moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
9,488 Commits 29 Branches 84 Tags 722 MiB
40a5e940c1
Commit Graph

3161 Commits

Author SHA1 Message Date
Dominik Stadler
511c2544a8 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad #60998 - HSLFTable.setRowHeight sets row height incorrect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 11:02:22 +00:00
Andreas Beeker
bd237e2483 #60996 - XSSF: Multiple embedded objects on same sheet are ignored 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-16 22:41:28 +00:00
Andreas Beeker
1f41c31984 Fix AIOOBE while extracting hssf pictures which are externally linked 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-10 21:43:22 +00:00
Dominik Stadler
0f193371ea Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 13:17:17 +00:00
Tim Allison
f426849947 bug 50955 convert Set to Singleton per Javen's code review 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 11:02:48 +00:00
Tim Allison
1bfd5f6585 bug 50955 and bug 60953 improve Big5 reader; ensure one character 
per byte pair

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 01:45:55 +00:00
Tim Allison
af51ea4c10 bug 50955 -- word 6.0 charset fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-04 02:06:46 +00:00
Tim Allison
69c3311a98 60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-20 20:47:15 +00:00
Dominik Stadler
eef36a1580 Fix typo to "length", closes #51 
Fix a few IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-19 20:30:04 +00:00
Dominik Stadler
e78eb68b10 60823: DGET function, correct behavior with multiple result entries but only one non-blank 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-19 20:29:55 +00:00
Greg Woolsey
6349d2c614 Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822. 
Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af Fix some Sonar issues in sample "HSSFReadWrite" 
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-13 14:09:27 +00:00
Dominik Stadler
c07c41659f HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-10 20:13:52 +00:00
Dominik Stadler
aafdbdfdd7 Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-10 20:13:39 +00:00
Javen O'Neal
5b879942fc bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-02 18:47:28 +00:00
Javen O'Neal
c04e2a314a bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8 add javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9 Add null check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-21 18:18:10 +00:00
Andreas Beeker
0744f73add BugFix for JDK-6623219 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-19 21:36:45 +00:00
Javen O'Neal
ee6677ee56 bug 59893: fix a few forgotten unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-17 09:25:49 +00:00
Javen O'Neal
8677d099fc bug 59893: commit the changes from attachment 34068 that were unrelated to available() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-17 08:39:05 +00:00
Greg Woolsey
ca399b4f42 Bug #56822 fix COUNTIFS() 
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b Bug #56822 fix COUNTIFS() 
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78 Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae Expose Priority from newer-style HSSF CF rules 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 17:49:13 +00:00
Greg Woolsey
05125678ab Expose another common property, strikeout. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 16:45:47 +00:00
Nick Burch
1e5fa0dbea Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 09:35:43 +00:00
Greg Woolsey
b0d0d0fda5 Add evaluation of data validation rules and conditional formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-13 22:51:30 +00:00
Andreas Beeker
967a3b0e0c #60625 - Rendering issue with background and shape overlayed by image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-12 22:30:49 +00:00
Andreas Beeker
db3000b142 SonarQube fixes and removed redundant logger level checks, for simple String messages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46 Add a possible future TODO 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 14:02:12 +00:00
Nick Burch
b6480adb9f If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5 Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 11:43:01 +00:00
Javen O'Neal
0f09e9eae2 bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 08:29:18 +00:00
Javen O'Neal
28999738a9 Convert all *.java files to use native end of line character(s) 
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 07:47:30 +00:00
Andreas Beeker
5c4ab1dbdf #60625 - Rendering issue with background and shape overlayed by image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 01:12:22 +00:00
Andreas Beeker
ac3d63926a #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 01:01:51 +00:00
Dominik Stadler
f431473f29 Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-05 22:34:40 +00:00
Dominik Stadler
560a33620a IntelliJ warnings, Javadoc, Formatting 
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-26 19:58:46 +00:00
Andreas Beeker
c48a0cf334 #59836 - Tracker: Replace primitives with enums 
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-22 22:01:22 +00:00
Javen O'Neal
9def800cd4 bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 05:35:57 +00:00
Javen O'Neal
c46e7d03f3 remove unused imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 05:04:57 +00:00
Javen O'Neal
dfd906aa9b bug 60605: remove code for enforcing rule that active sheet cannot be hidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:55:06 +00:00
Javen O'Neal
647f0a90a2 pull out loop invariants, use List.indexOf to look up sheet index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779560 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:38:18 +00:00
Javen O'Neal
15be6fb336 bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:23:42 +00:00
Javen O'Neal
47e81bd78c make instance variable final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779551 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 02:16:58 +00:00
Tim Allison
f6388c2fff Bug 60570 - Add rudimentary EMF read-only capability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-19 16:22:29 +00:00
Andreas Beeker
a7706b3fdf fix eclipse warnings - close resources / type generics 
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-15 23:08:47 +00:00
Andreas Beeker
5899f8884d #60586 - Support embedding OLE1.0 package in XSSF / SS Common 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778869 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-15 02:04:57 +00:00
Javen O'Neal
726fe10074 bug 60260: parse unicode sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-12 10:39:26 +00:00
Andreas Beeker
bf311b8e6e SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777855 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-08 00:38:41 +00:00
Andreas Beeker
24c0b83841 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777739 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-07 00:26:46 +00:00
Andreas Beeker
1042dacd93 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777669 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-06 17:51:22 +00:00
Andreas Beeker
9ee04feeb9 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-06 09:05:14 +00:00
Andreas Beeker
d7da7a0ff4 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777526 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-05 23:40:57 +00:00
Andreas Beeker
8cc9352d26 EmbeddedExtractor (for *SSF) - added OOXML support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777394 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-05 01:10:45 +00:00
Javen O'Neal
2680a535bd github-44: reference BuiltinFormats in javadocs for CellStyle.getDataFormat and setDataFormat 
This closes #44 github pull request from sixinli

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777260 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-04 07:00:24 +00:00
Andreas Beeker
8973c2fe07 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-04 01:06:30 +00:00
Andreas Beeker
97ea611e6e SonarQube fixes 
add Iterable interface to EscherContainerRecord / deprecate getChildIterator()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777046 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-03 01:02:33 +00:00
Javen O'Neal
ca0154a793 use case-insensitive string startsWith/endsWith utility function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-02 22:23:56 +00:00
Andreas Beeker
f2052fe278 Sonarqube fixes - Cast one of the operands of this multiplication operation to a ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-01 22:59:35 +00:00
Andreas Beeker
254b42ff26 #60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776820 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:54:32 +00:00
Andreas Beeker
1d9c74b1bf #60519 - Extractor for *SSF embeddings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:50:47 +00:00
Andreas Beeker
db4bdaf29a #60520 - Provide *SSF functionality via Common SS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776818 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:47:23 +00:00
Dominik Stadler
102c0d2173 Bug 60219: FormulaParser can't parse external references when sheet name is quoted 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 16:53:16 +00:00
Dominik Stadler
b2a4c75665 Fix some Findbugs reports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 09:43:08 +00:00
Dominik Stadler
36406ad3a1 Ensure streams are closed always, reformat code somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:12:06 +00:00
Dominik Stadler
6f616d0a51 Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:11:55 +00:00
Dominik Stadler
da2b7c0969 Fix some compilation warnings 
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:11:48 +00:00
Dominik Stadler
8def7307d9 Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input 
deprecate unused method isNonWorkday

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 15:05:14 +00:00
Dominik Stadler
b573615cd0 bug 60526: Make loggers final and make throttled log actually work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 13:09:28 +00:00
centic
a150527574 Add mising @Override and other warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776065 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-26 19:51:32 +00:00
kiwiwings
b4728919b9 report size of entries for POIFSViewer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775992 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-25 00:06:13 +00:00
kiwiwings
3ff9eb5f0d Fix 0-pointer on unset document 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775565 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-21 22:03:54 +00:00
centic
9a04e2dd07 Comments, Javadoc and make close() only log instead of throw an exception to not have catch inside catch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775118 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-19 15:03:58 +00:00
kiwiwings
c200faedec SonarQube fixes - close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774969 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-18 22:03:31 +00:00
kiwiwings
0ff9cbb0f9 #60331 - Remove deprecated classes (POI 3.16) 
- remove orphaned classes immediately, which are quite likely not used anymore
- deprecated the rest

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774842 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-18 03:26:13 +00:00
Andreas Beeker
f3674c3394 various sonarqube fixes - mainly resource closing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774705 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-17 02:35:30 +00:00
Andreas Beeker
4cc6e093f4 eclipse warnings - close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773910 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-13 00:36:03 +00:00
Andreas Beeker
4aaef1761d eclipse warnings - raw list access 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773909 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-13 00:34:30 +00:00
Dominik Stadler
230453d76e Adjust toString() of ExternalNameRecord 
Fix some IntelliJ warnings
 Reformat TextPieceTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773776 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-12 11:41:07 +00:00
Dominik Stadler
d4ae4b9cc6 Revert "Add more output to BiffViewer for local debugging" 
This reverts commit b6959b0d14b001ec374f60990671ff21bbcc24ec.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773685 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-11 21:15:20 +00:00
Dominik Stadler
b2b021bc32 Add more output to BiffViewer for local debugging 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773639 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-11 20:58:30 +00:00
Andreas Beeker
3cdf699add SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773165 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-07 23:45:38 +00:00
Andreas Beeker
83ff0e5ec4 Add "*" option to font_map/fallback to provide a catch-all configuration 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772816 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-06 00:21:22 +00:00
Andreas Beeker
75dc015766 SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772585 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-04 23:49:49 +00:00
Andreas Beeker
dcd8a53c64 regression #55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772485 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-03 20:32:08 +00:00
Andreas Beeker
656f28ba81 SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772291 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-01 23:46:27 +00:00
Andreas Beeker
48ff8e5686 sonarcube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771978 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-29 23:14:43 +00:00
Andreas Beeker
891e684eb7 #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771812 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-28 20:51:02 +00:00
Andreas Beeker
19842d1e58 javadocs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771672 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-28 01:18:48 +00:00
Andreas Beeker
6ea58e94bc #60331 - Remove deprecated classes - deprecate Mutable* property classes 
sonarcube fix - make protected attributes private

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-27 20:19:18 +00:00
Andreas Beeker
8968b6d6b6 SonarCube fixes - visibility of member attributes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771583 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-27 13:12:00 +00:00
Dominik Stadler
055630de2d Revert deprecating a class that we still use ourselves and update error text slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771395 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 22:07:52 +00:00
Dominik Stadler
ed975b0efa Include actual entries when we do not find a Document-entry 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771394 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 22:07:45 +00:00
Dominik Stadler
e2b22e51f7 Bug 59200: Check for actual Excel limits on data validation title/text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 08:55:52 +00:00
Andreas Beeker
ea63780926 Bug 60373 - TableCell.getTextHeight() returns Null pointer Exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1770447 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-18 23:29:53 +00:00
Andreas Beeker
44ca7f04ba SonarCube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769399 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-12 18:35:39 +00:00
Andreas Beeker
a6f005de81 SonarCube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769366 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-12 00:52:10 +00:00
Andreas Beeker
fc86b15f13 - SonarCube fixes 
- moved SecureTempFile classes to OOXML, because of duplicated code in test and examples packages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769363 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-11 23:22:43 +00:00
Andreas Beeker
3820215393 Bug 60345 - Handle corrupt PICT streams 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769226 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-10 23:04:25 +00:00
Dominik Stadler
76a0c6378e Add setFormattingRanges() to interface ConditionalFormatting, closes #42 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768588 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-07 21:32:04 +00:00
Nick Burch
7c9754a08d As requested on StackOverflow, expose on CellStyle QuotePrefix/123Prefix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768012 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-04 11:11:09 +00:00
Javen O'Neal
a3f001b7ae bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767728 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:37:12 +00:00
Javen O'Neal
cbc3f8599d bug 60331: remove deprecated EntryUtils.copyNodes( DirectoryEntry, DirectoryEntry, List<String> excepts). Use EntryUtils.copyNodes( FilteringDirectoryEntry, FilteringDirectoryEntry ) instead. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767716 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:25:18 +00:00
Javen O'Neal
6966eebb38 show example of equivalent EntryUtils.copyNodes using FilteringDirectoryNode instead of DirectoryNode with excepts list 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767715 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:22:04 +00:00
Andreas Beeker
9d3094f11f Handle null returns of coerceValueToBoolean 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767474 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-01 10:52:20 +00:00
Andreas Beeker
457100c358 Bug 60320 - issue opening password protected xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767399 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-01 01:30:48 +00:00
Andreas Beeker
423a49cbab Bug 60294 - Add "unknown" ShapeType for 4095 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766227 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-22 19:34:47 +00:00
Dominik Stadler
0610a20d87 Fix some IDE warnings, JavaDoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766063 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-21 16:31:37 +00:00
Tim Allison
d233f7c348 BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 15:13:16 +00:00
Javen O'Neal
96d35e0b8e Eclipse automated refactor/cleanup: convert for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 01:54:56 +00:00
Javen O'Neal
5d3d50b9d1 add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 23:04:16 +00:00
Tim Allison
5958cb4840 BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch. Problems are mine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 18:44:46 +00:00
Javen O'Neal
a73df78070 remove @deprecated annotation from Enum-returning getters. These will be deprecated after the int-returning getters are removed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765545 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 07:43:18 +00:00
Dominik Stadler
ec7607e398 Fix some IDE warnings/javadoc/... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765538 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 06:52:44 +00:00
Javen O'Neal
09c13eeefa on Windows, a directory cannot contain a file and a directory with the same name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765531 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:18:48 +00:00
Javen O'Neal
55252a9fe9 findbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform(Graphics2D) where default case is missing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765530 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:07:30 +00:00
Javen O'Neal
669e32e551 add data type to UTF_16LE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765529 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:06:49 +00:00
Javen O'Neal
fec5613aff remove java.nio.charset.StandardCharsets which is not available until Java 7 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765528 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:00:07 +00:00
Tim Allison
17d4d76f4f BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 18:24:39 +00:00
Tim Allison
92eb3bbade BUG 59858 -- avoid npe when there's a collision of record names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 16:43:20 +00:00
Tim Allison
c878e39b55 BUG 59830 -- incorrect reading of unicode stream name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 15:47:38 +00:00
Tim Allison
db79501e9f BUG 60158 -- AIOOBE in VBAMacroReader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 12:55:34 +00:00
Andreas Beeker
bf95861693 Bug 53191 - Problems with line style when converting ppt to png 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765196 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-16 22:48:25 +00:00
Dominik Stadler
37116e84e5 Bug 60029: apply suggested fix and fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-15 06:54:20 +00:00
Tim Allison
7f9f8e9afa add length sanity check for length of embedded OLE10Native (BUG 60256) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-14 14:57:29 +00:00
Javen O'Neal
1e5dc11721 bug 56781,60246: fix named range validation to match valid name rules per Excel docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-14 10:11:23 +00:00
Mark Murphy
37f9122633 53009: Problem creating header and footer 
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=53009

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764563 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-13 01:13:45 +00:00
Andreas Beeker
83bd292fff Bug 60230 - Roundtrip test that encrypts XSSFWorkbook and then decrypts it fails with latest code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764008 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 20:34:35 +00:00
Javen O'Neal
370aa27bf2 bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 10:59:34 +00:00
Javen O'Neal
e0fd36dfb4 bug 60021: add note that EncryptionInfo may require poi-ooxml.jar to run EncryptionModes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763944 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 05:40:38 +00:00
Javen O'Neal
dd1ed5b840 bug 60197: Workbook#setSheetOrder should update named range sheet indices 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 03:02:13 +00:00
Javen O'Neal
5b8cbb0143 bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-07 12:39:15 +00:00
Dominik Stadler
89f68a6a47 Bug 53028: Broken auto fit row height in the cells with word wrap 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:56 +00:00
Dominik Stadler
86eafd3c44 Some IDE warning fixes and unit test adjustments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:44 +00:00
Nick Burch
4ffc48f7f7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763399 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 10:39:03 +00:00
Mark Murphy
d106d31934 Add PropertyTemplate for drawing Borders (58787) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 02:23:52 +00:00
Nick Burch
48e338e828 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762875 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 10:22:27 +00:00
Javen O'Neal
c1a11dc0b8 bug 60187: set BorderStyle directly instead of through short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762859 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 07:02:02 +00:00
Javen O'Neal
d169bdc2f9 bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 06:39:29 +00:00
Andreas Beeker
d8767e1c70 Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 23:36:09 +00:00
Andreas Beeker
0a7cd3b68b merge trunk to branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 21:01:40 +00:00
Dominik Stadler
db79fe043c Adjust some JavaDoc and remove some unnecessary String.valueOf() calls and fix some other compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762617 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 08:44:14 +00:00
Javen O'Neal
43f7d5bfdc use equalsIgnoreCase for case-insensitive string comparisons 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-22 03:48:49 +00:00
Dominik Stadler
7e9cc96c46 Compiler/IDE warnings, unnecessary keywords, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 05:45:57 +00:00
Javen O'Neal
7e3f2ca8d1 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761669 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 03:57:22 +00:00
Javen O'Neal
deed3aa8d6 bug 57200,59788: be more specific why a temporary directory could not be created 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761667 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 03:19:31 +00:00
Javen O'Neal
2be1834545 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761665 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:45:39 +00:00
Javen O'Neal
ad8506b7f5 bug 59933: demote accessibility of NullLogger methods to the same level as POILogger 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761662 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:12:54 +00:00
Javen O'Neal
b44d6ec062 make POILogFactory _loggers cache final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761660 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:05:58 +00:00
Javen O'Neal
92d0f35c84 bug 59933: override POILogger#log(int, Object...) in NullLogger 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761657 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 01:41:54 +00:00
Dominik Stadler
c669e2ef67 Adjust handling of ByteBuffer some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-20 20:24:54 +00:00
Andreas Beeker
cda4f20482 merge trunk to branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-19 00:20:44 +00:00
Javen O'Neal
008a26d1bf bug 59705: consolidate bounds checking of column index into a helper method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-16 00:32:40 +00:00
Tim Allison
0784ab530a POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-15 00:19:52 +00:00
Javen O'Neal
91f2d5680e declare methods throw runtime exceptions for IDE hints 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 21:32:34 +00:00
Nick Burch
41b0462f50 Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 15:01:57 +00:00
Nick Burch
5fc5680d15 Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 14:59:00 +00:00
Javen O'Neal
ed7258906f move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 07:53:58 +00:00
Javen O'Neal
8842d7bffd move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 07:33:20 +00:00
Javen O'Neal
f71ae8036d bug 59791: add deprecation and removal annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 06:42:20 +00:00
Javen O'Neal
b0f814f83f bug 59791: add deprecation warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 06:22:38 +00:00
Javen O'Neal
9a11b0ffd5 bug 59791: add deprecation and removal annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:51:52 +00:00
Javen O'Neal
430ea9abfd bug 58190: add @since annotations to SlideShow.addPicture and findPicture 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:41:40 +00:00
Javen O'Neal
ca78ec2878 bug 58671: add @Removal annotation to deprecated fields 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760632 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:31:48 +00:00
Javen O'Neal
38cd94d676 bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:22:23 +00:00
Javen O'Neal
292d7ec27c bug 59264: revert getBorder[Top|Bottom|Left|Right|Diagonal]() to return short and add getBorder[Top|Bottom|Left|Right|Diagonal]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760627 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 04:35:45 +00:00
Javen O'Neal
2644cae418 bug 59790: add @Removal annotations to deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760624 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:51:45 +00:00
Javen O'Neal
5d1ae2cbae bug 59833: add @Removal annotation to deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:33:52 +00:00
Javen O'Neal
6839a52aa3 bug 59837,59833,59264: add @Removal annotations to CellStyle constants for which enums now exist 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760622 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:24:15 +00:00
Javen O'Neal
808996a683 bug 59873: add @Removal annotations for deprecated CreationHelper#createHyperlink(int) and Hyperlink static aliases to HyperlinkType enum values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760621 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:17:51 +00:00
Javen O'Neal
b91b5c5715 bug 59907: add @Removal annotations to AnchorType static aliases in ClientAnchor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760620 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:06:51 +00:00
Javen O'Neal
9ea5915313 bug 59907: add @Removal annotations to deprecated ClientAnchor#setAnchorType(int) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760619 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 02:55:52 +00:00
Javen O'Neal
0977e51818 bug 59907: restore ClientAnchor#setAnchorType(int) that was removed in POI 3.14 beta 1 and broke backwards compatibility without a 2 release deprecation notice 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760617 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 02:41:01 +00:00
Javen O'Neal
3c97d9700a change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-13 23:24:56 +00:00
Javen O'Neal
adfd0d7f6c bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760219 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-11 03:37:56 +00:00
Tim Allison
5747e871a1 poi-60044 small typo in last update to BuiltinFormats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760102 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-09 18:41:37 +00:00
Javen O'Neal
9665b9859a bug 59791: add @Removal tags to Cell.CELL_TYPE_* constants, deprecated by CellType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757239 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-22 18:25:45 +00:00
Javen O'Neal
3f4612ffcb bug 59791: improve Cell.CELL_TYPE_* backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757235 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-22 17:57:45 +00:00
Andreas Beeker
9521546156 add encryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756964 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-19 20:23:16 +00:00
Andreas Beeker
5a486ec7c8 forgot cryptoapi encryption flags 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755541 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 21:00:10 +00:00
Andreas Beeker
680683cf77 merge down trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 01:14:36 +00:00
Andreas Beeker
0bfefdfc04 HSSF CryptoAPI decryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755461 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 00:10:44 +00:00
Nick Burch
f8bc502028 Whitespace, javadocs and @Overrides for the Logger classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-04 14:23:54 +00:00
Andreas Beeker
c4ac2e7758 Preparations for hssf_cryptoapi: 
- Add cloneable
- Change existing hslf cryptoapi to streaming


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755127 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 23:54:01 +00:00
Nick Burch
a1f6d9c832 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:53:43 +00:00
Nick Burch
60b2586c3f Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:42:04 +00:00
Nick Burch
560ff4004e Whitespace / indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:15:13 +00:00
Nick Burch
1570d79529 Whitespace / indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:12:50 +00:00
Javen O'Neal
3c77adf9e8 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 17:36:06 +00:00
David North
984683ab4b Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 12:51:24 +00:00
Javen O'Neal
5ddd038640 javadoc fix: incorrect deprecated replacement 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 05:32:41 +00:00
Mark Murphy
20907fc5b4 revert changes made in r1754691 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 04:21:14 +00:00
Mark Murphy
8c0adfe55f correction to junit bugs in r1754691 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 02:53:55 +00:00
Nick Burch
0fe7cd5299 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 00:17:33 +00:00
Mark Murphy
504a26b844 Add new class Cell Style Template and supporting enum for drawing borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 23:59:02 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 17:19:27 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods. 
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-29 13:24:00 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-24 11:38:50 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 10:27:27 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:31:57 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:09:33 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:35:51 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:14:05 +00:00
Nick Burch
d84df31b50 #57919 Start on support for writing to a new File (faster than OutputStream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:07:29 +00:00
Javen O'Neal
50d1788d3d bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-19 08:02:41 +00:00
Javen O'Neal
ebbcd10034 bug 59881: fix spelling; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 18:25:28 +00:00
Dominik Stadler
abc3072df2 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30 Some warnings/improvements suggested by IntelliJ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 09:34:59 +00:00
Dominik Stadler
0bf845e0cc 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:27 +00:00
Dominik Stadler
da9cd94e76 Fix one more place where stream were left open when an exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:12 +00:00
Dominik Stadler
da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ... 
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:07 +00:00
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:33:32 +00:00
Javen O'Neal
056a8dac84 reduce statement complexity in drawContent, also has fewer FLOPS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:29:34 +00:00
Javen O'Neal
ec4a47df73 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:27:57 +00:00
Javen O'Neal
9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:25:37 +00:00
Nick Burch
cf6d3489e0 #57919 Provide an initial in-place write method for HSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 19:02:58 +00:00
Javen O'Neal
d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow 
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 13:25:02 +00:00
Javen O'Neal
bc91641444 bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 11:56:13 +00:00
Javen O'Neal
b3300cf4be HexDump.writeHex is similar to Long#toHexString. Consider consolidating. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:22:43 +00:00
Javen O'Neal
7637cdc080 bug 59873: javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:48:36 +00:00
Javen O'Neal
31f2b5fdd1 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:32:29 +00:00
Dominik Stadler
16b0c380c9 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:27:07 +00:00
Javen O'Neal
c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:20:21 +00:00
Javen O'Neal
efbfef84a6 make private maps final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:29:40 +00:00
Javen O'Neal
f296b55b36 add @Override annotations to CreationHelper classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:14:49 +00:00
Javen O'Neal
14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 05:47:03 +00:00
Javen O'Neal
44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 04:41:20 +00:00
Dominik Stadler
af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-16 20:52:39 +00:00
Javen O'Neal
064abfa59a replace for-loop over index with for-each loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:41:26 +00:00
Javen O'Neal
6ea74f170d annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:25:16 +00:00
Javen O'Neal
0c3aade7b1 JDK8 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:35:21 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s) 
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5 bug 59858: describe why VBA macro reading failed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:12:37 +00:00
David North
a7d210932a "cannot not" presumably means "cannot" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-13 16:40:47 +00:00
Dominik Stadler
7beffbe3e3 Fix name of new OLE2ScratchpadExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-12 15:40:18 +00:00
Nick Burch
90e8b0f5b0 Last bit of reflection - get back to the full OOXML-enabled factory if we can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:57:42 +00:00
Nick Burch
4643b2ade0 Exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:53:22 +00:00
Nick Burch
7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:47:02 +00:00
Nick Burch
a5fb04f45f Pull Scratchpad Extractor logic to own class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:27:02 +00:00
Nick Burch
ed7940dee5 Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:20:51 +00:00
Javen O'Neal
2ec6b12e13 bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 11:18:55 +00:00
Javen O'Neal
0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 08:29:02 +00:00
Javen O'Neal
847d90603a javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:54:36 +00:00
Javen O'Neal
79fac1f707 bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:52:16 +00:00
Andreas Beeker
cd349946a0 javadocs fixes (jdk8) 
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 18:52:26 +00:00
Javen O'Neal
44f0a6a66a add 2^x to POWER2 comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:54:07 +00:00
Javen O'Neal
e563dee47c bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:51:57 +00:00
Javen O'Neal
d8c65c777e bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:18:29 +00:00
Javen O'Neal
76dde0aed5 bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:05:43 +00:00
Javen O'Neal
ca22a79e01 close streams if an exception is throw 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 06:30:12 +00:00
Javen O'Neal
909c07f37f bug 59830: add context to why no more bytes could be read from input stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 05:39:56 +00:00
Javen O'Neal
a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 22:28:28 +00:00
Javen O'Neal
3092c1121e bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 18:45:15 +00:00
Javen O'Neal
4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:20:34 +00:00
Javen O'Neal
bb7da64c25 add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:00:07 +00:00
Javen O'Neal
dd32e6b5b5 add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:46:06 +00:00
Javen O'Neal
85def647c9 whitespace (3sp to 4sp) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751839 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:38:09 +00:00
Javen O'Neal
2e142f4d6a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751838 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:29:28 +00:00
Javen O'Neal
38c052cca1 add @Override annotations to spreadsheet formula Evaluation classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:27:32 +00:00
Javen O'Neal
9539c626a9 bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:22:10 +00:00
Javen O'Neal
b45a65e667 bug 59805: avoid memory leaks if time zone or locale are never set or user never resets the time zone or locale; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 01:10:24 +00:00
Javen O'Neal
5cbd7552eb findbugs: replace switch statement with fall-throughs with if statement, remove duplicate code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751738 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 00:48:52 +00:00
Javen O'Neal
1766825f62 bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 09:23:34 +00:00
Javen O'Neal
0390a566a5 bug 59805: make LocaleUtil a static class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751601 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 05:40:53 +00:00
Javen O'Neal
78801432ed bug 59804: javadoc update 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751574 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:33:31 +00:00
Javen O'Neal
b37fde6d96 +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:26:32 +00:00
Javen O'Neal
93f1f4b027 bug 59804: indicate when features were @Internal-ized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:22:49 +00:00
Javen O'Neal
f78b266d73 bug 59804: add since attribute to @Internal annotation; add @Removal annotation to track when features will be removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751569 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:01:05 +00:00
Andreas Beeker
05cecde4a5 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751568 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 22:57:50 +00:00
Andreas Beeker
3ef17caad7 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751387 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 23:45:19 +00:00
Javen O'Neal
18f2e5e405 typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751372 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 19:00:35 +00:00
Javen O'Neal
45f209e58c mark BitField as internal use only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751371 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:50:26 +00:00
Javen O'Neal
eb6488585a bug 59790,59791: add @since javadoc annotation to FormulaType and CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751287 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:49:44 +00:00
Javen O'Neal
be49e0c5a7 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:09:30 +00:00
Javen O'Neal
03671fea80 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:35:49 +00:00
Javen O'Neal
268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:21:42 +00:00
Javen O'Neal
034d3cfcca bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 11:54:20 +00:00
Javen O'Neal
fba65665fb reorganize imports (remove unused imports, sort alphabetically) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 10:38:25 +00:00
Javen O'Neal
64ef8e26a3 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.* 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 10:15:18 +00:00
Javen O'Neal
d1d6ea97fb bug 59791: convert Cell Type to an enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 09:45:46 +00:00
Javen O'Neal
8df4c77647 bug 59790: convert FormulaType class to enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 05:37:06 +00:00
Javen O'Neal
6605ff96ab javadocs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751209 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 05:00:55 +00:00
Javen O'Neal
d358c2a0ab bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 03:06:11 +00:00
Javen O'Neal
9208fc384e rearrange JavaDocs to match constructor ordering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751197 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 02:58:38 +00:00
Javen O'Neal
909b428443 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751195 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 02:14:02 +00:00
Javen O'Neal
954306ea2e bug 59773: replace for loops with for-each loops; javadocs fixes for JDK8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751193 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:49:28 +00:00
Javen O'Neal
8329fc22f5 add missing ASL license header from bug 59788 comment 2 r1751185 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751192 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:28:19 +00:00
Javen O'Neal
f972e1c6e4 bug 59166: suggest alternative implementations for TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:07:52 +00:00
Javen O'Neal
569db169dd bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 00:00:20 +00:00
Andreas Beeker
b56b2497d0 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751184 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:38:06 +00:00
Javen O'Neal
0e118a7b6d bug 59788: create temporary directories 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:58:06 +00:00
Andreas Beeker
1781e9d83f deprecated DrawingManager 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:21:55 +00:00
Andreas Beeker
8e84226202 #59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 21:54:17 +00:00
Andreas Beeker
6899a1ad95 javadocs fixes (jdk8) 
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 18:25:05 +00:00
Javen O'Neal
33cf815199 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 07:20:47 +00:00
Javen O'Neal
73fcbfdb68 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 18:28:43 +00:00
Javen O'Neal
4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 09:00:13 +00:00
Javen O'Neal
1aa3511d0c findbugs: remove switch statement fall-through and move default switch to bottom 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751034 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:20:14 +00:00
Javen O'Neal
e31aa190a8 deprecate o.a.p.hssf.util.AreaReference as it shadows o.a.p.ss.util.AreaReference (findbugs) and provides no additional functionality 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751021 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:43:21 +00:00
Javen O'Neal
d7900beec3 findbugs: DocumentInputStream.skip(long) result not checked; close DocumentInputStream even if exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751020 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:39:53 +00:00
Javen O'Neal
6645d8a80f whitespace and +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751019 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:28:41 +00:00
Andreas Beeker
c985706686 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-01 21:10:40 +00:00
Andreas Beeker
6eab79528b a few performance fixes to speed-up the tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 22:59:46 +00:00
Andreas Beeker
099f63d054 deprecated constants pointing to MissingCellPolicy - use enum instead 
javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 23:31:12 +00:00
Andreas Beeker
85f22291be Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 22:04:12 +00:00
Javen O'Neal
fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 21:39:44 +00:00
Andreas Beeker
c88ba795a0 javadoc fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749794 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:26:08 +00:00
Nick Burch
fdb7c7d1ff Provide an alternate method to get the OLE2 thumbnail that decodes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749526 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:26:28 +00:00
Javen O'Neal
0f3a7b24b4 bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 11:27:40 +00:00
Javen O'Neal
b617f3ccec bug 56781: disallow names with symbols, except underscore, period, and backslash 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:27:52 +00:00
Javen O'Neal
4036202ebc add comments, adjust whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749276 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:50:36 +00:00
Javen O'Neal
f3bd334002 whitespace (tabs to spaces); +svnprop svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749274 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:15:56 +00:00
Javen O'Neal
40727700f4 bug 59731: start migrating methods relating to row-shifting in HSSFSheet to HSSFRowShifter; consolidate with XSSFRowShifter into RowShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749262 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 04:16:32 +00:00
Javen O'Neal
ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 03:40:32 +00:00
Javen O'Neal
0ec8b3a88e bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749248 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 02:02:08 +00:00
Javen O'Neal
55cb9381de bug 56454: deprecate shiftMerged with unused parameter, move loop-invariant out of for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749247 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:49:46 +00:00
Javen O'Neal
015cf4c86f object-oriented methods are preferred over utility classes for discoverability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749245 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:25:23 +00:00
Javen O'Neal
8dc7ee659d bug 59729: update CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749243 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:55:51 +00:00
Javen O'Neal
970626a88e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749241 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:28:19 +00:00
Javen O'Neal
8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39 bug 56454: add CellRangeAddress#containsRow and containsColumn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:16:41 +00:00
Andreas Beeker
3a4754de98 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749238 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:08:11 +00:00
Javen O'Neal
778fa8aa3d bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749226 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 23:02:43 +00:00
Andreas Beeker
3a72eea5c5 Regression fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749224 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:43:24 +00:00
Javen O'Neal
b9e9b0d41d bug 56958: slightly improve performance when checking array formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:24:17 +00:00
Nick Burch
7da9b2cd67 #59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:13:41 +00:00
Nick Burch
b7b990f56f #59724 Provide Closeable on all OLE2-based POIDocument types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749213 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:12:55 +00:00
Javen O'Neal
492aac4e73 bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9 bug 59645: add Page Setup Print row and column headings support for Common SS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 18:20:23 +00:00
Javen O'Neal
8240a8ab5d update javadoc for clarification about non-literal lists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 06:23:57 +00:00
Andreas Beeker
bec4c45c59 findbugs fixes - ME_MUTABLE_ENUM_FIELD 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 01:06:55 +00:00
Javen O'Neal
d8d821b1f2 add unit test for HSSFWorkbook.getSelectedTabs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 02:37:24 +00:00
Javen O'Neal
acac716a64 bug 59718: deprecate get/setBoldweight. Use get/setBold 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 01:21:08 +00:00
Javen O'Neal
59d1dc095b bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 01:06:53 +00:00
Javen O'Neal
be7fd6ffb6 FunctionEval is a utility class. It should not have a public default constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748830 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 10:47:13 +00:00
Javen O'Neal
19a0cc12fa bug 59279: add Comment.equals and hashCode methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 08:56:10 +00:00
Javen O'Neal
6ea5e99ce4 move loop invariant outside of loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748809 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 07:59:01 +00:00
Javen O'Neal
7a66ac346f bug 59170: add version when deprecated 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748793 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:35:44 +00:00
Javen O'Neal
7b14a48436 bug 59170: deprecate o.a.p.hssf.model.PictureShape 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748792 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:31:27 +00:00
Javen O'Neal
0472d9d861 bug 55385: deprecate Font.getBoldweight and Font.setBoldweight 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-16 06:51:53 +00:00