moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
9,488 Commits 29 Branches 84 Tags 722 MiB
40a5e940c1
Commit Graph

3161 Commits

Author SHA1 Message Date
PJ Fanning
5ef2f1636c Numeric Array Formula and Matrix Function [from Bob95132] This closes #69 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808297 13f79535-47bb-0310-9956-ffa450edef68
 2017-09-13 23:54:36 +00:00
Greg Woolsey
914ae602b1 Fixes bug #61468, caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-29 17:14:52 +00:00
Dominik Stadler
20fa8328f4 Verify that bug 61294 is fixed now, add some more coverage for IOUtils in general 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806162 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-25 11:51:18 +00:00
Dominik Stadler
2108f82449 Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-19 16:31:45 +00:00
Greg Woolsey
5e5adc70e5 Bug 61431 - Conditional formatting evaluation ignores undefined cells 
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.

Added unit test based on previously failing file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-16 23:52:27 +00:00
Andreas Beeker
6f341568b6 #61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-11 20:47:48 +00:00
Dominik Stadler
c7e1fabf1c Reformat code slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803612 13f79535-47bb-0310-9956-ffa450edef68
 2017-08-01 06:26:27 +00:00
Andreas Beeker
97f90ca839 Fix further Windows JVM 6 font rendering errors - OOM and EXCEPTION_ACCESS_VIOLATION 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803528 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-31 12:25:23 +00:00
Andreas Beeker
27fd9e4cbb remove invalid javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803493 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-31 08:42:48 +00:00
Nick Burch
e34e286850 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803488 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-31 06:36:10 +00:00
Andreas Beeker
ff2bcdf62d #61363 - Unify escher shape id allocation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803483 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-30 23:11:36 +00:00
Greg Woolsey
e1f37388fc Fix data validation value list evaluation 
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.

However, data validation list formulas explicitly are expected to return a 2D ValueEval.  This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.

This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.

There is room for discussion over how it is implemented, but this works for me.

Includes the failing workbook we had as a new unit test.

While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 22:19:58 +00:00
Tim Allison
16f331054f 61337 -- try to convert assertions to exceptions. I left in the assertions for the binary search components. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803092 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 18:43:27 +00:00
Tim Allison
21cbf101bc 61346 add more sanity checks before allocating byte arrays in emf/wmf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803041 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-26 12:46:24 +00:00
Tim Allison
df3910135f 61295 -- prevent potential oom in HPSF triggered by fuzzed file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802879 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-25 01:38:35 +00:00
Andreas Beeker
2325cdb9e6 Bug 61331 - Font group handling / common font interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-23 22:45:47 +00:00
Dominik Stadler
8a95a71a48 My version of Java 6 chokes on Generics here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802633 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-21 18:19:29 +00:00
PJ Fanning
810d03f499 javadoc: replace invalid self enclosing elements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-17 08:24:24 +00:00
PJ Fanning
9b3812d027 some javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802035 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-15 22:31:09 +00:00
Tim Allison
408e236553 bug 61300 -- prevent really long (infinite?) loop on corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801989 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 20:47:40 +00:00
Tim Allison
93b1f0664c bug 61286/bug 61287 -- allow WriteProtectRecord to have 2 bytes, and allow for HeaderFooter to be empty. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801966 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 13:54:06 +00:00
Tim Allison
c7db66a30d bug 61294 -- cleaned up based on PJ Fanning's code review. Went with a copy/paste from commons-io. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801952 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-14 12:48:28 +00:00
Tim Allison
278a235b08 bug 61294 -- prevent infinite loop in IOUtils' skipFully. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801844 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 16:20:28 +00:00
Javen O'Neal
2b0ded5cb3 replace commented-out throw-away code that writes workbook to C:\temp\xxxxx.xlsx for manual review with XSSFTestDataSamples.writeOut(wb, "bug xxxxx for manual review") 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801801 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 04:19:20 +00:00
Javen O'Neal
dc869e5e4a replace return variable assignments with return statements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801799 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 03:42:12 +00:00
Javen O'Neal
08a624f172 github #43: fix roundUp and roundDown. 
Thanks to @FishMeat on github for the patch.
This closes #43 on github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801798 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-13 03:35:06 +00:00
PJ Fanning
748e0c4981 remove more deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801697 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-12 08:38:20 +00:00
PJ Fanning
e046241c30 [Bug-61268] avoid NegativeArraySizeException parsing doc file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801395 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 22:32:27 +00:00
PJ Fanning
9225a961a3 fix spelling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801393 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 21:34:53 +00:00
Nick Burch
05c7c16308 #61266 Test for old unsupported MS Write WRI files, and give a more helpful exception if found, plus unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801376 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 16:26:33 +00:00
Andreas Beeker
0cac9103ba Rollback of r1801368 because of a generics bug with self-referenced types in Java6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801373 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 15:27:29 +00:00
Andreas Beeker
04ffc95da7 SL Common: narrow generics definition because of tighter java9 checks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801368 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-09 11:09:45 +00:00
Andreas Beeker
377615e9cd #61169 - Text with Japanese characters overflows textbox 
- add resize methods with Graphics argument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801329 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-08 22:20:55 +00:00
PJ Fanning
23567cd3a0 [github-25] support excel number trailing comma format - Thabks to Luca Martini for proving the patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800975 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-06 07:56:57 +00:00
PJ Fanning
a0aa8807b5 [Bug 58975] do not cast numberOfOperands to byte in AbstractFunctionPtg 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800949 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-05 22:56:32 +00:00
PJ Fanning
a33eef41a0 fix javadoc issue 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800717 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-03 22:18:25 +00:00
PJ Fanning
86f7d0b896 [Bug 60422] fix data formatter issue with specific format in German locale 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800713 13f79535-47bb-0310-9956-ffa450edef68
 2017-07-03 20:56:02 +00:00
Andreas Beeker
a09a3398cc #61243 - Refactor and unify toString/toXml in DDF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800452 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 20:21:33 +00:00
PJ Fanning
cbb15b1efa Remove more deprecated code (MissingCellPolicy) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800400 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 13:00:57 +00:00
PJ Fanning
05d8c18a58 Remove more deprecated code (BorderFormatting constants) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800385 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 12:18:13 +00:00
PJ Fanning
ee70c9a8fb Remove more deprecated code (especially from Spreadsheet Cell classes) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-30 11:48:23 +00:00
PJ Fanning
2ec623fe0b remove deprecated org.apache.poi.hssf.record.RecordFormatException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800256 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 09:06:30 +00:00
PJ Fanning
af35e389da remove some unused imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:55:35 +00:00
PJ Fanning
1281127420 remove deprecated org.apache.poi.hssf.record.RecordFormatException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800249 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:37:02 +00:00
PJ Fanning
4bcc0f4eb1 Remove old XSSFPaswordHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-29 08:10:32 +00:00
Nick Burch
b3149fe1ad Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800214 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 23:30:15 +00:00
Nick Burch
a658a7f573 Used deprecated external method removed, so remove internal method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800211 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 23:25:41 +00:00
PJ Fanning
5c65b55bd4 Ensure SpreadsheetVersion is set for AreaReferences 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 22:11:26 +00:00
PJ Fanning
4209a1b2da Remove some deprecated *SSF APIs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-28 10:34:37 +00:00
PJ Fanning
03d4e52bc0 expand StaxHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 13:53:47 +00:00
PJ Fanning
61b0ecbd4b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-24 07:30:07 +00:00
Greg Woolsey
0e23e4e9d8 Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-23 15:43:48 +00:00
Greg Woolsey
8c67848ad6 Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor 
This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799643 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-23 05:16:38 +00:00
Tim Allison
649280df8c bug 61045 -- allow for (and log!) extra bytes in FormatRecord. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 18:11:34 +00:00
Javen O'Neal
c0e5fcaa98 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799332 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 09:52:43 +00:00
Nick Burch
4a51090ae7 Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799320 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 09:04:02 +00:00
Javen O'Neal
171692edf2 bug 57919: close opened resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799316 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 08:13:58 +00:00
Javen O'Neal
46b5d839c3 bug 57919: add functions to write and close a POIDocument, guaranteeing closure of the output stream and document. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799308 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 07:28:14 +00:00
Javen O'Neal
4d692223bb whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799303 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 05:51:48 +00:00
Javen O'Neal
5de40d3261 bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799302 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-20 05:47:56 +00:00
Dominik Stadler
66bf6c5ad7 Need to do the casting differently to make the code compile with Java 6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799038 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-18 05:59:31 +00:00
Dominik Stadler
bac17be565 Fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799035 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-18 05:59:11 +00:00
Andreas Beeker
0e57435abe #61169 - Text with Japanese characters overflows textbox 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798986 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-17 00:00:49 +00:00
Andreas Beeker
14b2d4501a #61162 - En-/decryption support for HWPF 
- encryption support for HWPF
- refactor/unify EncryptionInfo handling in H**F classes
- remove Iterable interface from WorkbookRecordList - use getRecords() instead, to prevent modifications over the Iterator

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798722 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-14 17:21:50 +00:00
Greg Woolsey
e5c5cba87c Standardize some more common chart axis properties. 
Implement the ChartAxis ss interface for date axes, which are pretty much a category axis with one extra property, a date granularity (not currently passed through, get it still from the CT* class).  Created the class and test from the category axis versions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798414 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-12 05:38:41 +00:00
Dominik Stadler
05570364db Move one testcase with incorrect source location 
remove some junit dependencies in example-code
build: do not pass junit-jar to normal compile targets to avoid introducing it as dependency again 
Reformat code, fix warnings, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798202 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-09 12:49:01 +00:00
Andreas Beeker
20dcde37ec Handle encrypted files with known password in integration tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797839 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-06 22:21:46 +00:00
Andreas Beeker
2b4f944883 #61162 - En-/decryption support for HWPF 
Decryption for Binary RC4 and CryptoAPI (... XOR is missing)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797837 13f79535-47bb-0310-9956-ffa450edef68
 2017-06-06 22:21:11 +00:00
Javen O'Neal
4232a72208 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796966 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-31 02:46:24 +00:00
Greg Woolsey
7e6007e0bd #61085 support table styles 
Needed a bit more, to support table/range only border properties for "internal" vertical and horizontal borders.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796961 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-31 00:22:58 +00:00
Andreas Beeker
49e47cb6e1 Bug 61119 - Fix preset shape rendering and shading 
- Fixed conversion of ooxml to awt angle
- replace subclasses and reflection calls with enums
- implemented tinting/shading of preset shapes


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796823 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-30 09:33:28 +00:00
Javen O'Neal
b3c6907741 bug 61059: fix NamePtg to read unsigned shorts instead of signed shorts, avoiding a AIOOBE when a workbook contains more than 32k Names. Thanks to Travis Burtrum for the patch. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796466 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-28 01:17:16 +00:00
Greg Woolsey
586cf38f1c Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color 
teach XSSFColor and most things that create instances about indexed colors.

Null is a valid value for IndexedColorMap instances - the existing built-in default colors are used.

Whenever a workbook style is accessible in the call hierarchy its color mappings are passed down now.

Thanks for the unit test in the issue, it now passes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796359 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-26 23:14:48 +00:00
Dominik Stadler
d868026959 Bug 61063: Add a RefListEval to handle UnionPtg and implement it for Rank(), may be missing for other functions where ArrayEval is currently handled 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795963 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-23 21:13:02 +00:00
Javen O'Neal
7881d05743 github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795681 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-20 21:04:14 +00:00
Javen O'Neal
4ff23197e9 bug 61110: remove deprecated, misspelled CellReference#isRowWithnRange and #isColumnWithnRange methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795680 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-20 20:22:24 +00:00
Greg Woolsey
2d2aa5196a #61085 support table styles 
Added more features - this allows a client app to fully display table styling without resorting to CT* classes, and has some helper logic for the additional processing needed for things like regional/area borders.

As far as I can tell I only added stuff, didn't change any existing behavior.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795648 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-20 04:05:32 +00:00
Javen O'Neal
0b767886bf replace "String.indexOf(String) >= 1" with "String.contains(String)" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795296 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-16 10:53:15 +00:00
Javen O'Neal
b6f78f8d57 github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication. Thanks to Daniel Kuan! This closes #32. 
https://github.com/apache/poi/pull/32

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795266 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-16 03:18:17 +00:00
Nick Burch
fec503f1de Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795261 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-16 02:50:35 +00:00
Andreas Beeker
8c1346b138 Add ASL header and exclude table preset from rat-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795137 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-15 06:30:06 +00:00
Andreas Beeker
90dca20bd2 #52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates 
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-14 22:25:33 +00:00
Greg Woolsey
0cdc064b0c git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68 2017-05-12 18:01:32 +00:00
Dominik Stadler
e77156d9f4 Simplify the ValueEval.toString() implementations and include more information on unexpected types of ValueEval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794956 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-12 11:38:05 +00:00
Greg Woolsey
6bca07a15f forgot license (as always) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794093 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-05 18:33:49 +00:00
Greg Woolsey
18d107d974 61060 - teach DataFormatter about conditional formatting rules with number formats 
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-05 17:44:58 +00:00
Andreas Beeker
ad72f60ab6 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-03 22:16:26 +00:00
Andreas Beeker
76dbb5a1eb HPSF: Change CustomProperties to delegate 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-03 19:18:45 +00:00
Andreas Beeker
d0630390d2 Remove Unicode chars in comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793647 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-03 14:08:04 +00:00
Andreas Beeker
0f78f6dc1f fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793604 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-03 00:14:55 +00:00
Andreas Beeker
cd6236c74b #52372 - OutOfMemoryError parsing a word file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-02 23:32:13 +00:00
Andreas Beeker
eeb697001f HPSF: Add CopyCompare to IntegrationTests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-02 23:29:19 +00:00
Andreas Beeker
3a1771ced1 HPSF: Enable new number types in VariantSupport 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-02 23:28:00 +00:00
Andreas Beeker
456b33a837 Fix hpsf javadocs and code issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-02 23:27:27 +00:00
Andreas Beeker
63b88fec6a HPSF: Use LittleEndianStream instead of offset calculation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793594 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-02 23:24:50 +00:00
Javen O'Neal
95538eb815 bug 61059: add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793418 13f79535-47bb-0310-9956-ffa450edef68
 2017-05-01 21:51:34 +00:00
Dominik Stadler
5265ff6f81 Improve information contained in exception in CellRangeAddress() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-30 09:12:44 +00:00
Tim Allison
5f567f29a1 bug 61049 fix ordering of builtin formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-27 16:18:25 +00:00
Greg Woolsey
6e0a5916b5 Fix bug #61007 
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.

Send what was checked previously plus only multi-segment conditional range formats.  Allows existing tests to pass plus the new test with the case for these conditional formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8 Fix bug #61007 
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel.  Also added tests for the failing formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-19 18:10:52 +00:00
Dominik Stadler
511c2544a8 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad #60998 - HSLFTable.setRowHeight sets row height incorrect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-17 11:02:22 +00:00
Andreas Beeker
bd237e2483 #60996 - XSSF: Multiple embedded objects on same sheet are ignored 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-16 22:41:28 +00:00
Andreas Beeker
1f41c31984 Fix AIOOBE while extracting hssf pictures which are externally linked 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-10 21:43:22 +00:00
Dominik Stadler
0f193371ea Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 13:17:17 +00:00
Tim Allison
f426849947 bug 50955 convert Set to Singleton per Javen's code review 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 11:02:48 +00:00
Tim Allison
1bfd5f6585 bug 50955 and bug 60953 improve Big5 reader; ensure one character 
per byte pair

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-05 01:45:55 +00:00
Tim Allison
af51ea4c10 bug 50955 -- word 6.0 charset fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
 2017-04-04 02:06:46 +00:00
Tim Allison
69c3311a98 60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-20 20:47:15 +00:00
Dominik Stadler
eef36a1580 Fix typo to "length", closes #51 
Fix a few IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-19 20:30:04 +00:00
Dominik Stadler
e78eb68b10 60823: DGET function, correct behavior with multiple result entries but only one non-blank 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-19 20:29:55 +00:00
Greg Woolsey
6349d2c614 Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822. 
Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af Fix some Sonar issues in sample "HSSFReadWrite" 
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-13 14:09:27 +00:00
Dominik Stadler
c07c41659f HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-10 20:13:52 +00:00
Dominik Stadler
aafdbdfdd7 Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-10 20:13:39 +00:00
Javen O'Neal
5b879942fc bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
 2017-03-02 18:47:28 +00:00
Javen O'Neal
c04e2a314a bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8 add javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9 Add null check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-21 18:18:10 +00:00
Andreas Beeker
0744f73add BugFix for JDK-6623219 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-19 21:36:45 +00:00
Javen O'Neal
ee6677ee56 bug 59893: fix a few forgotten unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-17 09:25:49 +00:00
Javen O'Neal
8677d099fc bug 59893: commit the changes from attachment 34068 that were unrelated to available() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-17 08:39:05 +00:00
Greg Woolsey
ca399b4f42 Bug #56822 fix COUNTIFS() 
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b Bug #56822 fix COUNTIFS() 
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78 Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae Expose Priority from newer-style HSSF CF rules 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 17:49:13 +00:00
Greg Woolsey
05125678ab Expose another common property, strikeout. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 16:45:47 +00:00
Nick Burch
1e5fa0dbea Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-14 09:35:43 +00:00
Greg Woolsey
b0d0d0fda5 Add evaluation of data validation rules and conditional formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-13 22:51:30 +00:00
Andreas Beeker
967a3b0e0c #60625 - Rendering issue with background and shape overlayed by image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-12 22:30:49 +00:00
Andreas Beeker
db3000b142 SonarQube fixes and removed redundant logger level checks, for simple String messages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46 Add a possible future TODO 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 14:02:12 +00:00
Nick Burch
b6480adb9f If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5 Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-10 11:43:01 +00:00
Javen O'Neal
0f09e9eae2 bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 08:29:18 +00:00
Javen O'Neal
28999738a9 Convert all *.java files to use native end of line character(s) 
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 07:47:30 +00:00
Andreas Beeker
5c4ab1dbdf #60625 - Rendering issue with background and shape overlayed by image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 01:12:22 +00:00
Andreas Beeker
ac3d63926a #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-08 01:01:51 +00:00
Dominik Stadler
f431473f29 Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68
 2017-02-05 22:34:40 +00:00
Dominik Stadler
560a33620a IntelliJ warnings, Javadoc, Formatting 
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-26 19:58:46 +00:00
Andreas Beeker
c48a0cf334 #59836 - Tracker: Replace primitives with enums 
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-22 22:01:22 +00:00
Javen O'Neal
9def800cd4 bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 05:35:57 +00:00
Javen O'Neal
c46e7d03f3 remove unused imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 05:04:57 +00:00
Javen O'Neal
dfd906aa9b bug 60605: remove code for enforcing rule that active sheet cannot be hidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:55:06 +00:00
Javen O'Neal
647f0a90a2 pull out loop invariants, use List.indexOf to look up sheet index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779560 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:38:18 +00:00
Javen O'Neal
15be6fb336 bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 04:23:42 +00:00
Javen O'Neal
47e81bd78c make instance variable final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779551 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-20 02:16:58 +00:00
Tim Allison
f6388c2fff Bug 60570 - Add rudimentary EMF read-only capability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-19 16:22:29 +00:00
Andreas Beeker
a7706b3fdf fix eclipse warnings - close resources / type generics 
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-15 23:08:47 +00:00
Andreas Beeker
5899f8884d #60586 - Support embedding OLE1.0 package in XSSF / SS Common 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778869 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-15 02:04:57 +00:00
Javen O'Neal
726fe10074 bug 60260: parse unicode sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-12 10:39:26 +00:00
Andreas Beeker
bf311b8e6e SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777855 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-08 00:38:41 +00:00
Andreas Beeker
24c0b83841 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777739 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-07 00:26:46 +00:00
Andreas Beeker
1042dacd93 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777669 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-06 17:51:22 +00:00
Andreas Beeker
9ee04feeb9 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-06 09:05:14 +00:00
Andreas Beeker
d7da7a0ff4 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777526 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-05 23:40:57 +00:00
Andreas Beeker
8cc9352d26 EmbeddedExtractor (for *SSF) - added OOXML support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777394 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-05 01:10:45 +00:00
Javen O'Neal
2680a535bd github-44: reference BuiltinFormats in javadocs for CellStyle.getDataFormat and setDataFormat 
This closes #44 github pull request from sixinli

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777260 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-04 07:00:24 +00:00
Andreas Beeker
8973c2fe07 SonarQube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-04 01:06:30 +00:00
Andreas Beeker
97ea611e6e SonarQube fixes 
add Iterable interface to EscherContainerRecord / deprecate getChildIterator()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777046 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-03 01:02:33 +00:00
Javen O'Neal
ca0154a793 use case-insensitive string startsWith/endsWith utility function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-02 22:23:56 +00:00
Andreas Beeker
f2052fe278 Sonarqube fixes - Cast one of the operands of this multiplication operation to a ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68
 2017-01-01 22:59:35 +00:00
Andreas Beeker
254b42ff26 #60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776820 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:54:32 +00:00
Andreas Beeker
1d9c74b1bf #60519 - Extractor for *SSF embeddings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:50:47 +00:00
Andreas Beeker
db4bdaf29a #60520 - Provide *SSF functionality via Common SS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776818 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 21:47:23 +00:00
Dominik Stadler
102c0d2173 Bug 60219: FormulaParser can't parse external references when sheet name is quoted 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 16:53:16 +00:00
Dominik Stadler
b2a4c75665 Fix some Findbugs reports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-31 09:43:08 +00:00
Dominik Stadler
36406ad3a1 Ensure streams are closed always, reformat code somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:12:06 +00:00
Dominik Stadler
6f616d0a51 Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:11:55 +00:00
Dominik Stadler
da2b7c0969 Fix some compilation warnings 
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 22:11:48 +00:00
Dominik Stadler
8def7307d9 Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input 
deprecate unused method isNonWorkday

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 15:05:14 +00:00
Dominik Stadler
b573615cd0 bug 60526: Make loggers final and make throttled log actually work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-30 13:09:28 +00:00
centic
a150527574 Add mising @Override and other warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776065 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-26 19:51:32 +00:00
kiwiwings
b4728919b9 report size of entries for POIFSViewer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775992 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-25 00:06:13 +00:00
kiwiwings
3ff9eb5f0d Fix 0-pointer on unset document 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775565 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-21 22:03:54 +00:00
centic
9a04e2dd07 Comments, Javadoc and make close() only log instead of throw an exception to not have catch inside catch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775118 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-19 15:03:58 +00:00
kiwiwings
c200faedec SonarQube fixes - close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774969 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-18 22:03:31 +00:00
kiwiwings
0ff9cbb0f9 #60331 - Remove deprecated classes (POI 3.16) 
- remove orphaned classes immediately, which are quite likely not used anymore
- deprecated the rest

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774842 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-18 03:26:13 +00:00
Andreas Beeker
f3674c3394 various sonarqube fixes - mainly resource closing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774705 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-17 02:35:30 +00:00
Andreas Beeker
4cc6e093f4 eclipse warnings - close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773910 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-13 00:36:03 +00:00
Andreas Beeker
4aaef1761d eclipse warnings - raw list access 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773909 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-13 00:34:30 +00:00
Dominik Stadler
230453d76e Adjust toString() of ExternalNameRecord 
Fix some IntelliJ warnings
 Reformat TextPieceTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773776 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-12 11:41:07 +00:00
Dominik Stadler
d4ae4b9cc6 Revert "Add more output to BiffViewer for local debugging" 
This reverts commit b6959b0d14b001ec374f60990671ff21bbcc24ec.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773685 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-11 21:15:20 +00:00
Dominik Stadler
b2b021bc32 Add more output to BiffViewer for local debugging 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773639 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-11 20:58:30 +00:00
Andreas Beeker
3cdf699add SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773165 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-07 23:45:38 +00:00
Andreas Beeker
83ff0e5ec4 Add "*" option to font_map/fallback to provide a catch-all configuration 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772816 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-06 00:21:22 +00:00
Andreas Beeker
75dc015766 SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772585 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-04 23:49:49 +00:00
Andreas Beeker
dcd8a53c64 regression #55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772485 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-03 20:32:08 +00:00
Andreas Beeker
656f28ba81 SonarCube fix - make members private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772291 13f79535-47bb-0310-9956-ffa450edef68
 2016-12-01 23:46:27 +00:00
Andreas Beeker
48ff8e5686 sonarcube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771978 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-29 23:14:43 +00:00
Andreas Beeker
891e684eb7 #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771812 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-28 20:51:02 +00:00
Andreas Beeker
19842d1e58 javadocs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771672 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-28 01:18:48 +00:00
Andreas Beeker
6ea58e94bc #60331 - Remove deprecated classes - deprecate Mutable* property classes 
sonarcube fix - make protected attributes private

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-27 20:19:18 +00:00
Andreas Beeker
8968b6d6b6 SonarCube fixes - visibility of member attributes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771583 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-27 13:12:00 +00:00
Dominik Stadler
055630de2d Revert deprecating a class that we still use ourselves and update error text slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771395 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 22:07:52 +00:00
Dominik Stadler
ed975b0efa Include actual entries when we do not find a Document-entry 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771394 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 22:07:45 +00:00
Dominik Stadler
e2b22e51f7 Bug 59200: Check for actual Excel limits on data validation title/text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-25 08:55:52 +00:00
Andreas Beeker
ea63780926 Bug 60373 - TableCell.getTextHeight() returns Null pointer Exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1770447 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-18 23:29:53 +00:00
Andreas Beeker
44ca7f04ba SonarCube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769399 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-12 18:35:39 +00:00
Andreas Beeker
a6f005de81 SonarCube fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769366 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-12 00:52:10 +00:00
Andreas Beeker
fc86b15f13 - SonarCube fixes 
- moved SecureTempFile classes to OOXML, because of duplicated code in test and examples packages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769363 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-11 23:22:43 +00:00
Andreas Beeker
3820215393 Bug 60345 - Handle corrupt PICT streams 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1769226 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-10 23:04:25 +00:00
Dominik Stadler
76a0c6378e Add setFormattingRanges() to interface ConditionalFormatting, closes #42 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768588 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-07 21:32:04 +00:00
Nick Burch
7c9754a08d As requested on StackOverflow, expose on CellStyle QuotePrefix/123Prefix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768012 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-04 11:11:09 +00:00
Javen O'Neal
a3f001b7ae bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767728 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:37:12 +00:00
Javen O'Neal
cbc3f8599d bug 60331: remove deprecated EntryUtils.copyNodes( DirectoryEntry, DirectoryEntry, List<String> excepts). Use EntryUtils.copyNodes( FilteringDirectoryEntry, FilteringDirectoryEntry ) instead. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767716 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:25:18 +00:00
Javen O'Neal
6966eebb38 show example of equivalent EntryUtils.copyNodes using FilteringDirectoryNode instead of DirectoryNode with excepts list 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767715 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-02 16:22:04 +00:00
Andreas Beeker
9d3094f11f Handle null returns of coerceValueToBoolean 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767474 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-01 10:52:20 +00:00
Andreas Beeker
457100c358 Bug 60320 - issue opening password protected xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767399 13f79535-47bb-0310-9956-ffa450edef68
 2016-11-01 01:30:48 +00:00
Andreas Beeker
423a49cbab Bug 60294 - Add "unknown" ShapeType for 4095 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766227 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-22 19:34:47 +00:00
Dominik Stadler
0610a20d87 Fix some IDE warnings, JavaDoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766063 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-21 16:31:37 +00:00
Tim Allison
d233f7c348 BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 15:13:16 +00:00
Javen O'Neal
96d35e0b8e Eclipse automated refactor/cleanup: convert for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-20 01:54:56 +00:00
Javen O'Neal
5d3d50b9d1 add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 23:04:16 +00:00
Tim Allison
5958cb4840 BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch. Problems are mine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 18:44:46 +00:00
Javen O'Neal
a73df78070 remove @deprecated annotation from Enum-returning getters. These will be deprecated after the int-returning getters are removed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765545 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 07:43:18 +00:00
Dominik Stadler
ec7607e398 Fix some IDE warnings/javadoc/... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765538 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 06:52:44 +00:00
Javen O'Neal
09c13eeefa on Windows, a directory cannot contain a file and a directory with the same name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765531 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:18:48 +00:00
Javen O'Neal
55252a9fe9 findbugs: Switch statement found in org.apache.poi.sl.draw.DrawShape.applyTransform(Graphics2D) where default case is missing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765530 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:07:30 +00:00
Javen O'Neal
669e32e551 add data type to UTF_16LE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765529 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:06:49 +00:00
Javen O'Neal
fec5613aff remove java.nio.charset.StandardCharsets which is not available until Java 7 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765528 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-19 05:00:07 +00:00
Tim Allison
17d4d76f4f BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 18:24:39 +00:00
Tim Allison
92eb3bbade BUG 59858 -- avoid npe when there's a collision of record names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 16:43:20 +00:00
Tim Allison
c878e39b55 BUG 59830 -- incorrect reading of unicode stream name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 15:47:38 +00:00
Tim Allison
db79501e9f BUG 60158 -- AIOOBE in VBAMacroReader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-18 12:55:34 +00:00
Andreas Beeker
bf95861693 Bug 53191 - Problems with line style when converting ppt to png 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765196 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-16 22:48:25 +00:00
Dominik Stadler
37116e84e5 Bug 60029: apply suggested fix and fix some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-15 06:54:20 +00:00
Tim Allison
7f9f8e9afa add length sanity check for length of embedded OLE10Native (BUG 60256) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-14 14:57:29 +00:00
Javen O'Neal
1e5dc11721 bug 56781,60246: fix named range validation to match valid name rules per Excel docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-14 10:11:23 +00:00
Mark Murphy
37f9122633 53009: Problem creating header and footer 
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=53009

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764563 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-13 01:13:45 +00:00
Andreas Beeker
83bd292fff Bug 60230 - Roundtrip test that encrypts XSSFWorkbook and then decrypts it fails with latest code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764008 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 20:34:35 +00:00
Javen O'Neal
370aa27bf2 bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 10:59:34 +00:00
Javen O'Neal
e0fd36dfb4 bug 60021: add note that EncryptionInfo may require poi-ooxml.jar to run EncryptionModes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763944 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 05:40:38 +00:00
Javen O'Neal
dd1ed5b840 bug 60197: Workbook#setSheetOrder should update named range sheet indices 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 03:02:13 +00:00
Javen O'Neal
5b8cbb0143 bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-07 12:39:15 +00:00
Dominik Stadler
89f68a6a47 Bug 53028: Broken auto fit row height in the cells with word wrap 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:56 +00:00
Dominik Stadler
86eafd3c44 Some IDE warning fixes and unit test adjustments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:44 +00:00
Nick Burch
4ffc48f7f7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763399 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 10:39:03 +00:00
Mark Murphy
d106d31934 Add PropertyTemplate for drawing Borders (58787) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 02:23:52 +00:00
Nick Burch
48e338e828 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762875 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 10:22:27 +00:00
Javen O'Neal
c1a11dc0b8 bug 60187: set BorderStyle directly instead of through short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762859 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 07:02:02 +00:00
Javen O'Neal
d169bdc2f9 bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 06:39:29 +00:00
Andreas Beeker
d8767e1c70 Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 23:36:09 +00:00
Andreas Beeker
0a7cd3b68b merge trunk to branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 21:01:40 +00:00
Dominik Stadler
db79fe043c Adjust some JavaDoc and remove some unnecessary String.valueOf() calls and fix some other compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762617 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 08:44:14 +00:00
Javen O'Neal
43f7d5bfdc use equalsIgnoreCase for case-insensitive string comparisons 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-22 03:48:49 +00:00