Commit Graph

1628 Commits

Author SHA1 Message Date
Dominik Stadler a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Dominik Stadler da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Javen O'Neal 9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:25:37 +00:00
Javen O'Neal d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:25:02 +00:00
Javen O'Neal 7637cdc080 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:48:36 +00:00
Javen O'Neal 4d33ceffb1 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:44:26 +00:00
Javen O'Neal 2944b7a7a8 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:42:13 +00:00
Javen O'Neal c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:20:21 +00:00
Javen O'Neal 0025b16e3e add cause to exceptions, log exceptions that are caught and suppressed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:41:52 +00:00
Javen O'Neal 1cf76af9e8 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:26:51 +00:00
Javen O'Neal f296b55b36 add @Override annotations to CreationHelper classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:14:49 +00:00
Javen O'Neal 4a8e7c393d throw exception if hyperlink is invalid type when validating hyperlink
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 06:04:56 +00:00
Javen O'Neal 14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:47:03 +00:00
Javen O'Neal 285bedac9e bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:43:03 +00:00
Javen O'Neal 44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Andreas Beeker 11fe2eda86 #59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 00:14:06 +00:00
Dominik Stadler af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Dominik Stadler 52bf709104 Add a test to check for a NullPointerException in XSLFTableCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:11 +00:00
Javen O'Neal 9d8b7b33db JDK8 javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 10:13:58 +00:00
Javen O'Neal 0c3aade7b1 JDK8 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:35:21 +00:00
Nick Burch 439fc2e92d Remove un-used imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 23:00:40 +00:00
Nick Burch 7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:47:02 +00:00
Nick Burch f94e7e761b Notes on use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:17:34 +00:00
Javen O'Neal 0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 08:29:02 +00:00
Javen O'Neal ba1e2c8b14 Add comments describing Outlook .msg DirectoryNode names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:41:15 +00:00
Javen O'Neal fbf2d524f9 move string literals out to array that can be for-looped over
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:29:30 +00:00
Javen O'Neal a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 22:28:28 +00:00
Javen O'Neal 9c00c18f38 bug 56154: rename setLastModifiedBy to setLastModifiedByUser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:05:02 +00:00
Javen O'Neal ed4ae3fff0 bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:59:01 +00:00
Javen O'Neal 182c1415f5 bug 56154: get and set last modified by user property; patch from Danil Lopatin
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:56:54 +00:00
Javen O'Neal 92c2fa753d add crude unit test for ZipPackagePropertiesMarshaller
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 09:10:03 +00:00
Javen O'Neal 4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:20:34 +00:00
Javen O'Neal 38c052cca1 add @Override annotations to spreadsheet formula Evaluation classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 22:27:32 +00:00
Javen O'Neal 9539c626a9 bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 22:22:10 +00:00
Javen O'Neal 6f566fca27 whitespace; +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751744 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:27:13 +00:00
Javen O'Neal 81f13bb621 Findbugs-JDK8: log ignored exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751743 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:25:42 +00:00
Javen O'Neal 56d11479de bug 50795: move hack to avoid xmlbeans corrupt pointer to its own function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751742 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:19:02 +00:00
Javen O'Neal b37fde6d96 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 23:26:32 +00:00
Javen O'Neal 93f1f4b027 bug 59804: indicate when features were @Internal-ized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 23:22:49 +00:00
Nick Burch 90e4babfc1 #59780 OPC support for a wider range of timezone'd created and modified date formats in package properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751379 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 20:55:07 +00:00
Javen O'Neal 24faa602e0 bug 59796: XSSFTable#getRowCount off-by-one error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751373 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 19:09:10 +00:00
Javen O'Neal f0f37b58ed pre for-each iteration over for index iteration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751369 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:43:45 +00:00
Javen O'Neal 31efeb44b7 bug 59795: add method to synchronize start and stop cell references with CTTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751368 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:25:00 +00:00
Javen O'Neal be49e0c5a7 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 13:09:30 +00:00
Javen O'Neal 03671fea80 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:35:49 +00:00
Javen O'Neal 268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal 034d3cfcca bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal fba65665fb reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal 64ef8e26a3 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal d1d6ea97fb bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal 8df4c77647 bug 59790: convert FormulaType class to enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 05:37:06 +00:00
Andreas Beeker 6899a1ad95 javadocs fixes (jdk8)
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 18:25:05 +00:00
Javen O'Neal 33cf815199 bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 07:20:47 +00:00
Andreas Beeker 76c479ce28 javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751106 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 23:08:07 +00:00
Javen O'Neal 73fcbfdb68 bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 18:28:43 +00:00
Javen O'Neal 4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Javen O'Neal b11ee3f7da don't shadow drawing field from XSSFShape in XSSFGraphicFrame
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:40:50 +00:00
Javen O'Neal ac84cdb773 findbugs: remove implements Cloneable declaration from classes that don't implement a clone method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:30:34 +00:00
Javen O'Neal 4dd2ff6c7c findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751023 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:11:01 +00:00
Javen O'Neal e7ef961359 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751022 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:01:43 +00:00
Andreas Beeker c985706686 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 21:10:40 +00:00
Javen O'Neal b2f4150b06 bug 59776: don't swallow cause of exception in ZipPackagePropertiesMashaller exception handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750893 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 09:14:41 +00:00
Nick Burch 520f4fbf76 #59766 Need to catch Errors as well when trying to tweak SAX stuff
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750408 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 19:57:33 +00:00
Andreas Beeker 099f63d054 deprecated constants pointing to MissingCellPolicy - use enum instead
javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 23:31:12 +00:00
Javen O'Neal fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 21:39:44 +00:00
Andreas Beeker a3718f8166 common-crawl-regression-fix: fallback to higher template level for default font, in case the style reference can't be determined
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750034 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 00:12:25 +00:00
Nick Burch 05f704d112 #59746 XSSF support for files from certain alternate tools where the row XML is missing the row number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749971 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 18:59:48 +00:00
Andreas Beeker 0341823c5c #59743 - ZipSecureFile throwing "zip bomb detected" exception when writing SXSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749799 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 00:23:51 +00:00
Andreas Beeker 89fb94e67d sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749795 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 22:27:53 +00:00
Andreas Beeker c88ba795a0 javadoc fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749794 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 22:26:08 +00:00
Nick Burch bfa702ed88 XSLFPictureData support for TIFF images - patch and tests from bug #59742 from Jens Popp
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749732 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 16:18:36 +00:00
Nick Burch 4eb8175d88 Fix inconsistent whitespace and indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749530 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 14:34:12 +00:00
Nick Burch 631ca92c16 #59717 POIXMLProperties helper methods for reading and changing OOXML document thumbnails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749528 13f79535-47bb-0310-9956-ffa450edef68
2016-06-21 14:27:41 +00:00
Javen O'Neal 0f3a7b24b4 bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 11:27:40 +00:00
Javen O'Neal b617f3ccec bug 56781: disallow names with symbols, except underscore, period, and backslash
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:27:52 +00:00
Javen O'Neal 44d8e4a2cb bug 59719: add unit test and comments/javadocs from Greg Woolsey for XSSFDataVAlidationConstraint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749265 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 05:01:21 +00:00
Javen O'Neal 40727700f4 bug 59731: start migrating methods relating to row-shifting in HSSFSheet to HSSFRowShifter; consolidate with XSSFRowShifter into RowShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749262 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 04:16:32 +00:00
Javen O'Neal ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:40:32 +00:00
Javen O'Neal 0ec8b3a88e bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749248 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 02:02:08 +00:00
Javen O'Neal 8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Andreas Beeker 3a4754de98 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749238 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:08:11 +00:00
Javen O'Neal b9e9b0d41d bug 56958: slightly improve performance when checking array formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:24:17 +00:00
Javen O'Neal 895bcab9f9 bug 59645: add Page Setup Print row and column headings support for Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00
Javen O'Neal 8240a8ab5d update javadoc for clarification about non-literal lists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:23:57 +00:00
Javen O'Neal 3eb3df8d35 use fully qualified name for Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749132 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:16:23 +00:00
Javen O'Neal 3d15bb8f65 add unit test for bug 59719
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:10:50 +00:00
Javen O'Neal e930c44e2d bug 59719: parse static list text properly; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749129 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 04:43:53 +00:00
Andreas Beeker e1241ed975 #59702 - Setting background color in slide master
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749108 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 23:48:00 +00:00
Javen O'Neal acac716a64 bug 59718: deprecate get/setBoldweight. Use get/setBold
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:21:08 +00:00
Javen O'Neal 59d1dc095b bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:06:53 +00:00
Javen O'Neal 21e8ce5979 bug 59432: move loop invariants outside the loop to marginally improve code execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748832 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 11:06:58 +00:00
Javen O'Neal 26d3072b1e bug 56958: validate array formulas wasn't correctly checking for overlap with a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748829 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:22:09 +00:00
Javen O'Neal 19a0cc12fa bug 59279: add Comment.equals and hashCode methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:56:10 +00:00
Javen O'Neal c3833b5ce7 bug 59170: remove deprecated o.a.p.xwpf.model.XWPFHyperlinkDecorator class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748780 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 00:20:48 +00:00
Javen O'Neal d7fc37b2db bug 59170: remove deprecated o.a.p.openxml4j.opc.internal.CnotentType#getParameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748778 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 23:52:54 +00:00
Javen O'Neal 0472d9d861 bug 55385: deprecate Font.getBoldweight and Font.setBoldweight
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 06:51:53 +00:00
Javen O'Neal 4243208ade bug 59170: remove deprecated XSSFExcelExtractor(String)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748495 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 04:26:14 +00:00
Javen O'Neal 9b217ab2da bug 59170: remove deprecated o.a.p.openxml4j.opc.Package
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748494 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 04:22:49 +00:00
Javen O'Neal 7228082d6b bug 59170: remove deprecated XSSFFontFormatting#getXSSFColor that was deprecated in 3.13 beta 1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748493 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 04:22:26 +00:00
Javen O'Neal ff3ccad347 add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748491 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 04:08:56 +00:00
Javen O'Neal ea30ed25b4 bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748482 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:56:56 +00:00
Javen O'Neal 07c65c3fc4 bug 57840: add comments for explicit boxing performance optimization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748479 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 01:42:11 +00:00
Andreas Beeker f83ff6f8ce javadoc fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 23:08:13 +00:00
Andreas Beeker d8437d0476 reverted changes of r1747942 and deprecated instead
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 21:18:50 +00:00
Javen O'Neal e4e4cbb71e findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:02:33 +00:00
Javen O'Neal 64ae6dc0ff findbugs: fix SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:38:53 +00:00
Javen O'Neal 6c5cd8e400 findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:34:02 +00:00
Javen O'Neal b148307f0f findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:06:47 +00:00
Javen O'Neal 1853126f9b findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:42:59 +00:00
Andreas Beeker 1ace43ba9f javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 19:54:35 +00:00
Andreas Beeker 0ef5f1d292 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 16:57:15 +00:00
Andreas Beeker 6a6aa540eb revert back to changes of bug 57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 00:54:01 +00:00
Andreas Beeker 81d891921b findbugs fixes
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 00:12:22 +00:00
Javen O'Neal 9e54ef68cb bug 57840: lazily compute hashCode; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 11:40:30 +00:00
Dominik Stadler 9880040b1b Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 08:45:41 +00:00
Javen O'Neal ed3364b6d2 bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:28:21 +00:00
Javen O'Neal 69ded5b7b0 whitespace (tabs to spaces); +props svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:12:43 +00:00
Javen O'Neal e3beb3abdd bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 02:10:32 +00:00
Javen O'Neal 6d03eafcfe bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 01:48:37 +00:00
Javen O'Neal 44c9a66906 remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:51:12 +00:00
Javen O'Neal 3ff5a7669f fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:42:33 +00:00
Javen O'Neal cd4058fd60 bug 57840: initialize the column header cache with 50% empty space
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 00:38:42 +00:00
Javen O'Neal c8627bb8b2 bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:45:14 +00:00
Javen O'Neal 71e3aa52fd bug 57840: add unit test for XSSFTable.findColumnIndex
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 18:10:52 +00:00
Javen O'Neal a6f21296cc bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:13:45 +00:00
Javen O'Neal 97adda6169 +props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747752 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:12:28 +00:00
Javen O'Neal 95df2cc417 whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747638 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 05:38:10 +00:00
Javen O'Neal 068bb510be bug 57840: add javadocs (warn about stale XSSFTable cache), remove rowIndex argument from calls to FormulaParser.parse(String, FormulaParsingWorkbook, FormulaType, int sheetIndex) when rowIndex is irrelevant, clear xmlColumnPr and commonXPath during updateHeaders so that users have a mechanism to clear invalidated cached values
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747627 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 04:20:41 +00:00
Javen O'Neal 1c2b9b3103 whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747625 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 02:51:45 +00:00
Javen O'Neal 3732a24a42 bug 57840: check for null to avoid NPE; add unit test for XSSFWorkbook.getTable()
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747621 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 01:52:08 +00:00
Javen O'Neal 1817337056 bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747616 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 01:08:05 +00:00
Javen O'Neal 5b983791aa bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747615 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 01:02:05 +00:00
Javen O'Neal 588c19e9d3 whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747614 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 00:26:39 +00:00
Javen O'Neal 83abda843a bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747612 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 00:21:59 +00:00
Andreas Beeker 6e477490f9 #59686 - Error when trying to access XSLFTableCell properties like textHeight, lineWidth, etc.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747605 13f79535-47bb-0310-9956-ffa450edef68
2016-06-09 23:06:42 +00:00
Andreas Beeker a749f7f3f5 sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747093 13f79535-47bb-0310-9956-ffa450edef68
2016-06-06 23:54:29 +00:00
Andreas Beeker 9b05849946 PPTX2PNG - don't complain about missing output dir, when in testing mode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746893 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 10:18:14 +00:00
Andreas Beeker bd2b438ee1 Regression fix for XSLF
- master style was always overridden, because of r1745100
- AIOOB in TextDirection mapping

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746858 13f79535-47bb-0310-9956-ffa450edef68
2016-06-05 01:04:58 +00:00
Andreas Beeker d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
2016-06-04 22:53:00 +00:00
Nick Burch 52537ae58e Add disabled test for XWPF writing to a new stream when opened read-only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746653 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 22:59:47 +00:00
Dominik Stadler 1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:14:28 +00:00
Dominik Stadler 6b6aa56455 Avoid NPE in XWPFTableCell, taken from https://github.com/prasad-babu/poi/tree/WORKING_BRANCH
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746625 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:09:44 +00:00
Dominik Stadler 505e695099 Bug 57838: Also remove comments when removing a row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746062 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:47 +00:00
Dominik Stadler a2bd714e55 Update error message to better indicate that we need a sample-file here
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746061 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 21:33:39 +00:00
Andreas Beeker 334ec509fa fix handling of hsl and linear rgb (%-values)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 23:39:23 +00:00
Andreas Beeker 592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 23:58:07 +00:00
Andreas Beeker dae1a761fd XSLF: remove creation of empty paragraph in XSLFTextShape.addNewTextParagraph()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745100 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 23:57:14 +00:00
Dominik Stadler e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
2016-05-22 16:08:51 +00:00
Andreas Beeker e5393711b7 fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744797 13f79535-47bb-0310-9956-ffa450edef68
2016-05-20 21:02:49 +00:00
Dominik Stadler ae32e5f677 Fix some compiler warnings, close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744636 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 20:18:19 +00:00
Dominik Stadler 2e4095deeb Apply patch for bug 59355: XSSFPivotTable::addColumnLabel sets the cell type of a cell outside of the source data area
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744635 13f79535-47bb-0310-9956-ffa450edef68
2016-05-19 20:18:08 +00:00
Andreas Beeker eb111ce81f findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 23:34:52 +00:00
Dominik Stadler 0c78005743 Bug 59427: Add a check to better report cases when a document is already closed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 19:08:34 +00:00
Andreas Beeker e28fff0423 ignore external relations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
2016-05-17 07:23:34 +00:00
Andreas Beeker 61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 21:04:00 +00:00
Andreas Beeker 73108582a0 deprecation fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:09:52 +00:00
Andreas Beeker 1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:09:22 +00:00
Andreas Beeker 20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 10:01:36 +00:00
Andreas Beeker 84be4acea9 Dispose XmlCursor
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
2016-05-16 09:54:01 +00:00
Andreas Beeker 401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
2016-05-13 23:50:39 +00:00
Javen O'Neal 730641576a bug 59443: exit early on setAddress if address is the same
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:46:14 +00:00
Javen O'Neal 191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:25:29 +00:00
Javen O'Neal 70459401a3 bug 59443: add get/setAddress methods on cell comment class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 05:09:41 +00:00
Javen O'Neal e9bfa9da87 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:53:55 +00:00
Andreas Beeker f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
2016-05-08 13:28:11 +00:00
Dominik Stadler 61f84af565 Try to print out more information if the timestamp-operation fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:44 +00:00
Dominik Stadler 8908412e3a Some general code-fixes found while trying out Java 9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
2016-05-05 12:22:31 +00:00
Andreas Beeker f688ed96c6 #59327 - Setting text direction on a table cell has no effect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
2016-05-04 22:09:10 +00:00
Javen O'Neal 556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:17:04 +00:00
Javen O'Neal dca380f057 reformat exclude classes regular expression for OOXMLLite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 20:02:17 +00:00
Javen O'Neal ec84916a9f bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:39:36 +00:00
Javen O'Neal 4d4b54b7c8 bug 59342: add sheet tab color getter and setter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 07:38:15 +00:00
Javen O'Neal 393ccc1873 fix Sonar warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 22:44:28 +00:00
Javen O'Neal ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 18:48:31 +00:00
Javen O'Neal a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
2016-04-12 12:03:24 +00:00
Javen O'Neal f49047e733 add @NotImplemented annotation to methods that are not implemented
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 21:28:41 +00:00
Dominik Stadler 2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
2016-04-10 09:40:40 +00:00
Tim Allison a060c664a1 close fileinputstream on second exception in ZipPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
2016-04-08 14:36:05 +00:00
Dominik Stadler 62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Javen O'Neal c95f6a4b35 whitespace (tabs to 4 spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:47:41 +00:00
Javen O'Neal fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 23:30:37 +00:00
Javen O'Neal e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 21:38:55 +00:00
Javen O'Neal 1786767b89 bug 59264: use BorderStyle for changing Cell border line style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
2016-04-05 20:28:46 +00:00
Dominik Stadler e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:56 +00:00
Dominik Stadler 328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
2016-04-02 11:01:43 +00:00
Nick Burch 29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 07:17:04 +00:00
Tim Allison 26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
2016-04-01 00:57:56 +00:00
Dominik Stadler d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
2016-03-31 13:32:05 +00:00
Dominik Stadler 992adb9c16 Revert set of inadvertedly committed files/changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler f5332a3a40 Bug 58915: Add note about memory consumption and update changelog
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:27:20 +00:00
Dominik Stadler 0888ad4de5 Fix some compiler warnings, improve error message, cover some more code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 15:45:04 +00:00
Andreas Beeker 4eeffd0532 XSLF: do not display Master Slide objects by default
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:52:01 +00:00
Andreas Beeker f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:49:45 +00:00
Dominik Stadler 8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:20:29 +00:00
Javen O'Neal 01b20a6567 make OPCPackage logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
2016-03-27 05:01:02 +00:00
Javen O'Neal f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 17:29:00 +00:00
Javen O'Neal 4fe9f0bcab make private member variable ctColor final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
2016-03-24 06:37:34 +00:00
Javen O'Neal 784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
2016-03-23 16:42:04 +00:00
Javen O'Neal e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00