moparisthebest
/
poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-06-13 07:02:33 +00:00
parent 64ae6dc0ff
commit e4e4cbb71e
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
View File

@ -27,11 +27,12 @@ import org.apache.poi.ss.util.CellRangeAddressList;
* Helper for working with Data Validation
*/
public class HSSFDataValidationHelper implements DataValidationHelper {
//URF_UNREAD_FIELD
// Findbugs: URF_UNREAD_FIELD . Do not delete without understanding how this class works.
//private HSSFSheet sheet;
public HSSFDataValidationHelper(HSSFSheet sheet) {
super();
// Findbugs: URF_UNREAD_FIELD . Do not delete without understanding how this class works.
//this.sheet = sheet;
}

2
src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
View File

@ -48,7 +48,7 @@ public class HSSFTextbox extends HSSFSimpleShape {
super(spContainer, objRecord, textObjectRecord);
}
//Unused: URF_UNREAD_FIELD
// Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
//HSSFRichTextString string = new HSSFRichTextString("");
/**

3
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
View File

@ -35,12 +35,13 @@ import org.openxmlformats.schemas.spreadsheetml.x2006.main.STDataValidationType;
*
*/
public class XSSFDataValidationHelper implements DataValidationHelper {
//Unused: URF_UNREAD_FIELD
// Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
//private XSSFSheet xssfSheet;
public XSSFDataValidationHelper(XSSFSheet xssfSheet) {
super();
// Findbugs: URF_UNREAD_FIELD. Do not delete without understanding how this class works.
//this.xssfSheet = xssfSheet;
}

4
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
View File

@ -43,8 +43,8 @@ public final class XSSFGraphicFrame extends XSSFShape {
private static CTGraphicalObjectFrame prototype = null;
private CTGraphicalObjectFrame graphicFrame;
// Unused: URF_UNREAD_FIELD
//private XSSFDrawing drawing;
// FIXME: shadows protected XSSFShape.drawing
private XSSFDrawing drawing;
private XSSFClientAnchor anchor;
/**