moparisthebest
/
poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

throw exception if hyperlink is invalid type when validating hyperlink 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-07-17 06:04:56 +00:00
parent 14472c1def
commit 4a8e7c393d
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFHyperlink.java
View File

@ -235,20 +235,26 @@ public class XSSFHyperlink implements Hyperlink {
}
}
@SuppressWarnings("fall-through")
private void validate(String address) {
switch (_type){
switch (_type) {
// email, path to file and url must be valid URIs
case Hyperlink.LINK_EMAIL:
case Hyperlink.LINK_FILE:
case Hyperlink.LINK_URL:
try {
new URI(address);
} catch (URISyntaxException x) {
IllegalArgumentException y = new IllegalArgumentException("Address of hyperlink must be a valid URI");
y.initCause(x);
throw y;
} catch (URISyntaxException e) {
throw new IllegalArgumentException("Address of hyperlink must be a valid URI", e);
}
break;
case Hyperlink.LINK_DOCUMENT:
// currently not evaluating anything.
break;
default:
// this check wouldn't need to be done if _type was checked when object was set
// since _type is final, this check would only need to be done once
throw new IllegalStateException("Invalid Hyperlink type: " + _type);
}
}