moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

add unit test for bug 59719

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2016-06-19 06:10:50 +00:00
parent e930c44e2d
commit 3d15bb8f65
2 changed files with 51 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationConstraint.java
View File

@ -90,7 +90,9 @@ public class XSSFDataValidationConstraint implements DataValidationConstraint {
}
}
/* (non-Javadoc)
/**
* If validation type is {@link ValidationType#LIST}, returns list of literal values.
* Otherwise returns <code>null</code>.
* @see org.apache.poi.ss.usermodel.DataValidationConstraint#getExplicitListValues()
*/
public String[] getExplicitListValues() {

48
src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java Normal file
View File

@ -0,0 +1,48 @@
/* ====================================================================
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==================================================================== */
package org.apache.poi.xssf.usermodel;
import static org.junit.Assert.*;
import org.apache.poi.ss.usermodel.DataValidationConstraint;
import org.apache.poi.ss.usermodel.DataValidationConstraint.ValidationType;
import org.apache.poi.ss.usermodel.DataValidationConstraint.OperatorType;
import org.junit.Test;
public class TestXSSFDataValidationConstraint {
// See bug 59719
@Test
public void listLiteralsQuotesAreStripped() {
int listType = ValidationType.LIST;
int ignoredType = OperatorType.IGNORED;
String literal = "\"one, two, three\"";
String[] expected = new String[] { "one", "two", "three" };
DataValidationConstraint constraint = new XSSFDataValidationConstraint(listType, ignoredType, literal, null);
assertArrayEquals(expected, constraint.getExplicitListValues());
String reference = "A1:A5";
constraint = new XSSFDataValidationConstraint(listType, ignoredType, reference, null);
assertNull(constraint.getExplicitListValues());
String namedRange = "MyNamedRange";
constraint = new XSSFDataValidationConstraint(listType, ignoredType, namedRange, null);
assertNull(constraint.getExplicitListValues());
}
}