Commit Graph

7779 Commits

Author SHA1 Message Date
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:33:32 +00:00
Javen O'Neal
056a8dac84 reduce statement complexity in drawContent, also has fewer FLOPS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:29:34 +00:00
Javen O'Neal
ec4a47df73 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:27:57 +00:00
Javen O'Neal
9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:25:37 +00:00
Javen O'Neal
bdf3f30418 make instance variables final where possible
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:24:14 +00:00
Nick Burch
cf6d3489e0 #57919 Provide an initial in-place write method for HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 19:02:58 +00:00
Javen O'Neal
d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:25:02 +00:00
Javen O'Neal
28622a6da5 bug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int offset) method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753070 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:12:27 +00:00
Javen O'Neal
1d80673383 bug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753069 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:11:18 +00:00
Javen O'Neal
b2b1a030a3 bug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753065 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 12:16:58 +00:00
Javen O'Neal
bc91641444 bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:56:13 +00:00
Javen O'Neal
9133eaa147 bug 59264,59833,59837: upgrade deprecated methods in examples and testcases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753061 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:45:40 +00:00
Javen O'Neal
a478687281 bug 59264,59833,59837: upgrade deprecated methods in examples and testcases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:43:50 +00:00
Javen O'Neal
2daa8a93ee close workbook to avoid resource leak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753053 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:27:44 +00:00
Javen O'Neal
38b29717ec bug 59170: remove deprecated constants, make private variables final, whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753052 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:27:18 +00:00
Javen O'Neal
b3300cf4be HexDump.writeHex is similar to Long#toHexString. Consider consolidating.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:22:43 +00:00
Javen O'Neal
3d18f17d04 log on unsupported Sprm operation, save operand to variable to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753048 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:10:21 +00:00
Javen O'Neal
8ee9106f18 whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753047 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:08:06 +00:00
Javen O'Neal
7c4a4270a0 HWPF SectionProperties implements Cloneable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753046 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:07:06 +00:00
Javen O'Neal
3a50581584 bug 58802: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:52:04 +00:00
Javen O'Neal
7637cdc080 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:48:36 +00:00
Javen O'Neal
4d33ceffb1 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:44:26 +00:00
Javen O'Neal
2944b7a7a8 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:42:13 +00:00
Javen O'Neal
31f2b5fdd1 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:32:29 +00:00
Dominik Stadler
146839d0ce Bug 58802: HWPF: Allow reading of footnote and endnote properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753039 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:27:17 +00:00
Dominik Stadler
16b0c380c9 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:27:07 +00:00
Javen O'Neal
c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:20:21 +00:00
Javen O'Neal
0ac8c90896 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753032 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:45:55 +00:00
Javen O'Neal
f92542e22e whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753031 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:45:00 +00:00
Javen O'Neal
0025b16e3e add cause to exceptions, log exceptions that are caught and suppressed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:41:52 +00:00
Javen O'Neal
1cf76af9e8 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:26:51 +00:00
Javen O'Neal
e0c50807c4 javadocs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753020 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:48:48 +00:00
Javen O'Neal
efbfef84a6 make private maps final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:29:40 +00:00
Javen O'Neal
f296b55b36 add @Override annotations to CreationHelper classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:14:49 +00:00
Javen O'Neal
4a8e7c393d throw exception if hyperlink is invalid type when validating hyperlink
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 06:04:56 +00:00
Javen O'Neal
14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:47:03 +00:00
Javen O'Neal
285bedac9e bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:43:03 +00:00
Javen O'Neal
4ba3ed06fc bug 59775: fix cell address index error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:59:12 +00:00
Javen O'Neal
44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Andreas Beeker
c00187f5e0 use real TempFile
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753004 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 00:27:52 +00:00
Andreas Beeker
11fe2eda86 #59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 00:14:06 +00:00
Dominik Stadler
af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Dominik Stadler
d0e3102fd1 Bug 59733: Narrow down testcase some more, after the first shift, removing the first row is sufficient to trigger the problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752996 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:28 +00:00
Dominik Stadler
52bf709104 Add a test to check for a NullPointerException in XSLFTableCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:11 +00:00
Dominik Stadler
ae7ef11c88 Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:02 +00:00
Javen O'Neal
9d8b7b33db JDK8 javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 10:13:58 +00:00
Javen O'Neal
064abfa59a replace for-loop over index with for-each loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 07:41:26 +00:00
Javen O'Neal
6ea74f170d annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 07:25:16 +00:00
Javen O'Neal
0c3aade7b1 JDK8 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:35:21 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:32:45 +00:00