Greg Woolsey
2d2aa5196a
#61085 support table styles
...
Added more features - this allows a client app to fully display table styling without resorting to CT* classes, and has some helper logic for the additional processing needed for things like regional/area borders.
As far as I can tell I only added stuff, didn't change any existing behavior.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795648 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 04:05:32 +00:00
Javen O'Neal
284f7d19c5
github-55: NumberFormatException if XSSFName.setNameName is set with a long name that looks similar to a cell address. Thanks to Thomas S @Millie4Ever
...
This closes #55 on github.
https://github.com/apache/poi/pull/55
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795595 13f79535-47bb-0310-9956-ffa450edef68
2017-05-19 08:26:41 +00:00
Javen O'Neal
0b767886bf
replace "String.indexOf(String) >= 1" with "String.contains(String)"
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795296 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 10:53:15 +00:00
Javen O'Neal
f701e81a64
github-25: add enable locking and tab color in SXSSFSheet. Thanks to Danilo Rangel. This closes #25 .
...
https://github.com/apache/poi/pull/25
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795277 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 08:38:58 +00:00
Javen O'Neal
b6f78f8d57
github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication. Thanks to Daniel Kuan! This closes #32 .
...
https://github.com/apache/poi/pull/32
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795266 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:18:17 +00:00
Javen O'Neal
be5106a1d7
github-43: add disabled unit test showing a problem with ROUNDUP(3987*0.2, 2). Thanks to @FishMeat.
...
https://github.com/apache/poi/pull/43
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795265 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:04:12 +00:00
Nick Burch
fec503f1de
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795261 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 02:50:35 +00:00
Javen O'Neal
b527f96daa
github-52: add ExcelToHtmlConverter method that works on InputStreams. Thanks to Tony Zeng! This closes #52 .
...
https://github.com/apache/poi/pull/52
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795256 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 00:58:01 +00:00
Javen O'Neal
fac98b5bef
github-53: fix NPE when iterating over paragraphs in certain *.docx files. Thanks to Praful Kumar Vaishnav! This closes #53 .
...
https://github.com/apache/poi/pull/53
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795254 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 00:41:25 +00:00
Javen O'Neal
5c62492ffb
github-54: when adding a picture to an XSSFWorkbook, reduce memory consumption by 100x and increase speed by 10x based on OpenJDK JMH benchmarking. Thanks to Tim Helmstedt! This closes #54 .
...
https://github.com/apache/poi/pull/54
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795252 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 23:27:21 +00:00
Andreas Beeker
8c1346b138
Add ASL header and exclude table preset from rat-check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795137 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 06:30:06 +00:00
Andreas Beeker
90dca20bd2
#52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
...
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Greg Woolsey
bf83a00457
tweak to use platform line separator so tests can pass on Windows as well as Linux.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795026 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 22:13:30 +00:00
Greg Woolsey
0cdc064b0c
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 18:01:32 +00:00
Dominik Stadler
e77156d9f4
Simplify the ValueEval.toString() implementations and include more information on unexpected types of ValueEval
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794956 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 11:38:05 +00:00
Dominik Stadler
d9df038f4a
Bug 60352: Text extraction: Don't include the text "null" for empty cells
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794260 13f79535-47bb-0310-9956-ffa450edef68
2017-05-07 21:03:46 +00:00
Greg Woolsey
8313b17515
60184 - invalid OOXML produced when XSSFFont.getFamily() called with no families defined
...
Fix to stop creating an empty family when none exist, just use the existing logic to return NOT_APPLICABLE. Creating the empty element produces XML that doesn't comply with the XSD.
Alternative would have been to set the family int value for the new family, but this way checking the value doesn't change the output, which is my preferred behavior. No quantum effects!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794111 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 21:50:59 +00:00
Greg Woolsey
6bca07a15f
forgot license (as always)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794093 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 18:33:49 +00:00
Greg Woolsey
18d107d974
61060 - teach DataFormatter about conditional formatting rules with number formats
...
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 17:44:58 +00:00
Andreas Beeker
fb28b14d48
test integration fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793733 13f79535-47bb-0310-9956-ffa450edef68
2017-05-04 01:13:48 +00:00
Andreas Beeker
ad72f60ab6
SonarQube fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 22:16:26 +00:00
Andreas Beeker
76dbb5a1eb
HPSF: Change CustomProperties to delegate
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 19:18:45 +00:00
Andreas Beeker
d0630390d2
Remove Unicode chars in comments
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793647 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 14:08:04 +00:00
Andreas Beeker
0f78f6dc1f
fix javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793604 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 00:14:55 +00:00
Andreas Beeker
cd6236c74b
#52372 - OutOfMemoryError parsing a word file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:32:13 +00:00
Andreas Beeker
a0b324224b
Reverted DocumentSummary hack in codepage guessing code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793601 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:30:17 +00:00
Andreas Beeker
eeb697001f
HPSF: Add CopyCompare to IntegrationTests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:29:19 +00:00
Andreas Beeker
3a1771ced1
HPSF: Enable new number types in VariantSupport
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:28:00 +00:00
Andreas Beeker
456b33a837
Fix hpsf javadocs and code issues
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:27:27 +00:00
Andreas Beeker
5600fa6f58
IntegrationTest - move excludes to file handler
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793595 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:25:45 +00:00
Andreas Beeker
63b88fec6a
HPSF: Use LittleEndianStream instead of offset calculation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793594 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:24:50 +00:00
Javen O'Neal
95538eb815
bug 61059: add @Override annotations
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793418 13f79535-47bb-0310-9956-ffa450edef68
2017-05-01 21:51:34 +00:00
Dominik Stadler
5265ff6f81
Improve information contained in exception in CellRangeAddress()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:44 +00:00
Dominik Stadler
fa39402871
60325: Add commented out test that reproduces the performance issue
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793251 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:36 +00:00
Nick Burch
28cbb8e84e
Javadoc fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793249 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 08:49:51 +00:00
Javen O'Neal
f5389965a2
bug 61034: break out of for-loop when both <sheet name="", id=""/> are found
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793230 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 18:56:09 +00:00
Javen O'Neal
e39ae9cd30
bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
...
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 17:27:17 +00:00
Tim Allison
a98eaeb917
bug 61051 -- add new worksheet-like relations for xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792940 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 18:50:22 +00:00
Tim Allison
5f567f29a1
bug 61049 fix ordering of builtin formulas
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 16:18:25 +00:00
Nick Burch
9896e13bf4
Patch from Tim Jones from #61044 - Note on setCompressTempFiles
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-26 09:43:56 +00:00
Tim Allison
c2dc3ad585
bug 61021 - extract abspath from xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792198 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 13:02:29 +00:00
Greg Woolsey
f5b90cbbee
Add conditional formatting evaluation example code and output results
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792102 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 18:05:50 +00:00
Javen O'Neal
3c2a6b38bb
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 01:28:40 +00:00
Javen O'Neal
3cbf4740b1
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 23:51:03 +00:00
Greg Woolsey
6e0a5916b5
Fix bug #61007
...
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.
Send what was checked previously plus only multi-segment conditional range formats. Allows existing tests to pass plus the new test with the case for these conditional formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8
Fix bug #61007
...
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel. Also added tests for the failing formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 18:10:52 +00:00
Nick Burch
d4d08d5ce8
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791857 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 06:13:33 +00:00
Dominik Stadler
511c2544a8
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad
#60998 - HSLFTable.setRowHeight sets row height incorrect
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c
findbugs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 11:02:22 +00:00
Andreas Beeker
594b46f1cd
fix forbidden-apis-check error
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791646 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 23:43:56 +00:00
Andreas Beeker
bd237e2483
#60996 - XSSF: Multiple embedded objects on same sheet are ignored
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 22:41:28 +00:00
Javen O'Neal
dc29c94460
roll back to hamcrest-core
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791570 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 06:10:23 +00:00
Andreas Beeker
160fb550c1
#60993 - HSLF: Grid and rowspan calculation in table cells is wrong
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791500 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 12:14:26 +00:00
Javen O'Neal
0acf44d3dc
improve unit test error messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791445 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:21:34 +00:00
Javen O'Neal
ef8c9329cf
change from hamcrest-core-1.3 to hamcrest-all-1.3
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791444 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:19:27 +00:00
Javen O'Neal
e7ca1594da
use hamcrest matchers to reduce custom code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:50:46 +00:00
Javen O'Neal
7977026f96
use assertStartsWith and assertEndsWith for better unit test error messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:19:24 +00:00
Nick Burch
70ae27f96d
#60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791108 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:11:56 +00:00
Nick Burch
3bd1f662f3
Failing, disabled unit test for bug #60973
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791098 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 09:40:54 +00:00
Greg Woolsey
6163e4ca45
Issue #60971 , handle formula chart titles
...
implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:27:23 +00:00
Tim Allison
0ddc4da7e2
bug 50955 - add logging per Javen's recommendation. Thank you!
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791021 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:00:12 +00:00
Tim Allison
9412d467f3
bug 50955 - incorporate info from the DocumentSummaryInformation for
...
guessing the encoding. Back off to the old method if DocSummInfo is
not available. Thanks to Andreas Beeker for recommending this direction.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791002 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 17:07:04 +00:00
Tim Allison
44d536e4ce
bug 50955 - try originally guessed codepoint, backoff to 1252 if that fails
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790904 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 01:30:02 +00:00
Andreas Beeker
1f41c31984
Fix AIOOBE while extracting hssf pictures which are externally linked
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 21:43:22 +00:00
Dominik Stadler
48526517cd
Adjust checking for Zip-Bomb errors so it also works on JDK >= 8
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790508 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 06:38:23 +00:00
Dominik Stadler
77614b8c49
Test for another type of xml-bomb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:50:03 +00:00
Dominik Stadler
0f193371ea
Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 13:17:17 +00:00
Tim Allison
f426849947
bug 50955 convert Set to Singleton per Javen's code review
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 11:02:48 +00:00
Tim Allison
1bfd5f6585
bug 50955 and bug 60953 improve Big5 reader; ensure one character
...
per byte pair
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 01:45:55 +00:00
Tim Allison
4b0e6dc048
bug 50955 -- turn off test that now passes in Java 1.8 and 1.7
...
but not 1.6 until we can fix it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790136 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 15:26:01 +00:00
Tim Allison
3c62c898a4
bug 50955 -- fix for java 7
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790130 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 14:41:53 +00:00
Tim Allison
af51ea4c10
bug 50955 -- word 6.0 charset fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 02:06:46 +00:00
Tim Allison
9dcb5d4c47
Bug 60906 -- clean up, and add range checking for casting to ints.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788295 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 18:08:52 +00:00
Tim Allison
3d20031b56
Bug 60489 -- add @Test annotation so that this actually runs and includes ConnectsType...<facepalm/>
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788288 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:56:29 +00:00
Tim Allison
925f4b85ad
Bug 60906 -- fix style index
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788282 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:31:42 +00:00
Tim Allison
3953b18e2b
60881 -- fix unit test to use assumeTrue thanks to Javen's recommendation.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788133 13f79535-47bb-0310-9956-ffa450edef68
2017-03-22 16:21:25 +00:00
Tim Allison
2674dad889
60881 -- strip out system.set props for local test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787891 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:13:11 +00:00
Tim Allison
26dddd5184
60881 -- fix new unit test. xlsb test file apparently requires unlimited jce. If not installed, ignore new test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787890 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:03:01 +00:00
Tim Allison
69c3311a98
60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 20:47:15 +00:00
Tim Allison
e4f884a915
60879 -- figure out if we can support old beta xlsb or throw exception. For now, let's hope there's only one diff and/or the other bounds checking etc will throw exception if there are other problems.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787832 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 18:50:25 +00:00
Dominik Stadler
1aee770758
Bug 60042: Add sample file to check if this bug is fixed via bug 55791 already.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787664 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:44:05 +00:00
Dominik Stadler
a22b4aaa2d
Bug 60810: Check for duplicate relation-names for notes similar to the fix for slides themselves in bug 55791
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787663 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:43:57 +00:00
Dominik Stadler
eef36a1580
Fix typo to "length", closes #51
...
Fix a few IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:30:04 +00:00
Dominik Stadler
e78eb68b10
60823: DGET function, correct behavior with multiple result entries but only one non-blank
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:29:55 +00:00
Dominik Stadler
bfeeba5eb8
Fix broken imports
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787585 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 18:46:15 +00:00
Dominik Stadler
69923f8c5a
Adjust integration-test files slightly, more failure-output, make it a bit easier to test single-files, add a HeapDump class for investigating memory leaks, adjust XSSFFileHandler to free memory more quickly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787556 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 13:56:11 +00:00
Dominik Stadler
531226ac84
Add docm-file which is actually a binary doc to check handling of wrong-format-exceptions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787555 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 13:56:04 +00:00
Dominik Stadler
12a26bd6ca
Fix ROOT_DIR
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787330 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 12:03:07 +00:00
Tim Allison
b52126f7f3
60826 -- clean up. Many, many thanks to Javen O'Neal's code review!
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787320 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 10:09:59 +00:00
Tim Allison
60b4624cf7
60826 -- update stress tests to handle xlsb
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787264 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 22:32:24 +00:00
Tim Allison
730f394261
60826 -- add initial support for streaming reading of xlsb files.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 18:37:13 +00:00
Greg Woolsey
6fc050a162
add missing license header
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786962 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 22:36:38 +00:00
Greg Woolsey
6349d2c614
Fixed #60858 , which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822 .
...
Includes new unit test based on the bug sample file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af
Fix some Sonar issues in sample "HSSFReadWrite"
...
Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 14:09:27 +00:00
Dominik Stadler
abc3d37adc
Add tests from bug 45353 to show that this now works fine
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:14:00 +00:00
Dominik Stadler
c07c41659f
HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:52 +00:00
Dominik Stadler
aafdbdfdd7
Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:39 +00:00
Tim Allison
b442671274
51519 -- follow on, make concatenation of rPh configurable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786021 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 16:44:40 +00:00
Tim Allison
5bb1195606
51519 -- allow users to ignore or include the <rPh> (phonetic run) element in the ReadOnlySharedStringsTable used in the SAX/streaming xlsx reader.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785965 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 13:41:07 +00:00
Javen O'Neal
8dd5f7b887
store repeated expressions as temporary variables to make code shorter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785793 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 03:16:50 +00:00
Javen O'Neal
5b879942fc
bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
2017-03-02 18:47:28 +00:00
Tim Allison
31dd2885dd
Bug 60795 -- fixed deprecation, thanks to Javen.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784989 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 16:49:15 +00:00
Tim Allison
5b801a9dc6
Bug 60795 -- add enum for message class in MAPIMessage; deprecate getMessageClass()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784978 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 15:47:47 +00:00
Javen O'Neal
bb6e94851f
add helper functions to make it easier to see which scenarios are being tested
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784231 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 05:07:10 +00:00
Javen O'Neal
c04e2a314a
bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8
add javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9
Add null check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:18:10 +00:00
Andreas Beeker
0744f73add
BugFix for JDK-6623219
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
2017-02-19 21:36:45 +00:00
Andreas Beeker
7810671d2d
#60662 - Slide import delete unrecognized elements in group shape
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783486 13f79535-47bb-0310-9956-ffa450edef68
2017-02-18 01:07:47 +00:00
Javen O'Neal
9783654301
bug 60742: remove commented out debugging code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 20:53:44 +00:00
Dominik Stadler
feee2b88c8
bug 60742: Remove local test-code from test for bug 60512
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783428 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 17:15:27 +00:00
Javen O'Neal
b2206fc40f
bug 60742: write out to unit test TempFile rather than Unix-only /tmp/60512.xlsx; patch from Chiara Marcheschi
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783426 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 16:57:43 +00:00
Javen O'Neal
7fcaaa9479
bug 59893: close open resources to prevent leaks
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783362 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:53:49 +00:00
Javen O'Neal
85a30f16cf
convert from junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783360 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:37:00 +00:00
Javen O'Neal
ee6677ee56
bug 59893: fix a few forgotten unrelated changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:25:49 +00:00
Javen O'Neal
1584310ac5
bug 59893: more unrelated changes from Andi
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783353 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:08:21 +00:00
Javen O'Neal
8677d099fc
bug 59893: commit the changes from attachment 34068 that were unrelated to available()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 08:39:05 +00:00
Javen O'Neal
0443c27ede
OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when executing TestAllFiles
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783174 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:15:13 +00:00
Javen O'Neal
c1b350201c
test-integration: replace redundant static { EXPECTED_FAILURES.add(...) } with (dynamic) Arrays.asList() to improve code legibility.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783171 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:08:44 +00:00
Greg Woolsey
ba7809d69a
a new test file needed to be added to the list of sheet clone expected errors.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783129 13f79535-47bb-0310-9956-ffa450edef68
2017-02-15 17:48:46 +00:00
Greg Woolsey
ca399b4f42
Bug #56822 fix COUNTIFS()
...
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b
Bug #56822 fix COUNTIFS()
...
includes unit test from the issue. Verified unit test results in Excel vs. incorrect previous POI results. Test passes new code, as do existing tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78
Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d
Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae
Expose Priority from newer-style HSSF CF rules
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 17:49:13 +00:00
Greg Woolsey
c88649ccd2
Ugh, that's what I get for copying someone else's code without fully reviewing it. Return the boolean property, don't wrap it in an extra if().
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782989 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:49:24 +00:00
Greg Woolsey
05125678ab
Expose another common property, strikeout.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:45:47 +00:00
Greg Woolsey
117a898e35
Add license
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782978 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 15:36:56 +00:00
Nick Burch
1e5fa0dbea
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:35:43 +00:00
Andreas Beeker
43921c1a19
Metro shapes: integration test regression on empty paragraphs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782897 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 00:18:13 +00:00
Greg Woolsey
b0d0d0fda5
Add evaluation of data validation rules and conditional formatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 22:51:30 +00:00
Andreas Beeker
d74cfc4df5
Generics fix for metro shapes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782722 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 06:46:59 +00:00
Andreas Beeker
41d7483ae3
#60625 - Rendering issue with background and shape overlayed by image
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782712 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 00:52:38 +00:00
Andreas Beeker
967a3b0e0c
#60625 - Rendering issue with background and shape overlayed by image
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
2017-02-12 22:30:49 +00:00
Andreas Beeker
397771011f
#60715 - Blank layout was not found
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782635 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 21:48:05 +00:00
Andreas Beeker
faaa94d20a
escape unicode chars
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782568 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 09:49:52 +00:00
Andreas Beeker
db3000b142
SonarQube fixes and removed redundant logger level checks, for simple String messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46
Add a possible future TODO
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 14:02:12 +00:00
Nick Burch
fc31afbb86
Use long for the dummy stream, to permit >2gb streams
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 13:51:33 +00:00
Nick Burch
b6480adb9f
If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5
Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 11:43:01 +00:00
Nick Burch
eeae830d19
Start on a unit test for #60670 , work required to get it passing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782380 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:51 +00:00
Nick Burch
31ec02043a
Unit test comment for possible future expansion
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782378 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:15 +00:00
Javen O'Neal
cc962432a4
bug 59030: revert r1746625 and restore r1731257, where XWPFTableCell#getVerticalAlignment() returns null rather than a default value (XWPFVertAlign.TOP) if vertical alignment is not set
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782225 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:35:04 +00:00
Javen O'Neal
61f69324c7
bug 59030: convert to junit4; whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782224 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:32:53 +00:00
Javen O'Neal
453a868b41
Per JavaDoc and tallison, XWPFTableCell#getVerticalAlignment() should return null if valign is not set. Patch from prasad-babu. This closes #30 on GitHub.
...
https://github.com/apache/poi/pull/30#issuecomment-186224438
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782130 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 09:23:04 +00:00
Javen O'Neal
0f09e9eae2
bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:29:18 +00:00