moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when executing TestAllFiles

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783174 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Javen O'Neal 2017-02-16 06:15:13 +00:00
parent c1b350201c
commit 0443c27ede
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/integrationtest/org/apache/poi/TestAllFiles.java
View File

@ -177,12 +177,15 @@ public class TestAllFiles {
HANDLERS.put("spreadsheet/test_properties1", new NullFileHandler());
}
private static final Set<String> unmodifiableHashSet(String... a) {
return Collections.unmodifiableSet(hashSet(a));
}
private static final Set<String> hashSet(String... a) {
return new HashSet<String>(Arrays.asList(a));
}
// Old Word Documents where we can at least extract some text
private static final Set<String> OLD_FILES = hashSet(
private static final Set<String> OLD_FILES = unmodifiableHashSet(
"document/Bug49933.doc",
"document/Bug51944.doc",
"document/Word6.doc",
@ -194,7 +197,7 @@ public class TestAllFiles {
"document/52117.doc"
);
private static final Set<String> EXPECTED_FAILURES = hashSet(
private static final Set<String> EXPECTED_FAILURES = unmodifiableHashSet(
// password protected files
"spreadsheet/password.xls",
"spreadsheet/protected_passtika.xlsx",
@ -284,7 +287,7 @@ public class TestAllFiles {
"spreadsheet/ConditionalFormattingSamples.xls"
);
private static final Set<String> IGNORED = hashSet(
private static final Set<String> IGNORED = unmodifiableHashSet(
// need JDK8+ - https://bugs.openjdk.java.net/browse/JDK-8038081
"slideshow/42474-2.ppt",
// OPC handler works / XSSF handler fails