moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,159 Commits 29 Branches 84 Tags 722 MiB
dcd8a53c64
Commit Graph

6757 Commits

Author SHA1 Message Date
Javen O'Neal
57033b6a9e revert whitespace changes to ASF license; previous commit r1751180 contributed by sebb 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751181 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:17:11 +00:00
Javen O'Neal
9e315cd89d bug 59786: fix NPE from winmail.dat files if message body is null 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751180 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:13:37 +00:00
Javen O'Neal
227ae30154 whitespace (3 spaces and tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751179 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:05:52 +00:00
Javen O'Neal
c54deaf3ff uncomment ignored unit tests so they at least compile 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:59:41 +00:00
Javen O'Neal
0e118a7b6d bug 59788: create temporary directories 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:58:06 +00:00
Andreas Beeker
1781e9d83f deprecated DrawingManager 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:21:55 +00:00
Andreas Beeker
8e84226202 #59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 21:54:17 +00:00
Javen O'Neal
ac451c874d convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751172 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 20:04:43 +00:00
Andreas Beeker
6899a1ad95 javadocs fixes (jdk8) 
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 18:25:05 +00:00
Javen O'Neal
33cf815199 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 07:20:47 +00:00
Andreas Beeker
76c479ce28 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751106 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 23:08:07 +00:00
Javen O'Neal
73fcbfdb68 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 18:28:43 +00:00
Javen O'Neal
e7eef4d75a bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751081 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 16:29:05 +00:00
Javen O'Neal
4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 09:00:13 +00:00
Javen O'Neal
b11ee3f7da don't shadow drawing field from XSSFShape in XSSFGraphicFrame 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751038 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:40:50 +00:00
Javen O'Neal
ac84cdb773 findbugs: remove implements Cloneable declaration from classes that don't implement a clone method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:30:34 +00:00
Javen O'Neal
1aa3511d0c findbugs: remove switch statement fall-through and move default switch to bottom 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751034 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:20:14 +00:00
Javen O'Neal
5af440d517 enable @Ignored unit test that is passing now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751024 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:12:19 +00:00
Javen O'Neal
4dd2ff6c7c findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751023 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:11:01 +00:00
Javen O'Neal
e7ef961359 +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751022 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:01:43 +00:00
Javen O'Neal
e31aa190a8 deprecate o.a.p.hssf.util.AreaReference as it shadows o.a.p.ss.util.AreaReference (findbugs) and provides no additional functionality 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751021 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:43:21 +00:00
Javen O'Neal
d7900beec3 findbugs: DocumentInputStream.skip(long) result not checked; close DocumentInputStream even if exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751020 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:39:53 +00:00
Javen O'Neal
6645d8a80f whitespace and +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751019 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:28:41 +00:00
Andreas Beeker
c985706686 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-01 21:10:40 +00:00
Javen O'Neal
b2f4150b06 bug 59776: don't swallow cause of exception in ZipPackagePropertiesMashaller exception handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750893 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-01 09:14:41 +00:00
Andreas Beeker
1b086d3a35 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 23:03:17 +00:00
Andreas Beeker
6eab79528b a few performance fixes to speed-up the tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 22:59:46 +00:00
Nick Burch
0c9e0cb608 #59739 When testing for a valid NFIB in a FileInformationBlock, accept common "nearby" values as found from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750866 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 21:20:23 +00:00
Dominik Stadler
6b1caa4e2c Bug 59739: For now fix the regression in FileInformationBlock which was introduced after 3.15-beta1 so that the documents can be loaded again pending a full fix as discussed in the bug. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750864 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 21:06:04 +00:00
Nick Burch
520f4fbf76 #59766 Need to catch Errors as well when trying to tweak SAX stuff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750408 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-27 19:57:33 +00:00
Javen O'Neal
a0f9c1d707 bug 59748: replace remaining Hashtable usages in contrib/poi-ruby and hssf examples 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750182 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-25 05:22:05 +00:00
Javen O'Neal
6f0825c5b4 add @Override annotation for updateOtherRecordReferences on PositionDependentRecordAtom descendents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750181 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-25 05:10:22 +00:00
Andreas Beeker
099f63d054 deprecated constants pointing to MissingCellPolicy - use enum instead 
javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 23:31:12 +00:00
Andreas Beeker
85f22291be Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 22:04:12 +00:00
Javen O'Neal
fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 21:39:44 +00:00
Andreas Beeker
18c2ee3fdc sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750162 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 20:26:08 +00:00
Andreas Beeker
a3718f8166 common-crawl-regression-fix: fallback to higher template level for default font, in case the style reference can't be determined 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750034 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 00:12:25 +00:00
Andreas Beeker
5fce29e432 Fix for test-data of #59746 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750033 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 23:13:59 +00:00
Nick Burch
05f704d112 #59746 XSSF support for files from certain alternate tools where the row XML is missing the row number 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749971 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 18:59:48 +00:00
Nick Burch
4abd9f6cca Disabled unit test for bug #59746, test file from Rob Owen 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749963 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 18:44:34 +00:00
Andreas Beeker
0341823c5c #59743 - ZipSecureFile throwing "zip bomb detected" exception when writing SXSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749799 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 00:23:51 +00:00
Andreas Beeker
c0fd2ae00b Ignore Tiff files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749797 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:51:14 +00:00
Andreas Beeker
89fb94e67d sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749795 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:27:53 +00:00
Andreas Beeker
c88ba795a0 javadoc fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749794 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:26:08 +00:00
Nick Burch
bfa702ed88 XSLFPictureData support for TIFF images - patch and tests from bug #59742 from Jens Popp 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749732 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 16:18:36 +00:00
Nick Burch
4eb8175d88 Fix inconsistent whitespace and indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749530 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:34:12 +00:00
Nick Burch
631ca92c16 #59717 POIXMLProperties helper methods for reading and changing OOXML document thumbnails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749528 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:27:41 +00:00
Nick Burch
fdb7c7d1ff Provide an alternate method to get the OLE2 thumbnail that decodes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749526 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:26:28 +00:00
Javen O'Neal
0f3a7b24b4 bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 11:27:40 +00:00
Javen O'Neal
8cefedd80a remove an unnecessary row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749300 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:52:50 +00:00
Javen O'Neal
3bc1764c5c bug 59733: cells do not need to be created for the XmlValueDisconnectedException to occur 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749298 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:49:05 +00:00
Javen O'Neal
3f546d927f bug 59733: add disabled unit test from Dattathreya 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749295 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:41:22 +00:00
Javen O'Neal
d23e77fcf5 remove commented out @Ignore 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749294 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:32:21 +00:00
Javen O'Neal
b617f3ccec bug 56781: disallow names with symbols, except underscore, period, and backslash 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:27:52 +00:00
Javen O'Neal
4036202ebc add comments, adjust whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749276 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:50:36 +00:00
Javen O'Neal
f3bd334002 whitespace (tabs to spaces); +svnprop svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749274 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:15:56 +00:00
Javen O'Neal
3881a0db31 bug 57929: add disabled unit test, adapted from nova 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 07:15:09 +00:00
Javen O'Neal
4df03b8762 bug 57523: off by one error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749269 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 06:49:13 +00:00
Javen O'Neal
54d0ebe889 bug 57523: add unit test written by Dominik Stadler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749267 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 06:27:12 +00:00
Javen O'Neal
44d8e4a2cb bug 59719: add unit test and comments/javadocs from Greg Woolsey for XSSFDataVAlidationConstraint 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749265 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 05:01:21 +00:00
Javen O'Neal
7929adbf80 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749264 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 04:21:26 +00:00
Javen O'Neal
40727700f4 bug 59731: start migrating methods relating to row-shifting in HSSFSheet to HSSFRowShifter; consolidate with XSSFRowShifter into RowShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749262 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 04:16:32 +00:00
Javen O'Neal
57e9abb8d1 parameterize raw generics 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 03:40:32 +00:00
Javen O'Neal
0ec8b3a88e bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749248 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 02:02:08 +00:00
Javen O'Neal
55cb9381de bug 56454: deprecate shiftMerged with unused parameter, move loop-invariant out of for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749247 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:49:46 +00:00
Javen O'Neal
2804197bdb bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:44:44 +00:00
Javen O'Neal
015cf4c86f object-oriented methods are preferred over utility classes for discoverability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749245 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:25:23 +00:00
Javen O'Neal
8dc7ee659d bug 59729: update CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749243 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:55:51 +00:00
Javen O'Neal
970626a88e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749241 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:28:19 +00:00
Javen O'Neal
8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39 bug 56454: add CellRangeAddress#containsRow and containsColumn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:16:41 +00:00
Andreas Beeker
3a4754de98 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749238 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:08:11 +00:00
Javen O'Neal
e08786d49e convert TestCellRangeAddress from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749237 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:00:41 +00:00
Javen O'Neal
778fa8aa3d bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749226 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 23:02:43 +00:00
Javen O'Neal
ebd55552bf bug 59728: add disabled unit test: should not be able to add an array formula to merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:51:01 +00:00
Andreas Beeker
3a72eea5c5 Regression fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749224 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:43:24 +00:00
Javen O'Neal
b9e9b0d41d bug 56958: slightly improve performance when checking array formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:24:17 +00:00
Nick Burch
7da9b2cd67 #59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:13:41 +00:00
Nick Burch
b7b990f56f #59724 Provide Closeable on all OLE2-based POIDocument types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749213 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:12:55 +00:00
Javen O'Neal
492aac4e73 bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9 bug 59645: add Page Setup Print row and column headings support for Common SS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 18:20:23 +00:00
Javen O'Neal
8240a8ab5d update javadoc for clarification about non-literal lists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 06:23:57 +00:00
Javen O'Neal
3eb3df8d35 use fully qualified name for Javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749132 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 06:16:23 +00:00
Javen O'Neal
3d15bb8f65 add unit test for bug 59719 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 06:10:50 +00:00
Javen O'Neal
e930c44e2d bug 59719: parse static list text properly; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749129 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 04:43:53 +00:00
Andreas Beeker
bec4c45c59 findbugs fixes - ME_MUTABLE_ENUM_FIELD 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-19 01:06:55 +00:00
Andreas Beeker
e1241ed975 #59702 - Setting background color in slide master 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749108 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 23:48:00 +00:00
Javen O'Neal
d8d821b1f2 add unit test for HSSFWorkbook.getSelectedTabs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 02:37:24 +00:00
Javen O'Neal
acac716a64 bug 59718: deprecate get/setBoldweight. Use get/setBold 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 01:21:08 +00:00
Javen O'Neal
59d1dc095b bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-18 01:06:53 +00:00
Javen O'Neal
21e8ce5979 bug 59432: move loop invariants outside the loop to marginally improve code execution speed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748832 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 11:06:58 +00:00
Javen O'Neal
be7fd6ffb6 FunctionEval is a utility class. It should not have a public default constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748830 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 10:47:13 +00:00
Javen O'Neal
26d3072b1e bug 56958: validate array formulas wasn't correctly checking for overlap with a merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748829 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 10:22:09 +00:00
Javen O'Neal
645fbd08fc bug 59279: add unit test for CellComment.equals and CellComment.hashCode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748827 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 10:17:47 +00:00
Javen O'Neal
19a0cc12fa bug 59279: add Comment.equals and hashCode methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 08:56:10 +00:00
Javen O'Neal
720e866a4c add unit test for Cell.getCellComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748813 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 08:54:08 +00:00
Javen O'Neal
6ea5e99ce4 move loop invariant outside of loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748809 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 07:59:01 +00:00
Javen O'Neal
4e60db8b4e findbugs: remove uncalled private methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748804 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 07:32:38 +00:00
Javen O'Neal
7a66ac346f bug 59170: add version when deprecated 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748793 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:35:44 +00:00
Javen O'Neal
7b14a48436 bug 59170: deprecate o.a.p.hssf.model.PictureShape 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748792 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:31:27 +00:00
Javen O'Neal
07767097bb bug 59170: remove deprecated constructors in o.a.p.hwpf.usermodel.Paragraph 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748791 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:16:40 +00:00
Javen O'Neal
890afdc0f4 bug 59170: remove deprecated o.a.p.hwpf.usermodel.Pictures methods; add version when deprecated to javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748790 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 02:12:05 +00:00
Javen O'Neal
c7c11821fe bug 59170: remove or privatize deprecated methods in o.a.p.hwpf.usermodel.Range from POI 3.8 beta 4/5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748789 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:48:46 +00:00
Javen O'Neal
bb43d1eb3c remove deprecated o.a.p.hwpf.usermodel.Shapes (replaced by OfficeDrawing in POI 3.8 beta 4) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748788 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:34:00 +00:00
Javen O'Neal
e28a8789f3 bug 59170: remove deprecated o.a.p.hwpf.usermodel.ListEntry constructor and method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748787 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:24:38 +00:00
Javen O'Neal
06b4103cb0 bug 59170: remove deprecated WordExtractor constructor; add version when deprecated to HWPF HeaderStories 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748786 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:19:36 +00:00
Javen O'Neal
3369507cac bug 59170: remove deprecated o.a.p.hwpf.usermodel.CharacterRun#cloneProperties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748785 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:09:05 +00:00
Javen O'Neal
5fe6c32f85 bug 59170: add version when deprecated 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748784 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:00:38 +00:00
Javen O'Neal
ae12cfcd57 bug 59170: remove deprecated HSLF and HWPF methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748783 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:55:22 +00:00
Javen O'Neal
45ec02487c bug 59170: remove deprecated o.a.p.hdgf.HDGFDiagram constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748782 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:36:19 +00:00
Javen O'Neal
d77a3f9058 whitespace (3 spaces to tab) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748781 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:35:29 +00:00
Javen O'Neal
c3833b5ce7 bug 59170: remove deprecated o.a.p.xwpf.model.XWPFHyperlinkDecorator class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748780 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:20:48 +00:00
Javen O'Neal
d7fc37b2db bug 59170: remove deprecated o.a.p.openxml4j.opc.internal.CnotentType#getParameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748778 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-16 23:52:54 +00:00
Javen O'Neal
0472d9d861 bug 55385: deprecate Font.getBoldweight and Font.setBoldweight 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-16 06:51:53 +00:00
Javen O'Neal
5028639443 add disabled unit test for bug 55273: contributed by Martin Studer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748606 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 16:36:31 +00:00
Javen O'Neal
b99c753158 fix javadocs @link error for removed o.a.p.hssf.util.CellRangeAddress 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748496 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:32:17 +00:00
Javen O'Neal
4243208ade bug 59170: remove deprecated XSSFExcelExtractor(String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748495 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:26:14 +00:00
Javen O'Neal
9b217ab2da bug 59170: remove deprecated o.a.p.openxml4j.opc.Package 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748494 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:22:49 +00:00
Javen O'Neal
7228082d6b bug 59170: remove deprecated XSSFFontFormatting#getXSSFColor that was deprecated in 3.13 beta 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748493 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:22:26 +00:00
Javen O'Neal
ff3ccad347 add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748491 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:08:56 +00:00
Javen O'Neal
aeddbc05e4 whitespace (2 spaces or tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748489 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:55:45 +00:00
Javen O'Neal
f2390589dc bug 59170: remove deprecated writeTo method in @Internal PAPBinTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748488 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:42:18 +00:00
Javen O'Neal
2b7649cbd6 whitespace (2 spaces to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748487 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:34:56 +00:00
Javen O'Neal
46a36df416 remove deprecated constructor for @Internal PAPBinTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748486 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:31:41 +00:00
Javen O'Neal
552ccb58e4 update WriteAuthorAntTitle example to Java 1.6+ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748485 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:29:31 +00:00
Javen O'Neal
e355d20cfa bug 59170: remove deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:26:58 +00:00
Javen O'Neal
ea30ed25b4 bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748482 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:56:56 +00:00
Javen O'Neal
ccdc23ab43 bug 59170: remove deprecated methods in o.a.p.hpsf.wellknown.SectionIDMap 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748481 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:48:23 +00:00
Javen O'Neal
e9be07056b bug 59170: remove deprecated hpsf.Constants class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748480 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:47:04 +00:00
Javen O'Neal
07c65c3fc4 bug 57840: add comments for explicit boxing performance optimization 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748479 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 01:42:11 +00:00
Javen O'Neal
72ef600ce0 remove RegionUtil reference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748473 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-14 21:57:38 +00:00
Andreas Beeker
f83ff6f8ce javadoc fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 23:08:13 +00:00
Andreas Beeker
d8437d0476 reverted changes of r1747942 and deprecated instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 21:18:50 +00:00
Javen O'Neal
227a62ce1e back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 18:14:26 +00:00
Javen O'Neal
beef6df971 back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 18:12:29 +00:00
Javen O'Neal
4a85959d45 Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748175 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:55:49 +00:00
Javen O'Neal
e61e346436 add HSSFCell.setCachedErrorResult(FormulaError) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748174 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:53:03 +00:00
Javen O'Neal
ef3564968a type check error code when setting cell error value on HSSFCell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748172 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:29:38 +00:00
Javen O'Neal
8bf974b185 add useless unit test for o.a.p.ss.util.RegionUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:14:44 +00:00
Javen O'Neal
84924a4918 add periods for complete sentences 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748166 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:51:01 +00:00
Nick Burch
ae11fa3dae Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748158 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:39:36 +00:00
Nick Burch
b8c13b6cc8 Javadoc fixes - @see and @link can't be combined together, at least not in Java 6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748157 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:38:12 +00:00
Javen O'Neal
48eb5c521b improve unit test coverage on CellReference. 
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 08:58:55 +00:00
Javen O'Neal
48410a4224 fix accidental infinite recursion 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748143 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 08:55:41 +00:00
Javen O'Neal
4c89f44cc5 bug 58787: add an advertisement to BorderPropertyTemplate. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:44:29 +00:00
Javen O'Neal
ede81720ee bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:40:20 +00:00
Javen O'Neal
d658ec8f95 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:27:18 +00:00
Javen O'Neal
e4e4cbb71e findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:02:33 +00:00
Javen O'Neal
64ae6dc0ff findbugs: fix SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:38:53 +00:00
Javen O'Neal
84113f3c63 findbugs: fix SF_SWITCH_FALLTHROUGH warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:12:35 +00:00
Javen O'Neal
6c5cd8e400 findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 05:34:02 +00:00
Javen O'Neal
b148307f0f findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 05:06:47 +00:00
Javen O'Neal
1853126f9b findbugs: fix URF_UNREAD_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:42:59 +00:00
Javen O'Neal
81d15d29df whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748083 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:34:37 +00:00
Javen O'Neal
ddfb99fa47 consolidate findbugs filters using Or logic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:09:41 +00:00
Javen O'Neal
55b675a384 fix findbugs issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 03:48:30 +00:00
Javen O'Neal
9d58a47e0c bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf test copy constructor: make changes to same range: this is a better test for deepcopy 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f add copy constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:43:34 +00:00
Javen O'Neal
d68b4ea41d move colors in TestBorderPropertyTemplate to testclass constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:40:46 +00:00
Javen O'Neal
0ae778e5cd rewrite switch statements to not re-check the switch'd variable 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:43:16 +00:00
Javen O'Neal
a63d82bbee rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:03:23 +00:00
Javen O'Neal
67b7e97a9f rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:59:47 +00:00
Javen O'Neal
ad98f81e5f move check if border line style is blank before setting the border color to a helper function for readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:57:37 +00:00
Javen O'Neal
344b9d9884 remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key. 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:33:24 +00:00
Javen O'Neal
513dfc5ff1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:02:38 +00:00
Javen O'Neal
e6937956f2 use CellAddress in unit tests where possible to improve readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:01:30 +00:00
Javen O'Neal
3530aa3bf2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:00:45 +00:00
Javen O'Neal
f9c7ae0102 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:35:56 +00:00
Andreas Beeker
a696823927 fixing javadocs errors (in JDK8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:28:13 +00:00
Andreas Beeker
a1ff5002a5 fixing javadocs errors (in JDK8) 
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 20:19:59 +00:00
Andreas Beeker
1ace43ba9f javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 19:54:35 +00:00
Andreas Beeker
0ef5f1d292 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 16:57:15 +00:00
Andreas Beeker
feead38601 ignore invalid performance issues - e.g. see #57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 01:18:12 +00:00
Andreas Beeker
6a6aa540eb revert back to changes of bug 57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:54:01 +00:00
Andreas Beeker
f919e8bd8a Common-SS: changed UDFFinder from interface to abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:20:52 +00:00
Andreas Beeker
81d891921b findbugs fixes 
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:12:22 +00:00
Dominik Stadler
b9ceae5ef3 Add some pre-checks to fail the test with better assertion if the locale is not set correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 17:03:59 +00:00
Javen O'Neal
61f0e58abb make CellRangeAddresses easier to cross-reference the example with the written out workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:18:04 +00:00
Javen O'Neal
16fb41d5f1 make these classes more discoverable/searchable using more specific names 
rename PropertyTemplate to BorderPropertyTemplate
  rename Extent to BorderExtent

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:09:23 +00:00
Javen O'Neal
9e54ef68cb bug 57840: lazily compute hashCode; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:40:30 +00:00
Javen O'Neal
55546a5495 whitespace (tabs to spaces, 3-space to 4-space) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:35:18 +00:00
Javen O'Neal
be9b615048 bug 57840: add disabled unit test with large number of structured reference formulas 
patch and spreadsheet contributed by Mark Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:28:55 +00:00
Javen O'Neal
cea8cc65a3 javadoc update and boolean addLeft|Right|Top|Bottom line wrap update 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:12:04 +00:00
Javen O'Neal
66498c10af fix spelling in javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:01:48 +00:00
Javen O'Neal
7c90716fdc fix javadocs: remove unnecessary @links, remove references to CellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 10:09:05 +00:00
Javen O'Neal
ad11547c8a move loop-invariants outside the loop for readability and execution speed 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:58:12 +00:00
Javen O'Neal
bd22a7be43 replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.* 
update PropertyTemplate functions to require enum instead of short borderType

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:15:57 +00:00
Dominik Stadler
9880040b1b Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:45:41 +00:00
Javen O'Neal
7dc4706edf continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679 add helper functions for verifying template properties were set correctly 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577 whitespace (unwrap lines) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f shorten PropertyTemplate.Extent to Extent 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158 bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy 
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 06:47:25 +00:00
Javen O'Neal
249bdf8661 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 04:27:21 +00:00
Javen O'Neal
8673812492 methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 03:05:31 +00:00
Javen O'Neal
ed3364b6d2 bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:28:21 +00:00
Javen O'Neal
69ded5b7b0 whitespace (tabs to spaces); +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:12:43 +00:00
Javen O'Neal
e3beb3abdd bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:10:32 +00:00
Javen O'Neal
6d03eafcfe bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:48:37 +00:00
Javen O'Neal
9ca89c2278 add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:41:54 +00:00
Javen O'Neal
649f2df1e9 add crude unit tests for UDFFinder classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:38:27 +00:00
Javen O'Neal
44c9a66906 remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:51:12 +00:00
Javen O'Neal
6ed13b4b5b add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:57 +00:00
Javen O'Neal
3ff5a7669f fix typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:33 +00:00
Javen O'Neal
cd4058fd60 bug 57840: initialize the column header cache with 50% empty space 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:38:42 +00:00
Javen O'Neal
52e866f4bc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:34:22 +00:00
Javen O'Neal
9aaa2bd51e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:16:14 +00:00
Javen O'Neal
82134e3d8a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:15:00 +00:00
Javen O'Neal
1a906b4d68 bug 57840: add test using a Data Table not anchored at A1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747819 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:11:41 +00:00
Andreas Beeker
12c7c32187 fix text height test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747803 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 21:29:47 +00:00
Javen O'Neal
c8627bb8b2 bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:45:14 +00:00
Javen O'Neal
71e3aa52fd bug 57840: add unit test for XSSFTable.findColumnIndex 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:10:52 +00:00
Javen O'Neal
a6f21296cc bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:13:45 +00:00
Javen O'Neal
97adda6169 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747752 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:12:28 +00:00
Javen O'Neal
ce5eccd8f5 bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747740 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 16:36:59 +00:00
Javen O'Neal
db6ceaa7fa bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:52:44 +00:00
Javen O'Neal
79ebd4915d findbugs: SBSC_USE_STRINGBUFFER_CONCATENATION FormulaParser.parseAsColumnQuantifier() concatenates strings using + in a loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747685 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:16:16 +00:00
Nick Burch
1197db5415 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747674 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:42:09 +00:00
Nick Burch
937519fad5 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747673 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:40:26 +00:00
Javen O'Neal
bec8fbe92c fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:16:41 +00:00
Javen O'Neal
30dc1a4d30 add missing AL header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747669 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:10:41 +00:00
Javen O'Neal
a5f82ba8b0 fix spelling error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747659 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:45:31 +00:00
Javen O'Neal
1da2c2d2d1 close opened workbooks in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747656 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:36:22 +00:00
Javen O'Neal
954d5f8be4 bug 57840: add structured reference formula parsing tests from FormulaParser.parseStructuredReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747655 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:33:30 +00:00
Javen O'Neal
95df2cc417 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747638 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 05:38:10 +00:00
Javen O'Neal
f17c9a9c25 ooxml o.a.p.ss.formula.TestFormulaParser junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747633 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:57:04 +00:00
Javen O'Neal
3de47c1c6f whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747632 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:45:58 +00:00
Javen O'Neal
65c7d551e6 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747628 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:40:56 +00:00
Javen O'Neal
068bb510be bug 57840: add javadocs (warn about stale XSSFTable cache), remove rowIndex argument from calls to FormulaParser.parse(String, FormulaParsingWorkbook, FormulaType, int sheetIndex) when rowIndex is irrelevant, clear xmlColumnPr and commonXPath during updateHeaders so that users have a mechanism to clear invalidated cached values 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:20:41 +00:00
Javen O'Neal
1c2b9b3103 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:51:45 +00:00
Javen O'Neal
12a8f5b603 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:01:15 +00:00
Javen O'Neal
b983f435d1 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747622 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:57:13 +00:00
Javen O'Neal
3732a24a42 bug 57840: check for null to avoid NPE; add unit test for XSSFWorkbook.getTable() 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747621 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:52:08 +00:00
Javen O'Neal
1817337056 bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747616 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:08:05 +00:00
Javen O'Neal
5b983791aa bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747615 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:02:05 +00:00
Javen O'Neal
588c19e9d3 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747614 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:26:39 +00:00
Javen O'Neal
83abda843a bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747612 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:59 +00:00
Javen O'Neal
944901f8f2 bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747611 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:21 +00:00
Andreas Beeker
6e477490f9 #59686 - Error when trying to access XSLFTableCell properties like textHeight, lineWidth, etc. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747605 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 23:06:42 +00:00
Javen O'Neal
fe44b01cd3 bug 57840: add Table interface for Structured References. Patch from Daniel Livshen and Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747602 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 22:47:35 +00:00
Andreas Beeker
8dbe0b3cd8 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747327 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:38:05 +00:00
Andreas Beeker
f29eb91c08 Add XSSF support to ForkedEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747326 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:15:40 +00:00
Andreas Beeker
3387617db8 #59170 - Remove deprecated classes (POI 3.15) - remove BuiltinFormats.getBuiltinFormats() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747325 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:13:57 +00:00
Javen O'Neal
9c19717151 add comments and make the statefulness of localeIsAdapting more obvious. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 08:54:08 +00:00
Javen O'Neal
914fb92f3c make emulateCSV final, add a single common all-inclusive (private) constructor that all other constructors tree up to and invert the constructors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747163 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 07:39:40 +00:00
Javen O'Neal
b84f05a44c replace Obervable with Observable; emulateCsv with emulateCSV 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747152 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:37:24 +00:00
Javen O'Neal
74be4d4174 bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:18:44 +00:00
Andreas Beeker
a749f7f3f5 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747093 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:54:29 +00:00
Andreas Beeker
60d35b92c6 close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747092 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:34:17 +00:00
Andreas Beeker
b8e38304f2 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:33:00 +00:00
Dominik Stadler
ee222dc91d Fix test-failure in Maven builds that I introduced by manually deleting the temporary directory in the test. The Maven build runs these in one process and thus the directory was not re-created any more. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746933 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:55:48 +00:00
Andreas Beeker
c423015a1b try to find out temp file errors on maven build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746932 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:49:18 +00:00
Andreas Beeker
9b05849946 PPTX2PNG - don't complain about missing output dir, when in testing mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746893 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 10:18:14 +00:00
Andreas Beeker
bd2b438ee1 Regression fix for XSLF 
- master style was always overridden, because of r1745100
- AIOOB in TextDirection mapping

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 01:04:58 +00:00
Andreas Beeker
d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-04 22:53:00 +00:00
Dominik Stadler
1caa8ff288 Try to not fail if the time-webservice is offline temporarily 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-03 06:01:27 +00:00
Nick Burch
52537ae58e Add disabled test for XWPF writing to a new stream when opened read-only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746653 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 22:59:47 +00:00
Dominik Stadler
1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:14:28 +00:00
Dominik Stadler
6b6aa56455 Avoid NPE in XWPFTableCell, taken from https://github.com/prasad-babu/poi/tree/WORKING_BRANCH 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:44 +00:00
Dominik Stadler
ee6c0625d0 Try to reproduce bug 57798 but it seems to be fixed in the meantime 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746624 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:35 +00:00
Dominik Stadler
aee2959a64 Bug 59378: Try to reproduce, but could not 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:25 +00:00
Dominik Stadler
aad52afa12 The changes for using AccessController/SecurityManager also added a log which now spams a lot if log is enabled in integration-tests, reduce it a bit by not trying to call "cleaner()" on HeapByteBuffer which does not have it for sure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746411 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-01 08:05:07 +00:00
Nick Burch
e9a1e2987f Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746286 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 15:08:14 +00:00
Dominik Stadler
7cb15d81db Change logger.log to System.out to print out one line for each file that is handled in the test, otherwise it is sometimes impossible to see where the test stopped (e.g. on timeout), enabling POILogger leads to 400MB logs, which is usually too much to handle... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746275 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:52:16 +00:00
Dominik Stadler
68102762fd Fix some compiler/IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746274 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:48:25 +00:00
Dominik Stadler
505e695099 Bug 57838: Also remove comments when removing a row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746062 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:47 +00:00
Dominik Stadler
a2bd714e55 Update error message to better indicate that we need a sample-file here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746061 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:39 +00:00
Dominik Stadler
d53ad74c37 Remove the created temporary directory after the test again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746060 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:33 +00:00
Dominik Stadler
a9f9290bb7 Try to access set/getVisible as well in TestXSSFVMLDrawing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746058 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:24 +00:00
Andreas Beeker
334ec509fa fix handling of hsl and linear rgb (%-values) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 23:39:23 +00:00
Dominik Stadler
10ce4e23a6 Adjust two tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745370 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:48:57 +00:00
Dominik Stadler
a7df6604a4 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes 
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:17:52 +00:00
Nick Burch
6c976b6700 Fix inconsistent spacing / whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745361 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:39:46 +00:00
Nick Burch
dccad7fb92 Another exclude 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745358 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:32:33 +00:00
Nick Burch
2ff845b852 Whitespace fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745357 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:30:58 +00:00
Nick Burch
d71d796f62 Copy out code from the site and fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745348 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 12:16:13 +00:00
Andreas Beeker
592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:58:07 +00:00
Andreas Beeker
dae1a761fd XSLF: remove creation of empty paragraph in XSLFTextShape.addNewTextParagraph() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745100 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:57:14 +00:00
Dominik Stadler
e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 16:08:51 +00:00
Andreas Beeker
3d60c67151 fix junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744821 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-21 04:06:49 +00:00
Andreas Beeker
e58f6f3fb0 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 22:05:00 +00:00
Andreas Beeker
e5393711b7 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744797 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 21:02:49 +00:00
Dominik Stadler
ae32e5f677 Fix some compiler warnings, close resources in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744636 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:19 +00:00
Dominik Stadler
2e4095deeb Apply patch for bug 59355: XSSFPivotTable::addColumnLabel sets the cell type of a cell outside of the source data area 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744635 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:08 +00:00
Andreas Beeker
eb111ce81f findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 23:34:52 +00:00
Dominik Stadler
0c78005743 Bug 59427: Add a check to better report cases when a document is already closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:34 +00:00
Dominik Stadler
df72dbfbed Revert expected failure as it seems to be fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744305 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:27 +00:00
Dominik Stadler
6a223ec11e BiffViewer: Close resources always 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:21 +00:00
Dominik Stadler
ff055532c1 Exclude newly added corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744211 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:16 +00:00
Andreas Beeker
e28fff0423 ignore external relations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 07:23:34 +00:00
Andreas Beeker
7b282db0e2 Move reflection-equals to POITestCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744169 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 23:28:25 +00:00
Andreas Beeker
61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 21:04:00 +00:00
Andreas Beeker
33241e821f add asl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744021 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:54:02 +00:00
Andreas Beeker
73108582a0 deprecation fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:52 +00:00
Andreas Beeker
1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:22 +00:00
Andreas Beeker
306edb91e5 sonar fix - reduce complexity by using constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:04:46 +00:00
Andreas Beeker
fa00834766 Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744005 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:02:13 +00:00
Andreas Beeker
20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:01:36 +00:00
Andreas Beeker
2e5f0132c5 Sonar fixes - array is stored directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:57:19 +00:00
Andreas Beeker
84be4acea9 Dispose XmlCursor 
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:54:01 +00:00
Andreas Beeker
12425ac107 added commons-logging to integration test to make profiling easier - just match the timestamps of the log with the timestamps of the profiling monitor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744001 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:49:17 +00:00
Andreas Beeker
dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:38:42 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-13 23:50:39 +00:00
Javen O'Neal
4a3acf4de0 add @since to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:47:49 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:09:41 +00:00
Javen O'Neal
fe04abd31d fix BasteTestCellComment#attemptToSave2CommentsWithSameCoordinates to work with different behaviors of HSSFWorkbook and XSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742871 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 04:29:17 +00:00
Javen O'Neal
e9bfa9da87 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:53:55 +00:00
Javen O'Neal
a92163e9b6 add disabled unit test for bug 59393 from stone 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742868 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:49:16 +00:00
Javen O'Neal
88d0eee64b move TestHSSFComment#attemptToSave2CommentsWithSameCoordinates down to BaseTestCellComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742866 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:35:45 +00:00
Javen O'Neal
94e4eb5276 merge TestComment into TestHSSFComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742865 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:27:32 +00:00
Javen O'Neal
25552a1453 add test case from Anders Åberg for bug 59442 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742862 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:27:31 +00:00
Javen O'Neal
3920d0660c Test CellUtil with XSSFWorkbook and SXSSFWorkbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742860 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:12:25 +00:00
Javen O'Neal
9fba427794 convert TestCellUtil to BaseTestCellUtil so that it can be tested with different workbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742859 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:09:36 +00:00
Andreas Beeker
f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-08 13:28:11 +00:00
Dominik Stadler
61f84af565 Try to print out more information if the timestamp-operation fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:44 +00:00
Dominik Stadler
d158ef23bd Close file-handles in tests as well to avoid noise when running file-leak-detection 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742424 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:37 +00:00
Dominik Stadler
8908412e3a Some general code-fixes found while trying out Java 9 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:31 +00:00
Dominik Stadler
56c5bd05e1 Try to catch more network-unavailable cases in TestSignatureInfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742422 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:23 +00:00
Dominik Stadler
26de463419 Refactor SSPerformanceTest into a few methods to make it easier to use a profiler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742420 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:16 +00:00
Andreas Beeker
f688ed96c6 #59327 - Setting text direction on a table cell has no effect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-04 22:09:10 +00:00
Javen O'Neal
808254af89 bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-26 22:48:02 +00:00
Javen O'Neal
20b11d54b1 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739689 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:47:06 +00:00
Javen O'Neal
480ec67d81 add unit test for SXSSFSheet#changeRowNum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739688 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:46:05 +00:00
Javen O'Neal
1e07b01af3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739661 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:51:16 +00:00
Javen O'Neal
ba64b65412 add unit test for StringUtil#join 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739660 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:28:49 +00:00
Javen O'Neal
556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:17:04 +00:00
Javen O'Neal
dca380f057 reformat exclude classes regular expression for OOXMLLite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:02:17 +00:00
Javen O'Neal
ae5b894886 upgrade TestPaletteRecord to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739587 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:40:18 +00:00
Javen O'Neal
e66fc6b289 bug 58896: write autoSizeColumn timing to POILogger instead of standard output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739584 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:36:50 +00:00
Javen O'Neal
e678eeb582 revert r1739548 and r1739550. I could not figure out how to add BaseTestXWorkbook|Sheet|Row.java without causing junit to complain about 'Test class should have exactly one public constructor' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739580 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:25:35 +00:00
Javen O'Neal
0b9fea928e add comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739554 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:42:26 +00:00
Javen O'Neal
da6d61f83b consolidate duplicates between TestXSSF* and TestSXSSF* 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739552 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:40:27 +00:00
Javen O'Neal
144758da98 add junit test classes for combined testing of XML-specific functionality of (S)XSSF Workbook, Sheet, and Row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739550 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:06:30 +00:00
Javen O'Neal
ec84916a9f bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:39:36 +00:00
Javen O'Neal
4d4b54b7c8 bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:38:15 +00:00
Javen O'Neal
3ba74f8319 bug 59340: lookup IndexedColors by index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739539 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:39:21 +00:00
Javen O'Neal
48bba39dcf move unit test for XSSFSheet.setTabColor from TestXSSFWorkbook to TestXSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739538 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:35:58 +00:00
Javen O'Neal
4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 01:29:19 +00:00
Javen O'Neal
f3af2a116b bug 59336: patch from Mark Murphy: replace deprecated usage of functions in CellUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739533 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:32:32 +00:00
Javen O'Neal
6043813e67 bug 59338: patch from Mark Murphy to deprecate HSSFCellUtil class in favor of CellUtil. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739531 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:20:37 +00:00
Javen O'Neal
393ccc1873 fix Sonar warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 22:44:28 +00:00
Javen O'Neal
ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 18:48:31 +00:00
Javen O'Neal
d94ff1aa8e javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738789 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:19:49 +00:00
Javen O'Neal
a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:03:24 +00:00
Javen O'Neal
9e389627cc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738773 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:28:25 +00:00
Javen O'Neal
cb5544ad9f fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738765 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:12:57 +00:00
Javen O'Neal
aa6083ce0a add LINK_TYPE_SECONDARY_CATEGORIES, which appears to be a valid type (0x03) based on HSSFChart.insertData 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738762 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:03:58 +00:00
Dominik Stadler
78a05ca7a0 Fix compiler warnings and ensure CTChartSheets stays included and is not refactored out by automated import reorganization 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 10:09:44 +00:00
Javen O'Neal
921c9b9e4b junit4 assert* improvements, add CTChartsheet to unit test so that it's compiled into poi-ooxml-schemas.jar (if it isn't already) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738742 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 09:22:48 +00:00
Javen O'Neal
db25900315 convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738738 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 08:51:45 +00:00
Dominik Stadler
4010992ac2 Exclude file that was modified and now fails with the known limitation of sheet-cloning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738704 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 06:56:06 +00:00
Javen O'Neal
68ac23176f convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738680 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:43:33 +00:00
Javen O'Neal
a4808bb56c whitespace: +svn:eol-style=native, tabs to 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738679 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:21:01 +00:00
Javen O'Neal
4260aa76c2 javadoc typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:13:52 +00:00
Javen O'Neal
d59c08e954 fix javadocs and findbugs warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 01:30:20 +00:00
Javen O'Neal
5e51b9e89b bug 52949: add unit test for reading VBA Macros from a Visio OOXML (VSDM, 2013+) file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738651 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 21:35:22 +00:00
Javen O'Neal
bbf912dceb bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 05:54:17 +00:00
Javen O'Neal
d6252e00b1 bug 52949: fix forbidden apis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 01:26:09 +00:00
Javen O'Neal
f49047e733 add @NotImplemented annotation to methods that are not implemented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 21:28:41 +00:00
Javen O'Neal
f2e250d7e4 ignore VBA source files in integration test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738460 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 20:21:55 +00:00
Javen O'Neal
f49897de27 bug 52949: parameterize fromNPOIFS also 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738439 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:46:42 +00:00
Javen O'Neal
9f36d6c876 bug 52949: prepare for adding DOC/DOCM and PPT/PPTM test cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738438 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:33:47 +00:00
Javen O'Neal
014d371a5f bug 52949: add junit test for RLEDecompressingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:09:02 +00:00
Javen O'Neal
8898db6b2e svn propset svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:05:33 +00:00
Nick Burch
d7981342e0 Javadoc tweaks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 13:02:36 +00:00
Nick Burch
e8e1a294e6 Make the extractor exactly that, powered by the reader #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:59:38 +00:00
Nick Burch
2185e91883 Unit test for VBA macro reading #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:45:53 +00:00
Nick Burch
82351e8fea Start to refactor VBAMacroExtractor into a more general class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:54:09 +00:00
Nick Burch
4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:16:49 +00:00
Dominik Stadler
2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 09:40:40 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-08 14:36:05 +00:00
Dominik Stadler
3718d45538 In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-07 07:25:02 +00:00
Dominik Stadler
5c1780aa72 Close two more file-handles in Example FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:20 +00:00
Dominik Stadler
8b10d4d71b Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:14 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message 
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:47 +00:00
Dominik Stadler
2c4a66ee49 Add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 10:52:36 +00:00
Dominik Stadler
5dc647da61 Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 09:00:05 +00:00
Nick Burch
a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:28:14 +00:00
Javen O'Neal
7fd89e0e39 add test coverage for TestSXSSFCell.toString() on blank and date cells 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:01:26 +00:00
Javen O'Neal
f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 05:15:15 +00:00
Javen O'Neal
bed6a46d10 bug 59264: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 04:32:36 +00:00
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:30:37 +00:00
Javen O'Neal
e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:38:55 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-03 18:32:22 +00:00
Dominik Stadler
e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:56 +00:00
Dominik Stadler
205055b83c Prevent us from changing the file with every test-run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:49 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor 
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:43 +00:00
Dominik Stadler
1985e23f59 Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 06:38:39 +00:00
Nick Burch
29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 07:17:04 +00:00
Dominik Stadler
88e9ff08db Enhance integration tests to call some of the common examples/devtools to also trigger these with all sample files, currently XLSX2CSV, BiffViewer, FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737308 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 06:25:49 +00:00
Tim Allison
26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 00:57:56 +00:00
Dominik Stadler
316c1fe307 Bug 57930: Add support for inlineString in FromHowTo 
Also do not require an Apache Xerces Parser, let the JDK choose an available one instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737247 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 14:39:11 +00:00
Dominik Stadler
12f99cc9d5 Adjust integration tests, fix compilation warnings, make the check on "EXPECTED_EXTRACTOR_FAILURES" actually work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737242 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:56:27 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets. 
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:27:20 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default 
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory 
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:49:45 +00:00
Andreas Beeker
ceda10fa32 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:20:29 +00:00
Javen O'Neal
4f4531c67e assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:09:50 +00:00
Javen O'Neal
6b6b6a668e add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:04:37 +00:00
Javen O'Neal
01b20a6567 make OPCPackage logger final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 05:01:02 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 17:29:00 +00:00
Javen O'Neal
4fe9f0bcab make private member variable ctColor final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 06:37:34 +00:00
Javen O'Neal
784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-23 16:42:04 +00:00
Javen O'Neal
1128818a70 bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:22:03 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily 
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:51:39 +00:00
Javen O'Neal
dd308cd87e return unmodifiable shared strings to guarentee parallel data structures stay in sync 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:04:51 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 04:20:45 +00:00
Javen O'Neal
e89f19bef3 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 02:31:16 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 00:14:21 +00:00
Andreas Beeker
8be67e1910 fix eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-20 13:36:56 +00:00
Andreas Beeker
b09c85ff04 eclipse warning fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 23:12:28 +00:00
Andreas Beeker
87f4e8fa63 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 22:21:12 +00:00
Andreas Beeker
488ce5fec3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 21:34:03 +00:00
Andreas Beeker
33991bfd98 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:30:19 +00:00
Andreas Beeker
7652be2ed1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735323 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:34:26 +00:00
Andreas Beeker
d749785d1f sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735321 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:27:56 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:10:27 +00:00
Andreas Beeker
4c4d718f52 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735316 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:59:40 +00:00
Andreas Beeker
a7c073ada9 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735312 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:46:28 +00:00
Andreas Beeker
ac6a01898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735301 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:20:15 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter. 
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:18:58 +00:00
Andreas Beeker
52fe2e4571 Fix for Softmaker Office files, which set encryption settings invalidly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735298 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:05:37 +00:00
Tim Allison
81e49eff0f 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 17:52:42 +00:00
Nick Burch
560ce3ee0b Ignore ODS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735079 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 14:17:47 +00:00
Nick Burch
197458b30c One final invalid file type check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:30:45 +00:00
Nick Burch
700fe05e34 Push all the zip opening logic into ZipHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:03:30 +00:00
Nick Burch
0fab07ccfc Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:56:28 +00:00
Nick Burch
5f2f0adfae Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:54:16 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:50:57 +00:00
Dominik Stadler
4a98bd4c27 Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 12:00:27 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:38 +00:00
Dominik Stadler
3c1052e375 Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:27 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 19:31:32 +00:00
Andreas Beeker
045123e198 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734809 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 14:12:43 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:33 +00:00
Dominik Stadler
f1a476d83a Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:26 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class 
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles 
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes 
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:56 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place 
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:43 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-11 23:14:09 +00:00
Andreas Beeker
630bdd0f15 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:32:33 +00:00
Andreas Beeker
1b9523898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 10:57:52 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 00:41:02 +00:00
Dominik Stadler
e444b4b01a Fix source rebuilding verification after resulting binaries in dist-folder changed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-07 08:32:11 +00:00
Nick Burch
ea9169b3c4 Comment and Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-01 18:11:14 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:36:58 +00:00
Dominik Stadler
4ad3d7b35a Exclude file for bug 59074 for some more tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 19:40:25 +00:00
Andreas Beeker
a7ca3d19ae find bugs fix - WMF_HEADER_MAGIC isn't final but should be 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 15:24:14 +00:00
Dominik Stadler
2fa065d96c Also mark the file for bug 59074 as expected-failure for integration testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:53 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:43:59 +00:00