moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,702 Commits 29 Branches 84 Tags 722 MiB
85963a56f7
Commit Graph

7100 Commits

Author SHA1 Message Date
Javen O'Neal
3369507cac bug 59170: remove deprecated o.a.p.hwpf.usermodel.CharacterRun#cloneProperties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748785 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:09:05 +00:00
Javen O'Neal
5fe6c32f85 bug 59170: add version when deprecated 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748784 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 01:00:38 +00:00
Javen O'Neal
ae12cfcd57 bug 59170: remove deprecated HSLF and HWPF methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748783 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:55:22 +00:00
Javen O'Neal
45ec02487c bug 59170: remove deprecated o.a.p.hdgf.HDGFDiagram constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748782 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:36:19 +00:00
Javen O'Neal
d77a3f9058 whitespace (3 spaces to tab) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748781 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:35:29 +00:00
Javen O'Neal
c3833b5ce7 bug 59170: remove deprecated o.a.p.xwpf.model.XWPFHyperlinkDecorator class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748780 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-17 00:20:48 +00:00
Javen O'Neal
d7fc37b2db bug 59170: remove deprecated o.a.p.openxml4j.opc.internal.CnotentType#getParameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748778 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-16 23:52:54 +00:00
Javen O'Neal
0472d9d861 bug 55385: deprecate Font.getBoldweight and Font.setBoldweight 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-16 06:51:53 +00:00
Javen O'Neal
5028639443 add disabled unit test for bug 55273: contributed by Martin Studer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748606 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 16:36:31 +00:00
Javen O'Neal
b99c753158 fix javadocs @link error for removed o.a.p.hssf.util.CellRangeAddress 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748496 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:32:17 +00:00
Javen O'Neal
4243208ade bug 59170: remove deprecated XSSFExcelExtractor(String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748495 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:26:14 +00:00
Javen O'Neal
9b217ab2da bug 59170: remove deprecated o.a.p.openxml4j.opc.Package 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748494 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:22:49 +00:00
Javen O'Neal
7228082d6b bug 59170: remove deprecated XSSFFontFormatting#getXSSFColor that was deprecated in 3.13 beta 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748493 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:22:26 +00:00
Javen O'Neal
ff3ccad347 add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748491 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 04:08:56 +00:00
Javen O'Neal
aeddbc05e4 whitespace (2 spaces or tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748489 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:55:45 +00:00
Javen O'Neal
f2390589dc bug 59170: remove deprecated writeTo method in @Internal PAPBinTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748488 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:42:18 +00:00
Javen O'Neal
2b7649cbd6 whitespace (2 spaces to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748487 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:34:56 +00:00
Javen O'Neal
46a36df416 remove deprecated constructor for @Internal PAPBinTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748486 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:31:41 +00:00
Javen O'Neal
552ccb58e4 update WriteAuthorAntTitle example to Java 1.6+ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748485 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:29:31 +00:00
Javen O'Neal
e355d20cfa bug 59170: remove deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 03:26:58 +00:00
Javen O'Neal
ea30ed25b4 bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748482 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:56:56 +00:00
Javen O'Neal
ccdc23ab43 bug 59170: remove deprecated methods in o.a.p.hpsf.wellknown.SectionIDMap 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748481 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:48:23 +00:00
Javen O'Neal
e9be07056b bug 59170: remove deprecated hpsf.Constants class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748480 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 02:47:04 +00:00
Javen O'Neal
07c65c3fc4 bug 57840: add comments for explicit boxing performance optimization 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748479 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-15 01:42:11 +00:00
Javen O'Neal
72ef600ce0 remove RegionUtil reference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748473 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-14 21:57:38 +00:00
Andreas Beeker
f83ff6f8ce javadoc fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 23:08:13 +00:00
Andreas Beeker
d8437d0476 reverted changes of r1747942 and deprecated instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 21:18:50 +00:00
Javen O'Neal
227a62ce1e back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 18:14:26 +00:00
Javen O'Neal
beef6df971 back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 18:12:29 +00:00
Javen O'Neal
4a85959d45 Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748175 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:55:49 +00:00
Javen O'Neal
e61e346436 add HSSFCell.setCachedErrorResult(FormulaError) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748174 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:53:03 +00:00
Javen O'Neal
ef3564968a type check error code when setting cell error value on HSSFCell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748172 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:29:38 +00:00
Javen O'Neal
8bf974b185 add useless unit test for o.a.p.ss.util.RegionUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 10:14:44 +00:00
Javen O'Neal
84924a4918 add periods for complete sentences 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748166 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:51:01 +00:00
Nick Burch
ae11fa3dae Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748158 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:39:36 +00:00
Nick Burch
b8c13b6cc8 Javadoc fixes - @see and @link can't be combined together, at least not in Java 6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748157 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 09:38:12 +00:00
Javen O'Neal
48eb5c521b improve unit test coverage on CellReference. 
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 08:58:55 +00:00
Javen O'Neal
48410a4224 fix accidental infinite recursion 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748143 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 08:55:41 +00:00
Javen O'Neal
4c89f44cc5 bug 58787: add an advertisement to BorderPropertyTemplate. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:44:29 +00:00
Javen O'Neal
ede81720ee bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:40:20 +00:00
Javen O'Neal
d658ec8f95 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:27:18 +00:00
Javen O'Neal
e4e4cbb71e findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:02:33 +00:00
Javen O'Neal
64ae6dc0ff findbugs: fix SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:38:53 +00:00
Javen O'Neal
84113f3c63 findbugs: fix SF_SWITCH_FALLTHROUGH warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:12:35 +00:00
Javen O'Neal
6c5cd8e400 findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 05:34:02 +00:00
Javen O'Neal
b148307f0f findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 05:06:47 +00:00
Javen O'Neal
1853126f9b findbugs: fix URF_UNREAD_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:42:59 +00:00
Javen O'Neal
81d15d29df whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748083 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:34:37 +00:00
Javen O'Neal
ddfb99fa47 consolidate findbugs filters using Or logic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:09:41 +00:00
Javen O'Neal
55b675a384 fix findbugs issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 03:48:30 +00:00
Javen O'Neal
9d58a47e0c bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf test copy constructor: make changes to same range: this is a better test for deepcopy 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f add copy constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:43:34 +00:00
Javen O'Neal
d68b4ea41d move colors in TestBorderPropertyTemplate to testclass constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:40:46 +00:00
Javen O'Neal
0ae778e5cd rewrite switch statements to not re-check the switch'd variable 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:43:16 +00:00
Javen O'Neal
a63d82bbee rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:03:23 +00:00
Javen O'Neal
67b7e97a9f rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:59:47 +00:00
Javen O'Neal
ad98f81e5f move check if border line style is blank before setting the border color to a helper function for readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:57:37 +00:00
Javen O'Neal
344b9d9884 remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key. 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:33:24 +00:00
Javen O'Neal
513dfc5ff1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:02:38 +00:00
Javen O'Neal
e6937956f2 use CellAddress in unit tests where possible to improve readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:01:30 +00:00
Javen O'Neal
3530aa3bf2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:00:45 +00:00
Javen O'Neal
f9c7ae0102 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:35:56 +00:00
Andreas Beeker
a696823927 fixing javadocs errors (in JDK8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:28:13 +00:00
Andreas Beeker
a1ff5002a5 fixing javadocs errors (in JDK8) 
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 20:19:59 +00:00
Andreas Beeker
1ace43ba9f javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 19:54:35 +00:00
Andreas Beeker
0ef5f1d292 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 16:57:15 +00:00
Andreas Beeker
feead38601 ignore invalid performance issues - e.g. see #57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 01:18:12 +00:00
Andreas Beeker
6a6aa540eb revert back to changes of bug 57840 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:54:01 +00:00
Andreas Beeker
f919e8bd8a Common-SS: changed UDFFinder from interface to abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:20:52 +00:00
Andreas Beeker
81d891921b findbugs fixes 
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:12:22 +00:00
Dominik Stadler
b9ceae5ef3 Add some pre-checks to fail the test with better assertion if the locale is not set correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 17:03:59 +00:00
Javen O'Neal
61f0e58abb make CellRangeAddresses easier to cross-reference the example with the written out workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:18:04 +00:00
Javen O'Neal
16fb41d5f1 make these classes more discoverable/searchable using more specific names 
rename PropertyTemplate to BorderPropertyTemplate
  rename Extent to BorderExtent

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:09:23 +00:00
Javen O'Neal
9e54ef68cb bug 57840: lazily compute hashCode; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:40:30 +00:00
Javen O'Neal
55546a5495 whitespace (tabs to spaces, 3-space to 4-space) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:35:18 +00:00
Javen O'Neal
be9b615048 bug 57840: add disabled unit test with large number of structured reference formulas 
patch and spreadsheet contributed by Mark Woolsey

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:28:55 +00:00
Javen O'Neal
cea8cc65a3 javadoc update and boolean addLeft|Right|Top|Bottom line wrap update 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:12:04 +00:00
Javen O'Neal
66498c10af fix spelling in javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:01:48 +00:00
Javen O'Neal
7c90716fdc fix javadocs: remove unnecessary @links, remove references to CellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 10:09:05 +00:00
Javen O'Neal
ad11547c8a move loop-invariants outside the loop for readability and execution speed 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:58:12 +00:00
Javen O'Neal
bd22a7be43 replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.* 
update PropertyTemplate functions to require enum instead of short borderType

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:15:57 +00:00
Dominik Stadler
9880040b1b Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:45:41 +00:00
Javen O'Neal
7dc4706edf continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:15:50 +00:00
Javen O'Neal
66875dbc1b continue simplifying using helper functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 08:08:04 +00:00
Javen O'Neal
8ad237f679 add helper functions for verifying template properties were set correctly 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:48:32 +00:00
Javen O'Neal
222e32d577 whitespace (unwrap lines) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:40:46 +00:00
Javen O'Neal
50d0a1197f shorten PropertyTemplate.Extent to Extent 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:10:21 +00:00
Javen O'Neal
fc6b8cdd0e +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158 bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy 
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 06:47:25 +00:00
Javen O'Neal
249bdf8661 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 04:27:21 +00:00
Javen O'Neal
8673812492 methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 03:05:31 +00:00
Javen O'Neal
ed3364b6d2 bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:28:21 +00:00
Javen O'Neal
69ded5b7b0 whitespace (tabs to spaces); +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:12:43 +00:00
Javen O'Neal
e3beb3abdd bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 02:10:32 +00:00
Javen O'Neal
6d03eafcfe bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:48:37 +00:00
Javen O'Neal
9ca89c2278 add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:41:54 +00:00
Javen O'Neal
649f2df1e9 add crude unit tests for UDFFinder classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:38:27 +00:00
Javen O'Neal
44c9a66906 remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to o.a.p.ss.formula.udf 3 years ago and was @Internal before that 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:51:12 +00:00
Javen O'Neal
6ed13b4b5b add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:57 +00:00
Javen O'Neal
3ff5a7669f fix typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:33 +00:00
Javen O'Neal
cd4058fd60 bug 57840: initialize the column header cache with 50% empty space 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:38:42 +00:00
Javen O'Neal
52e866f4bc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:34:22 +00:00
Javen O'Neal
9aaa2bd51e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:16:14 +00:00
Javen O'Neal
82134e3d8a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:15:00 +00:00
Javen O'Neal
1a906b4d68 bug 57840: add test using a Data Table not anchored at A1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747819 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:11:41 +00:00
Andreas Beeker
12c7c32187 fix text height test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747803 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 21:29:47 +00:00
Javen O'Neal
c8627bb8b2 bug 57840: add unit tests for XSSFTable methods; rename XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:45:14 +00:00
Javen O'Neal
71e3aa52fd bug 57840: add unit test for XSSFTable.findColumnIndex 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 18:10:52 +00:00
Javen O'Neal
a6f21296cc bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from Greg Woolsey 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:13:45 +00:00
Javen O'Neal
97adda6169 +props svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747752 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 17:12:28 +00:00
Javen O'Neal
ce5eccd8f5 bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747740 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 16:36:59 +00:00
Javen O'Neal
db6ceaa7fa bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:52:44 +00:00
Javen O'Neal
79ebd4915d findbugs: SBSC_USE_STRINGBUFFER_CONCATENATION FormulaParser.parseAsColumnQuantifier() concatenates strings using + in a loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747685 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:16:16 +00:00
Nick Burch
1197db5415 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747674 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:42:09 +00:00
Nick Burch
937519fad5 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747673 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:40:26 +00:00
Javen O'Neal
bec8fbe92c fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:16:41 +00:00
Javen O'Neal
30dc1a4d30 add missing AL header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747669 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:10:41 +00:00
Javen O'Neal
a5f82ba8b0 fix spelling error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747659 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:45:31 +00:00
Javen O'Neal
1da2c2d2d1 close opened workbooks in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747656 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:36:22 +00:00
Javen O'Neal
954d5f8be4 bug 57840: add structured reference formula parsing tests from FormulaParser.parseStructuredReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747655 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:33:30 +00:00
Javen O'Neal
95df2cc417 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747638 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 05:38:10 +00:00
Javen O'Neal
f17c9a9c25 ooxml o.a.p.ss.formula.TestFormulaParser junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747633 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:57:04 +00:00
Javen O'Neal
3de47c1c6f whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747632 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:45:58 +00:00
Javen O'Neal
65c7d551e6 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747628 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:40:56 +00:00
Javen O'Neal
068bb510be bug 57840: add javadocs (warn about stale XSSFTable cache), remove rowIndex argument from calls to FormulaParser.parse(String, FormulaParsingWorkbook, FormulaType, int sheetIndex) when rowIndex is irrelevant, clear xmlColumnPr and commonXPath during updateHeaders so that users have a mechanism to clear invalidated cached values 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:20:41 +00:00
Javen O'Neal
1c2b9b3103 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:51:45 +00:00
Javen O'Neal
12a8f5b603 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:01:15 +00:00
Javen O'Neal
b983f435d1 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747622 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:57:13 +00:00
Javen O'Neal
3732a24a42 bug 57840: check for null to avoid NPE; add unit test for XSSFWorkbook.getTable() 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747621 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:52:08 +00:00
Javen O'Neal
1817337056 bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747616 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:08:05 +00:00
Javen O'Neal
5b983791aa bug 57840: move XSSFTable cache from XSSFWorkbook to XSSFEvaluationWorkbook where staleness is less likely to cause problems for users 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747615 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:02:05 +00:00
Javen O'Neal
588c19e9d3 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747614 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:26:39 +00:00
Javen O'Neal
83abda843a bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747612 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:59 +00:00
Javen O'Neal
944901f8f2 bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747611 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:21 +00:00
Andreas Beeker
6e477490f9 #59686 - Error when trying to access XSLFTableCell properties like textHeight, lineWidth, etc. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747605 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 23:06:42 +00:00
Javen O'Neal
fe44b01cd3 bug 57840: add Table interface for Structured References. Patch from Daniel Livshen and Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747602 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 22:47:35 +00:00
Andreas Beeker
8dbe0b3cd8 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747327 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:38:05 +00:00
Andreas Beeker
f29eb91c08 Add XSSF support to ForkedEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747326 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:15:40 +00:00
Andreas Beeker
3387617db8 #59170 - Remove deprecated classes (POI 3.15) - remove BuiltinFormats.getBuiltinFormats() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747325 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:13:57 +00:00
Javen O'Neal
9c19717151 add comments and make the statefulness of localeIsAdapting more obvious. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 08:54:08 +00:00
Javen O'Neal
914fb92f3c make emulateCSV final, add a single common all-inclusive (private) constructor that all other constructors tree up to and invert the constructors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747163 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 07:39:40 +00:00
Javen O'Neal
b84f05a44c replace Obervable with Observable; emulateCsv with emulateCSV 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747152 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:37:24 +00:00
Javen O'Neal
74be4d4174 bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:18:44 +00:00
Andreas Beeker
a749f7f3f5 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747093 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:54:29 +00:00
Andreas Beeker
60d35b92c6 close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747092 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:34:17 +00:00
Andreas Beeker
b8e38304f2 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:33:00 +00:00
Dominik Stadler
ee222dc91d Fix test-failure in Maven builds that I introduced by manually deleting the temporary directory in the test. The Maven build runs these in one process and thus the directory was not re-created any more. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746933 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:55:48 +00:00
Andreas Beeker
c423015a1b try to find out temp file errors on maven build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746932 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:49:18 +00:00
Andreas Beeker
9b05849946 PPTX2PNG - don't complain about missing output dir, when in testing mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746893 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 10:18:14 +00:00
Andreas Beeker
bd2b438ee1 Regression fix for XSLF 
- master style was always overridden, because of r1745100
- AIOOB in TextDirection mapping

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746858 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 01:04:58 +00:00
Andreas Beeker
d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-04 22:53:00 +00:00
Dominik Stadler
1caa8ff288 Try to not fail if the time-webservice is offline temporarily 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-03 06:01:27 +00:00
Nick Burch
52537ae58e Add disabled test for XWPF writing to a new stream when opened read-only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746653 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 22:59:47 +00:00
Dominik Stadler
1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:14:28 +00:00
Dominik Stadler
6b6aa56455 Avoid NPE in XWPFTableCell, taken from https://github.com/prasad-babu/poi/tree/WORKING_BRANCH 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:44 +00:00
Dominik Stadler
ee6c0625d0 Try to reproduce bug 57798 but it seems to be fixed in the meantime 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746624 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:35 +00:00
Dominik Stadler
aee2959a64 Bug 59378: Try to reproduce, but could not 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:09:25 +00:00
Dominik Stadler
aad52afa12 The changes for using AccessController/SecurityManager also added a log which now spams a lot if log is enabled in integration-tests, reduce it a bit by not trying to call "cleaner()" on HeapByteBuffer which does not have it for sure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746411 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-01 08:05:07 +00:00
Nick Burch
e9a1e2987f Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746286 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 15:08:14 +00:00
Dominik Stadler
7cb15d81db Change logger.log to System.out to print out one line for each file that is handled in the test, otherwise it is sometimes impossible to see where the test stopped (e.g. on timeout), enabling POILogger leads to 400MB logs, which is usually too much to handle... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746275 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:52:16 +00:00
Dominik Stadler
68102762fd Fix some compiler/IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746274 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:48:25 +00:00
Dominik Stadler
505e695099 Bug 57838: Also remove comments when removing a row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746062 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:47 +00:00
Dominik Stadler
a2bd714e55 Update error message to better indicate that we need a sample-file here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746061 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:39 +00:00
Dominik Stadler
d53ad74c37 Remove the created temporary directory after the test again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746060 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:33 +00:00
Dominik Stadler
a9f9290bb7 Try to access set/getVisible as well in TestXSSFVMLDrawing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746058 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-29 21:33:24 +00:00
Andreas Beeker
334ec509fa fix handling of hsl and linear rgb (%-values) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 23:39:23 +00:00
Dominik Stadler
10ce4e23a6 Adjust two tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745370 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:48:57 +00:00
Dominik Stadler
a7df6604a4 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes 
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 14:17:52 +00:00
Nick Burch
6c976b6700 Fix inconsistent spacing / whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745361 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:39:46 +00:00
Nick Burch
dccad7fb92 Another exclude 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745358 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:32:33 +00:00
Nick Burch
2ff845b852 Whitespace fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745357 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 13:30:58 +00:00
Nick Burch
d71d796f62 Copy out code from the site and fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745348 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 12:16:13 +00:00
Andreas Beeker
592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:58:07 +00:00
Andreas Beeker
dae1a761fd XSLF: remove creation of empty paragraph in XSLFTextShape.addNewTextParagraph() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745100 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:57:14 +00:00
Dominik Stadler
e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 16:08:51 +00:00
Andreas Beeker
3d60c67151 fix junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744821 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-21 04:06:49 +00:00
Andreas Beeker
e58f6f3fb0 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 22:05:00 +00:00
Andreas Beeker
e5393711b7 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744797 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 21:02:49 +00:00
Dominik Stadler
ae32e5f677 Fix some compiler warnings, close resources in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744636 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:19 +00:00
Dominik Stadler
2e4095deeb Apply patch for bug 59355: XSSFPivotTable::addColumnLabel sets the cell type of a cell outside of the source data area 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744635 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-19 20:18:08 +00:00
Andreas Beeker
eb111ce81f findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 23:34:52 +00:00
Dominik Stadler
0c78005743 Bug 59427: Add a check to better report cases when a document is already closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744306 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:34 +00:00
Dominik Stadler
df72dbfbed Revert expected failure as it seems to be fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744305 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 19:08:27 +00:00
Dominik Stadler
6a223ec11e BiffViewer: Close resources always 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:21 +00:00
Dominik Stadler
ff055532c1 Exclude newly added corrupt file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744211 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:16 +00:00
Andreas Beeker
e28fff0423 ignore external relations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744196 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 07:23:34 +00:00
Andreas Beeker
7b282db0e2 Move reflection-equals to POITestCase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744169 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 23:28:25 +00:00
Andreas Beeker
61321b4b37 #54570 - InvalidFormatException because of Absolute URI forbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744137 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 21:04:00 +00:00
Andreas Beeker
33241e821f add asl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744021 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:54:02 +00:00
Andreas Beeker
73108582a0 deprecation fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744008 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:52 +00:00
Andreas Beeker
1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:22 +00:00
Andreas Beeker
306edb91e5 sonar fix - reduce complexity by using constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:04:46 +00:00
Andreas Beeker
fa00834766 Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744005 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:02:13 +00:00
Andreas Beeker
20fe8a5e0f Reduce calls to utf-related methods - the integration test took ages because of poc-shared-strings.xlsx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744004 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:01:36 +00:00
Andreas Beeker
2e5f0132c5 Sonar fixes - array is stored directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:57:19 +00:00
Andreas Beeker
84be4acea9 Dispose XmlCursor 
Replacing a method argument (XmlCursor) with a local instance and then updating it, doesn't make sense

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744002 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:54:01 +00:00
Andreas Beeker
12425ac107 added commons-logging to integration test to make profiling easier - just match the timestamps of the log with the timestamps of the profiling monitor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744001 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:49:17 +00:00
Andreas Beeker
dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:38:42 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-13 23:50:39 +00:00
Javen O'Neal
4a3acf4de0 add @since to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:47:49 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:09:41 +00:00
Javen O'Neal
fe04abd31d fix BasteTestCellComment#attemptToSave2CommentsWithSameCoordinates to work with different behaviors of HSSFWorkbook and XSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742871 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 04:29:17 +00:00
Javen O'Neal
e9bfa9da87 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:53:55 +00:00
Javen O'Neal
a92163e9b6 add disabled unit test for bug 59393 from stone 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742868 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:49:16 +00:00
Javen O'Neal
88d0eee64b move TestHSSFComment#attemptToSave2CommentsWithSameCoordinates down to BaseTestCellComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742866 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:35:45 +00:00
Javen O'Neal
94e4eb5276 merge TestComment into TestHSSFComment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742865 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:27:32 +00:00
Javen O'Neal
25552a1453 add test case from Anders Åberg for bug 59442 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742862 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:27:31 +00:00
Javen O'Neal
3920d0660c Test CellUtil with XSSFWorkbook and SXSSFWorkbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742860 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:12:25 +00:00
Javen O'Neal
9fba427794 convert TestCellUtil to BaseTestCellUtil so that it can be tested with different workbook instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742859 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 01:09:36 +00:00
Andreas Beeker
f850d93b68 #59434 - Cannot add a picture on a slide that already have an image with an hyperlink on it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742816 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-08 13:28:11 +00:00
Dominik Stadler
61f84af565 Try to print out more information if the timestamp-operation fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742425 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:44 +00:00
Dominik Stadler
d158ef23bd Close file-handles in tests as well to avoid noise when running file-leak-detection 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742424 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:37 +00:00
Dominik Stadler
8908412e3a Some general code-fixes found while trying out Java 9 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742423 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:31 +00:00
Dominik Stadler
56c5bd05e1 Try to catch more network-unavailable cases in TestSignatureInfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742422 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:23 +00:00
Dominik Stadler
26de463419 Refactor SSPerformanceTest into a few methods to make it easier to use a profiler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742420 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-05 12:22:16 +00:00
Andreas Beeker
f688ed96c6 #59327 - Setting text direction on a table cell has no effect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-04 22:09:10 +00:00
Javen O'Neal
808254af89 bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-26 22:48:02 +00:00
Javen O'Neal
20b11d54b1 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739689 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:47:06 +00:00
Javen O'Neal
480ec67d81 add unit test for SXSSFSheet#changeRowNum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739688 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-18 04:46:05 +00:00
Javen O'Neal
1e07b01af3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739661 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:51:16 +00:00
Javen O'Neal
ba64b65412 add unit test for StringUtil#join 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739660 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 21:28:49 +00:00
Javen O'Neal
556f1e78a1 restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:17:04 +00:00
Javen O'Neal
dca380f057 reformat exclude classes regular expression for OOXMLLite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:02:17 +00:00
Javen O'Neal
ae5b894886 upgrade TestPaletteRecord to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739587 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:40:18 +00:00
Javen O'Neal
e66fc6b289 bug 58896: write autoSizeColumn timing to POILogger instead of standard output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739584 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:36:50 +00:00
Javen O'Neal
e678eeb582 revert r1739548 and r1739550. I could not figure out how to add BaseTestXWorkbook|Sheet|Row.java without causing junit to complain about 'Test class should have exactly one public constructor' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739580 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 11:25:35 +00:00
Javen O'Neal
0b9fea928e add comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739554 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:42:26 +00:00
Javen O'Neal
da6d61f83b consolidate duplicates between TestXSSF* and TestSXSSF* 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739552 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:40:27 +00:00
Javen O'Neal
144758da98 add junit test classes for combined testing of XML-specific functionality of (S)XSSF Workbook, Sheet, and Row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739550 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:06:30 +00:00
Javen O'Neal
ec84916a9f bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739548 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:39:36 +00:00
Javen O'Neal
4d4b54b7c8 bug 59342: add sheet tab color getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739547 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 07:38:15 +00:00
Javen O'Neal
3ba74f8319 bug 59340: lookup IndexedColors by index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739539 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:39:21 +00:00
Javen O'Neal
48bba39dcf move unit test for XSSFSheet.setTabColor from TestXSSFWorkbook to TestXSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739538 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:35:58 +00:00
Javen O'Neal
4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 01:29:19 +00:00
Javen O'Neal
f3af2a116b bug 59336: patch from Mark Murphy: replace deprecated usage of functions in CellUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739533 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:32:32 +00:00
Javen O'Neal
6043813e67 bug 59338: patch from Mark Murphy to deprecate HSSFCellUtil class in favor of CellUtil. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739531 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:20:37 +00:00
Javen O'Neal
393ccc1873 fix Sonar warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738876 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 22:44:28 +00:00
Javen O'Neal
ecf7db3223 bug 59312: delete temporary files even when the output stream cannot be closed (such as out of disk space IOException) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738848 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 18:48:31 +00:00
Javen O'Neal
d94ff1aa8e javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738789 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:19:49 +00:00
Javen O'Neal
a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:03:24 +00:00
Javen O'Neal
9e389627cc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738773 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:28:25 +00:00
Javen O'Neal
cb5544ad9f fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738765 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:12:57 +00:00
Javen O'Neal
aa6083ce0a add LINK_TYPE_SECONDARY_CATEGORIES, which appears to be a valid type (0x03) based on HSSFChart.insertData 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738762 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:03:58 +00:00
Dominik Stadler
78a05ca7a0 Fix compiler warnings and ensure CTChartSheets stays included and is not refactored out by automated import reorganization 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 10:09:44 +00:00
Javen O'Neal
921c9b9e4b junit4 assert* improvements, add CTChartsheet to unit test so that it's compiled into poi-ooxml-schemas.jar (if it isn't already) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738742 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 09:22:48 +00:00
Javen O'Neal
db25900315 convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738738 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 08:51:45 +00:00
Dominik Stadler
4010992ac2 Exclude file that was modified and now fails with the known limitation of sheet-cloning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738704 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 06:56:06 +00:00
Javen O'Neal
68ac23176f convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738680 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:43:33 +00:00
Javen O'Neal
a4808bb56c whitespace: +svn:eol-style=native, tabs to 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738679 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:21:01 +00:00
Javen O'Neal
4260aa76c2 javadoc typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:13:52 +00:00
Javen O'Neal
d59c08e954 fix javadocs and findbugs warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 01:30:20 +00:00
Javen O'Neal
5e51b9e89b bug 52949: add unit test for reading VBA Macros from a Visio OOXML (VSDM, 2013+) file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738651 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 21:35:22 +00:00
Javen O'Neal
bbf912dceb bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 05:54:17 +00:00
Javen O'Neal
d6252e00b1 bug 52949: fix forbidden apis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 01:26:09 +00:00
Javen O'Neal
f49047e733 add @NotImplemented annotation to methods that are not implemented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 21:28:41 +00:00
Javen O'Neal
f2e250d7e4 ignore VBA source files in integration test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738460 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 20:21:55 +00:00
Javen O'Neal
f49897de27 bug 52949: parameterize fromNPOIFS also 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738439 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:46:42 +00:00
Javen O'Neal
9f36d6c876 bug 52949: prepare for adding DOC/DOCM and PPT/PPTM test cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738438 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:33:47 +00:00
Javen O'Neal
014d371a5f bug 52949: add junit test for RLEDecompressingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:09:02 +00:00
Javen O'Neal
8898db6b2e svn propset svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:05:33 +00:00
Nick Burch
d7981342e0 Javadoc tweaks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 13:02:36 +00:00
Nick Burch
e8e1a294e6 Make the extractor exactly that, powered by the reader #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:59:38 +00:00
Nick Burch
2185e91883 Unit test for VBA macro reading #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:45:53 +00:00
Nick Burch
82351e8fea Start to refactor VBAMacroExtractor into a more general class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:54:09 +00:00
Nick Burch
4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:16:49 +00:00
Dominik Stadler
2a0ed81538 Bug 57844: Add some javadoc for unimplemented features in SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738413 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 09:40:40 +00:00
Tim Allison
a060c664a1 close fileinputstream on second exception in ZipPackage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738251 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-08 14:36:05 +00:00
Dominik Stadler
3718d45538 In Example FromHowTo, open the OPCPacakge read-only to not try to write it back on close() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738097 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-07 07:25:02 +00:00
Dominik Stadler
5c1780aa72 Close two more file-handles in Example FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738035 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:20 +00:00
Dominik Stadler
8b10d4d71b Tried to evaluate all formulas in worksheets as part of the integration tests, but some documents fail and it probably increases runtime of tests considerably, so left commented out for now. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738034 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:14 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message 
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:47 +00:00
Dominik Stadler
2c4a66ee49 Add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737963 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 10:52:36 +00:00
Dominik Stadler
5dc647da61 Bug 56911: Fix IndexOutOfBoundsException in PlfLfo.add() and add minimal test, however these classes look quite untested and thus require more test-coverage to make them more robust 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737947 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 09:00:05 +00:00
Nick Burch
a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:28:14 +00:00
Javen O'Neal
7fd89e0e39 add test coverage for TestSXSSFCell.toString() on blank and date cells 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737923 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:01:26 +00:00
Javen O'Neal
f9c74888e3 add test coverage for WorkbookFactory.create(File file, String password, Boolean readOnly) when file does not exists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737917 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 05:15:15 +00:00
Javen O'Neal
bed6a46d10 bug 59264: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 04:32:36 +00:00
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:30:37 +00:00
Javen O'Neal
e2399abbe9 bug 59264: type safety: check if border code is a valid BorderStyle enum for setBorderX(short) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737886 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:38:55 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-03 18:32:22 +00:00
Dominik Stadler
e8263f9d8f Fix two more places where wrong/invalid files can lead to file-handle leaks currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737489 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:56 +00:00
Dominik Stadler
205055b83c Prevent us from changing the file with every test-run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737488 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:49 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor 
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:43 +00:00
Dominik Stadler
1985e23f59 Regression: Add unit-test which triggers more code deep inside XSLF to have some missing pieces included in the reduced ooxml-schema-jar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737466 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 06:38:39 +00:00
Nick Burch
29c2e05b58 Javadoc fix - Generics are type-erased so not included in the javadoc links 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737317 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 07:17:04 +00:00
Dominik Stadler
88e9ff08db Enhance integration tests to call some of the common examples/devtools to also trigger these with all sample files, currently XLSX2CSV, BiffViewer, FromHowTo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737308 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 06:25:49 +00:00
Tim Allison
26af28bbdb POI 59257 upgrade Bouncy Castle to 1.54 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737298 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-01 00:57:56 +00:00
Dominik Stadler
316c1fe307 Bug 57930: Add support for inlineString in FromHowTo 
Also do not require an Apache Xerces Parser, let the JDK choose an available one instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737247 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 14:39:11 +00:00
Dominik Stadler
12f99cc9d5 Adjust integration tests, fix compilation warnings, make the check on "EXPECTED_EXTRACTOR_FAILURES" actually work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737242 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:56:27 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets. 
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:30:55 +00:00
Dominik Stadler
ff68b433b8 Bug 58915: Update javadoc for memory consumption and fix some other javadoc and compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737024 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:27:20 +00:00
Dominik Stadler
00e6abb6bc Try to reproduce bug 58922, convert to JUnit 4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737018 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 16:11:29 +00:00
Dominik Stadler
0888ad4de5 Fix some compiler warnings, improve error message, cover some more code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737013 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 15:45:04 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 14:53:44 +00:00
Andreas Beeker
4eeffd0532 XSLF: do not display Master Slide objects by default 
XSLF: fix alternate content handling for picture shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736935 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:52:01 +00:00
Andreas Beeker
f8767e3981 some zips can't be opened via ZipFile in JDK6, as the central directory 
contains either non-latin entries or the compression type can't be handled
the workaround is to iterate over the stream and not the directory


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736933 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:49:45 +00:00
Andreas Beeker
ceda10fa32 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:22:08 +00:00
Dominik Stadler
8afb394974 Bug 59199: Handle null date-values in a similar way as null-Strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736923 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:20:29 +00:00
Javen O'Neal
4f4531c67e assertCloseDoesNotModifyFile method was adapted from method with the same name in TestWorkbookFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736744 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:09:50 +00:00
Javen O'Neal
6b6b6a668e add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 13:04:37 +00:00
Javen O'Neal
01b20a6567 make OPCPackage logger final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736721 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-27 05:01:02 +00:00
Javen O'Neal
f0e824587b bug 59224: change hasTint, add hasAlpha and unit tests. Patch from gubespam@gmail.com 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736469 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 17:29:00 +00:00
Javen O'Neal
4fe9f0bcab make private member variable ctColor final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736395 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-24 06:37:34 +00:00
Javen O'Neal
784b07e424 bug 59222: fix NPE thrown by (S)XSSFSheet.getCellComments(). Reported by Vasily Kopytov. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736347 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-23 16:42:04 +00:00
Javen O'Neal
1128818a70 bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736165 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:22:03 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily 
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:51:39 +00:00
Javen O'Neal
dd308cd87e return unmodifiable shared strings to guarentee parallel data structures stay in sync 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736144 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:04:51 +00:00
Javen O'Neal
a61e242e86 bug 59208: correctly understand val="1" for isBold, isItalic, etc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736126 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 04:20:45 +00:00
Javen O'Neal
e89f19bef3 fix inconsistent newlines (remove carriage returns), set svnprop eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736121 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 02:31:16 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 00:14:21 +00:00
Andreas Beeker
8be67e1910 fix eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735881 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-20 13:36:56 +00:00
Andreas Beeker
b09c85ff04 eclipse warning fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735706 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 23:12:28 +00:00
Andreas Beeker
87f4e8fa63 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 22:21:12 +00:00
Andreas Beeker
488ce5fec3 #59195 - POIXMLTypeLoader depends on XMLBeans 2.6.0 - remove piccolo classes from xmlbeans jars and disable xmloption in type loader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735685 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 21:34:03 +00:00
Andreas Beeker
33991bfd98 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:30:19 +00:00
Andreas Beeker
7652be2ed1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735323 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:34:26 +00:00
Andreas Beeker
d749785d1f sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735321 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:27:56 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:10:27 +00:00
Andreas Beeker
4c4d718f52 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735316 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:59:40 +00:00
Andreas Beeker
a7c073ada9 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735312 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:46:28 +00:00
Andreas Beeker
ac6a01898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735301 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:20:15 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter. 
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:18:58 +00:00
Andreas Beeker
52fe2e4571 Fix for Softmaker Office files, which set encryption settings invalidly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735298 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:05:37 +00:00
Tim Allison
81e49eff0f 59183 - handle timezones (even with colons) in date parsing metadata in ooxml opc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735270 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 17:52:42 +00:00
Nick Burch
560ce3ee0b Ignore ODS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735079 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 14:17:47 +00:00
Nick Burch
197458b30c One final invalid file type check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:37:01 +00:00
Nick Burch
7112835d90 Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:30:45 +00:00
Nick Burch
700fe05e34 Push all the zip opening logic into ZipHelper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 12:03:30 +00:00
Nick Burch
0fab07ccfc Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:56:28 +00:00
Nick Burch
5f2f0adfae Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:54:16 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:50:57 +00:00
Dominik Stadler
4a98bd4c27 Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 12:00:27 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:38 +00:00
Dominik Stadler
3c1052e375 Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:27 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 19:31:32 +00:00
Andreas Beeker
045123e198 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734809 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 14:12:43 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:33 +00:00
Dominik Stadler
f1a476d83a Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:26 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class 
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:32 +00:00
Dominik Stadler
6d97ae7083 Fix some cases where POI itself or the tests leaked file-handles 
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:22 +00:00
Dominik Stadler
128a991f9c Findbugs fixes 
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:56 +00:00
Dominik Stadler
b989e4f5a8 Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place 
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:50 +00:00
Dominik Stadler
8c508d89b0 Add test for bug 59098 which shows that this is fixed in 3.14. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:43 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-11 23:14:09 +00:00
Andreas Beeker
630bdd0f15 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:32:33 +00:00
Andreas Beeker
1b9523898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 10:57:52 +00:00
Andreas Beeker
9f47700711 #59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 01:25:02 +00:00
Andreas Beeker
3a328aa220 #57031 - Out of Memory when extracting text from attached files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 00:41:02 +00:00
Dominik Stadler
e444b4b01a Fix source rebuilding verification after resulting binaries in dist-folder changed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-07 08:32:11 +00:00
Nick Burch
ea9169b3c4 Comment and Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-01 18:11:14 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:36:58 +00:00
Dominik Stadler
4ad3d7b35a Exclude file for bug 59074 for some more tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 19:40:25 +00:00
Andreas Beeker
a7ca3d19ae find bugs fix - WMF_HEADER_MAGIC isn't final but should be 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-28 15:24:14 +00:00
Dominik Stadler
2fa065d96c Also mark the file for bug 59074 as expected-failure for integration testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:53 +00:00
Dominik Stadler
da1879c1b2 Bug 57914: Provide a better error message for OOXML strict format which we do not support yet. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-27 10:23:46 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:43:59 +00:00
Nick Burch
1cbcfbe026 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:54 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF 
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:39:11 +00:00
Nick Burch
d35942ca52 #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:24:09 +00:00
Nick Burch
194fdfe162 Pull out two more XSSF namespace definitions as re-usable constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:16:54 +00:00
Nick Burch
094e3f68e6 Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-23 22:10:20 +00:00
Nick Burch
c58e4fe96c Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 21:17:23 +00:00
Dominik Stadler
0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:42:05 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:41:56 +00:00
Tim Allison
bc716a2796 POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-19 15:46:26 +00:00
Javen O'Neal
2cab09db04 bug 58896: comment out time-dependent test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 17:53:13 +00:00
Nick Burch
20777db2e7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 11:16:11 +00:00
Javen O'Neal
7bb1a1bb22 move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 04:05:45 +00:00
Javen O'Neal
57ebf6b133 bug 58896: add unit test to time Sheet.autoSizeColumn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 03:33:25 +00:00
Javen O'Neal
5e52b6f4e9 avoid redundant null check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 02:03:11 +00:00
Tim Allison
9e46ee937c 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:49:59 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:33:14 +00:00
Dominik Stadler
5093542774 Add test which verifies that bug 52684 is not a problem (any more) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-17 21:35:22 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 20:27:59 +00:00
Dominik Stadler
4aeff3f0ac Tried to reproduce bug 55476, but could not, added unit test anyway 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 19:16:45 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:40:24 +00:00
Dominik Stadler
63a7f89342 No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 10:08:26 +00:00
Dominik Stadler
677b19afbd GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 09:26:51 +00:00
Dominik Stadler
98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 08:33:12 +00:00
Dominik Stadler
528a64dc76 Improve error messages to state which bounds are exceeded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 07:41:47 +00:00
Dominik Stadler
b01efb6855 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes 
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:30:10 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a 
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:46 +00:00
Dominik Stadler
eeee511f71 Ignore a failure during cloning if we exceed file-format limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:23 +00:00
Dominik Stadler
b6de146895 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-12 09:44:47 +00:00
Nick Burch
118b728156 Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:40 +00:00
Nick Burch
a3966df033 Allow common tests to do auto-sizing even on SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:01 +00:00
Andreas Beeker
2aa39f5bdb Add example for adding videos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-06 22:23:47 +00:00
Andreas Beeker
ce22cc44c4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 22:03:44 +00:00
Dominik Stadler
fb07d95b55 Remove file from expected failures after changes for bug 56880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 07:51:35 +00:00
Tim Allison
827c3f562b Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-04 19:54:15 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:14:55 +00:00
Javen O'Neal
6c89d062bf bug 58885: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 04:04:56 +00:00
Javen O'Neal
e365e9cbac bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 03:27:35 +00:00
Dominik Stadler
a79dfd18e4 Adjust test to pass forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-30 11:02:54 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called 
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-29 22:09:03 +00:00
Dominik Stadler
f94bb63332 add an ignored test for bug 58804 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726681 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-25 20:21:30 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns 
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-24 00:12:10 +00:00
Dominik Stadler
2ac89a2dc9 Rename test-source file to actual class name to avoid constant recompilations on 'compile-main' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725336 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:38 +00:00
Dominik Stadler
a369daa432 Fix possible NPE found with msg-file from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725334 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:23 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 19:56:30 +00:00
Javen O'Neal
0173f22787 make SXSSFWorkbook member variables private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725047 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:58:25 +00:00
Javen O'Neal
14beee1cfd whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725043 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:31 +00:00
Javen O'Neal
18c5045d5b fix questionable List.remove(int) in SXSSFITestDataProvider 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725042 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:05 +00:00
Andreas Beeker
94fdd517aa BugFix: wrong hyperlink record added - used child instead of parent record 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725041 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:19:34 +00:00
Javen O'Neal
51e4b32498 add @Override annotations to ITestDataProviders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725040 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:03:58 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:01:33 +00:00
Andreas Beeker
79920b06eb Fix NPE when calling HSLFTextRun.setHorizontalCentered() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725022 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 19:27:58 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:46:17 +00:00
Dominik Stadler
50d09bf36c Fix a NullPointerException that occurs with some PPTs now but did not in POI 3.13 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724487 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:49 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:05 +00:00
David North
a08539ef02 Generalised API for adding ignored errors, e.g. number stored as text. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724469 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 17:54:24 +00:00
Dominik Stadler
8793846bc6 Bug 58829: Remove some useages of printStackTrace() and some other minor cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 15:59:38 +00:00
Dominik Stadler
8cf781c31b Rework test to not catch exception, junit does a good job of handling unexpected exceptions itself, StringBuffer replacing, code duplication 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724368 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 08:16:15 +00:00
Nick Burch
c86a4af85e Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491 #58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:26:26 +00:00
Andreas Beeker
0ded035dda Javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724343 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 01:09:43 +00:00
Andreas Beeker
b0c16b8261 #57796 - Support hyperlink extraction when rendering slides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207 More Office 12 DSI property IDs, getters/setters to follow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805 Bump up the max DSI property ID, and list a few Office 12 well known IDs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:26:24 +00:00
Andreas Beeker
f56b918b16 #54916 - POI does not always read all the slides in pptx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723966 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 20:44:17 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 02:20:35 +00:00
Andreas Beeker
22a9bade84 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723898 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 01:12:16 +00:00
Tim Allison
f065bf6e00 POI-58822 switch printStackTrace for actual log msg. Should probably open separate ticket to handle handful of other instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723765 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-08 17:06:39 +00:00
Javen O'Neal
1e9fd97f78 bug 58815: javadoc spelling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-07 01:53:05 +00:00
Andreas Beeker
afb36678f5 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723198 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-05 23:40:47 +00:00
Andreas Beeker
6ec54a0177 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722771 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 22:46:57 +00:00
Dominik Stadler
0fe35af294 Undo changes to file in assertCloseDoesNotModifyFile to not have dirty files after running tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722756 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:37:52 +00:00
Dominik Stadler
f54452a0e7 Try to reproduce bug 52258 and add more checks to integration tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722755 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:23:09 +00:00
Dominik Stadler
c4c9ac0ccf bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:17 +00:00
Dominik Stadler
ff8592b190 Fix bug 58067: XWPF: don't return deleted text when document is in review-mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722715 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:01 +00:00
Javen O'Neal
bc6a4a20d4 re-throw errors we aren't looking for 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722708 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:48:05 +00:00
Javen O'Neal
4f6a75b701 bug 58779: check if SlideShowFactory.create() modifies the file being read when the slideshow is closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722707 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:16:59 +00:00
Javen O'Neal
2cf06902d5 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722696 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:34:33 +00:00
Javen O'Neal
87ec46ff34 test XSLF SlideShowFactory creation methods individually for more granular unit test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722695 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:26:29 +00:00
Javen O'Neal
d747590977 rearrange unit tests into more, smaller functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722667 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:20:43 +00:00
Dominik Stadler
67d7b4a231 Move test for bug 57236 as it seems to be fixed since some time 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722666 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:41 +00:00
Dominik Stadler
b037995fdd Add test which reproduces bug 58325, seems the file uses AlternateContent which POI does not support (yet) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722665 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:28 +00:00
Javen O'Neal
347881ef1e bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7 bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 03:40:22 +00:00
Andreas Beeker
f5a24203b8 remove test debug stuff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722556 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:45:30 +00:00
Andreas Beeker
9072855208 preparation for #54916 - commit unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722538 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:05:50 +00:00
Dominik Stadler
4803a0c355 bug 58618: XWPFParagraph insertNewRun and removeRun work incorrectly for 
runs after hyperlink/field runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722503 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:28:01 +00:00
Dominik Stadler
bbd6e63c60 Include full nested exception, not just localized message 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722502 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:50 +00:00
Dominik Stadler
a6957b5c91 Some more unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722501 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:35 +00:00
Dominik Stadler
39551f8e01 Combine common functionality in POIXMLTypeLoader into helper method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722500 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:27 +00:00
Andreas Beeker
006595947d add ignored testcase for multiple signatures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722497 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 15:04:06 +00:00
Andreas Beeker
318f0b35b8 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722482 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 02:22:31 +00:00
Andreas Beeker
8ed770dfe3 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722480 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 00:45:05 +00:00
Andreas Beeker
e7d60982c7 #55030 - RichTextRun getFontName can not get Chinese font name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722479 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 23:49:34 +00:00
Andreas Beeker
f317f5e288 #56570 - RecordType has repeat by code type 3009 
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 22:10:17 +00:00
Andreas Beeker
ee6966dae9 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722465 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 20:23:20 +00:00
David North
069d7c6141 Fix example. If you don't call super for the non-ignored sheets, everything breaks because you end up with an empty workbook. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722457 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 18:15:35 +00:00
Dominik Stadler
7f105042ba Fix bug 58760: non-standard namespace-key breaks parsing XLSX files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722433 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 09:56:33 +00:00
Dominik Stadler
c7baa89709 Revert changes to integration-test-framework to not make tests fail with strange errors about entity expansion limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722425 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 08:23:04 +00:00
Dominik Stadler
5344aa12cd Use parameter in unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722412 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:56 +00:00
Dominik Stadler
902830cf14 Adjust test for extracting some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:50 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:44 +00:00
Dominik Stadler
e4b168d27f Add null-handler in integration-tests for two Visio files which are not handled (yet) and adjust memory handling somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722408 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:30 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:23 +00:00
Dominik Stadler
b4ac21a810 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:13 +00:00
Dominik Stadler
b06eaa0d3e Exclude file from integration-tests until bug 58760 is fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722405 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:04 +00:00
Andreas Beeker
5a8442a16a WMF - remove test output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722249 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 23:53:52 +00:00
Nick Burch
a3d4d2571f Disabled unit test for #58760 (problem remains) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722244 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 22:42:17 +00:00
Javen O'Neal
434ebbbdef remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722095 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:41 +00:00
Javen O'Neal
8be029b0c6 add comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722094 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:57 +00:00
Javen O'Neal
b96af85631 move comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722093 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:43:40 +00:00
Javen O'Neal
900d21a59c javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722092 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:41:50 +00:00
Javen O'Neal
44c5423be4 add unit test for bug 58779 when the problem gets fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:40:20 +00:00
Javen O'Neal
dba7fcdd4e junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:54:59 +00:00
Javen O'Neal
5310fc4b6d revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:28:32 +00:00
Javen O'Neal
6bc5c33c10 revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:21:17 +00:00
Javen O'Neal
5ab2c61a3f make spreadsheet file names static final rather than initializing them with setUp() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 08:53:46 +00:00
Javen O'Neal
7980a6b457 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722070 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 07:38:31 +00:00
Javen O'Neal
eb5bca1612 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 06:55:22 +00:00
Javen O'Neal
ef26a1d15c bug 58775: set an upper limit on number of data formats, default 250. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 05:46:20 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 02:57:58 +00:00
Javen O'Neal
22b03ba71b convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:26:55 +00:00
Javen O'Neal
1dd49eff7c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:18:16 +00:00
Andreas Beeker
a89d5210c3 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722046 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:45:59 +00:00
Javen O'Neal
ae1020ac35 bug 58778: override a built-in number format, such as using £ instead of $ for currency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:12:04 +00:00
Javen O'Neal
bf5e95d37a bug 58740: javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 16:04:47 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:50:54 +00:00
Javen O'Neal
0404c61acc bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:37:23 +00:00
Javen O'Neal
8f47967d55 write for loop for performance and readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:20:30 +00:00
Javen O'Neal
0849d8c34a bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:19:50 +00:00
Javen O'Neal
f3c14d82a6 simplify bug 57880 test case: 
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:03:52 +00:00
Javen O'Neal
934effd443 add convenience methods for writing and reading back XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 13:44:08 +00:00
Javen O'Neal
3204cedf28 bug 58775: use assertNotBuiltInFormat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:13:17 +00:00
Javen O'Neal
0ef05fcdab java docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:11:13 +00:00
Javen O'Neal
9bdfcc4be6 bug 58775: add unit test to test for non-built-in data formats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:10:12 +00:00
Javen O'Neal
8a7cd6308e bug 58775: add Override annotations, Javadocs, and comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 07:56:54 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 05:43:11 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures 
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:35:59 +00:00
Andreas Beeker
b333ed457d #56004 - Support for WMF rendering (parsing the WMF records) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-21 01:26:39 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-20 20:39:01 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 12:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 09:51:22 +00:00
Andreas Beeker
ad89fdcaf5 #58718 - Master styles not initialized when running multithreaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719758 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 01:50:24 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:43:26 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:11:38 +00:00
Javen O'Neal
dedb924183 bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:51:54 +00:00
Javen O'Neal
37622ec57e make test easier to understand using A1 addresses instead of row+col numbers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:43:27 +00:00
Dominik Stadler
96cb8c18fe Bug 58084: Fix cloning Cell Styles with Borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:39:07 +00:00
Dominik Stadler
387fb86d68 Eclipse warnings, code formatting, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:38:14 +00:00
Javen O'Neal
4aa6108c0d add hashCode for corresponding equals function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:59:26 +00:00
Javen O'Neal
abced24fe4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:56:59 +00:00
Javen O'Neal
eca89530d3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717931 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:12:27 +00:00
Javen O'Neal
26abacebaf FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:54:21 +00:00
Javen O'Neal
3b24eaacd3 make fields static 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:51:03 +00:00
Javen O'Neal
ebbf3d0ddb whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:47:31 +00:00
Javen O'Neal
6d17f8ddef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:46:58 +00:00
Javen O'Neal
17a4680cee findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:33:28 +00:00
Javen O'Neal
93497e5b0e add comments for names of missing functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:01:58 +00:00
Javen O'Neal
b6e5801a1c fix javadocs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:20:36 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:10:26 +00:00
Javen O'Neal
44c9afd31d fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:05:52 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:36:27 +00:00
Javen O'Neal
293ef9fe17 remove deprecated functions (since 2008) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:30:34 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-02 21:47:52 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide 
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 23:34:30 +00:00
Javen O'Neal
89fbd66262 bug 58670: cleanup from r1717192 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 07:03:09 +00:00
Javen O'Neal
8410c84ad6 bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell> 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 06:07:49 +00:00
Javen O'Neal
b5ad3a9327 add @Override annotations to SXSSFRow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:28:57 +00:00
Javen O'Neal
24e5a0a458 add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:22:14 +00:00
Javen O'Neal
5650b03ea0 testBool/testErr: check values before writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717178 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:21:01 +00:00
Javen O'Neal
7fc9df615f fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717171 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:00:24 +00:00
Javen O'Neal
dcba12a0ce whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717167 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:50:18 +00:00
Javen O'Neal
a5725f9b21 add @Override and @NotImplemented annotations to SXSSFCell, update javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717164 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:43:32 +00:00
Javen O'Neal
2924c7b9da break testBoolErr into 2 unit tests. The test shouldn't be aware of the underlying implementation for HSSFRows, and shorter tests are better 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717163 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:38:04 +00:00
Javen O'Neal
b58839e4b0 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717162 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:36:17 +00:00
Javen O'Neal
71b587ef36 bug 58671: change MissingCellPolicy from class to enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717157 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:24:06 +00:00
Javen O'Neal
b2a24f1a71 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717151 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 02:06:36 +00:00
Javen O'Neal
11650f84a9 add missing ASF License headers for bug 57450 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717149 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 01:05:10 +00:00
Javen O'Neal
226fefe0c9 patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 00:22:50 +00:00
Andreas Beeker
c4b5635db3 Add helper method for opening the test files - maybe switched to InputStream if test-data files are changed unexpectedly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717099 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 17:41:58 +00:00
Andreas Beeker
60b17589b7 XSLF: tables can now be removed from sheets/groups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 16:17:29 +00:00
Javen O'Neal
0e04793c2c bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:31:57 +00:00
Javen O'Neal
0a69246abc add @Override annotations to Sheet classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:27:34 +00:00
Andreas Beeker
ee0f9b84e1 close resources 
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:26:53 +00:00
Javen O'Neal
d7c3a9b2ca remove debugging print statements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717076 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:24:08 +00:00
Javen O'Neal
79e099f5fa Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:45:24 +00:00
Javen O'Neal
5ee6c34217 findbugs: add missing equals and hashCode for classes with a compareTo method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717068 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:33:28 +00:00
Javen O'Neal
d8223753ae javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 13:15:03 +00:00
Javen O'Neal
74f0442563 bug 58667: make SX/X/HSSFRow implement Comparable interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 12:14:45 +00:00
Javen O'Neal
16c1afa0d0 HSSFRow: make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717049 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:58:26 +00:00
Javen O'Neal
f3b88f6755 SXSSFRow: privatize instance variables, make _sheet final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:50:11 +00:00
Javen O'Neal
ff6d93d4f3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717043 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:48:02 +00:00
Javen O'Neal
a2ac15f1c8 make SXSSFRow._style private, add getRowStyleIndex() in its place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717042 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:47:27 +00:00
Javen O'Neal
f324646c04 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717040 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:44:03 +00:00
Javen O'Neal
db3028defb javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717038 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:39:36 +00:00
Javen O'Neal
7619f0c38f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:34:56 +00:00
Javen O'Neal
9d014aa00b bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:43:17 +00:00
Javen O'Neal
659662b5f8 bug 58636: make ClientAnchor enum constructor private, make byId Internal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717024 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:18:45 +00:00
Andreas Beeker
484297b9cf #46210 - Title placeholder not recognized by Powerpoint 2003 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717020 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 01:23:54 +00:00
Andreas Beeker
0c7e8e0c47 #58663 - Pictures cannot be removed from a slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717018 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 00:51:04 +00:00
Javen O'Neal
8c1517eee4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:55:02 +00:00
Javen O'Neal
47dc6340c2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:53:22 +00:00
Javen O'Neal
1f05c1916a make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716843 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:35:43 +00:00
Javen O'Neal
2a62f57db5 +FIXME 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:30:18 +00:00
Javen O'Neal
58bffd78a1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716811 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 09:45:53 +00:00
Javen O'Neal
19f4f8af22 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:52:25 +00:00
Javen O'Neal
e8b2d5feb4 bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:48:17 +00:00
Javen O'Neal
2e795a5f26 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716342 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 09:48:36 +00:00
Javen O'Neal
842171b94a add failing unit test for bug 58648 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716338 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 09:19:03 +00:00
Javen O'Neal
1f874be829 bug 58636: upgrade anchor types from int to AnchorType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 07:16:43 +00:00
Javen O'Neal
026ad8fbdf close workbook at end of example 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716102 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 10:50:57 +00:00
Dominik Stadler
e20da28904 Remove useless double check on null introduced with the previous bugfix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716082 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 09:10:27 +00:00
Javen O'Neal
65cd898a61 bug 58637: replace deprecated getCellComment(row, col) usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716075 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:54:32 +00:00
Javen O'Neal
72aae0f14b bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:52:45 +00:00
Javen O'Neal
e117107313 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716073 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:50:53 +00:00
Javen O'Neal
e25f69814c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716060 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:15:42 +00:00
Javen O'Neal
d58342dd9f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716057 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:13:10 +00:00
Javen O'Neal
735c43ec9d bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:04:42 +00:00
Javen O'Neal
e7d29ad533 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:53:17 +00:00
Javen O'Neal
8eabc4710a bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:43:53 +00:00
Javen O'Neal
891f2d26fc bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:34:09 +00:00
Javen O'Neal
84fdda5736 rewrite ternary expression as simple Math.min call (yes, the ternary expression as written is equivalent to min, not max, despite the variable being called max. I'll leave that fix up to the original author). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:05:11 +00:00
Javen O'Neal
dc1acc7ead whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:57:31 +00:00
Javen O'Neal
2fab3547be whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716034 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:51:54 +00:00
Javen O'Neal
cd254f2f1e FindBugs MALICIOUS_CODE, finalize method should have protected access 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716006 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:20:45 +00:00
Javen O'Neal
a736ac1777 FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:11:57 +00:00
Javen O'Neal
cba32cd1a0 FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:10:47 +00:00
Javen O'Neal
d6ee7f8221 remove duplicate null check of srcStartRow (identified by FindBugs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716003 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:08:34 +00:00
Javen O'Neal
6acd60f74d fix normal priority FindBugs warning: DMI_INVOKING_HASHCODE_ON_ARRAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715998 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 00:08:22 +00:00
Javen O'Neal
10eb8f8095 fix javadoc warnings from r1690486 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715996 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:57:40 +00:00
Javen O'Neal
b5494da29c fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715993 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:52:59 +00:00
Javen O'Neal
4dd060e25b fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715987 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:34:33 +00:00
Javen O'Neal
788047ed08 fixed bad test case in BaseTestSheet.getCellComments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715854 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:45:30 +00:00
Javen O'Neal
7af82a3de2 catch IOException and rethrow as RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715850 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:36:57 +00:00
Javen O'Neal
3e10c4f0f6 bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:11:28 +00:00
Javen O'Neal
cf41635922 prevent slideshow test-data files shapes.pptx and tables_test.pptx from being modified when running "ant test"; close open resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715815 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 13:55:48 +00:00
Javen O'Neal
a77dd2777b bug 58365: patch from Hannes Erven. Update XSSFSheetXMLHandler.java to use CellAddress instead of CellReference/String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715794 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:47:24 +00:00
Javen O'Neal
831fa71953 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715787 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:32:26 +00:00
Javen O'Neal
090394287b bug 58365: patch from Hannes Erven. Update CommentsTable to use CellAddress instead of String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715784 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:29:45 +00:00
Javen O'Neal
ae9bcd8e82 convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715752 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 10:26:06 +00:00
Javen O'Neal
dbba80c3fc bug 58637: contribution from Hannes Erven: add CellAddress class, distinct from CellReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715743 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 09:30:53 +00:00
Andreas Beeker
4ccadf7315 fix unnecessary cast warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-22 12:30:42 +00:00
Andreas Beeker
47b5cde9c3 #58617 - Add custom safe XmlBeans type loader / rename vendor specific schema packages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715555 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 19:37:26 +00:00
Andreas Beeker
7458fdc277 In preparation for table rendering, added table row heights and column widths to common sl. 
To have better results in rendering switch anchor from java.awt.Rectangle to Rectangle2D.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715540 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 15:54:01 +00:00
Andreas Beeker
2bc397b665 #58630 - Signing failed after deletion of first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715438 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-20 22:38:27 +00:00
Andreas Beeker
07dc2b9e08 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-19 01:44:38 +00:00
Andreas Beeker
e2bc07e9d1 #55955 - Filling an existing ppt table stopped working with 3.9 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714715 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-16 23:56:19 +00:00
Andreas Beeker
a0e06add7a #54210 When saving PPT to PNG, some text is rendered backwards 
#53189 Shapes drawn wrongly when ppt file converted to image
fix line decoration (HSLF)


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714290 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:44:07 +00:00
Andreas Beeker
67b4477a7e Fix typo in EscherProperties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714289 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:42:05 +00:00
Andreas Beeker
c6f11991e7 Add default XmlOptions to XMLBeans parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714288 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:41:48 +00:00
Uwe Schindler
9ab28f52ab Add security check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713917 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 19:17:18 +00:00
Uwe Schindler
493a157e6a Fix remaining security manager problems. Forbiddenapis now passes. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 19:11:35 +00:00
Uwe Schindler
73a8488838 #58597: Fix tests to not do setAccessible(), add some doPrivileged, too. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 16:57:39 +00:00
Uwe Schindler
da19b14670 #58597: Add more AccessController.doPrivileged. We should fix them later! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713813 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 11:36:44 +00:00
Uwe Schindler
b62cc549fe #58597: Remove setAccessible (more coming soon) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713770 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 07:41:54 +00:00
Andreas Beeker
b0b4c020ed Fixed Off-by-one-Error which skipped paragraph styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713546 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 21:37:10 +00:00
Uwe Schindler
ce66e14b5a Wrap more security related reflection in AccessController 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713356 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:32:37 +00:00
Uwe Schindler
8c3cd70589 Use Lucene's unmapping code inside AccessController.doPrivileged() for unmapping mapped byte buffers. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713350 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:06:01 +00:00
Andreas Beeker
d1d1298d96 #53192 - Images in ppt file have wrong width when convering ppt to png 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713332 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 01:28:31 +00:00
Uwe Schindler
66ce32aee1 Add reason message to @SuppressForbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713324 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:44:24 +00:00
Andreas Beeker
ccce28aae4 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713319 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:14:50 +00:00
Andreas Beeker
e8d108ff22 Add support for HSLF metro blobs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713318 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:13:28 +00:00
Andreas Beeker
1a32b63fd3 #52297 - Bullets are not aligned properly while converting ppt slide to image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713316 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:11:22 +00:00
Uwe Schindler
0f40ad3125 Make forbiddenapis also check excelant. Use a separate "classpath" for running forbiddenapis; don't misuse javadoc.classpath for that. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713222 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 11:57:58 +00:00
Dominik Stadler
db98ec0bd9 Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713218 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:01:48 +00:00
asf-sync-process
c39e9df3c8 Add some more tests for the checks for files that can cause large memory usage. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:38 +00:00
Dominik Stadler
4cdcc9fc24 Eclipse warnings, typos, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713216 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:24 +00:00
Javen O'Neal
8cff5d7e49 bug 58591: add formula evaluation unit tests inspired by Jason Tomforde's question on user@ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713080 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-07 04:09:39 +00:00
Nick Burch
a4e891ff8f Whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712985 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 17:03:22 +00:00
Nick Burch
6cc2839b66 Convert to JUnit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712984 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 17:02:18 +00:00
Javen O'Neal
0149810619 remove TestWorkbookEvaluator from junit3 test suite since it was upgraded to junit4 in r1712908 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712921 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 08:51:49 +00:00
Javen O'Neal
c47401d239 remove deprecated ErrorConstants usage in TestWorkbookEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712910 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:58:35 +00:00
Javen O'Neal
663c64ff44 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712909 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:45:25 +00:00
Javen O'Neal
42c1296ef6 convert TestWorkbookEvaluator from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712908 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:43:50 +00:00
Nick Burch
172593de22 Add a XWPFRun equivalent of isHighlighted, and add to the common WP interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712793 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 15:15:36 +00:00
David North
5636e64d68 Patch to bring CTTableStyleInfo into poi-ooxml-schemas by referencing it from a unit test. 
Thanks to Danil Lopatin

https://bz.apache.org/bugzilla/show_bug.cgi?id=58579

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712769 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 13:44:14 +00:00
Andreas Beeker
9b4919cd51 extended forbidden-apis-check to ooxml-tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712693 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 00:15:51 +00:00
Nick Burch
ecab3629d8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712606 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:25:35 +00:00
Nick Burch
0e7caa5eb1 Bug #55265 - DataFormatter correct support for alternate number grouping characters, eg 1234 + #'##0 = 1'234 not 1,234 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712605 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:23:17 +00:00
Javen O'Neal
20ba4851a8 fix for bug 51622: autosize columns with leading whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 06:39:57 +00:00
Javen O'Neal
265d198612 bug 58576: rename canComputeColumnWidht to canComputeColumnWidth 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:23:09 +00:00
Javen O'Neal
3b88a60498 supporting change for bug 57450 from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:07:11 +00:00
Javen O'Neal
93373073bc set svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712214 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 06:06:43 +00:00
Javen O'Neal
3a08acac95 fix typos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712213 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 06:03:52 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues 
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 23:46:57 +00:00
Javen O'Neal
06b3878176 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711961 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:25:31 +00:00
Javen O'Neal
3b94c206e5 fix javadoc link 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711957 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:13:52 +00:00
Javen O'Neal
e1e740bc3c bug 58572: change hyperlink reference to be consistent with TestXSSFHyperlink#testCopyXSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711952 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:02:44 +00:00
Javen O'Neal
9b8250832e bug 58572: replace Cloneable with copy constructors for spreadsheet Hyperlink class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711951 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 12:57:57 +00:00
Javen O'Neal
54113431b5 bug58348: add test for copying formula with unregistered UDF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711939 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 10:47:19 +00:00
Javen O'Neal
f7fbfcd5ea bug 58348: add hyperlink copying and merging to CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711926 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:59:32 +00:00
Javen O'Neal
0eb6ec6717 bug 58572: move getHyperlinkList() and getHyperlink(row, col) from XSSFSheet to Sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711923 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:40:49 +00:00
Javen O'Neal
3c18d6aa7b don't leave behind files when running unit tests. In the future this should be revisited to verify POI isn't writing workbooks that are unopenable/corrupt by applications that read POI's formats (MS Office, OpenOffice, LibreOffice, etc) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711920 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:23:12 +00:00
Javen O'Neal
e88fac62ef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711911 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:03:12 +00:00
Javen O'Neal
43a5f308d0 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711910 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:01:23 +00:00
Javen O'Neal
0e3230f703 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711909 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:55:45 +00:00
Javen O'Neal
3753893f1a whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711906 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:34:21 +00:00
Javen O'Neal
87ad007ce4 add ASF License 2.0 header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711901 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 05:33:31 +00:00
Javen O'Neal
0aeab392e5 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711886 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:51:31 +00:00
Javen O'Neal
1360cd835d bug 58348: add support for copying rows for XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711885 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:50:33 +00:00
Javen O'Neal
6fc1d21367 javadocs, remove unnecessary SuppressWarnings("resource") decorator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711883 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:39:15 +00:00
Javen O'Neal
682f5b3ed4 make private shouldRemoveRow static and final, remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711881 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:28:34 +00:00
Javen O'Neal
b729d3896c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711880 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:45 +00:00
Javen O'Neal
40b250bbb3 replace deprecated usage of FormulaShifter.createForRowShift 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711879 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:03 +00:00
Javen O'Neal
fa7beda123 remove unneeded SuppressWarnings("resource") decorator from getSheetName 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711878 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:13:35 +00:00
Javen O'Neal
75dd7f9ba3 remove unnecessary @SuppressWarnings(resource) add Override decorator to SXSSFCell.getCellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711877 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:06:43 +00:00
Javen O'Neal
c0aec91a93 delete unnecessary cast 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711876 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 01:51:03 +00:00
Javen O'Neal
af4a96f467 bug 58384: add FormulaShifter.createForRowCopy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711866 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:25:08 +00:00
Andreas Beeker
ae69a781f5 close resources, as SlideShow is now Closeable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711865 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:05:14 +00:00
Javen O'Neal
44edbec0d5 prepare for bug 58348, make FormulaShifter.ShiftMode enum private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711864 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:54:13 +00:00
Javen O'Neal
adcc71257a whitespace changes: replaced tabs with 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711862 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:30:48 +00:00
asf-sync-process
8b6cef3b79 #45908 - RichTextRun.setBullet(false) doesn't work, bullets still here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711858 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 22:52:49 +00:00
asf-sync-process
0ae2928035 #45088 - POI-HSLF changeTextInRichTextRun corrupts presentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711845 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 19:37:28 +00:00
Andreas Beeker
5338f9dce1 Fix locale error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711726 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 08:43:57 +00:00
Andreas Beeker
fa40f8417c findbugs fixes 
close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711712 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 03:23:16 +00:00
Andreas Beeker
72834dfffa FindBugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711708 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:13:35 +00:00
Andreas Beeker
8ebc22a84e Add method for setting bullet styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711707 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:43 +00:00
Andreas Beeker
6485c11305 Make SlideShow closeable as of HSLF references a NPOIFSFileSystem and hasn't closed it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711706 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:17 +00:00
Andreas Beeker
02ff2b913f #45124 - inserting text or images wipes out boldness and makes everything italic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711705 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:08:52 +00:00
Andreas Beeker
8a6a5578e6 #45124 - inserting text or images wipes out boldness and makes everything italic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711704 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:05:09 +00:00
Javen O'Neal
401d3eec77 replace deprecated usage of AreaReference as a result of bug 56328 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711685 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 20:53:12 +00:00
Javen O'Neal
d0694f4fc9 whitespace change 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711680 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 19:56:22 +00:00
Javen O'Neal
f98fda03c1 add javadoc info for intersects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711613 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 12:21:51 +00:00
Javen O'Neal
1aa81eb463 bug58452: set cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711605 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:57:39 +00:00
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:39:01 +00:00
Javen O'Neal
07cf6736ae improve error message if CellRangeAddress intersection assertion fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711597 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:20:15 +00:00
Javen O'Neal
5f23aa95f7 bug 58442: in-place reorganize an AreaPtg as upper-left and lower-right 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711592 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:10:28 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 10:22:19 +00:00
Javen O'Neal
b40a0b01bb replace deprecated usage of o.a.p.ss.util.Region with o.a.p.ss.util.CellRangeAddress; add documentation to tests that exist strictly to test deprecated methods, and move SuppressWarnings-deprecation down to just those functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711581 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 09:29:32 +00:00
Dominik Stadler
50baa731d3 Add a limit of the max number of characters that can be extracted to avoid sending applications out of memory with very large documents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711520 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-30 17:26:37 +00:00
Andreas Beeker
b9cf1bdc38 #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711381 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 23:22:54 +00:00
Andreas Beeker
438d4bd03e #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711380 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 23:20:35 +00:00
Dominik Stadler
ba7f5f3037 Ensure that no password was set by other tests, this breaks sometimes when the Sonar/Maven build runs all tests in one VM 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711199 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:30:11 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:28:38 +00:00
Javen O'Neal
1396738460 bug 58557: fix from Alessandro Guarascio, shift hyperlinks when shifting rows on an XSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711185 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 06:53:55 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText() 
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 01:05:27 +00:00
Nick Burch
632228a34e #58558 SXSSFCell.setCellValue((RichTextString)null) fixed to work like XSSF and HSSF, with common unit tests to verify this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711082 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-28 17:42:56 +00:00
Javen O'Neal
c65de59909 bug 26862: add test case for HSSFWorkbook.cloneSheet copies charts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710730 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-27 07:43:23 +00:00
Javen O'Neal
bcb09a3798 convert scratchpad TestHSSFChart from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710729 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-27 07:41:09 +00:00
Dominik Stadler
856bbf97f4 Fix Sonar-Maven build, correctly determine path to test-file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710694 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:38 +00:00
Dominik Stadler
f1f08de7fb Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:32 +00:00
David North
b0551e322e Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58549 
Thanks to Damian Cugley for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710552 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 10:32:30 +00:00
Dominik Stadler
c7ebebcbb1 Bug 56957: Avoid error if Workbook with empty SharedStringTable is written 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710521 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 07:54:06 +00:00
Nick Burch
8cd7f1f736 58536 DataFormatter and CellFormat non-localised support for localised currency formats like [$£-809] 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710484 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 21:20:44 +00:00
Nick Burch
90db0bf451 Fix javadoc warning - @see with a URL needs wrapping in an a-href tag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710460 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:19:35 +00:00
Nick Burch
dc947416d4 Mention about Locale definitions in Excel cell data format strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:13:16 +00:00
Nick Burch
1b019d3c76 #58532 Enable more of the padding cell format tests, but a few remain to be fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710407 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:57:49 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which 
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:34:47 +00:00
Nick Burch
e86a116d0a Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710395 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 22:12:06 +00:00
asf-sync-process
41419d44eb Test to check that #58532 formats are seen as valid 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710394 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 22:09:11 +00:00
Dominik Stadler
dd48f58f95 Bug 58085: removing sheet breaks other existing sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710193 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 12:11:40 +00:00
Javen O'Neal
c22fdbbc2b bug 58441: define equals method for CellRangeAddressBase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710172 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 11:17:06 +00:00
Javen O'Neal
ab729cfd0e bug 58402: make AreaReference's private SpreadsheetVersion _version variable final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710163 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 09:54:32 +00:00
Javen O'Neal
522b6d4a15 bug 58439: rename private FormulaShifter.adjustPtgDueToShiftMove to adjustPtgDueToSheetMove 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710147 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:56:49 +00:00
Javen O'Neal
538b2d1377 bug 33174: Use common unit test for testNoMergedRegionsIsEmptyList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710140 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:38:14 +00:00
Dominik Stadler
27d4814b80 Set newer curvesapi-version in .classpath as well and update some third-party libs for the password-protection-code to the latest versions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710032 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-22 15:21:25 +00:00
Dustin Spicuzza
fe771aa808 XDGF: fix the fix 
- Use Collections.emptySet() for an iterator instead
- Bump curvesapi to 1.03, which is compiled for JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709463 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 18:36:45 +00:00
Dustin Spicuzza
9c23e12b8e XDGF: fix jdk < 1.8 compat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709427 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 14:55:30 +00:00
Dustin Spicuzza
f540622a05 XDGF: fix jenkins build errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709363 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:55:06 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:26:57 +00:00
Dustin Spicuzza
879ca64994 Add some limited XDGF documentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709357 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:08:58 +00:00
Dustin Spicuzza
e3365dfaeb poi-import: fix build dependencies 
- Compilation + tests work now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709356 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:42 +00:00
Dustin Spicuzza
d70b8e8b88 poi-visio import: reformat code to fit project standards, remove JRE 7isms 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709355 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:37 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:52:35 +00:00
Dominik Stadler
3a8f40db7c Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway 
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 14:40:36 +00:00
Dominik Stadler
43ab1cd35a Use the default XmlOptions for all the invocations of the XmlBeans XML parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709128 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 08:45:25 +00:00
David North
bb18031ac7 Remove unnecessary warning suppressions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708921 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-16 09:00:43 +00:00
Dominik Stadler
e9d0e9cc12 Update test to not depend on an existing build-directory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708682 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 19:27:20 +00:00
Dominik Stadler
392591e222 Reenable test on Windows which was disabled previously but should now work after a workaround was put in place via bug 58480. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708613 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 15:00:19 +00:00
Dominik Stadler
a00240f212 Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:53:41 +00:00
Dominik Stadler
d15ef65b8f Bug 58341: fix some edge cases in the DStar function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708606 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:31:04 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor 
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 20:43:42 +00:00
Dominik Stadler
7fbf591db5 Retry which measures duration a few times to see if that reduces the number of failures caused by this test sometimes when CI machines are loaded. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707488 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-08 11:08:41 +00:00
Nick Burch
4ae623c699 Update the XSSF EventModel example, to show how to do it better using the SheetContentsHandler helper that does most of the work for you 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707326 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-07 15:19:04 +00:00
Dustin Spicuzza
bf68d5f290 Bug 58048: Add visio schemas to the OOXML jar 
- Bumped OOXML jar version also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707177 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-07 02:41:30 +00:00
Andreas Beeker
cab7f9c2e0 fix forbidden apis issue and make non-static as decimalformat is not thread-safe 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707166 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 22:52:05 +00:00
David North
efee7bf83f Format numbers more like Excel does 
Thanks to Chris Boyle for the patch

https://bz.apache.org/bugzilla/show_bug.cgi?id=58471

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706971 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 09:56:26 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 00:04:12 +00:00
David North
2dc93d4411 Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58466 
ColumnHelper now preserves information on multiple changes to the same group, hopefully while preserving the faster implementation intended by the original patch.

NB changes to TestXSSFSheet: the behaviour of column group collapsing/expanding is now closer to what Excel does than before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706789 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 10:31:33 +00:00
Dominik Stadler
cc1caaf658 As discussed at ApacheCon: Try to automatically find test-data in unit tests, this makes it easier to get going in Eclipse or other IDEs. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706752 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 06:45:20 +00:00
Dominik Stadler
4b487fcc10 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706750 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 06:41:48 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:28:54 +00:00
Andreas Beeker
0d29f8b2ec obsoleted Codec classes by HexDump 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706741 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:27:47 +00:00
Andreas Beeker
8aec6ba738 removed obsolete classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706740 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:45 +00:00
Andreas Beeker
d9c0fb9ce5 Fixed a problem with save-and-load of conditional formattings (CFHeader12 wasn't added to conditional formattings, rgb value wasn't saved in extended color) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706739 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:19 +00:00
Andreas Beeker
98e93217fe sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-04 00:35:30 +00:00
Dominik Stadler
030c29cfed Bug 55032: Fix handling missing option values in financial functions PV, FV, NPER and PMT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706254 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-01 14:05:28 +00:00
Andreas Beeker
2de9d527b4 sonar fixes 
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-30 23:06:39 +00:00
Dominik Stadler
9deb59f263 Verify that bug 51998 is actually fixed since some time already. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705855 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 13:09:47 +00:00
Dominik Stadler
99d33a0330 Bug 50319: Make row groups which include row 0 work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705844 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 12:26:08 +00:00
Dominik Stadler
b261c978a8 Tried to reproduce bug 48403 but couldn't, still adding the related unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705830 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 10:14:40 +00:00
Andreas Beeker
ffd1f4333e sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 08:31:15 +00:00
Dominik Stadler
c56977e6d2 Add test which shows that bug 46515 is fixed since some time already. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705807 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 07:51:48 +00:00
Dominik Stadler
72ae82f7dc Verify that bug 45541 can be resolved, add some more checks in XSLFFileHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705804 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 06:08:08 +00:00
Andreas Beeker
1b2b506edb Sonar fixes - add cloneable interface to classes with clone() 
Sonar fixes - remove pubic/static/final modifier from interfaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705789 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 23:16:58 +00:00
Andreas Beeker
6f7f16853e Removed HDF API 
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-27 22:14:25 +00:00
Andreas Beeker
bde96d1a9a fixed some wrong nightly assumptions ... (Note to myself, don't rely on ant automatic file change detection, but run ant clean before ...) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704999 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-24 05:51:38 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes 
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 23:22:46 +00:00
David North
c93ded0f36 Make XSSF and HSSF consistent in getMergedRegions - return empty list if there are none, rather than an exception. Tests for this. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58350

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704839 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 12:53:13 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-22 19:50:37 +00:00
Nick Burch
c556e08a52 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704393 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 19:18:40 +00:00
Andreas Beeker
6488170c6d removed common sl path 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704207 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:16:36 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio 
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:09:45 +00:00
Dominik Stadler
d61ea07e26 Bug 58333: Apply patch to verify behavior on row-index before and after the limits set by the specification 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704186 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:16:17 +00:00
Dominik Stadler
f2cd7ed8f5 Bug 58332: Adjust implementation of dev-util 'MemoryUsage' to print out information if limits are reached instead of OOM 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704182 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:05:36 +00:00
Andreas Beeker
f3004e6185 close resources in junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704124 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 12:02:40 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF) 
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 02:25:35 +00:00
Dominik Stadler
a207e463e9 Bug 57925: Add unit test and a simple fix to at least avoid the NPE when Workbooks have invalid external references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703999 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-19 12:22:42 +00:00
Dominik Stadler
3a325dc5dc Bug 57915: Fix Dev2Hex for numbers larger than Integer.MAX_VALUE and less than Integer.MIN_VALUE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703672 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 19:23:25 +00:00
Dominik Stadler
6dda58db90 Apply patch from bug 57890 to add support for different datatypes in XSSFImportFromXML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703665 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 18:30:13 +00:00
Nick Burch
20b44d546e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703575 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 11:18:15 +00:00
Nick Burch
9647b62d1a Patch from Javen ONeal from bug #58245 - Make Workbook support iterating over Sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703573 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 11:10:11 +00:00
Dominik Stadler
8f604e8563 Eclipse warnings, code formatting, simplify ExcelAntWorkbookUtilFactory, always close resources, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703028 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-14 18:40:23 +00:00
Dominik Stadler
a5918f26fe Update javadoc for bug 56129 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702805 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:32:50 +00:00
Dominik Stadler
c6f875fbb9 Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:55 +00:00
Dominik Stadler
a4901ca30d Enhance integration testing to apply OPCPackage tests to more file-types and also run XSSFReader in XSSFFileHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702801 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:40 +00:00
Dominik Stadler
42053fcf71 Verify that bug 55406 can be closed WORKSFORME 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702800 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:28 +00:00
Dominik Stadler
fb88108e30 Add test case for bug 54399 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702786 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 14:48:58 +00:00
Andreas Beeker
50777f1e48 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702773 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 12:36:56 +00:00
Andreas Beeker
5f94d8b533 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-12 18:45:07 +00:00
Dominik Stadler
768060a8ff Bug 58353: Return correct value in Match-Function with match-type == -1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702535 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-11 18:52:29 +00:00
Nick Burch
aff1dba75b Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702417 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-11 10:27:22 +00:00
Andreas Beeker
fec6b40606 More forbidden apis fixes (added main-tests to the check) 
and a few junit4 upgrades
... hopefully this doesn't crash the build again ... :|

to simulate the tests on jenkins on the local developer box, uncomment the UTC lines in the build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702356 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-11 00:56:16 +00:00
Andreas Beeker
c21b7bc4d1 forbidden apis fixes - timezone fix ... will it work? 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702321 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-10 21:31:00 +00:00
David North
728e202b6b Patch from https://bz.apache.org/bugzilla/show_bug.cgi?id=58347 - s/arg/filename for a more descriptive filename 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702060 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-09 17:27:49 +00:00
Andreas Beeker
aea434a135 forbidden apis fixes - a few DateFormat clean ups ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-09 00:41:03 +00:00
Andreas Beeker
50107cae16 Bug 58326 - Forbidden APIs patches - second set of changes for charset settings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701713 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-08 00:04:12 +00:00
Andreas Beeker
91e6a64627 forbidden apis fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 22:34:21 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:19:50 +00:00
Andreas Beeker
3166646249 Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
commit single files because of svn failures ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701684 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:14:33 +00:00
Dominik Stadler
782739541a Bug 58315: Avoid NPE for RichTextString without font-details 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701382 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-05 12:57:04 +00:00
Dominik Stadler
b2bd6a0a4c Eclipse warnings, close resources in CommandLineTextExtractor, add try/finally, formatting, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701139 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:59:14 +00:00
Dominik Stadler
de46578051 Bug 56959: Add verification unit test to show that the bug cannot be reproduced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701135 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:32 +00:00
Dominik Stadler
dab5f4c078 Fix bug 53275: reset indexed color flag when setting a non-indexed color 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701134 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:23 +00:00
Dominik Stadler
f7e0bdea37 Add unit test which verifies that bug 53105 is actually fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701133 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:14 +00:00
Dominik Stadler
4b8c20a7ca Add unit tests to verify that bug 51626 and bug 51451 are fixed 
Conflicts:
	src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701132 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:04 +00:00
Dominik Stadler
fcfe2e2a71 Add unit tests which verify that the issues from bug 48962 and 50755 do not occur any more on the latest version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701131 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:45:55 +00:00
David North
7d1947ad3a Make D* functions thread safe, thanks to Patrick Zimmermann for the patch. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701055 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 15:58:00 +00:00
Andreas Beeker
d6f598b8f9 remove trailing comma ... works ok in Oracle jdk6, but maybe not in openjdk ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700880 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-02 19:44:14 +00:00
Andreas Beeker
1ca522ffa9 Fix DAYS360 for US/EU handling 
fix forbidden api calls
add TimeZone (user) override to DateUtil
fix a few left open resources in the junit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700686 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 23:10:43 +00:00
Nick Burch
d2ebc899fb Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700677 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:46:30 +00:00
Nick Burch
d00fb8a65b Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700675 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:31:02 +00:00
Nick Burch
83399ac543 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700673 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:26:39 +00:00
Nick Burch
b0ec4fbcf6 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700672 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:18:33 +00:00
Nick Burch
aa455c91fd Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:09:20 +00:00
Nick Burch
4fba7dbd62 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700669 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 20:57:57 +00:00
Nick Burch
28ae209cb8 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700652 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:36:22 +00:00
Nick Burch
64416b4d84 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700651 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:24:55 +00:00
Nick Burch
8265e2e95e Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700648 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:19:55 +00:00
Nick Burch
46eccc04cc Fix inconsistent indent/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700647 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:17:40 +00:00
Nick Burch
3e9159c523 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700646 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:16:21 +00:00
Nick Burch
71a62c0f9d Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700645 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:11:20 +00:00
Nick Burch
47fb9df1a1 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700644 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:06:53 +00:00
Nick Burch
533e1c8dcb Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:01:36 +00:00
Nick Burch
2015baaad3 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700641 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 18:56:44 +00:00
Nick Burch
4fed0c35e9 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700640 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 18:49:50 +00:00
Nick Burch
f098eca5a0 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700635 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 18:37:07 +00:00
Andreas Beeker
6703c9d3fb forbidden apis fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700076 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-29 21:45:08 +00:00
Andreas Beeker
828c58f956 forbidden apis fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700063 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-29 18:01:26 +00:00
Andreas Beeker
3c609d309b fixed a few forbidden api calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700055 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-29 15:52:10 +00:00
Andreas Beeker
f2487c035a junit4 fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700043 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-29 14:47:16 +00:00
Andreas Beeker
33ffe01bff - reworked HexDump class - unified array dumps and usage of standard java calls for hex format 
- fixed a few findbugs DM_DEFAULT_ENCODING issues
- removed a few System.out/.err calls - instead the poilogger is used
- closed a few left open resource instances

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700040 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-29 14:41:12 +00:00
Nick Burch
c451224d84 Fix a handful of forbidden apis identified problems 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698198 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-27 17:21:35 +00:00
Dominik Stadler
b98bfd48aa Adjust excludes for TestRecordLister 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698081 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-27 06:32:33 +00:00
Andreas Beeker
880d5fa413 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698030 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-26 22:26:39 +00:00
Andreas Beeker
cf84bb1a85 Fix for JDK6 bug: http://bugs.java.com/view_bug.do?bug_id=6569074 
This was fixed in jdk 7u72 ... so we'll keep this bit uncleaner version for a while ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698006 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-26 21:25:58 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-26 19:34:28 +00:00
Dominik Stadler
5a867f39e9 Adjust excludes after adjusting multiple HeaderFooterRecord instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697602 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-25 08:32:41 +00:00
Dominik Stadler
50687e782b Refactor BaseXLSIteratingTest into a Parameterized test to better show which files failed 
Simplify exclusion handling
Exclude testEXCEL_3.xls and testEXCEL_4.xls in two tests, not sure why this worked before?!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697601 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-25 08:30:49 +00:00
Dominik Stadler
97fa448a2c Allow multiple instances of HeaderFooterRecord in CustomViewSettingsRecordAggregate similar to ChartSubstreamRecordAggreagte in order to read sample 49931.xls correctly after re-saving it with HSSFWorkbook 
Improve error output


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697600 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-25 08:28:54 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions 
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 08:12:01 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-20 14:28:39 +00:00
Dominik Stadler
f828ff1554 Somehow the Date formatting via SimpleDateFormatter fails on some CI machines, don't rely on this to avoid test-failures due to timezones/locales but rather compare the date directly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696710 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-20 06:29:48 +00:00
Nick Burch
cd988b9c2e Patch from Javen ONeal from bug #58254 - CellFormatResult.text should check for nulls as per the javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696638 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 18:00:31 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:36:08 +00:00
Dominik Stadler
a6caec985c Add additional checks to narrow down why this test fails when run via Maven 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696584 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:28:23 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened 
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:10:08 +00:00
Dominik Stadler
badd478547 Add one unit-test for a different way of calculating workdays to see if this also triggers test failures in Sonar Maven runs which currently fail for test-case TestWorkdayFunction 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696498 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 20:24:07 +00:00
Nick Burch
152b0d1e6d Comments, imports and warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696436 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 14:59:52 +00:00
Nick Burch
91ed79222b Fix indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696432 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 14:49:38 +00:00
Nick Burch
96a2062e6e Patch from Javen ONeal from bug #58253 - CellReference upper-case check for #REF!, and code readability + javadoc improvements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696430 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 14:46:01 +00:00
Nick Burch
a92c078d18 Fix indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696429 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 14:34:52 +00:00
Nick Burch
3bde975db7 Patch from Javen ONeal from bug #58252 - More CellReference unit testing coverage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696427 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-18 14:32:53 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-17 20:54:32 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-16 20:51:40 +00:00
Andreas Beeker
d90309db4e Move and rename hslf line because of ambiguity with common sl line 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696095 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 20:43:51 +00:00
Andreas Beeker
5827cee62d FindBugs - DLS_DEAD_LOCAL_STORE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696050 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 13:05:00 +00:00
Andreas Beeker
ef3dab6bd7 FindBugs - BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696049 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 13:00:05 +00:00
Andreas Beeker
dd5e6e61c4 FindBugs - DMI_INVOKING_TOSTRING_ON_ARRAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696043 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 12:20:52 +00:00
Andreas Beeker
860a1ecae0 FindBugs - BX_UNBOXING_IMMEDIATELY_REBOXED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696042 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 12:13:09 +00:00
Andreas Beeker
af3f0427b5 FindBugs - BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696040 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 12:09:26 +00:00
Andreas Beeker
05c92b7a19 FindBugs - DLS_DEAD_LOCAL_STORE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 11:57:57 +00:00
Nick Burch
2df37edbae Bigger warnings that new users should use SXSSF, and not mess around with the XML themselves 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696019 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 07:29:27 +00:00
Nick Burch
6be4fc05d2 Remove catches which were previously incorrectly declared when not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695775 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:31:25 +00:00
Nick Burch
1a84b476e8 #58237 When adding a picture to a XWPF header or footer, attach it to the right part 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695772 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:23:58 +00:00
Nick Burch
cfbc261e65 #58237 Add some more XWPF header and footer tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695769 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:01:04 +00:00
Nick Burch
d9697de075 Fix inconsistent line endings and some eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695757 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 19:20:58 +00:00
Andreas Beeker
0e1aa75750 findbugs - DM_NUMBER_CTOR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695635 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:38:04 +00:00
Andreas Beeker
3ac2d2905a findbugs - DM_BOXED_PRIMITIVE_... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695629 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:17:08 +00:00
Andreas Beeker
14df4b2824 Common stress test for X/HSLF and a few bug fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695628 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:10:11 +00:00
Nick Burch
36ee486049 More consistent test-file output for Excel testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695605 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 19:52:22 +00:00
Nick Burch
a87cdf35cd Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695604 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 19:49:25 +00:00
Nick Burch
83bf96035c Continue with 55747 / 55324 testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695603 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 19:46:54 +00:00
Nick Burch
459cb5ec62 More tests for 55747 / 55324 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695601 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 19:31:47 +00:00
Nick Burch
f3a33fcead Note on arguments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695595 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 18:38:30 +00:00
Nick Burch
940b5fc449 Javadoc updates, and fix warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695593 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 18:03:52 +00:00
Nick Burch
6d46fc382f #58220 - Improve the javadocs for XSSFFont and Font getFontHeight methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695528 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 14:14:12 +00:00
Nick Burch
ac8ed40f80 Fix some eclipse warnings, add TODOs for fields/hyperlinks XWPF add support, and give a more helpful exception if someone tries to remove a XWPFRun that is not a direct paragraph child 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695365 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:10:53 +00:00
Nick Burch
87a2acf935 Support XWPF field runs, the same way that we handle hyperlink runs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695361 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:01:26 +00:00
Dominik Stadler
3b1e99d58f Fix integration test for OPCPackage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695346 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 18:39:50 +00:00
Nick Burch
beec0097bc Bring over some fixes from XSSFSheetXMLHandler, and note that in the javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695309 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 14:31:14 +00:00
Dominik Stadler
ccc4ebcf70 Bug 56479: don't hardcode dcterms as namespace alias in the attribute, but expect the actual alias that is used in the corresponding element. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695212 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 05:37:15 +00:00
Andreas Beeker
4795b3d2cb clamp (h)sl values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695183 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 00:07:15 +00:00
Dominik Stadler
e7f4d132f1 Provide more output when failing range-checks on HSL2RGB-construction 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694960 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-10 06:17:44 +00:00
Andreas Beeker
750558d8d9 #56519 - XSLFSlide.draw is not working with text embeded in PPTX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694925 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 22:44:13 +00:00
Nick Burch
bdb00633a3 Complete theme colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694892 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 14:15:00 +00:00
Nick Burch
5b97e55997 Get theme and non-theme rows consistent in the test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694889 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:30:35 +00:00
Nick Burch
d2a95d0901 Begin Themes+Normal colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694887 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:06:40 +00:00
Nick Burch
3abeb347a6 Fix the themes test for the complex workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694883 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 12:36:57 +00:00
Andreas Beeker
d325916595 Added Siddharths ExcelComparator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694753 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-08 00:56:44 +00:00
Andreas Beeker
7c8f544b9f add ASL header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694613 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-07 06:59:11 +00:00
Andreas Beeker
d0e0f0cb97 #58205 - getSlideMasters() returns the master slides in the incorrect order 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694592 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-07 00:17:55 +00:00
David North
1d6a728931 Make it a complete sentence. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694537 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 16:38:23 +00:00
David North
66fbc9d44e Example to go with refactor for https://bz.apache.org/bugzilla/show_bug.cgi?id=58219 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694536 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 16:37:09 +00:00
David North
9730ff9cd6 Proposed refactor for: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694531 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 15:57:48 +00:00
Andreas Beeker
f28588fbb3 #57786 - XSLFFreeformShape ignores quadratic bezier curves 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694373 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 23:24:13 +00:00
Andreas Beeker
e5069da22a #58206 - provide a mechanism to find slide layouts by name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694340 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 22:46:42 +00:00
Andreas Beeker
91353085b5 #58204 - STYLE: ShapeContainer interface makes internal getShapesList() redundant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694335 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 21:44:01 +00:00
Nick Burch
0e2e61d1e1 NPE fix for text extraction from MSG files with only a short name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694255 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 15:58:43 +00:00
Nick Burch
1f6594c244 Stub next test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694127 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:26:20 +00:00
Nick Burch
b2ab81ad81 Use an enum to simplify the themes code and tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694125 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:14:23 +00:00
Andreas Beeker
c4e543d4fa Findbugs fixes for DMI_INVOKING_TOSTRING_ON_ARRAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694124 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:11:50 +00:00