moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,354 Commits 29 Branches 84 Tags 722 MiB
4ed96136ec
Commit Graph

2795 Commits

Author SHA1 Message Date
Javen O'Neal
4c89f44cc5 bug 58787: add an advertisement to BorderPropertyTemplate. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:44:29 +00:00
Javen O'Neal
ede81720ee bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:40:20 +00:00
Javen O'Neal
d658ec8f95 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:27:18 +00:00
Javen O'Neal
e4e4cbb71e findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 07:02:33 +00:00
Javen O'Neal
64ae6dc0ff findbugs: fix SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:38:53 +00:00
Javen O'Neal
84113f3c63 findbugs: fix SF_SWITCH_FALLTHROUGH warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 06:12:35 +00:00
Javen O'Neal
1853126f9b findbugs: fix URF_UNREAD_FIELD warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 04:42:59 +00:00
Javen O'Neal
55b675a384 fix findbugs issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 03:48:30 +00:00
Javen O'Neal
9d58a47e0c bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 01:00:51 +00:00
Javen O'Neal
ca9431d71f add copy constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-13 00:43:34 +00:00
Javen O'Neal
0ae778e5cd rewrite switch statements to not re-check the switch'd variable 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:43:16 +00:00
Javen O'Neal
a63d82bbee rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 23:03:23 +00:00
Javen O'Neal
67b7e97a9f rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior? 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:59:47 +00:00
Javen O'Neal
ad98f81e5f move check if border line style is blank before setting the border color to a helper function for readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:57:37 +00:00
Javen O'Neal
344b9d9884 remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key. 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:33:24 +00:00
Javen O'Neal
513dfc5ff1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:02:38 +00:00
Javen O'Neal
3530aa3bf2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 22:00:45 +00:00
Javen O'Neal
f9c7ae0102 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:35:56 +00:00
Andreas Beeker
a696823927 fixing javadocs errors (in JDK8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 21:28:13 +00:00
Andreas Beeker
a1ff5002a5 fixing javadocs errors (in JDK8) 
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 20:19:59 +00:00
Andreas Beeker
f919e8bd8a Common-SS: changed UDFFinder from interface to abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:20:52 +00:00
Andreas Beeker
81d891921b findbugs fixes 
changed UDFFinder to abstract class and moved DEFAULT constant to factory method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-12 00:12:22 +00:00
Javen O'Neal
16fb41d5f1 make these classes more discoverable/searchable using more specific names 
rename PropertyTemplate to BorderPropertyTemplate
  rename Extent to BorderExtent

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 12:09:23 +00:00
Javen O'Neal
cea8cc65a3 javadoc update and boolean addLeft|Right|Top|Bottom line wrap update 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:12:04 +00:00
Javen O'Neal
66498c10af fix spelling in javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 11:01:48 +00:00
Javen O'Neal
7c90716fdc fix javadocs: remove unnecessary @links, remove references to CellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 10:09:05 +00:00
Javen O'Neal
ad11547c8a move loop-invariants outside the loop for readability and execution speed 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:58:12 +00:00
Javen O'Neal
bd22a7be43 replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.* 
update PropertyTemplate functions to require enum instead of short borderType

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 09:15:57 +00:00
Javen O'Neal
fc6b8cdd0e +props svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 07:00:40 +00:00
Javen O'Neal
54213ab158 bug 58787: add PropertyTemplate, unit test, and example from Mark Murphy 
Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*())

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 06:47:25 +00:00
Javen O'Neal
8673812492 methods that return lists should return unmodifiable lists; use foreach sheet iterator when sheet index is not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 03:05:31 +00:00
Javen O'Neal
9ca89c2278 add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 01:41:54 +00:00
Javen O'Neal
6ed13b4b5b add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:42:57 +00:00
Javen O'Neal
52e866f4bc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:34:22 +00:00
Javen O'Neal
9aaa2bd51e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:16:14 +00:00
Javen O'Neal
82134e3d8a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-11 00:15:00 +00:00
Javen O'Neal
db6ceaa7fa bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:52:44 +00:00
Javen O'Neal
79ebd4915d findbugs: SBSC_USE_STRINGBUFFER_CONCATENATION FormulaParser.parseAsColumnQuantifier() concatenates strings using + in a loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747685 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 11:16:16 +00:00
Nick Burch
1197db5415 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747674 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:42:09 +00:00
Nick Burch
937519fad5 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747673 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:40:26 +00:00
Javen O'Neal
bec8fbe92c fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747671 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 09:16:41 +00:00
Javen O'Neal
954d5f8be4 bug 57840: add structured reference formula parsing tests from FormulaParser.parseStructuredReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747655 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 07:33:30 +00:00
Javen O'Neal
95df2cc417 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747638 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 05:38:10 +00:00
Javen O'Neal
068bb510be bug 57840: add javadocs (warn about stale XSSFTable cache), remove rowIndex argument from calls to FormulaParser.parse(String, FormulaParsingWorkbook, FormulaType, int sheetIndex) when rowIndex is irrelevant, clear xmlColumnPr and commonXPath during updateHeaders so that users have a mechanism to clear invalidated cached values 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 04:20:41 +00:00
Javen O'Neal
1c2b9b3103 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747625 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:51:45 +00:00
Javen O'Neal
12a8f5b603 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747623 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 02:01:15 +00:00
Javen O'Neal
b983f435d1 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747622 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:57:13 +00:00
Javen O'Neal
3732a24a42 bug 57840: check for null to avoid NPE; add unit test for XSSFWorkbook.getTable() 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747621 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 01:52:08 +00:00
Javen O'Neal
83abda843a bug 57840: apply patch from Daniel Livshen and Greg Woolsey to get structured references working in XSSFWorkbook formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xssf_structured_references@1747612 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-10 00:21:59 +00:00
Javen O'Neal
fe44b01cd3 bug 57840: add Table interface for Structured References. Patch from Daniel Livshen and Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747602 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-09 22:47:35 +00:00
Andreas Beeker
8dbe0b3cd8 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747327 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:38:05 +00:00
Andreas Beeker
f29eb91c08 Add XSSF support to ForkedEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747326 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:15:40 +00:00
Andreas Beeker
3387617db8 #59170 - Remove deprecated classes (POI 3.15) - remove BuiltinFormats.getBuiltinFormats() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747325 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 23:13:57 +00:00
Javen O'Neal
9c19717151 add comments and make the statefulness of localeIsAdapting more obvious. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 08:54:08 +00:00
Javen O'Neal
914fb92f3c make emulateCSV final, add a single common all-inclusive (private) constructor that all other constructors tree up to and invert the constructors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747163 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 07:39:40 +00:00
Javen O'Neal
b84f05a44c replace Obervable with Observable; emulateCsv with emulateCSV 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747152 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:37:24 +00:00
Javen O'Neal
74be4d4174 bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-07 06:18:44 +00:00
Andreas Beeker
60d35b92c6 close resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747092 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:34:17 +00:00
Andreas Beeker
b8e38304f2 javadocs / java warnings (jdk8) fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747090 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-06 23:33:00 +00:00
Andreas Beeker
c423015a1b try to find out temp file errors on maven build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746932 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-05 16:49:18 +00:00
Andreas Beeker
d80170f9ac #57766 - XSLFTable isn't exported on convert slides of a .pptx slide show to a PNG/SVG image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746856 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-04 22:53:00 +00:00
Dominik Stadler
1fdbf14e1e Fix some Sonar issues and some IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-02 20:14:28 +00:00
Dominik Stadler
aad52afa12 The changes for using AccessController/SecurityManager also added a log which now spams a lot if log is enabled in integration-tests, reduce it a bit by not trying to call "cleaner()" on HeapByteBuffer which does not have it for sure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746411 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-01 08:05:07 +00:00
Nick Burch
e9a1e2987f Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746286 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 15:08:14 +00:00
Dominik Stadler
68102762fd Fix some compiler/IntelliJ warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746274 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-31 13:48:25 +00:00
Andreas Beeker
334ec509fa fix handling of hsl and linear rgb (%-values) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745412 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-24 23:39:23 +00:00
Andreas Beeker
592f22882f #58217 - XSLF: support alpha channel on solid colors (fill, line, text) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745101 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 23:58:07 +00:00
Dominik Stadler
e48e4e771d Bug 58190: Add more overloaded methods for adding pictures from streams and files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745073 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-22 16:08:51 +00:00
Andreas Beeker
e58f6f3fb0 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744802 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-20 22:05:00 +00:00
Andreas Beeker
eb111ce81f findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744332 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 23:34:52 +00:00
Dominik Stadler
6a223ec11e BiffViewer: Close resources always 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744212 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-17 08:44:21 +00:00
Andreas Beeker
1f862981e2 Close resources in Common SL rendering classes and minimize memory consumption by using the image anchor dimensions instead of the WMF-included dimensions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744007 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:09:22 +00:00
Andreas Beeker
306edb91e5 sonar fix - reduce complexity by using constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744006 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 10:04:46 +00:00
Andreas Beeker
2e5f0132c5 Sonar fixes - array is stored directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744003 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:57:19 +00:00
Andreas Beeker
dde2a25283 #59170 - Remove deprecated classes (POI 3.15) - use FormulaError instead of ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1744000 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-16 09:38:42 +00:00
Andreas Beeker
401a9fb477 #58144 - Behaviour for headers and footers of slides is inconsistent between slideshows created in 2003 and 2007 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1743769 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-13 23:50:39 +00:00
Javen O'Neal
4a3acf4de0 add @since to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742882 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:47:49 +00:00
Javen O'Neal
730641576a bug 59443: exit early on setAddress if address is the same 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742881 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:46:14 +00:00
Javen O'Neal
191726ee7b bug 59443: use Comment.setAddress when changing both row and column of cell comment address 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742880 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:25:29 +00:00
Javen O'Neal
70459401a3 bug 59443: add get/setAddress methods on cell comment class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742879 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 05:09:41 +00:00
Javen O'Neal
e9bfa9da87 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742869 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-09 03:53:55 +00:00
Andreas Beeker
f688ed96c6 #59327 - Setting text direction on a table cell has no effect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742338 13f79535-47bb-0310-9956-ffa450edef68
 2016-05-04 22:09:10 +00:00
Javen O'Neal
808254af89 bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-26 22:48:02 +00:00
Javen O'Neal
dca380f057 reformat exclude classes regular expression for OOXMLLite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739643 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 20:02:17 +00:00
Javen O'Neal
0b9fea928e add comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739554 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 08:42:26 +00:00
Javen O'Neal
3ba74f8319 bug 59340: lookup IndexedColors by index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739539 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 03:39:21 +00:00
Javen O'Neal
4e33c06871 bug 59336: patch from Mark Murphy: deprecate functions in CellUtil that require an unnecessary Workbook argument. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739536 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 01:29:19 +00:00
Javen O'Neal
f3af2a116b bug 59336: patch from Mark Murphy: replace deprecated usage of functions in CellUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739533 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:32:32 +00:00
Javen O'Neal
6043813e67 bug 59338: patch from Mark Murphy to deprecate HSSFCellUtil class in favor of CellUtil. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739531 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-17 00:20:37 +00:00
Javen O'Neal
d94ff1aa8e javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738789 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:19:49 +00:00
Javen O'Neal
a4af4fc6c3 fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738782 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 12:03:24 +00:00
Javen O'Neal
9e389627cc whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738773 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:28:25 +00:00
Javen O'Neal
cb5544ad9f fix several findbugs SF_SWITCH_NO_DEFAULT warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738765 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:12:57 +00:00
Javen O'Neal
aa6083ce0a add LINK_TYPE_SECONDARY_CATEGORIES, which appears to be a valid type (0x03) based on HSSFChart.insertData 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738762 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 11:03:58 +00:00
Javen O'Neal
4260aa76c2 javadoc typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738677 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 03:13:52 +00:00
Javen O'Neal
d59c08e954 fix javadocs and findbugs warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738674 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-12 01:30:20 +00:00
Javen O'Neal
bbf912dceb bug 52949: add VBAMacroReader unit tests for H/XSLF, H/XWPF, and HGDF; OLE directories as case-insensitive 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738513 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 05:54:17 +00:00
Javen O'Neal
d6252e00b1 bug 52949: fix forbidden apis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738499 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-11 01:26:09 +00:00
Javen O'Neal
f49047e733 add @NotImplemented annotation to methods that are not implemented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 21:28:41 +00:00
Javen O'Neal
014d371a5f bug 52949: add junit test for RLEDecompressingInputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738436 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:09:02 +00:00
Javen O'Neal
8898db6b2e svn propset svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738435 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 14:05:33 +00:00
Nick Burch
d7981342e0 Javadoc tweaks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738431 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 13:02:36 +00:00
Nick Burch
e8e1a294e6 Make the extractor exactly that, powered by the reader #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738429 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:59:38 +00:00
Nick Burch
2185e91883 Unit test for VBA macro reading #52949 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 12:45:53 +00:00
Nick Burch
82351e8fea Start to refactor VBAMacroExtractor into a more general class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738423 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:54:09 +00:00
Nick Burch
4abcc6626a VBA extraction support from bug #52949 from Barry Lagerweij 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738418 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-10 11:16:49 +00:00
Dominik Stadler
b9e7c32ffe Bug 58648: Fix handling whitespaces in formulas, unfortunately blank can be the intersection operator as well, so we need to try and skip it as whitespace if intersection fails which can lead to hard to track bugs or misleading error messages with some formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738033 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:50:08 +00:00
Dominik Stadler
ec6bb2a066 Slightly improve error message 
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:59 +00:00
Dominik Stadler
62ee0abc13 Code cleanup via IntelliJ: Remove unnecessary semicolon 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 19:49:47 +00:00
Nick Burch
a456ad5d77 Fix javadoc warning - As per http://bugs.java.com/bugdatabase/view_bug.do;jsessionid=d014dfa686594180be40ca5872f5?bug_id=4907024 an @see is only allowed a single link with nothing after it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737924 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 06:28:14 +00:00
Javen O'Neal
bed6a46d10 bug 59264: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737914 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 04:32:36 +00:00
Javen O'Neal
b8dcd4df42 bug 59264: fix findbugs warning 'A boxed value is unboxed and then immediately reboxed.' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737896 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-06 00:06:53 +00:00
Javen O'Neal
c95f6a4b35 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737895 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:47:41 +00:00
Javen O'Neal
fe13debb84 bug 59264: move border style deprecations to POI 3.15 beta 2. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737894 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 23:30:37 +00:00
Javen O'Neal
5752c4bb7e bug 59264: allow borders styles to be set with BorderStyles enums or Short codes for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737885 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:36:11 +00:00
Javen O'Neal
f7939c4c95 bug 59264: add link to BorderStyle on deprecated BORDER_* constants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737884 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 21:34:24 +00:00
Javen O'Neal
1786767b89 bug 59264: use BorderStyle for changing Cell border line style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737879 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-05 20:28:46 +00:00
Javen O'Neal
739196e5b3 bug 59264: copy cell border style codes (from CellStyle.java) into BorderStyle enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737752 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:27:20 +00:00
Javen O'Neal
8e1b343761 rearrange BORDER_DOTTED and BORDER_HAIR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737751 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-04 23:26:44 +00:00
Dominik Stadler
b46a57926c Bug 55982: Don't fail to open the spreadsheet if no TabIdRecord is found 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737602 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-03 18:32:22 +00:00
Dominik Stadler
328c52aab7 Fix some cases where file handles are not closed in OldExcelExtractor 
Close resources in some more tests to make the file-leak report clean again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737487 13f79535-47bb-0310-9956-ffa450edef68
 2016-04-02 11:01:43 +00:00
Dominik Stadler
d0513f2ca6 Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets. 
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-31 13:32:05 +00:00
Dominik Stadler
33cf4c310b DumpPOIFS: Create a separate named sub-directory for each file to not overwrite each other when passing in multiple files for dumping, check for failing mkdirs() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737031 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:44:11 +00:00
Dominik Stadler
992adb9c16 Revert set of inadvertedly committed files/changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 18:11:44 +00:00
Dominik Stadler
f5332a3a40 Bug 58915: Add note about memory consumption and update changelog 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 17:30:55 +00:00
Dominik Stadler
02b29ea698 Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-29 14:53:44 +00:00
Andreas Beeker
ceda10fa32 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 22:46:53 +00:00
Dominik Stadler
0115c12e2d Fix some compiler warnings, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-28 20:22:08 +00:00
Javen O'Neal
e2615ce68e bug 59212: Do not check for overlapping regions when adding merged regions to a sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 09:02:08 +00:00
Dominik Stadler
d806c2ac2b Check for null in IOUtils.closeQuietly() to not log this unnecessarily 
Add coverage for some  more methods in ExtractorFactory
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-22 07:51:39 +00:00
Andreas Beeker
197aef5420 findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:42:56 +00:00
Andreas Beeker
762864d0f2 findbugs fixes - RR_NOT_CHECKED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 23:29:06 +00:00
Andreas Beeker
e9f333827d fix eclipse warnings 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-21 00:14:21 +00:00
Andreas Beeker
87f4e8fa63 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-18 22:21:12 +00:00
Andreas Beeker
33991bfd98 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:39:20 +00:00
Andreas Beeker
492e51b15f findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 22:36:11 +00:00
Andreas Beeker
3e6de40c64 sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-17 21:52:53 +00:00
Andreas Beeker
4187b04edb forgot another contains call ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:40:00 +00:00
Andreas Beeker
61388344ba findbugs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:36:17 +00:00
Andreas Beeker
56ceb000f1 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 23:30:19 +00:00
Andreas Beeker
d6d47e0bca findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 22:10:27 +00:00
Andreas Beeker
80e4d8b879 First try of uncluttering CellNumberFormatter. 
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-16 21:18:58 +00:00
Nick Burch
4d7955d6b5 Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-15 11:50:57 +00:00
Dominik Stadler
d853210049 Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 11:58:15 +00:00
Andreas Beeker
3f4f58829d HSLF: Add support for system colors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-14 00:42:59 +00:00
Dominik Stadler
4bd9afde4f Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:38 +00:00
Dominik Stadler
0a5dcbec1b Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:30:18 +00:00
Nick Burch
2718aa2f51 Escape spaces in the URL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 21:19:46 +00:00
Andreas Beeker
653403e956 #59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-13 19:31:32 +00:00
Dominik Stadler
9bf1bf60b2 Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 16:56:33 +00:00
Andreas Beeker
8e36872c48 #59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 13:33:53 +00:00
Dominik Stadler
2b28cd97a3 Apply patch to fix bug 57495: getTableArray method can not get 0 pos table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:45:34 +00:00
Dominik Stadler
06083f85f4 Refactor some common code from the various Document-Factories into a helper class 
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:32 +00:00
Dominik Stadler
128a991f9c Findbugs fixes 
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 11:36:56 +00:00
Andreas Beeker
7d6be0ff54 #59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-11 23:14:09 +00:00
Andreas Beeker
1b9523898d sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6 Remove a superfluous/bloated log function, which String.format can do better and is only used once ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 20:57:26 +00:00
Nick Burch
9090741226 More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
 2016-03-09 10:57:52 +00:00
Andreas Beeker
261ef4934c #59056 - Render individual slideshow shapes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25 Fix NPE of regression tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-29 23:36:58 +00:00
Nick Burch
62b5b0d874 #59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0 Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:43:59 +00:00
Nick Burch
0b8283b37c Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15 Regression fixes for H/XSLF and HWMF 
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-24 22:39:11 +00:00
Dominik Stadler
10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-21 20:41:56 +00:00
Javen O'Neal
c80fa0c870 bug 56345: reject single-cell merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-18 01:33:14 +00:00
Javen O'Neal
3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 20:27:59 +00:00
Nick Burch
86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 14:40:24 +00:00
Dominik Stadler
98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 08:33:12 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a 
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:46 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:14:55 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called 
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-29 22:09:03 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns 
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-24 00:12:10 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 19:56:30 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:01:33 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:46:17 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:05 +00:00
Nick Burch
c86a4af85e Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491 #58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:26:26 +00:00
Andreas Beeker
b0c16b8261 #57796 - Support hyperlink extraction when rendering slides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207 More Office 12 DSI property IDs, getters/setters to follow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805 Bump up the max DSI property ID, and list a few Office 12 well known IDs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:26:24 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 02:20:35 +00:00
Javen O'Neal
1e9fd97f78 bug 58815: javadoc spelling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-07 01:53:05 +00:00
Dominik Stadler
c4c9ac0ccf bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:17 +00:00
Javen O'Neal
347881ef1e bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7 bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 03:40:22 +00:00
Andreas Beeker
f317f5e288 #56570 - RecordType has repeat by code type 3009 
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 22:10:17 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:44 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:23 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 02:57:58 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:50:54 +00:00
Javen O'Neal
0ef05fcdab java docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:11:13 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 05:43:11 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:43 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:35:59 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-20 20:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 09:51:22 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:11:38 +00:00
Javen O'Neal
4aa6108c0d add hashCode for corresponding equals function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:59:26 +00:00
Javen O'Neal
abced24fe4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:56:59 +00:00
Javen O'Neal
26abacebaf FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:54:21 +00:00
Javen O'Neal
3b24eaacd3 make fields static 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:51:03 +00:00
Javen O'Neal
93497e5b0e add comments for names of missing functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:01:58 +00:00
Javen O'Neal
b6e5801a1c fix javadocs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:20:36 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:10:26 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:36:27 +00:00
Javen O'Neal
293ef9fe17 remove deprecated functions (since 2008) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:30:34 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide 
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 23:34:30 +00:00
Javen O'Neal
b58839e4b0 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717162 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:36:17 +00:00
Javen O'Neal
71b587ef36 bug 58671: change MissingCellPolicy from class to enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717157 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:24:06 +00:00
Javen O'Neal
226fefe0c9 patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 00:22:50 +00:00
Javen O'Neal
0e04793c2c bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:31:57 +00:00
Javen O'Neal
0a69246abc add @Override annotations to Sheet classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:27:34 +00:00
Javen O'Neal
79e099f5fa Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:45:24 +00:00
Javen O'Neal
d8223753ae javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 13:15:03 +00:00
Javen O'Neal
74f0442563 bug 58667: make SX/X/HSSFRow implement Comparable interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 12:14:45 +00:00
Javen O'Neal
16c1afa0d0 HSSFRow: make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717049 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:58:26 +00:00
Javen O'Neal
9d014aa00b bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:43:17 +00:00
Javen O'Neal
659662b5f8 bug 58636: make ClientAnchor enum constructor private, make byId Internal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717024 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:18:45 +00:00
Javen O'Neal
8c1517eee4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:55:02 +00:00
Javen O'Neal
47dc6340c2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:53:22 +00:00
Javen O'Neal
2a62f57db5 +FIXME 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:30:18 +00:00
Javen O'Neal
19f4f8af22 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:52:25 +00:00
Javen O'Neal
e8b2d5feb4 bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:48:17 +00:00
Javen O'Neal
2e795a5f26 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716342 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 09:48:36 +00:00
Javen O'Neal
1f874be829 bug 58636: upgrade anchor types from int to AnchorType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 07:16:43 +00:00
Dominik Stadler
e20da28904 Remove useless double check on null introduced with the previous bugfix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716082 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 09:10:27 +00:00
Javen O'Neal
72aae0f14b bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:52:45 +00:00
Javen O'Neal
e117107313 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716073 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:50:53 +00:00
Javen O'Neal
e25f69814c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716060 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:15:42 +00:00
Javen O'Neal
d58342dd9f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716057 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:13:10 +00:00
Javen O'Neal
735c43ec9d bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:04:42 +00:00
Javen O'Neal
e7d29ad533 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:53:17 +00:00
Javen O'Neal
8eabc4710a bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:43:53 +00:00
Javen O'Neal
891f2d26fc bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:34:09 +00:00
Javen O'Neal
cd254f2f1e FindBugs MALICIOUS_CODE, finalize method should have protected access 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716006 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:20:45 +00:00
Javen O'Neal
a736ac1777 FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:11:57 +00:00
Javen O'Neal
cba32cd1a0 FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:10:47 +00:00
Javen O'Neal
6acd60f74d fix normal priority FindBugs warning: DMI_INVOKING_HASHCODE_ON_ARRAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715998 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 00:08:22 +00:00
Javen O'Neal
10eb8f8095 fix javadoc warnings from r1690486 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715996 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:57:40 +00:00
Javen O'Neal
4dd060e25b fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715987 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:34:33 +00:00
Javen O'Neal
3e10c4f0f6 bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:11:28 +00:00
Javen O'Neal
dbba80c3fc bug 58637: contribution from Hannes Erven: add CellAddress class, distinct from CellReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715743 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 09:30:53 +00:00
Andreas Beeker
4ccadf7315 fix unnecessary cast warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-22 12:30:42 +00:00
Andreas Beeker
7458fdc277 In preparation for table rendering, added table row heights and column widths to common sl. 
To have better results in rendering switch anchor from java.awt.Rectangle to Rectangle2D.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715540 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 15:54:01 +00:00
Andreas Beeker
07dc2b9e08 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-19 01:44:38 +00:00
Andreas Beeker
a0e06add7a #54210 When saving PPT to PNG, some text is rendered backwards 
#53189 Shapes drawn wrongly when ppt file converted to image
fix line decoration (HSLF)


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714290 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:44:07 +00:00
Andreas Beeker
67b4477a7e Fix typo in EscherProperties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714289 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:42:05 +00:00
Uwe Schindler
493a157e6a Fix remaining security manager problems. Forbiddenapis now passes. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 19:11:35 +00:00
Uwe Schindler
73a8488838 #58597: Fix tests to not do setAccessible(), add some doPrivileged, too. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 16:57:39 +00:00
Uwe Schindler
b62cc549fe #58597: Remove setAccessible (more coming soon) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713770 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 07:41:54 +00:00
Uwe Schindler
8c3cd70589 Use Lucene's unmapping code inside AccessController.doPrivileged() for unmapping mapped byte buffers. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713350 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:06:01 +00:00
Andreas Beeker
d1d1298d96 #53192 - Images in ppt file have wrong width when convering ppt to png 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713332 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 01:28:31 +00:00
Uwe Schindler
66ce32aee1 Add reason message to @SuppressForbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713324 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:44:24 +00:00
Andreas Beeker
1a32b63fd3 #52297 - Bullets are not aligned properly while converting ppt slide to image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713316 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:11:22 +00:00
Dominik Stadler
4cdcc9fc24 Eclipse warnings, typos, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713216 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:24 +00:00
Nick Burch
172593de22 Add a XWPFRun equivalent of isHighlighted, and add to the common WP interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712793 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 15:15:36 +00:00
Nick Burch
ecab3629d8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712606 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:25:35 +00:00
Nick Burch
0e7caa5eb1 Bug #55265 - DataFormatter correct support for alternate number grouping characters, eg 1234 + #'##0 = 1'234 not 1,234 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712605 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:23:17 +00:00
Javen O'Neal
20ba4851a8 fix for bug 51622: autosize columns with leading whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 06:39:57 +00:00
Javen O'Neal
265d198612 bug 58576: rename canComputeColumnWidht to canComputeColumnWidth 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:23:09 +00:00
Javen O'Neal
3b88a60498 supporting change for bug 57450 from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:07:11 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues 
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 23:46:57 +00:00
Javen O'Neal
9b8250832e bug 58572: replace Cloneable with copy constructors for spreadsheet Hyperlink class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711951 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 12:57:57 +00:00
Javen O'Neal
f7fbfcd5ea bug 58348: add hyperlink copying and merging to CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711926 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:59:32 +00:00
Javen O'Neal
0eb6ec6717 bug 58572: move getHyperlinkList() and getHyperlink(row, col) from XSSFSheet to Sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711923 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:40:49 +00:00
Javen O'Neal
87ad007ce4 add ASF License 2.0 header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711901 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 05:33:31 +00:00
Javen O'Neal
1360cd835d bug 58348: add support for copying rows for XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711885 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:50:33 +00:00
Javen O'Neal
b729d3896c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711880 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:45 +00:00
Javen O'Neal
40b250bbb3 replace deprecated usage of FormulaShifter.createForRowShift 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711879 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:03 +00:00
Javen O'Neal
fa7beda123 remove unneeded SuppressWarnings("resource") decorator from getSheetName 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711878 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:13:35 +00:00
Javen O'Neal
af4a96f467 bug 58384: add FormulaShifter.createForRowCopy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711866 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:25:08 +00:00
Andreas Beeker
ae69a781f5 close resources, as SlideShow is now Closeable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711865 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:05:14 +00:00
Javen O'Neal
44edbec0d5 prepare for bug 58348, make FormulaShifter.ShiftMode enum private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711864 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:54:13 +00:00
Javen O'Neal
adcc71257a whitespace changes: replaced tabs with 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711862 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:30:48 +00:00
Andreas Beeker
72834dfffa FindBugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711708 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:13:35 +00:00
Andreas Beeker
8ebc22a84e Add method for setting bullet styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711707 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:43 +00:00
Andreas Beeker
6485c11305 Make SlideShow closeable as of HSLF references a NPOIFSFileSystem and hasn't closed it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711706 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:17 +00:00
Javen O'Neal
d0694f4fc9 whitespace change 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711680 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 19:56:22 +00:00
Javen O'Neal
f98fda03c1 add javadoc info for intersects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711613 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 12:21:51 +00:00
Javen O'Neal
1aa81eb463 bug58452: set cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711605 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:57:39 +00:00
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:39:01 +00:00
Javen O'Neal
5f23aa95f7 bug 58442: in-place reorganize an AreaPtg as upper-left and lower-right 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711592 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:10:28 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 10:22:19 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:28:38 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText() 
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 01:05:27 +00:00
David North
b0551e322e Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58549 
Thanks to Damian Cugley for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710552 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 10:32:30 +00:00
Nick Burch
8cd7f1f736 58536 DataFormatter and CellFormat non-localised support for localised currency formats like [$£-809] 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710484 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 21:20:44 +00:00
Nick Burch
dc947416d4 Mention about Locale definitions in Excel cell data format strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:13:16 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which 
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:34:47 +00:00
Dominik Stadler
dd48f58f95 Bug 58085: removing sheet breaks other existing sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710193 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 12:11:40 +00:00
Javen O'Neal
c22fdbbc2b bug 58441: define equals method for CellRangeAddressBase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710172 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 11:17:06 +00:00
Javen O'Neal
ab729cfd0e bug 58402: make AreaReference's private SpreadsheetVersion _version variable final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710163 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 09:54:32 +00:00
Javen O'Neal
522b6d4a15 bug 58439: rename private FormulaShifter.adjustPtgDueToShiftMove to adjustPtgDueToSheetMove 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710147 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:56:49 +00:00
Dominik Stadler
a00240f212 Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:53:41 +00:00
Dominik Stadler
d15ef65b8f Bug 58341: fix some edge cases in the DStar function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708606 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:31:04 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor 
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 20:43:42 +00:00
Andreas Beeker
cab7f9c2e0 fix forbidden apis issue and make non-static as decimalformat is not thread-safe 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707166 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 22:52:05 +00:00
David North
efee7bf83f Format numbers more like Excel does 
Thanks to Chris Boyle for the patch

https://bz.apache.org/bugzilla/show_bug.cgi?id=58471

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706971 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 09:56:26 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 00:04:12 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:28:54 +00:00
Andreas Beeker
0d29f8b2ec obsoleted Codec classes by HexDump 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706741 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:27:47 +00:00
Andreas Beeker
8aec6ba738 removed obsolete classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706740 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:45 +00:00
Andreas Beeker
d9c0fb9ce5 Fixed a problem with save-and-load of conditional formattings (CFHeader12 wasn't added to conditional formattings, rgb value wasn't saved in extended color) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706739 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:19 +00:00
Andreas Beeker
98e93217fe sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-04 00:35:30 +00:00
Dominik Stadler
030c29cfed Bug 55032: Fix handling missing option values in financial functions PV, FV, NPER and PMT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706254 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-01 14:05:28 +00:00
Andreas Beeker
2de9d527b4 sonar fixes 
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-30 23:06:39 +00:00
Dominik Stadler
99d33a0330 Bug 50319: Make row groups which include row 0 work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705844 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 12:26:08 +00:00
Andreas Beeker
ffd1f4333e sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 08:31:15 +00:00
Andreas Beeker
1b2b506edb Sonar fixes - add cloneable interface to classes with clone() 
Sonar fixes - remove pubic/static/final modifier from interfaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705789 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 23:16:58 +00:00
Andreas Beeker
6f7f16853e Removed HDF API 
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-27 22:14:25 +00:00
Andreas Beeker
bde96d1a9a fixed some wrong nightly assumptions ... (Note to myself, don't rely on ant automatic file change detection, but run ant clean before ...) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704999 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-24 05:51:38 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes 
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 23:22:46 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-22 19:50:37 +00:00
Nick Burch
c556e08a52 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704393 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 19:18:40 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio 
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:09:45 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF) 
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 02:25:35 +00:00
Dominik Stadler
a207e463e9 Bug 57925: Add unit test and a simple fix to at least avoid the NPE when Workbooks have invalid external references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703999 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-19 12:22:42 +00:00
Dominik Stadler
3a325dc5dc Bug 57915: Fix Dev2Hex for numbers larger than Integer.MAX_VALUE and less than Integer.MIN_VALUE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703672 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 19:23:25 +00:00
Nick Burch
9647b62d1a Patch from Javen ONeal from bug #58245 - Make Workbook support iterating over Sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703573 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-17 11:10:11 +00:00
Dominik Stadler
8f604e8563 Eclipse warnings, code formatting, simplify ExcelAntWorkbookUtilFactory, always close resources, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703028 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-14 18:40:23 +00:00
Dominik Stadler
a5918f26fe Update javadoc for bug 56129 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702805 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:32:50 +00:00
Dominik Stadler
c6f875fbb9 Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 19:05:55 +00:00
Andreas Beeker
50777f1e48 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702773 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-13 12:36:56 +00:00
Andreas Beeker
5f94d8b533 fix eclipse warning - mostly generics cosmetics 
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-12 18:45:07 +00:00
Dominik Stadler
768060a8ff Bug 58353: Return correct value in Match-Function with match-type == -1 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702535 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-11 18:52:29 +00:00
David North
728e202b6b Patch from https://bz.apache.org/bugzilla/show_bug.cgi?id=58347 - s/arg/filename for a more descriptive filename 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702060 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-09 17:27:49 +00:00
Andreas Beeker
aea434a135 forbidden apis fixes - a few DateFormat clean ups ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-09 00:41:03 +00:00
Andreas Beeker
50107cae16 Bug 58326 - Forbidden APIs patches - second set of changes for charset settings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701713 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-08 00:04:12 +00:00
Andreas Beeker
91e6a64627 forbidden apis fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 22:34:21 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:19:50 +00:00
Dominik Stadler
de46578051 Bug 56959: Add verification unit test to show that the bug cannot be reproduced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701135 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:32 +00:00
David North
7d1947ad3a Make D* functions thread safe, thanks to Patrick Zimmermann for the patch. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701055 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 15:58:00 +00:00