Commit Graph

7486 Commits

Author SHA1 Message Date
Andreas Beeker
377615e9cd #61169 - Text with Japanese characters overflows textbox
- add resize methods with Graphics argument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801329 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 22:20:55 +00:00
PJ Fanning
cfc7aa4315 [Bug 58975] add test case for new function args default of 255
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801307 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:15:49 +00:00
PJ Fanning
23567cd3a0 [github-25] support excel number trailing comma format - Thabks to Luca Martini for proving the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800975 13f79535-47bb-0310-9956-ffa450edef68
2017-07-06 07:56:57 +00:00
PJ Fanning
a0aa8807b5 [Bug 58975] do not cast numberOfOperands to byte in AbstractFunctionPtg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800949 13f79535-47bb-0310-9956-ffa450edef68
2017-07-05 22:56:32 +00:00
PJ Fanning
a33eef41a0 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800717 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 22:18:25 +00:00
PJ Fanning
86f7d0b896 [Bug 60422] fix data formatter issue with specific format in German locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800713 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 20:56:02 +00:00
PJ Fanning
68be989d22 [Bug 61246] remove flush method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800712 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 20:32:55 +00:00
PJ Fanning
0c9a1ef203 [Bug 61246] fix issue where SXSSF sheet data has unicode surrogate chars replaced by '?'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800705 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 18:49:25 +00:00
PJ Fanning
e02f6e038f Remove check for jdk1.5 in test because POI now only supports jre1.6 and up
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800696 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 16:16:35 +00:00
PJ Fanning
3cac752c89 Add missing deprecations for CellType methods that return ints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800569 13f79535-47bb-0310-9956-ffa450edef68
2017-07-02 17:12:55 +00:00
PJ Fanning
0aa4406a08 add test case for date formatting using different locales
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800558 13f79535-47bb-0310-9956-ffa450edef68
2017-07-02 12:29:37 +00:00
Andreas Beeker
a09a3398cc #61243 - Refactor and unify toString/toXml in DDF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800452 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 20:21:33 +00:00
PJ Fanning
cbb15b1efa Remove more deprecated code (MissingCellPolicy)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800400 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 13:00:57 +00:00
PJ Fanning
05d8c18a58 Remove more deprecated code (BorderFormatting constants)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800385 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 12:18:13 +00:00
PJ Fanning
ee70c9a8fb Remove more deprecated code (especially from Spreadsheet Cell classes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 11:48:23 +00:00
Javen O'Neal
e552b04d9c remove incomplete javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800361 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 07:48:40 +00:00
Javen O'Neal
7cb0588daf add @Internal annotation to methods that return a CT* class
add @Override annotation where missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 07:45:46 +00:00
Greg Woolsey
07a7987a48 Expose one more bit of style information generically (for XSSF). If someone needs all these properties for HSSF charts as well, we can build a new Interface for the various bits and populate it with things like axis line width and color, etc. but for now I think most users are in the XSSF realm like me.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800341 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 23:06:27 +00:00
Nick Burch
2cbd15ece2 Deprecated xssfSheetIterator has been removed, so remove javadoc reference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800288 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 14:38:41 +00:00
Andreas Beeker
b2d19936ef remove temporary jenkins debug output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800263 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 10:49:22 +00:00
Andreas Beeker
1ce039753a remove timezoned call to Date.toString() - SignatureProperties don't necessarily need an Id attribute
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800257 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 09:33:33 +00:00
PJ Fanning
2ec623fe0b remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800256 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 09:06:30 +00:00
PJ Fanning
af35e389da remove some unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:55:35 +00:00
PJ Fanning
5f6e2b780a remove deprecated POIXMLDocument.hasOOXMLHeader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800254 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:45:00 +00:00
PJ Fanning
1281127420 remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800249 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:37:02 +00:00
PJ Fanning
657784ce1a Remove old XSSFWorkbook wb.xssfSheetIterator method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800248 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:15:50 +00:00
PJ Fanning
4bcc0f4eb1 Remove old XSSFPaswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:10:32 +00:00
Nick Burch
b3149fe1ad Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800214 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:30:15 +00:00
Nick Burch
07c18a9055 Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800212 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:29:58 +00:00
Nick Burch
a658a7f573 Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800211 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:25:41 +00:00
Andreas Beeker
9ef695aedf add debugging info to find signature differences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800209 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:04:25 +00:00
PJ Fanning
5c65b55bd4 Ensure SpreadsheetVersion is set for AreaReferences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
Andreas Beeker
51b46a9e4e Bug 61182 - Invalid signature created for streamed xslx file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800207 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 21:38:23 +00:00
PJ Fanning
4209a1b2da Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
Nick Burch
a753adb848 Add import for javadocs references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799832 13f79535-47bb-0310-9956-ffa450edef68
2017-06-25 19:16:36 +00:00
PJ Fanning
03d4e52bc0 expand StaxHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 13:53:47 +00:00
Andreas Beeker
85963a56f7 rollback invalid commit - r1799740
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799742 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 09:20:02 +00:00
Andreas Beeker
6aae53935a release prepare for 3.17-beta1 - pin documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799740 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 09:03:00 +00:00
PJ Fanning
61b0ecbd4b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 07:30:07 +00:00
Greg Woolsey
972d561897 Add file that failed regression tests as a unit test.
Adjust table style processing to allow for AlternateContent wrappers for table element style definitions.  


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799733 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 05:55:45 +00:00
PJ Fanning
eee5205d0c [Bug 60422] Fix forbidden-api build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799723 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:37:03 +00:00
PJ Fanning
c1cc93a2ef [Bug 60422] Tidy up test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799722 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:15:20 +00:00
PJ Fanning
66b39c70ad Bug 60422 add testtestcase with current LocaleUtil workaround
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799721 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 23:42:25 +00:00
Greg Woolsey
0e23e4e9d8 Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 15:43:48 +00:00
Greg Woolsey
12048f528b Bug 61203
one of these days I'll add the copyright to my project templates.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799645 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 06:17:09 +00:00
Greg Woolsey
8c67848ad6 Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor
This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799643 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 05:16:38 +00:00
Tim Allison
649280df8c bug 61045 -- allow for (and log!) extra bytes in FormatRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 18:11:34 +00:00
Tim Allison
fe5f8fb54c bug 61053 -- not a fix, but this aligns XSSFBSheetHandler's behavior with streaming and non-streaming extractors for xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799345 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 12:59:33 +00:00
Javen O'Neal
c0e5fcaa98 javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799332 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:52:43 +00:00
Javen O'Neal
1866c69754 @Ignore("requires an internet connection to a 3rd party site"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799326 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:16:05 +00:00
Javen O'Neal
9326624d76 unit test that is not written yet should fail
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799324 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:13:18 +00:00
Javen O'Neal
de9134c1d8 simplify unit test code with IOUtils.write to a NullOutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799323 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:12:42 +00:00
Nick Burch
4a51090ae7 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799320 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:04:02 +00:00
Javen O'Neal
171692edf2 bug 57919: close opened resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799316 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 08:13:58 +00:00
Javen O'Neal
46b5d839c3 bug 57919: add functions to write and close a POIDocument, guaranteeing closure of the output stream and document.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799308 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:28:14 +00:00
Javen O'Neal
5971083683 rename createXls and createXlsx helper functions: these are specifically for testing text rotation.
Made the file creation compatible on Windows and Mac/Linux using POI TempFile instead of a hard-coded filename.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799307 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:05:08 +00:00
Javen O'Neal
51065c8159 bug 58113: this passes with SXSSF now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799306 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:03:13 +00:00
Javen O'Neal
15212e0feb bug 56557: open test-data/spreadsheet/56557.xlsx such that the unit test test56557() does not leave a modified file on disk after running.
I verified that
> Workbook wb = XSSFTestDataSamples.openSampleWorkbook("56557.xlsx")
and
> Workbook wb = WorkbookFactory.create(XSSFTestDataSamples.getSampleFile("56557.xlsx"), password=null, readOnly=false);
both fail when the fix from r1798913 for SXSSFWorkbook is not applied and both pass when the fix is applied.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799304 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 06:08:38 +00:00
Javen O'Neal
4d692223bb whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799303 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:51:48 +00:00
Javen O'Neal
5de40d3261 bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799302 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:47:56 +00:00
Dominik Stadler
2095c92402 Improve error message if we encounter invalid/unexpected files in integration tests
Adjust some tests slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799178 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 11:05:20 +00:00
Dominik Stadler
66bf6c5ad7 Need to do the casting differently to make the code compile with Java 6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799038 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:31 +00:00
Dominik Stadler
128ba623f8 Don't try to clone a chart, this makes integration-tests work for a few more documents, also the one added via bug 56557
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799037 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:25 +00:00
Dominik Stadler
bac17be565 Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799035 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:11 +00:00
Andreas Beeker
0e57435abe #61169 - Text with Japanese characters overflows textbox
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798986 13f79535-47bb-0310-9956-ffa450edef68
2017-06-17 00:00:49 +00:00
Dominik Stadler
20f46393f7 Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798913 13f79535-47bb-0310-9956-ffa450edef68
2017-06-16 11:35:31 +00:00
Javen O'Neal
c05e2ae644 bug 61170: add comment why we should catch exceptions in SAXHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798793 13f79535-47bb-0310-9956-ffa450edef68
2017-06-15 05:08:24 +00:00
Javen O'Neal
f66153c810 bug 61170: add extra logging to SaxHelper.
Thanks to PJ Fanning for the patch!
This closes #58 on github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798792 13f79535-47bb-0310-9956-ffa450edef68
2017-06-15 05:00:25 +00:00
Andreas Beeker
14b2d4501a #61162 - En-/decryption support for HWPF
- encryption support for HWPF
- refactor/unify EncryptionInfo handling in H**F classes
- remove Iterable interface from WorkbookRecordList - use getRecords() instead, to prevent modifications over the Iterator

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798722 13f79535-47bb-0310-9956-ffa450edef68
2017-06-14 17:21:50 +00:00
Greg Woolsey
e5c5cba87c Standardize some more common chart axis properties.
Implement the ChartAxis ss interface for date axes, which are pretty much a category axis with one extra property, a date granularity (not currently passed through, get it still from the CT* class).  Created the class and test from the category axis versions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798414 13f79535-47bb-0310-9956-ffa450edef68
2017-06-12 05:38:41 +00:00
Greg Woolsey
8d7bab82bb Don't report data table master cells as formula cells, since POI doesn't evaluate data table formulas.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798289 13f79535-47bb-0310-9956-ffa450edef68
2017-06-10 01:04:40 +00:00
Dominik Stadler
05570364db Move one testcase with incorrect source location
remove some junit dependencies in example-code
build: do not pass junit-jar to normal compile targets to avoid introducing it as dependency again 
Reformat code, fix warnings, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798202 13f79535-47bb-0310-9956-ffa450edef68
2017-06-09 12:49:01 +00:00
Dominik Stadler
938bb91c51 Bug 60374: Add test for ArrayIndexOutOfBounds on old Word Documents due to Non-Unicode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798200 13f79535-47bb-0310-9956-ffa450edef68
2017-06-09 12:47:03 +00:00
Nick Burch
993801aa1c Update the CreateTable example to reduce the use of the raw CT classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797923 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 13:35:20 +00:00
Nick Burch
7b38f8c5f1 Permit table style modifications, needed for CreateTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797922 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 13:33:58 +00:00
Nick Burch
fd0e150a94 Make it possible to create simple XSSF sheet tables without needing CT classes directly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797919 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 13:06:38 +00:00
Nick Burch
2ce00a5a78 XSSFTable should format numeric/date cells when used as Column Header names as Excel does, see https://stackoverflow.com/questions/44407111/apache-poi-cant-format-filled-cells-as-numeric
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797914 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 12:39:41 +00:00
Andreas Beeker
a5dda416e7 Ignore JCE restriction errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797856 13f79535-47bb-0310-9956-ffa450edef68
2017-06-07 06:25:56 +00:00
Andreas Beeker
20dcde37ec Handle encrypted files with known password in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797839 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 22:21:46 +00:00
Andreas Beeker
739599059a Replace HWPFOutputStream with ByteArrayOutputStream - it doesn't add any new features
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797838 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 22:21:40 +00:00
Andreas Beeker
2b4f944883 #61162 - En-/decryption support for HWPF
Decryption for Binary RC4 and CryptoAPI (... XOR is missing)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797837 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 22:21:11 +00:00
Javen O'Neal
b0d0f2d255 bug 58325: enable TestXSSFShape unit tests. Thanks to Dominik Stadler for the initial unit test. Thanks to PJ Fanning for discovering that the bug was fixed at some point in the past and enabling the unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797600 13f79535-47bb-0310-9956-ffa450edef68
2017-06-04 18:59:18 +00:00
Andreas Beeker
efccafd898 fix eclipse resource leak warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797043 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 14:10:18 +00:00
Javen O'Neal
4232a72208 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796966 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 02:46:24 +00:00
Andreas Beeker
95164e4a50 SonarQube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796962 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 00:31:53 +00:00
Greg Woolsey
7e6007e0bd #61085 support table styles
Needed a bit more, to support table/range only border properties for "internal" vertical and horizontal borders.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796961 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 00:22:58 +00:00
Andreas Beeker
49e47cb6e1 Bug 61119 - Fix preset shape rendering and shading
- Fixed conversion of ooxml to awt angle
- replace subclasses and reflection calls with enums
- implemented tinting/shading of preset shapes


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796823 13f79535-47bb-0310-9956-ffa450edef68
2017-05-30 09:33:28 +00:00
Javen O'Neal
b3c6907741 bug 61059: fix NamePtg to read unsigned shorts instead of signed shorts, avoiding a AIOOBE when a workbook contains more than 32k Names. Thanks to Travis Burtrum for the patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796466 13f79535-47bb-0310-9956-ffa450edef68
2017-05-28 01:17:16 +00:00
Greg Woolsey
479b45ced9 Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color
Missed this test.  As part of the work I noticed the Enum was missing some values defined in the OOXML spec, so I added them.

I've updated the test to reflect that those values are no longer invalid.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796360 13f79535-47bb-0310-9956-ffa450edef68
2017-05-26 23:37:04 +00:00
Greg Woolsey
586cf38f1c Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color
teach XSSFColor and most things that create instances about indexed colors.

Null is a valid value for IndexedColorMap instances - the existing built-in default colors are used.

Whenever a workbook style is accessible in the call hierarchy its color mappings are passed down now.

Thanks for the unit test in the issue, it now passes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796359 13f79535-47bb-0310-9956-ffa450edef68
2017-05-26 23:14:48 +00:00
Dominik Stadler
d868026959 Bug 61063: Add a RefListEval to handle UnionPtg and implement it for Rank(), may be missing for other functions where ArrayEval is currently handled
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795963 13f79535-47bb-0310-9956-ffa450edef68
2017-05-23 21:13:02 +00:00
Dominik Stadler
8564aa7bb6 Reformat code somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795962 13f79535-47bb-0310-9956-ffa450edef68
2017-05-23 21:12:50 +00:00
Javen O'Neal
7881d05743 github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795681 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 21:04:14 +00:00
Javen O'Neal
4ff23197e9 bug 61110: remove deprecated, misspelled CellReference#isRowWithnRange and #isColumnWithnRange methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795680 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 20:22:24 +00:00
Greg Woolsey
2d2aa5196a #61085 support table styles
Added more features - this allows a client app to fully display table styling without resorting to CT* classes, and has some helper logic for the additional processing needed for things like regional/area borders.

As far as I can tell I only added stuff, didn't change any existing behavior.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795648 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 04:05:32 +00:00
Javen O'Neal
284f7d19c5 github-55: NumberFormatException if XSSFName.setNameName is set with a long name that looks similar to a cell address. Thanks to Thomas S @Millie4Ever
This closes #55 on github.
https://github.com/apache/poi/pull/55

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795595 13f79535-47bb-0310-9956-ffa450edef68
2017-05-19 08:26:41 +00:00
Javen O'Neal
0b767886bf replace "String.indexOf(String) >= 1" with "String.contains(String)"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795296 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 10:53:15 +00:00
Javen O'Neal
f701e81a64 github-25: add enable locking and tab color in SXSSFSheet. Thanks to Danilo Rangel. This closes #25.
https://github.com/apache/poi/pull/25

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795277 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 08:38:58 +00:00
Javen O'Neal
b6f78f8d57 github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication. Thanks to Daniel Kuan! This closes #32.
https://github.com/apache/poi/pull/32

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795266 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:18:17 +00:00
Javen O'Neal
be5106a1d7 github-43: add disabled unit test showing a problem with ROUNDUP(3987*0.2, 2). Thanks to @FishMeat.
https://github.com/apache/poi/pull/43

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795265 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:04:12 +00:00
Nick Burch
fec503f1de Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795261 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 02:50:35 +00:00
Javen O'Neal
b527f96daa github-52: add ExcelToHtmlConverter method that works on InputStreams. Thanks to Tony Zeng! This closes #52.
https://github.com/apache/poi/pull/52

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795256 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 00:58:01 +00:00
Javen O'Neal
fac98b5bef github-53: fix NPE when iterating over paragraphs in certain *.docx files. Thanks to Praful Kumar Vaishnav! This closes #53.
https://github.com/apache/poi/pull/53

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795254 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 00:41:25 +00:00
Javen O'Neal
5c62492ffb github-54: when adding a picture to an XSSFWorkbook, reduce memory consumption by 100x and increase speed by 10x based on OpenJDK JMH benchmarking. Thanks to Tim Helmstedt! This closes #54.
https://github.com/apache/poi/pull/54

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795252 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 23:27:21 +00:00
Andreas Beeker
8c1346b138 Add ASL header and exclude table preset from rat-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795137 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 06:30:06 +00:00
Andreas Beeker
90dca20bd2 #52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Greg Woolsey
bf83a00457 tweak to use platform line separator so tests can pass on Windows as well as Linux.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795026 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 22:13:30 +00:00
Greg Woolsey
0cdc064b0c git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68 2017-05-12 18:01:32 +00:00
Dominik Stadler
e77156d9f4 Simplify the ValueEval.toString() implementations and include more information on unexpected types of ValueEval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794956 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 11:38:05 +00:00
Dominik Stadler
d9df038f4a Bug 60352: Text extraction: Don't include the text "null" for empty cells
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794260 13f79535-47bb-0310-9956-ffa450edef68
2017-05-07 21:03:46 +00:00
Greg Woolsey
8313b17515 60184 - invalid OOXML produced when XSSFFont.getFamily() called with no families defined
Fix to stop creating an empty family when none exist, just use the existing logic to return NOT_APPLICABLE.  Creating the empty element produces XML that doesn't comply with the XSD.

Alternative would have been to set the family int value for the new family, but this way checking the value doesn't change the output, which is my preferred behavior.  No quantum effects!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794111 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 21:50:59 +00:00
Greg Woolsey
6bca07a15f forgot license (as always)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794093 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 18:33:49 +00:00
Greg Woolsey
18d107d974 61060 - teach DataFormatter about conditional formatting rules with number formats
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 17:44:58 +00:00
Andreas Beeker
fb28b14d48 test integration fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793733 13f79535-47bb-0310-9956-ffa450edef68
2017-05-04 01:13:48 +00:00
Andreas Beeker
ad72f60ab6 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 22:16:26 +00:00
Andreas Beeker
76dbb5a1eb HPSF: Change CustomProperties to delegate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 19:18:45 +00:00
Andreas Beeker
d0630390d2 Remove Unicode chars in comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793647 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 14:08:04 +00:00
Andreas Beeker
0f78f6dc1f fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793604 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 00:14:55 +00:00
Andreas Beeker
cd6236c74b #52372 - OutOfMemoryError parsing a word file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:32:13 +00:00
Andreas Beeker
a0b324224b Reverted DocumentSummary hack in codepage guessing code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793601 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:30:17 +00:00
Andreas Beeker
eeb697001f HPSF: Add CopyCompare to IntegrationTests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:29:19 +00:00
Andreas Beeker
3a1771ced1 HPSF: Enable new number types in VariantSupport
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:28:00 +00:00
Andreas Beeker
456b33a837 Fix hpsf javadocs and code issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:27:27 +00:00
Andreas Beeker
5600fa6f58 IntegrationTest - move excludes to file handler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793595 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:25:45 +00:00
Andreas Beeker
63b88fec6a HPSF: Use LittleEndianStream instead of offset calculation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793594 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:24:50 +00:00
Javen O'Neal
95538eb815 bug 61059: add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793418 13f79535-47bb-0310-9956-ffa450edef68
2017-05-01 21:51:34 +00:00
Dominik Stadler
5265ff6f81 Improve information contained in exception in CellRangeAddress()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:44 +00:00
Dominik Stadler
fa39402871 60325: Add commented out test that reproduces the performance issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793251 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:36 +00:00
Nick Burch
28cbb8e84e Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793249 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 08:49:51 +00:00
Javen O'Neal
f5389965a2 bug 61034: break out of for-loop when both <sheet name="", id=""/> are found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793230 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 18:56:09 +00:00
Javen O'Neal
e39ae9cd30 bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 17:27:17 +00:00
Tim Allison
a98eaeb917 bug 61051 -- add new worksheet-like relations for xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792940 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 18:50:22 +00:00
Tim Allison
5f567f29a1 bug 61049 fix ordering of builtin formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 16:18:25 +00:00
Nick Burch
9896e13bf4 Patch from Tim Jones from #61044 - Note on setCompressTempFiles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-26 09:43:56 +00:00
Tim Allison
c2dc3ad585 bug 61021 - extract abspath from xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792198 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 13:02:29 +00:00
Greg Woolsey
f5b90cbbee Add conditional formatting evaluation example code and output results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792102 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 18:05:50 +00:00
Javen O'Neal
3c2a6b38bb Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 01:28:40 +00:00
Javen O'Neal
3cbf4740b1 Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 23:51:03 +00:00
Greg Woolsey
6e0a5916b5 Fix bug #61007
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.

Send what was checked previously plus only multi-segment conditional range formats.  Allows existing tests to pass plus the new test with the case for these conditional formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8 Fix bug #61007
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel.  Also added tests for the failing formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 18:10:52 +00:00
Nick Burch
d4d08d5ce8 Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791857 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 06:13:33 +00:00
Dominik Stadler
511c2544a8 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad #60998 - HSLFTable.setRowHeight sets row height incorrect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 11:02:22 +00:00
Andreas Beeker
594b46f1cd fix forbidden-apis-check error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791646 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 23:43:56 +00:00
Andreas Beeker
bd237e2483 #60996 - XSSF: Multiple embedded objects on same sheet are ignored
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 22:41:28 +00:00
Javen O'Neal
dc29c94460 roll back to hamcrest-core
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791570 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 06:10:23 +00:00
Andreas Beeker
160fb550c1 #60993 - HSLF: Grid and rowspan calculation in table cells is wrong
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791500 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 12:14:26 +00:00
Javen O'Neal
0acf44d3dc improve unit test error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791445 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:21:34 +00:00
Javen O'Neal
ef8c9329cf change from hamcrest-core-1.3 to hamcrest-all-1.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791444 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:19:27 +00:00
Javen O'Neal
e7ca1594da use hamcrest matchers to reduce custom code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:50:46 +00:00
Javen O'Neal
7977026f96 use assertStartsWith and assertEndsWith for better unit test error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:19:24 +00:00
Nick Burch
70ae27f96d #60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791108 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:11:56 +00:00
Nick Burch
3bd1f662f3 Failing, disabled unit test for bug #60973
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791098 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 09:40:54 +00:00
Greg Woolsey
6163e4ca45 Issue #60971, handle formula chart titles
implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:27:23 +00:00
Tim Allison
0ddc4da7e2 bug 50955 - add logging per Javen's recommendation. Thank you!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791021 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:00:12 +00:00
Tim Allison
9412d467f3 bug 50955 - incorporate info from the DocumentSummaryInformation for
guessing the encoding.  Back off to the old method if DocSummInfo is
not available. Thanks to Andreas Beeker for recommending this direction.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791002 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 17:07:04 +00:00
Tim Allison
44d536e4ce bug 50955 - try originally guessed codepoint, backoff to 1252 if that fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790904 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 01:30:02 +00:00
Andreas Beeker
1f41c31984 Fix AIOOBE while extracting hssf pictures which are externally linked
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 21:43:22 +00:00
Dominik Stadler
48526517cd Adjust checking for Zip-Bomb errors so it also works on JDK >= 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790508 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 06:38:23 +00:00
Dominik Stadler
77614b8c49 Test for another type of xml-bomb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:50:03 +00:00
Dominik Stadler
0f193371ea Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 13:17:17 +00:00
Tim Allison
f426849947 bug 50955 convert Set to Singleton per Javen's code review
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 11:02:48 +00:00
Tim Allison
1bfd5f6585 bug 50955 and bug 60953 improve Big5 reader; ensure one character
per byte pair

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 01:45:55 +00:00
Tim Allison
4b0e6dc048 bug 50955 -- turn off test that now passes in Java 1.8 and 1.7
but not 1.6 until we can fix it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790136 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 15:26:01 +00:00
Tim Allison
3c62c898a4 bug 50955 -- fix for java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790130 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 14:41:53 +00:00
Tim Allison
af51ea4c10 bug 50955 -- word 6.0 charset fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 02:06:46 +00:00
Tim Allison
9dcb5d4c47 Bug 60906 -- clean up, and add range checking for casting to ints.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788295 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 18:08:52 +00:00
Tim Allison
3d20031b56 Bug 60489 -- add @Test annotation so that this actually runs and includes ConnectsType...<facepalm/>
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788288 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:56:29 +00:00
Tim Allison
925f4b85ad Bug 60906 -- fix style index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788282 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 16:31:42 +00:00
Tim Allison
3953b18e2b 60881 -- fix unit test to use assumeTrue thanks to Javen's recommendation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1788133 13f79535-47bb-0310-9956-ffa450edef68
2017-03-22 16:21:25 +00:00
Tim Allison
2674dad889 60881 -- strip out system.set props for local test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787891 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:13:11 +00:00
Tim Allison
26dddd5184 60881 -- fix new unit test. xlsb test file apparently requires unlimited jce. If not installed, ignore new test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787890 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 00:03:01 +00:00
Tim Allison
69c3311a98 60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 20:47:15 +00:00
Tim Allison
e4f884a915 60879 -- figure out if we can support old beta xlsb or throw exception. For now, let's hope there's only one diff and/or the other bounds checking etc will throw exception if there are other problems.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787832 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 18:50:25 +00:00
Dominik Stadler
1aee770758 Bug 60042: Add sample file to check if this bug is fixed via bug 55791 already.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787664 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:44:05 +00:00
Dominik Stadler
a22b4aaa2d Bug 60810: Check for duplicate relation-names for notes similar to the fix for slides themselves in bug 55791
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787663 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 21:43:57 +00:00
Dominik Stadler
eef36a1580 Fix typo to "length", closes #51
Fix a few IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:30:04 +00:00
Dominik Stadler
e78eb68b10 60823: DGET function, correct behavior with multiple result entries but only one non-blank
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:29:55 +00:00
Dominik Stadler
bfeeba5eb8 Fix broken imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787585 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 18:46:15 +00:00
Dominik Stadler
69923f8c5a Adjust integration-test files slightly, more failure-output, make it a bit easier to test single-files, add a HeapDump class for investigating memory leaks, adjust XSSFFileHandler to free memory more quickly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787556 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 13:56:11 +00:00
Dominik Stadler
531226ac84 Add docm-file which is actually a binary doc to check handling of wrong-format-exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787555 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 13:56:04 +00:00
Dominik Stadler
12a26bd6ca Fix ROOT_DIR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787330 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 12:03:07 +00:00
Tim Allison
b52126f7f3 60826 -- clean up. Many, many thanks to Javen O'Neal's code review!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787320 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 10:09:59 +00:00
Tim Allison
60b4624cf7 60826 -- update stress tests to handle xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787264 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 22:32:24 +00:00
Tim Allison
730f394261 60826 -- add initial support for streaming reading of xlsb files.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787228 13f79535-47bb-0310-9956-ffa450edef68
2017-03-16 18:37:13 +00:00
Greg Woolsey
6fc050a162 add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786962 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 22:36:38 +00:00
Greg Woolsey
6349d2c614 Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822.
Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af Fix some Sonar issues in sample "HSSFReadWrite"
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 14:09:27 +00:00
Dominik Stadler
abc3d37adc Add tests from bug 45353 to show that this now works fine
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:14:00 +00:00
Dominik Stadler
c07c41659f HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:52 +00:00
Dominik Stadler
aafdbdfdd7 Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:39 +00:00
Tim Allison
b442671274 51519 -- follow on, make concatenation of rPh configurable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786021 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 16:44:40 +00:00
Tim Allison
5bb1195606 51519 -- allow users to ignore or include the <rPh> (phonetic run) element in the ReadOnlySharedStringsTable used in the SAX/streaming xlsx reader.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785965 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 13:41:07 +00:00
Javen O'Neal
8dd5f7b887 store repeated expressions as temporary variables to make code shorter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785793 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 03:16:50 +00:00
Javen O'Neal
5b879942fc bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
2017-03-02 18:47:28 +00:00
Tim Allison
31dd2885dd Bug 60795 -- fixed deprecation, thanks to Javen.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784989 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 16:49:15 +00:00
Tim Allison
5b801a9dc6 Bug 60795 -- add enum for message class in MAPIMessage; deprecate getMessageClass()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784978 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 15:47:47 +00:00
Javen O'Neal
bb6e94851f add helper functions to make it easier to see which scenarios are being tested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784231 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 05:07:10 +00:00
Javen O'Neal
c04e2a314a bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8 add javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9 Add null check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:18:10 +00:00
Andreas Beeker
0744f73add BugFix for JDK-6623219
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
2017-02-19 21:36:45 +00:00
Andreas Beeker
7810671d2d #60662 - Slide import delete unrecognized elements in group shape
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783486 13f79535-47bb-0310-9956-ffa450edef68
2017-02-18 01:07:47 +00:00
Javen O'Neal
9783654301 bug 60742: remove commented out debugging code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 20:53:44 +00:00
Dominik Stadler
feee2b88c8 bug 60742: Remove local test-code from test for bug 60512
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783428 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 17:15:27 +00:00
Javen O'Neal
b2206fc40f bug 60742: write out to unit test TempFile rather than Unix-only /tmp/60512.xlsx; patch from Chiara Marcheschi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783426 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 16:57:43 +00:00
Javen O'Neal
7fcaaa9479 bug 59893: close open resources to prevent leaks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783362 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:53:49 +00:00
Javen O'Neal
85a30f16cf convert from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783360 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:37:00 +00:00
Javen O'Neal
ee6677ee56 bug 59893: fix a few forgotten unrelated changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:25:49 +00:00
Javen O'Neal
1584310ac5 bug 59893: more unrelated changes from Andi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783353 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:08:21 +00:00
Javen O'Neal
8677d099fc bug 59893: commit the changes from attachment 34068 that were unrelated to available()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 08:39:05 +00:00
Javen O'Neal
0443c27ede OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when executing TestAllFiles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783174 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:15:13 +00:00
Javen O'Neal
c1b350201c test-integration: replace redundant static { EXPECTED_FAILURES.add(...) } with (dynamic) Arrays.asList() to improve code legibility.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783171 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:08:44 +00:00
Greg Woolsey
ba7809d69a a new test file needed to be added to the list of sheet clone expected errors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783129 13f79535-47bb-0310-9956-ffa450edef68
2017-02-15 17:48:46 +00:00
Greg Woolsey
ca399b4f42 Bug #56822 fix COUNTIFS()
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b Bug #56822 fix COUNTIFS()
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78 Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae Expose Priority from newer-style HSSF CF rules
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 17:49:13 +00:00
Greg Woolsey
c88649ccd2 Ugh, that's what I get for copying someone else's code without fully reviewing it. Return the boolean property, don't wrap it in an extra if().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782989 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:49:24 +00:00
Greg Woolsey
05125678ab Expose another common property, strikeout.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:45:47 +00:00
Greg Woolsey
117a898e35 Add license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782978 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 15:36:56 +00:00
Nick Burch
1e5fa0dbea Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:35:43 +00:00
Andreas Beeker
43921c1a19 Metro shapes: integration test regression on empty paragraphs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782897 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 00:18:13 +00:00
Greg Woolsey
b0d0d0fda5 Add evaluation of data validation rules and conditional formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 22:51:30 +00:00
Andreas Beeker
d74cfc4df5 Generics fix for metro shapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782722 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 06:46:59 +00:00
Andreas Beeker
41d7483ae3 #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782712 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 00:52:38 +00:00
Andreas Beeker
967a3b0e0c #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
2017-02-12 22:30:49 +00:00
Andreas Beeker
397771011f #60715 - Blank layout was not found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782635 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 21:48:05 +00:00
Andreas Beeker
faaa94d20a escape unicode chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782568 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 09:49:52 +00:00
Andreas Beeker
db3000b142 SonarQube fixes and removed redundant logger level checks, for simple String messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46 Add a possible future TODO
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 14:02:12 +00:00
Nick Burch
fc31afbb86 Use long for the dummy stream, to permit >2gb streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 13:51:33 +00:00
Nick Burch
b6480adb9f If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5 Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 11:43:01 +00:00
Nick Burch
eeae830d19 Start on a unit test for #60670, work required to get it passing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782380 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:51 +00:00
Nick Burch
31ec02043a Unit test comment for possible future expansion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782378 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:15 +00:00
Javen O'Neal
cc962432a4 bug 59030: revert r1746625 and restore r1731257, where XWPFTableCell#getVerticalAlignment() returns null rather than a default value (XWPFVertAlign.TOP) if vertical alignment is not set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782225 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:35:04 +00:00
Javen O'Neal
61f69324c7 bug 59030: convert to junit4; whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782224 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:32:53 +00:00
Javen O'Neal
453a868b41 Per JavaDoc and tallison, XWPFTableCell#getVerticalAlignment() should return null if valign is not set. Patch from prasad-babu. This closes #30 on GitHub.
https://github.com/apache/poi/pull/30#issuecomment-186224438

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782130 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 09:23:04 +00:00
Javen O'Neal
0f09e9eae2 bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:29:18 +00:00
Javen O'Neal
28999738a9 Convert all *.java files to use native end of line character(s)
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Javen O'Neal
c2d3025161 bug 59983: correctly update shared formulas when shifting rows. Thanks to Luca Martini for the initial failing unit test with test file and Chiara Marcheschi for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782111 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:20:31 +00:00
Javen O'Neal
9a82490f0e +svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782109 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:04:55 +00:00
Andreas Beeker
5c4ab1dbdf #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:12:22 +00:00
Andreas Beeker
ac3d63926a #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:01:51 +00:00
Dominik Stadler
f431473f29 Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:40 +00:00
Dominik Stadler
142e52dfba Adjust for JDK 9 ea152 and newer: certain whitespaces in XML may now be trimmed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781821 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:09 +00:00
Tim Allison
be805a6e66 Bug 60677 -- handle multibyte encodings correctly in HwmfGraphics' drawString. Thanks to Dominik Stadler for finding this bug and a triggering doc via large scale regression testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781593 13f79535-47bb-0310-9956-ffa450edef68
2017-02-03 20:19:33 +00:00
Dominik Stadler
db600cf0b4 Adjust expected font-size in tests, XSSF seems to use slightly larger fonts on some machines
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780479 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 20:59:49 +00:00
Dominik Stadler
41e52ffea7 Finally enable test for bug 44937, we got the requested missing test-documents a long time ago already.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780456 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:59:05 +00:00
Dominik Stadler
400bdc08b7 Don't wrap RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780455 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:58 +00:00
Dominik Stadler
37b53744c0 Move test to base-test-class to run it for (S)XSSF as well
Also had to increase the numbers a bit as it fails locally for me otherwise

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780454 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:52 +00:00
Dominik Stadler
560a33620a IntelliJ warnings, Javadoc, Formatting
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:46 +00:00
Dominik Stadler
41795e6936 Cover some dev-tools with a few simple tests, close resources correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780451 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:25 +00:00
Dominik Stadler
797ea00d09 Bug 60031: Enhance test some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780450 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:18 +00:00
Andreas Beeker
4a5f7765bb fix eclipse warnings - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779869 13f79535-47bb-0310-9956-ffa450edef68
2017-01-23 00:31:27 +00:00
Andreas Beeker
c48a0cf334 #59836 - Tracker: Replace primitives with enums
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68
2017-01-22 22:01:22 +00:00
Tim Allison
d9bce7fff9 Bug 60608 -- improve charset handling in Hwmf -- remove deprecated drawString(String...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779613 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 12:10:29 +00:00
Javen O'Neal
93eb933aa6 fix assert message typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779567 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:40:49 +00:00
Javen O'Neal
6aa7fe54e9 fix copy-paste typo in unit test found by Andrzej Witecki
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779565 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:37:12 +00:00
Javen O'Neal
9def800cd4 bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:35:57 +00:00
Javen O'Neal
c46e7d03f3 remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:04:57 +00:00
Javen O'Neal
2f648842cd bug 60605: replace Workbook.SHEET_STATE_VERY_HIDDEN with SheetVisibility.VERY_HIDDEN
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779562 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:00:29 +00:00
Javen O'Neal
dfd906aa9b bug 60605: remove code for enforcing rule that active sheet cannot be hidden
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:55:06 +00:00
Javen O'Neal
647f0a90a2 pull out loop invariants, use List.indexOf to look up sheet index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779560 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:38:18 +00:00
Javen O'Neal
15be6fb336 bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:23:42 +00:00
Javen O'Neal
85575f32f5 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779557 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:20:20 +00:00
Javen O'Neal
47e81bd78c make instance variable final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779551 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 02:16:58 +00:00
Tim Allison
a9436e9789 Bug 60608 -- improve charset handling in Hwmf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779519 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 20:19:26 +00:00
Tim Allison
f6388c2fff Bug 60570 - Add rudimentary EMF read-only capability
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779493 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 16:22:29 +00:00
Javen O'Neal
2abd64f3a9 bug 60601: unset hyperlinks after removing them individually from the DOM
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779437 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 09:01:39 +00:00
Javen O'Neal
b2e807c005 bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779433 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 08:51:04 +00:00
Javen O'Neal
45de2e444a bug 60601: hyperlinks have to be removed one by one to avoid other errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779429 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 08:09:11 +00:00
Javen O'Neal
70cc2bce03 bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779426 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 07:44:25 +00:00
Andreas Beeker
c0986ebe7a SonarQube fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779285 13f79535-47bb-0310-9956-ffa450edef68
2017-01-18 00:59:19 +00:00
Andreas Beeker
75c630f976 fix eclipse warnings / close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778958 13f79535-47bb-0310-9956-ffa450edef68
2017-01-16 01:18:46 +00:00
Andreas Beeker
a7706b3fdf fix eclipse warnings - close resources / type generics
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 23:08:47 +00:00
Andreas Beeker
e436060f24 remove test output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778940 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 19:03:17 +00:00
Andreas Beeker
1445d51f58 Java9 fix - resource not found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778939 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 19:02:48 +00:00
Andreas Beeker
5899f8884d #60586 - Support embedding OLE1.0 package in XSSF / SS Common
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778869 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 02:04:57 +00:00
Tim Allison
86eeda4cbd bug 60584 -- avoid NPE by checking for null/missing image in XSSFReader's getShapes().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778664 13f79535-47bb-0310-9956-ffa450edef68
2017-01-13 20:55:04 +00:00
Javen O'Neal
726fe10074 bug 60260: parse unicode sheet names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68
2017-01-12 10:39:26 +00:00
Tim Allison
13499b6444 Bug 60574 prevent rare NPE in ListTables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778320 13f79535-47bb-0310-9956-ffa450edef68
2017-01-11 16:01:32 +00:00
Andreas Beeker
bf311b8e6e SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777855 13f79535-47bb-0310-9956-ffa450edef68
2017-01-08 00:38:41 +00:00
Andreas Beeker
24c0b83841 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777739 13f79535-47bb-0310-9956-ffa450edef68
2017-01-07 00:26:46 +00:00
Andreas Beeker
1042dacd93 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777669 13f79535-47bb-0310-9956-ffa450edef68
2017-01-06 17:51:22 +00:00
Andreas Beeker
9ee04feeb9 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68
2017-01-06 09:05:14 +00:00
Andreas Beeker
d7da7a0ff4 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777526 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 23:40:57 +00:00
Andreas Beeker
0aa24b3b60 Rename example class (typo)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777518 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 22:49:14 +00:00
Javen O'Neal
42c5a08dfb add unit tests for MAPIMessage.get*Body()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777463 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 12:46:28 +00:00
Javen O'Neal
25db24d2d6 junit improvements: assertEquals(null|true|false, ...) -> assertNull, assertTrue, assertFalse
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777450 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 11:26:42 +00:00
Javen O'Neal
5add583122 bug 60331: remove deprecated OutlookTextExtractor constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777447 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 11:17:44 +00:00
Javen O'Neal
579a132ef3 bug 60331: remove deprecated constructor and method in scratchpad o.a.p.hsmf.MAPIMessage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777444 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 10:41:23 +00:00
Javen O'Neal
cbd8705bed revert accidental commits in r1777435
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777436 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 08:36:06 +00:00
Javen O'Neal
4b99fb8ec1 junit3 -> junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777435 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 08:32:07 +00:00
Javen O'Neal
fd47334832 bug 60550: read ContentID chunks from mail attachments; unit test and test-data/hsmf/attachmet_msg_inlineImg.msg contributed by maoblackberry@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777429 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 08:01:58 +00:00
Javen O'Neal
d10cc5eacd bug 60550: read ContentID chunks from mail attachments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777428 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 07:59:27 +00:00
Javen O'Neal
5152cb9ada whitespace: 3/4sp -> 4sp
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777427 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 07:26:02 +00:00
Javen O'Neal
a3489c0dbb junit improvements:
assertEquals(null, ...) -> assertNull(...)
attachment.getAttachFileName().toString() -> attachment.getAttachFileName().getValue()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777423 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 07:16:27 +00:00
Andreas Beeker
8cc9352d26 EmbeddedExtractor (for *SSF) - added OOXML support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777394 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 01:10:45 +00:00
Javen O'Neal
2680a535bd github-44: reference BuiltinFormats in javadocs for CellStyle.getDataFormat and setDataFormat
This closes #44 github pull request from sixinli

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777260 13f79535-47bb-0310-9956-ffa450edef68
2017-01-04 07:00:24 +00:00
Andreas Beeker
28076295e3 relax timeout on performance test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777254 13f79535-47bb-0310-9956-ffa450edef68
2017-01-04 01:24:19 +00:00
Andreas Beeker
8973c2fe07 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777252 13f79535-47bb-0310-9956-ffa450edef68
2017-01-04 01:06:30 +00:00
David North
e402698484 Fix poor XPath performance when importing XSSF from XML
https://bz.apache.org/bugzilla/show_bug.cgi?id=60498

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777146 13f79535-47bb-0310-9956-ffa450edef68
2017-01-03 15:41:41 +00:00
Javen O'Neal
9a32a42130 bug 60484: avoid NPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777063 13f79535-47bb-0310-9956-ffa450edef68
2017-01-03 04:35:54 +00:00
Javen O'Neal
9eb965304c use Collections.singletonList and Collections.emptyList where appropriate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777056 13f79535-47bb-0310-9956-ffa450edef68
2017-01-03 03:52:58 +00:00
Javen O'Neal
b8e9fcef73 refactor duplicated code in TestXSSFSheet#setColumnGroupCollapsed; remove unnecessary int to short casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777052 13f79535-47bb-0310-9956-ffa450edef68
2017-01-03 02:14:29 +00:00
Andreas Beeker
97ea611e6e SonarQube fixes
add Iterable interface to EscherContainerRecord / deprecate getChildIterator()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777046 13f79535-47bb-0310-9956-ffa450edef68
2017-01-03 01:02:33 +00:00
Javen O'Neal
f458a9ac41 convert TestColumnHelper from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777038 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 23:23:16 +00:00
Javen O'Neal
18fd1b522d assertEquals(false, ...) -> assertFalse(...)
assertEquals(true, ...) -> assertTrue(...)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777037 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 23:14:53 +00:00
Javen O'Neal
ca0154a793 use case-insensitive string startsWith/endsWith utility function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777031 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 22:23:56 +00:00
Andreas Beeker
b919ad9989 Sonarqube fixes
- replace RuntimeException with application specific runtime exception
- clean-up sources - add braces to if statements and add override annotations
- fix a few hslf blockers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776896 13f79535-47bb-0310-9956-ffa450edef68
2017-01-02 00:55:49 +00:00
Andreas Beeker
f2052fe278 Sonarqube fixes - Cast one of the operands of this multiplication operation to a ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 22:59:35 +00:00
Javen O'Neal
4ed96136ec md5hash should not fail silently
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776828 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 06:58:01 +00:00
Javen O'Neal
11c8858f6e use last file extension if multiple extensions; close opened stream; extract String constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776827 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 06:57:42 +00:00
Andreas Beeker
a4a0c1e91a fix content-type handling in *SSF-EmbeddedExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776823 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 00:56:51 +00:00
Andreas Beeker
254b42ff26 #60521 - Enable nested XSSF GroupShapes and fix calculation of Client-/ChildAnchor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776820 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:54:32 +00:00
Andreas Beeker
1d9c74b1bf #60519 - Extractor for *SSF embeddings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776819 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:50:47 +00:00
Andreas Beeker
db4bdaf29a #60520 - Provide *SSF functionality via Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776818 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:47:23 +00:00
Andreas Beeker
820c8f8fd3 fix forbidden-apis-check error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776817 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 21:37:14 +00:00
Dominik Stadler
8f1eed63cc Fix missing license-headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776806 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 17:55:52 +00:00
Dominik Stadler
13e4ff4553 Cover some dev-tools with a few simple tests, close resources correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776798 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:33 +00:00
Dominik Stadler
102c0d2173 Bug 60219: FormulaParser can't parse external references when sheet name is quoted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:16 +00:00
Dominik Stadler
b2a4c75665 Fix some Findbugs reports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776714 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 09:43:08 +00:00
Dominik Stadler
36406ad3a1 Ensure streams are closed always, reformat code somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:12:06 +00:00
Dominik Stadler
6f616d0a51 Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:55 +00:00
Dominik Stadler
da2b7c0969 Fix some compilation warnings
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:48 +00:00
Dominik Stadler
4d83cc8ac2 Fix an api-violations introduced in a test-case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776633 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 20:35:08 +00:00
Dominik Stadler
800866450b Add test provided via bug 60536 for bug 60526, remove some warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776622 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 18:54:47 +00:00
Dominik Stadler
12e2fa39fa Bug 60512: Add missing XSSFRelation.CUSTOM_PROPERTY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776606 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 16:55:19 +00:00
Dominik Stadler
8def7307d9 Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input
deprecate unused method isNonWorkday

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 15:05:14 +00:00
Dominik Stadler
b573615cd0 bug 60526: Make loggers final and make throttled log actually work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776555 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 13:09:28 +00:00
centic
25b22afebf Add some throttling to the log for failed SAXHelper features to not spam the log on JDK 9 with restricted reflection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776067 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:42 +00:00
centic
a150527574 Add mising @Override and other warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776065 13f79535-47bb-0310-9956-ffa450edef68
2016-12-26 19:51:32 +00:00
kiwiwings
b4728919b9 report size of entries for POIFSViewer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775992 13f79535-47bb-0310-9956-ffa450edef68
2016-12-25 00:06:13 +00:00
kiwiwings
3ff9eb5f0d Fix 0-pointer on unset document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775565 13f79535-47bb-0310-9956-ffa450edef68
2016-12-21 22:03:54 +00:00
centic
c44cf6ab38 Sonar issues: Mark two places where we catch Error/Throwable as "On purpose"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775122 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 15:25:20 +00:00
centic
9a04e2dd07 Comments, Javadoc and make close() only log instead of throw an exception to not have catch inside catch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1775118 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 15:03:58 +00:00
kiwiwings
503a63c0d4 fix eclipse warnings - close resources
add getter for HSLF slideshows implementation class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774974 13f79535-47bb-0310-9956-ffa450edef68
2016-12-19 01:34:24 +00:00
kiwiwings
c200faedec SonarQube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774969 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 22:03:31 +00:00
kiwiwings
4f94969a41 sonarqube fixes - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774845 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:47:08 +00:00
kiwiwings
0ff9cbb0f9 #60331 - Remove deprecated classes (POI 3.16)
- remove orphaned classes immediately, which are quite likely not used anymore
- deprecated the rest

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774842 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 03:26:13 +00:00
Andreas Beeker
f3674c3394 various sonarqube fixes - mainly resource closing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774705 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 02:35:30 +00:00
Tim Allison
8b5f8483f4 bug 60489 -- add a file that triggered a ClassNotFoundException on TIKA-2208/elasticsearch-22077
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774638 13f79535-47bb-0310-9956-ffa450edef68
2016-12-16 16:46:00 +00:00
Mark Murphy
94a81f7e68 SonarCube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774557 13f79535-47bb-0310-9956-ffa450edef68
2016-12-16 06:00:35 +00:00
Mark Murphy
3ab0097cdc Findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774556 13f79535-47bb-0310-9956-ffa450edef68
2016-12-16 05:17:38 +00:00
Mark Murphy
f4d208f452 60465: Cannot specify interline spacing for a Paragraph in XWPF
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=60465

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1774551 13f79535-47bb-0310-9956-ffa450edef68
2016-12-16 03:21:02 +00:00
Andreas Beeker
4cc6e093f4 eclipse warnings - close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773910 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:36:03 +00:00
Andreas Beeker
4aaef1761d eclipse warnings - raw list access
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773909 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:34:30 +00:00
Andreas Beeker
cbbf3f44db SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773908 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:33:50 +00:00
Andreas Beeker
269dd9e0af SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773907 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:33:08 +00:00
Andreas Beeker
6a8332a173 eclipse warnings - raw list access
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773906 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:31:23 +00:00
Andreas Beeker
128001186b eclipse warnings - raw list access
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773905 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:30:24 +00:00
Andreas Beeker
fae46faf29 remove unused class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773904 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:29:03 +00:00
Dominik Stadler
230453d76e Adjust toString() of ExternalNameRecord
Fix some IntelliJ warnings
 Reformat TextPieceTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773776 13f79535-47bb-0310-9956-ffa450edef68
2016-12-12 11:41:07 +00:00
Mark Murphy
701b19cf21 58237: Unable to add image to a word document header using XWPF
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=58237

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773729 13f79535-47bb-0310-9956-ffa450edef68
2016-12-12 02:43:45 +00:00
Dominik Stadler
52f34a4cbd Revert "Add script to run ant locally with Java 1.6/Ant 1.8.x"
This reverts commit ed848f2d5f02ea0b6645bc509e03c1e0c7135d96.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773714 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:17:18 +00:00
Dominik Stadler
46e4a58986 Revert "Print out amount of available memory during startup of OOXMLLite"
This reverts commit b9b9c2e7c661bb89a2063326ca0903059214bc2b.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773691 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:15:47 +00:00
Dominik Stadler
17311852ce Revert "Local test to run one of the multi-file tests on only one file"
This reverts commit 6582ca62b000143b96823509ad7bb8d444cabee3.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773689 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:15:37 +00:00
Dominik Stadler
d4ae4b9cc6 Revert "Add more output to BiffViewer for local debugging"
This reverts commit b6959b0d14b001ec374f60990671ff21bbcc24ec.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773685 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:15:20 +00:00
Dominik Stadler
5cf4143fcc Revert "Adjust local test class run with Gradle-Build as well"
This reverts commit 76be95541fa6ac22bf0746d864404a84868ab1c6.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773663 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:13:51 +00:00
Dominik Stadler
2f0fc06f0f Adjust some missing/incorrec throws and related javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773662 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:13:46 +00:00
Dominik Stadler
8003ad78f4 Adjust local test class run with Gradle-Build as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773661 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:00:00 +00:00
Dominik Stadler
b2b021bc32 Add more output to BiffViewer for local debugging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773639 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:58:30 +00:00
Dominik Stadler
54778bfac6 Local test to run one of the multi-file tests on only one file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773635 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:58:12 +00:00
Dominik Stadler
261912044a Print out amount of available memory during startup of OOXMLLite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773633 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:58:03 +00:00
Dominik Stadler
f86223074e Add script to run ant locally with Java 1.6/Ant 1.8.x
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773610 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:56:28 +00:00
Dominik Stadler
2e364ee85d Exclude new BIFF5 file in some unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773605 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:56:03 +00:00
Andreas Beeker
6a8cb7493c reindent code - prepare for cleanups
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773544 13f79535-47bb-0310-9956-ffa450edef68
2016-12-10 23:35:12 +00:00
Andreas Beeker
f27507244c SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773495 13f79535-47bb-0310-9956-ffa450edef68
2016-12-10 00:40:37 +00:00
Andreas Beeker
470119db95 SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773315 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 00:39:49 +00:00
Andreas Beeker
3cdf699add SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773165 13f79535-47bb-0310-9956-ffa450edef68
2016-12-07 23:45:38 +00:00
Nick Burch
30d64fda8c Recursive delete unit test based on users@ query - working fine already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772894 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 13:52:46 +00:00
Andreas Beeker
83ff0e5ec4 Add "*" option to font_map/fallback to provide a catch-all configuration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772816 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 00:21:22 +00:00
Andreas Beeker
75dc015766 SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772585 13f79535-47bb-0310-9956-ffa450edef68
2016-12-04 23:49:49 +00:00
Andreas Beeker
dcd8a53c64 regression #55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772485 13f79535-47bb-0310-9956-ffa450edef68
2016-12-03 20:32:08 +00:00
Andreas Beeker
21009c9abe #60331 - Remove deprecated classes - remove constructors with PackageRelationship argument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772424 13f79535-47bb-0310-9956-ffa450edef68
2016-12-03 00:49:08 +00:00
Andreas Beeker
656f28ba81 SonarCube fix - make members private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772291 13f79535-47bb-0310-9956-ffa450edef68
2016-12-01 23:46:27 +00:00
Dominik Stadler
45228f9801 Move test to correct package and add some more checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772148 13f79535-47bb-0310-9956-ffa450edef68
2016-12-01 07:12:34 +00:00
Mark Murphy
07893ec6a0 60329: Avoid NPE when styleid is null
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=60329

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772138 13f79535-47bb-0310-9956-ffa450edef68
2016-12-01 02:21:56 +00:00
Andreas Beeker
48ff8e5686 sonarcube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771978 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 23:14:43 +00:00
Andreas Beeker
d9ef0efcdd #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images
more cases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771974 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 22:41:26 +00:00
Andreas Beeker
cc40df42ad forbidden apis fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771850 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 08:15:49 +00:00
Andreas Beeker
11986a0492 #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images
more cases

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771832 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 00:46:39 +00:00
Andreas Beeker
891e684eb7 #60427 - Creating pictures in PowerPoint slides requires scratchpad-jar for adding WMF images
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771812 13f79535-47bb-0310-9956-ffa450edef68
2016-11-28 20:51:02 +00:00
Andreas Beeker
19842d1e58 javadocs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771672 13f79535-47bb-0310-9956-ffa450edef68
2016-11-28 01:18:48 +00:00
Andreas Beeker
6ea58e94bc #60331 - Remove deprecated classes - deprecate Mutable* property classes
sonarcube fix - make protected attributes private

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 20:19:18 +00:00
Andreas Beeker
8968b6d6b6 SonarCube fixes - visibility of member attributes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771583 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 13:12:00 +00:00
Dominik Stadler
aba5d21295 Fix newly introduced Sonar issues and allow text to be null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771563 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 11:06:57 +00:00
Dominik Stadler
be1aa45b25 Bug 60370: Encode some special characters when setting title/text for validation text-boxes, for now all characters below 32, more can be added if necessary.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771396 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:59 +00:00
Dominik Stadler
055630de2d Revert deprecating a class that we still use ourselves and update error text slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771395 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:52 +00:00
Dominik Stadler
ed975b0efa Include actual entries when we do not find a Document-entry
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771394 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:45 +00:00
Dominik Stadler
e2b22e51f7 Bug 59200: Check for actual Excel limits on data validation title/text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 08:55:52 +00:00
Dominik Stadler
90ce8cb096 Remove unnecessary cast and reformat some code a bit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771247 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 05:34:58 +00:00
Javen O'Neal
52dcd75c66 bug 60416: prefer CellReference ref over String ref
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771232 13f79535-47bb-0310-9956-ffa450edef68
2016-11-24 21:25:43 +00:00
Javen O'Neal
d2f6e5c24e bug 60416: Reduce Hyperlink memory consumption in SXSSF; patch from Dmitry Katsubo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771231 13f79535-47bb-0310-9956-ffa450edef68
2016-11-24 21:14:35 +00:00