moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,064 Commits 29 Branches 84 Tags 722 MiB
3f91e44380
Commit Graph

6686 Commits

Author SHA1 Message Date
Nick Burch
0fe7cd5299 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 00:17:33 +00:00
Mark Murphy
504a26b844 Add new class Cell Style Template and supporting enum for drawing borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 23:59:02 +00:00
Dominik Stadler
b23e85c852 Add coverage of function WEEKDAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754689 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 21:24:13 +00:00
Dominik Stadler
98401573ed Test a few more cases of function INDIRECT() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754675 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 17:19:33 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 17:19:27 +00:00
Dominik Stadler
5e0612eabd IDE warnings and fix a few places where we do not close resources in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 17:19:17 +00:00
Nick Burch
dfcf57bfbf Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-29 14:03:28 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods. 
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-29 13:24:00 +00:00
Dominik Stadler
fa24949520 Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-27 18:15:54 +00:00
Nick Burch
2beb904e86 HWPFDocument.write(File) support and tests #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754108 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-26 10:58:08 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-24 11:38:50 +00:00
Nick Burch
5a1ff54cf3 In-place write for HSLF #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753741 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 23:25:02 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 10:27:27 +00:00
Javen O'Neal
327a4aa091 test Cell.setCellValue(false) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 02:17:37 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:31:57 +00:00
Nick Burch
af36e63bff #57919 HSLF writing to new File 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753622 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:20:02 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:09:33 +00:00
Nick Burch
b15c2b1c53 Whitespace / indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753620 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:39:12 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:35:51 +00:00
Nick Burch
1ccced289d Mark some more scratchpad document types as currently being read-only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753618 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:18:25 +00:00
Nick Burch
9830fd3dca Helper class for implementing extra write methods (#57919) for Scratchpad classes which are read-only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753617 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:13:03 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:14:05 +00:00
Nick Burch
d84df31b50 #57919 Start on support for writing to a new File (faster than OutputStream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:07:29 +00:00
Javen O'Neal
93a53a1da3 add test case for bug 53564 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-19 10:08:50 +00:00
Javen O'Neal
50d1788d3d bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-19 08:02:41 +00:00
Javen O'Neal
ebbcd10034 bug 59881: fix spelling; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 18:25:28 +00:00
Dominik Stadler
abc3072df2 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30 Some warnings/improvements suggested by IntelliJ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 09:34:59 +00:00
Dominik Stadler
0bf845e0cc 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:27 +00:00
Dominik Stadler
29b21a82f7 Adjust unused local variables to also make FindBugs happy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753124 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:19 +00:00
Dominik Stadler
da9cd94e76 Fix one more place where stream were left open when an exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:12 +00:00
Dominik Stadler
da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ... 
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:07 +00:00
Dominik Stadler
412ae950c2 Enable reproducer test for bug 56880 after it was fixed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753121 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:17:51 +00:00
Dominik Stadler
a118ec77d4 Add commented reproducer for bug 57603 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753120 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:17:45 +00:00
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:33:32 +00:00
Javen O'Neal
056a8dac84 reduce statement complexity in drawContent, also has fewer FLOPS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:29:34 +00:00
Javen O'Neal
ec4a47df73 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:27:57 +00:00
Javen O'Neal
9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:25:37 +00:00
Javen O'Neal
bdf3f30418 make instance variables final where possible 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753111 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:24:14 +00:00
Nick Burch
cf6d3489e0 #57919 Provide an initial in-place write method for HSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 19:02:58 +00:00
Javen O'Neal
d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow 
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 13:25:02 +00:00
Javen O'Neal
28622a6da5 bug 59170: remove deprecated TableSprmUncompressor#uncompressTAP(byte[] grpprl, int offset) method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753070 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 13:12:27 +00:00
Javen O'Neal
1d80673383 bug 59170: fix compile error from r1753052 when removing deprecated TAP_TYPE constant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753069 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 13:11:18 +00:00
Javen O'Neal
b2b1a030a3 bug 58190: add unit tests for XMLSlideShow#addPicture and XMLSlideShow#findPicture 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753065 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 12:16:58 +00:00
Javen O'Neal
bc91641444 bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 11:56:13 +00:00
Javen O'Neal
9133eaa147 bug 59264,59833,59837: upgrade deprecated methods in examples and testcases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753061 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 11:45:40 +00:00
Javen O'Neal
a478687281 bug 59264,59833,59837: upgrade deprecated methods in examples and testcases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 11:43:50 +00:00
Javen O'Neal
2daa8a93ee close workbook to avoid resource leak 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753053 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:27:44 +00:00
Javen O'Neal
38b29717ec bug 59170: remove deprecated constants, make private variables final, whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753052 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:27:18 +00:00
Javen O'Neal
b3300cf4be HexDump.writeHex is similar to Long#toHexString. Consider consolidating. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:22:43 +00:00
Javen O'Neal
3d18f17d04 log on unsupported Sprm operation, save operand to variable to reduce duplicated code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753048 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:10:21 +00:00
Javen O'Neal
8ee9106f18 whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753047 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:08:06 +00:00
Javen O'Neal
7c4a4270a0 HWPF SectionProperties implements Cloneable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753046 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:07:06 +00:00
Javen O'Neal
3a50581584 bug 58802: javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753044 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:52:04 +00:00
Javen O'Neal
7637cdc080 bug 59873: javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:48:36 +00:00
Javen O'Neal
4d33ceffb1 bug 59873: javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:44:26 +00:00
Javen O'Neal
2944b7a7a8 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:42:13 +00:00
Javen O'Neal
31f2b5fdd1 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:32:29 +00:00
Dominik Stadler
146839d0ce Bug 58802: HWPF: Allow reading of footnote and endnote properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753039 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:27:17 +00:00
Dominik Stadler
16b0c380c9 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:27:07 +00:00
Javen O'Neal
c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:20:21 +00:00
Javen O'Neal
0ac8c90896 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753032 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 08:45:55 +00:00
Javen O'Neal
f92542e22e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753031 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 08:45:00 +00:00
Javen O'Neal
0025b16e3e add cause to exceptions, log exceptions that are caught and suppressed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 08:41:52 +00:00
Javen O'Neal
1cf76af9e8 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 08:26:51 +00:00
Javen O'Neal
e0c50807c4 javadocs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753020 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:48:48 +00:00
Javen O'Neal
efbfef84a6 make private maps final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:29:40 +00:00
Javen O'Neal
f296b55b36 add @Override annotations to CreationHelper classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:14:49 +00:00
Javen O'Neal
4a8e7c393d throw exception if hyperlink is invalid type when validating hyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 06:04:56 +00:00
Javen O'Neal
14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 05:47:03 +00:00
Javen O'Neal
285bedac9e bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 05:43:03 +00:00
Javen O'Neal
4ba3ed06fc bug 59775: fix cell address index error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 04:59:12 +00:00
Javen O'Neal
44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 04:41:20 +00:00
Andreas Beeker
c00187f5e0 use real TempFile 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753004 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 00:27:52 +00:00
Andreas Beeker
11fe2eda86 #59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 00:14:06 +00:00
Dominik Stadler
af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-16 20:52:39 +00:00
Dominik Stadler
d0e3102fd1 Bug 59733: Narrow down testcase some more, after the first shift, removing the first row is sufficient to trigger the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752996 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-16 20:52:28 +00:00
Dominik Stadler
52bf709104 Add a test to check for a NullPointerException in XSLFTableCell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 18:24:11 +00:00
Dominik Stadler
ae7ef11c88 Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 18:24:02 +00:00
Javen O'Neal
9d8b7b33db JDK8 javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 10:13:58 +00:00
Javen O'Neal
064abfa59a replace for-loop over index with for-each loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:41:26 +00:00
Javen O'Neal
6ea74f170d annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:25:16 +00:00
Javen O'Neal
0c3aade7b1 JDK8 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:35:21 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s) 
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5 bug 59858: describe why VBA macro reading failed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:12:37 +00:00
Javen O'Neal
bb8f614a90 bug 59858: add disabled unit test for bug 59858; file from Brooke 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 05:28:29 +00:00
David North
a7d210932a "cannot not" presumably means "cannot" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-13 16:40:47 +00:00
Dominik Stadler
7beffbe3e3 Fix name of new OLE2ScratchpadExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-12 15:40:18 +00:00
Nick Burch
439fc2e92d Remove un-used imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 23:00:40 +00:00
Nick Burch
90e8b0f5b0 Last bit of reflection - get back to the full OOXML-enabled factory if we can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:57:42 +00:00
Nick Burch
4643b2ade0 Exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:53:22 +00:00
Nick Burch
7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:47:02 +00:00
Nick Burch
a5fb04f45f Pull Scratchpad Extractor logic to own class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:27:02 +00:00
Nick Burch
ed7940dee5 Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:20:51 +00:00
Nick Burch
f94e7e761b Notes on use 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:17:34 +00:00
Javen O'Neal
c541e0a16f add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 11:37:22 +00:00
Javen O'Neal
2ec6b12e13 bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 11:18:55 +00:00
Javen O'Neal
0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 08:29:02 +00:00
Javen O'Neal
847d90603a javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:54:36 +00:00
Javen O'Neal
79fac1f707 bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:52:16 +00:00
Javen O'Neal
ba1e2c8b14 Add comments describing Outlook .msg DirectoryNode names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 01:41:15 +00:00
Javen O'Neal
fbf2d524f9 move string literals out to array that can be for-looped over 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 01:29:30 +00:00
Andreas Beeker
cd349946a0 javadocs fixes (jdk8) 
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 18:52:26 +00:00
Javen O'Neal
44f0a6a66a add 2^x to POWER2 comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:54:07 +00:00
Javen O'Neal
e563dee47c bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:51:57 +00:00
Javen O'Neal
d8c65c777e bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:18:29 +00:00
Javen O'Neal
76dde0aed5 bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:05:43 +00:00
Javen O'Neal
518253650a remove Internal UnhandledDataStructure.copyOfRange because function is available in JDK 1.6+ and we no longer support JDK 1.5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751984 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 06:38:16 +00:00
Javen O'Neal
ca22a79e01 close streams if an exception is throw 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 06:30:12 +00:00
Javen O'Neal
909c07f37f bug 59830: add context to why no more bytes could be read from input stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 05:39:56 +00:00
Javen O'Neal
a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 22:28:28 +00:00
Javen O'Neal
3092c1121e bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 18:45:15 +00:00
Javen O'Neal
9c00c18f38 bug 56154: rename setLastModifiedBy to setLastModifiedByUser 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 18:05:02 +00:00
Javen O'Neal
ed4ae3fff0 bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 17:59:01 +00:00
Javen O'Neal
182c1415f5 bug 56154: get and set last modified by user property; patch from Danil Lopatin 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 17:56:54 +00:00
Javen O'Neal
d3eae0ccd8 convert OPC Compliance unit tests to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751891 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 12:07:20 +00:00
Javen O'Neal
6cbca80d5d whitespace and +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751890 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 11:55:21 +00:00
Javen O'Neal
99837b5014 AllOpenXML4JInternalTests no longer needed in AllOpenXML4JTests suite because it was upgraded to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751889 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 11:53:28 +00:00
Javen O'Neal
92c2fa753d add crude unit test for ZipPackagePropertiesMarshaller 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 09:10:03 +00:00
Javen O'Neal
7d427f0d16 convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751870 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 08:53:34 +00:00
Javen O'Neal
891b45e186 whitespace and +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751867 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 08:38:28 +00:00
Javen O'Neal
4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:20:34 +00:00
Javen O'Neal
bb7da64c25 add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:00:07 +00:00
Javen O'Neal
dd32e6b5b5 add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:46:06 +00:00
Javen O'Neal
85def647c9 whitespace (3sp to 4sp) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751839 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:38:09 +00:00
Javen O'Neal
2e142f4d6a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751838 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:29:28 +00:00
Javen O'Neal
38c052cca1 add @Override annotations to spreadsheet formula Evaluation classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:27:32 +00:00
Javen O'Neal
9539c626a9 bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:22:10 +00:00
Javen O'Neal
6f566fca27 whitespace; +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751744 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 02:27:13 +00:00
Javen O'Neal
81f13bb621 Findbugs-JDK8: log ignored exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751743 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 02:25:42 +00:00
Javen O'Neal
56d11479de bug 50795: move hack to avoid xmlbeans corrupt pointer to its own function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751742 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 02:19:02 +00:00
Javen O'Neal
140b11bc7a bug 59805: tearDown should reset, not set, the LocaleUtil ThreadLocals (also avoid memory leaks) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751741 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 02:09:25 +00:00
Javen O'Neal
b45a65e667 bug 59805: avoid memory leaks if time zone or locale are never set or user never resets the time zone or locale; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 01:10:24 +00:00
Javen O'Neal
5cbd7552eb findbugs: replace switch statement with fall-throughs with if statement, remove duplicate code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751738 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 00:48:52 +00:00
Javen O'Neal
66cf2b5b09 add comment about a bug found by findbugs-jdk8. Someone more familiar with HSLF should resolve this. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751737 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 00:12:04 +00:00
Javen O'Neal
1766825f62 bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 09:23:34 +00:00
Javen O'Neal
83e27bd10c bug 59805: add unit test for LocaleUtil#getLocaleCalendar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751629 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 08:52:40 +00:00
Javen O'Neal
076b9b600d bug 59805: add unit test for LocaleUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751620 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 08:12:08 +00:00
Javen O'Neal
0390a566a5 bug 59805: make LocaleUtil a static class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751601 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 05:40:53 +00:00
Javen O'Neal
78801432ed bug 59804: javadoc update 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751574 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:33:31 +00:00
Javen O'Neal
b37fde6d96 +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:26:32 +00:00
Javen O'Neal
93f1f4b027 bug 59804: indicate when features were @Internal-ized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:22:49 +00:00
Javen O'Neal
f78b266d73 bug 59804: add since attribute to @Internal annotation; add @Removal annotation to track when features will be removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751569 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:01:05 +00:00
Andreas Beeker
05cecde4a5 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751568 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 22:57:50 +00:00
Dominik Stadler
6784574ea2 Add a unit-test to verify that DataFormatter.formatCellValue() does format formula-results correctly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751400 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 07:24:14 +00:00
Andreas Beeker
3ef17caad7 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751387 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 23:45:19 +00:00
Nick Burch
e4d673ddc3 When dumping a HMEF body that is a string not RTF, use a predictable encoding rather than whatever the property happened to have in the original file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751386 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 22:47:17 +00:00
Nick Burch
28c437531e Fix HMEFMessage to allow fetching attributes by custom MAPI Properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751385 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 22:41:46 +00:00
Nick Burch
90e4babfc1 #59780 OPC support for a wider range of timezone'd created and modified date formats in package properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751379 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 20:55:07 +00:00
Nick Burch
307fdc61b0 Add ignored test for #59780, and specially-crafted test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751375 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 20:26:40 +00:00
Javen O'Neal
24faa602e0 bug 59796: XSSFTable#getRowCount off-by-one error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751373 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 19:09:10 +00:00
Javen O'Neal
18f2e5e405 typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751372 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 19:00:35 +00:00
Javen O'Neal
45f209e58c mark BitField as internal use only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751371 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:50:26 +00:00
Javen O'Neal
f0f37b58ed pre for-each iteration over for index iteration 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751369 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:43:45 +00:00
Javen O'Neal
31efeb44b7 bug 59795: add method to synchronize start and stop cell references with CTTable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751368 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:25:00 +00:00
Nick Burch
4a438b1bbd Try (as best as possible with no test file) to extract uncompressed HMEF test when that is there instead of Compressed RTF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751361 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:06:14 +00:00
Javen O'Neal
eb6488585a bug 59790,59791: add @since javadoc annotation to FormulaType and CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751287 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:49:44 +00:00
Javen O'Neal
be49e0c5a7 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:09:30 +00:00
Javen O'Neal
03671fea80 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:35:49 +00:00
Javen O'Neal
268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:21:42 +00:00
Javen O'Neal
034d3cfcca bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 11:54:20 +00:00
Javen O'Neal
fba65665fb reorganize imports (remove unused imports, sort alphabetically) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 10:38:25 +00:00
Javen O'Neal
64ef8e26a3 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.* 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 10:15:18 +00:00
Javen O'Neal
d1d6ea97fb bug 59791: convert Cell Type to an enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 09:45:46 +00:00
Javen O'Neal
8df4c77647 bug 59790: convert FormulaType class to enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 05:37:06 +00:00
Javen O'Neal
6605ff96ab javadocs fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751209 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 05:00:55 +00:00
Javen O'Neal
d358c2a0ab bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 03:06:11 +00:00
Javen O'Neal
9208fc384e rearrange JavaDocs to match constructor ordering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751197 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 02:58:38 +00:00
Javen O'Neal
909b428443 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751195 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 02:14:02 +00:00
Javen O'Neal
954306ea2e bug 59773: replace for loops with for-each loops; javadocs fixes for JDK8 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751193 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:49:28 +00:00
Javen O'Neal
8329fc22f5 add missing ASL license header from bug 59788 comment 2 r1751185 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751192 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:28:19 +00:00
Javen O'Neal
f972e1c6e4 bug 59166: suggest alternative implementations for TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 01:07:52 +00:00
Javen O'Neal
569db169dd bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 00:00:20 +00:00
Andreas Beeker
b56b2497d0 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751184 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:38:06 +00:00
Javen O'Neal
0dc4d4fbbf whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751183 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:33:36 +00:00
Javen O'Neal
b6fe670114 make class attributes final; return unmodifiable lists 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751182 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:23:54 +00:00
Javen O'Neal
57033b6a9e revert whitespace changes to ASF license; previous commit r1751180 contributed by sebb 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751181 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:17:11 +00:00
Javen O'Neal
9e315cd89d bug 59786: fix NPE from winmail.dat files if message body is null 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751180 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:13:37 +00:00
Javen O'Neal
227ae30154 whitespace (3 spaces and tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751179 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 23:05:52 +00:00
Javen O'Neal
c54deaf3ff uncomment ignored unit tests so they at least compile 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:59:41 +00:00
Javen O'Neal
0e118a7b6d bug 59788: create temporary directories 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:58:06 +00:00
Andreas Beeker
1781e9d83f deprecated DrawingManager 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 22:21:55 +00:00
Andreas Beeker
8e84226202 #59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 21:54:17 +00:00
Javen O'Neal
ac451c874d convert to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751172 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 20:04:43 +00:00
Andreas Beeker
6899a1ad95 javadocs fixes (jdk8) 
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 18:25:05 +00:00
Javen O'Neal
33cf815199 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-03 07:20:47 +00:00
Andreas Beeker
76c479ce28 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751106 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 23:08:07 +00:00
Javen O'Neal
73fcbfdb68 bug 59773: move loop invariants outside of loop or change for loops to for-each loops 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 18:28:43 +00:00
Javen O'Neal
e7eef4d75a bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751081 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 16:29:05 +00:00
Javen O'Neal
4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 09:00:13 +00:00
Javen O'Neal
b11ee3f7da don't shadow drawing field from XSSFShape in XSSFGraphicFrame 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751038 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:40:50 +00:00
Javen O'Neal
ac84cdb773 findbugs: remove implements Cloneable declaration from classes that don't implement a clone method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:30:34 +00:00
Javen O'Neal
1aa3511d0c findbugs: remove switch statement fall-through and move default switch to bottom 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751034 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 08:20:14 +00:00
Javen O'Neal
5af440d517 enable @Ignored unit test that is passing now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751024 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:12:19 +00:00
Javen O'Neal
4dd2ff6c7c findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751023 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:11:01 +00:00
Javen O'Neal
e7ef961359 +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751022 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 05:01:43 +00:00
Javen O'Neal
e31aa190a8 deprecate o.a.p.hssf.util.AreaReference as it shadows o.a.p.ss.util.AreaReference (findbugs) and provides no additional functionality 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751021 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:43:21 +00:00
Javen O'Neal
d7900beec3 findbugs: DocumentInputStream.skip(long) result not checked; close DocumentInputStream even if exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751020 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:39:53 +00:00
Javen O'Neal
6645d8a80f whitespace and +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751019 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-02 04:28:41 +00:00
Andreas Beeker
c985706686 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-01 21:10:40 +00:00
Javen O'Neal
b2f4150b06 bug 59776: don't swallow cause of exception in ZipPackagePropertiesMashaller exception handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750893 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-01 09:14:41 +00:00
Andreas Beeker
1b086d3a35 forbidden-apis-fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750868 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 23:03:17 +00:00
Andreas Beeker
6eab79528b a few performance fixes to speed-up the tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 22:59:46 +00:00
Nick Burch
0c9e0cb608 #59739 When testing for a valid NFIB in a FileInformationBlock, accept common "nearby" values as found from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750866 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 21:20:23 +00:00
Dominik Stadler
6b1caa4e2c Bug 59739: For now fix the regression in FileInformationBlock which was introduced after 3.15-beta1 so that the documents can be loaded again pending a full fix as discussed in the bug. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750864 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-30 21:06:04 +00:00
Nick Burch
520f4fbf76 #59766 Need to catch Errors as well when trying to tweak SAX stuff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750408 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-27 19:57:33 +00:00
Javen O'Neal
a0f9c1d707 bug 59748: replace remaining Hashtable usages in contrib/poi-ruby and hssf examples 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750182 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-25 05:22:05 +00:00
Javen O'Neal
6f0825c5b4 add @Override annotation for updateOtherRecordReferences on PositionDependentRecordAtom descendents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750181 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-25 05:10:22 +00:00
Andreas Beeker
099f63d054 deprecated constants pointing to MissingCellPolicy - use enum instead 
javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 23:31:12 +00:00
Andreas Beeker
85f22291be Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750171 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 22:04:12 +00:00
Javen O'Neal
fd1a23361b bug 59748: replace Hashtable with HashMap; contributed by Axel Howind 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 21:39:44 +00:00
Andreas Beeker
18c2ee3fdc sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750162 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 20:26:08 +00:00
Andreas Beeker
a3718f8166 common-crawl-regression-fix: fallback to higher template level for default font, in case the style reference can't be determined 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750034 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-24 00:12:25 +00:00
Andreas Beeker
5fce29e432 Fix for test-data of #59746 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750033 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 23:13:59 +00:00
Nick Burch
05f704d112 #59746 XSSF support for files from certain alternate tools where the row XML is missing the row number 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749971 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 18:59:48 +00:00
Nick Burch
4abd9f6cca Disabled unit test for bug #59746, test file from Rob Owen 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749963 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 18:44:34 +00:00
Andreas Beeker
0341823c5c #59743 - ZipSecureFile throwing "zip bomb detected" exception when writing SXSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749799 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-23 00:23:51 +00:00
Andreas Beeker
c0fd2ae00b Ignore Tiff files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749797 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:51:14 +00:00
Andreas Beeker
89fb94e67d sonar fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749795 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:27:53 +00:00
Andreas Beeker
c88ba795a0 javadoc fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749794 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 22:26:08 +00:00
Nick Burch
bfa702ed88 XSLFPictureData support for TIFF images - patch and tests from bug #59742 from Jens Popp 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749732 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-22 16:18:36 +00:00
Nick Burch
4eb8175d88 Fix inconsistent whitespace and indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749530 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:34:12 +00:00
Nick Burch
631ca92c16 #59717 POIXMLProperties helper methods for reading and changing OOXML document thumbnails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749528 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:27:41 +00:00
Nick Burch
fdb7c7d1ff Provide an alternate method to get the OLE2 thumbnail that decodes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749526 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-21 14:26:28 +00:00
Javen O'Neal
0f3a7b24b4 bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 11:27:40 +00:00
Javen O'Neal
8cefedd80a remove an unnecessary row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749300 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:52:50 +00:00
Javen O'Neal
3bc1764c5c bug 59733: cells do not need to be created for the XmlValueDisconnectedException to occur 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749298 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:49:05 +00:00
Javen O'Neal
3f546d927f bug 59733: add disabled unit test from Dattathreya 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749295 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:41:22 +00:00
Javen O'Neal
d23e77fcf5 remove commented out @Ignore 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749294 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:32:21 +00:00
Javen O'Neal
b617f3ccec bug 56781: disallow names with symbols, except underscore, period, and backslash 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 10:27:52 +00:00
Javen O'Neal
4036202ebc add comments, adjust whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749276 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:50:36 +00:00
Javen O'Neal
f3bd334002 whitespace (tabs to spaces); +svnprop svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749274 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 08:15:56 +00:00
Javen O'Neal
3881a0db31 bug 57929: add disabled unit test, adapted from nova 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 07:15:09 +00:00
Javen O'Neal
4df03b8762 bug 57523: off by one error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749269 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 06:49:13 +00:00
Javen O'Neal
54d0ebe889 bug 57523: add unit test written by Dominik Stadler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749267 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 06:27:12 +00:00
Javen O'Neal
44d8e4a2cb bug 59719: add unit test and comments/javadocs from Greg Woolsey for XSSFDataVAlidationConstraint 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749265 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 05:01:21 +00:00
Javen O'Neal
7929adbf80 whitespace (tabs to 4 spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749264 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 04:21:26 +00:00
Javen O'Neal
40727700f4 bug 59731: start migrating methods relating to row-shifting in HSSFSheet to HSSFRowShifter; consolidate with XSSFRowShifter into RowShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749262 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 04:16:32 +00:00
Javen O'Neal
57e9abb8d1 parameterize raw generics 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 03:40:32 +00:00
Javen O'Neal
0ec8b3a88e bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749248 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 02:02:08 +00:00
Javen O'Neal
55cb9381de bug 56454: deprecate shiftMerged with unused parameter, move loop-invariant out of for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749247 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:49:46 +00:00
Javen O'Neal
2804197bdb bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:44:44 +00:00
Javen O'Neal
015cf4c86f object-oriented methods are preferred over utility classes for discoverability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749245 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 01:25:23 +00:00
Javen O'Neal
8dc7ee659d bug 59729: update CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749243 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:55:51 +00:00
Javen O'Neal
970626a88e whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749241 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:28:19 +00:00
Javen O'Neal
8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
 2016-06-20 00:25:29 +00:00