moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,650 Commits 29 Branches 84 Tags 722 MiB
268c5deeb2
Commit Graph

1834 Commits

Author SHA1 Message Date
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:19:50 +00:00
Andreas Beeker
3166646249 Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings 
commit single files because of svn failures ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701684 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-07 20:14:33 +00:00
Dominik Stadler
782739541a Bug 58315: Avoid NPE for RichTextString without font-details 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701382 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-05 12:57:04 +00:00
Dominik Stadler
b2bd6a0a4c Eclipse warnings, close resources in CommandLineTextExtractor, add try/finally, formatting, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701139 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:59:14 +00:00
Dominik Stadler
dab5f4c078 Fix bug 53275: reset indexed color flag when setting a non-indexed color 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701134 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:23 +00:00
Dominik Stadler
f7e0bdea37 Add unit test which verifies that bug 53105 is actually fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701133 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:14 +00:00
Dominik Stadler
4b8c20a7ca Add unit tests to verify that bug 51626 and bug 51451 are fixed 
Conflicts:
	src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701132 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:46:04 +00:00
Dominik Stadler
fcfe2e2a71 Add unit tests which verify that the issues from bug 48962 and 50755 do not occur any more on the latest version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701131 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-03 20:45:55 +00:00
Nick Burch
aa455c91fd Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 21:09:20 +00:00
Nick Burch
47fb9df1a1 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700644 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:06:53 +00:00
Nick Burch
533e1c8dcb Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 19:01:36 +00:00
Nick Burch
f098eca5a0 Fix some Forbidden APIs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700635 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-01 18:37:07 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-26 19:34:28 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions 
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-24 08:12:01 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-20 14:28:39 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:36:08 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened 
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-19 10:10:08 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-17 20:54:32 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-16 20:51:40 +00:00
Andreas Beeker
05c92b7a19 FindBugs - DLS_DEAD_LOCAL_STORE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-15 11:57:57 +00:00
Nick Burch
6be4fc05d2 Remove catches which were previously incorrectly declared when not needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695775 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:31:25 +00:00
Nick Burch
1a84b476e8 #58237 When adding a picture to a XWPF header or footer, attach it to the right part 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695772 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:23:58 +00:00
Nick Burch
cfbc261e65 #58237 Add some more XWPF header and footer tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695769 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 20:01:04 +00:00
Nick Burch
d9697de075 Fix inconsistent line endings and some eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695757 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 19:20:58 +00:00
Andreas Beeker
0e1aa75750 findbugs - DM_NUMBER_CTOR 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695635 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:38:04 +00:00
Andreas Beeker
3ac2d2905a findbugs - DM_BOXED_PRIMITIVE_... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695629 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-13 00:17:08 +00:00
Nick Burch
6d46fc382f #58220 - Improve the javadocs for XSSFFont and Font getFontHeight methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695528 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-12 14:14:12 +00:00
Nick Burch
ac8ed40f80 Fix some eclipse warnings, add TODOs for fields/hyperlinks XWPF add support, and give a more helpful exception if someone tries to remove a XWPFRun that is not a direct paragraph child 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695365 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:10:53 +00:00
Nick Burch
87a2acf935 Support XWPF field runs, the same way that we handle hyperlink runs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695361 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 20:01:26 +00:00
Dominik Stadler
ccc4ebcf70 Bug 56479: don't hardcode dcterms as namespace alias in the attribute, but expect the actual alias that is used in the corresponding element. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695212 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-11 05:37:15 +00:00
Andreas Beeker
750558d8d9 #56519 - XSLFSlide.draw is not working with text embeded in PPTX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694925 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 22:44:13 +00:00
Nick Burch
bdb00633a3 Complete theme colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694892 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 14:15:00 +00:00
Nick Burch
5b97e55997 Get theme and non-theme rows consistent in the test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694889 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:30:35 +00:00
Nick Burch
d2a95d0901 Begin Themes+Normal colour tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694887 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 13:06:40 +00:00
Nick Burch
3abeb347a6 Fix the themes test for the complex workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694883 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-09 12:36:57 +00:00
Andreas Beeker
d0e0f0cb97 #58205 - getSlideMasters() returns the master slides in the incorrect order 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694592 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-07 00:17:55 +00:00
David North
66fbc9d44e Example to go with refactor for https://bz.apache.org/bugzilla/show_bug.cgi?id=58219 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694536 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 16:37:09 +00:00
David North
9730ff9cd6 Proposed refactor for: 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694531 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-06 15:57:48 +00:00
Andreas Beeker
f28588fbb3 #57786 - XSLFFreeformShape ignores quadratic bezier curves 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694373 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 23:24:13 +00:00
Andreas Beeker
e5069da22a #58206 - provide a mechanism to find slide layouts by name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694340 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 22:46:42 +00:00
Andreas Beeker
91353085b5 #58204 - STYLE: ShapeContainer interface makes internal getShapesList() redundant 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694335 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-05 21:44:01 +00:00
Nick Burch
1f6594c244 Stub next test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694127 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:26:20 +00:00
Nick Burch
b2ab81ad81 Use an enum to simplify the themes code and tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694125 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 23:14:23 +00:00
Nick Burch
f78eac8c41 Pull out indexes from the switch statement to constants, and fix warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694121 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 22:46:27 +00:00
Andreas Beeker
1241a24ebb move setting of xmlinputfactory from junit to gump-meta/poi.xml 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694120 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 22:24:31 +00:00
Nick Burch
885368e2ce Further XSSF Themes unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694093 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-04 17:50:44 +00:00
Andreas Beeker
adfcf4d251 FindBugs fixes - MS_SHOULD_BE_FINAL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693984 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:36:28 +00:00
Andreas Beeker
0a42120b89 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693983 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:30:13 +00:00
Andreas Beeker
5a4575bb8c gump build fixing - move system properties tinkering into junit class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693978 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-03 23:09:10 +00:00
Andreas Beeker
77315b425f Trying to fix the wrong xmlinputfactory on gump run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693830 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-02 21:29:23 +00:00
Andreas Beeker
6b8af03c42 #58190 - The current picture handling uses raw integers for types and index, replace with enum and reference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693825 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-02 20:21:35 +00:00
Nick Burch
42bf5e5fc6 Use the same "is this a formula" logic for both getCellType and getCachedFormulaResultType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693767 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 21:34:34 +00:00
Andreas Beeker
98ed7bb5fb #58193 - Use input stream rather than byte array for checksum etc. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693754 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 20:09:37 +00:00
Nick Burch
fb731a62a5 Unit test for bug #57181 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693676 13f79535-47bb-0310-9956-ffa450edef68
 2015-08-01 00:25:20 +00:00
Nick Burch
098177f39e Re-enable some SXSSF skipped tests, but not all, for our limited evaluation support #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693663 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:16:53 +00:00
Nick Burch
0b6add86ac Start re-enabling some SXSSF formula evaluation tests, with required fixes #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693662 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:07:58 +00:00
Nick Burch
1761949b02 Refactor the core part of the XSSF Formula Evaluator, to make SXSSF overrides easier #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693661 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 22:04:16 +00:00
Nick Burch
4782319fd1 More helpful exception on the wrong cell type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693656 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 21:44:56 +00:00
Nick Burch
a11d4082ca Get basic SXSSF formula evaluation working, for cells/references in the window #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693654 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 21:31:53 +00:00
Nick Burch
5b22ad3be6 Push most of the common logic from XSSFEvaluationWorkbook into BaseXSSFEvaluationWorkbook, and start to use it for SXSSF as well #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693647 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:40:41 +00:00
Nick Burch
070ac341d2 Remove a long-deprecated constructor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693646 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:38:36 +00:00
Nick Burch
72909b1e6d Fix inconsistent indents/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693645 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:24:29 +00:00
Nick Burch
af9f83fd08 Prepare for SXSSF evaluation #58200 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693644 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 20:22:11 +00:00
Nick Burch
66d370a978 #58200 Prepare for evaluating SXSSF cell formulas in limited cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693641 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 19:19:33 +00:00
Nick Burch
fcbd93a768 Use more specific return types in SXSSF, which avoids casts, and also fix some long-standing TODOs on 1904 dates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693633 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 17:23:01 +00:00
Nick Burch
2ad973852c Have XSSF rich test strings report if they have formatting applied or not, and fix them to only add the formatting child element when needed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693632 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-31 17:22:05 +00:00
Andreas Beeker
b6b3853330 temporary activate jaxp debugging to find jaxb/stax error on gump build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692944 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-27 20:24:09 +00:00
Dominik Stadler
4728df5b6a Improve error message slightly, add tests to verify things failing in Gump-build currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692836 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-27 08:44:04 +00:00
Andreas Beeker
b2e18cf5ed Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692674 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-26 00:25:27 +00:00
Andreas Beeker
fe3b8e5eec Annotation for unimplemented drawing handlers. 
Ignore unsupported image types (e.g. wmf).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692640 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-25 19:24:51 +00:00
Andreas Beeker
5d267dd16d fixed NPE with Jaxb proxy classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692598 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-25 00:25:07 +00:00
Andreas Beeker
f5e9adea84 merged common_sl branch to trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692593 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-24 21:47:55 +00:00
Dominik Stadler
0a9a9e13f7 Bug 57571, Bug 58175: Fix creating comments for XSSF/SXSSF, regression was introduced via bug 54920 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692483 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-24 11:58:01 +00:00
Nick Burch
a6779a3c02 Allow creating of an empty Themes Table on request 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692211 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-22 00:04:59 +00:00
Nick Burch
8bb5d65cf8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1692210 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-21 23:57:44 +00:00
Dominik Stadler
ed7d892de7 Bug 58156: Possible data corruption in hasPOIFSHeader and hasOOXMLHeader 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691948 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 14:03:35 +00:00
Nick Burch
5e77d18b53 Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691871 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 04:56:05 +00:00
Nick Burch
b7d27d44ce #58130 CF DataBar example and tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691869 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 04:43:36 +00:00
Nick Burch
104d9ad8e3 #58130 CF DataBar support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691868 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 03:52:50 +00:00
Nick Burch
ac6aab29cf #58130 Begin CF DataBar support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691867 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 03:21:57 +00:00
Nick Burch
164aa4c7c6 #58130 Support for creating CF Color Scale Formattings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691866 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 02:49:12 +00:00
Nick Burch
eee0fb2835 Move some of the XSSF Color logic to a base class, so that the HSSF Extended Color wrapper can use it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691864 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-20 00:46:50 +00:00
Nick Burch
7261a10654 #58130 Enable CF ColorScale support on the rule, and begin testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691860 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 22:35:37 +00:00
Nick Burch
1f12ed1002 XSSF color scale CF objects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691859 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 22:22:09 +00:00
Andreas Beeker
58bf1455ec merge trunk to common sl branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691845 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 19:32:41 +00:00
Andreas Beeker
d439f080d6 merge trunk to common sl branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691843 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 19:00:32 +00:00
Dominik Stadler
8c1b7df4bc Bug 57484: Allow processing of non-OOXML core namespace packages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691821 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-19 12:11:19 +00:00
Nick Burch
6cfa6ee7e4 #58130 Mostly there with CF Icon sets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691679 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-18 04:55:27 +00:00
Nick Burch
4780ccf161 Start on XSSF CF Iconset for #58130 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691479 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 02:55:22 +00:00
Nick Burch
a22ab7249f XSSF CF thresholds 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691478 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 02:41:20 +00:00
Nick Burch
0cde71224d #58130 more progress towards supporting other CF types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691472 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-17 01:20:20 +00:00
Dominik Stadler
651f03cc64 * Make on unit test not fail if Fonts are not available on the machine 
* Refactor SheetUtil a bit to reduce code-duplication, adjust JavaDoc for -1 return values
* Add method to check if we can compute text-width
* Add unit-tests which verify some more of SheetUtil

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691341 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-16 09:06:47 +00:00
Andreas Beeker
d8bf3aae84 junit fixes 
set font size via Double
color handling via HSL calculation

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1691117 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-15 00:30:21 +00:00
Nick Burch
a6836c595f Start checking the CF colours in the unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691092 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:45:23 +00:00
Nick Burch
e0f6ff5ca1 #58138 CF Border colour getters and setters on Color objects as well as shorts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691083 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:19:13 +00:00
Nick Burch
8a62462905 Support unsetting the XSSF CF pattern colours 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691081 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 21:10:14 +00:00
Nick Burch
36c3b8d688 Cleaner code for checking and casting the Color objects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691064 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 19:29:18 +00:00
Nick Burch
2eb88db1b0 Provide format-agnostic conditional formatting patter colour getters and setters 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691047 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 18:32:35 +00:00
Nick Burch
777806d350 Provide format-agnostic conditional formatting font colour getter and setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691045 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 18:05:28 +00:00
Nick Burch
892d7fa4d0 Constant for the Office 2010 Conditional Formatting extensions namespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691015 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-14 16:12:40 +00:00
Nick Burch
4632e35c3d Move some test checks to using ConditionType instead of raw bytes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690808 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 20:11:47 +00:00
Nick Burch
fbf95cdb54 Enable CF2007 test for XLSX too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690805 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 19:56:09 +00:00
Nick Burch
9217c91425 Provide a Conditional Formatting type class, and deprecate the byte-based types, to better work with the wider range 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690803 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 19:47:21 +00:00
Nick Burch
fdd0d249ca CFRule12 tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690778 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 17:54:28 +00:00
David North
24612d3e82 Add Sheet.getMergedRegions to obtain them all as a list. Implement this for XSSF using "deprecated" methods in XMLBeans which allow the operation to be linear in the number of regions rather than n-squared. 
Fixes #57893

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690661 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 13:00:35 +00:00
Dominik Stadler
da56e012c3 Bug 58113: Fix regression: NullPointerException when setting cell value to null 
add unit tests which verifies this for all three SS-implementations

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690652 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 12:17:52 +00:00
David North
2f8aa558b3 Patch from Chris Boyle to add basic support for .xlsm (macro-enabled) workbooks. The binary blob containing the VBA macros may be copied from one such workbook into another. 
Fixes #58036

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1690593 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-13 09:05:17 +00:00
Andreas Beeker
65538c0f71 JUnit and rendering fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1690421 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-12 00:38:39 +00:00
Andreas Beeker
ee53e203c0 added ASL header to drawing classes 
fixed a few rendering NPEs
added dummy interfaces for table / connector shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1690185 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-09 22:46:29 +00:00
Dominik Stadler
0f24b7532c OOXMLPrettyPrint: Populate the standalone-attribute always to avoid differences in the resulting XML files from Excel and POI 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689794 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-08 05:57:32 +00:00
Andreas Beeker
6fe5b7bf51 downgraded xjc params to jdk6 and regenerated geometry binding classes 
added rendering for auto numbers
fixed various bugs on failing tests
changed xslf paragraph indent to indentLevel to align with hslf
added escher record factory subclass to hslf, to eventually make hslf wrapper classes obsolete

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1689777 13f79535-47bb-0310-9956-ffa450edef68
 2015-07-08 00:09:34 +00:00
Dominik Stadler
efc96e1d8e Open file read-only in test to avoid making it dirty during running unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688045 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-28 19:55:56 +00:00
Dominik Stadler
bde247f61a Fix test to find the exception-text in all cases 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687212 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 08:53:25 +00:00
Dominik Stadler
5103ea7c0c show full exception stack-trace if zip-bomb detection test fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687197 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 08:33:06 +00:00
Andreas Beeker
7393f122b2 Removed Java7 calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687176 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-24 07:06:01 +00:00
Andreas Beeker
c0cb680292 Bug 56865 - Limit number of bytes (by counting them) while opening office docs 
Bug 50090 - 'zip' bomb prevention

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1687148 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-23 23:39:07 +00:00
Dominik Stadler
e4f5df42f6 Bug 56655: Fix Sumifs for cases where the criteria is in error. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686610 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-20 13:10:28 +00:00
Dominik Stadler
cb5588c4a1 Bug 56420: Fix possible NullPointerException when empty cell is included in Sumif calculation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686564 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-20 11:29:14 +00:00
Andreas Beeker
f97d6f6c34 Rendering fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1686117 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 22:21:13 +00:00
Dominik Stadler
13eb52f12f Move more tests into base class and add a TestSXSSFBugs class to verify some things that are supported against SXSSFWorkbook as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686035 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 14:53:38 +00:00
Dominik Stadler
e7d33e4ccb Make setLandscape(false) and setLeftToRight(false) do what one would expect 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686019 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-17 14:26:31 +00:00
Dominik Stadler
f77cdd40b4 add missing license header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685506 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-15 08:17:08 +00:00
Andreas Beeker
2170a52383 Rendering of rotated group shapes fixed, other smaller fixes, defaulting to white transparent slide background 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1685344 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-13 23:26:46 +00:00
David North
16a9eca7c8 My own patch to fix #56328 
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-12 15:20:10 +00:00
Andreas Beeker
4acc6a84a1 Fixed TextRun handling and various junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1684773 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-10 22:23:47 +00:00
David North
c580758b2c Use a different arbitrary value for the ID of the comment shape type. This appears to prevent Excel >= 2010 from turning POI-written comments into the wrong shape (giant curved arrow). 
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1683315 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-03 12:50:10 +00:00
Tim Allison
ca17056096 POI-57975: clean up white spaces and other style issues in XWPF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682473 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-29 14:01:31 +00:00
Tim Allison
b8f9c0cad1 POI-57889 -- actually trigger inclusion of CTNumLvl with document contributed by Moritz Dorka on TIKA-1315 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682310 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 19:08:24 +00:00
Nick Burch
a727593a41 Correct package 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682210 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:15:07 +00:00
Nick Burch
c5c70d3ce4 Pull out the parts of TextPainter needed by XSLF from HSLF to common-SL in core #57963 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682209 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:13:23 +00:00
Dominik Stadler
03805d9e20 Add WorkbookFactory.create() with a flag to allow to open files read-only, keep the current way of opening read/write as default to not break existing code. 
Also adjust Javadoc somewhat.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681823 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 19:30:21 +00:00
Dominik Stadler
9017803980 Make POIXMLDocument implement Closeable as it holds an OCPPackage with open resources and thus should be closed after usage. Until now only XSSFWorkbook did this, but it makes sense for all derived classes. 
Also make close() in POIXMLDocument public to not have to re-implement it in all sub-classes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681822 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 19:30:04 +00:00
Dominik Stadler
589b189151 Prevent problems reported in Bug 56574 by ensuring that Cells are properly removed when a row is overwritten by calling createRow() with it's rownum. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680280 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-19 13:13:09 +00:00
Dominik Stadler
dafabdc7b9 Move location where document is held and adjust constructors and class-hierarchy accordingly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1679903 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-17 21:26:31 +00:00
Nick Burch
dd8fc66a0c #56791 More updates from OPOIFS to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:59:10 +00:00
Nick Burch
8bd0d5b819 Refactor common default styles code to use the new helpers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678197 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:34:03 +00:00
Nick Burch
120608b1f9 Start exposing the default paragraph and run styles from XWPFStyles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678193 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:25:47 +00:00
Nick Burch
1c693babb8 Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678188 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:08:15 +00:00
Nick Burch
9fd1832753 Start on XWPFStyles support for document default styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678187 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 13:07:00 +00:00
Nick Burch
9a755850e9 Begin on test for going from xwpf text to style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678179 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-07 12:37:43 +00:00
Dominik Stadler
ea27ddf601 Try to fix flaky test by waiting for a switch of the second to ensure that we have the same timestamps in the two workbooks that we compare byte-wise in this test. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677950 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-06 08:42:28 +00:00
Andreas Beeker
02bbe3b566 OOM fix for gump run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677913 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-05 23:51:10 +00:00
Tim Allison
8bfc6056c8 POI-57889 prevent NPE with on some documents with XWPFParagraph's getNumFmt() and add some other classes to enable calculation of paragraph numbers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677723 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-05 01:39:16 +00:00
Nick Burch
e9340cc1ba If an empty stream or file is given to WorkbookFactory.create, give a more informative exception - EmptyFileException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677562 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-04 09:15:48 +00:00
Andreas Beeker
02e70fdbfe fixed HSLF text handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1677496 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 23:42:42 +00:00
Nick Burch
c8f8cde62d Patch from Mark Olesen from bug #57552: Sort PackagePart returns from OPCPackage by name considering numbers in filenames, so Image10.png comes after Image9.png, fixing problems with XSLF adding 10+ images to a slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677373 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 08:47:50 +00:00
Nick Burch
3543d1a553 Avoid short wrapping on cell styles and formats > 32,767 in XSSF - format supports up to 64,000 of them #57880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677371 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 08:10:07 +00:00
Nick Burch
16d2e7881a Ensure consistent ordering when writing out formats following changes in r1677368 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677370 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 07:59:18 +00:00
Nick Burch
c76db74929 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677369 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 07:56:40 +00:00
Nick Burch
602832bda6 Somewhat speed up creating data formats with large counts, and add maximum format/style count checking. #57884 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677368 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-03 07:53:09 +00:00
Dominik Stadler
31adc2f269 Add verifying testcase for Bug 57423 and Bug 55752, both are still not solved, though. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676965 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-30 11:54:13 +00:00
Dominik Stadler
3275263c2b Remove Eclipse warnings in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676903 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-30 05:58:15 +00:00
Nick Burch
925d32e2c1 Allow WorkbookFactory.create to open xlsx files protected with the default password 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676853 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 20:36:13 +00:00
Nick Burch
9f196708d4 #57593 Complete create overloading in WorkbookFactory to take passwords 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676847 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 20:19:38 +00:00
Nick Burch
73aa2c9ee3 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676845 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 20:13:42 +00:00
Nick Burch
2889cabaed #57593 Begin adding overloaded WorkbookFactory.create methods which take the spreadsheet password 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676843 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 20:12:18 +00:00
Nick Burch
fb4bf25259 Use a constant for the name of the OOXML encrypted package node 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676838 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 19:47:35 +00:00
Nick Burch
b3bd87d3c2 When removing a SXSSF sheet, ensure temp files associated with it are disposed of #57666 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676833 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 19:28:26 +00:00
Nick Burch
b2a1862f19 Patch from Jon Scharff from bug #57826 - If a XSSF shape has a buFont but no bullet character, mirror Excel and treat as un-bulleted 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676831 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 19:21:37 +00:00
Nick Burch
c029154424 Add a (disabled) unit test showing the incorrect ordering problem of parts - bug #57552 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676810 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 18:31:12 +00:00
Andreas Beeker
e6413c3fe7 committing intermediate results - hslf is mostly migrated to common interface - junit tests partly fail - still a few compile errors - xslf drawing works - hslf drawing is not yet tested 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1676365 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-27 20:13:43 +00:00
Dominik Stadler
4c96affb9a Add unit-test which verifies that fill and alignment styles are applied and read back in correctly. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676276 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-27 14:29:59 +00:00
Nick Burch
3c1d9756ba Fix some inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675748 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 02:20:57 +00:00
Nick Burch
b681f4fb3a #57642 Fix setSheetName with ISERROR on XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675745 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 02:13:07 +00:00
Nick Burch
a5846f0f66 #57829 Avoid XmlValueDisconnectedException when removing a XWPFRun from a XWPFParagraph by removing from IRuns as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675738 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 01:29:10 +00:00
Dominik Stadler
f5c3a2a62c Print out slightly more on test-failure for a unit tests which fails intermittently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675266 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-22 06:49:38 +00:00
Dominik Stadler
d1385bbe1b Fix bug 57828, shifting more than one commit per row did not work. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674975 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-20 20:13:33 +00:00
Dominik Stadler
dfe1c74dff Fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674965 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-20 19:17:24 +00:00
Dominik Stadler
5118bdb128 Avoid possible NullPointerException seen with some powerpoint files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674958 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-20 18:26:39 +00:00
Dominik Stadler
ca8e3c465e Avoid NullPointerException if an image cannot be read 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674952 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-20 18:10:43 +00:00
Dominik Stadler
37a7733b45 Add missing nested Exception in thrown Exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674618 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-19 12:35:19 +00:00
Dominik Stadler
570819e4f6 Bug 56579: Throw exception if max string length of 32767 chars is exceeded in XSSF and SXSSF. 
Add verification testcase for bug 57008.
Move some unit tests to the Bsae-Test-Class to verify things for all SS-implementations.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671096 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-03 15:55:21 +00:00
Dominik Stadler
b173dc11d0 XMLPrettyPrint: Don't try to pretty-print non-XML files and print out which file from the ooxml-file fails to parse 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671095 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-03 15:54:59 +00:00
Andreas Beeker
652211b8d2 Snapshot commit - still lots of errors, xslf rendering works, started work on hslf 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1667902 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-19 23:44:23 +00:00
Dominik Stadler
0216a881f7 Bug 56017: fix shifting comments with shifted rows and move some more tests into the base classes to run them against XSSF, SXSSF and HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666843 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-15 20:52:55 +00:00
Dominik Stadler
30d20582af Bug 56295: Fix cloning of styles across workbooks and handling of default value of attribute applyFill 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666736 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-14 19:32:28 +00:00
Dominik Stadler
7bf9b90fb2 Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-14 13:18:43 +00:00
Nick Burch
ff737c5df4 Detect OOXML-strict, and give more helpful exceptions for them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666525 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-13 17:39:47 +00:00
Nick Burch
48e3a2e56a Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666518 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-13 17:17:47 +00:00
Nick Burch
a62be1da0c More relation types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666517 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-13 17:17:27 +00:00
Nick Burch
ace2354d6c Stub unit tests for #57699 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666510 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-13 16:46:15 +00:00
Dominik Stadler
97ce24a440 Verify that document from bug 56392 works 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666003 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-11 20:39:18 +00:00
Dominik Stadler
b7c14b3a8f Bug 56467: Fix cloning of sheets with pictures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665959 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-11 18:24:49 +00:00
Dominik Stadler
51fdb9434d Add testcase which verifies that bug 56820 was solved by some other fix already 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665957 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-11 18:24:32 +00:00
Nick Burch
c5ea89b2bc Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665933 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-11 16:30:02 +00:00
Nick Burch
555e42f4de Give a more helpful exception if a Visio VSDX ooxml file is passed to ExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1665929 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-11 16:17:41 +00:00
Andreas Beeker
a0070048fe committing intermediate results - xslf now compiles - hslf needs to be migrated to common interface - drawing is not yet tested 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1664935 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-07 23:35:40 +00:00
Nick Burch
aff5642202 Patch from tntim96 from bug #56799 - Include CTTblGrid in the smaller poi-ooxml-schemas jar 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1664236 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-05 06:31:18 +00:00
Dominik Stadler
9ede62441a Bug 57165: also verify that createSheet() had the same problem and is also fixed now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663154 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-01 20:01:43 +00:00
Dominik Stadler
e13374683a Bug 57165: Avoid PartAlreadyExistsException when removing/cloning sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663153 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-01 19:56:56 +00:00
Dominik Stadler
54bbd99ce4 Add missing close and handle theme-pptx in ExtractorFactory. Add creating slide-bitmaps to PPTX integration test. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1663137 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-01 17:50:16 +00:00
Nick Burch
2ccd6db57e More missing core properties unit tests, covering read-write without checks, and encryption 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662972 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-28 17:37:11 +00:00
Nick Burch
3ba7b59afc Ensure that the core properties are there before saving them, in case they have not yet been lazy-created 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662971 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-28 17:36:19 +00:00
Dominik Stadler
f043c44017 * Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available 
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler 
* Remove some Eclipse warnings in test-code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-27 14:58:41 +00:00
Dominik Stadler
e86ed72c2b * Add text-extraction verification to integration-tests via a new abstract base FileHandler 
* Fix NullPointerException found in some documents when running against the test-data
* Add support for extracting text from Dir-Entries WORKBOOK and BOOK to support some old/strangely formatted XLS files.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662652 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-27 09:59:14 +00:00
Dominik Stadler
7dfcd6c684 Adjust tests and fix small typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662650 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-27 09:52:57 +00:00
Dominik Stadler
b57a4f04e3 Adjust to provide full exception information for cases where we catch unexpected exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662447 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-26 13:43:10 +00:00
Nick Burch
66afa6d09b Update Javadocs to refer to the fact that WorkbookFactory.create will throw a EncryptedDocumentException if the file is password protected 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662074 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-24 18:20:02 +00:00
Nick Burch
7ee6e41e59 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661912 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-24 12:11:34 +00:00
Nick Burch
b6a88f09c8 Patch from rojotek from github-18 - Handle documents with a picture-only header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661908 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-24 12:09:30 +00:00
Nick Burch
d5065b1742 Change from XMLEventFactory.newFactory to XMLEventFactory.newInstance, for IBM JDK Compatibility, fixes #57622 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661903 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-24 12:03:53 +00:00
Dominik Stadler
1bbbd985d4 Bug 57612: Fix checking for proxy/accessible website in TestSignatureInfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661774 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-23 20:45:21 +00:00
Nick Burch
327df5cf76 Unit tests for OPC handling of files without a Core Properties part 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661663 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-23 13:21:23 +00:00
Dominik Stadler
04ae3247eb Revert organize imports 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1661327 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-21 11:58:45 +00:00
Andreas Beeker
996c9dd93c initial commit - still lots of errors, but I need to switch to a clean trunk for releasing and testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1661322 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-21 10:56:03 +00:00
Dominik Stadler
fa85c4bbef Use assertArrayEquals() to try to better show why this test fails in some rare cases currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1660697 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-18 18:47:22 +00:00
Dominik Stadler
ce007f05ee Bug 57459: Add method in SXSSFSheet to directly set row OutLineLevel 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659785 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-14 12:46:16 +00:00
Dominik Stadler
e450b8d5e1 Adjust TestSignatureInfo so junit provides more information if an unexpected exception happens 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659784 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-14 12:46:04 +00:00
Nick Burch
702f8b9ee7 Finish converting ErrorEval to only use the FormulaError constants, and then finish unit test for 57535 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658190 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-08 15:37:14 +00:00
Nick Burch
b1a6afc36a Add a unit test (disabled) for bug #57535 - "Unknown error type: -60" fetching formula error value 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658186 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-08 15:17:47 +00:00
Nick Burch
25385edc38 XWPF implementation of some common Paragraph methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657717 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-05 23:31:59 +00:00
Nick Burch
483982caad Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657712 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-05 23:20:43 +00:00
Nick Burch
c526206e0d More common HWPF/XWPF interfaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657634 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-05 17:35:09 +00:00
Nick Burch
1f2fc6c08b More common XWPF/HWPF character run methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657631 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-05 17:25:02 +00:00
Nick Burch
a351b66fde XWPF double strikethrough, and start on a common interface for HWPF and XWPF character runs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1657624 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-05 17:00:08 +00:00
Nick Burch
b25e4ca87d 57482 Handle XSLX files with no shared strings table in read-only mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653825 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-22 12:15:59 +00:00
Nick Burch
ca33983388 Unit test from Isao Kadowaki from bug #57482 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653814 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-22 11:45:40 +00:00
Dominik Stadler
eab2c0d20d Add a developer-tool to pretty-print the XMLs in an OOXML file. This makes it easier to compare OOXML files produced by different applications with differeing XML formatting. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1653777 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-22 07:24:01 +00:00
Nick Burch
0257c23cae Have ExtractorFactory open OPCPackages from files in read-only mode by default, since writing should never be needed when extracting text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652877 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-18 23:46:29 +00:00
Nick Burch
df20c0a69b For XSSFSheet, add a getDrawingPatriarch() method alongside the existing createDrawingPatriarch() one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1652876 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-18 23:45:04 +00:00
Nick Burch
c4eb73a28b Test to show that bug #57430 works fine already 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651314 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-13 09:57:46 +00:00
Dominik Stadler
113edb1a76 Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-09 20:37:11 +00:00
Dominik Stadler
3403bef5a8 Fix Eclipse warnings, provide better error message and adjust javadoc slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650598 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-09 16:52:23 +00:00
Dominik Stadler
c8bf92f963 Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-09 16:51:02 +00:00
Nick Burch
ed8964594b Swap Exception for Throwable, to skip a wider range of problems (eg GAE) when attempting to set an xml security manager as best we can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650290 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-08 13:22:50 +00:00
Dominik Stadler
8997d8900d * Add missing close() on streams in ImageUtils.getImageDimension() 
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-07 14:36:39 +00:00
Dominik Stadler
f912ecac92 Add reproducer for bug 56655 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650069 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-07 14:34:13 +00:00
Dominik Stadler
5aff4f5a2a Add reproducing testcase for Bug 57294 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649536 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-05 14:39:51 +00:00
Dominik Stadler
fa8eae2bfd Move some tests to the base test class where applicapple 
Introduce class BaseTestXCell to collect tests for XSSFCell and SXSSFCell that do not work for HSSFCell

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649527 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-05 14:03:37 +00:00
Dominik Stadler
c2d82b6005 Update disabled test for bug 54071 to show the root-cause better 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649526 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-05 13:48:41 +00:00
Dominik Stadler
8edf70ec8f Add unit tests for XSSFTextRun and TextPainter, slightly more tests for XSSFSheet and enhance unit tests for XWPFParagraph and ExcelAntTest 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649309 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-04 10:23:01 +00:00
Dominik Stadler
9794510d33 Improve information in exceptions thrown by XSSFRichTextString and improve unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649234 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-03 19:30:56 +00:00
Dominik Stadler
2f681f430c Fix copy/paste errors in XSSFSimpleShape, allow unset of insets multiple times and add unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649233 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-03 19:30:36 +00:00
Dominik Stadler
3bbf57cd27 Fix copy/paste error in XSSFTextParagraph and add unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649232 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-03 19:29:51 +00:00
Dominik Stadler
302db39cb7 Fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 21:06:51 +00:00
Dominik Stadler
ffcc20f60e Bug 46898: Convert unit tests for circular references to also run for XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649122 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 21:04:50 +00:00
Dominik Stadler
12edcc5ed2 Bug 46192: Add methods to query outline level for HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 20:03:28 +00:00
Dominik Stadler
5c76ccba5b Add missing close() of resources in both production code and tests 
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 09:16:57 +00:00
Dominik Stadler
26585f4e95 Ensure that XSSFWorkbooks contain a BookView, some corrupt ones do not contain this, e.g. ones created by movescound.com 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648158 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 09:08:58 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete 
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-27 01:33:28 +00:00
Dominik Stadler
0c580c8f45 Add a test-suite which performs integration/stress tests which load and handle all stored test files in various ways. 
It works by using handlers for each type of file which perform various operations on the files, e.g. loading,
iterating content, modify, ... This will trigger changes which break working with the available test-files and
thus provides another layer of regression testing which hopefully prevents some failures from making it into
releases.

It is runnable via a new ant-target 'test-integration' and also added to the jenkins-target.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647885 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-25 09:16:44 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF 
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-25 01:56:29 +00:00
Dominik Stadler
ed60f5cb08 Add comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647512 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-23 09:26:22 +00:00
Dominik Stadler
95c9b9991a Fix testcases which were not executed before, use tempfile, cleanup, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647511 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-23 09:26:14 +00:00
Dominik Stadler
7ee9ce8388 Fix two Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647325 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 14:56:47 +00:00
Dominik Stadler
83f5683c50 Bug 57373: Fix get/setFirstVisibleTab() for XSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647322 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 14:37:37 +00:00
Dominik Stadler
1db7f3bd3b Bug 57362: Properly initialize chart axis when loading a workbook which already contains a chart. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647317 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 14:16:23 +00:00
Dominik Stadler
f622530806 Remove iterating over the number of runs for certain XSSFRichTextString operations. If I didn't overlook something, they can directly access the array element anyway. Seems this was some leftover copy/paste stuff. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647315 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 14:09:55 +00:00
Dominik Stadler
03f846c695 Bug 56511: Add a null-check to ensure that the run actually has a font to not cause a NullPointerException but rather return null as documented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647308 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 13:06:58 +00:00
Dominik Stadler
645d2083bf Bug 56550: Defer the initialization of the _classes to when it is actually needed to allow IBM JDK to at least load the class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647302 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 12:38:44 +00:00
Dominik Stadler
43ee4e08ca Add missing license header to newly added file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647294 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 11:49:43 +00:00
Dominik Stadler
0b6867d1d5 Bug 56644: Fix adding cells if MissingCellPolicy is set to NULL_FOR_BLANK and the last column in a row is empty 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647291 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 11:11:34 +00:00
Dominik Stadler
181de5f6e5 Bug 56888: XSSFDataValidation ignores "allow blank" read from sheet, assumes true 
Add TestSXSSFDataValidation to verify some parts for SXSSF as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647276 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 10:03:32 +00:00
Dominik Stadler
a98c9daa01 Some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647269 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 09:16:16 +00:00
Dominik Stadler
2d07fa94af Add reproducer for Bug 57165, no fix yet, though... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647265 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 09:10:01 +00:00
Dominik Stadler
0fdfac62c9 Bug 57171 and 57163: Adjust the active sheet in setSheetOrder() and removeSheet() for both HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647264 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 09:00:18 +00:00
Dominik Stadler
12353bca7f Bug 57236: Add reproducer, although I am not sure if we should and how to fix this... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647254 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 07:57:03 +00:00
Dominik Stadler
213aa1559b Adjust typos in Javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647210 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-21 21:07:06 +00:00
Nick Burch
3a72ec0aec Patch from Kamil Linek from bug #57071 - 3+ XSSF column label names for pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647088 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-21 06:20:06 +00:00
Nick Burch
942f8044d9 Patch from Kamil Linek from bug #57063 - XSSF custom column label names for pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647087 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-21 06:12:20 +00:00
Dominik Stadler
68bb54e06a Bug 57254: XWPF: Correctly build internal list of styles when styles are added 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646742 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-19 14:42:25 +00:00
Dominik Stadler
66de3ced8b Remove unused members, 
Fix an Eclipse warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646736 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-19 14:36:41 +00:00
Dominik Stadler
fb9295ffb9 Bug 57312: Add check for null value of underline w:val 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1646729 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-19 14:29:50 +00:00
Dominik Stadler
51308cd422 Bug 57355: Fix ArrayIndexOutOfBoundsException by removing two unnecessary lines in XSSFSheet.getColumnWidthInPixels() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645900 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-16 10:40:02 +00:00
Andreas Beeker
1460fd33b2 Added workarounds to tests for JDK 6 LineBreakMeasurer bug and handle it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1644806 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-12 01:43:45 +00:00
Andreas Beeker
dbfabda346 close decrypted stream - test for #57296 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1644796 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-12 00:06:15 +00:00
Andreas Beeker
f3e4795275 57250 - XMLSlideShow.setSlideOrder() produces corrupted CTSlideIdList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643684 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-07 15:28:01 +00:00
Andreas Beeker
93dffcb366 XML signatures - ignore line breaks in Office 2007 .rels files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1643415 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-05 20:20:23 +00:00
Dominik Stadler
1deed31c23 Include root-cause exception information when constructing ContentTypeManager fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641940 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-26 21:11:02 +00:00
Andreas Beeker
9d84f426f3 Don't swallow exceptions on validation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641025 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-22 01:47:48 +00:00
Andreas Beeker
d3dee868ef the subdir element needs to be included otherwise certain xmlbean operations (e.g. selectPath) can't find the corresponding xmlbeans classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1640846 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-21 01:06:39 +00:00
Andreas Beeker
27b0d08d0f Bug 57164 - XSSFDrawing.createCellComment() does not honor dx and dy values passed in 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1639996 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-16 14:48:47 +00:00
Andreas Beeker
45fb6c5b18 Picture method to resize with different scales in width and height 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638623 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-12 00:19:00 +00:00
Dominik Stadler
194738dd91 Restore printing out test-failures after switch to JUnit4 execution 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638179 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-11 15:30:34 +00:00
Andreas Beeker
d709edb343 Use Junit4 JUnitCore instead of legacy TestRunner 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637996 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-10 23:46:50 +00:00
Dominik Stadler
9f3e8b4919 Bug 57197: use proxy for TestSignatureInfo if set via environment variables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637979 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-10 20:37:26 +00:00
Dominik Stadler
3cf7699fde Fix Eclipse warning about generics 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637978 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-10 20:36:54 +00:00
Dominik Stadler
3dd00ab13a Add xmlsec-jar in test-ooxml-lite which is missing after removing ooxml.classpath 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637718 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-09 19:19:02 +00:00
Nick Burch
82ee923858 Patch from hishidama to add Cell.removeHyperlink(). This closes #13 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637562 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-08 13:46:30 +00:00
Nick Burch
e2dd7f27c0 Test from Tim to include PropertyList in poi-ooxml-schemas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637548 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-08 12:21:27 +00:00
Dominik Stadler
24effccc61 Fail build if test-cases fail in OOXMLLite execution to avoid missing included schema-classes. Also adjust how we look for test-classes so that we print out the ones that we skip with known ones excluded. Also print out skipped inner classes. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637475 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 22:33:54 +00:00
Dominik Stadler
62ac7efea6 Slowly start to adjust places in tests where we do not properly close file handles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637474 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 22:33:35 +00:00
Dominik Stadler
b6a3184196 Calling ping is not a good idea as it runs endlessly on some platforms, do a Java connection test instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637370 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 13:05:57 +00:00
Andreas Beeker
69dc33caf2 another signature ubuntu jdk6 bug fix ... and offline/online handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637283 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 01:16:21 +00:00
Nick Burch
70177caa04 Try for a more specific failure message on the assert 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637129 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-06 14:54:02 +00:00
Andreas Beeker
21d90606ab another blind sha2 bug fix ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637005 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-05 23:33:33 +00:00
Andreas Beeker
1fcb0d7fd3 Added a catch and another workaround for the OpenJDK SHA2 AIOOBE bug 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637001 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-05 22:56:31 +00:00
Dominik Stadler
5f4a2a3b44 github-7 - Form check box extraction with XWPFWordExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636990 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-05 22:26:00 +00:00
Nick Burch
85d0a161b0 Patch from hishidama to add Sheet.getDataValidations() for HSSF and XSSF. This closes #11 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636857 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-05 12:14:54 +00:00
Nick Burch
20438f4db5 Patch from hishidama to add Comment.getClientAnchor(). This closes #12 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636782 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 23:55:23 +00:00
Andreas Beeker
bb378b0719 workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1155012 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636769 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 22:56:39 +00:00
Nick Burch
4923afc9f8 Fix bug #57185 - Should be Series not Serie, latter is incorrect English / a Typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636755 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 22:11:07 +00:00
Nick Burch
3b4a96bbc2 Some more XSSF testing for #57184 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636750 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 22:00:09 +00:00
Nick Burch
0fdd7a1dbc Partial HSSF support for adding new external workbook formula references for #57184 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636742 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 21:35:01 +00:00
Nick Burch
dbfe9f3949 Fix naming, see #57185 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636707 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 19:54:59 +00:00
Nick Burch
663171c6c2 Add unit test for bug #57176 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636634 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 16:20:05 +00:00
Nick Burch
1b9ad8e4db More disabled unit tests relating to external workbook formula references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636626 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 16:03:25 +00:00
Nick Burch
5596161186 Switch to explicit includes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636623 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 16:01:24 +00:00
Uwe Schindler
80b148f56f Fix bug 57162: Content_types.xml and .rels files had elements with wrong namespace (the default one) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636188 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-02 20:53:02 +00:00
Nick Burch
da85bfd23e Comment out work-in-progress extension to test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635542 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 16:53:01 +00:00
Nick Burch
8616a88a86 Add missing HSSFWorkbook constructor javadocs #57166 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635533 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 16:19:54 +00:00
Andreas Beeker
1d84cd9828 Bug 55164 - Support for adding slide notes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635010 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-29 00:07:34 +00:00
Andreas Beeker
5dcf6b1a29 simplified the cropping code and changed the cropping image to a more sophisticated one - interesting enough, it's rendered correct in POI (like in Powerpoint), but malformed in LO 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634749 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-28 00:04:10 +00:00
Andreas Beeker
2ff41d7acd Bug 54542 - Add support for cropped images in XSLFPictureShape.drawContent() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634410 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-27 00:00:05 +00:00
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-25 21:32:03 +00:00
Dominik Stadler
2e283f2ebf Apply patch for bug 55864 - XSSFImportFromXML.importFromXML() does not support optional elements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633404 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-21 15:56:45 +00:00
Dominik Stadler
3c37d8f3cd Apply patch to fix bug 56835: Unreadable content when adding multiple comments to cell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633397 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-21 15:16:14 +00:00
Nick Burch
89ad69234c Unit tests which reference XSSF must be on the ooxml part of the tree 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633256 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 23:21:01 +00:00
Andreas Beeker
11cfec8513 xml dsign - javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633241 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 22:18:42 +00:00
Dominik Stadler
7664c7efa7 * Make more tests work in OOXMLLite compilation by adding xml security classpath and ensuring proper cleanup in some Extractor tests 
* Remove downloading xerces library here, we now do this in the special Jenkins job and thus can get rid of it here

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633166 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 14:26:53 +00:00
Dominik Stadler
02a4dc5462 * Also adjust build.xml for newer required Ant 1.8.0 
* Pass "additionaljar" to junit calls to enable us to exclude tests which we know are failing (newer XML Security stuff)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633156 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 13:54:41 +00:00
Dominik Stadler
f0d47ab7cb When using v4 Junit style, we need to set @Test to make the test-methods actually execute 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633154 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 13:49:51 +00:00
Andreas Beeker
14f3200486 Removed some custom classloading code, which doesn't make sense anymore 
Tested a few other timestamp providers
limited the use of the additional libraries to xml dsign classes while running the junit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632858 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 23:19:49 +00:00
Dominik Stadler
a604506683 Seems we have slow connection on the Apache Jenkins instance. Thus allow one specific test to fail with a specific ConnectException as we see this happening sometimes in Jenkins but should not fail the unit test suite of POI because of such infrastructure problems 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632566 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-17 13:04:53 +00:00
Andreas Beeker
5692f061a9 Bug 56836 - XML signature support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632447 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-16 23:30:42 +00:00
Andreas Beeker
daa7d17531 Bug 57080 - IndexOutOfBoundsException in poi decryptor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631600 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-13 23:42:33 +00:00
Andreas Beeker
a16db327fd xml signature: mainly javadocs - a few reorgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631003 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-10 22:48:21 +00:00
Dominik Stadler
8dde4b0ae4 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:39:35 +00:00
Dominik Stadler
d254ec8ec1 Print out current version of java before building to allow to see in build output if we use a supported Java VM version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:20:12 +00:00
Andreas Beeker
30d72983d1 another round of refactoring, limited exception declarations, more javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629332 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-03 22:24:09 +00:00
Andreas Beeker
ab84e448ca removed obsolete classes and added a few javadocs elements and example calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629095 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-02 22:47:35 +00:00
Andreas Beeker
3438e7f4f6 xml signature - small javadoc fixes, removed obsolete parameter from SignatureFacet interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1628575 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-30 23:42:21 +00:00
Andreas Beeker
1ed069daf7 Fixed complete-build errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628338 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-29 23:39:45 +00:00
Andreas Beeker
da4201c2cd more tests, some refactoring 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 22:30:02 +00:00
Andreas Beeker
4fb7957b52 forgot to rename get/setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628031 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 00:35:00 +00:00
Andreas Beeker
ab5a1dd5d3 Moved prefix logic in one place 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628029 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 00:30:05 +00:00
Andreas Beeker
013bd1469c configure namespaces via signatureconfig 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627985 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-27 17:49:09 +00:00
Andreas Beeker
0eb917b223 clean ups 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627682 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-25 23:59:36 +00:00
Andreas Beeker
123784df81 more flexible signer verification through Iterable-Interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627434 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-24 22:54:21 +00:00
Andreas Beeker
ff38e12652 centralized configs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1626646 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-21 22:48:20 +00:00
Andreas Beeker
6639a1938e reorganization, xmlsignatureservice is now in signatureinfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1626107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-18 23:47:41 +00:00
Andreas Beeker
c9757d974f Switched to config object 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625850 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 23:12:16 +00:00
Andreas Beeker
b410e72196 merge with trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 21:12:36 +00:00
Andreas Beeker
11e384f0ec timestamping fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620990 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-27 22:58:03 +00:00
Andreas Beeker
687194fd91 removed HorribleProxy 
added current version of BouncyCastle and xmlsec (using xmlsec instead of jdk internal classes, because of interoperabiltiy with e.g. IBM JDK)
heaps of changes because of above

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620230 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-24 23:06:05 +00:00
Andreas Beeker
d0cc2e4267 removed HorribleProxy 
added current version of BouncyCastle and xmlsec (using xmlsec instead of jdk internal classes, because of interoperabiltiy with e.g. IBM JDK)
heaps of changes because of above

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620229 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-24 23:05:26 +00:00
Andreas Beeker
8962fa8310 starting tsp tests / removed mockito stuff again 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618515 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-17 19:53:34 +00:00
Andreas Beeker
58b11677cb - Updated to BC 1.51 
- Download BC/test-libs in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618403 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-16 19:21:31 +00:00
Andreas Beeker
ec7fde8fcb replace xmlbeans.factory.parse with selectPath calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618292 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 23:10:07 +00:00
Andreas Beeker
1b2f321ae9 migrated enveloped document test (1 of 2) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618288 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 22:20:30 +00:00
Andreas Beeker
777fd47d71 some changes because of test errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618254 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 18:19:28 +00:00
Andreas Beeker
c378d75e51 sync merge to trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617624 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 23:33:07 +00:00
Uwe Schindler
cd80405811 Add some extra safety test to check that external entities are not loaded by xmlbeans 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617453 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 11:33:02 +00:00
Uwe Schindler
2f5bcfd162 Fix bug #56814 - Switch from dom4j to JAXP 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617428 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 07:19:51 +00:00
Andreas Beeker
6bbe12277f Tests/fixes for hash > sha1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617180 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 23:34:13 +00:00
Andreas Beeker
7d445b6693 download xades files and remove from them resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617153 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 20:37:44 +00:00
Andreas Beeker
63f8c1dcf0 Xml signature support - version 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617141 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 18:25:10 +00:00
Nick Burch
89fd75ff0a Fix bug #56812 - In XSLF provide a way to get the URI of externally linked pictures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615812 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 22:00:47 +00:00
Nick Burch
e0f22fd7cf Add a disabled unit test for bug #56812, based on code and file from Geoff Wright 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615803 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 21:34:51 +00:00
Nick Burch
b350d5c5ed Before parsing an OOXML document, reset the xmlbeans sax parser to avoid the risk of getting one in an error state (due to XMLBEANS-512). Should be a minimal extra overhead pending a proper fix. Allows us to finish enabling the unit tests for #54764 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615781 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 20:42:41 +00:00
Nick Burch
07771c3d8c Add another test file for #54764, and a test that uses it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615731 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 19:18:20 +00:00
Nick Burch
236c3c52a9 Apply suggestions from Uwe Schindler for more secure xml defaults for #54764 and #56164, for xml parsers which support them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615720 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 18:17:26 +00:00
Andreas Beeker
3cd1cd6e70 Another test for NPOIFS in-place writing support - probably the deletion of an entry causes the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615273 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-02 00:51:56 +00:00
Nick Burch
0e44d8da73 Fix bug #56800 - Provide a helpful exception, XLSBUnsupportedException, if XSSFWorkbook is passed a .xlsb file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615118 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-01 14:33:17 +00:00
Nick Burch
afa2322295 Fix bug #55196 - Correct XWPF createTOC handling of short style names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614930 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 16:11:35 +00:00
Nick Burch
4bfe3c6784 Fix bug #56502 - When shifting XSSF rows with formula cells, if the formula can't be parsed, log + leave it unchanged rather than failing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614916 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 15:07:27 +00:00
Nick Burch
5f5d8f496e Fix bug #56527 - Avoid NPE from XSSFHyperLink when setting the cell 
it references on a new link

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614914 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 14:55:04 +00:00
Nick Burch
de0d2a0935 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614886 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:37:33 +00:00
Nick Burch
64187356aa #56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 18:08:28 +00:00
Nick Burch
d03c10f257 XSSF external workbook lookup support for in-line file:/// based book "numbers" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614724 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 17:53:54 +00:00
Nick Burch
7844d4dafb Updated patch from Marc from #55927 - handle date formulas too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614696 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 16:10:56 +00:00
Nick Burch
27dd2eafe1 Add row label getter for Pivot Tables, and use this in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614691 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:44:05 +00:00
Nick Burch
797f3368d6 Patch from Sofia Larsson and Martin Andersson from bug #56020 - XSSF support for creating Pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614684 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:27:09 +00:00
Nick Burch
f0dc1291ad Change XSSFSheetXMLHandler.SheetContentsHandler to require fewer backwards incompatible changes for #56023 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614576 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 07:41:01 +00:00
Nick Burch
5d9f8945c9 HSSF and XSSF Multi-Sheet formula reference tests from Radoslav from bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613654 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-26 15:20:06 +00:00
Nick Burch
59861b7836 Complete evaluation support for multi-sheet references for bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:42:31 +00:00
Nick Burch
97c4bbc9b8 Allow XSSF to evaluate multi-sheet references too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:55:49 +00:00
Nick Burch
82b36d3268 Split the reference and area tests for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613454 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:49:35 +00:00
Nick Burch
3e2e01c149 Update the XSSF getExternalSheet method signature, to start to prepare for sheet ranges 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613439 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:23:21 +00:00
Nick Burch
4c8f3ab160 More tests for #55906, and provide a new eval that lets you get at evals for many sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:15:56 +00:00
Nick Burch
96386e2e0a Areas can have multi-sheet references too, so add FormulaParser support to these as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 13:59:07 +00:00
Nick Burch
8f4fac46ee Update Ref3DPxg to support multi-sheet ranges too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613376 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:22:21 +00:00
Nick Burch
29e5928c42 More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:05:57 +00:00
Nick Burch
1161077a6b More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 22:44:51 +00:00
Nick Burch
7f6ba5513c Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:25:45 +00:00
Nick Burch
899ff0569b Disabled unit tests for multi-sheet references, see bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613282 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 20:48:29 +00:00
Nick Burch
14d5fa912f Patch from Shaun Kalley from bug #56023 - Allow XSSF event model to find + return comments, and use this for the event based .xlsx text extractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613266 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 20:13:54 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 18:58:27 +00:00
Nick Burch
9fcdec5719 To avoid problems on strange platforms, tell xmlbeans to use UTF-8 for strings by default, for bug #56683 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613193 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 17:14:00 +00:00
Nick Burch
bb91152a12 For places where an ordered collection is created and used within the context of a single thread, and there are no thread safety concerns, use ArrayList not Vector. See bug #54838 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613186 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:41:43 +00:00
Nick Burch
fec4eb7a12 When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:56:23 +00:00
Nick Burch
bf6f54d836 Get further with the XSSF formula reference evaluation testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612926 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 19:09:45 +00:00
Nick Burch
4418c0cef9 Further XSSF external name evaluation lookup support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612925 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 19:09:25 +00:00
Dominik Stadler
a5d32d87d4 Fix test to make it work on different date as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612786 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 07:55:48 +00:00
Dominik Stadler
b6dd3bca34 Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 12:31:56 +00:00
Nick Burch
56b7f9f365 Use the link table when looking up external xssf names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612347 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 16:52:19 +00:00
Nick Burch
12e87a1900 Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 12:23:54 +00:00
Nick Burch
d43121661c Correct non-sheet-based NameXPxg formula rendering, and add tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 07:35:09 +00:00
Nick Burch
1179ca9c26 More unit tests for #56737 and #56752 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612157 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 19:24:42 +00:00
Nick Burch
146c39e070 Comments updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612156 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 19:13:45 +00:00
Nick Burch
05dc1ec70c Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:56:35 +00:00
Nick Burch
a550397ac2 XSSF Pxgs must escape sheet names where required when generating the formula string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:53:27 +00:00
Nick Burch
42cd819573 Update the formula evaluator to support XSSF style external named ranges too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 17:51:51 +00:00
Nick Burch
0b1dee9913 Better reporting on why a test is failing, and partial NameXPxg eval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:27:28 +00:00
Nick Burch
81869b869d Complete the XSSF Formula Parser tests for #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611963 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:00:21 +00:00
Nick Burch
ed7140b3d8 Move towards supporting same workbook named ranges in external style for xssf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:51:23 +00:00
Nick Burch
58096a6862 Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:30:31 +00:00
Nick Burch
86ca81d22f Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:42:07 +00:00
Nick Burch
2cd4290460 Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:19:06 +00:00
Nick Burch
7c382f9f37 The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 12:49:41 +00:00
Nick Burch
1ed2a18323 There can be more than one linked ExternalLinks table for a workbook #56744 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611890 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 11:27:46 +00:00
Nick Burch
7d2a9093da Turns out that .xlsx files can have multiple link tables, add a test file which shows this (support to follow) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611878 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 10:09:00 +00:00
Nick Burch
c386b48755 Convert test to junit 4, and stub out the additional 3d ref tests we need to pass for #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611877 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 10:08:20 +00:00
Nick Burch
58d3cd3717 Stub the unit test which is the next thing to need to work for progress on #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611833 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 23:02:51 +00:00
Nick Burch
551573dd95 Bit more towards XSSF name support for #56737, will need some deeper changes though to fully implement 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611830 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 22:50:54 +00:00
Nick Burch
611bcffb0c Initial support for XSSF External Links tables, which hold references to other workbooks referenced by formulas and names. #56744 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611828 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 22:48:59 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:16 +00:00
Nick Burch
c9d90732e5 Add disabled unit tests for bug #56737, which currently fails (differently) for HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611400 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-17 16:18:39 +00:00
Nick Burch
696b9d6406 Fix for #56702 - If a cell is of type numeric but has an empty <v/> tag, return as 0 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1610482 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-14 18:53:39 +00:00
Nick Burch
b9ff74b050 This bug has been fixed, so re-enable the unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607662 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 14:46:32 +00:00
Nick Burch
92f1cd20da Add a disabled unit test for bug #56420 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607661 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 14:30:47 +00:00
Nick Burch
f33843810a Now that XSSFWorkbook can be closed, the older path based constructor no longer needs to be deprecated #56537 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607536 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 05:45:21 +00:00
Dominik Stadler
e34e77b12d Bug 56537: Update javadoc to reflect the addition of Closeable to Workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607390 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-02 15:05:05 +00:00
Tim Allison
94e9d67258 BUG 54771: add class to svn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602960 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-16 18:53:28 +00:00
Tim Allison
af7b947bb9 BUG 54771 extract text from SDTs at the cell level within a table row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602955 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-16 18:46:00 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly, 
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 20:36:30 +00:00
Nick Burch
8afc419270 Fix inconsistent indent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601930 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 15:38:26 +00:00
Nick Burch
a1d0c8a260 #56537 close method for SXSSF too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601917 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 14:38:32 +00:00
Nick Burch
47a8f6cf48 Partial fix for #56537 - Have Workbook offer a close() method, which in turn closes the NPOIFS or OPC resource from which it was loaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601901 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 13:48:54 +00:00
Nick Burch
1bcf519c7c Add a note about file resources, see bug #56537 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1600326 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-04 16:34:16 +00:00
Nick Burch
e1000f257e When finding the CTCol object for a XSSF Sheet column, as we often have to traverse most of the list, and we are mostly reading not changing, switch to fetching all the objects as an array in one go, rather than fetching one at a time, which is hopefully faster. Aims to help bug #56556 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1600319 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-04 15:58:14 +00:00
Nick Burch
6cc94cdae8 Handle date format strings in an iso8601 style format, with a T in them. Fixes bug #54034 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597038 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 09:18:16 +00:00
Nick Burch
2bde35b8ff Patch from Yaniv Kunda from bug #56274 - Fix SXSSF writing of tables when creating from a template 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596624 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-21 17:08:25 +00:00
Dominik Stadler
1e93f257fc Move some tests from "unfixed" to "normal" test classes as the underlying bug is now fixed. 
Also make on of the unfixed bugs cause an actual failure so it is justified to stay in "unfixed"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596261 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-20 14:12:19 +00:00
Dominik Stadler
38b5621723 Bug 56170: Fix a problem with cells in workbooks becoming disconnected from XMLBeans whenever columns need to be reordered during writing the file. This happens because setCArray() disconnects any previously stored array-item but we try to re-use them. So we need to recreate the CTCell and set it in the XSSFCell to make this work in all currently tested cases. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595659 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-18 19:18:27 +00:00
Dominik Stadler
927e62f662 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-16 13:25:45 +00:00
Dominik Stadler
8f04bf295e Fix Bug 56514, add missing null-check if simple shape does not have any text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595127 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-16 07:09:55 +00:00
Dominik Stadler
9efc349872 Avoid unnecessary string creation/concatination for numeric conversion, use Double.toString() instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595047 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 21:14:32 +00:00
Andreas Beeker
d0320ad77d Bug 56468 - Writing a workbook more than once corrupts the file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594721 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-14 21:14:16 +00:00
Dominik Stadler
599489e6fa fix some Eclipse warnings, unnecessary null-check and missing close() in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594201 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-13 11:31:18 +00:00
Nick Burch
d36d917467 Fix some Eclipse identified warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589765 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 15:07:20 +00:00
Nick Burch
6050a68d5a Two more test files from Stefan Kopf for bug #56164, and unit tests which use them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589759 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 14:52:09 +00:00
Nick Burch
67d97d8894 Correct an eclipse warning around close(), and a related bug that this identified 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 14:50:52 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes: 
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 12:16:54 +00:00
Dominik Stadler
0974acc778 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 18:20:15 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-15 21:59:52 +00:00
Dominik Stadler
a202d2fa64 Fix two javadoc warnings reported in Jenkins build and add some @Overrides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583598 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-01 10:40:13 +00:00
Nick Burch
8bee2665b3 Patch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC 
IDIC platforms, by setting the required encoding explicitly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1580314 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-22 20:48:58 +00:00
Nick Burch
af381473d0 Support adding tabs to a XWPFRun, and add unit tests on toString() for addTab and addCarriageReturn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578921 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-18 14:26:28 +00:00
Nick Burch
e9ea048c00 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578915 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-18 14:17:36 +00:00
Nick Burch
6d2ecdeac2 Fix bug #56278 - Support loading .xlsx files with no Styles Table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578518 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-17 19:02:21 +00:00
Dominik Stadler
ee58bd0d32 Bug 56195: replace System.err with propert logging 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578147 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-16 19:46:56 +00:00
Dominik Stadler
24fdb260bc Remove two files added inadvertedely 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577909 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 17:31:43 +00:00
Dominik Stadler
7c3f1a926b Bug 56169: Fix NPE during export to XML with xs:all 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577907 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 17:29:17 +00:00
Andreas Beeker
c5527db88a Bug 56075 - Add Change Tracking support to XWPF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577010 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-13 00:16:56 +00:00
Nick Burch
f63b47b8f6 Fix inconsistent whitespace, and add a close call in the main method to avoid a resource-leak warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575684 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-09 09:53:25 +00:00
Nick Burch
434f05058e Fix the inconsistent indents in the test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575600 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 20:03:40 +00:00
Nick Burch
09adb72510 Add more unit tests for XWPF Headers and Footers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575599 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 20:01:38 +00:00
Nick Burch
d5c8510750 When adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575597 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 19:52:09 +00:00
Nick Burch
70e1b5edeb Add some javadocs for the XWPF Header/Footer creation methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575594 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 19:33:07 +00:00
Dominik Stadler
8c5115aeb1 Fix Sonar issues about finalize() usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:41:25 +00:00
Dominik Stadler
382be9f312 Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:22:03 +00:00
Andreas Beeker
3fe86eca24 Added MD4-option and some cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-06 00:53:09 +00:00
Andreas Beeker
833ae007f8 Bug 56076 - Add document protection with password support to XWPF 
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-21 23:19:57 +00:00
Nick Burch
32290bd2bf Another content types test, for #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570002 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-20 00:06:34 +00:00
Nick Burch
d72bd78c19 Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:54:46 +00:00
Nick Burch
56d6f0342a Complete support for OOXML content types with parameters, including parts of the patch from Sebastien Schneider from bug #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569976 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:34:53 +00:00
Nick Burch
6e933cb242 Begin to implement some of the tests and logic for content types with parameters, based on the test file for bug #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569965 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:12:56 +00:00
Andreas Beeker
53c90692ee FindBugs fix 
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 19:35:16 +00:00
Andreas Beeker
8689458854 Sweeping is also needed for empty column-list ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568791 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 17:00:53 +00:00
Andreas Beeker
2a14920cdd FindBugs fix 
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 16:30:24 +00:00
Dominik Stadler
9b4121cb45 Update Javadoc somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:19:32 +00:00
Dominik Stadler
2b85b00690 Add assertions, remove Sonar warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568554 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:18:34 +00:00
Andreas Beeker
f8bf66308e update *ssf-workbook tests to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568541 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 23:21:30 +00:00
Andreas Beeker
a0831ba0f9 Bug 53130 - SXSSF Shared Strings option support, to make generated xlsx files compatible with Google Docs or iPad 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568539 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 22:45:05 +00:00
Andreas Beeker
92a488a28b FindBugs fix 
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix 
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-13 23:34:11 +00:00
Andreas Beeker
413e76aed0 FindBugs fix 
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-09 21:19:20 +00:00
Dominik Stadler
d9009484a6 Bug 55923: Fix compare/sorting of nodes in exported XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564050 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 20:56:43 +00:00
Dominik Stadler
19ed26f156 Bug 55924: Avoid errors during exporting XML if there are numeric cells without value, also verify in tests that XML can always be parsed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564045 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 20:17:59 +00:00
Dominik Stadler
d7028dcf09 Bug 55926: Handle numeric formula values when exporting to XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564028 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 19:46:41 +00:00
Dominik Stadler
503ce1e6c4 Bug 55927: Handle date types when exporting to XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564011 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 19:19:14 +00:00
Nick Burch
eb2e8ffe0a Patch from Shaun Kalley from bug #56022 - XSSF Event Text Extractor header/footer support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563657 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:39:53 +00:00
Nick Burch
85bee89fe3 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563653 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:28:04 +00:00
Nick Burch
720b4a3aad Have the Excel text extractors all implement the same interface, as best as they can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:23:26 +00:00
Dominik Stadler
cdb915a279 Bug 56017: Fix comment-ref when shiftig rows with comments, this probably does not fix the bug itself, though 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563587 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 10:34:42 +00:00
Andreas Beeker
c1a7ab3860 Bug 53282 - Hyperlink with a non-breaking space throws java.lang.IllegalStateException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563540 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 01:56:02 +00:00
Andreas Beeker
028ec314ae javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563509 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 23:23:07 +00:00
Andreas Beeker
f101bc0aff Bug 55802 - Special Letters not exported correct 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563496 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 22:26:18 +00:00
Andreas Beeker
5e7679eafd Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563488 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:56:07 +00:00
Dominik Stadler
7db6081827 Bug 56011: Use default style if the cell style attribute is not present 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563470 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 20:54:09 +00:00
Andreas Beeker
bd3cd2243e TreeSet without JDK 6 method usages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561511 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 16:26:59 +00:00
Andreas Beeker
e790281425 This patch is not working as of license incompatibility - see http://www.apache.org/licenses/GPL-compatibility.html 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561507 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 15:38:11 +00:00
Andreas Beeker
6f6c6cda34 As Jdk 1.5 doesn't provide NavigableMap/Set classes of JDK 1.6, we temporarily use the open jdk classes instead, until POI has switched to JDK 1.6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561500 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 15:01:12 +00:00
Andreas Beeker
30d9106d9a - Bug 51585 - WorkbookFactory.create() hangs when creating a workbook 
- adapted relevant test-classes to Junit4 to support timeout handling
- tab / space cleanup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561435 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 02:18:53 +00:00
Andreas Beeker
439ad29071 Added license headers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-18 00:38:04 +00:00
Andreas Beeker
1eba8faedb Bug 35897 - Password protected files 
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 23:14:03 +00:00
Dominik Stadler
d714d0da65 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-01 22:15:44 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more 
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:12:30 +00:00
Dominik Stadler
1e4c1770d7 Bug 51158: clear out Memory-based part before writing to it, 
except for PictureData items, which keep the original image
data in the Part-object directly.
Add reproducer-unit tests and enhance some related unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553525 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 17:55:36 +00:00
Dominik Stadler
f8969e8d83 Remove unnecessary separate length, an array already has one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553522 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 17:54:49 +00:00
Dominik Stadler
aaa4029cd5 Remove unused members and make others private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553464 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 09:31:25 +00:00
Andreas Beeker
2788aca235 javadoc and compiler warning house-keeping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 23:24:04 +00:00
Andreas Beeker
3ccd728544 javadoc house-keeping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553422 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 22:18:53 +00:00
kiwiwings
3a36da330a JCE policy fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553342 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 01:04:29 +00:00
kiwiwings
82958a11cb Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553340 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:55:17 +00:00
kiwiwings
ad9cecae59 Patch for Bug/Enhancement 55818 - add encryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553336 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:13:21 +00:00
Nick Burch
01378c8acc Don't use the degree symbol in comments, as it upsets the compiler, and causes the javadoc tool to error. Use the word degrees instead, much safer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1550351 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-12 05:29:11 +00:00
Dominik Stadler
76c0cfc2c9 Refactor XSSFExportToXml a bit, split code into more methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1549008 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-08 08:39:10 +00:00
Dominik Stadler
2a08a1dd10 Bug 55850: fix NullPointerException during extraction from XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1549007 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-08 08:35:20 +00:00
Dominik Stadler
18f9a3e88e Bug 55640, added reproducer, a fix for the Exception cases and some verify-tests to ensure future 
changes are checked via unit tests. There might be more work pending to
make grouping fully work the same way as Excel does.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1547153 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-02 19:14:03 +00:00
Dominik Stadler
5511c6dbcc Bug 55745: fix handling of tables in XSSF if there are comments as well, add testcase which was committed to the wrong tag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1546458 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-28 21:19:34 +00:00
Dominik Stadler
6618473e64 Bug 55745: fix handling of tables in XSSF if there are comments as well, there is not much sense in leaving the loop on the first instance of comment table and skipping all the other tables. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1546385 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-28 15:15:59 +00:00
Cédric Walter
73ee268e56 Bug 55768: added Line charts support and setting axis tick marks, title 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544628 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 18:26:11 +00:00
Cédric Walter
e9b8faa748 Bug 54676: added new chart axis type: Category axis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544612 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 17:45:00 +00:00
Nick Burch
44c9f41cc9 Patch from Andreas Beeker from bug #53475 - Switch XWPF test to JUnit 4, so that we can skip one part of the tests if the JVM doesn't support larger keys 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544121 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-21 11:18:23 +00:00
Nick Burch
d1118ce0d5 Patch from Andreas Beeker from bug #53475 - further OOXML Encryption support, covering more ciphers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541009 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 11:37:45 +00:00
Nick Burch
e2e04b0ebc Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541005 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 11:32:10 +00:00
Nick Burch
16eb9990bc More JavaDoc tweaks, and suppress deprecated warnings where these are expected 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540989 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:55:46 +00:00
Nick Burch
c6dde74f4f Consistent indenting, based on current POI style guide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540987 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:53:57 +00:00
Nick Burch
381cc611d7 Fix some JavaDocs, and add a generic constructor based on ZipEntrySource 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540986 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:51:13 +00:00
Nick Burch
6780a911e2 Reduce duplication by replacing lots of deprecated methods with calls to their replacement (which is basically the same code anyway) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540878 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-11 23:08:36 +00:00
Nick Burch
0457300fdf Try to make a few OPCPackage error messages more helpful, and slightly reform the configure code block to make it hopefully easier to read 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540877 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-11 23:03:00 +00:00
Yegor Kozlov
9b3a2ccb82 Patch 53176 - Fixed auto shapes render problem in pptx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540290 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-09 11:32:55 +00:00
Nick Burch
4ae76ffddc Unit tests for Shrink To Fit cell style support (#55661) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539850 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 22:39:11 +00:00
Nick Burch
c6177274af Start on HSSF/XSSF Shrink To Fit support, see bug #55661 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539848 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 22:28:06 +00:00
Nick Burch
f7b44f5e9f Patch from Andreas Beeker from bug #53475 - CSPName may not always be present on OOXML encrypted documents, plus test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539828 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 21:29:14 +00:00
Cédric Walter
3976993fda Bug 54696: Add overlay setting to ChartLegend 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539169 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 22:35:54 +00:00
Nick Burch
a6b301e485 Fix bug #55733 - XWPFWordExtractor need 
s to handle .docx files with neither headers nor footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538044 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-01 19:43:46 +00:00
Dominik Stadler
d08ab9dc0d Slightly more test-coverage in HSSFSheet/XSSFSheet/SXSSFSheet and fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1537331 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-30 22:26:13 +00:00
Dominik Stadler
0342f9602d Add reproducer tests for Bug 53515, disabled as we do not fix any of the 
reported issues. Also fix some Ecliipse warnings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535959 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-26 10:05:24 +00:00
Dominik Stadler
5644fcbaa0 Bug 49940: Apply patch to avoid XmlValueDisconnectedException when 
saving a file twice and enable reproducing unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535938 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-26 07:31:47 +00:00
Dominik Stadler
5ad89d96b6 Fix some Eclipse warnings, remove trailing whitespaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535517 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-24 19:58:19 +00:00
Nick Burch
b646166b6c Have HSSFWorkbook check for an encrypted .xlsx file when opening, and give a helpful error if found, plus tests. Fixes #55692 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534967 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-23 09:43:28 +00:00
Nick Burch
5ac455fd72 Patch from bug #55650 from Andrej - Avoid AIOOBE if a non-existant Xfs is requested for a styleAvoid AIOOBE if a non-existant Xfs is requested for a style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534818 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-22 22:04:16 +00:00
Dominik Stadler
1bf79ee0cf Bug 55369: Add support for collapsing rows in SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533932 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-20 18:04:08 +00:00
Dominik Stadler
3b4538cfb4 Bug 55658: don't fail in SXSSF if a numeric cell is overwritten with a string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532873 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-16 19:47:21 +00:00
Dominik Stadler
9d98d6e309 Change from having actual zero bytes in java code to java-string notation for unicode-zero to avoid trouble with this file in Sonar when using PostgreSQL (which seems to fall over binary data in text files). The resulting test should be the same with the \u0000 notation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532037 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-14 19:44:30 +00:00
Dominik Stadler
43b74b0253 Apply patch from bug 55341 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527397 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-29 20:23:20 +00:00
Dominik Stadler
4a3c974e3b Remove Eclipse warnings, remove duplicate test, rename tests to also run tests in base class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521015 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-09 09:41:31 +00:00
Dominik Stadler
e6ed66a126 Bug 53798: Add fix for XmlValueDisconnectException during shifting rows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521012 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-09 09:24:05 +00:00
Dominik Stadler
17e8880dcd Bug 54524: Fix border case in FormulaShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517676 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-26 20:09:19 +00:00
Dominik Stadler
18d369ed86 Exclude TestUnfixedBugs from OOXMLLite to avoid confusing output in ant-build of ooxml-lite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517179 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-24 18:32:45 +00:00
Dominik Stadler
b79d4fda52 Tried to reproduce Bug 47090, but seems to be fixed now. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516982 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:56:32 +00:00
Dominik Stadler
13e08c3e92 Add testcase which tries to reproduce Bug 48495, but seems to be fixed 
now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516981 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:56:11 +00:00
Dominik Stadler
f8f998b80b Some Eclipse warnings removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516980 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:54:05 +00:00
Dominik Stadler
bff0813e48 fix some Eclipse warnings, adjust some unit tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516818 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 10:44:39 +00:00
Dominik Stadler
134195c86c Also fix some Eclipse warnings while hunting Bugs: Generics, unused 
variables, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516312 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:06:07 +00:00
Nick Burch
75a56dcf22 Push the fix for bug #55248 up to the Sheet interface (was XSSF only before) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 09:41:15 +00:00
Dominik Stadler
9e62269eef Bug 52233: try to fix this without breaking the format of xlsx-files. 
The set to null is necessary to not have an empty <cols/> element in the
xlsx, however later on stuff breaks if no colsArray is availalbe,
therefore we now re-create the empty cols array if we did remove it
before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515916 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-20 18:44:44 +00:00
Dominik Stadler
4a675204cb Revert changes from rev. 1513916 as it severly broke writing valid xlsx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515842 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-20 15:03:18 +00:00
Dominik Stadler
17f3b2cb26 Bug 52233: Do not make the XSSFSheet invalid during write(), I could not find out why the ColsArray was set to null in the write() method. By removing this the writing of the sheet does not invalidate the Workbook any more and makes the test case work fine. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513916 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-14 14:57:44 +00:00
Dominik Stadler
2834048155 Various small Eclipse warning fixes, 
also ensure close() of stream in Ant-Task, although WorkbookFactory usually takes care of this, however in exception-cases it could be missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513764 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-14 08:25:51 +00:00