Greg Woolsey
123c0e1e6c
Fixed #60858 , which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822 .
...
Includes new unit test based on the bug sample file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786954 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:40:32 +00:00
Greg Woolsey
6349d2c614
Fixed #60858 , which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822 .
...
Includes new unit test based on the bug sample file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af
Fix some Sonar issues in sample "HSSFReadWrite"
...
Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 14:09:27 +00:00
Dominik Stadler
699ddabcdf
Gradle Build: Try with setting baseDir for Sonar-runs, but likely still does not work
...
Update wrapper to 3.4.1, although we do not store it yet anyway
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786681 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 13:20:51 +00:00
Dominik Stadler
7ae44605b5
Jenkins DSL: Fix setting property for Sonar-Host-URL
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786670 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 12:18:21 +00:00
Dominik Stadler
abc3d37adc
Add tests from bug 45353 to show that this now works fine
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:14:00 +00:00
Dominik Stadler
c07c41659f
HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:52 +00:00
Dominik Stadler
69b260f538
Allow to enable Sonar as part of the Gradle build and add Jenkins DSL job to test it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786430 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:46 +00:00
Dominik Stadler
aafdbdfdd7
Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:39 +00:00
Dominik Stadler
566ec2d487
Jenkins DSL: Exclude some more slaves from building with OpenJDK
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786230 13f79535-47bb-0310-9956-ffa450edef68
2017-03-09 19:50:17 +00:00
Tim Allison
b442671274
51519 -- follow on, make concatenation of rPh configurable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786021 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 16:44:40 +00:00
Tim Allison
5bb1195606
51519 -- allow users to ignore or include the <rPh> (phonetic run) element in the ReadOnlySharedStringsTable used in the SAX/streaming xlsx reader.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785965 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 13:41:07 +00:00
Javen O'Neal
8dd5f7b887
store repeated expressions as temporary variables to make code shorter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785793 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 03:16:50 +00:00
Javen O'Neal
5b879942fc
bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
2017-03-02 18:47:28 +00:00
Tim Allison
31dd2885dd
Bug 60795 -- fixed deprecation, thanks to Javen.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784989 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 16:49:15 +00:00
Tim Allison
5b801a9dc6
Bug 60795 -- add enum for message class in MAPIMessage; deprecate getMessageClass()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784978 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 15:47:47 +00:00
Javen O'Neal
11c3e70963
fix formatting: 2nd level indentation
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784505 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 05:56:41 +00:00
Javen O'Neal
5d02b91900
add repo location of unit test code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784504 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 05:52:50 +00:00
Javen O'Neal
b36923b7e1
fix formatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784503 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 05:37:43 +00:00
Javen O'Neal
7051715662
fix formatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784502 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 05:36:19 +00:00
Javen O'Neal
9ec3177109
add README.rst to make project more accessible to GitHub users
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784501 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 05:35:19 +00:00
Javen O'Neal
a376255e83
copy .gitignore from svn-props
...
svn propget svn:ignore . > .gitignore
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784493 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 04:18:46 +00:00
Javen O'Neal
bb6e94851f
add helper functions to make it easier to see which scenarios are being tested
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784231 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 05:07:10 +00:00
Javen O'Neal
c04e2a314a
bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8
add javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9
Add null check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:18:10 +00:00
Dominik Stadler
b17701cd14
svn-ignore 'sonar/target'
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783831 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 06:29:53 +00:00
Dominik Stadler
efc0dd2d50
Jenkins DSL: Add one more directory for test-results to try to make Gradle build happy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783830 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 06:28:12 +00:00
Andreas Beeker
0744f73add
BugFix for JDK-6623219
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
2017-02-19 21:36:45 +00:00
Andreas Beeker
7810671d2d
#60662 - Slide import delete unrecognized elements in group shape
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783486 13f79535-47bb-0310-9956-ffa450edef68
2017-02-18 01:07:47 +00:00
Javen O'Neal
9783654301
bug 60742: remove commented out debugging code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 20:53:44 +00:00
Dominik Stadler
feee2b88c8
bug 60742: Remove local test-code from test for bug 60512
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783428 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 17:15:27 +00:00
Javen O'Neal
b2206fc40f
bug 60742: write out to unit test TempFile rather than Unix-only /tmp/60512.xlsx; patch from Chiara Marcheschi
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783426 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 16:57:43 +00:00
Javen O'Neal
7fcaaa9479
bug 59893: close open resources to prevent leaks
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783362 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:53:49 +00:00
Javen O'Neal
85a30f16cf
convert from junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783360 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:37:00 +00:00
Javen O'Neal
ee6677ee56
bug 59893: fix a few forgotten unrelated changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:25:49 +00:00
Javen O'Neal
1584310ac5
bug 59893: more unrelated changes from Andi
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783353 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:08:21 +00:00
Javen O'Neal
8677d099fc
bug 59893: commit the changes from attachment 34068 that were unrelated to available()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 08:39:05 +00:00
Javen O'Neal
0443c27ede
OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when executing TestAllFiles
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783174 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:15:13 +00:00
Javen O'Neal
c1b350201c
test-integration: replace redundant static { EXPECTED_FAILURES.add(...) } with (dynamic) Arrays.asList() to improve code legibility.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783171 13f79535-47bb-0310-9956-ffa450edef68
2017-02-16 06:08:44 +00:00
Greg Woolsey
ba7809d69a
a new test file needed to be added to the list of sheet clone expected errors.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783129 13f79535-47bb-0310-9956-ffa450edef68
2017-02-15 17:48:46 +00:00
Dominik Stadler
12c06b3084
Jenkins DSL: Use latest JDK 1.9 pre-build and exclude some more slaves for the OpenJDK build
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783098 13f79535-47bb-0310-9956-ffa450edef68
2017-02-15 12:13:34 +00:00
Greg Woolsey
ca399b4f42
Bug #56822 fix COUNTIFS()
...
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b
Bug #56822 fix COUNTIFS()
...
includes unit test from the issue. Verified unit test results in Excel vs. incorrect previous POI results. Test passes new code, as do existing tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78
Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d
Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae
Expose Priority from newer-style HSSF CF rules
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 17:49:13 +00:00
Greg Woolsey
c88649ccd2
Ugh, that's what I get for copying someone else's code without fully reviewing it. Return the boolean property, don't wrap it in an extra if().
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782989 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:49:24 +00:00
Greg Woolsey
05125678ab
Expose another common property, strikeout.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:45:47 +00:00
Greg Woolsey
653c627b1f
use Ant 1.9.9 explicitly, since Ant (latest) is now 1.10.1 which requires Java 8.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782983 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:18:55 +00:00