be70120ee5
Use Service.onStartCommand() instead of deprecated Service.onStart()
2011-11-10 06:36:14 +01:00
8c8b3eea9e
Use Intent.ACTION_SEND_MULTIPLE instead of string constant
2011-11-10 05:44:30 +01:00
07fa0c7264
Use Build.VERSION.SDK_INT instead of parsing Build.VERSION.SDK
2011-11-10 05:39:04 +01:00
14ff4d006e
Removed onBackPressed() magic
2011-11-10 05:38:52 +01:00
85f556e6c9
Removed helper function to create AbsoluteSizeSpan objects
2011-11-10 05:38:51 +01:00
5eb2533bcb
Removed code for old contacts API (ContactsSdk3_4)
2011-11-10 05:05:06 +01:00
c5cc62b570
Removed AutoSyncHelper and use API 5 methods directly
2011-11-10 05:05:05 +01:00
a2fcb54507
Merge pull request #95 from ashleywillis/reply-after-quote
...
added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);"
2011-11-07 15:51:05 -08:00
ef631e21d1
Merge pull request #83 from andrewachen/messageview_save_location
...
Restore position in MessageView after rotation screen.
2011-11-07 09:57:18 -08:00
efe591c34d
added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);" because bodyOffset could refer to header or footer
2011-11-07 01:59:03 -06:00
6497ac4cf4
Default authentication type for SMTP is automatic
2011-11-07 01:58:38 +01:00
6d9463801e
Don't call promptForServerPasswords() if we already know all passwords
2011-11-07 01:45:52 +01:00
d6c03de6f5
Fixed logic bug that prevented imported accounts from being recognized
...
We have to add new account UUIDs to "accountUuids" for them to show up
in the account list.
2011-11-07 01:45:52 +01:00
e2e9f8b6a3
Fixed startActivityForResult() failing for MessageList
...
Fixes issue 3638
2011-11-07 00:07:06 +01:00
7ca72b9d0f
Work around broken office suites by sending an explicit mime type with files we open
2011-11-06 17:00:25 -05:00
70dc27c481
Make MimeUtility.getMimeTypeForViewing() return lower case MIME types
...
MIME type matching in Android is case-sensitive. So we convert the MIME
types we read from the email to lower case.
2011-11-06 02:05:47 +01:00
88a2dd6289
Merge branch 'issue549'
...
Conflicts:
src/com/fsck/k9/Account.java
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-05 18:47:55 +01:00
4a1046a893
Merge pull request #93 from andrewgaul/cursor-close-quietly
...
Introduce and use Utility.closeQuietly(Cursor)
2011-11-04 16:20:22 -07:00
39aa577651
Introduce and use Utility.closeQuietly(Cursor)
...
This helper is in the same spirit as IOUtils.closeQuietly.
2011-11-04 09:58:55 -07:00
2b77c6e35c
moved code from onStop() to onPause() since onStop() may never be called.
2011-11-04 02:33:56 -05:00
d301089f3c
Avoid string concatenation in String.format
2011-11-03 18:47:34 -07:00
5d9bf309c9
Avoid NullPointerException in services when process/service is restarted
...
See issue 3750
2011-11-03 22:10:24 +01:00
7f582f5a38
added mIgnoreOnStop for when adding an attachment.
2011-11-03 15:38:53 -05:00
f6eea9f014
Move the listener logic out of the Activity and into the View.
...
Change variable naming in ToggleScrollView to meet standard.
Cache the result of computeVerticalScrollRange() in ToggleScrollView.
2011-11-03 09:14:42 -07:00
57e0abbf8f
Merge pull request #84 from andrewgaul/api7
...
Use LinkedList instead of Deque.
2011-11-03 07:41:09 -07:00
981dc6cca6
Merge pull request #92 from andrewgaul/remove-combine-uuids
...
Prefer Utility.combine over Account.combinedUuids
2011-11-03 06:41:33 -07:00
7f046e5f0a
Merge pull request #91 from andrewgaul/findbugs-stream-close
...
Improve the way we open/close streams.
2011-11-03 06:40:07 -07:00
d80e5bfbd0
Merge pull request #90 from andrewgaul/close-quietly
...
Call IOUtils.closeQuietly instead of using empty try/catch block.
2011-11-03 06:35:42 -07:00
64b299ebec
Merge pull request #89 from andrewgaul/is-empty
...
Prefer Collection.isEmpty over size
2011-11-03 06:34:15 -07:00
9e74f9ffcf
Merge pull request #88 from andrewgaul/log-throwable
...
Log Throwables instead of concatenating
2011-11-03 06:32:20 -07:00
64e2247e8f
Merge pull request #87 from andrewgaul/map-initialization
...
Optimize static map, remove unneeded inner class, and use unmodifiable map.
2011-11-03 06:31:32 -07:00
8dccc7a996
Merge pull request #86 from andrewgaul/findbugs-concatenation
...
Prefer StringBuilder.append over String.concat
2011-11-03 06:28:51 -07:00
c2e9e4b345
Prefer Utility.combine over Account.combinedUuids
2011-11-02 22:57:06 -07:00
b53b0d33ba
Close streams on exceptional paths
...
Addresses FindBugs complaints.
2011-11-02 22:48:37 -07:00
b1a807a712
Call IOUtils.closeQuietly where appropriate
2011-11-02 22:22:15 -07:00
2599bdcc75
Log Throwable instead of concatenating
2011-11-02 22:18:30 -07:00
70b635ec30
Initialize static map optimally
...
Remove unneeded inner class, use unmodifiable map, and mark as static.
2011-11-02 22:16:12 -07:00
cb14cd9d78
Prefer StringBuilder.append over String.concat
...
Addresses FindBugs complaints.
2011-11-02 22:10:02 -07:00
61c850e077
Remove dead stores
...
Addresses FindBugs complaints.
2011-11-02 22:02:41 -07:00
98d0b61890
API 7 fixes
2011-11-02 20:47:48 -07:00
647ae0a31c
Prefer Collection.isEmpty over size
2011-11-02 20:03:07 -07:00
674c39f3d5
Merge pull request #80 from andrewachen/unify_gesturedetector
...
Make the K9Activity.GestureDetector reusable
2011-11-02 18:04:01 -07:00
1e9a40ffd2
Merge pull request #81 from aatdark/issue3814
...
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 17:55:58 -07:00
68cecb168e
added testcases for address#parse function,changed empty to null (conforms to existing code)
2011-11-03 01:36:57 +01:00
763ff2752d
Scroll to the last known position in the MessageView when rotating the screen.
2011-11-02 16:39:23 -07:00
b5dca5cf68
Merge pull request #76 from sunglim/string_util
...
Added StringUtils.isNullOrEmpty().
2011-11-02 10:50:52 -07:00
66881c0f2b
Merge branch 'master' of git@github.com:k9mail/k-9.git
...
* 'master' of git@github.com:k9mail/k-9.git:
Optimize java.util.* imports.
2011-11-02 08:37:12 -07:00
f884e967c9
Use MimeHeader.* constants when referring to content headers. Minor whitespace changes.
2011-11-02 08:34:06 -07:00
a021ab71de
Override onStop() to save email as draft when activity is changed (go to home screen, call received)
2011-11-01 22:12:51 -05:00
6a76b073c3
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 02:08:06 +01:00
30151f1a70
Add parameter to MyGestureDetector to enable gestures for a specific detector, even if system-wide gestures are disabled.
2011-11-01 17:25:49 -07:00
edd78ea10c
Make the K9Activity GestureDetector more generic so that it can be used by both MessageList and MessageView.
...
Make the mTopView a ToggleScrollView. The only consumer is currently the MessageView, which uses a ToggleScrollView anyway. This should make it easier to reuse the anti-scrolling features in ToggleScrollView for ListView later on.
2011-11-01 16:55:13 -07:00
406aae6e61
Optimize java.util.* imports.
...
Conflicts:
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-01 13:54:55 -07:00
ea05f3b5d0
Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul
...
* 'legacy-collections' of https://github.com/andrewgaul/k-9 :
Prefer unsynchronized Collection types
2011-11-01 13:26:54 -07:00
186b65e523
Merge pull request #70 from andrewgaul/combine-one-element
...
Optimize Utility.combine for length 1 arguments
2011-11-01 12:51:44 -07:00
4395da270d
Merge pull request #77 from andrewgaul/findbugs-entryset
...
Prefer entrySet over keySet and get
2011-11-01 12:44:26 -07:00
57b9321a1e
issue-1424: saving duplicate or similar drafts fixed.
2011-11-01 03:02:29 -05:00
773f2e8870
Prefer Integer.valueOf over explicit boxing
...
Addresses a FindBugs complaint.
2011-10-31 21:58:32 -07:00
bfd11c444f
Prefer entrySet over keySet and get
...
Addresses FindBugs complaints.
2011-10-31 21:42:12 -07:00
8ab10a7586
applied StringUtils.isNullOrEmpty()
2011-10-29 15:12:49 +09:00
807907cb9e
Merge branch 'master' into issue549
...
Conflicts:
res/values/strings.xml
src/com/fsck/k9/service/MailService.java
2011-10-29 05:22:07 +02:00
f345c33728
Removed useless try block
2011-10-29 05:10:13 +02:00
2d1f9f9c84
Reworked MailService to cut overhead when executing background tasks
...
Since MailService uses the auto shutdown mode of CoreService we can't
use CoreService.execute() with a startId parameter that is null. So this
change should also fix the problem some users reported where the pushers
weren't set up correctly.
See issue 2777
2011-10-29 05:08:37 +02:00
74f7abaec2
Cosmetic changes and documentation updates/fixes
2011-10-29 05:00:37 +02:00
987a1ea511
Merge branch 'master' of ssh://github.com/k9mail/k-9
2011-10-29 03:09:15 +02:00
7e1c19d4d8
Cosmetic changes - kill whitespace at the end of lines
2011-10-28 21:29:39 +02:00
f24d4c9155
Merge pull request #72 from andrewgaul/remove-literal
...
Remove unused literal methods
2011-10-27 23:32:28 -07:00
e3f6561008
Don't crash when trying to connect to an non-SSL service using SSL
...
Fixes issue 3798
2011-10-28 04:59:08 +02:00
7903797080
stringutils
2011-10-28 03:50:23 +09:00
91ee21bb2d
Use "String.length() == 0" instead of String.isEmpty() [API 9+]
2011-10-27 19:11:44 +02:00
b69d6cb64c
Use Locale.US with toUpperCase() and toLowerCase() where appropriate
2011-10-27 17:17:43 +02:00
9327c86fe7
Use Locale.US when calling toUpperCase() on the generated MIME boundary
...
Fixes issue 3733
2011-10-27 16:52:27 +02:00
d3baa299f1
Use "reply after quoted text" value when editing drafts
2011-10-27 08:20:03 +02:00
f4f726ae67
Fixed restoring drafts saved with "reply after quoted text" enabled
...
Fixes issue 2568
2011-10-27 07:23:01 +02:00
b6cdec43e9
Merge pull request #73 from andrewgaul/address-parse-npe
...
Fix NPE in Address.Parse
2011-10-26 18:15:40 -07:00
ad5676ed28
Fix NPE in Address.Parse
...
Found by FindBugs. Also avoid an allocation in the uncommon case.
2011-10-25 21:24:38 -07:00
e394924ce4
Prefer Random.nextInt over Math.random
...
Addresses a FindBugs complaint.
2011-10-25 21:21:23 -07:00
ae465789b7
Export default value for keys not found in preference storage
2011-10-26 05:13:22 +02:00
a2d0f9ccb7
Remove unused literal methods
2011-10-25 13:56:07 -07:00
844db81b8d
Optimize Utility.combine for length 1 arguments
2011-10-25 13:10:47 -07:00
ae3f098b4a
Merge pull request #64 from andrewgaul/typesafe-set
...
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
ea384b40a1
Merge pull request #66 from andrewgaul/redundant-combine-flags
...
Remove duplicated combine flags code
2011-10-20 05:33:37 -07:00
4c5f2e59a0
Remove unused Utility.readInputStream
...
Consider IOUtils.toString instead.
2011-10-19 23:11:03 -07:00
5b9f542bd7
Avoid type-unsafe Set
2011-10-19 23:05:34 -07:00
ce4b42f66b
Remove duplicated combine flags code
2011-10-19 22:04:57 -07:00
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
afd355f83c
Use Preferences.getAvailableAccounts() where appropriate
2011-10-18 05:09:20 +02:00
4d6946f47c
Start services and list folders after account has been activated
2011-10-18 05:06:32 +02:00
dd8cd33c5a
Fixed decoding of store URIs with empty passwords
2011-10-18 05:05:40 +02:00
9fa802afe2
Validate file format version and content version of settings file
2011-10-18 01:30:41 +02:00
e7ad0e296e
Validate account UUID on import
2011-10-17 23:33:32 +02:00
6b5b4e474e
Fixed store URI encoding/decoding in Pop3Store
2011-10-17 05:59:36 +02:00
d87e25dde1
Added new authentication methods to SmtpTransport.createUri()
2011-10-17 04:57:01 +02:00
75dc38a1c4
Added new settings to GlobalSettings
2011-10-17 04:52:33 +02:00
f08b1ef739
Added new settings to AccountSettings
2011-10-17 04:34:26 +02:00
3967654a3e
Show short message when moving accounts
2011-10-17 04:34:26 +02:00
52a92d93a1
Add dialog to ask for server passwords after import
2011-10-17 04:34:26 +02:00
849a4e37a0
Mark accounts as disabled on import
...
If the settings file doesn't contain passwords for the incoming and
outgoing servers we disable those accounts.
2011-10-16 19:24:31 +02:00
fc8d2e9979
Merge branch 'master' into issue549
...
Conflicts:
res/menu/accounts_context.xml
res/menu/accounts_option.xml
res/values/strings.xml
src/com/fsck/k9/Account.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/AsyncUIProcessor.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/ImportListener.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/Pop3Store.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-10-14 20:33:25 +02:00
effb45c463
Cleaned up success message after settings import
2011-10-14 06:19:30 +02:00
f5e684310e
Renamed StorageImportExportException to SettingsImportExportException
2011-10-14 06:00:10 +02:00
c835bb757a
Renamed StorageImporter to SettingsImporter
2011-10-14 05:58:55 +02:00
cf8bdef0a8
Renamed StorageExporter to SettingsExporter
2011-10-14 05:58:15 +02:00
0ae176bab3
Code/documentation cleanup. No functional changes.
2011-10-14 05:54:23 +02:00
470ba8bb03
Removed everything related to settings file encryption
...
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
2011-10-14 05:38:27 +02:00
fd16ff8fe6
Remove reference to NonConfigurationInstance when no longer needed
2011-10-14 04:15:45 +02:00
5b81dbc2ed
Use resource strings instead of hardcoding things
2011-10-14 03:42:04 +02:00
b146fcb2fd
Improved handling of object retention on configuration changes
2011-10-14 02:52:32 +02:00
b05750c245
Better input validation in *Store.createUri()
2011-10-13 02:35:08 +02:00
2058fc378d
Option to show next message after delete by default instead of previous.
2011-10-12 17:50:24 +02:00
a258415629
Merge pull request #60 from andrewgaul/builder-append-no-concatenation
...
Avoid concatenation in StringBuilder append
2011-10-12 08:28:32 -07:00
c34d896474
Merge pull request #59 from andrewgaul/immutable-sets
...
Make sets immutable
2011-10-12 08:26:43 -07:00
4c8ebb4bcd
added check for Null
2011-10-11 08:53:51 +02:00
7a9c747db9
Don't export incoming/outgoing server passwords
2011-10-11 03:12:18 +02:00
1de28150e2
Require accounts to at least have one identity when importing
2011-10-09 01:23:45 +02:00
13b74d0d9e
Added error logging
2011-10-09 01:14:59 +02:00
d791770154
Code cleanup
2011-10-09 00:31:33 +02:00
6714a7ec5a
Improved logging in StorageImporter
2011-10-09 00:04:00 +02:00
1ab7dbae54
Added input validation for folder settings
2011-10-08 21:30:45 +02:00
f21e14afc7
Added input validation for identity settings
2011-10-08 17:58:57 +02:00
060d21db3e
Make collections immutable
2011-10-07 21:20:12 +02:00
0920b0c14d
Changed the way SettingsDescription is used
...
Added ability to rewrite the string representation used internally to
something "pretty" on export.
Now only settings that have entries is GlobalSettings and
AccountSettings are exported. This prevents export of newer settings
that are left in the preference storage when downgrading.
2011-10-07 20:29:03 +02:00
57be9e3ee3
Make sets immutable
...
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
9b27aba2ba
Avoid concatenation in StringBuilder append
2011-10-06 09:20:11 -07:00
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
31af4526ab
Merge pull request #58 from andrewgaul/spelling
...
Spelling corrections
2011-10-06 09:01:37 -07:00
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
dad0332667
Make an inner class static
2011-10-05 22:01:53 -07:00
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
83ee4253d5
Whitelist settings for export instead of blacklisting keys
...
Use GlobalSettings.SETTINGS an AccountSettings.SETTINGS to decide
which settings to export.
2011-10-04 05:13:17 +02:00
644571cfe5
Make sure the InputStream of the import file is always closed
2011-10-04 00:48:43 +02:00
f2a3752930
Added constants for (export) file format version and "settings version"
2011-10-04 00:09:38 +02:00
33ae5ff7d0
Added code to skip some account settings on export
2011-10-03 20:16:02 +02:00
0619eaf79c
Catch NumberFormatException when parsing disposition size parameter
...
Fixes issue 3712
2011-10-01 21:17:00 +02:00
88dc36da8a
Added a check to prevent an ArrayIndexOutOfBoundsException
...
Fixes issue 3683
2011-10-01 20:30:22 +02:00
dfa97cd878
Handle activity restarts due to configuration changes
...
Close existing dialogs before the activity is destroyed. Recreate them
and rewire AsyncTasks to the new activity instance after its creation.
2011-10-01 20:11:14 +02:00
6e1bf2965d
Fixed DateFormatValidator to handle placeholders SHORT and MEDIUM
2011-09-30 16:54:01 +02:00
cd72e197ec
Added code to skip certain settings on export
2011-09-30 16:47:59 +02:00
c76bec971b
Fixed compiler warning
...
Use new variable instead of overwriting an argument.
2011-09-30 14:58:13 +02:00
defabdc20c
Additional service fixes from the original author of the issue 2777 fix
...
to stop the service from being shutdown when we have push enabled
2011-09-29 00:16:27 -04:00
fd61b4f20b
Merge pull request #52 from andrewgaul/peekable-bad-offset
...
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
7cf1bfcc98
Fix bad offset in PeekableInputStream
2011-09-20 21:21:50 -07:00
f3795f3df5
Search same sender from searchable folders instead of the unified inbox
2011-09-16 01:33:51 +09:00
dd1334b874
Add some JavaDoc to SearchAccount stuff; astyle.
2011-09-12 15:08:34 -07:00
cbaa9f5b3d
Work around cases where mail was last checked in the future.
...
Sometimes, user devices will have their clock misset. Previously, K-9
would just stop checking mail until the device caught up with the
future.
2011-09-05 22:16:04 -04:00
7d5bb99dbd
Add progress indicator during account move.
2011-09-05 12:45:53 -05:00
2867a90286
Disable account move menu items when account is at an end of the list.
...
Conflicts:
src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
06cabdbde1
Working version of moving accounts within the Accounts view.
2011-09-05 12:38:03 -05:00
c67ac4735f
Fixes Issue 3177
...
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes. This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count. If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
50e6218c1d
Merge pull request #49 from senab/master
...
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-04 18:44:08 -07:00
8223e4d4bf
Removed some doc annotations from chrisk's fix for the service stopping
...
issue (2777)
2011-09-04 16:13:19 -04:00
7cd6334c64
Stop service(s) if not in use - Fixes Issue 2777
2011-09-04 16:00:02 -04:00
1b7481f854
optimize cketti's pop3 space-splitting code to not make lots of extra
...
copies of responses.
2011-09-04 15:53:12 -04:00
b002f3178b
Move Sender Address to end of Default Projection
2011-09-02 11:33:20 +01:00
caa02b16eb
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-01 11:57:06 +01:00
f6a647d7b0
Cosmetic changes
2011-08-31 02:17:45 +02:00
e9e9d5afcb
Removed unused method
2011-08-31 02:12:01 +02:00
dfc370c057
Merge pull request #42 from jca02266/wip-fix-activity-switching-for-message-view
...
Fix for message list opening the wrong message view
Fixes issue 3592
2011-08-30 17:09:11 -07:00
16c1f9c35b
Add the remaining two return receipt headers upon request.
2011-08-28 16:08:41 -07:00
1ac652dc5f
Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers.
2011-08-28 18:28:12 -04:00
a1378789b2
Merge pull request #48 from rpimonitrbtch/master
...
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames.
Resolves Issue 2784: Cannot set server hostname
2011-08-28 12:48:10 -07:00
bdcb19e344
Issue 2784: Cannot set server hostname
...
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames. Removed the localhost and localhost.localdomain exceptions, as they are now redundant.
2011-08-28 15:24:52 -04:00
f5c679fb95
Added support for requesting read receipts
2011-08-27 20:46:04 -04:00
47bedec410
Fixed an issue which caused space characters to throw exceptions when being parsed. Some cosmetic changes, and context sensitivity for EXISTS, RECENT and EXPUNGE responses which have empty token lists.
2011-08-04 23:30:27 +05:30
9335dacd46
Added a separate handler for status responses to parse the resp-text tokens contained in these responses.
2011-08-02 02:19:12 +05:30
be1be56e3a
Fixed bug where uid in response was truncated
...
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
cf39070048
Whitespaces :/
2011-07-25 18:56:21 +05:30
3679b31b12
Workaround for market-reported error:
...
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
2011-07-25 01:49:42 -04:00
da9a5e6c17
Made some cosmetic changes for clarity, added debug messages for erroneous conditions. Fixed potential NPE in ImapFolder.parseSequenceSet().
2011-07-25 06:50:26 +05:30
7b7601082b
the refactoring to combine batch and record logic added an extra check
...
that broke delete of single messages from message list.
2011-07-23 18:45:43 -04:00
fda43206a3
Fixed the below issue for GalaxyS and S2.
...
When scrolling a ListView, all items turn black.
it was reproduced on FolderList, MessageList and Accounts, other views were not.
2011-07-20 22:13:20 +09:00
0543183b11
Work around a weird NPE in WebDAV sync reported by Jon Blow
2011-07-19 22:43:32 -04:00
8d264b159e
Workaround for below issue.
...
1. Show a message in MessageView.
2. Press HOME button to back home.
3. Re-launch the K-9 and select another message.
4. Show first selected message.
See also: https://github.com/k9mail/k-9/commit/fix_activity_stack
2011-07-18 00:59:30 +09:00
2acd55a9ef
Implemented work-around to handle malformed UIDL responses (POP3).
...
Fixes issue 3546
2011-07-17 14:37:21 +02:00
9f581cb6f3
Extracted POP3 commands and capabilities to constants
2011-07-17 14:13:04 +02:00
45e29ccba4
Fixed issue 3530.
...
Should not HTMLify the message when it is sent without quoted message.
The problem is:
1. set MessageFormat in Account setting to the TEXT.
2. reply a message without quoted text.
3. it is sent with HTML tags.
2011-07-17 08:56:28 +09:00
adc7d65d09
Newline :/
2011-07-17 01:42:12 +05:30
c6a2cb48b1
Added method to check for status response.
2011-07-17 01:41:14 +05:30
021d5641e5
ant astyle
2011-07-17 01:40:20 +05:30
2e173150d5
Rather than disabling imap-specific preferences on POP3, hide em
2011-07-13 22:15:36 -04:00
87640719dd
Disable "download by date range" for webdav and pop3.
...
The previous behavior caused catastrophic network abuse, downloading
messages outside the date range over and over.
2011-07-12 22:05:49 -04:00
b85c9b7b0e
Work around the fact that when we can't get read status for a message,
...
we'd end up with an NPE as we then queried the hashmap
2011-07-11 11:08:20 -04:00
98ae8cf2be
refactoring to use the object we extracted from the array
2011-07-11 11:08:20 -04:00
d7dfba15cf
It appears that Exchange is returning responses
...
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
2011-07-09 17:00:35 -04:00
220be75473
Add a bit of logging to find out what webdav servers tell us about how
...
many messages they have in debug mode
2011-07-09 16:24:18 -04:00
8cffc5b682
Bullet proofing for user-reported exceptions in WebDAV sync:
...
E/k9 ( 5735): java.lang.NullPointerException
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9 ( 5735): at java.lang.Thread.run(Thread.java:1096)
2011-07-09 15:26:30 -04:00
c7e8969b01
remove a bunch of listener notification duplication that crept into the
...
code. this caused all attachments to be double-opened, among other
things
2011-07-09 00:27:56 -04:00
a60a2a4295
Changed code to show/hide the correct views for CC/BCC
...
Fixes issue 3509
2011-07-07 04:59:45 +02:00
d310167b99
Rewrite mime type image/pjpeg to image/jpeg
...
Fixes issue 1712
2011-07-07 03:05:12 +02:00
b02b895aaf
Add 2MB, 5MB and "All" message download options
2011-07-02 15:29:49 -04:00
2a698f1ab9
ant astyle
2011-07-02 15:18:43 -04:00
3321ebdc33
COPYUID changes were being updated only in memory, but were not being written to db.
2011-07-02 11:59:00 +05:30
bc9b7030d7
COPYUID implementation now in place and working, restructured appendMessages, copyMessages and moveMessages globally to return a Map of srcUids -> destUids rather than returning nothing. This is now used to bring local and remote UIDs upto speed without the need for additional requests.
2011-06-28 16:50:48 +05:30
0ba7f20622
Attempt to implement COPYUID, works for the most part except for updation of the LocalStore with freshly copied messages.
2011-06-24 02:54:12 +05:30
2f48309f82
We forgot to HTML markup the body of the message in cases where we
...
weren't quoting any text
2011-06-20 18:26:19 -07:00
970271dbf9
If the response for an APPEND command contains the APPENDUID response code, read the UID of the newly appended message from there.
2011-06-21 04:34:57 +05:30
6c84e196aa
Astyle is seriously getting on my nerves. I'm committing this with nothing but astyle changes so that forthcoming commits are clean.
2011-06-21 02:56:53 +05:30
1bdf7095a7
Delete the old localized outbox. Fixes the "two outboxes" problem.
...
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695
Fixes issue 3411
2011-06-17 06:17:01 +02:00
222cd43c80
Some code cleanup. No functional changes.
2011-06-17 04:13:32 +02:00
5eec09d37a
Merge branch 'refs/heads/master' of git@github.com:k9mail/k-9.git
2011-06-14 15:23:20 +02:00
b8f04b8a4f
typo
2011-06-14 15:22:45 +02:00
a558466c36
ant astyle
2011-06-13 19:49:06 -04:00
379a8dfa9e
It turns out that 79a96952f2 has caused a
...
lot of messages to be unreadable in K-9 3.8. (see mailing list
threads)
2011-06-09 21:54:22 -04:00
ded489daab
Add support for incoming-server and outgoing-server elements on import
2011-06-09 05:50:43 +02:00
c416f02d52
Improve BACK button handling for MessageView
...
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.
Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).
If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.
The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
2011-06-08 22:53:23 +02:00
4d11c80f65
Fix account selection on import if file doesn't contain global settings
2011-06-08 22:28:34 +02:00
5ee63c47fe
Implemented BACK handling for MessageView
...
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
2011-06-08 08:42:40 +02:00
8d97287ffd
Write outgoing-server element instead of transportUri to export file
2011-06-07 23:09:40 +02:00
4a807e33d9
Decode transport URIs into ServerSettings objects
2011-06-07 16:39:41 +02:00
bccf0b5546
Renamed class StoreSettings to ServerSettings
2011-06-07 16:09:15 +02:00
f4bcb4d923
Extracted inner class Store.StoreSettings
2011-06-07 15:59:23 +02:00
6abb5b5850
Write incoming-server element instead of storeUri key to export file
2011-06-07 04:25:17 +02:00
f6de6f8e42
Save name of the store type in StoreSettings
2011-06-07 04:07:50 +02:00
25c1a565e7
WebDavStore cleanup
...
Store port number so we can throw away the store URI once decoded
2011-06-07 03:01:02 +02:00
9b0ce3c75a
Remove no longer used references on confirmation dialog disapproval
2011-06-07 01:25:38 +02:00
fc4dd077e4
Don't attempt to configure a dismissed dialog during Android activity
...
reloading
As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.
The actual problem here was the mActiveMessages member being null
at such times.
2011-06-07 01:15:04 +02:00
29738993d9
Added function to decode store URIs into a container object
...
This will later be used by the export code to make exporting the
password optional (and the XML output "pretty").
It's also the first step to get away from store URIs towards something
more easily extensible, like Store.StoreSettings.
2011-06-07 00:08:43 +02:00
0e2afc38ef
Cosmetic changes
...
- Grouped static fields and functions
- Renamed static fields to match code standard
2011-06-06 21:10:14 +02:00
9a3ce9e03e
Added file format version attribute to export file
2011-06-06 19:54:54 +02:00
a57e605496
Added first version of input validation for account settings
2011-06-06 19:44:01 +02:00
72870174ce
Pluralize the "Move to spam" confirmation dialog since code paths were
...
unified in MessageList and multi-selection is now subject to this
dialog.
2011-06-05 01:35:11 +02:00
de7b75a1df
Properly keep selection in case of a
...
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
2011-06-05 01:16:34 +02:00
5366a07f28
Add @Override compiler check
2011-06-04 23:55:48 +02:00
190d028669
Javadoc fix
2011-06-04 23:17:47 +02:00
821a00e727
MessageList refactoring to remove duplicate code paths.
...
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).
This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
2011-06-04 23:01:34 +02:00
40546edcf7
Remove local.properties, new default projection column introduced by merge d3cf49a5e4
2011-06-02 20:30:10 +02:00
d3cf49a5e4
Merge remote-tracking branch 'refs/remotes/unread/master' into unread
2011-06-02 20:20:56 +02:00
503b88e2fd
Merge remote branch 'k-9/master'
2011-06-02 14:39:58 +01:00
31adcd2ed8
Revert " http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary "
...
This reverts commit 0c2e06133c
2011-06-02 09:35:03 -04:00
3d583da450
ant astyle
2011-06-01 16:03:56 -04:00
0c2e06133c
http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3408: SMTP timeouts while calculating message size
2011-06-01 09:13:16 +02:00
0b6f0a09bb
http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3407: Handling of SMTP 5xx error codes unclean
fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
2011-06-01 09:07:05 +02:00
2fd9bd5a03
Cleanup Utility.combine()
...
Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
2011-05-31 15:11:36 +02:00
c5342472f2
Load AbsoluteSizeSpan(int,boolean) constructor via reflection
...
This will allow us to run on Android 1.5/1.6 devices.
2011-05-26 23:43:35 -04:00
a9b28d62d7
Fix a NPE
2011-05-26 22:59:50 -04:00
30d31c7074
Explicitly use Locale.US when dealing with dates in message headers
2011-05-26 04:32:26 +02:00
de4abf87cb
Respect "move/copy destination folders" setting in ChooseFolder
...
Fixes issue 2664
2011-05-26 04:11:09 +02:00
92239739b0
microoptimize peekableInputStream's peek method to not do an extra
...
method dispatch and boolean check on every peek.
2011-05-24 21:35:18 -04:00
29117ae7a6
Switch a StringBuffer to StringBuilder, which replaced it
2011-05-24 21:21:03 -04:00
b4f3712246
Should retrieve just visibleLimit messages when the local folder is cleared.
2011-05-25 00:37:51 +09:00
cb46f170cd
Should reset visibleLimit on clear messages.
2011-05-25 00:37:49 +09:00
a4f7288d37
Avoid NullPointerException.
...
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
90a5ca8ec2
Merge pull request #34 from jca02266/possible-to-toggle-quoted-text-display
...
Possible to toggle quoted text display
2011-05-24 08:33:53 -07:00
7f93cfcbca
Refactoring
2011-05-25 00:25:23 +09:00
33a92b11a2
Use the Button instead of the ImageButton.
2011-05-22 04:12:41 +09:00
ce9b280746
Added account preference to display quoted text.
2011-05-22 03:56:51 +09:00
5d6df85aac
possible to toggle to display the quoted message to send.
2011-05-22 03:55:50 +09:00
4f67a6be24
Fixed counting of new unread messages
2011-05-21 00:33:43 +02:00
6c1b1ebf32
Moved checks from notifyAccount() to shouldNotifyForMessage()
...
This should fix the "notification count" for cases where messages
passed the shouldNotifyForMessage() checks but not the ones in
notifyAccount().
2011-05-20 23:00:48 +02:00
2d7fad1fa9
Use InetAddress.getCanonicalHostName() instead of getHostName()
...
This should always return a FQDN.
2011-05-19 00:55:34 +02:00
cketti