Commit Graph

2249 Commits

Author SHA1 Message Date
cketti f5e684310e Renamed StorageImportExportException to SettingsImportExportException 2011-10-14 06:00:10 +02:00
cketti c835bb757a Renamed StorageImporter to SettingsImporter 2011-10-14 05:58:55 +02:00
cketti cf8bdef0a8 Renamed StorageExporter to SettingsExporter 2011-10-14 05:58:15 +02:00
cketti 0ae176bab3 Code/documentation cleanup. No functional changes. 2011-10-14 05:54:23 +02:00
cketti 470ba8bb03 Removed everything related to settings file encryption
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
2011-10-14 05:38:27 +02:00
cketti fd16ff8fe6 Remove reference to NonConfigurationInstance when no longer needed 2011-10-14 04:15:45 +02:00
cketti 5b81dbc2ed Use resource strings instead of hardcoding things 2011-10-14 03:42:04 +02:00
cketti b146fcb2fd Improved handling of object retention on configuration changes 2011-10-14 02:52:32 +02:00
cketti b05750c245 Better input validation in *Store.createUri() 2011-10-13 02:35:08 +02:00
ashley willis 2058fc378d Option to show next message after delete by default instead of previous. 2011-10-12 17:50:24 +02:00
cketti a258415629 Merge pull request #60 from andrewgaul/builder-append-no-concatenation
Avoid concatenation in StringBuilder append
2011-10-12 08:28:32 -07:00
cketti c34d896474 Merge pull request #59 from andrewgaul/immutable-sets
Make sets immutable
2011-10-12 08:26:43 -07:00
Marcus Wolschon 4c8ebb4bcd added check for Null 2011-10-11 08:53:51 +02:00
cketti 7a9c747db9 Don't export incoming/outgoing server passwords 2011-10-11 03:12:18 +02:00
cketti 1de28150e2 Require accounts to at least have one identity when importing 2011-10-09 01:23:45 +02:00
cketti 13b74d0d9e Added error logging 2011-10-09 01:14:59 +02:00
cketti d791770154 Code cleanup 2011-10-09 00:31:33 +02:00
cketti 6714a7ec5a Improved logging in StorageImporter 2011-10-09 00:04:00 +02:00
cketti 1ab7dbae54 Added input validation for folder settings 2011-10-08 21:30:45 +02:00
cketti f21e14afc7 Added input validation for identity settings 2011-10-08 17:58:57 +02:00
cketti 060d21db3e Make collections immutable 2011-10-07 21:20:12 +02:00
cketti 0920b0c14d Changed the way SettingsDescription is used
Added ability to rewrite the string representation used internally to
something "pretty" on export.
Now only settings that have entries is GlobalSettings and
AccountSettings are exported. This prevents export of newer settings
that are left in the preference storage when downgrading.
2011-10-07 20:29:03 +02:00
Andrew Gaul 57be9e3ee3 Make sets immutable
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
Andrew Gaul 9b27aba2ba Avoid concatenation in StringBuilder append 2011-10-06 09:20:11 -07:00
cketti 2e2428b093 Merge pull request #55 from andrewgaul/stringbuilder
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti 31af4526ab Merge pull request #58 from andrewgaul/spelling
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul 220e55603d Spelling corrections 2011-10-05 22:04:39 -07:00
Andrew Gaul dad0332667 Make an inner class static 2011-10-05 22:01:53 -07:00
Andrew Gaul 47eb0fa2e1 Prefer StringBuilder over StringBuffer
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti 83ee4253d5 Whitelist settings for export instead of blacklisting keys
Use GlobalSettings.SETTINGS an AccountSettings.SETTINGS to decide
which settings to export.
2011-10-04 05:13:17 +02:00
cketti 644571cfe5 Make sure the InputStream of the import file is always closed 2011-10-04 00:48:43 +02:00
cketti f2a3752930 Added constants for (export) file format version and "settings version" 2011-10-04 00:09:38 +02:00
cketti 33ae5ff7d0 Added code to skip some account settings on export 2011-10-03 20:16:02 +02:00
cketti 0619eaf79c Catch NumberFormatException when parsing disposition size parameter
Fixes issue 3712
2011-10-01 21:17:00 +02:00
cketti 88dc36da8a Added a check to prevent an ArrayIndexOutOfBoundsException
Fixes issue 3683
2011-10-01 20:30:22 +02:00
cketti dfa97cd878 Handle activity restarts due to configuration changes
Close existing dialogs before the activity is destroyed. Recreate them
and rewire AsyncTasks to the new activity instance after its creation.
2011-10-01 20:11:14 +02:00
cketti 6e1bf2965d Fixed DateFormatValidator to handle placeholders SHORT and MEDIUM 2011-09-30 16:54:01 +02:00
cketti cd72e197ec Added code to skip certain settings on export 2011-09-30 16:47:59 +02:00
cketti c76bec971b Fixed compiler warning
Use new variable instead of overwriting an argument.
2011-09-30 14:58:13 +02:00
Jesse Vincent defabdc20c Additional service fixes from the original author of the issue 2777 fix
to stop the service from being shutdown when we have push enabled
2011-09-29 00:16:27 -04:00
Jesse Vincent fd61b4f20b Merge pull request #52 from andrewgaul/peekable-bad-offset
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
Andrew Gaul 7cf1bfcc98 Fix bad offset in PeekableInputStream 2011-09-20 21:21:50 -07:00
Koji Arai f3795f3df5 Search same sender from searchable folders instead of the unified inbox 2011-09-16 01:33:51 +09:00
Andrew Chen dd1334b874 Add some JavaDoc to SearchAccount stuff; astyle. 2011-09-12 15:08:34 -07:00
Jesse Vincent cbaa9f5b3d Work around cases where mail was last checked in the future.
Sometimes, user devices will have their clock misset. Previously, K-9
would just stop checking mail until the device caught up with the
future.
2011-09-05 22:16:04 -04:00
danapple 7d5bb99dbd Add progress indicator during account move. 2011-09-05 12:45:53 -05:00
danapple 2867a90286 Disable account move menu items when account is at an end of the list.
Conflicts:

	src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
danapple 06cabdbde1 Working version of moving accounts within the Accounts view. 2011-09-05 12:38:03 -05:00
danapple c67ac4735f Fixes Issue 3177
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes.  This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count.  If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
Jesse Vincent 50e6218c1d Merge pull request #49 from senab/master
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-04 18:44:08 -07:00
Jesse Vincent 8223e4d4bf Removed some doc annotations from chrisk's fix for the service stopping
issue (2777)
2011-09-04 16:13:19 -04:00
Christian Knecht 7cd6334c64 Stop service(s) if not in use - Fixes Issue 2777 2011-09-04 16:00:02 -04:00
Jesse Vincent 1b7481f854 optimize cketti's pop3 space-splitting code to not make lots of extra
copies of responses.
2011-09-04 15:53:12 -04:00
Chris Banes b002f3178b Move Sender Address to end of Default Projection 2011-09-02 11:33:20 +01:00
Chris Banes caa02b16eb Expose SenderAddress through ContentProvider. Issue: 3665 2011-09-01 11:57:06 +01:00
cketti f6a647d7b0 Cosmetic changes 2011-08-31 02:17:45 +02:00
cketti e9e9d5afcb Removed unused method 2011-08-31 02:12:01 +02:00
cketti dfc370c057 Merge pull request #42 from jca02266/wip-fix-activity-switching-for-message-view
Fix for message list opening the wrong message view

Fixes issue 3592
2011-08-30 17:09:11 -07:00
Andrew Chen 16c1f9c35b Add the remaining two return receipt headers upon request. 2011-08-28 16:08:41 -07:00
Jesse Vincent 1ac652dc5f Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers. 2011-08-28 18:28:12 -04:00
Jesse Vincent a1378789b2 Merge pull request #48 from rpimonitrbtch/master
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames.

Resolves Issue 2784: Cannot set server hostname
2011-08-28 12:48:10 -07:00
rpimonitrbtch bdcb19e344 Issue 2784: Cannot set server hostname
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames. Removed the localhost and localhost.localdomain exceptions, as they are now redundant.
2011-08-28 15:24:52 -04:00
Alessandro Russo f5c679fb95 Added support for requesting read receipts 2011-08-27 20:46:04 -04:00
Apoorv Khatreja 47bedec410 Fixed an issue which caused space characters to throw exceptions when being parsed. Some cosmetic changes, and context sensitivity for EXISTS, RECENT and EXPUNGE responses which have empty token lists. 2011-08-04 23:30:27 +05:30
Apoorv Khatreja 9335dacd46 Added a separate handler for status responses to parse the resp-text tokens contained in these responses. 2011-08-02 02:19:12 +05:30
Adam be1be56e3a Fixed bug where uid in response was truncated
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
Apoorv Khatreja cf39070048 Whitespaces :/ 2011-07-25 18:56:21 +05:30
Jesse Vincent 3679b31b12 Workaround for market-reported error:
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
2011-07-25 01:49:42 -04:00
Apoorv Khatreja da9a5e6c17 Made some cosmetic changes for clarity, added debug messages for erroneous conditions. Fixed potential NPE in ImapFolder.parseSequenceSet(). 2011-07-25 06:50:26 +05:30
Jesse Vincent 7b7601082b the refactoring to combine batch and record logic added an extra check
that broke delete of single messages from message list.
2011-07-23 18:45:43 -04:00
Koji Arai fda43206a3 Fixed the below issue for GalaxyS and S2.
When scrolling a ListView, all items turn black.
it was reproduced on FolderList, MessageList and Accounts, other views were not.
2011-07-20 22:13:20 +09:00
Jesse Vincent 0543183b11 Work around a weird NPE in WebDAV sync reported by Jon Blow 2011-07-19 22:43:32 -04:00
Koji Arai 8d264b159e Workaround for below issue.
1. Show a message in MessageView.
2. Press HOME button to back home.
3. Re-launch the K-9 and select another message.
4. Show first selected message.

See also: https://github.com/k9mail/k-9/commit/fix_activity_stack
2011-07-18 00:59:30 +09:00
cketti 2acd55a9ef Implemented work-around to handle malformed UIDL responses (POP3).
Fixes issue 3546
2011-07-17 14:37:21 +02:00
cketti 9f581cb6f3 Extracted POP3 commands and capabilities to constants 2011-07-17 14:13:04 +02:00
Koji Arai 45e29ccba4 Fixed issue 3530.
Should not HTMLify the message when it is sent without quoted message.

The problem is:
1. set MessageFormat in Account setting to the TEXT.
2. reply a message without quoted text.
3. it is sent with HTML tags.
2011-07-17 08:56:28 +09:00
Apoorv Khatreja adc7d65d09 Newline :/ 2011-07-17 01:42:12 +05:30
Apoorv Khatreja c6a2cb48b1 Added method to check for status response. 2011-07-17 01:41:14 +05:30
Apoorv Khatreja 021d5641e5 ant astyle 2011-07-17 01:40:20 +05:30
Jesse Vincent 2e173150d5 Rather than disabling imap-specific preferences on POP3, hide em 2011-07-13 22:15:36 -04:00
Jesse Vincent 87640719dd Disable "download by date range" for webdav and pop3.
The previous behavior caused catastrophic network abuse, downloading
messages outside the date range over and over.
2011-07-12 22:05:49 -04:00
Jesse Vincent b85c9b7b0e Work around the fact that when we can't get read status for a message,
we'd end up with an NPE as we then queried the hashmap
2011-07-11 11:08:20 -04:00
Jesse Vincent 98ae8cf2be refactoring to use the object we extracted from the array 2011-07-11 11:08:20 -04:00
Jesse Vincent d7dfba15cf It appears that Exchange is returning responses
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
2011-07-09 17:00:35 -04:00
Jesse Vincent 220be75473 Add a bit of logging to find out what webdav servers tell us about how
many messages they have in debug mode
2011-07-09 16:24:18 -04:00
Jesse Vincent 8cffc5b682 Bullet proofing for user-reported exceptions in WebDAV sync:
E/k9      ( 5735): java.lang.NullPointerException
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9      ( 5735):      at java.lang.Thread.run(Thread.java:1096)
2011-07-09 15:26:30 -04:00
Jesse Vincent c7e8969b01 remove a bunch of listener notification duplication that crept into the
code. this caused all attachments to be double-opened, among other
things
2011-07-09 00:27:56 -04:00
cketti a60a2a4295 Changed code to show/hide the correct views for CC/BCC
Fixes issue 3509
2011-07-07 04:59:45 +02:00
cketti d310167b99 Rewrite mime type image/pjpeg to image/jpeg
Fixes issue 1712
2011-07-07 03:05:12 +02:00
Jesse Vincent b02b895aaf Add 2MB, 5MB and "All" message download options 2011-07-02 15:29:49 -04:00
Jesse Vincent 2a698f1ab9 ant astyle 2011-07-02 15:18:43 -04:00
Apoorv Khatreja 3321ebdc33 COPYUID changes were being updated only in memory, but were not being written to db. 2011-07-02 11:59:00 +05:30
Apoorv Khatreja bc9b7030d7 COPYUID implementation now in place and working, restructured appendMessages, copyMessages and moveMessages globally to return a Map of srcUids -> destUids rather than returning nothing. This is now used to bring local and remote UIDs upto speed without the need for additional requests. 2011-06-28 16:50:48 +05:30
Apoorv Khatreja 0ba7f20622 Attempt to implement COPYUID, works for the most part except for updation of the LocalStore with freshly copied messages. 2011-06-24 02:54:12 +05:30
Jesse Vincent 2f48309f82 We forgot to HTML markup the body of the message in cases where we
weren't quoting any text
2011-06-20 18:26:19 -07:00
Apoorv Khatreja 970271dbf9 If the response for an APPEND command contains the APPENDUID response code, read the UID of the newly appended message from there. 2011-06-21 04:34:57 +05:30
Apoorv Khatreja 6c84e196aa Astyle is seriously getting on my nerves. I'm committing this with nothing but astyle changes so that forthcoming commits are clean. 2011-06-21 02:56:53 +05:30
cketti 1bdf7095a7 Delete the old localized outbox. Fixes the "two outboxes" problem.
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695

Fixes issue 3411
2011-06-17 06:17:01 +02:00
cketti 222cd43c80 Some code cleanup. No functional changes. 2011-06-17 04:13:32 +02:00
Marcus Wolschon 5eec09d37a Merge branch 'refs/heads/master' of git@github.com:k9mail/k-9.git 2011-06-14 15:23:20 +02:00
Marcus Wolschon b8f04b8a4f typo 2011-06-14 15:22:45 +02:00
Jesse Vincent a558466c36 ant astyle 2011-06-13 19:49:06 -04:00
Jesse Vincent 379a8dfa9e It turns out that 79a96952f2 has caused a
lot of messages to be unreadable in K-9 3.8.  (see mailing list
threads)
2011-06-09 21:54:22 -04:00
cketti ded489daab Add support for incoming-server and outgoing-server elements on import 2011-06-09 05:50:43 +02:00
Fiouz c416f02d52 Improve BACK button handling for MessageView
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.

Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).

If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.

The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
2011-06-08 22:53:23 +02:00
cketti 4d11c80f65 Fix account selection on import if file doesn't contain global settings 2011-06-08 22:28:34 +02:00
Fiouz 5ee63c47fe Implemented BACK handling for MessageView
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
2011-06-08 08:42:40 +02:00
cketti 8d97287ffd Write outgoing-server element instead of transportUri to export file 2011-06-07 23:09:40 +02:00
cketti 4a807e33d9 Decode transport URIs into ServerSettings objects 2011-06-07 16:39:41 +02:00
cketti bccf0b5546 Renamed class StoreSettings to ServerSettings 2011-06-07 16:09:15 +02:00
cketti f4bcb4d923 Extracted inner class Store.StoreSettings 2011-06-07 15:59:23 +02:00
cketti 6abb5b5850 Write incoming-server element instead of storeUri key to export file 2011-06-07 04:25:17 +02:00
cketti f6de6f8e42 Save name of the store type in StoreSettings 2011-06-07 04:07:50 +02:00
cketti 25c1a565e7 WebDavStore cleanup
Store port number so we can throw away the store URI once decoded
2011-06-07 03:01:02 +02:00
Fiouz 9b0ce3c75a Remove no longer used references on confirmation dialog disapproval 2011-06-07 01:25:38 +02:00
Fiouz fc4dd077e4 Don't attempt to configure a dismissed dialog during Android activity
reloading

As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.

The actual problem here was the mActiveMessages member being null
at such times.
2011-06-07 01:15:04 +02:00
cketti 29738993d9 Added function to decode store URIs into a container object
This will later be used by the export code to make exporting the
password optional (and the XML output "pretty").
It's also the first step to get away from store URIs towards something
more easily extensible, like Store.StoreSettings.
2011-06-07 00:08:43 +02:00
cketti 0e2afc38ef Cosmetic changes
- Grouped static fields and functions
- Renamed static fields to match code standard
2011-06-06 21:10:14 +02:00
cketti 9a3ce9e03e Added file format version attribute to export file 2011-06-06 19:54:54 +02:00
cketti a57e605496 Added first version of input validation for account settings 2011-06-06 19:44:01 +02:00
Fiouz 72870174ce Pluralize the "Move to spam" confirmation dialog since code paths were
unified in MessageList and multi-selection is now subject to this
dialog.
2011-06-05 01:35:11 +02:00
Fiouz de7b75a1df Properly keep selection in case of a
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
2011-06-05 01:16:34 +02:00
Fiouz 5366a07f28 Add @Override compiler check 2011-06-04 23:55:48 +02:00
Fiouz 190d028669 Javadoc fix 2011-06-04 23:17:47 +02:00
Fiouz 821a00e727 MessageList refactoring to remove duplicate code paths.
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).

This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
2011-06-04 23:01:34 +02:00
Fiouz 40546edcf7 Remove local.properties, new default projection column introduced by merge d3cf49a5e4 2011-06-02 20:30:10 +02:00
Fiouz d3cf49a5e4 Merge remote-tracking branch 'refs/remotes/unread/master' into unread 2011-06-02 20:20:56 +02:00
João Pedro Taveira 503b88e2fd Merge remote branch 'k-9/master' 2011-06-02 14:39:58 +01:00
Jesse Vincent 31adcd2ed8 Revert "http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary"
This reverts commit 0c2e06133c.

The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list

Conflicts:

	src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-06-02 09:35:03 -04:00
Jesse Vincent 3d583da450 ant astyle 2011-06-01 16:03:56 -04:00
Marcus Wolschon 0c2e06133c http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
Issue 3408: 	SMTP timeouts while calculating message size
2011-06-01 09:13:16 +02:00
Marcus Wolschon 0b6f0a09bb http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
Issue 3407: 	Handling of SMTP 5xx error codes unclean

fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
2011-06-01 09:07:05 +02:00
Andrew Gaul 2fd9bd5a03 Cleanup Utility.combine()
Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
2011-05-31 15:11:36 +02:00
cketti c5342472f2 Load AbsoluteSizeSpan(int,boolean) constructor via reflection
This will allow us to run on Android 1.5/1.6 devices.
2011-05-26 23:43:35 -04:00
Jesse Vincent a9b28d62d7 Fix a NPE 2011-05-26 22:59:50 -04:00
cketti 30d31c7074 Explicitly use Locale.US when dealing with dates in message headers 2011-05-26 04:32:26 +02:00
cketti de4abf87cb Respect "move/copy destination folders" setting in ChooseFolder
Fixes issue 2664
2011-05-26 04:11:09 +02:00
Jesse Vincent 92239739b0 microoptimize peekableInputStream's peek method to not do an extra
method dispatch and boolean check on every peek.
2011-05-24 21:35:18 -04:00
Jesse Vincent 29117ae7a6 Switch a StringBuffer to StringBuilder, which replaced it 2011-05-24 21:21:03 -04:00
Koji Arai b4f3712246 Should retrieve just visibleLimit messages when the local folder is cleared. 2011-05-25 00:37:51 +09:00
Koji Arai cb46f170cd Should reset visibleLimit on clear messages. 2011-05-25 00:37:49 +09:00
Koji Arai a4f7288d37 Avoid NullPointerException.
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
Koji Arai 90a5ca8ec2 Merge pull request #34 from jca02266/possible-to-toggle-quoted-text-display
Possible to toggle quoted text display
2011-05-24 08:33:53 -07:00
Koji Arai 7f93cfcbca Refactoring 2011-05-25 00:25:23 +09:00
Koji Arai 33a92b11a2 Use the Button instead of the ImageButton. 2011-05-22 04:12:41 +09:00
Koji Arai ce9b280746 Added account preference to display quoted text. 2011-05-22 03:56:51 +09:00
Koji Arai 5d6df85aac possible to toggle to display the quoted message to send. 2011-05-22 03:55:50 +09:00
cketti 4f67a6be24 Fixed counting of new unread messages 2011-05-21 00:33:43 +02:00
cketti 6c1b1ebf32 Moved checks from notifyAccount() to shouldNotifyForMessage()
This should fix the "notification count" for cases where messages
passed the shouldNotifyForMessage() checks but not the ones in
notifyAccount().
2011-05-20 23:00:48 +02:00
cketti 2d7fad1fa9 Use InetAddress.getCanonicalHostName() instead of getHostName()
This should always return a FQDN.
2011-05-19 00:55:34 +02:00
cketti 8fc714ac4a Don't show "null" for partially downloaded messages with empty text body 2011-05-16 00:36:46 +02:00
cketti 41b039b691 Fix bug introduced with commit b7a6dbd973
Fixes issue 3297
2011-05-15 16:23:53 +02:00
cketti 95288b37d7 Removed unnecessary method implementation
Make Pop3Folder.setFlags(Flag[],boolean) throw an
UnsupportedOperationException instead of calling a method that does
just that.
2011-05-14 23:46:26 +02:00
cketti dc96bf3186 Only mark all messages as read on the server if that's supported
This change prevents K-9 Mail from establishing a connection to the
server when all messages are marked as read on a POP3 account.
2011-05-14 23:30:47 +02:00
cketti ba9bc2f8e9 Added method Folder.isFlagSupported(Flag) 2011-05-14 23:19:24 +02:00
cketti e90a479384 Renamed member variables to match code style guidelines 2011-05-14 22:17:15 +02:00
cketti 92b17ec2e2 Hide "Show only subscribed folders" checkbox for POP3 accounts 2011-05-14 22:15:39 +02:00
cketti 86fca9c1f2 POP3: Check for support of the TOP command (if CAPA isn't supported)
This will allow to download partial messages if the server doesn't
support the CAPA command but supports the TOP command (e.g. Hotmail).

Fixes issue 2042
2011-05-14 21:40:21 +02:00
cketti 969e2d93fd Don't use the "owner name" as default value for the email name
Get rid of Contacts.getOwnerName() and associated permissions.

Fixes issue 3331
2011-05-14 04:53:17 +02:00
Andrew Chen e5d952bff4 Save and restore the cursor position when saving or loading a draft. This is the first step in making "resume composition on context switch" a reality. 2011-05-10 15:23:25 -07:00
Marcus Wolschon e0ef94f64b Issue 3319: unseen message count can add up to infinity 2011-05-09 11:21:24 +02:00
cketti 8e1c4acef9 Get rid of constant K9.OUTBOX
Use Account.getOutboxFolderName() instead (still hardcoded, though)
2011-05-08 02:22:38 +02:00
cketti f4931a3167 Get rid of constant K9.INBOX
Use Account.getInboxFolderName() instead
2011-05-08 02:17:23 +02:00
cketti 92ea452163 Restore hardcoded Outbox 2011-05-07 23:57:47 +02:00
cketti 33c0bf9e31 Avoid NullPointerException for messages with html_content = NULL in DB
Fixes issue 3302
2011-05-06 20:02:55 +02:00
Andrew Chen e12dd323f8 Issue 3105: Drop newlines in favor of preserving multiple spaces in htmlified text bodies. 2011-05-05 13:52:47 -07:00
Jesse Vincent cfd1ad7cdb comment some htmlifciation regexes 2011-05-05 12:50:45 -04:00
Jesse Vincent 8a907f9be7 remove a pointless extra assignment 2011-05-05 12:47:57 -04:00
Jesse Vincent 196a9c167d comment some preview regexes 2011-05-05 12:47:39 -04:00
Andrew Chen 1ea27d7020 Issue 3105: Generate proper HTML-ified versions of text messages so that textification of the HTMLified text message preserves the original newlines. 2011-05-05 00:17:34 -07:00
Andrew Chen 3fcca67ae5 Preserve legacy SMTP authentication behavior for PLAIN by trying LOGIN if supported. 2011-05-04 23:34:02 -07:00
cketti 71c5e3c611 Remove unnecessary null pointer check 2011-05-05 02:54:20 +02:00
cketti 141e2d2ad9 Make the "pick directory intent" array a constant 2011-05-05 02:52:47 +02:00
cketti 837b7da206 Changed order of pick directory intents 2011-05-05 02:36:15 +02:00
jmccabe 50b6d62169 Refactor of showFileBrowserActivity to add a couple of extra options
to the list of possible file browser intents (ES File Explorer and
Blackmoon File Browser) and simplify possible future updates.
2011-05-05 08:29:05 +08:00
Koji Arai 870791958f Refresh folder list when folder is cleared 2011-05-05 07:08:33 +09:00
Vitaly Polonetsky 37ae2e41f5 fixed displaying of "(null)" account description in notification at account setup wizard 2011-05-05 04:38:33 +08:00
João Pedro Taveira af7d57561f Message ContentProvider field rename from READED to UNREAD to maintain
names consistency.
2011-05-02 16:00:04 +01:00
cketti 42987cee51 Use current values for missing or malformed global settings in the import file 2011-05-02 04:06:22 +02:00
cketti 01937d4ab8 Don't crash if "footer view" is clicked in search results
Fixes issue 3071
2011-05-01 05:34:17 +02:00
Bernhard Redl f2283aa91e Catch IllegalCharsetNameException causing force-close on unsupported japanese charsets (issue 3272) 2011-05-01 04:32:10 +02:00
cketti 7e24377bb8 Return detailed information on imported accounts 2011-04-29 04:29:16 +02:00
cketti b7a6dbd973 Skip IMAP folders with names that are not correctly encoded.
Configure the CharsetDecoder to throw an exception if malformed input
is encountered. Not doing this can cause an endless loop that
allocates memory until the application dies with an OutOfMemory error.
Until we have support for both a folder display name and a raw folder
name we simply ignore folders with names that aren't correctly encoded
with the modified UTF-7 variant.

Fixes issue 3268

Credits: Bernhard Redl (aatdark) analysed the problem and wrote the
initial version of the fix.
2011-04-28 04:46:01 +02:00
cketti 037b0ff64d Fix automatic authentication method selection for SMTP
Only use automatic authentication method selection if none was
explicitly selected in outgoing server settings.
2011-04-26 18:23:41 +02:00
cketti e8a1a9a466 Restored semantics of auth*Supported in SMTP authentication code
Also, display a debug message if a certain authentication method was
selected by the user but the server didn't advertise support for it in
the EHLO response.
2011-04-26 17:49:40 +02:00
cketti 80f60a06ca Merged pull request #21 from jott/master.
Support for SMTP authentication methods that are not announced by the server.
2011-04-26 08:18:49 -07:00
Koji Arai 9b2e4c43a9 Fixed default sender color in the MessageList 2011-04-26 23:49:25 +09:00
Jonas Hurrelmann da38149091 Support for SMTP authentication methods that are not announced by the server.
- Added AUTOMATIC as a new authentication method that will automatically choose the best authentication method (basically old behavior with CRAM_MD5). All other options will now enforce the selected authentication method.
- Added LOGIN as selectable option.
- Cleaned up code so strings to the different authentication methods are only defined once.
2011-04-25 22:32:48 +02:00
Jesse Vincent c3480db129 Add missing file from the file chooser work 2011-04-25 13:17:18 +10:00
Bernhard Redl f90fccbfa7 fix NullPtr Exception when there is no Sent Mail folder on the imap server 2011-04-24 14:19:58 +10:00
Bernhard Redl ab4bae214f Make attachment saving respect the new preference. Allow long-press to
choose a folder.

(new constant renamed from CHOOSE_FOLDER to CHOOSE directory for
clarity)
2011-04-24 14:01:03 +10:00
Bernhard Redl 96842b3ce6 Unroll import statements in AttachmentView.java 2011-04-24 13:56:54 +10:00
Bernhard Redl e278ea23e9 Add a preference for selecting a default folder in which to save attachments 2011-04-24 13:55:25 +10:00
cketti 4b2fe6efab Removed unused imports 2011-04-21 00:00:16 +02:00
cketti 49308922d9 Refactored code to calculate number of unread messages some more 2011-04-20 23:58:10 +02:00
cketti 71f423d029 Added first version of import file validation 2011-04-20 21:37:48 +02:00
Bernhard Redl 92f7c3a19f Refactored the code to calculate the number of unread messages in an account 2011-04-20 23:35:02 +10:00
Bernhard Redl 415c11d712 "When calculating the number of unread messages shown in the account list, INBOX now is always counted, even if a "special" folder has been set to INBOX (issue 3074) 2011-04-20 23:09:02 +10:00
Bernhard Redl 120a39d5d6 * Fix Bug https://code.google.com/p/k9mail/issues/detail?id=3224
12/24 timesetting is no based on the android system settings
2011-04-20 10:12:59 +08:00
cketti 237302cc2b Changed import code to set "defaultAccountUuid" if necessary 2011-04-19 23:04:43 +02:00
Marcus Wolschon 6f4bef3530 Issue 3259: Show SubjectAltNames in acceptKeyDialog 2011-04-19 10:46:17 +02:00
Marcus Wolschon 59399506df fixed very rare NullPointerException 2011-04-19 09:01:01 +02:00
Jesse Vincent 724b6eaaa5 For a while, it was possible for users to conifgure their outbox and
drafts folders to be the same folder. This could result in drafts being
sent over and over.  This change uses the K-9 Identity header as a
shibboleth for drafts, as it's not actually set when a message is sent.
2011-04-17 21:07:13 +10:00
Koji Arai 659a5d36b2 Fixed issue 2991: Should display colorized name in the message list. 2011-04-16 18:16:33 +09:00
mwolschon 7f5c18bd2b updated comments 2011-04-14 10:07:33 +02:00
mwolschon 9bdfb0d023 BUGFIX: time changes are still honored even if the user choose the
[abort] button of the DialogPreference.
2011-04-13 12:18:07 +02:00
cketti 8240d7ff10 Always reload all accounts after importing one or more accounts 2011-04-13 03:44:43 +02:00
cketti 12d87854ac First version of the import code that reads the new file format 2011-04-13 03:37:44 +02:00
Jesse Vincent d3848d352d astyle 2011-04-12 22:17:22 +10:00
bitblaster d2c56edbd2 Restored original imports, added comments, changed method createFolder 2011-04-12 22:17:11 +10:00
bitblaster 0a5d7ba953 In getPersonalNameSpaces now we ask the server for the real folder names corresponding to the special folders ids (for which we have constants), so we can map the account folders using the real names. 2011-04-12 22:17:11 +10:00
bitblaster c46372b58c Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 59b1d57658 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 20a9043a13 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 461b57747c Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 879d872616 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 3290166749 Replaced references to K9.INBOX with account.getInboxFolderName() and disabled the call to reverseTranslateFolder in case of WebDav account 2011-04-12 22:17:11 +10:00
bitblaster ccc79f62b9 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 236226858c Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 680e2e4191 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
bitblaster 50b906aef7 Added mInboxFolderName and mOutboxFolderName fields 2011-04-12 22:17:11 +10:00
Jesse Vincent 0174988d27 astyle 2011-04-12 22:16:22 +10:00
Sander Bogaert 17cb5106f6 The date format preference is now refreshed each time the messages get listed.
Previously, changes to the date format preference weren't noticed until
the app restarted.
2011-04-12 21:44:51 +10:00
Sander Bogaert c283449d04 Added another badDateTimeFormat to ImapResponseParser.
Some IMAP servers generate timestamps without timezones. :/

Fixes gcode issue 3179
2011-04-12 21:34:22 +10:00
João Pedro Taveira 591d7a3c6f Added readed field to MessageProvider to indicate if message was
readed yet.
2011-04-11 20:34:23 +01:00
cketti 939660faf4 Quote CID before using it in a regular expression
Fixes issue 3227
2011-04-10 20:39:40 +02:00
Koji Arai 2cd178e684 Fixed NullPointerException 2011-04-10 01:10:25 +09:00
Koji Arai 79a96952f2 Correct encoding and decoding for the filename parameter in the Content-Disposition. 2011-04-08 00:58:53 +09:00
cketti 2cadff74b1 Extracted CRAM-MD5 computation into separate class.
This gets rid of duplicated code in ImapStore, Pop3Store, and
SmtpTransport.
2011-04-07 17:11:32 +02:00
Jesse Vincent e3818e7739 Merge branch 'master' of https://github.com/dnet/k-9 into dnet-master
* 'master' of https://github.com/dnet/k-9:
  Added SHA-1 checksum to acceptKeyDialog
2011-04-07 15:44:09 +10:00
Will Hawkins d881832eca Made the minor modifications to support CRAM-MD5 authentication
in POP3 accounts.
2011-04-06 11:42:37 -04:00
András Veres-Szentkirályi dcf5d150a6 Added SHA-1 checksum to acceptKeyDialog 2011-04-04 18:14:46 +02:00
Koji Arai 37303d69d8 Should store the disposition-type without Content-Disposition parameters. 2011-04-04 00:58:59 +09:00
Jesse Vincent 39e3aecf73 Unify two IMAP date parsing paths, improving the exception so we can
learn what date format we don't cope with.
2011-04-03 14:56:12 +10:00
cketti 8a112f04f9 Disable "Enable refile buttons" preference for POP3 users 2011-04-01 06:44:50 +02:00
cketti 4aec4b096c Added option to disable confirmation dialog for "mark all as read"
Fixes issue 1415
2011-04-01 05:34:27 +02:00
cketti 867b251e6d Added @Override annotations to fix warnings 2011-04-01 04:36:29 +02:00
cketti aa4c970baa Added "move to spam folder" confirmation dialog to MessageList 2011-04-01 04:21:27 +02:00
cketti e3e31062ad Only keep reference to selected message if necessary
Only keep mSelectedMessage pointing to the currently selected message
if we use the spam action and ask for confirmation before moving.
2011-04-01 03:45:50 +02:00
cketti ea9213cd4d Converted some more confirmation dialogs to use ConfirmationDialog 2011-04-01 03:40:08 +02:00
cketti ac148a1ef7 Extracted confirmation dialog creation to ConfirmationDialog
Confirmation dialogs in MessageList and MessageView now use the new
ConfirmationDialog class.
2011-04-01 03:17:47 +02:00
cketti 449d4df2a9 Minor code cleanup 2011-04-01 03:13:23 +02:00
Archibald Sheran 80f055a0a7 Issue 2296 Spam message 2011-04-01 05:54:51 +08:00
DraSine on Rails e698c78190 Fixed gcode #3182
Sending mail (SMTP) doesn’t work is the SMTP server is picky about RFC
conformance of envelope dialogue.

k9mail:

MAIL FROM: <sender@dom.ain>
RCPT TO: <receiver@dom.ain>

rfc:

MAIL FROM:<sender@dom.ain>
RCPT TO:<receiver@dom.ain>
2011-03-31 21:41:03 +08:00
cketti d5197fdc56 Put all import code in StorageImporter
Get rid of StorageImporterEncryptedXml and IStorageImporter. Also
AsyncUIProcessor is now obsolete.
2011-03-30 21:00:34 +02:00
cketti 45afa3a747 Make XML element/attribute names for export public 2011-03-30 20:56:26 +02:00
cketti 49e30b1be4 Export settings sorted by key 2011-03-30 06:44:16 +02:00
cketti 70f9a7b852 Granted some account/identity keys their own XML element (export) 2011-03-30 06:37:10 +02:00
cketti 8850915987 Add method to export an encrypted settings file 2011-03-30 05:31:48 +02:00
cketti 6258118ed6 Write identity elements in correct order (export) 2011-03-30 05:08:49 +02:00
cketti 29c42eb1a3 More structure for the XML export (folder settings) 2011-03-30 04:57:05 +02:00
cketti 83b2972a13 Rename "settings" tag to "global" for global settings (export) 2011-03-30 04:23:54 +02:00
cketti 24785bab66 More structure for the XML export (identity) 2011-03-30 03:55:14 +02:00
cketti 77f7303aa2 Use constants for element names and attributes in XML export code 2011-03-30 00:21:15 +02:00
cketti fbe1b26f24 Reflect some of the settings structure in exported XML 2011-03-29 07:08:29 +02:00
cketti 81931967a9 Fix code so accounts are exported when exporting everything 2011-03-29 06:59:02 +02:00
cketti 0ac406d3cd Removed per key/value encryption on export 2011-03-29 06:15:58 +02:00
cketti c36182f586 Use XmlSerializer instead of writing XML tags manually 2011-03-29 05:27:18 +02:00
cketti 9a78145e22 Merge StorageExporterEncryptedXml into StorageExporter 2011-03-29 04:27:41 +02:00
cketti 84f4331766 Disable import for now 2011-03-28 08:12:12 +02:00
cketti 6510919eee Moved export to file code from Accounts activity into StorageExporter 2011-03-28 08:04:43 +02:00
cketti f5c153b405 Get rid of StorageFormat 2011-03-28 07:25:07 +02:00
cketti 97f493c881 Get rid of ExportListener 2011-03-28 07:18:47 +02:00
cketti 1d146278b0 Moved password input dialog for export to Accounts activity. 2011-03-28 01:55:46 +02:00
cketti a559a35249 Use AsyncTask instead of AsyncUIProcessor for export 2011-03-28 01:18:36 +02:00
danapple ad4c7f7071 UUIDs could have been generated by different generators within the
same instance due to local upgrades of K-9 Mail.
2011-03-27 15:27:14 -05:00
danapple 90e88c251e Explanation of the reasons for mapping imported UUIDs into new local
UUIDs.
2011-03-27 13:14:36 -05:00
danapple e5ef068c15 Move the generation of the XML envelope to a common place since it
would be used in all storageFormats.  StorageImporter uses the header
to figure out which specific import implementation to use.
2011-03-27 11:37:43 -05:00
Jesse Vincent 03d05e9331 If an SMTP server tells us how big the biggest message they accept is,
don't even try to deliver it to them
2011-03-27 23:09:41 +08:00
Jesse Vincent 97ec38d03f Move our IMAP Store to using a message's sizing method 2011-03-27 23:09:41 +08:00
Jesse Vincent 4f63a3de24 Add a pair of methods to help optimize countingmessagestream 2011-03-27 23:08:25 +08:00
Jesse Vincent 604e532879 Add a method to calculate a message's serialized size 2011-03-27 23:08:25 +08:00
Jesse Vincent c8d38da568 Pull out the maximum acceptable message size from SMTP servers that tell
us when we EHLO.

Next step is to _use_ this data.
2011-03-27 23:08:25 +08:00
Jesse Vincent 0bded12843 Kill off ExportHelper. It had become clutter that was only used once 2011-03-27 13:09:26 +08:00
Jesse Vincent b3b8302c52 Remove some vestiges of HashSet 2011-03-27 12:40:00 +08:00
Jesse Vincent 9deeaf9c11 No longer export global settings when exporting one account 2011-03-27 12:03:23 +08:00
Jesse Vincent 52825f409f As suggested by cketti, HashSet -> Set in our method signature
definition
2011-03-27 11:37:37 +08:00
cketti 087feb478b First step at replacing the term "version" with "storageFormat" 2011-03-26 07:19:20 +01:00
cketti 4bdc20c127 Rename StorageVersioning to StorageFormat 2011-03-26 07:00:53 +01:00
cketti 18cefedf32 Get rid of the STORAGE_VERSION enum in StorageVersioning 2011-03-26 06:59:45 +01:00
cketti 26258d7666 Removed unused imports 2011-03-26 06:43:39 +01:00
Jesse Vincent fd38dc3519 Further wordings cleanups 2011-03-25 17:15:46 +11:00
Jesse Vincent b4a43893a3 Lift the choice of which accounts to export all the way up to
Accounts.java in advance of adding a dialog
2011-03-25 16:28:14 +11:00
Jesse Vincent b8949abaca Kill some now-dead and duplicate code 2011-03-25 15:56:25 +11:00
cketti c9510f8f16 Merge branch 'mime_type_rewriting' 2011-03-25 01:31:27 +01:00
cketti 0aa03ccdc4 Extract MIME type fixup code to method MimeUtility.getMimeTypeForViewing() 2011-03-25 00:37:53 +01:00
cketti 522634fba7 Extend AttachmentProvider to be able to get "raw" attachment
AttachmentProvider can now return an attachment with an unmodified
MIME type. However, when viewing attachments this is not desirable. So
we try hard to return a sensible MIME type (use extension to look up
a MIME type if it's originally "application/octet-stream"; or replace
with canonical MIME type if it's known to be wrong, e.g.
"image/jpg" -> "image/jpeg")
2011-03-24 23:36:59 +01:00
cketti 7c5c29e87e Move MIME type fixing to AttachmentProvider 2011-03-24 23:07:46 +01:00
cketti f3e4618702 Cosmetic + documentation changes 2011-03-24 23:04:58 +01:00
Apoorv Khatreja 168f6277da Mime type rewriting must be done only when an attachment is viewed. Therefore, removed conflicting references to rewriting code from LocalStore. 2011-03-25 05:46:11 +08:00
Apoorv Khatreja 80d99baf29 Implemented table lookup for mime type replacement (issue 873 and similar), added javadocs, moved to MimeUtility.java. 2011-03-25 05:46:11 +08:00
Apoorv Khatreja fa5901d404 Fixed issue 873 where JPEG images with the MIME type "image/jpg" failed to open on some Motorola phones. 2011-03-25 05:45:54 +08:00
cketti 83451cff10 Merge branch 'remove_non_api_dependencies' 2011-03-24 19:35:12 +01:00
cketti 277c358f87 Cache information whether or not contact picker intent is available for this device. 2011-03-24 05:19:42 +01:00
cketti b6561c8b29 Cosmetic changes 2011-03-24 05:16:25 +01:00
cketti 55440f8a18 Fixed javadoc comments 2011-03-24 05:16:25 +01:00
danapple fd468e95fb Specify a particular mime type. Although the K-9 settings file mime
type will not be generally known, specifying something in particular
means that only file browsers that can handle */* will used as options
in the chooser.  In my tests, OI File Manager responds immediately (and
the chooser is bypassed) and the camera, music and ringtone selectors
are not provided as options.
2011-03-23 00:00:24 -05:00
danapple 0a0cfac1cb Better internationalization, using real Android pluralization API. 2011-03-22 22:59:30 -05:00
Jesse Vincent e19162cb86 ant astyle 2011-03-22 18:07:47 +11:00
Jesse Vincent 81644d0f4b Initial support for a button to look up contacts in a contact provider 2011-03-22 18:07:47 +11:00
danapple 3f45df2bd4 Astyle recent changes for StorageManager listener. 2011-03-20 15:37:51 -05:00
danapple 8e5c50a8ef astyle 2011-03-20 15:21:24 -05:00
danapple 2e7a785209 Clarify logic for when an importer needs a password prompt. 2011-03-20 12:01:29 -05:00
danapple 89bdbdce94 Build a structure to allow for more easily creating new versions of
preferences Storage importers/exporters.  Password/encryption key
prompting is now down in centralized place.  On import, the password
prompt is given if the file to be imported uses an importer
implementation that requires a password and no password is provided.
On export, the password prompt is given if the chosen version is for
an exporter that requires a password and no password was provided.

For instance, for automatic backups, a password could be stored in
preferences and provided to the exporter, so no password prompt would
be given.
2011-03-20 11:52:13 -05:00
danapple 90fc3d2c8d Grey out unavailable accounts.
Display a short toast when attempting to open an unavailable account.

Conflicts:

	res/values/strings.xml
	src/com/fsck/k9/activity/Accounts.java
2011-03-19 12:36:58 -05:00
HIRANO Takahito 6c37741e63 Could not handle iso-2022-jp streams which contain continuous escape
sequences.

Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-03-19 18:05:07 +09:00
danapple c3cc43675b Grey out unavailable accounts.
Display a short toast when attempting to open an unavailable account.
2011-03-16 17:05:41 -05:00
cketti 330737c4c6 Fix length-check of BODYSTRUCTURE reply
Fixes issue 3116
2011-03-15 08:34:38 +01:00
steiler e2a7a55cf3 Issue 3104: Can't bcc to more than 1 address 2011-03-14 19:28:44 -04:00
mwolschon 6fa1f39fcc merging refs/remotes/origin/master into HEAD 2011-03-14 13:38:08 +01:00
mwolschon 0be4f95430 update issue 3130
"Allow filtering in FolderList"
2011-03-14 13:37:22 +01:00
cketti a753f1ce5c Removed unused import 2011-03-14 00:35:03 +01:00
danapple a8440032e9 Fixes Issue 3102 in cooperation with vincent...@gmail.com
Reset service enablement and MailService scheduling whenever a storage
medium is mounted or unmounted.
2011-03-12 12:27:11 -06:00
danapple 7891b24c31 Fixes Issue 3102 in cooperation with vincent...@gmail.com
Reset service enablement and MailService scheduling whenever a storage
medium is mounted or unmounted.
2011-03-09 23:04:05 -06:00
Jesse Vincent daf04c2a9c When showing the root cause of a controller failure, show a better
message if the exception wasn't generated internally
2011-03-09 22:45:57 -05:00
Jesse Vincent a54cf7a757 Tempfail outgoing messages after 5 delivery attempts 2011-03-09 22:45:57 -05:00
Jesse Vincent 2affa9d52b Permanent failures when trying to deliver a message move it back to
drafts.

Opening a "permfail" message takes you to the drafts folder
2011-03-09 22:45:57 -05:00
Jesse Vincent d80a941dba Split out "tempfail" and "permfail" message deliver errors 2011-03-09 22:45:57 -05:00
Jesse Vincent c305397d05 Fix "sending message failed" notifications to actually report the server
error
2011-03-09 22:45:57 -05:00
Jesse Vincent 9996d80080 When making sure not to offer up the outbox as a potential folder for
things like Drafts or Inbox, use a case-insensitive comparison
2011-03-09 16:32:25 -05:00
Jesse Vincent 79a4557500 Switch K-9 to using the SMTP submission port rather than the regular
server-to-server transport port.
2011-03-09 00:21:16 -05:00
baolongnt 06ecc11ee7 Merge commit '4586ba560e3498ead43fc4eacb7a92a3ce62de75'
Merged branch issue-3060 to master: Option to hide special accounts
2011-03-06 16:53:21 -08:00
cketti 171711fa9c Remove trailing space from IMAP command
This could be the cause of the error reported in issue 3089.
2011-03-04 03:36:52 +01:00
danapple 4f59a04fd5 Make importer usable by other things handling InputStreams, like a
facility to use the Android-wide Backup Service.
2011-03-03 10:14:19 -06:00
danapple 9224876768 Make exporter usable by other things handling OutputStreams, like a
facility to use the Android-wide Backup Service.
2011-03-03 10:00:58 -06:00
danapple fdb38da2e5 Discourage accidental deletion of essential mime types. 2011-03-02 19:28:36 -06:00
Andrew Chen 5a22137d54 Use <pre> instead of <div> so that plain text clients get the line wrapping correct. 2011-03-02 08:17:36 -08:00
danapple 32b5afc702 astyle 2011-03-02 07:34:54 -06:00
danapple 107408c0d9 K-9 Mail now opens the Accounts Activity when started with an Intent
with an enclosed URI with a content type of application/x-k9settings.
This allows a user to bootstrap K-9 Mail configuration by email a
settings file from one device to another, perhaps using a GMail
account on the receiving end.
2011-03-01 22:34:41 -06:00
danapple d9cb84047b Delete obsolete import 2011-03-01 21:43:43 -06:00
danapple 88f6034cbb When emailing a K-9 settings export file, use specific special content type. 2011-03-01 21:43:11 -06:00
danapple 9cd5f61539 Change import/export completion Toasts to Dialogs. 2011-03-01 21:21:00 -06:00
Koji Arai da34a5ec8c Avoid IllegalArgumentException for Charset.forName(null). 2011-03-02 00:59:20 +09:00
danapple 8a3e1336e0 Although I believe SimplyCrypto was made available without
restriction, with no license, K9Krypto is a completely new, completely
taint-free implementation of encryption for K-9 Mail settings files.

Also, K9Krypto reuses the cryptography infrastructure
between strings, so should be more efficient.
2011-02-28 21:27:58 -06:00
cketti 203dab5c64 Revert changes for issue 549 (import/export settings).
The feature will be polished in branch "issue549".
2011-02-28 22:55:34 +01:00
danapple 7b82061535 Add provenance explanation. 2011-02-27 22:22:09 -06:00
danapple a756f70eb6 Turn off some logging 2011-02-27 13:36:36 -06:00
danapple a7e134164f Handle pluralization of import toasts. 2011-02-27 13:35:59 -06:00
danapple 932d178679 Merge branch 'issue549'
Conflicts:
	src/com/fsck/k9/Account.java
	src/com/fsck/k9/K9.java
	src/com/fsck/k9/Preferences.java
	src/com/fsck/k9/activity/Accounts.java
	src/com/fsck/k9/activity/ActivityListener.java
	src/com/fsck/k9/activity/ChooseFolder.java
	src/com/fsck/k9/activity/FolderInfoHolder.java
	src/com/fsck/k9/activity/FolderList.java
	src/com/fsck/k9/activity/K9Activity.java
	src/com/fsck/k9/activity/K9ListActivity.java
	src/com/fsck/k9/activity/MessageList.java
	src/com/fsck/k9/activity/MessageReference.java
	src/com/fsck/k9/activity/MessageView.java
	src/com/fsck/k9/activity/setup/AccountSettings.java
	src/com/fsck/k9/controller/MessagingController.java
	src/com/fsck/k9/crypto/Apg.java
	src/com/fsck/k9/helper/DateFormatter.java
	src/com/fsck/k9/helper/DomainNameChecker.java
	src/com/fsck/k9/mail/Address.java
	src/com/fsck/k9/mail/internet/MimeHeader.java
	src/com/fsck/k9/mail/internet/MimeMessage.java
	src/com/fsck/k9/mail/internet/MimeUtility.java
	src/com/fsck/k9/mail/store/ImapStore.java
	src/com/fsck/k9/mail/store/LocalStore.java
	src/com/fsck/k9/mail/store/WebDavStore.java
	src/com/fsck/k9/mail/transport/SmtpTransport.java
	src/com/fsck/k9/view/AttachmentView.java
2011-02-27 13:09:38 -06:00
danapple 807f85d38e Astyling recent change 2011-02-27 11:10:32 -06:00
danapple f0a8d2edee Update date formatter on when importing preferences. 2011-02-26 19:28:47 -06:00
danapple ad3dd07a7a astyle-d 2011-02-26 18:39:06 -06:00
cketti 4724848a5a Merge branch 'focus_to_box' 2011-02-27 01:26:04 +01:00
cketti 766674c27c Code/comment cleanup 2011-02-26 23:04:49 +01:00
cketti 6686b3e993 Merge branch 'remove_bouncycastle_dependency' into HEAD 2011-02-26 22:59:48 +01:00
Jesse Vincent c7a3b28289 Change our technique for sending \r\n at the end of smtp commands to
deal with a weird failure on honeycomb
2011-02-26 16:53:53 -05:00
danapple 6dc94fb78e First mostly working copy of export/import. Committing while I sort
out how to use git.
2011-02-26 11:31:56 -06:00
cketti 6f90d791b5 Removed dependency on (external) commons-codec and commons-logging 2011-02-26 17:36:18 +01:00
cketti 77f4625cd9 Use SslCertificate that is part of the official Android API instead of
BouncyCastle's X509Name (which is not shipped anymore in Android 3.0)
to verify domain names on SSL/TLS connections.
2011-02-26 16:57:58 +01:00
baolongnt 457479cd43 Removed dup check (keeping the more explicit one) per cketti recommendation 2011-02-25 14:49:39 -08:00