1653 Commits

Author	SHA1	Message	Date
mwolschon	673b1fdf94	bugfix for ... 2e981afaed ( forgot a call to finish() )	2011-02-10 07:59:29 +01:00
Andrew Chen	a51daf9798	Use interface Map.Entry.	2011-02-09 11:06:01 -08:00
cketti	14abb68772	Get rid of the "Fwd: " prefix when sharing a message. Add recipients ... to the intent ("To:" -> EXTRA_EMAIL, "CC:" -> EXTRA_CC)	2011-02-09 07:08:10 +01:00
cketti	7e824fc748	Log error message when switching local storage provider fails.	2011-02-09 06:58:06 +01:00
Marcus Wolschon	2e981afaed	if account is not ready (sd-card removed), fall through to the ... "else"-case, so onItemClick -handler still gets registred. Else inserting the SD-card without leaving the activity, THEN clicking the account will not do anything.	2011-02-08 08:56:08 +01:00
Jesse Vincent	2aee63e242	make it possible to define Providers that don't require ... username+password auth	2011-02-07 22:07:31 -05:00
Jesse Vincent	7cd99bdfd2	When some message has an Application/octet-stream .jpg attachment, be a ... bit more lenient and treat it as application/octet-stream, so we can look up the content type by file extension	2011-02-07 20:34:08 -05:00
Jesse Vincent	bb1e66c70d	If android's content-type lookup says "why yes, I have no idea what that ... is", at least look at our local list	2011-02-07 20:33:46 -05:00
Jesse Vincent	12d1097a24	Big, scary massive "ant astyle" to get us back to something ... approximating AOSP coding standards.	2011-02-06 17:09:48 -05:00
Andrew Chen	cc9d6ac5ea	Add button to allow editing of quoted message in HTML mode by dropping user back to text mode. Fixes issue 2959.	2011-02-05 15:14:02 -08:00
cketti	d2561f19af	Removed unused imports ... git-svn-id: https://k9mail.googlecode.com/svn/k9mail/trunk@3270 9a7fa126-a48b-11dd-a887-7ffe1a420f8d	2011-02-04 23:19:07 -05:00
Dan Applebaum	4842051de6	Immediately update the title bar when the syncing status changes due to external events.	2011-02-04 23:19:06 -05:00
Andrew Chen	19d863ee41	Move linkification into a separate method. Linkify text in textToHtmlFragment. Fixed Issue 2951.	2011-02-04 23:19:06 -05:00
Andrew Chen	1b37fc69f6	Another potential NPE fix.	2011-02-04 23:19:06 -05:00
Dan Applebaum	e31d218dc5	At Jesse's suggestion, avoid the use of the Android term-of-art "density". Instead use "Compact layouts" to refer, both internally and externally, to the feature of elminating minimum sizes on UI elements and other minor layout changes for maximizing information quantity to be displayed on a page. ... Others are free to adjust the user-facing text further.	2011-02-04 23:19:06 -05:00
Andrew Chen	66f6999c53	Fix for NPE introduced in r3258.	2011-02-04 23:19:06 -05:00
Dan Applebaum	40bdf99925	Fixes Issue 2934 Fixes Issue 2935 ... Provides for storing Folder Settings in the central Preferences Storage as a back-up to the settings stored on each folder. In this way, even if the LocalStore DB is recreated or otherwise lost, Folder Settings can be recovered. 1) Does not change the methodology used to read settings while running, nor the changes in r3107 & r3116 which tremendously improve Accounts list loading time. 2) Loads Folder Settings from Preferences and stores on the folder only when creating a new LocalFolder 3) Saves Folder Settings to Preferences and the DB row every time the Folder Settings are changed. 4) When upgrading from DB version 41 to 42 or later, copies all settings for existing folders from the DB storage to the Preferences Storage. 5) Transactional bulk folder creation and single pass local folder existence check during "Refresh folders" operation drastically reduces time spent when refreshing folders from the remote store. 6) Uses prepared statement during Editor commit to reduce Preference storing time. Probably needs a reversion of r3239, but I'm unfamiliar with translations, so am leaving that to others' discretion.	2011-02-04 23:19:06 -05:00
Dan Applebaum	ea3619b733	Display a message in the titlebar when K-9 Mail is not performing any message synchronization. This state will happen when no network is available, when background ops/background data/auto-sync settings turn off synchronization, or when no account is set for polling or pushing. ... This revision respects the intention of r3011 that when K-9 Mail is set for pushing only no message is displayed, as that condition is a normal state. However, it provides valuable feedback in other cases that synchronization is off-line, as was done in r1433. Although the case when the user has intentionally set no account for polling or pushing can be considered "normal" and therefore unworthy of a message, it turns out to be a significant burden to detect that situation when the network is offline, since we normally do not even try to figure out the account configurations in that case. Therefore, without making substantial, otherwise unwarranted, changes to MailService.java, "Syncing off" would be displayed sometimes to such a user, and sometimes not. Since it is presumably a rare case, and there is minimal harm to display the "Syncing off" message, the message will be consistently displayed when no account is set for polling or pushing. Note to translators: "Syncing off" is different than "Polling off". The new phrase "Syncing off" means that K-9 Mail is not performing any synchronization with any mail server. The prior non-English phrases for "Polling off" are currently in-place as translations for "Syncing off", as it seems that the meanings are close enough that it would be better to show the obsolete translations that to fallback to the English "Syncing off". However, better translations of "Syncing off" would be welcome.	2011-02-04 23:19:06 -05:00
Andrew Chen	33e5520a9d	Mark messages as ANSWERED only on send. Save a reference to the message in the identity so that loading a draft of a reply also marks the referenced message correctly.	2011-02-03 06:32:29 +00:00
Daniel Applebaum	6c03c968ef	Provide for users with good eyesight to completely take advantage of the ... "smaller" (and smaller) fonts by allowing the Accounts and Folder List items to have a height smaller than the normal Android minimum. This option is off by default to maintain existing behavior for uninterested parties. The preferences text is not especially compelling so could certainly be changed if better phrasing is found.	2011-02-03 03:42:45 +00:00
Andrew Chen	5fa757bba1	Only include name with an address if it's non-empty.	2011-02-03 03:35:50 +00:00
Jesse Vincent	ff0f517cbb	Configure MIME4J to not die when there are long header lines or a large message header	2011-02-01 20:48:20 +00:00
Kris Wong	9e5435a5f3	Fix the ability to accept invalid SSL certificates for exchange support.	2011-02-01 13:15:54 +00:00
Jesse Vincent	3d090e9626	astyle	2011-01-31 23:45:23 +00:00
Jesse Vincent	6550151684	Add serialVersionUID to Serializable classes to make eclipse happy	2011-01-31 23:45:14 +00:00
Jesse Vincent	4d5381f33d	Turns out to be some code which tries to be clever about removing the ... multipart envelope in LocalStore.java. It is thrown away if there is just one item in the multipart. This breaks the display of attachment only message, since the attachment is no longer detected by the code which creates the view. I made a fix (see patch below) which checks if the single item in the multipart is not a attachment. -- patch from wernermann29 at googlemail.com	2011-01-31 01:54:27 +00:00
Andrew Chen	fe8ba6078e	Propagate the ACTION_DOWN event to the ScrollView so we can stop scrolling after a fling. Fixes issue 2892.	2011-01-30 22:05:47 +00:00
Jesse Vincent	65dc3c7d1b	Fix display of icon in About box on Android 2.1 and earlier	2011-01-30 15:11:16 +00:00
cketti	bec094326a	Make decodeQ() actually use the "fixed up" string. Will fix Q-encoded subjects where space is encoded as "_". ... Fixes issue 2926	2011-01-30 03:00:46 +00:00
HIRANO Takahito	07814db9f4	Fix range check for ISO-2022-JP stream. ... Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>	2011-01-29 17:56:58 +00:00
cketti	555e6431b2	Add credits for third-party libraries and emoji icons to about box	2011-01-29 02:49:39 +00:00
Kris Wong	88d0af16a5	Updated Exchange setup view.	2011-01-28 22:45:10 +00:00
Andrew Chen	13898f7edf	Fix the way newlines are added in HTML mode.	2011-01-28 21:41:06 +00:00
Jesse Vincent	5e7982a31b	first pass at a better about box	2011-01-28 18:30:35 +00:00
cketti	a213ca2fb7	Correctly parse email addresses (from contacts). Could be of the form "User name <user@example.com>". ... Fixes issue 2920	2011-01-28 06:01:10 +00:00
Jesse Vincent	4a558c5ac5	Revert the active part of "Update issue 848" ... This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d. It turns out that disabling the "View attachment" button (rather than giving a useful error message telling the user what mime type the app needs to support) was confusing to users.	2011-01-28 03:33:49 +00:00
Andrew Chen	840fa7bf40	Replace concatenation in StringBuilder with append.	2011-01-25 04:25:27 +00:00
Andrew Chen	ba1709770e	Issue 854 - Fix reply after quote in HTML mode.	2011-01-25 03:56:19 +00:00
cketti	e5b172b7bb	Fix warnings	2011-01-25 02:36:08 +00:00
cketti	737edf369b	Use new contacts API on Android 2.0, 2.0.1, and 2.1 devices with additional code to match by phonetic names. ... Fixes issue 2906	2011-01-25 02:34:02 +00:00
cketti	de9f04ea0d	Avoid IllegalArgumentException - Only fetch display name in getOwnerName()	2011-01-25 02:29:31 +00:00
cketti	57be868668	Added some comments	2011-01-25 01:32:31 +00:00
Marcus Wolschon	ba24fdc742	update issue 2744 ... try all addresses of a host. (Fix is required for proper operation in IPv4-only/IPv6-only networks for IPv4/IPv6 dual-stack mail-hosts)	2011-01-24 15:09:36 +00:00
Jesse Vincent	04e4dcb187	code reindenting	2011-01-24 03:27:26 +00:00
Jesse Vincent	59b3c1ba89	Extract out the list of folder columns	2011-01-24 03:27:19 +00:00
Jesse Vincent	22f422ea29	Use a heuristic to try to avoid notifying POP3 users about older mail ... messages	2011-01-24 03:27:14 +00:00
Jesse Vincent	7858f72c53	Remove commented out code. that's what a version control system is for	2011-01-24 03:27:08 +00:00
Jesse Vincent	3444bb4134	Remove some duplicate code in the pop3 implementation	2011-01-24 03:26:57 +00:00
cketti	6a2233cdd0	Removed unnecessary imports	2011-01-23 13:59:15 +00:00
Jesse Vincent	24d03ce662	Deal with potential NPEs if folders aren't set up, as happens on new ... accounts	2011-01-23 02:26:14 +00:00
Jesse Vincent	098851684f	astyle	2011-01-23 00:56:01 +00:00
Jesse Vincent	c06643bd47	Add a preference to allow users to always show email addresses instead ... of the "friendly" parts of email addresses.	2011-01-23 00:55:46 +00:00
Jesse Vincent	a234c39722	astyle	2011-01-19 21:33:23 +00:00
Jesse Vincent	8329a0287b	Upgrade to mime4j. "0.7" branch as of ... http://svn.apache.org/repos/asf/james/mime4j/trunk@1058339	2011-01-19 21:32:09 +00:00
cketti	f5bb836087	Fix code that was broken when fixing warnings.	2011-01-19 21:00:28 +00:00
Andrew Chen	b1d8e49d72	Be a little more graceful when scrolling horizontally in a (vertical) scroll view. ... Not quite to the point of diagonal scrolling, but hopefully closer.	2011-01-19 17:05:56 +00:00
cketti	bcb1131cb5	Don't rely on FolderClass implementation details outside of FolderClass	2011-01-19 01:50:28 +00:00
cketti	22834d6998	Removed unnecessary null pointer checks	2011-01-19 01:30:13 +00:00
cketti	4e11c17ff5	Removed unnecessary type cast	2011-01-19 01:28:27 +00:00
cketti	7119c7165f	Removed unnecessary type casts	2011-01-19 01:21:27 +00:00
cketti	14a20843e3	Get rid of two potential null pointer access warnings	2011-01-19 00:57:12 +00:00
cketti	365b106753	Fixed warnings about unchecked casts by extracting the code to methods and using the @SuppressWarnings annotation on them.	2011-01-19 00:36:15 +00:00
cketti	d48ec4892a	Added missing annotation	2011-01-19 00:33:19 +00:00
cketti	a9cee7a6ad	Rewrote code to get rid of return statement in finally block (which generated a warning).	2011-01-19 00:23:56 +00:00
cketti	72d2d24cec	Fixed potential null pointer access	2011-01-19 00:13:58 +00:00
cketti	8f2623e33c	Rewrote code to be easier to read and not raise a potential null pointer warning by Eclipse.	2011-01-19 00:10:36 +00:00
cketti	6a9a5f6b1f	Added a null pointer check to make the static analysis component of Eclipse happy	2011-01-19 00:00:58 +00:00
cketti	8279092070	Fixed lots of warnings (unused imports/variables, missing annotations, etc.)	2011-01-18 23:54:49 +00:00
cketti	a40ec8fa98	Removed unused variables and imports.	2011-01-18 23:37:37 +00:00
Marcus Wolschon	60ea4c6ce7	Update issue 2479 ... possible fix for "The content of the adapter has changed but ListView did not receive a notification."	2011-01-18 15:34:41 +00:00
Jesse Vincent	951dbcbd33	Set up some reasonableish defaults when creating folders	2011-01-18 00:04:24 +00:00
Jesse Vincent	65e89afc40	remove a duplicate codepath for folder insert	2011-01-18 00:04:17 +00:00
Jesse Vincent	d59600653c	astyle	2011-01-18 00:04:11 +00:00
Jesse Vincent	bd66315375	Visual cleanup of messageview. Clean up of icon display codepaths	2011-01-17 17:25:00 +00:00
Marcus Wolschon	fc4b64c559	Update issue 848 ... "view" only enabled for attachments if there is an actual application on the phone to view this kind of file.	2011-01-17 10:41:48 +00:00
Marcus Wolschon	30767c3bd9	Fixed NullPointerExceptions	2011-01-17 10:28:58 +00:00
Jesse Vincent	6504d592ea	Try harder not to use "special folders" as count sources	2011-01-17 04:06:34 +00:00
Jesse Vincent	890564b926	Missed a case for stats computation	2011-01-17 03:22:30 +00:00
Jesse Vincent	30fed01784	Replace the expensive part of Account.getStats() that loaded all folders ... and iterated through them with a SQL query.	2011-01-16 21:33:58 +00:00
Jesse Vincent	5a5541b400	Don't notify for new mail in a designated spam folder	2011-01-16 21:33:54 +00:00
Jesse Vincent	734cbf856d	Simplify the logic for "should I search this folder" using our new ... helper	2011-01-16 21:33:50 +00:00
Jesse Vincent	a974f7188c	Simplify folder-skip logic when cleaning out folders deleted on the ... server. (Note that we no longer delete the archive folder locally, even if it's killed upstream)	2011-01-16 21:33:46 +00:00
Jesse Vincent	c5846b4202	simplify our "should we count messages in this folder" logic for the ... purposes of account stats generation	2011-01-16 21:33:43 +00:00
Jesse Vincent	76e1165fea	we no longer need the special version of getDisplayClass	2011-01-16 21:33:39 +00:00
Jesse Vincent	574c544d64	new helper routine for checking to see if a folder is special.	2011-01-16 21:33:34 +00:00
Jesse Vincent	5fb8b7c7e5	only do one preferences update per account when upgrading. Big perf ... boost	2011-01-16 04:23:12 +00:00
Jesse Vincent	38ba071172	astyle	2011-01-16 04:23:08 +00:00
Jesse Vincent	4d0f489ab4	Initial implementation of folder attributes on the folder, rather than in preferences	2011-01-16 04:23:03 +00:00
Jesse Vincent	cafa08fc6a	generalize some repeated code	2011-01-16 04:22:59 +00:00
Jesse Vincent	ab5c7ea6ff	Refactoring of emoji transcoding code into the htmlconverter class	2011-01-15 15:25:48 +00:00
Jesse Vincent	4dcf32d2a9	Call the routine to convert emoji to images only when a message actually contains emoji. ... This is to solve the performance issue repoted by jesse in Issue 2657. Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>	2011-01-15 15:25:42 +00:00
Jesse Vincent	711b4763e9	Tweak our message list subject default a bit bigger to set it off from the other text.	2011-01-14 03:54:00 +00:00
Jesse Vincent	aacb414004	astyle	2011-01-14 01:37:52 +00:00
Jesse Vincent	8bb7613471	Update URL regexes by importing from AOSP and then from IANA	2011-01-14 01:37:46 +00:00
Jesse Vincent	d1a1b12aae	Support emoji in subjects. ... Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>	2011-01-14 00:53:19 +00:00
Jesse Vincent	e36ead77c4	ant doesn't like the unicode symbol	2011-01-13 16:28:57 +00:00
Jesse Vincent	da22ffdcea	standardize the formats of our wakelock messages to be able to better audit them	2011-01-13 01:18:40 +00:00
Andrew Chen	e56b044bbc	Add support for HTML composition with text alternative. ... Revamp K9 Identity string. Quote names in Address only when needed. Remove quoted text bar and move button to quoted text area.	2011-01-12 23:48:28 +00:00
Andrew Chen	ed4aec26f1	Removed bogus javadoc param.	2011-01-12 06:24:00 +00:00
Andrew Chen	c07c7052dc	Add Notification setting to disable unread count in notification bar.	2011-01-12 01:23:17 +00:00
Andrew Chen	a17c21f0cd	Add null check in header view to prevent NPE.	2011-01-11 22:25:06 +00:00
cketti	ba6a92b432	Removed unnecessary import.	2011-01-11 03:49:11 +00:00
cketti	a03f75dd5e	Updated javadoc comment	2011-01-11 03:48:30 +00:00
cketti	3aba9e11ae	Code/comment cleanup	2011-01-11 03:40:43 +00:00
cketti	d403e36f06	Don't count on skip() to actually skip as many bytes as requested.	2011-01-11 03:27:58 +00:00
cketti	c7a7d832e7	Better handle the case where a list in an IMAP response is prematurely ended by CRLF. ... Fixes issue 2852	2011-01-11 03:10:24 +00:00
Andrew Chen	b4635e53b5	When editing a draft, only show the BCC field if it has entries other than the auto-bcc for that account. ... This makes draft editing behavior the same as new composition.	2011-01-11 02:49:00 +00:00
Andrew Chen	e19f742678	Consolidate exception catching in processSourceMessage into a single try/catch block. ... Add error logging if we do have an exception.	2011-01-10 20:12:08 +00:00
Jesse Vincent	9d5704c0f5	Split the Header view out from the MessageView activity	2011-01-10 17:47:28 +00:00
Jesse Vincent	052695af83	Simplify Contacts API	2011-01-10 17:47:23 +00:00
Jesse Vincent	0ca6adfbf8	move DateFormatter from Activity to Helper	2011-01-10 17:47:16 +00:00
Andrew Chen	5fe33f2c62	remove dead isInUse code.	2011-01-07 21:41:27 +00:00
Jesse Vincent	b2c44579d2	lift "displayMessage" out of a callback	2011-01-06 16:56:55 +00:00
Jesse Vincent	39ef6584a8	continue to extract attachment code out to AttachmentView	2011-01-06 16:56:37 +00:00
Jesse Vincent	19c5324316	Extract AttachmentView and MediaScannerNotifier into their own classes	2011-01-06 16:56:20 +00:00
Jesse Vincent	ed60cdfa5a	replace constant lookups of the MessagingController instance with a locally cached one	2011-01-06 16:56:02 +00:00
Jesse Vincent	299c057cd4	minor code cleanup	2011-01-06 16:55:48 +00:00
Jesse Vincent	9c847d3e9d	minor code cleanup	2011-01-06 16:55:34 +00:00
Jesse Vincent	de806f7715	astyle	2011-01-06 16:55:08 +00:00
Andrew Chen	aa0eeac736	Show the correct quote style options at preference load time.	2011-01-06 07:05:57 +00:00
Andrew Chen	f9ddc7eb06	Remove extraneous colon.	2011-01-06 01:34:08 +00:00
Andrew Chen	74e6384236	Fix potential NPE.	2011-01-06 01:31:28 +00:00
cketti	f9f6160719	Correctly encode/escape strings when used in IMAP commands. ... Fixes issue 2832	2011-01-06 00:39:09 +00:00
Andrew Chen	5fef7f3b07	Add support for Outlook-style quote headers as a preference under Account Settings -> Sending Mail. ... Refactor forwarding header (header-style quote header) into individual string pieces that are assembled in code to accommodate future HTML version of headers. Introduced four new strings for translation.	2011-01-05 23:58:14 +00:00
Jesse Vincent	9f4790088e	Escape backslashes in IMAP mailbox names	2011-01-05 13:12:30 +00:00
Andrew Chen	ead632aac6	Refactor html/text conversions into its own class. ... Add more tags to be ignored during HTML to plain text conversion. Remove UTF-8 non-breaking spaces from generated text.	2011-01-05 04:26:33 +00:00
Jesse Vincent	f8f916edde	Make contacts searchable from phonetic names on Eclair and earlier. ... Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>	2011-01-04 14:33:02 +00:00
Jesse Vincent	2daf8eaec8	Allow emoji input. ... Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>	2011-01-04 13:25:59 +00:00
Jesse Vincent	d25f12fa16	Switch K-9 from generating X-User-Agent to User-Agent headers. ... Fixes issue 1917	2011-01-04 08:33:12 +00:00
Andrew Chen	f3e75d564a	Add custom HTML tag handler to be used when converting HTML to Text. ... Hides code in STYLE and SCRIPT tags and adds text-equivalent of HR.	2011-01-04 06:58:13 +00:00
Jesse Vincent	40344aea41	support iPad mail too	2011-01-03 18:12:35 +00:00
Jesse Vincent	0a8514888e	Map emoji code points defined by mobile carriers to ones defined by ... Google in order to support various carriers. Patch by HIRANO Takahito <hiranotaka@zng.info>	2011-01-03 18:07:44 +00:00
Andrew Chen	68ded8aa3e	Add some more documentation about temporary notification avoidance code using UIDs.	2011-01-03 03:26:31 +00:00
Andrew Chen	e794af0bbf	Prevent new mail notifications if they're older than our most recent message. ... First attempt at fixing Issue 1276. Only works with services that use numeric message IDs, like IMAP.	2011-01-02 09:01:23 +00:00
cketti	fe724c8c79	Changed SMTP code to handle reply codes without additional text. ... Fixes issue 2801	2011-01-01 18:45:33 +00:00
Andrew Chen	731ea27a24	Minor formatting cleanup.	2010-12-31 08:56:05 +00:00
Jesse Vincent	29fdb81f9b	Fix for the "K9 skips every 101st message when fetching on IMAP" bug by ... e-t172 <e-t172@akegroup.org>. Fixes Issue 2819	2010-12-30 23:57:41 +00:00
Fiouz	47762a9baa	Remove coupling between ImapStore and ImapConnection by adding an settings indirection interface. Purpose: use the IMAP connection code to validate credentials without having an actual ImapStore instance.	2010-12-30 21:57:59 +00:00
cketti	a1e059e871	Introduced setting to change the font size of the message preview in the message list. ... Fixes issue 2788	2010-12-30 00:52:00 +00:00
Andrew Chen	605a0bdc93	Add more comments about LocalTextBody. ... Display decrypted PGP data as text/plain (content type was being set, but not being passed to WebViews).	2010-12-29 07:34:57 +00:00
Andrew Chen	b85f0b64c0	Fix javadoc; make constant all caps.	2010-12-29 07:17:43 +00:00
cketti	cb97c312fc	Move ColorChip to the correct directory	2010-12-28 23:37:47 +00:00
Jesse Vincent	777f75b5c4	Stop showing "Not polling" in the status header. Most of the time, this ... is because we're pushing.	2010-12-28 09:12:02 +00:00
Jesse Vincent	8bc984f440	APG-related messageview bugfixes	2010-12-28 09:11:35 +00:00
Jesse Vincent	0c426c9c4b	Round our color chips, clean up color hcip rendering a bit	2010-12-28 09:11:10 +00:00
Jesse Vincent	4c9c478d8d	minor code and doc cleanups as recommended by IntelliJ	2010-12-28 09:10:50 +00:00
Jesse Vincent	bbf65f1335	remove temporary variables	2010-12-28 09:10:30 +00:00
Jesse Vincent	b166cf03e8	split apart attachment view creation a bit	2010-12-28 09:09:52 +00:00
Jesse Vincent	3c9eb2c004	Further refactoring of message display	2010-12-28 09:09:33 +00:00
Jesse Vincent	9fe56831bf	finish removing setHeaders as a layer of indirection	2010-12-28 09:09:15 +00:00
Jesse Vincent	8116a0f39f	lift some gpg code into the crypto initializer	2010-12-28 09:08:58 +00:00
Jesse Vincent	3ffa28fa02	we import so we don't need to qualify	2010-12-28 09:08:40 +00:00
Jesse Vincent	85a7a08e9a	Rename our attachment view holder from Attachment to AttachmentViewHolder	2010-12-28 09:08:18 +00:00
Jesse Vincent	6a04afb758	extract "does it have html images" out of MessageView. really, it should ... end up in LocalMessage somewhere	2010-12-28 09:07:59 +00:00
Jesse Vincent	7623a02852	lift the "get display text" code out of the messageview and into ... localmessage	2010-12-28 09:07:39 +00:00
Jesse Vincent	84f6e546d2	setLoadPictures sets mShowPictures. We don't need to set it again	2010-12-28 09:07:19 +00:00
Jesse Vincent	f292251b78	lift createUniqueFile to a Utility class	2010-12-28 09:06:57 +00:00
Jesse Vincent	570dbf7126	split apart onCreate into bite-sized pieces	2010-12-26 03:51:33 +00:00
Jesse Vincent	43e3e860f8	doc fix	2010-12-26 03:49:52 +00:00
Jesse Vincent	d352b8a4a5	whitespace	2010-12-26 03:49:23 +00:00
Jesse Vincent	f2b2fddd5a	onRefile removes code duplication	2010-12-26 03:49:20 +00:00
Jesse Vincent	db02383d4a	whitespace cleanups	2010-12-26 03:49:16 +00:00
Jesse Vincent	8488b55e09	remove some duplicated code	2010-12-26 03:49:13 +00:00
Jesse Vincent	8c6df94739	remove some temp variables	2010-12-26 03:49:09 +00:00
Jesse Vincent	877427f110	cut down a couple overly verbose conditionals	2010-12-26 03:49:06 +00:00
Jesse Vincent	daf5a9d704	lift emulateShiftHeld to our custom WebView subclass	2010-12-25 22:30:34 +00:00
Jesse Vincent	8e2e4e515f	simplify MessageView's setHeaders	2010-12-25 22:30:31 +00:00
Jesse Vincent	8b52aac135	remove unused imports	2010-12-25 22:30:27 +00:00
Jesse Vincent	76fd8e9939	extract animation code from MessageView	2010-12-25 22:30:22 +00:00
Jesse Vincent	5f9eae1580	Extract MessageWebView specific code into a new class	2010-12-25 22:30:16 +00:00
Jesse Vincent	ea4e0aa61f	remove a bunch of extraneous code and variables	2010-12-25 19:29:02 +00:00
Jesse Vincent	9f24ea2b03	minor code cleanup	2010-12-25 19:28:58 +00:00
Jesse Vincent	91ab617807	rename "hide buttons" to "scroll buttons" because that's what it does	2010-12-25 19:28:54 +00:00
Andrew Chen	dc5616c4b6	Add a space between recipients when doing toString().	2010-12-25 01:36:48 +00:00
Andrew Chen	77c01c65dd	Refactor network data blocking out of the main K9 class and into the MessageView class.	2010-12-25 01:26:47 +00:00
Jesse Vincent	f14c7ecd9b	doc & comment updates from achen.code	2010-12-25 00:27:09 +00:00
Jesse Vincent	c361c0e63c	Extract a method to set up our MessageView WebView	2010-12-25 00:27:05 +00:00
Jesse Vincent	1fae914efb	tiny doc update from achen.code	2010-12-25 00:26:59 +00:00
Jesse Vincent	db7649c9af	move folderlist initialization into an asynctask, so it's not so slow to populate	2010-12-24 22:48:29 +00:00
Jesse Vincent	b99eb47d15	extract folder preference setup to a method, so we can push it onto a thread	2010-12-24 22:48:26 +00:00
Jesse Vincent	4a97f4a1a0	astyle	2010-12-24 22:48:22 +00:00
Jesse Vincent	fa510f2dab	Turns out that UUID generation is expensive. deferring it until first access improves startup performance.	2010-12-24 22:48:19 +00:00
Jesse Vincent	d64d9c460a	Disable webview cache and javascript. (Mail + Javascript == scary)	2010-12-24 22:48:17 +00:00
Jesse Vincent	df96d0fbe0	avoid use of a temp variable	2010-12-24 22:48:14 +00:00
Jesse Vincent	30b7402569	We shouldn't be resetting visible limits every time K-9 is opened, only when the user changes ... how many messages they want to be synced, otherwise the "fetch more messages" option is session-only, which is really, really wasteful of network. (and "session" is poorly defined, since android manages our lifecycle.) Additionally, doing this at startup has huge overhead. If this functionality is ever restored, we should make it asynchronous	2010-12-24 22:48:11 +00:00
Jesse Vincent	9878b74379	astyle	2010-12-24 18:55:05 +00:00
Jesse Vincent	c49a856046	Enable Strict Mode when a new "developer mode" is enabled and we're running on 2.3 or newer	2010-12-24 18:55:01 +00:00
Jesse Vincent	0b3dc2840b	Bump us up to android-9 so we can have strict mode for development	2010-12-24 18:54:56 +00:00
Andrew Chen	2806c267c9	Remove unreadable characters from message previews.	2010-12-23 23:16:54 +00:00
Andrew Chen	302339545b	Try using IP address for EHLO if hostname is unavailable. Only use a default hostname if the IP address is unavailable. ref r2958, issue 2750.	2010-12-23 17:43:57 +00:00
Andrew Chen	6c52c8d927	Set a default hostname if we can't get the local hostname. Fixes issue 2750.	2010-12-23 17:15:20 +00:00
Andrew Chen	f5421f32b8	Fix bug where replaceAll result was being discarded. ... Fix javadoc.	2010-12-22 22:08:15 +00:00
Fiouz	df44a1f89b	Add @Override annotations (1.6) for safer compile-time checks	2010-12-20 21:34:01 +00:00
Fiouz	0abbeb443e	Batch storing of unsynced messages to speed up DB update (chunk size set to 5). ... Execution code path is modified since it's not longer handling one message at a time when inserting in DB - might require review.	2010-12-19 11:51:54 +00:00
Jesse Vincent	eda76640c0	When mail is sent successfully, cancel the "couldn't send mail" ... notification	2010-12-19 01:30:11 +00:00
Jesse Vincent	b59eb6c69f	lift lastFailure up so we can reference it in an outer scope	2010-12-19 01:30:07 +00:00
Jesse Vincent	dbe4bea290	Give our "send failed" notification a contant	2010-12-19 01:30:03 +00:00
Fiouz	ab5caba92c	Factor out store locking code in an intermediate DB access layer.	2010-12-18 22:56:40 +00:00
Fiouz	c5f7dbf028	Execute LocalMessage.appendMessage() & LocalMessage.setFlag() in the same transaction for small message storing in order to speed up DB update. ... This is a per message basis optimization. More improved speed could be attained by batching several messages in the same transaction.	2010-12-18 10:12:52 +00:00
Kris Wong	bb5052f848	Fix possible NPE.	2010-12-17 17:25:27 +00:00
Kris Wong	623217f6d0	Improved fallback authentication methods + ran source formatter.	2010-12-17 14:40:19 +00:00
Jesse Vincent	0778c8ea17	Provisional fix for Issue 2760 in k9mail: New NPE from market. showing up a lot on 3.400	2010-12-16 02:38:54 +00:00
Kris Wong	33f5a42562	Fix usage of 'advanced' exchange settings.	2010-12-15 17:00:54 +00:00
Fiouz	f8f2169643	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:27:11 +00:00
Fiouz	caabbd735a	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:27:04 +00:00
Fiouz	0d23157e3b	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:57 +00:00
Fiouz	05a8a31d4a	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:51 +00:00
Fiouz	fb348449c3	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:44 +00:00
Fiouz	63a8197f5a	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:37 +00:00
Fiouz	64b5655d7c	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:31 +00:00
Fiouz	36858f53de	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:25 +00:00
Fiouz	9d01876481	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:18 +00:00
Fiouz	dcbfd332ab	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:09 +00:00
Fiouz	a667a72585	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:26:02 +00:00
Fiouz	4024ddd384	Don't reference the enclosing type instance when it's not used (memory optimisation)	2010-12-14 19:25:56 +00:00
Kris Wong	2b56464ad9	Fix form based re-authentication when logon cookies had expired.	2010-12-14 18:02:39 +00:00
Jesse Vincent	5e7257492d	small cleanups to messageview code	2010-12-13 01:56:57 +00:00
Jesse Vincent	063bbb904f	Extract SizeFormatter into helpers	2010-12-13 01:02:39 +00:00
Jesse Vincent	23b57b4502	remove a duplicated and divergent size formatter	2010-12-13 01:02:35 +00:00
Jesse Vincent	936b2779d6	fixup onNext was overloaded (due to the flinger) - at least unify the ... protection level	2010-12-13 01:02:31 +00:00
Jesse Vincent	2451dde1bc	simplify our "should we animate" checks in messageview (also, we now ... honor the animation preference when using the volume keys to navigate)	2010-12-13 00:37:31 +00:00
Andrew Chen	b0e4d9cdff	Try calculating content preview from HTML part if text part is unsuccessful on appendMessages.	2010-12-13 00:33:00 +00:00
Jesse Vincent	26712ed84a	reshuffle color views into view/	2010-12-13 00:18:00 +00:00
Jesse Vincent	76b6fa696b	Move the ToggleScrollView into the view/ hierarchy	2010-12-13 00:17:54 +00:00
Jesse Vincent	aa2960eb04	move the AccessibleEmailContentActivity into activity/	2010-12-13 00:17:49 +00:00
Jesse Vincent	f97d4289ca	Start moving custom views into the view/ hierarchy	2010-12-13 00:17:44 +00:00
Jesse Vincent	4bb5acb51c	Revert "stop fading the chip if a message is read. we already change text" ... It's contentious to change, apparently. So, revert until it's a setting This reverts commit a6060fa66c8ae6001c402b0f3ac3d240b7348b8e.	2010-12-07 01:22:35 +00:00
Marcus Wolschon	f5420ac528	readable thread-name for debugging ... javadoc	2010-12-06 09:25:23 +00:00
cketti	9f7b447181	POP3: Ignore messages without unique-id when parsing UIDL response ... Fixes issue 2731	2010-12-01 18:14:12 +00:00
Jesse Vincent	f5eb6e03af	astyle	2010-12-01 06:32:29 +00:00
Jesse Vincent	e44a74c652	Get rid of a whole lot of crazy code that forced repeated attachment ... downloads with the intent of only having one attachment downloaded at a time.	2010-12-01 06:04:28 +00:00
Jesse Vincent	35f19abc9f	Improve the "Do what I mean" nature of "Empty trash" - it now syncs the ... trash folder after deletions to clear out local records of deleted messages and does a compact operation on the local store.	2010-12-01 06:04:22 +00:00
Jesse Vincent	75ec749ed4	Remove an unused "context" from a private function	2010-12-01 06:04:16 +00:00
Jesse Vincent	02acea3bbf	replying to a message you sent shouldn't end up sending mail only to you	2010-12-01 06:04:12 +00:00
Jesse Vincent	1898ceee71	Remove two retundant variables	2010-12-01 03:08:36 +00:00
Jesse Vincent	f4a54b9ecb	fix a numeric equality bug spotted by intellij	2010-12-01 03:08:09 +00:00
Jesse Vincent	78c900b5fe	remove redundant ;s	2010-12-01 03:07:28 +00:00
Jesse Vincent	75aa644a23	Remove a bunch of stringification inside of string appends (per intellij)	2010-12-01 03:06:50 +00:00
Jesse Vincent	0677bd9e77	Get rid of some redundant casts (Per IntelliJ)	2010-12-01 03:06:12 +00:00
Jesse Vincent	fde438fbfb	Get rid of some unnecessary stringification (Per IntelliJ)	2010-12-01 03:05:40 +00:00
Jesse Vincent	cead5c7060	flip some loops to using java internals instead (per intellij)	2010-12-01 03:04:57 +00:00
Jesse Vincent	5485d0faf1	switch over some for loops to enhanced for loop syntax per intellij	2010-12-01 03:04:07 +00:00
Jesse Vincent	58e6bd388b	finalize some declarations per IntelliJ	2010-12-01 03:03:22 +00:00
Jesse Vincent	c79ea226a5	Remove "throws" declarations that didn't actually get thrown. Remove a ... couple of try blocks that only caught throws we didn't throw. IntelliJ optimization.	2010-12-01 03:02:13 +00:00
Jesse Vincent	81f12f0e05	clean up a couple null checks	2010-12-01 03:01:20 +00:00
Jesse Vincent	43d9c0a6d4	Eliminate some redundant assignments	2010-12-01 03:00:36 +00:00
Jesse Vincent	2ecdc22111	simplify static final methods to just be static. (IntelliJ inspection)	2010-12-01 02:59:50 +00:00
Jesse Vincent	1ce9021ecd	Fix pinch-to-zoom. Patch by achen.code. Fixes isue 2720	2010-11-30 01:42:00 +00:00
Jesse Vincent	174a62536e	Resolves Issue 2719: Message List Previews: Read message senders are shown in bold patch from achen.code	2010-11-30 01:04:24 +00:00
Jesse Vincent	f98a2db2ab	stop fading the chip if a message is read. we already change text ... weight	2010-11-29 03:24:57 +00:00
Jesse Vincent	dbc07d14ee	Revert "http://code.google.com/p/k9mail/issues/detail?id=2682" until we ... can make it configurable, per discussion with Marcus This reverts commit 1436eeefa292f64c8c9aa6ec9fa2daaeafeb93fd.	2010-11-29 02:21:27 +00:00
Jesse Vincent	15bf83bbe4	preliminary implementation of 'quiet time'	2010-11-29 02:21:16 +00:00
Jesse Vincent	fb6dfb3bde	removed a commented-out method to show notifications on changes to ... system connectivity	2010-11-28 21:48:29 +00:00
Jesse Vincent	2b8f7c0bbc	unify all our beeping, buzzing and flashing codepaths	2010-11-28 21:48:25 +00:00
Jesse Vincent	70922989d3	genericize configureNotification in preparation for code reuse	2010-11-28 21:48:21 +00:00
Jesse Vincent	64667d03dc	extract vibration pattern metadata out ouf MessagingController into ... notificationsetting	2010-11-28 20:29:14 +00:00
Jesse Vincent	b7f52a834f	isVibrate -> shouldVibrate to match shouldRing	2010-11-28 20:29:09 +00:00
Jesse Vincent	28c126b8a5	extract notification code from actual "action" code	2010-11-28 20:29:05 +00:00
Jesse Vincent	99d5704b82	extract "sending messages" notification into methods	2010-11-28 20:29:02 +00:00
Jesse Vincent	9784d0e943	remove 100loc by replacing a pattern with a method.	2010-11-28 20:28:58 +00:00
Jesse Vincent	fa64f4c3a8	Minor refactoring for readability	2010-11-28 20:28:53 +00:00
Jesse Vincent	b7617a3497	extract "determine what to do with a new message" out of ... downloadMessages Probably wants a better name	2010-11-28 20:28:50 +00:00
Jesse Vincent	3404edca28	extract the "synchronize one folder" method	2010-11-28 20:28:46 +00:00
Jesse Vincent	36bb10fb2c	extract out "sync one account"	2010-11-28 20:28:42 +00:00
Jesse Vincent	4f376e8332	astyle	2010-11-28 20:28:37 +00:00
Jesse Vincent	a75098013a	add a new quiet time preference	2010-11-28 20:28:32 +00:00
Jesse Vincent	d3c86a39dd	initial import of a timepicker preference widget	2010-11-28 20:28:19 +00:00
Jesse Vincent	621f87fcbc	Revert "refactor getHeaders and removeHeaders to use a common method and an" ... Subtly flawed. Returned the wrong headers This reverts commit 657b3961f86b1b694fb7587216ecefeb0b20f5d2.	2010-11-27 04:03:15 +00:00
Jesse Vincent	75108f4078	move toMe and ccMe into LocalMessage from MessageInfoHolder	2010-11-27 04:03:10 +00:00
Jesse Vincent	580f47998d	Remove subject from messageinfoholder	2010-11-27 04:03:06 +00:00
Jesse Vincent	60a538e071	Remove "preview" form messageinfoholder	2010-11-27 04:03:02 +00:00
Jesse Vincent	f9981dcf7c	lift hasAttachments to LocalMessage	2010-11-27 04:02:56 +00:00
Jesse Vincent	1149f2d916	refactor getHeaders and removeHeaders to use a common method and an ... iterator to address a Market FC: java.util.ConcurrentModificationException at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:573) at com.fsck.k9.mail.internet.MimeHeader.getHeader(MimeHeader.java:87) at com.fsck.k9.mail.internet.MimeHeader.getFirstHeader(MimeHeader.java:51) at com.fsck.k9.mail.internet.MimeMessage.getFirstHeader(MimeMessage.java:437) at com.fsck.k9.mail.internet.MimeMessage.getContentType(MimeMessage.java:130) at com.fsck.k9.mail.internet.MimeMessage.getMimeType(MimeMessage.java:159) at com.fsck.k9.mail.internet.MimeUtility.findFirstPartByMimeType(MimeUtility.java:971) at com.fsck.k9.crypto.Apg.isEncrypted(Apg.java:464) at com.fsck.k9.activity.MessageView.updateDecryptLayout(MessageView.java:2702) at com.fsck.k9.activity.MessageView$Listener$6.run(MessageView.java:2466) at android.os.Handler.handleCallback(Handler.java:587) at android.os.Handler.dispatchMessage(Handler.java:92) at android.os.Looper.loop(Looper.java:144) at android.app.ActivityThread.main(ActivityThread.java:4937) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626)	2010-11-26 03:53:15 +00:00
Jesse Vincent	23254e8998	BatchButton area toggling should't happen from anything other than the ... UiThread: Fixes a common error from the market: android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views. at android.view.ViewRoot.checkThread(ViewRoot.java:2802) at android.view.ViewRoot.invalidateChild(ViewRoot.java:607) at android.view.ViewRoot.invalidateChildInParent(ViewRoot.java:633) at android.view.ViewGroup.invalidateChild(ViewGroup.java:2505) at android.view.View.invalidate(View.java:5139) at android.view.View.setFlags(View.java:4502) at android.view.View.setVisibility(View.java:3030) at com.fsck.k9.activity.MessageList.hideBatchButtons(MessageList.java:2883) at com.fsck.k9.activity.MessageList.toggleBatchButtons(MessageList.java:2906) at com.fsck.k9.activity.MessageList.access$500(MessageList.java:77) at com.fsck.k9.activity.MessageList$MessageListAdapter.pruneDirtyMessages(MessageList.java:2302) at com.fsck.k9.activity.MessageList$1.run(MessageList.java:811)	2010-11-26 03:53:10 +00:00
Marcus Wolschon	4f08820683	http://code.google.com/p/k9mail/issues/detail?id=2682 ... mark multiple mails as SPAM	2010-11-22 08:12:48 +00:00
Koji Arai	0206ebf809	Fixed issue 2680 ... Should not set empty string in auto-expand folder list.	2010-11-21 13:25:21 +00:00
Jesse Vincent	5d33bc044b	when a message is seen _decrement_ the unread count, don't increment it	2010-11-21 05:31:42 +00:00
Jesse Vincent	14152a8585	Don't compare whether we're setting the delete flag with whether the ... message is seen or not. (logic error)	2010-11-21 05:31:38 +00:00
Jesse Vincent	0e5b5de409	update our counts on destroy before actually destroying the message, so ... we have something to call isSet on	2010-11-21 05:31:34 +00:00
Jesse Vincent	43cef54ad6	We don't cache positive DNS lokups. We shouldn't cache negative DNS lookups either	2010-11-21 02:10:59 +00:00
cketti	389502da55	Fixed account shortcuts ... - Fixed NullPointerException - Removed unnecessary stuff (originally copied from Accounts activity)	2010-11-18 09:09:57 +00:00
cketti	0560dc28d9	Don't use the application context to start the Accounts activity (because then we'd have to create a new task) ... Fixes issue 2653	2010-11-18 09:08:40 +00:00
Fiouz	a67a2022d3	Added method name logging on transaction logging, when debug is enabled	2010-11-17 21:11:07 +00:00
Fiouz	dc16657480	Made LocalStore.destroy() transactional	2010-11-17 21:10:45 +00:00
Jesse Vincent	46300ac421	Move our "pick a folder" preferences out of the account setup wizard, ... where you're unlikely to even have access to them the first time you walk through into the "Folders" preferences. At the same time, move toward using a list preference widget, rather than a custom activity.	2010-11-17 03:43:02 +00:00
Jesse Vincent	b6ccba9c7d	When getting a list of folders out of the database, ask for it in ... asciibetical order, rather than random order	2010-11-17 03:42:14 +00:00
Jesse Vincent	7291486ca0	No longer delete the Outbox every time it's empty - it makes it somewhat ... more difficult to work with. If we want to hide it when it's empty, that's fine. but it's not necessary to delete it.	2010-11-17 03:41:37 +00:00
Jesse Vincent	80e4de6db4	fix a deleted message count logic error	2010-11-15 01:31:20 +00:00
Jesse Vincent	4f4fe87d5f	Minor refactoring of flag setting code	2010-11-15 01:31:16 +00:00
Jesse Vincent	36714d3b4a	astyle	2010-11-15 01:31:11 +00:00
Fiouz	f9d828a62c	Improved some comments	2010-11-14 23:21:48 +00:00
cketti	58ca9fe740	Changed external intent (e.g. Intent.ACTION_SEND_TO) handling code in MessageCompose ... - extracted handling of external intents to a new method - only allow mailto URI for ACTION_VIEW and ACTION_SENDTO (as documented by AOSP) - allow additional recipients via "to" parameter in mailto URI - removed check for allowed MIME type when adding attachments since we're accepting all MIME types anyway - show CC and BCC text fields when one of those recipient types was set by the intent - use MIME type specified in intent for attachments (if present and doesn't contain a "*")	2010-11-14 02:27:42 +00:00
Jesse Vincent	675651286b	Added the ability to completely wipe the localy cached messages of a syncced folder.	2010-11-14 00:49:25 +00:00
Jesse Vincent	32ea04a5b3	kill a temporary variable	2010-11-14 00:49:21 +00:00
Jesse Vincent	6a6c86d117	Kill a once-used temporary variable	2010-11-14 00:49:18 +00:00
Jesse Vincent	945d4d7c32	a slight cleanup for message deletioon policy logic.	2010-11-14 00:49:15 +00:00
Jesse Vincent	0eee80f08b	renamed deleteMessagesOlderThan to clearMessagesOlderThan to better ... reflect that it just nukes local copies rather than the synced copies	2010-11-14 00:49:08 +00:00
Jesse Vincent	7d40596aa1	split apart "delete messages older than" for later reuse	2010-11-14 00:49:04 +00:00
Jesse Vincent	14055691a3	Merge branch 'mail-on-sd' ... * mail-on-sd: (40 commits) Added more comments to explain how the locking mecanism works for LocalStore Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm) Add more comments about how the various StorageProviders work and how they're enabled find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs French localization for storage related settings Remove unused SD card strings (replaced with storage indirection) Merge mail-on-sd branch from trunk Reset mail service on storage mount (even if no account uses the storage, to be improved) find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs Migraion -> Migration move the Storage location preference into preferences rather than the wizard. Made LocalStore log less verbose Added @Override compile checks Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable). Added transaction timing logging Factorised storage lock/transaction handling code for regular operations. Use DB transactions to batch modifications (makes code more robust / could improve performances) Merge mail-on-sd branch from trunk Update issue 888 Added DB close on unmount / DB open on mount Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList ...	2010-11-13 21:40:56 +00:00
Jesse Vincent	76e26607b8	Added a first pass implementation of being able to resend a message.	2010-11-13 03:09:32 +00:00
Jesse Vincent	3779237eb8	remove a special flag in FolderInfoHolder that we only use twice and ... appear to initialize unreliably in favor of some simple checks.	2010-11-13 03:09:27 +00:00
Jesse Vincent	27d3e6312b	Refactor FolderInfoHolder to remove copy-paste code	2010-11-13 03:09:23 +00:00
Jesse Vincent	a8de2d0000	astyle	2010-11-13 01:47:08 +00:00
Jesse Vincent	a551dc8dff	Replace the old "record a message in K9 Errors and give up" ... failed-message scheme with an actual android notification that opens the outbox	2010-11-13 01:47:02 +00:00
Jesse Vincent	e964c7ba84	Tell the user about a failed delivery the first (any) time it fails	2010-11-13 01:46:59 +00:00
Jesse Vincent	4fb338d8a9	Disable "don't send messages in the outbox if they're flagged" - users ... really don't like their mail just getting stuck	2010-11-13 01:46:55 +00:00
Jesse Vincent	ecf793ea26	remove an unused constant	2010-11-13 01:46:46 +00:00
Jesse Vincent	24b018a812	replace a trivial one-line method that was called twice with its body	2010-11-13 01:46:41 +00:00
Jesse Vincent	f874f0f9d3	replace a single-use single-line private method with its body in the one place it was used	2010-11-13 01:46:36 +00:00
Jesse Vincent	0f4366aa77	in the account list, when trying to check mail, also try to send mail	2010-11-13 01:46:31 +00:00
Jesse Vincent	af5f78928c	Add a "fetch all messages" visible limit	2010-11-12 23:41:43 +00:00
Jesse Vincent	a130f56bf4	when changing an account's visible limits, try to reset folder visible ... limits as soon as we save the setting	2010-11-12 23:41:38 +00:00
Jesse Vincent	9f695eb4ed	extract the per-account "reset visible limits" method	2010-11-12 23:41:33 +00:00
Jesse Vincent	478bd876ee	There's no reason the getSubject accessor should throw a ... MessagingException on LocalMessage	2010-11-12 22:27:32 +00:00
Jesse Vincent	b2e5d7afc5	extract our our folder-count updating code from the flag setting code	2010-11-12 21:38:11 +00:00
Jesse Vincent	eb908b67a3	try to clean up our message count update logic in flagging	2010-11-12 21:38:06 +00:00
Jesse Vincent	2d8a8998b0	factor out a "destroy" method for local messages	2010-11-12 21:38:02 +00:00
Jesse Vincent	1292a10ac2	When a message has been deleted on the server and we want to sync remote ... deletions, we don't care whether it was flagged as deleted ocally - we definitely want to destroy it.	2010-11-12 21:37:58 +00:00
Jesse Vincent	33fd42e766	If we DELETE a message from the database, don't then try to UPDATE it	2010-11-12 21:37:54 +00:00
Jesse Vincent	52e2a437fb	Imported a variant of http://code.google.com/p/android-color-picker/ into k-9 ... - Ported to the ColorPickerDialog API - Translated the API and Internals from Indonesian to English - Moved to use K-9 strings rather than custom strings. In an ideal world, we should use ambilwarna as an android library project, like it was intended.	2010-11-08 02:21:32 +00:00
Jesse Vincent	d45081abaa	Animate the batch-operations toolbar (Imported from AOSP)	2010-11-07 19:40:42 +00:00
Jesse Vincent	6528b2d775	lift up font setting code to be with the rest of the initial messagelist item setting code	2010-11-07 00:30:17 +00:00
Jesse Vincent	69675bc935	Now that we can show bigger previews, actually generate a bigger preview	2010-11-05 04:23:09 +00:00
Jesse Vincent	a78776a9ee	Only look at the first 8k of a message when calculating message previews	2010-11-05 04:23:04 +00:00
Jesse Vincent	bfc24a58a0	Improvements to message preview heuristics	2010-11-05 03:55:24 +00:00
Jesse Vincent	9d69875246	Add a new preference to let users select how many lines of message ... preview show in message-preview mode.	2010-11-05 02:59:26 +00:00
Jesse Vincent	d0e85ce43a	astyle	2010-11-05 02:59:21 +00:00
Jesse Vincent	602099cfd3	Be more careful about deleting messages from the MessageListAdapter - ... don't do it from something that's not the UI thread	2010-11-05 01:16:35 +00:00
Marcus Wolschon	4aba667a4e	fix for "http:/"-links in plaintext -emails. (add http:// is a link has no schema)	2010-11-04 13:35:39 +00:00
cketti	5b88a99de0	Got rid of some compiler warnings.	2010-11-04 03:11:34 +00:00
Jesse Vincent	fb55aa5bfb	Fix an extra paren	2010-11-03 00:48:18 +00:00
Jesse Vincent	b9999878df	We care about eclair MR1, not eclair	2010-11-03 00:44:07 +00:00
Jesse Vincent	9c7e3bcc26	Guard against null content from html parts on reply/forward, which was ... causing a bunch of NPEs on the market.	2010-10-31 17:42:03 +00:00
cketti	7f396e29a0	Match beginning of words when searching for contacts in Android 1.5/1.6 (e.g. "Doe" will find "Doe, John" and "John Doe") ... Fixes issue 1354	2010-10-30 20:53:56 +00:00
cketti	0add1f97c0	Mark contacts as contacted when a mail is sent to them. ... Fixes issue 2522	2010-10-30 20:35:49 +00:00
Jesse Vincent	7db384fc08	Use a more backward compatible os version check, since the "current" ... best practice is incompatible with 1.5	2010-10-29 22:35:27 +00:00
Jesse Vincent	e0d6a55d06	SINGLE_COLUMN layouts cause Android 1.0-2.1 to segfault.	2010-10-29 22:35:19 +00:00
Jesse Vincent	b749a198a7	get to: contacts working right.	2010-10-29 22:35:11 +00:00
Jesse Vincent	c5cf9e5c8c	message_to_label and message_to_fmt were used from places that weren't ... their original sources. rename them to lie less.	2010-10-29 22:34:59 +00:00
Fiouz	d28a85de5b	Update issue 2270 ... Status: Fixed Gracefully ignore RejectedExecutionException on service shutdown (there's little we can do about being shut down)	2010-10-29 19:55:04 +00:00
Fiouz	be6ab18091	Update issue 2537 ... Try to gracefully handle account DB corruption by deleting file on open exception	2010-10-28 19:16:55 +00:00
Fiouz	50c3751421	Display "Account settings" title instead of "General settings" when opening account settings (doesn't seem to be affected by user chosen language though)	2010-10-28 19:07:30 +00:00
Marcus Wolschon	b723769e65	translated "unable to connect".	2010-10-28 14:37:48 +00:00
Jesse Vincent	6704279042	redo our messagelist sigil code to not break sender colorization	2010-10-25 03:21:08 +00:00
Jesse Vincent	724169e982	astyle	2010-10-25 03:20:03 +00:00
Jesse Vincent	ddccd11ef7	Try to send pending messages whenever we refresh pushers. should help ... with "stuck" unsent messages on push-only accounts	2010-10-25 03:19:43 +00:00
Jesse Vincent	f6f9d35430	unify two codepaths that sent unsent messages, one of them without a notification	2010-10-25 03:19:19 +00:00
Jesse Vincent	968fb8c508	add a variant of sendPendingMessages that will send pending messages in all accounts	2010-10-25 03:18:51 +00:00
Jesse Vincent	1d6caa5c0a	Never show an undismissable "new email" notification for a null account (like used to happen during setup)	2010-10-24 02:01:13 +00:00
Jesse Vincent	c216f42eb3	Exchange authenticaton and setup overhaul from Kris Wong	2010-10-24 01:03:29 +00:00
Jesse Vincent	07adaaee4d	Applied WebDavStore_cleanup.diff to remove dead code in the WebDav store from Kris Wong <wongk@seapine.com>	2010-10-24 01:02:46 +00:00
Jesse Vincent	62caa5ce76	Experimental change - ask android to try to make columns no wider than ... the viewport. This change should NOT be backported to 3.2, but I'd like folks to try it with real email.	2010-10-23 18:50:54 +00:00
Jesse Vincent	43cb54594b	Push the webview's renderpriority from NORMAL to HIGH - it's cargo-cult ... performance improvement, but it certainly doesn't hurt	2010-10-23 18:50:24 +00:00
Jesse Vincent	983d7ad48f	The "viewport" hinting we used to try to better fit messages by default ... made android zooming incredibly unreliable. Now it's only somewhat unreliable.	2010-10-23 18:50:10 +00:00
Jesse Vincent	4ea6c1603b	We've been seeing a lot of FCs on htmlifcation of large messages due to ... running out of memory during our heavy HTMLification. Try to be a bit lighter on the poor RAM if a plain text message is big.	2010-10-23 17:33:08 +00:00
Jesse Vincent	524dfb348a	Updated MIME Type list with http://www.stdicon.com/mimetypes	2010-10-23 16:28:18 +00:00
Jesse Vincent	105df4c61a	It turns out that not every android release has a good extension to ... mimetype mapping. restore our previous hardcoded mime database as a fallback	2010-10-23 16:28:07 +00:00
Jesse Vincent	fb059a8138	Fix for NPE when changing the identity ... Fixes issue 2506. Patch from jca02266	2010-10-23 15:26:50 +00:00
Jesse Vincent	96f1d9eadf	Fix phantom messages in unified inbox.	2010-10-23 15:19:56 +00:00
Jesse Vincent	bc2127c84a	added a synchronous variant of searchLocalMessages	2010-10-23 15:19:47 +00:00
Jesse Vincent	64c102dd14	notification that the dataset changed needs to happen on the UI thread.	2010-10-21 20:49:48 +00:00
Jesse Vincent	48f2885cfc	When returning from a messageview to a messagelist do our listview ... updates on a thread rather than on the main ui thread. it results in the list blinking with old data, but that's still a better user experience than "frozen"	2010-10-21 20:49:36 +00:00
Jesse Vincent	e8756af4f1	astyle	2010-10-21 20:49:20 +00:00
Jesse Vincent	2a4792eb60	update a comment about an uncommon code path	2010-10-21 20:49:05 +00:00
Jesse Vincent	8d9c074a27	Add gmail-style "to me" and "cc me" indicators in messagelist	2010-10-21 20:48:45 +00:00
Jesse Vincent	d02ddda19b	When doing a message search, break it into "first 10" and "more" - ... because a long SQL query takes more time before starting to return results, K-9 was increasingly slow on large folders. Doing two searches may take marginally more time but starts getting results back to the UI much faster.	2010-10-21 20:48:28 +00:00
Jesse Vincent	e05784d41d	Running heavy operations on the UI thread makes K-9's UI slow and ... freezy. addOrUpdateMessages is very heavy. and very common.	2010-10-21 20:48:12 +00:00
Marcus Wolschon	0933fad9b3	Update issue 7031 ... http://code.google.com/p/android/issues/detail?id=7031 added removeDialog() for every dismissDialog()	2010-10-18 09:53:22 +00:00
Jesse Vincent	b2a08d969b	Revert "For the common case of "getMessage" where we actually have the object in" ... This doesn't work on initial sync, since the comparisons fail and you're left with duplicates in the displayed mailbox This reverts commit fa1c88bec348d0132acc60a320626bf0ca1170ec.	2010-10-16 08:27:58 +00:00
Jesse Vincent	496677dad4	Calculate preview for html-only messages ... Fixes 2465	2010-10-16 08:27:47 +00:00
cketti	742db2ac62	Cosmetic code changes	2010-10-13 20:56:44 +00:00
cketti	4be781a749	Fix NullPointerException when saving account settings for non-IMAP accounts. ... Fixes issue 2454	2010-10-13 20:49:34 +00:00
Jesse Vincent	28c9dfdcce	Delay formatting of dates in messagelist until we actually need them ... -- it turns out they're very expensive.	2010-10-13 10:53:08 +00:00
Jesse Vincent	4e53ee12b6	For the common case of "getMessage" where we actually have the object in ... the list, use a less painful equality check than iteration. This works because messageInfoHolders compare to each other using the same key as message they contain.	2010-10-13 10:52:53 +00:00
Fiouz	9db44bf4a9	MessageProvider: making sure exposed cursor gets dereferenced on close (and closed on finalization) to prevent memory leak	2010-10-11 20:41:59 +00:00
Jesse Vincent	e8fd9683e6	Optimize the new return-to-listview code. (Avoid a bug where we do far ... too much work on first open of a message list)	2010-10-11 19:47:41 +00:00
Jesse Vincent	d07aca3008	"Preferences" -> "Settings" for consistency	2010-10-11 14:54:23 +00:00
Jesse Vincent	c5d68fb49d	Add preferences to enable pinch-to-zoom and single-column layout for ... messages	2010-10-11 14:54:15 +00:00
Jesse Vincent	5fc78b4219	astyle	2010-10-11 00:08:54 +00:00
Jesse Vincent	a683186f6e	move 3 IMAP preferences out of the "wizard" flow to an advanced page ... where they belong	2010-10-11 00:08:47 +00:00
Jesse Vincent	28388b235e	move "saveAllHeaders" to the account preferences screen.	2010-10-11 00:08:39 +00:00
Jesse Vincent	777c3e28b5	Disable theme in preferences to work around an android bug	2010-10-10 19:29:15 +00:00
Fiouz	296ab4f2be	Update issue 1623 ... Message retrieval: - Use the given projection for the cursor result instead of always using a predefined projection. Extraction logic is now in dedicated classes for easy extension. - Added BaseColumns._ID & BaseColumns._COUNT columns. - Deprecated "id" column since it's not a reliable identifier (it's an incremential value generated at query() time)	2010-10-09 09:19:24 +00:00
cketti	3503355b2e	"Reply after quote" preference wasn't persisted.	2010-10-09 03:17:59 +00:00
cketti	385c34e190	Refactoring ... - Moved ListPreference helper functions from FontSizeSettings to K9PreferenceActivity - Used helper functions in Prefs - Reordered preferences in Prefs to match the order in global_preferences.xml (display order)	2010-10-09 01:05:29 +00:00
cketti	96f18734f4	Minor rename	2010-10-09 00:48:46 +00:00
cketti	da7210d1db	Refactoring: Some variable, method, and id renaming.	2010-10-09 00:38:52 +00:00
cketti	7028a4c167	Fixes issue 2144 ... - Removed the contact names cache (memory leak) - Changed Contacts.searchByAddress() to Contacts.getNameForAddress(). Cursor is now immediately closed. - Only try to resolve contact names when "Global settings" -> "Show contact name" is checked - Never resolve contact names if number of recipients exceeds a threshold	2010-10-09 00:24:43 +00:00
cketti	4f429ec3bc	Update issue 2144 ... Forgot to actually save the value when leaving global settings.	2010-10-09 00:13:46 +00:00
cketti	23b53bd660	Update issue 2144 ... Added option to show names from contacts to global preferences (value isn't used yet).	2010-10-08 23:50:33 +00:00
Jesse Vincent	72cb0bf7ec	remove debugging statement	2010-10-08 06:56:50 +00:00
Jesse Vincent	8c1eda3149	An attempt at cleaning up after the 3.00x and earlier bug that caused ... K-9 to leave old headers hanging around in the database	2010-10-08 06:33:04 +00:00
Jesse Vincent	ccc9a99d94	make batch buttons behave correctly if the last selected item is deleted ... while in a messageview	2010-10-08 06:18:45 +00:00
Jesse Vincent	b0de9913e0	more correct list updates after restore	2010-10-08 06:18:30 +00:00
Jesse Vincent	7881039cbf	astyle	2010-10-08 05:34:46 +00:00
Jesse Vincent	945bccd633	First pass at a sane "restore list state" behavior when going back to a ... messagelist from a message view	2010-10-08 05:34:33 +00:00
Jesse Vincent	78f797dda8	A previous refactoring broke notification for messages from the user by ... replacing a localized string with substitutions with a concatenation in one of two places the string was used.	2010-10-08 05:09:38 +00:00
Fiouz	6feb483f36	Update issue 1623 ... Restored accidently dropped content resolver notification code (dropped during r2397 refactoring) First pass at documenting exposed fields	2010-10-06 20:14:33 +00:00
Fiouz	f858c72482	Added @Override compile check	2010-10-06 17:51:35 +00:00
cketti	9b5436d23b	Removed (redundant) debug logging from the IMAP parser code.	2010-10-06 01:50:02 +00:00
Fiouz	548e6e7c77	Update issue 1623 ... Don't export the formatted date through the content provider: now exported as the raw Epoch value - date formatting is a UI concern. That makes MessageInfoHolder lighter.	2010-10-05 22:33:20 +00:00
Fiouz	58c80ad096	Update issue 1623 ... Added semaphore to prevent third party content resolver from exhausting K-9 resources: it won't allow more than 1 cursor to be active at the same time. Concurrent threads (other content resolver invocations) will be suspended until the previous cursor gets released.	2010-10-05 20:23:07 +00:00
Jesse Vincent	6061c42ea9	find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs	2010-10-05 06:04:28 +00:00
Jesse Vincent	58bb54a588	when quoting an html body part for forwarding, downrez it to plain text. ... In the glorious future, we should be forwarding as an attachment. but this is better than the previous behaviour	2010-10-05 06:04:16 +00:00
Jesse Vincent	ae53a0c5ff	broke addAttachmentView into its own sub	2010-10-05 06:03:51 +00:00
Jesse Vincent	524350a960	Replace our (incomplete) custom MIME type list with a call to webkit.	2010-10-05 06:03:24 +00:00
Fiouz	4d24101e13	MessageProvider: ... - Prevented from handling queries while K-9 isn't ready - Added more log output	2010-10-05 05:09:17 +00:00
cketti	00ffc4f7fe	Reverted "shortcut" to global settings in menu for search results (message list) as this led to display problems with Android 2.2. ... Fixes issue 2347	2010-10-04 00:01:59 +00:00
Fiouz	a3f4429963	Switch to UNIX EOL style	2010-10-03 11:08:42 +00:00
Fiouz	f1d413ce77	Optimization: extracted populate() outside MessageInfoHolder in order to properly cache DateFormat (avoid useless DateFormat costly lookup at each population)	2010-10-03 10:56:16 +00:00
Fiouz	9347409e14	Changed case of CheckboxListPreference class to match the Android framework naming pattern	2010-10-03 09:26:30 +00:00
Fiouz	8bb6eb146b	Optimizations: ... - Don't instantiate an empty Address array just to throw it away (less gabarge collection) - Use a StringBuilder rather than a StringBuffer (faster as it isn't synchronized)	2010-10-03 08:28:56 +00:00
Fiouz	ef1d958092	Optimization: don't invoke Cursor.getXXX(int) more than necessary	2010-10-02 18:45:51 +00:00
Fiouz	75984939d1	Don't embed helper instance inside a data transfer object (ideally, the populate() method should be moved outside that DTO to an external service/helper) as this might lead future development to introduce unwanted dependency graphs (= memory leaks)	2010-10-02 09:07:14 +00:00
Fiouz	bb64a0ab01	Update issue 2379 ... Status: Fixed Extracted Intent.ACTION_SENDTO handling in a separate block to extract data from URI (as opposed to ACTION_SEND which uses Intent extras to pass data)	2010-10-02 08:14:12 +00:00
Fiouz	f6064ff19f	Use a thread pool to optimize resource usage instead of always firing up new threads (less garbage collection). ... Note: this is not a complete revert of r2153 since the pool is now automatically expanded as needed (different implementation).	2010-10-02 07:45:11 +00:00
Fiouz	71dbdf3417	Update issue 1623 ... Removed dependency from K9 to MessageProvider (and added ability for components to register themselve for being notified when K9 instance is ready) Moved Intent broadcast code from MessageProvider to K9 Made query() easily extensible using strategy pattern, the discriminant still being the Uri path	2010-10-01 19:41:39 +00:00
Fiouz	01f961c058	Update issue 1623 ... Fixed severe design flaw where the message provider would accumulate messages, causing an OutOfMemoryError even when the message provider isn't explicitely invoked. query() is now synchronized with message retrieval	2010-09-26 16:01:41 +00:00
Koji Arai	2a39cd5206	Fixes issue 2282 ... Added an option whether the registered name color is change or not Avoid "Connection error" when MessageView is opened. The contacts.getName() might return null.	2010-09-26 14:39:52 +00:00
Jesse Vincent	a2fe3bda34	When a new mail alert is alerting about a specific mailbox rather than ... inbox, default to having it open that mailbox. Patch from thardie	2010-09-22 15:43:43 +00:00
Jesse Vincent	b6124fb397	deleteHeaders deleted message headers by id when it should have been ... deleting by message_id. I believe this was our last serious leak in our flash storage deleting message headers was....just wrong. we've fixed other similar bugs inherited from android 1.0 before.	2010-09-22 02:46:20 +00:00
Fiouz	4cb2d52c9c	Refactored message sorting code by extracting the sort code from the sorted object (this was a bad design, worsened by the MessageProvider patch). Ideally, new Comparator classes should get promoted to top-level classes and not be enclosed in MessageList. ... Subject stripper backported from issue258 branch (Utility.java) The result is a cleaner MessageInfoHolder class.	2010-09-21 22:12:45 +00:00
Marcus Wolschon	9ef306413b	MessagingController not propagating provided listener	2010-09-20 11:47:02 +00:00
Fiouz	0990609727	Don't forget to remove some Preference entires when deleting Account	2010-09-19 21:10:56 +00:00
Fiouz	e28e6d8817	Added ability to disable LED notification for new messages (new account setting) ... Extracted notification related settings in separate class (see Issue 2268) Update issue 371 Status: Fixed Added ability to disable LED notification for new messages	2010-09-19 20:54:43 +00:00
Fiouz	e16a79d08c	Javadoc comment	2010-09-12 06:11:08 +00:00
Fiouz	c8a5de7abd	Intent.ACTION_SENDTO.equals(action) was tested twice in the same if/else if statement causing the last one to never match, removed the first one in order to properly enable intent-based activity population ... Fixes issue 2110 "Intent.ACTION_SENDTO.equals(action)" removed from first condition See r1712	2010-09-12 05:26:13 +00:00
Fiouz	bbd664ad3c	Optimization: don't use bytes and related byte/char conversion when we're actually working on string only	2010-09-11 11:20:50 +00:00
cketti	8cf2655dd8	Reverted r2332 and r2333 because the cause of the problem reported in issue 2078 seems to be different than initially thought.	2010-09-09 23:52:06 +00:00
Fiouz	5aa56e1569	Code cleaning: remove unused imports/variables	2010-09-04 06:57:25 +00:00
Jesse Vincent	3291c585e8	Improve Volume navigation settings, fix a bug when a list view is in ... touch mode. Patch by fiouzy.	2010-09-03 21:41:32 +00:00
Fiouz	de31886f44	Fixes issue 2230 ... Owner: fiouzy Synchronize access to designated list to prevent concurrency issue	2010-09-03 20:32:12 +00:00
cketti	a85ea2ee53	- Reworked the previous patch with suggestions by jessev to be as runtime/memory efficient as possible without being useless. ... - Output debug message when invalid responses are encountered.	2010-09-03 15:32:25 +00:00
cketti	b9b15295cd	Added yet another work-around for an IMAP server implementation with a creative interpretation of the specification. Sanity check results returned for a SEARCH command. ... Fixes issue 2078	2010-09-03 13:58:09 +00:00
cketti	9d9e669d65	Code cleanup	2010-09-03 02:15:57 +00:00
cketti	b44bed2596	Fix NullPointerException ... Fixes issue 2261	2010-09-03 01:16:41 +00:00
cketti	0c27a1ab0e	Avoid division by zero. ... Fixes issue 2259	2010-09-03 00:56:19 +00:00
cketti	525d9a2ef9	Don't choke on malformed UIDL responses (POP3). ... Fixes issue 2252	2010-09-02 23:59:20 +00:00
Jesse Vincent	6573f27cec	do our messagelist updates from sync on the ui thread rather than the ... sync thread. copy the incoming message list to deal with concurrent access issues. Patch by cketti++	2010-09-02 03:45:16 +00:00
Fiouz	08f10f1fe5	Issue 1711 (don't display subject when phone locked) ... Modified code so that subject is still visible after unlock when notification bar is expanded	2010-09-01 22:37:11 +00:00
Fiouz	f43db5235c	Fixes issue 1711 ... Owner: fiouzy Don't display message subject in notification bar when keyguard is active (system locked)	2010-09-01 22:26:36 +00:00
Fiouz	f21d86d8ce	Fixes issue 1945. Toast debug location when enabling debug logging.	2010-09-01 21:27:11 +00:00
Fiouz	9b285ae3fc	Fixes issue 939 ... Heavily inspired from Gmail implementation. Currently implemented only for MessageView delete operation.	2010-09-01 20:59:09 +00:00
Koji Arai	842a5ee123	Update issue 2144 ... Use setSpan() instead of Html.fromHtml() Should clear cached name of contacts at MessageView#onClickSender().	2010-09-01 01:35:20 +00:00
Jesse Vincent	a83fd2d548	Kill an insanely chatty log message	2010-08-31 05:01:26 +00:00
Jesse Vincent	a1496bd839	Revert the clever runonuithread hack from the previous commit, as it ... leads to concurrent modification exceptions. "oops" :/	2010-08-31 04:29:56 +00:00
Jesse Vincent	7030967fa7	astyle	2010-08-31 03:58:33 +00:00
Jesse Vincent	7bd8fc3599	When we sync messages and are displaying a messagelist, do the listview ... updates on the UI thread rather than the sync thread. This is a huge performance boost (based on simple empirical testing) for initial syncs as we now do more work as we add messages to message lists	2010-08-31 03:57:02 +00:00
Jesse Vincent	db1b86a296	Better visibility toggling as k-9 switches between messages in ... MessageView	2010-08-31 03:55:30 +00:00
cketti	7f72da93e0	Added missing bit of achen.code's patch for issue 2211 (reply below quote)	2010-08-30 21:27:07 +00:00
Koji Arai	b1074329e4	On the MessageList and the MessageView, prefer to use the display name registered in the Contacts rather than raw addresses. ... Update issue 2144	2010-08-30 14:37:34 +00:00
Koji Arai	e5c4f35737	Correct loading the alternated font size preferences.	2010-08-30 14:14:43 +00:00
Jesse Vincent	4bf233fba5	next and previous were reversed from K-9's standard interpretation of ... them in the previous patch to add volume button navigation	2010-08-30 03:05:41 +00:00
Jesse Vincent	12eb866370	Remove a temporary variable	2010-08-30 02:16:38 +00:00
Jesse Vincent	65f0d22355	Add Volume button navigation in MessageView, MessageList and all ... K9ListActivity subclasses. The MessageView code is a patch from paulkilroy@gmail.com. Fixes Issue 2112	2010-08-30 02:16:20 +00:00
Jesse Vincent	0f1a1baa89	Add a preference to use volume up / volume down to navigate items. ... From a patch by paul.kilroy@gmail.com. Partial resolution of Issue 2112	2010-08-30 02:15:59 +00:00
Jesse Vincent	be8ac83198	A first pass at letting users choose not to top-post their message ... replies. Code By achen.code@gmail.com Fixes Issue 2262	2010-08-30 00:00:34 +00:00
Jesse Vincent	6e2c5be84c	simplify a boolean in isMoveCapable	2010-08-29 23:40:14 +00:00
Jesse Vincent	1f399f5904	Simplify a boolean conditional	2010-08-29 23:40:00 +00:00
Jesse Vincent	7d2804549e	Remove redundant "return" statements from the end of void methods (with ... help from intellij)	2010-08-29 23:39:45 +00:00
Jesse Vincent	4f0bce1569	Simplify many, many boolean conditions with help from IntelliJ	2010-08-29 23:39:26 +00:00
cketti	3d27cf220a	Removed some code/string duplication.	2010-08-29 18:46:51 +00:00
Jesse Vincent	89dcc3646b	Database version bump to clear bogus cached attachments	2010-08-29 16:58:04 +00:00
Jesse Vincent	6031862bad	Before we delete messages earlier than the earliest acceptable date, make sure we also delete their attachments.	2010-08-29 16:57:57 +00:00
Jesse Vincent	fe62812ff2	Delete the attachments from disk before we delete them from the database, so we know what to delete.	2010-08-29 16:57:49 +00:00
Jesse Vincent	994ed6653c	simplify some of our flagging logic and remove duplication using ternary operators	2010-08-29 16:57:40 +00:00
Jesse Vincent	6d38c1c71a	Comments to better explain what's really going on on delete of messages	2010-08-29 16:57:31 +00:00
Jesse Vincent	a5b7aa97dd	typo fix	2010-08-29 16:57:24 +00:00
Jesse Vincent	e0447e32cc	astyle	2010-08-29 16:57:13 +00:00
Jesse Vincent	7300aca2b8	Remove a call to deleteHeaders since headers are deleted implicitly by ... an SQLite trigger. Call our new variant of deleteAttachments() to avoid an extra lookup	2010-08-29 16:57:02 +00:00
Jesse Vincent	31613e15c7	extract the method for "delete a message" from the "Set flags" method	2010-08-29 16:56:54 +00:00
Jesse Vincent	54a4c84afa	Split out deleteAttachment to avoid an extra SQL call if we can.	2010-08-29 16:56:45 +00:00
cketti	38c31db8f6	Don't open a connection to the server if the protocol doesn't support flags and the flag to be changed isn't the deleted flag. This avoids unnecessary connections to POP3 servers. ... Fixes issue 2046	2010-08-28 21:15:23 +00:00
Koji Arai	015666b657	Fixed issue 2174 ... When selecting one of the five vibrate patterns or the number of repetitions, we should demonstrate to the user what the vibrate pattern feels like. (Thanks to achen.code) use the ListPreference instead of the EditTextPreference to set vibrate times.	2010-08-28 14:00:34 +00:00
cketti	41ebeb3498	Don't show K9mail-errors as move/copy destination folder. ... Fixes issue 2219	2010-08-27 01:02:29 +00:00
Thialfihar	a93da0ed80	decoupled PgpData from CryptoProvider, moved the crypto provider into Account	2010-08-22 09:51:17 +00:00
cketti	df0ae4e4bf	Update Issue 2168 ... Respect "Return to list after delete" after pressing on "Archive", "Move", or "Spam" button. TODO: Change strings to reflect this change (e.g. "Return to list after move/delete")	2010-08-19 03:14:27 +00:00
cketti	90ee194d0f	Fixes issue 387 ... Applied patch by achen.code (thanks!) to word wrap the quoted text on replies.	2010-08-19 02:49:13 +00:00
Marcus Wolschon	00d30f1b8a	NullPointerException and TODO-Marker on a strange code-line	2010-08-18 14:27:39 +00:00
Marcus Wolschon	726b472330	set context before using it	2010-08-18 14:13:37 +00:00
Jesse Vincent	0b62640eac	Provisional initial commit of MessagingProvider code by ... stephane.lajeunesse and koxx33 We're going to try it out in the 3.1 dev series. if it ends up looking good, it'll be in 3.2	2010-08-18 02:49:13 +00:00
Jesse Vincent	ff5024eaec	astyle	2010-08-18 02:48:55 +00:00
Jesse Vincent	86dc82f916	Merge branch 'ideal-screenreader' ... * ideal-screenreader: The IDEAL Group have joined the K-9 dogwalkers and submitted their code to be part of K-9! Initial import of the Ideal K-9 branch which adds support for screenreaders.	2010-08-18 02:01:10 +00:00
Jesse Vincent	8832933a60	It turns out that if you're only fetching the bodystructure, the mime4j ... parser can't parse the message.	2010-08-17 04:21:22 +00:00
cketti	02aad5945a	Added null pointer check. ... See issue 2154	2010-08-16 19:34:48 +00:00
cketti	ba95150a31	Use IP address for SMTP EHLO if hostname contains invalid characters, e.g. underscore. ... Fixes issue 2143	2010-08-15 19:26:44 +00:00
Koji Arai	7964c34dbd	Fixes issue 2145 ... Cannot show the emoji icon on Android 1.6 at least. Replaced all "< img" to "<img".	2010-08-15 14:52:59 +00:00
cketti	da90792fa7	Don't call MimeUtility.unfoldAndDecode() on the message body when scanning for external image references. Also cleaned up the code a bit.	2010-08-15 04:05:39 +00:00
Jesse Vincent	73c3872dd0	Improve our display of inline images in HTML mail to not also offer ... themselves up for download. To do so, we need to start storing the original content-id and content-disposition for attachments - this includes a database upgrade. Based on a patch from @achen.code	2010-08-15 02:37:06 +00:00
Thialfihar	95fd605b0e	default account setting cryptoApp to APG	2010-08-14 19:30:37 +00:00
cketti	0e4c1dfacb	Added helper class to access contacts. Uses the old contacts API for SDK/API 3+4 devices and the new API for SDK/API 5+ devices. ... All places that accessed the contacts have been updated to use this helper class.	2010-08-14 13:59:33 +00:00
cketti	0eb342ef5a	Code cleanup (Removed unused imports, added @Override annotations)	2010-08-13 14:06:13 +00:00
Marcus Wolschon	97001b6edb	filter on folder-selection	2010-08-13 06:37:00 +00:00
Thialfihar	b839866e17	removed some unused APG constants, added an APG Intent API version to be sent along with all Intents	2010-08-12 17:39:50 +00:00
Fiouz	1e67fc4cde	Update issue 1290 ... Update issue 1916 Added support for country/region specific locales	2010-08-12 11:03:19 +00:00
Jesse Vincent	a0238904b6	Update our emoji implementation to support docomo, softbank and kddi ... (with the exception of 3 kddi glyphs that overlap with softbank). As of this commit, emoji sent by iPhone users are visible in K-9	2010-08-12 02:22:35 +00:00
Jesse Vincent	d123aa2a39	Add a hook for hinting charset conversions to Java, since Android's java ... doesn't know about all conversions.	2010-08-12 02:22:25 +00:00
Jesse Vincent	54633a4e16	Improvements to "more from this sender" - hopefully this should search ... only on actual addresses, not their local parts.	2010-08-12 02:22:08 +00:00
Jesse Vincent	ece68bae5d	Off-by-one error in the recent IMAP fetch work :/	2010-08-12 02:21:56 +00:00
Jesse Vincent	de16b21124	Add debug logging when K-9 doesn't enable push because the user has ... configured push to be off.	2010-08-11 03:36:49 +00:00
Jesse Vincent	0229d8a1fe	Implement windowing for IMAP UID FETCH ... Our previous implementation of UID FETCH didn't ever take into account maximum command line lengths. When fetching, say 800 messages from a GMail IMAP server, we could easily overflow the max line length leading to a fetch that didn't get all the messages we wanted to and was truncated before the description of which fields we want. That caused K-9 to fetch complete messages, exhaust memory and ultimately fail, even when we were just trying to get message lengths. An equivalent fix needs to be made to seach by UID.	2010-08-11 03:36:40 +00:00
Jesse Vincent	9ebf16e3d9	Finish removing the ThreadPool / ExecutorService Left over from when the ... code was actually in the view class	2010-08-10 04:29:18 +00:00
Jesse Vincent	490ab6b8c0	Try harder to make message loading feel responsive and scroll correctly. ... We're still not there.	2010-08-09 03:16:40 +00:00
Jesse Vincent	a724df79d4	To date, "loadMessageForView" competed for threads in a thread pool with ... all of our mail syncing code. This led to very choppy UI experience. This change doesn't entirely fix message load lag, but the _worst case_ I see is now better than the best case I saw last week.	2010-08-08 23:49:27 +00:00
cketti	2e6a67c2a7	Better text filter for ChooseFolder (folder is displayed if search term is found anywhere in the folder name, not just at the beginning) ... Heavily based on a patch provided by Marcus.Wolschon Fixes issue 2098	2010-08-08 20:27:39 +00:00
Jesse Vincent	1f725a2d5c	increment the new message count if the message is in a notifiable folder ... and the account wants notifications. (even if we don't notify for a message from ourselves, we DO increase the notification count.)	2010-08-08 19:43:01 +00:00
Jesse Vincent	ce9a84e8fd	Quick updates from a code review pass by cketti	2010-08-08 19:35:18 +00:00
Jesse Vincent	d2e3061f20	Lift our initial unread counter up higher so that it happens before ... called code starts resetting the unread count again.	2010-08-08 19:14:52 +00:00
Jesse Vincent	06a3d5985b	Avoid allocating two temp variables on sync	2010-08-08 19:14:47 +00:00
Jesse Vincent	f5a399f6c6	extract out "should we notify" from "notify"; ... rather than calculating the number of pre-existing new messages for this sync twice, do it once, a bit earlier.	2010-08-08 18:50:31 +00:00
cketti	43fb202d43	Fixes issue 1522 ... Added option to automatically show images in message view (always, if sender is in contacts, never). Patch by paulkilroy (thanks!) Includes bugfix for the "Show pictures" on orientation change code introduced earlier.	2010-08-07 22:38:08 +00:00
cketti	9d45470b40	Fixes issue 1076 ... Remember "Show pictures" button state when changing orientation.	2010-08-07 21:37:57 +00:00
cketti	5c588992a0	Fixes Issue 2076 ... Remove german version of the "Re:" prefix when replying to messages. So instead of "Re: AW: subject" we get "Re: subject".	2010-08-07 19:25:47 +00:00
Fiouz	dfb8f9e0f2	Memory management optimisation: help garbage collection by avoiding repeated instantiations of immutable arrays (empty arrays of String, Message, Flag, Address)	2010-08-07 15:10:07 +00:00
Thialfihar	54e0ad5ce0	added some comments to explain some cryptography-related classes and to-dos	2010-08-05 10:55:59 +00:00
Thialfihar	11e28698e1	hide the decrypt signature layout in MessageView if no signature exists, fixes the wrong display of signatures from another message	2010-08-05 10:45:58 +00:00
Fiouz	380452355c	MessageListAdapter: ... - Use of a single View.OnClickListener for all messages. - Extracted method to bind message item views (from MessageInfoHolder to MessageViewHolder).	2010-08-03 07:46:31 +00:00
Fiouz	ad9c315cf4	No longer need to extend Handler since r1126: we're using Activity.runOnUiThread()	2010-08-03 06:09:39 +00:00
Fiouz	2a476dc92c	Additional @Override compile check	2010-08-03 05:46:35 +00:00
Jesse Vincent	f15101420e	Revert "I like this idea, but it's not ready for 3.000" ... This reverts commit f812a3485445c7db4024f84865aaa5d8e6b7b3a0. (Now that 3.0 is branched, this can be on trunk again for further work)	2010-08-02 22:34:21 +00:00
Jesse Vincent	58c5afc77b	I like this idea, but it's not ready for 3.000 ... Revert "It turns out that a big part of our perceptible message switching time" This reverts commit 06f9bb5b7f3064e646b43148d188cec06cd14d11.	2010-08-02 22:32:57 +00:00
Fiouz	44cef83e0b	Use of constants for immutable empty arrays (prevent useless memory allocation)	2010-08-02 11:55:31 +00:00
Jesse Vincent	d4695636f3	It turns out that a big part of our perceptible message switching time ... was loading the "loading..." file into the WebView. Since it doesn't take that long to load the real content, replacing the "Loading..." file with "blank the view" seems to actually feel a heck of a lot faster.	2010-08-02 03:03:58 +00:00
Jesse Vincent	f2729fc58b	Don't show "To: " if the only recipients were ccs and bccs.	2010-08-02 03:03:53 +00:00
Jesse Vincent	cd6b64d88f	Experimental changes to tell WebView that the HTML versions of messages ... we generate from ascii are "mobile-optimized"	2010-08-02 01:27:50 +00:00
Jesse Vincent	d78e7a0d69	Switch from the incomplete (but compatible with java 1.3) mime4j charset ... alias resolver to the core java nio version with a better charset database; rather than falling back to not showing the user a failing message, fall back to showing the user the message as ascii -- it makes it possible to get _something_ out of an unknown-charset message, rather than just a "ha ha. no." error.	2010-08-02 01:27:46 +00:00
Jesse Vincent	7fc921c0b7	astyle	2010-08-02 01:27:40 +00:00
Jesse Vincent	a4381696f9	Support Emoji for DoCoMo. ... Emoji icons are derived from http://start.typepad.jp/typecast/	2010-08-02 01:24:40 +00:00
Fiouz	3bbb6ae050	Don't display Archive/Spam batch operations when corresponding folders are unset	2010-07-30 09:58:26 +00:00
Jesse Vincent	d8a73b195d	Factor out the decision about whether a part is "viewable" for purposes ... of fetching ; remove broken "inline" check from the same.	2010-07-30 00:58:33 +00:00
cketti	0c67f1f4cf	Only ask for POP3 capabilities before authorization if TLS should be used. Always ask after authorization.	2010-07-30 00:58:22 +00:00
cketti	91e55f6fa1	Don't log POP3 passwords by default.	2010-07-30 00:53:46 +00:00
Jesse Vincent	d8a757faaf	Try to avoid a bunch of reallocations as we grow the temporary output stream by defining its size if we can get it	2010-07-29 22:17:35 +00:00
Jesse Vincent	134c0b23dd	Backport a bit of memory efficiency I'm not sure I believe from AOSP	2010-07-29 22:17:32 +00:00
Jesse Vincent	0bb115ca42	Actually catch an OOM in getTextFromPart ... Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages	2010-07-29 22:17:29 +00:00
Jesse Vincent	c6aa505ffe	improve the method docs on getTextFromPart ... Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages	2010-07-29 22:17:26 +00:00
cketti	4c1060ecae	Only show "save or discard" dialog before leaving the message compose activity if the message needs saving.	2010-07-28 23:17:46 +00:00
Thialfihar	3d5fb524ef	set account setting crypto app to "APG" by default	2010-07-28 21:28:51 +00:00
Thialfihar	5e30c3dab1	removed two extra lines from the merge in r2055	2010-07-28 12:10:08 +00:00
Jesse Vincent	2ca76e3db0	Fix for Issue 1956 ... A race condition made the outgoing certificate being compared to the old incoming mHost, throwing an exception with an untrusted certificate dialogue to accept or decline.	2010-07-27 18:59:41 +00:00
Jesse Vincent	7a4d12b53b	Merge from apg-integration	2010-07-27 12:10:09 +00:00
Jesse Vincent	bae8a9736d	Clean up some inverted logic	2010-07-27 01:28:03 +00:00
Jesse Vincent	b1fb92034a	clean up some weird inverted logic (as recommended by intellij)	2010-07-27 01:27:54 +00:00
Jesse Vincent	c541a07ed2	Don't fire off a notification about new mail before we finish ... initializing an account.	2010-07-27 01:27:45 +00:00
Jesse Vincent	766a115155	Remove URLs from message previews. Suggested by Kevin Falcone	2010-07-24 02:09:12 +00:00
Jesse Vincent	19a06d39a1	With all the other performance work we've been doing, getting a message ... into the messagelist is now much, much faster. Intentionally loading the whole mailbox before we let the user interact with the list is increasingly painful. A 250 message mailbox takes 2+ seconds to "unlock" on a modern phone. Consequently, this commit switches us _back_ to progressive loading of mailboxes from the synchronous version. Based on user feedback, we may or may not keep this for the production release.	2010-07-22 04:17:13 +00:00
Jesse Vincent	80e134c03c	astyle	2010-07-22 03:40:30 +00:00
Jesse Vincent	eb21807384	Moving sendMessage and saveMessage into AsyncTasks to make the send/save ... buttons much less janky	2010-07-22 03:40:22 +00:00
Jesse Vincent	8182b8a8ee	Split out sendmessage and savemessage - the sendorsavemessage method ... didn't actually have them sharing code.	2010-07-22 03:40:14 +00:00
Jesse Vincent	338919a9a0	Merge remote branch 'remotes/issue814' ... * remotes/issue814: Changed the appearance of the ChooseAccount activity to better match the look of the account list. svn:eol-style set to LF (UNIX style) Update issue 814 Status: Started Cc: +fiouzy Reuse of res/layout/accounts_item.xml to match account list Automatically expand/scroll to Intent-presented account - Patch provided by fiouzy (ability to choose identity from other accounts) - Modifications in MessageCompose by cketti (use MessageReference to replace mFolder and mSourceMessageUid) Created branch for issue 814 (Feature to select account to send from in compose screen)	2010-07-22 03:15:28 +00:00