remove a special flag in FolderInfoHolder that we only use twice and

appear to initialize unreliably in favor of some simple checks.

src/com/fsck/k9/activity/FolderInfoHolder.java

@@ -22,11 +22,6 @@ public class FolderInfoHolder implements Comparable<FolderInfoHolder>
     public Folder folder;
     public boolean pushActive;
 
-    /**
-     * Outbox is handled differently from any other folder.
-     */
-    public boolean outbox;
-
     @Override
     public boolean equals(Object o)
     {
@@ -133,7 +128,6 @@ public class FolderInfoHolder implements Comparable<FolderInfoHolder>
         if (this.name.equals(account.getOutboxFolderName()))
         {
             this.displayName = String.format(context.getString(R.string.special_mailbox_name_outbox_fmt), this.name);
-            this.outbox = true;
         }
 
         if (this.name.equals(account.getDraftsFolderName()))

src/com/fsck/k9/activity/FolderList.java

@@ -766,7 +766,7 @@ public class FolderList extends K9ListActivity
         if (!folder.name.equals(mAccount.getTrashFolderName()))
             menu.findItem(R.id.empty_trash).setVisible(false);
 
-        if (folder.outbox)
+        if (folder.name.equals(mAccount.getOutboxFolderName()))
         {
             menu.findItem(R.id.check_mail).setVisible(false);
         }

src/com/fsck/k9/activity/MessageList.java

@@ -1750,7 +1750,7 @@ public class MessageList
         }
         else
         {
-            if (mCurrentFolder != null && mCurrentFolder.outbox)
+            if (mCurrentFolder != null && mCurrentFolder.name.equals(mAccount.getOutboxFolderName()))
             {
                 menu.findItem(R.id.check_mail).setVisible(false);
             }