Sander Bogaert
c2af640891
Messagelist special cases bug fix.
2012-09-08 21:32:54 -07:00
Sander Bogaert
2ec97235ec
Split bar on Messagelist activity and some code styling.
2012-09-08 21:32:54 -07:00
Sander Bogaert
4293914855
Initial actionbar integration. On top of every activity, no real integration yet.
2012-09-08 21:14:55 -07:00
cketti
3253466f14
More magic to work around BinaryTempFileBodyInputStream
2012-09-09 01:15:26 +02:00
cketti
734e0d1920
Merge branch 'MessageListAdapter_cleanup'
2012-09-09 00:55:18 +02:00
Andrew Chen
2ef8cda13c
Remove the try-finally stream close. Add comment as to why this pattern doesn't work here.
2012-09-07 23:49:24 -07:00
Andrew Chen
c44b19cda6
Close input stream after reading to fix strict mode warning.
2012-09-07 20:34:40 -07:00
Andrew Chen
2b0b929aa2
Add references and in-reply-to for forwarded messages.
2012-09-07 11:03:46 -07:00
Andrew Chen
3f4bc28363
Add null check before attempting to do math on the date.
2012-09-06 16:38:45 -07:00
cketti
f42943f30c
Optimized searching for a message in the message list
2012-09-06 22:33:22 +02:00
cketti
5678786c97
Properly closing InputStreams to avoid StrictMode warnings
2012-09-05 05:57:52 +02:00
cketti
9c335127e2
Code cleanup
2012-09-05 03:50:02 +02:00
cketti
16ab1b67bc
Made sure the message list is only modified from the UI thread
2012-09-05 03:02:22 +02:00
cketti
d97da517fa
Rewrote code accessing mAdapter.messages from outside MessageListAdapter
2012-09-05 01:31:09 +02:00
cketti
fb6d004692
Don't use MessageListHandler when calling from the UI thread
2012-09-05 01:02:05 +02:00
cketti
bd9b6aea2d
Moved methods modifying the message list to MessageListAdapter
2012-09-05 00:51:04 +02:00
cketti
75a97a82c0
Make MessageListHandler a real Handler that uses Android's message queue
2012-09-05 00:35:43 +02:00
Andrew Chen
536046809d
Merge pull request #170 from roee88/master
...
Issue 4461: MessageProvider enhancements and fixes
2012-09-03 12:47:45 -07:00
Roee Shlomo
f6e30a0642
Removed unreachable searchStats overrides
...
Removed unreachable searchStats overrides.
Replaced with folderStatusChanged in MessageProvider.
Further review confirmed searchStats is only called for listeners passed
directly to MessagingController.searchLocalMessages* and never called
for any
MessagingController registered listener.
folderStatusChanged is more appropriate for this purpose.
2012-08-31 04:35:56 +03:00
Bernhard Redl
474f32ad02
changed parseFlags to directly manimpulate member
2012-08-30 18:15:19 +02:00
Bernhard Redl
7c007d19fb
added improvements suggested by achen
2012-08-30 17:47:58 +02:00
Bernhard Redl
56105bcfe3
+ add support for $Forwarded IMAP flag
2012-08-29 02:26:38 +02:00
cketti
c0153a1636
Display decrypted/verified messages like text/plain messages
...
Nicely format the text instead of wrapping it in <pre> tags.
2012-08-27 17:38:10 +02:00
Roee Shlomo
a4b8bbdb72
Removed trailing spaces
2012-08-18 20:52:32 +03:00
Roee Shlomo
ef082f0260
Fixed indentation
2012-08-17 17:29:35 +03:00
Roee Shlomo
7419259407
Allow more fields in the external provider
2012-08-17 17:19:26 +03:00
Roee Shlomo
a4d1f78dbd
Fixed ACTION_REFRESH_OBSERVER broadcast sending
...
searchStats seems unreachable so broadcast is now sent from
folderStatusChanged and also contains the account and folder name as
extra parameters.
2012-08-17 17:18:00 +03:00
Andrew Chen
a274a3717a
Merge pull request #168 from aatdark/aatdark_mime4j072
...
upgraded Mime4J from 0.7-SNAPSHOT to 0.7.2. Fixes MimeMultipart parser bug (Issue 4455).
2012-08-15 15:34:25 -07:00
cketti
66911a0624
Use grey background for read messages in the message list
2012-08-15 04:14:12 +02:00
Bernhard Redl
89f6c2f6d0
upgraded Mime4J 0.7-SNAPSHOT -> 0.7.2 (fixes MimeMultipart parser bug)
2012-08-15 01:47:57 +02:00
cketti
2e454f0af7
Removed "System zoom controls" setting
...
We always allow zooming but hide (provided the Android version supports
it) the on-screen zoom controls if the device supports multi-touch,
hence pinch-to-zoom.
2012-08-15 00:21:22 +02:00
cketti
3f426c824c
Fixed typo
2012-08-13 20:05:19 +02:00
cketti
03f0678047
Use TitleBarDelegate otherwise clicking links won't work on Jelly Bean
2012-08-13 16:12:15 +02:00
cketti
d9f1690741
Added option to always show the CC/BCC text input fields
2012-08-10 03:38:10 +02:00
cketti
1ff3b6b88f
Disable the 'Add Cc/Bcc' menu option when both fields are visible
2012-08-10 02:31:55 +02:00
Andrew Chen
6f8c60763d
Use Calendar to get current year when formatting copyright.
2012-08-08 11:03:10 -07:00
Andrew Chen
4f122ca094
Merge pull request #160 from dzan/fix_messagelist_whitespace
...
No more white space at the right hand side of the MessageList
2012-08-06 16:53:55 -07:00
cketti
e08b5d2edf
Make the setEmbeddedTitleBar fall-back work on pre-API16, too
2012-08-04 01:13:38 +02:00
cketti
de6d271d58
Remove JBTitleBarWebView because TitleBarWebView handles all versions
2012-08-04 00:16:06 +02:00
Sander Bogaert
ee283c0c77
Give star a bit more room so there is no cut-off. Don't force the scrollbar on the outside so the listitems can take the whole width.
2012-08-03 12:18:12 -04:00
Jesse Vincent
a80d7c518a
Always recalculate
2012-08-02 16:58:13 -07:00
Jesse Vincent
74f04e75e3
A first spike of integrating http://code.google.com/p/android-titlebar-webview
...
on my nexus 7, the webview and titlebar are overlapping each other, still
2012-08-02 16:49:21 -07:00
Jesse Vincent
17a6f79365
Better solution coming up!
...
Revert "Added fallback for when WebView.setEmbeddedTitleBar() is not available"
This reverts commit 6073b9d3fa
.
2012-08-02 16:11:10 -07:00
cketti
592ed3ef38
Upgrade from "keyguardPrivacy" to "notificationHideSubject"
...
Make sure existing installations aren't reset to the default value when
the new setting can't be found.
2012-08-02 03:09:26 +02:00
cketti
3e6d161c18
Show current value for the 'notification_hide_subject' ListPreference
2012-08-02 02:43:10 +02:00
cketti
8c11ec18a9
Code style/documentation cleanup (no functional changes)
2012-08-02 02:31:54 +02:00
cketti
cd37ae16e1
Fixed setting names in SettingsUpgrader for version 12
2012-08-02 02:20:33 +02:00
Bernhard Redl
4028505d69
Extended setting to hide subject in notification area (never, when locked, always)
...
Fixed issue 2595
2012-08-02 01:47:20 +02:00
cketti
f3e74d5321
Added support for "show in top group" to ChooseFolder
2012-08-01 23:44:40 +02:00
cketti
853b4681b2
Hide 'Background data' option on ICS+ devices
2012-07-19 05:25:23 +02:00
cketti
eb7f94a500
Hide "Show unread count" (notifications) on Honeycomb+ devices
...
On Android 3.0 and newer the notification icon is no longer overlaid
with the 'notification number', so we hide the setting.
2012-07-19 02:23:09 +02:00
cketti
5467a71cbf
Added work-around for image loading bug in Android 4.0's WebView
...
Fixes issue 3997
2012-07-16 02:14:42 +02:00
cketti
b72fcd9d4b
Only use the single-column layout on known good Android versions
...
Fixes issue 3820
2012-07-13 23:04:04 +02:00
cketti
83e57064ff
Check database version after ending the transaction
2012-07-07 17:15:14 +02:00
cketti
d08169b004
Corrected indentation
2012-07-07 17:14:03 +02:00
cketti
400487b8aa
Merge branch 'pullreq150'
2012-07-07 17:04:17 +02:00
cketti
e1d9a4779d
Changed the rest of ImapStore to use longs for storing UIDs
2012-07-07 16:46:07 +02:00
cketti
2ad748fad7
Change ImapUtility to use 'long' for the values of sequence sets
2012-07-07 16:21:07 +02:00
cketti
a37c95b456
Move auto-unboxing out of if-clause
2012-07-07 15:41:55 +02:00
cketti
c359eb3cb7
Use auto-unboxing when iterating over a List<Long>
2012-07-07 15:36:43 +02:00
cketti
08c6c63b31
Merge branch 'pullreq153'
2012-07-07 15:06:41 +02:00
cketti
a281b3401e
Extracted code to disable Lint warning when using newer API
2012-07-07 15:03:23 +02:00
cketti
1f2104cae1
Added annotations to disable Lint warnings when we're using newer APIs
2012-07-07 14:38:57 +02:00
cketti
ece107f6d8
Removed unused variable
2012-07-07 14:33:15 +02:00
cketti
f832e08de3
Removed unused debug message
2012-07-07 14:30:42 +02:00
cketti
8493847895
Removed unused class
2012-07-07 14:29:40 +02:00
cketti
2269f22153
Removed unused method that was used for debugging
2012-07-07 14:28:15 +02:00
cketti
411117b660
Removed unused imports
2012-07-07 14:26:16 +02:00
cketti
79253968ff
Get rid of auto-unboxing in comparison
2012-07-07 14:19:22 +02:00
András Veres-Szentkirályi
85b2eb8315
removed unused private field mUID
2012-07-06 15:05:53 +02:00
András Veres-Szentkirályi
d0c08fb705
removed unread private field mSecure
2012-07-06 15:04:46 +02:00
András Veres-Szentkirályi
2f918c2307
Use more efficient entrySet iterator instead of keySet + get()
...
The loop extracted keys from `remodeUidMap` and then called
`remouteUidMap.get(...)` for every key. If both the key and the value
needs to be iterated on, `Map.entrySet()` is a more efficient solution
as it doesn't require O(n) Map lookups.
2012-07-06 15:00:25 +02:00
András Veres-Szentkirályi
9413cf5c9d
Removed override merely calling super()
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
bff1602da1
combined nested if statements in LocalStore
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
961872edf0
combined nested if statements in ImapStore
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
57f364ca69
combined nested if statements in MimeHeader.hasToBeEncoded
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
f79b1eb142
combined nested if statements in DomainNameChecker.matchDns
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
5c23549a0b
combined nested if statements in DomainNameChecker.matchIpAddress
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
cfd77f8e32
combined nested if statements in AccountSetupCheckSettings
2012-07-06 14:35:01 +02:00
András Veres-Szentkirályi
dd5ab2c2c6
combined nested if statements in MessageList.removeMessages()
2012-07-06 14:34:57 +02:00
András Veres-Szentkirályi
e3853824db
removed empty else clause
2012-07-06 14:04:32 +02:00
András Veres-Szentkirályi
8c3b64c3d7
removed unused private fields gesture{Detector,Listener}
2012-07-06 14:04:19 +02:00
András Veres-Szentkirályi
7ae7fc9d9d
removed unread private field mFontSizes
2012-07-06 14:03:48 +02:00
Joe Steele
102c6153a1
Issue 4359: IMAP message UIDs are 32 bit unsigned values and cannot be
...
stored in int, so we now parse them as long.
2012-07-05 18:00:49 -04:00
cketti
6073b9d3fa
Added fallback for when WebView.setEmbeddedTitleBar() is not available
...
The (undocumented) method WebView.setEmbeddedTitleBar() was removed in
Android 4.1 which caused the message header to never be displayed.
This fallback is only a temporary fix. We really need to come up with a
solution that feels like the previous (setEmbeddedTitleBar) behavior.
2012-06-29 00:14:06 +02:00
cketti
602ce7be99
Trim the first value in getHeaderParameters()
...
Previously a value like 'text/html ; charset="windows-1251"' for the
Content-Type header would not be decoded correctly.
Fixes issue 4348
2012-06-18 04:46:46 +02:00
cketti
ee1288ee75
Disable special screen reader mode on ICS
...
The default message view is accessible enough.
Info and original patch provided by Nolan Darilek.
See issue 4153
2012-06-18 03:17:02 +02:00
cketti
fb1bd9f913
Made ColorPickerDialog a real dialog by subclassing AlertDialog
...
This way it's easy to save/restore the dialog's state, e.g. on orientation changes.
2012-06-09 01:39:14 +02:00
cketti
9b77aad8b7
Use the framework to manage the color picker dialog in account settings
...
This way the dialog will survive orientation changes.
2012-06-09 01:39:14 +02:00
cketti
67caa357fd
Fixed loading messages from the database when message format is AUTO
2012-06-01 20:03:03 +02:00
cketti
116e9598da
Create an HTML version of text/plain-only drafts in the database
...
Without this, text/plain-only messages with K-9 Mail's "identity header"
are displayed as "No text" (when moved out of the Drafts folder).
2012-06-01 16:15:07 +02:00
cketti
e88633cf78
Put the logic that decides which message format to use in one place
...
This change is in preparation for the future rich text editing
functionality.
2012-05-30 15:20:51 +02:00
cketti
71b3b2916e
Extracted methods for easier reading
2012-05-30 15:20:51 +02:00
cketti
01c8e84396
Introduced enum for the MessageCompose actions (compose, reply, ...)
2012-05-30 15:20:51 +02:00
Romain Vimont (®om)
fb36389d20
Create database in a transaction (for performance)
...
On my emulator, it takes 70ms instead of 250ms.
On a very specific hardware, it takes 0,5s instead of 4,1s.
I willingly did not indent the code between my try/catch (for the patch to be readable).
2012-05-30 12:57:05 +02:00
cketti
003069e802
Work around a bug in Android 4.x (?) when the system locale is turkish
...
See https://code.google.com/p/k9mail/issues/detail?id=4256
See https://code.google.com/p/android/issues/detail?id=31574
2012-05-21 00:36:53 +02:00
cketti
632dde614d
Added missing account setting "alwaysBcc" to import/export table
2012-05-16 23:03:40 +02:00
cketti
bd6cdecdb0
Always use the application context when instantiating singletons
2012-05-16 22:22:39 +02:00
cketti
c3808827a8
Don't use reflection to load the API-specific Contacts implementation
2012-05-16 21:09:10 +02:00
cketti
ea902ce680
Merge onToggleSortAscending() with changeSort() to avoid code duplication
2012-05-16 20:35:56 +02:00
cketti
bf7a6ba398
Added the global sort settings to the import/export table
2012-05-16 20:35:56 +02:00
cketti
c64c14c4a6
Use account sort settings when filtering messages of only one account
...
This will use the account settings when viewing e.g. only the unread
messages in a folder.
2012-05-16 20:35:55 +02:00
cketti
6d19d9c829
Save sort type and sort order for search views (e.g. Unified Inbox)
2012-05-16 20:35:55 +02:00
cketti
e2b109e7ea
Whitespace cleanup; no functional changes.
2012-05-15 08:01:10 +02:00
cketti
68a6eddfb6
Avoid NullPointerException in the gesture detection code
2012-05-10 17:19:21 +02:00
ashley willis
7e5717ed81
use the new way on internal storage, or the original way otherwise
2012-05-09 21:09:10 -05:00
ashley willis
9e4ac9014b
updated year in copyright.
2012-05-09 14:48:11 -05:00
ashley willis
b1b6d5fce4
Yahoo! IMAP seems to no longer require 'ID ("GUID" "1")' over non-3G.
...
see http://mobile.yahoo.com/mail for IMAP setup instructions.
2012-05-09 13:48:36 -05:00
cketti
f25422f269
Don't use the NotificationBuilder as singleton
2012-05-08 06:45:04 +02:00
ashley willis
ca6d697eed
fixed commit ed4c74983e
due to crashing on 2.1 devices
2012-05-07 09:24:13 -05:00
cketti
edfae1906a
Make sure we always have an account name when importing settings
...
This avoids a NullPointerException in the dialog that allows selecting
which accounts to import.
2012-05-06 21:02:41 +02:00
cketti
dc476eb3e8
Support ACTION_SEND extras when handling ACTION_SENDTO
...
Too many applications get this wrong and rely on the undocumented
behavior of the AOSP Email app and Gmail.
See https://code.google.com/p/android/issues/detail?id=30190
2012-05-06 17:47:59 +02:00
cketti
e1fa90b2fd
Use Notification.Builder on Honeycomb+ devices
...
Using the new helper class we can easily add support for some of the
new notification features later.
2012-05-04 22:03:35 +02:00
cketti
8fdece4782
Use bezel swipe gestures to move to next/prev message in MessageView
2012-05-04 16:32:39 +02:00
m0viefreak
022940d4f5
Fix gesture detection
...
This commit addresses 2 issues:
1) Before, a general GestureDetector was registered on the highest level in K9Activity
This resulted in EVERY inherited activity to have a useless, unused gesture detector.
But more than that, in MessageList, a second GestureDetector was assigned to the ListView.
On every fling gesture, both detectors called the onSwipe() methods,
which technically did the following:
- The one directly assigned to the ListView would work corectly by mapping the
(local) event coordinates to the right entry in the ListView
- The global one worked on screen coordinates, so the onSwipe() method would
likely select the wrong ListView entry (system menu bar offset).
- For some reason this "worked" fine, and only the correct entry was selected,
despite two detectors used.
2) The gesture detection for the MessageView caused problems when the message
itself was scrollable, i.e. wide HTML mails. A fling gesture inside the WebView
would scroll the message, but also switch the message.
This commit fixes all those by doing the following:
- Don't register the GestureDetector in K9Activity, instead make the member variable
accessible by subclasses.
- In the subclasses that need a detector register it
- In K9Activity.dispatchTouchEvent() check for mGestureDetector being null
- For MessageList:
* Remove the duplicate gesture detector assigned to the ListView
* in the handleSwipe() methods: calclulate pixel offset of the ListView to make
it work using the global screen coordinates
- For MessageView: Limit sensitive area to the message header, to prevent interference
with the WebView scrolling
- Respect current behavior:
* Force-enable gestures for the MessageList
* Respect user setting in MessageView
- Make sure that after a successful swipe gesture, any pending action is cancelled, to
prevent unwanted things to happen (such as expanding the header after changing
the message, or a context menu popping up in the MessageList).
See http://code.google.com/p/android/issues/detail?id=8497
2012-05-01 03:00:15 +02:00
ashley willis
9e1fa63139
fixed MimeHeader.hasToBeEncoded() to include TAB.
...
bug encounted when replying to a message such as:
From: "bar, foo" <foobar@example.com>
the field was originally folded on the tab, but the CRLF was already stripped before this error.
2012-04-30 13:58:02 -05:00
cketti
5d080b656d
Fixed a NullPointerException for the context menu in the Unified Inbox
2012-04-30 16:12:14 +02:00
ashley willis
ed4c74983e
fixed security issue -- account databases previously world-readable and accessible to any app if UUID is known.
2012-04-26 08:03:06 -05:00
cketti
2c8ae0644b
Fixed code style
2012-04-25 16:46:05 +00:00
Andrew Chen
8577d1558e
Merge branch 'text-quote-to-html-div'
...
* text-quote-to-html-div:
Use property to determine if we should write test debug information or not.
Remove top margin on converted quote text, consistent with html quoted text.
Colorize quoted text that has been converted to html. Like Thunderbird, but optimized for mobile (no right margin quote bar, thinner left margin quote bar).
Add 1ex of margin at the bottom of converted blockquotes.
Convert quote characters in plain text messages to blockquotes in the html version. "Be like Thunderbird."
2012-04-24 10:24:14 -07:00
Andrew Chen
c829fe9cd2
Remove top margin on converted quote text, consistent with html quoted text.
2012-04-23 15:13:45 -07:00
Andrew Chen
9f1e2717a6
Colorize quoted text that has been converted to html.
...
Like Thunderbird, but optimized for mobile (no right margin quote bar, thinner left margin quote bar).
2012-04-23 15:10:34 -07:00
Andrew Chen
0bb1f4ff56
Add 1ex of margin at the bottom of converted blockquotes.
2012-04-23 14:00:03 -07:00
cketti
2485d21f1d
Show the display name instead of the "internal" name in folder settings
2012-04-22 00:02:46 +00:00
Andrew Chen
32ce196b5a
Convert quote characters in plain text messages to blockquotes in the html version. "Be like Thunderbird."
2012-04-17 10:22:43 -07:00
Andrew Chen
32ae7bad9c
Migrate to Account.has(Special)Folder() methods.
2012-04-17 08:23:22 -07:00
Bernhard Redl
39f5587f30
Fixed Issue 4222. Use of the wrong method to get device-SDK version resulting in errors on ApiLevel 7 (2.1) devices.
2012-04-17 00:09:00 +02:00
ashley willis
93de6cdafe
fixed issue with sort not being remembered at all on unified inbox / all messages (still does not save sort to settings).
2012-04-12 21:12:22 -05:00
ashley willis
f0c22510e2
fixed FC when changing sort from unified inbox and all messages.
...
the new sort saves per account, and there is no active account for these folders.
so also, there is no saving of the sort for the unified inbox nor all messages.
2012-04-11 00:08:49 -05:00
Ashley Willis
bfecdc9443
Merge pull request #134 from yarikoptic/upstream
...
BF: mAccount must not be accessed before verfied to be non-null
2012-04-10 21:25:11 -07:00
cketti
3f29b95846
Use the Android framework to manage the find folder dialog
2012-04-11 04:50:23 +02:00
cketti
ff4d6a66c8
Fixed bug introduced with 6f525f0e31
...
Intent extra was renamed but the code in MessageCompose still used the
(hardcoded) old name.
2012-04-11 04:47:10 +02:00
Yaroslav Halchenko
4288789e39
BF: mAccount must not be accessed before verfied to be non-null
...
otherwise obviously leads to crashes.
IMHO this was a logical location to move, and it resolved my issue when
account was not yet accessible due to not yet accepted key upon importing
old settings from a stored file
2012-04-10 22:26:49 -04:00
cketti
9d854a0f6f
Fix a display bug by extending the system themes
2012-04-11 03:26:45 +02:00
cketti
52b5c567ef
Don't use EmailAddressAdapter as singleton
2012-04-11 03:26:45 +02:00
ashley willis
81c9fdcb13
Merge branch 'master' into pull-128
2012-04-08 21:59:20 -05:00
ashley willis
539ab93bcb
refactored sorting
2012-04-08 21:29:08 -05:00
cketti
8bd5090816
Removed unused import + constants
2012-04-09 02:02:12 +02:00
cketti
6f525f0e31
Converted hardcoded strings to constants
2012-04-09 02:02:12 +02:00
cketti
56d4cca4dd
Make ContactItem immutable
2012-04-09 01:57:45 +02:00
cketti
a09f26a227
Renamed getEmailFromContactPicker() to better reflect what it does
2012-04-09 01:57:44 +02:00
cketti
08e54cf44b
Updated JavaDoc for getEmailFromContactPicker()
2012-04-09 01:57:44 +02:00
cketti
3b5492f5fc
Optimized getEmailFromContactPicker()
2012-04-09 01:57:44 +02:00
Andrew Chen
7e26b62227
Remove horizontal rules in message previews.
2012-04-08 16:52:55 -07:00
Andrew Chen
1c4a3c355c
Add comment about increment settings version.
2012-04-08 15:27:39 -07:00
cketti
d6a1f2e95c
Renamed enum SORT_TYPE to SortType
2012-04-08 23:17:06 +02:00
cketti
24c172add0
Fixed version number for added settings
2012-04-08 23:13:55 +02:00
Jesse Vincent
85da3d8667
workaround to detect the charset from HTML mail without charset parameter on the header.
...
Conflicts:
src/com/fsck/k9/mail/internet/MimeUtility.java
2012-04-08 12:38:45 -04:00
Koji Arai
6861c813ea
Change layout of the email address list.
...
set title to the contact name.
change text size is medium from default(Large).
2012-04-08 12:32:10 -04:00
Jesse Vincent
3a9589714b
added the ContactItem class for picked item from ContactPicker.
...
Conflicts:
src/com/fsck/k9/helper/ContactsSdk3_4.java
src/com/fsck/k9/helper/ContactsSdk5.java
2012-04-08 12:32:04 -04:00
Jesse Vincent
4723ea0ae5
Possible to select email addresses from the ContactPicker
...
Conflicts:
src/com/fsck/k9/activity/MessageCompose.java
src/com/fsck/k9/helper/ContactsSdk3_4.java
2012-04-08 12:29:08 -04:00
Jesse Vincent
dd0ba7640c
Switch the sort order code around so it saves when reversing sort with a keyboard
2012-04-07 17:11:32 -04:00
Jesse Vincent
66528a0ca8
Merge pull request #128 from srinathwarrier/k-9
...
---
A new option to set default sort setting is added to account settings.
* commit '7a9ba4e0ad483cb275281e8b33d9e6d35d870151':
Create implicit sort remembering setting2(minor indentation error)
Create implicit sort remembering setting
Create default sort setting by preference
2012-04-07 16:53:53 -04:00
Andrew Chen
50b2056454
Always hide the batch archive button in a search view, consistent with the batch ops menu.
2012-04-06 16:46:04 -07:00
Andrew Chen
3559618ca9
astyle
2012-04-06 16:42:54 -07:00
Andrew Chen
42d6462946
Hide the batch archive button preference if none of our accounts have an archive folder.
...
Hide the batch archive button in the MessageList if none of the visible account(s) have an archive folder.
2012-04-06 15:52:56 -07:00
Andrew Chen
e94db81ecb
Add Account.hasArchiveFolder() method.
2012-04-06 14:45:44 -07:00
Andrew Chen
12d1301056
Fix Settings version number for batch button preferences.
2012-04-06 14:41:33 -07:00
Andrew Chen
3e03120a73
Merge branch 'master' of https://github.com/mnb20/k-9 into pull111
...
* 'master' of https://github.com/mnb20/k-9 :
High DPI version of archive button icon
Fixed whitespace
Remove TODO
Replaced archive icon. Still a bit crap, but better than my previous attempt.
Added batch buttons for Archive and Move. Made batch buttons configurable.
2012-04-06 13:47:55 -07:00
cketti
e88fbf43d0
Removed unused ToggleScrollView
2012-04-04 10:04:57 +02:00
cketti
5041a2c832
SingleMessageView cleanup
2012-04-04 10:04:57 +02:00
Bernhard Redl
eba886b85d
Render html code to make white on DarkTheme (fixes 4196)
2012-04-04 01:46:22 +02:00
cketti
0caac114a6
Added some error checks when processing IMAP FETCH responses
2012-04-03 07:55:52 +02:00
cketti
4612ceb3c8
Enabled dark theme for MessageCompose and MessageView
2012-04-03 07:55:51 +02:00
cketti
5819d27394
Added long-press popup menu to WebView in SingleMessageView
...
Actions:
- Open link for viewing
- Share link
- Copy link to clipboard
- View image
- Download/save image
- Copy image URL to clipboard
- Call number
- Save phone number to Contacts
- Copy phone number to clipboard
- Send mail
- Save to Contacts
- Copy email address to clipboard
This is based on work done by kernelhunter92 and ShellZero.
Fixed issue 1248
2012-04-01 22:46:36 +02:00
cketti
1596ddfaab
Moved sanitizeFilename() to com.fsck.k9.helper.Utility
2012-04-01 21:14:43 +02:00
cketti
1d25d2ff40
Added helper class to use the most recent ClipboardManager
2012-04-01 21:08:31 +02:00
cketti
2331696153
Always use the light theme in MessageCompose
...
This fixes a display bug in the "Send as" dialog in MessageCompose.
2012-03-29 06:39:31 +02:00
cketti
d584492a6d
Changed internal representation of the selected theme in the database
2012-03-29 06:33:01 +02:00
cketti
1266c3c73e
Don't allow invalid values for header/footer insertion point
2012-03-27 20:41:43 +02:00
cketti
4e21f049d3
Validate "original message" field of identity header when loading drafts
2012-03-26 21:36:26 +02:00
cketti
a1caebdcf1
Fixed potential NullPointerException
2012-03-26 19:41:21 +02:00
cketti
661ed08061
Removed unnecessary layout containers
2012-03-24 22:51:33 +01:00
cketti
b9e0ec1ab4
Added AccountHolder
2012-03-24 20:43:17 +01:00
Jesse Vincent
ea90e24785
move the chips, change the sizes
2012-03-24 19:57:32 +01:00
Jesse Vincent
580f1639c3
UI improvements to the "select identity" button
2012-03-24 19:57:31 +01:00
cketti
365f8e71e0
Fixed array length calculation
2012-03-23 04:20:29 +01:00
cketti
8180fd9ad2
Added a button to switch the identity in MessageCompose
...
Originally I wanted to use a Spinner, but it doesn't support multiple
view types (see [1]). Those are necessary because we use different
layouts for accounts (section headers) and identities (selectable list
items).
Removed the ChooseAccount activity because it's now unused.
2012-03-22 22:17:10 +01:00
cketti
1d28eb003d
Added a setting to disable marking messages as read on viewing
2012-03-19 04:44:41 +01:00
cketti
5245191900
Notify the listener provided as argument to doRefreshRemote()
...
With this change pressing "Refresh folders" in ChooseFolder actually
refreshes the folder list.
2012-03-18 22:43:47 +01:00
cketti
8c66a2f835
Replaced hardcoded strings with references to string resources
2012-03-18 22:13:27 +01:00
cketti
16afff4dfc
Notify the adapter from runOnUiThread() instead of using Handler
2012-03-18 22:09:52 +01:00
cketti
4f2412eacd
Changed code formatting. No functional changes
2012-03-18 22:06:44 +01:00
cketti
b7c1f8ab2f
Prefixed instance variables with "m" to comply with K-9 code style
2012-03-18 21:51:01 +01:00
cketti
09bc07596e
Got rid of unnecessary instance variable
2012-03-18 21:48:22 +01:00
cketti
6bdaac4353
Fixed whitespace (tabs vs. spaces)
2012-03-18 21:46:32 +01:00
unusualdiscrepancy
58c01c05b7
Fix for Issue 4164: Force close when moving an email to another folder
2012-03-18 21:45:33 +01:00
cketti
482ae352c1
Reverted most of the recent message header changes
...
Clicking the additional headers area still allows to hide that view
again.
2012-03-18 04:51:29 +01:00
cketti
69ee6a4818
Avoid NullPointerException in Accounts.onCreateDialog()
...
Also cleaned up code formatting of onCreateDialog() and
onPrepareDialog().
2012-03-17 21:28:54 +01:00
cketti
ef01dc906b
Use AlertDialog's ListView on import instead of creating our own
...
This fixes a display problem when using the dark theme.
2012-03-17 21:28:53 +01:00
Koji Arai
10c37942a6
Added two domains handle docomo emoji
2012-03-17 23:24:12 +09:00
Koji Arai
f9fb74241a
avoid NPE. address may be null when the parser is failed.
2012-03-17 23:23:27 +09:00
cketti
f9a35aeaee
Replace CRLF with LF when loading drafts
...
This is necessary because we save the offset and length of the user-
supplied text in the identity header. These values are then later used
to split the draft in user text and quoted message.
When calculating these values we operate on a string with LF line
endings. Ideally we want to do the reverse operation on the same
string, but when saving the message to the server LF is converted to
CRLF to create RFC-conforming messages.
This is only a hack and will probably be the cause of more trouble in
the future. A better solution would be to make the identity header more
robust or get rid of it entirely.
2012-03-17 04:15:30 +01:00
cketti
3fa8081e88
Fixed MimeUtility.extractTextual() when loading messages from the server
2012-03-17 03:19:09 +01:00
cketti
dbf38dae65
Fixed the change of the previous commit
2012-03-17 00:30:40 +01:00
cketti
a48adafbbc
Don't use null for 'text' and 'html' in ViewableContainer
2012-03-16 22:56:09 +01:00
cketti
f181e923ca
Don't modify draft messages when storing them in the database
2012-03-15 21:21:00 +01:00
Srinath Warrier
7a9ba4e0ad
Create implicit sort remembering setting2(minor indentation error)
2012-03-12 22:55:31 +05:30
cketti
aeb0220e56
Fixed MimeUtility.getHeaderParameter() to not crash on unexpected input
2012-03-12 17:45:34 +01:00
Srinath Warrier
3ebd3c1fc2
Create implicit sort remembering setting
2012-03-12 22:04:10 +05:30
ashley willis
f9a30d1822
added sort by arrival option.
2012-03-11 17:48:56 -05:00
cketti
0cb4207ef7
IMAP: don't create the destination folder when copying messages
2012-03-09 21:51:48 +01:00
cketti
7163d39091
Change ImapException to always be a permanent error
...
This way IMAP commands that get anything but an "OK" response are never
tried again (pending actions).
2012-03-09 21:50:26 +01:00
cketti
ee34344d30
Upgrade to SDK 15
2012-03-07 21:52:47 +01:00
cketti
4721d92e79
Avoid some instances of autoboxing
...
This will hopefully allow us to compile with "Android Java IDE".
2012-03-07 21:40:41 +01:00
cketti
a089fadd9a
Merge branch 'messageheader'
2012-03-06 05:26:11 +01:00
cketti
faf9dc6e02
Restored show/more less indicator in the message header
2012-03-06 04:38:08 +01:00
ashley willis
78615f878d
added From: addresses on reply all when Reply-To: is set. don't repeat address in To: field if it's already included in replyToAddresses.
2012-03-05 15:17:31 -06:00
Srinath Warrier
ff6e1f6c85
Create default sort setting by preference
2012-03-04 16:20:37 +05:30
m0viefreak
8d12244a9c
Message header changes
...
* remove expand/collapse arrows, instead use the background area of the header to toggle
* allow expanding of To: and Cc: texts when too long and cut off by clicking on them
2012-03-02 06:15:55 +01:00
m0viefreak
f1baa8f461
invalidate message content WebView when the message header changes
...
This fixes redraw issues where text appears doubled or is cut off
2012-03-02 05:16:58 +01:00
cketti
5591865f17
Merge branch 'uidplus'
2012-02-29 14:09:41 +01:00
cketti
f6ebe4d4e0
Deduplicated code to create SearchAccounts for special accounts
2012-02-29 03:03:20 +01:00
cketti
e72afc1641
Set content type of attachment even when no file name was found
2012-02-27 23:20:30 +01:00
cketti
ba979808fe
Use AttachmentView instance as onClick and onLongClick listener
2012-02-27 21:45:47 +01:00
cketti
206c559236
Don't handle exceptions in AttachmentView.populateFromPart()
...
We now catch exceptions in SingleMessageView.renderAttachments(). This
way we can avoid adding AttachmentViews that couldn't be properly
populated.
2012-02-27 21:45:47 +01:00
cketti
25dff5ae6a
Don't choke on invalid size parameters for attachment parts
2012-02-27 21:45:46 +01:00
cketti
2cb31a2fac
Added button to show unnamed and inline attachments
2012-02-27 21:45:46 +01:00
cketti
de2c6cdae3
Prevent users from changing special folder assignments for POP3 accounts
2012-02-25 05:05:21 +01:00
cketti
8e7950164b
Hide "Expunge" menu item for all folders in a POP3 account
...
Also hide "Check mail" for all folders except the Inbox (POP3).
2012-02-25 04:28:08 +01:00
cketti
1af5476b96
Hide refile batch actions in the message list for POP3 accounts
2012-02-25 04:19:27 +01:00
cketti
3632978b49
Don't animate the previous/next buttons in message view
2012-02-25 01:08:55 +01:00
cketti
7c97527d73
Allow message header to scroll when displaying the attachment list
2012-02-25 00:43:09 +01:00
cketti
c1d663b084
Save/restore instance state for MessageHeader
2012-02-24 04:07:29 +01:00
cketti
4e12dc154e
Save/restore instance state for SingleMessageView
2012-02-24 03:43:42 +01:00
cketti
2c09d75afa
Switch to "message view" when displayMessageBody() is called
2012-02-23 00:10:47 +01:00
cketti
18c96f94d6
Retain "show pictures" state on orientation change
2012-02-22 23:26:59 +01:00
cketti
4984a6b9e5
Keep current view state after having downloaded the complete message
...
If the attachment view was visible, keep it that way.
2012-02-22 23:07:48 +01:00
cketti
2b54599c2b
Small code cleanup
2012-02-22 22:56:05 +01:00
cketti
0ef9c516be
Moved click listener from MessageView to SingleMessageView
2012-02-22 22:44:31 +01:00
cketti
80cb0cce35
Changed the layout to include a color chip again
2012-02-21 23:38:43 +01:00
cketti
d44849d239
Restored previous/next animations
2012-02-21 16:54:35 +01:00
cketti
ec6645bf6a
Avoid creating new objects for handling click events
2012-02-21 16:21:47 +01:00
cketti
9f42ff61d3
Removed settings for scrolling buttons
2012-02-21 15:16:36 +01:00
cketti
309eeb72ac
Got rid of the ScrollView in MessageView
...
The ScrollView around the WebView caused all sorts of problems. This
change removes the ScrollView and uses the undocumented method
WebView.setEmbeddedTitleBar() to set the MessageHeader view as "title
bar" of the WebView. This allows MessageHeader to scroll away making
more room for the WebView.
All of the "magic title bar" code was originally implemented by Jesse
for Kaiten.
Because WebView doesn't support a scrolling footer we can no longer
support scrolling buttons or attachments at the end of the message. Now
users can switch from message view to attachment view via a button just
below the message headers.
I also copied some code for which I was too lazy to create a separate
commit. It allows to display attachments we didn't use to show by
clicking on a "More..." button in the attachment view. Those
attachments are mostly images referenced by the HTML part (e.g.
background images).
Fixes issue 3291
2012-02-21 05:07:01 +01:00
cketti
fbc187a3e2
IMAP: Send the Message-ID as quoted string in getUidFromMessageId()
2012-02-19 19:51:06 +01:00
cketti
8e32320f5d
Merge branch 'viewables'
2012-02-18 19:29:34 +01:00
cketti
4adfc51339
Use HtmlConverter.convertEmoji2Img() in LocalFolder.updateMessage()
2012-02-18 00:44:24 +01:00
cketti
b9803ece19
Fixed divider before text part with filename
2012-02-18 00:05:56 +01:00
cketti
8ce78408c2
Fixed HTML generation in MimeUtility.extractTextAndAttachments()
2012-02-17 19:42:35 +01:00
cketti
5083b8f1e8
Use newly imported AOSP code instead of ImapStore.parseSequenceSet()
2012-02-17 15:01:30 +01:00
cketti
deb01bcd16
Imported ImapUtility.java from AOSP Email
...
Modified it to fit our needs.
2012-02-17 14:59:50 +01:00
cketti
c1ed0c78a9
Introduced new pending command to retain upgradability
2012-02-17 01:59:04 +01:00
ashley willis
4db048343f
account setup changes:
...
added gmx.com.
set delete policy to DELETE_POLICY_ON_DELETE for IMAP on automatic setup like manual setup does.
set default names for Archive and Spam on manual config like automatic setup does.
2012-02-16 18:35:25 -06:00
cketti
f7299a69d4
Keep track of UIDs when moving messages to the trash folder
2012-02-17 00:43:35 +01:00
cketti
c3885bc475
Cleaned up LocalFolder.appendMessages() a bit
2012-02-16 23:52:44 +01:00
cketti
023c60513e
Fixed UID mapping return value of LocalStore.moveMessages()
2012-02-16 23:37:44 +01:00
cketti
4ed77c7a29
Avoid NullPointerException
2012-02-16 22:36:57 +01:00
cketti
89e0ed3c03
Notify listeners of UID changes after remote copy/move
2012-02-16 22:34:50 +01:00
cketti
3e4e6c72fd
Cleaned up ImapStore.ImapFolder.copyMessages()
2012-02-16 22:12:44 +01:00
cketti
396005974a
Cleaned up ImapStore.ImapFolder.appendMessages()
2012-02-16 21:33:53 +01:00
cketti
8e1627e1b9
Merge branch 'master' into uidplus
...
Conflicts:
src/com/fsck/k9/controller/MessagingController.java
src/com/fsck/k9/mail/store/WebDavStore.java
2012-02-16 19:57:24 +01:00
cketti
53ae9d7fe7
Avoid exception when a screen reader is installed but not active.
2012-02-16 14:52:56 +01:00
cketti
3ee0889529
Use the Androiod framework for the file manager error dialog
...
This will automatically recreate the dialog on configuration changes
(e.g. orientation change).
2012-02-16 14:43:38 +01:00
ashley willis
15ffaf301e
changed ANDROID_MARKET_URL to automatically search for OI File Manager.
2012-02-14 22:48:27 -06:00
Ashley Willis
8d5ad172c6
Merge pull request #125 from wilian-cb/issue-3945
...
3945: Handling error when there's no File Manager application used in import settings
2012-02-14 20:41:42 -08:00
wilian-cb
4c318d1727
3945: Treatment for errors related to not having a file manager application in Android to handle import configurations.
2012-02-14 21:11:15 -02:00
cketti
dfd47702bc
Fixed rare NullPointerException
2012-02-14 00:27:28 +01:00
cketti
cf9631d481
Changed the way we decide what message parts to display
2012-02-13 23:11:59 +01:00
cketti
485a505ca0
More tweaks to the unread widget
2012-02-13 12:25:03 +01:00
cketti
64f4f7e4a3
Use the new AccountList activity when creating launcher shortcuts
2012-02-13 12:25:03 +01:00
cketti
7a252bf002
Changed method to update the unread widget
2012-02-13 12:16:20 +01:00
cketti
98461e5a21
Notify listeners if unread count changed due to a copy/move operation
2012-02-13 12:16:19 +01:00
cketti
d4bc664c41
Removed unused method
2012-02-13 12:16:19 +01:00
cketti
e87f4cd98a
Code cleanup. No functional changes.
2012-02-13 12:16:19 +01:00
cketti
29e1a68288
Added widget to display the unread count for an account
2012-02-13 12:16:18 +01:00
cketti
328701e87e
Fixed JavaDoc
2012-02-13 00:57:06 +01:00
cketti
53604be914
Fixed NullPointerException
2012-02-13 00:56:34 +01:00
wilian-cb
e766f75da2
Creating and initializing special accounts in Accounts activity to avoid NullPointerException when it's resumed. Constant added to represent the number of special accounts.
2012-02-12 11:57:34 -06:00
wilian-cb
02b07f34a1
Issue 3280: Add launcher shortcuts for special accounts/folders ("Unified Inbox" and "All messages")
2012-02-10 00:24:32 -06:00
cketti
7ef5f9d37e
Set flagged and unread count to 0 when emptying the trash folder
2012-02-04 21:06:35 +01:00
cketti
898f65e081
Changed the way we set flags to update the original Message object
2012-02-04 21:06:34 +01:00
Nick Nikolaou
46bf2c5be7
Add discard confirmation dialog when pressing back
2012-02-02 19:33:49 -06:00
cketti
35b5aebdb3
Add debug message when saving an attachment to SD card fails
2012-02-03 01:22:37 +01:00
cketti
b1a1de8f7b
Restore mark as unread in message view
...
Fixes issue 3958
Fixes issue 3319
2012-01-27 08:39:10 +01:00
cketti
1165787129
Changed regular expression for invalid characters in a file name
2012-01-27 03:39:08 +01:00
cketti
6c23e204ba
Replace invalid characters in file name instead of removing them
2012-01-27 03:21:20 +01:00
cketti
68f5f009f1
Whitespace cleanup
2012-01-27 03:07:44 +01:00
wilian-cb
9a0f650cd9
3674: Displaying the final file name.
2012-01-27 02:44:01 +01:00
wilian-cb
193450cd63
3674: Illegal characters used in file names are being removed when saving them on the device.
2012-01-27 02:44:01 +01:00
cketti
e8eae37389
Reset unread/flagged count on "empty trash"
2012-01-27 00:51:18 +01:00
cketti
5a8ddaa039
Make sure draft id points to a valid message before deleting it
...
Avoids IllegalArgumentException in LocalStore.getMessage()
2012-01-26 00:37:25 +01:00
cketti
aae734c175
Don't Log.w() full stacktrace if file wasn't found
...
This happens regularly when AttachmentView tries to get a thumbnail for
attachments that haven't been downloaded yet.
2012-01-24 22:14:21 +01:00
cketti
4e5d116713
Delete attachment metadata and thumbnails when deleting attachments
2012-01-24 16:15:45 +01:00
cketti
c6696f632a
Code cleanup, fixed some warnings, rearranged some stuff
2012-01-24 16:15:44 +01:00
cketti
7a3cadbf1c
Refactored AttachmentProvider.openFile()
2012-01-24 16:15:44 +01:00
cketti
4bbc5de1ba
Code cleanup / fixed lots of warnings
2012-01-22 06:25:06 +01:00
cketti
45faad041e
Don't finish() MessageCompose in onPause()
2012-01-22 05:32:52 +01:00
cketti
bddacf6b64
Use database ID to keep track of the current draft
...
By using the database ID we avoid having to deal with the problem of
changing UIDs. First the message has a local UID, then, when the upload
to the server is completed, it gets a remote UID.
2012-01-22 05:20:41 +01:00
cketti
96f827d291
Modified LocalStore to use UPDATE when replacing existing messages
...
This way we can later use the database ID to keep track of drafts.
2012-01-22 05:20:41 +01:00
cketti
be2aac52a8
Reload accounts after writing imported account settings to storage
...
This makes sure that when the next account is imported it will see the
account just imported. That's necessary e.g. when going though all
accounts to find the next free account number, or when avoiding account
name conflicts.
2012-01-21 03:10:40 +01:00
cketti
0625e13380
Canceling notifications once should be enough
2012-01-20 23:32:55 +01:00
cketti
a8f91b0f70
Minor code cleanup
2012-01-20 23:32:12 +01:00
cketti
7eccc1701d
Merge branch 'issue3508'
2012-01-20 23:19:22 +01:00
cketti
2c5f640b9e
Minor cleanup
2012-01-20 23:15:11 +01:00
wcb
457e65010e
Issue 3139: notifications of new messages removed when unified inbox is selected
2012-01-20 11:55:04 -08:00
Nick Nikolaou
773d1e30f1
Simplied code and added curly brackets to if/else
2012-01-20 19:10:11 +00:00
cketti
32a29f131b
Make sure an IOException is always passed through as MessagingException
...
This is important for the code handling pending actions in
MessagingController. If a non-permantent MessagingException is
encountered, the pending action is retried later.
Fixes issue 3696
2012-01-20 19:50:07 +01:00
Nick Nikolaou
1a01c10fc5
Don't save to drafts if drafts folder is -NONE-
2012-01-20 17:02:35 +00:00
cketti
258b0039d5
IMAP: also get the Message-ID when fetching the message "envelope"
...
This should fix issue 3994
2012-01-14 06:30:22 +01:00
cketti
66b7805a57
Fixed a bug in the IMAP response parser
...
Also got rid of ImapResponse.more() which isn't necessary anymore.
2012-01-12 07:56:52 +01:00
cketti
ad8b025b6f
Fixed indentation
2012-01-12 02:20:22 +01:00
cketti
8e627834c1
Changed font size unit from DIP to SP
...
"Scale-independent Pixels - this is like the dp unit, but it is also
scaled by the user's font size preference. It is recommend you use this
unit when specifying font sizes, so they will be adjusted for both the
screen density and the user's preference." - Android Developer Docs
2012-01-12 02:18:41 +01:00
cketti
edf0361aab
Added font size setting for text input fields in MessageCompose
2012-01-12 01:05:01 +01:00
cketti
e7f29d429c
Fixed quoted text for plain text messages
2012-01-10 07:44:50 +01:00
cketti
0d8497b04b
Restructured and documented MessageCompose.buildText()
...
Also fixed a bug where the signature wasn't appended in the HTML part of
newly composed messages.
2012-01-10 01:47:23 +01:00
cketti
a191415860
Avoid using TreeMap methods introduced with API 9
2012-01-08 04:04:25 +01:00
Jesse Vincent
ec78c1e009
Save settings changes "on pause" rather than "on back" so we actually
...
save settings when a user hits home or menu or whatever.
2012-01-06 20:27:10 -05:00
Jesse Vincent
3d9f9c4ab4
Don't save account settings until after we save the updated push
...
settings.
2012-01-06 20:12:40 -05:00
Andrew Chen
beda7beac7
Use a constant for 18 hours.
2012-01-05 19:01:00 -08:00
cketti
7e8aede93d
Updated settings description with new default values (import/export)
2012-01-06 01:36:32 +01:00
Andrew Chen
06175888b9
Enable system zoom and disable gestures by default.
2012-01-05 16:10:23 -05:00
cketti
926406edd3
Be more careful when deleting an account
...
Fixes issue 3954
2012-01-05 20:24:18 +01:00
cketti
d848b434f5
Fall back to HELO command if the server doesn't know EHLO (SMTP)
...
Fixes issue 2704
2012-01-05 03:53:23 +01:00
Mark Baker
0e86fb2a80
Fixed whitespace
2012-01-04 19:58:19 +00:00
Andrew Chen
3c5a63adeb
Issue 3875: Revert to the old way of determining minimum swipe distance.
...
Fix my logic bug when determining left to right vs. right to left.
2012-01-03 21:58:36 -08:00
Andrew Chen
11ebc1b262
Issue 3875: Add a bit more debug data for swiping.
2012-01-03 21:19:59 -08:00
Andrew Chen
fc5ea05e48
Issue 3875: Add more debugging lines to figure out what might be wrong with the new swipe algorithm.
...
Fix some variable names.
2012-01-03 21:06:20 -08:00
Andrew Chen
81f0cb510a
Remove unused date formatter.
2012-01-03 21:04:27 -08:00
cketti
fec6434f08
Removed unused code
2012-01-04 03:57:54 +01:00
cketti
71174417ce
Clone Message object to avoid ConcurrentModificationExceptions
...
Fixes issue 3953
2012-01-04 03:57:53 +01:00
edpeur
daeedc2222
Close resources properly
2011-12-31 17:38:41 +00:00
cketti
0aa513429a
Show/hide ListView footer depending on message list type
...
Fixes issue 3946
2011-12-31 02:24:54 +01:00
Mark Baker
09c6cfb6e4
Remove TODO
2011-12-29 09:56:54 +00:00
wongk
fb3cd234fa
Merge branch 'master' of github.com:k9mail/k-9
2011-12-28 14:04:37 -05:00
wongk
b2d5ea3ce2
Fixed the parsing of response data for WebDAV requests.
2011-12-28 14:03:44 -05:00
Mark Baker
7ad5429e98
Merge remote-tracking branch 'upstream/master'
2011-12-26 19:17:05 +00:00
cketti
852dca4124
Removed unused import
2011-12-26 02:30:59 +01:00
András Veres-Szentkirályi
39ef1ae9a4
Removed overrides merely calling super()
2011-12-26 02:28:32 +01:00
András Veres-Szentkirályi
cea6f4468d
Removed unused private field
2011-12-26 02:28:31 +01:00
András Veres-Szentkirályi
1949067979
Removed unnecessary return statement
2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
de30c712f9
Removed duplicate import
2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
b9ea7db5da
Removed unneeded semicolons
2011-12-26 02:28:29 +01:00
Mark Baker
af1b9f83f2
Added batch buttons for Archive and Move. Made batch buttons configurable.
2011-12-24 18:17:12 +00:00
cketti
6de081c5b0
Minor cleanup
2011-12-19 02:21:27 +01:00
mwolschon
696666ca5e
Issue 1303: can't send mail get "no route to host" error
2011-12-19 02:10:17 +01:00
mwolschon
2bfe1f4533
Issue 17: Hierarchical folder list / folder tree
2011-12-15 10:34:29 +01:00
cketti
61ca1a2ae2
Use internal representation for settings during the upgrade process
...
This avoids constant conversion between the string representation used
in preference storage and the internal representation.
2011-12-11 06:02:31 +01:00
cketti
345f4c2939
Code cleanup; no functional changes
2011-12-11 05:16:22 +01:00
cketti
18a58e2872
Added code to upgrade settings on import
...
This allows us to import files with an outdated content version, then
upgrade the settings to the current content version.
2011-12-11 05:16:22 +01:00
cketti
d57e684296
Extended *Settings classes to handle multiple versions
2011-12-11 05:16:22 +01:00
cketti
50058a92db
Fixed "managed" back button behavior in MessageView
2011-12-05 18:16:43 +01:00
Koji Arai
d1778e0303
mIgnoreOnStop should be set to true when call startActivityForResult()
2011-12-04 05:25:57 +09:00
cketti
63605b65b6
Add support for new auto-detect namespace setting to ImapStore
2011-12-01 06:30:47 +01:00
cketti
017033cd53
Changed UI to allow selecting the empty IMAP namespace
2011-12-01 06:05:05 +01:00
cketti
75cdbd860e
Only save IMAP path prefix in store URI if auto-detection isn't used
2011-12-01 05:58:44 +01:00
cketti
f729dd72dc
Code cleanup
2011-12-01 05:17:32 +01:00
cketti
9f41afc6e7
Use Store.createStoreUri() in AccountSetupIncoming
2011-12-01 05:10:13 +01:00
cketti
f2253a95d7
Modified ServerSettings to be able to create instances with "extras"
2011-12-01 02:57:53 +01:00
cketti
cb7b88680b
Use Store.decodeStoreUri() in AccountSetupIncoming
2011-12-01 02:28:57 +01:00
cketti
9e0ea7dd79
Extended ImapStore URI to support empty IMAP path prefix
2011-12-01 01:57:50 +01:00
cketti
d6fbeb2913
Fixed creation of store URIs when a "path" was used.
2011-11-29 21:45:52 +01:00
cketti
9350a3b1b6
Merge pull request #105 from andrewgaul/writer-string-concatenation
...
Avoid string concatenation in Writer.write
2011-11-27 16:32:25 -08:00
cketti
23c72cd181
FixedLengthInputStream - code cleanup
...
Inspired by andrewgaul
2011-11-28 01:21:50 +01:00
cketti
798d6753dd
FixedLengthInputStream - implement skip which honors mLength
...
Patch by andrewgaul
2011-11-28 01:14:49 +01:00
cketti
e145a621c7
FixedLengthInputStream - increment mCount only when read() succeeds
...
Patch by andrewgaul
2011-11-28 01:10:41 +01:00
Andrew Gaul
368bac851b
Prefer Boolean constants over Boolean.valueOf
2011-11-27 15:10:58 -08:00
Andrew Gaul
e93510b4b3
Avoid string concatenation in Writer.write
2011-11-27 13:57:11 -08:00
Andrew Gaul
057b316bcb
Avoid NPE in getOldestMessageDate
...
Caused by autounboxing a possibly null Long into a long.
2011-11-27 10:35:06 -08:00
Andrew Chen
4b548169d6
Merge pull request #82 from ashleywillis/issue-1424
...
Issue 1424: saving duplicate or similar drafts fixed.
2011-11-21 11:13:09 -08:00
Andrew Chen
6fc22283db
Merge pull request #102 from ashleywillis/pgp-fixes
...
Pgp-related fixes (issues 2152, 2900, 3673, partially 1424)
2011-11-21 07:28:16 -08:00
cketti
20eab9c812
Rewrite application/x-zip-compressed to application/zip
2011-11-21 11:49:03 +01:00
ashley willis
e9c8ec5598
Merge branch 'master' into pgp-fixes
2011-11-21 02:24:10 -06:00
ashley willis
94ba9bf71f
added comments, reworked a bit, and created warning dialog if some recipients don't have keys saved.
2011-11-21 01:59:51 -06:00
cketti
73edf5c31a
Fixed problem with back button because of custom dispatchKeyEvent()
2011-11-20 21:29:18 +01:00
ashley willis
18ad12eda7
incremented Settings.VERSION
2011-11-19 18:15:20 -06:00
ashley willis
079996ebe5
refuse to save draft marked encrypted
2011-11-19 18:05:24 -06:00
ashley willis
c49d1ecc8e
removed code from previous commit disabling of syncing drafts to be encrypted.
2011-11-19 13:34:26 -06:00
ashley willis
51c662f0d0
pgp issues 2152, 2900, and 3673. also option to disable not-yet-encrypted drafts related to issue 1424.
2011-11-19 00:49:04 -06:00
Koji Arai
d82d0a220c
Fixed Issue 3850. Revert part of the onBackPressed() magic to back from MessageView.
...
At least, this code still needed on android.os.Build.VERSION.SDK_INT == GINGERBREAD_MR1.
2011-11-17 22:52:35 +09:00
Apoorv Khatreja
4b0d3ccf21
Removed an unnecessary portion of code that attempted to handle command continuation requests after a UID COPY command. Also removed some extraneous test code that mysteriously creeped into the repo.
2011-11-17 02:46:01 +05:30
cketti
fe727f8b20
Merge pull request #98 from cketti/remove_legacy_code
...
Remove legacy code
2011-11-15 20:07:23 -08:00
cketti
4f060642ee
Merge branch 'imap_parser'
2011-11-16 04:52:05 +01:00
cketti
99163dc9b9
Removed isSizeOrExpungeResponse()
...
I don't understand what the purpose of this code was. It stopped parsing
before the end of the line was reached, thus causing problems with
parsing subsequent lines of the response.
2011-11-16 04:48:50 +01:00
cketti
8cdd283bb8
Added Javadoc comment
2011-11-16 03:59:27 +01:00
cketti
e9b0f82c11
Minor code cleanup
2011-11-16 03:23:59 +01:00
cketti
f8779095d9
Parse resp-text on command continuation requests
2011-11-16 03:17:36 +01:00
cketti
43f5cbb361
Renamed parseStatusResponse() to parseResponseText()
2011-11-16 03:11:35 +01:00
cketti
727c8564ec
Cleaned up readTokens()
2011-11-16 03:10:26 +01:00
cketti
688db057ac
Removed unused imports
2011-11-16 02:51:46 +01:00
Andrew Chen
97bfb5e229
Merge branch 'star-confirm' of https://github.com/ashleywillis/k-9 into pull-101
...
* 'star-confirm' of https://github.com/ashleywillis/k-9 :
Option to have confirmation on deleting starred messages.
incremented preferences/Settings.VERSION for new settings
2011-11-15 11:21:27 -08:00
ashley willis
6a02552b23
incremented preferences/Settings.VERSION for new settings
2011-11-15 13:01:30 -06:00
Andrew Chen
ec17cd3c38
Merge pull request #100 from ashleywillis/autoformat
...
Message Format: Automatic (plain text unless replying to an HTML message)
2011-11-15 10:13:45 -08:00
ashley willis
6694f637e3
capitalization and change of variable names.
2011-11-15 00:42:37 -06:00
ashley willis
3ffb5021e1
Option to have confirmation on deleting starred messages.
2011-11-15 00:28:41 -06:00
Jesse Vincent
a8ef6594ec
Preserve header order (with the exception of duplicate headers like
...
"received" they all show up where the first one did
2011-11-15 00:00:42 -05:00
Andrew Chen
c642b10b39
Merge pull request #99 from andrewachen/autoconfig_gmail_yahoo
...
Do a better job of auto-configuring Yahoo! and Gmail accounts
2011-11-14 18:57:38 -08:00
Andrew Chen
7ca438669e
Add theoretical support for RFC6154 SPECIAL-USE for auto-configuration.
2011-11-14 18:55:11 -08:00
Andrew Chen
95215f00b7
Kerio also supports auto-configuration; remove the gmail.com requirement to use XLIST for auto-configuration.
2011-11-14 18:27:08 -08:00
Andrew Chen
2f3565d180
Implement Gmail's XLIST IMAP command to determine Gmail-specific folders.
2011-11-14 18:15:32 -08:00
ashley willis
994f474aae
configured so setting message format to auto does not break k-9 if it is downgraded.
2011-11-14 20:12:08 -06:00
Andrew Chen
58d20a501a
Set the IMAP namespace for Gmail during auto-configuration.
2011-11-14 15:42:50 -08:00
Andrew Chen
44cc1930d5
If we auto-config a Yahoo! account, set the spam folder to be "Bulk Mail."
2011-11-14 15:42:40 -08:00
ashley willis
9201d16659
add MessageFormat.AUTO so that text/html messages are created only when necessary.
2011-11-14 17:28:45 -06:00
Andrew Chen
22e61b987e
Add javadoc for getSignatureHtml() and use StringUtil.isNullOrEmpty().
2011-11-14 14:23:29 -08:00
ashley willis
37f480c969
Merge ashleywillis' changes in https://github.com/k9mail/k-9/pull/97 .
...
Option to strip signature from quoted text in replies.
Strips signature from quoted text in replies (line of /^-- $/ or html
equivalent, and everything below). Per account.
2011-11-14 14:00:15 -08:00
ashley willis
1012ad56dd
Merge ashleywillis' changes in https://github.com/k9mail/k-9/pull/96
2011-11-14 13:20:07 -08:00
cketti
be70120ee5
Use Service.onStartCommand() instead of deprecated Service.onStart()
2011-11-10 06:36:14 +01:00
cketti
8c8b3eea9e
Use Intent.ACTION_SEND_MULTIPLE instead of string constant
2011-11-10 05:44:30 +01:00
cketti
07fa0c7264
Use Build.VERSION.SDK_INT instead of parsing Build.VERSION.SDK
2011-11-10 05:39:04 +01:00
cketti
14ff4d006e
Removed onBackPressed() magic
2011-11-10 05:38:52 +01:00
cketti
85f556e6c9
Removed helper function to create AbsoluteSizeSpan objects
2011-11-10 05:38:51 +01:00
cketti
5eb2533bcb
Removed code for old contacts API (ContactsSdk3_4)
2011-11-10 05:05:06 +01:00
cketti
c5cc62b570
Removed AutoSyncHelper and use API 5 methods directly
2011-11-10 05:05:05 +01:00
Andrew Chen
a2fcb54507
Merge pull request #95 from ashleywillis/reply-after-quote
...
added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);"
2011-11-07 15:51:05 -08:00
Andrew Chen
ef631e21d1
Merge pull request #83 from andrewachen/messageview_save_location
...
Restore position in MessageView after rotation screen.
2011-11-07 09:57:18 -08:00
ashley willis
efe591c34d
added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);" because bodyOffset could refer to header or footer
2011-11-07 01:59:03 -06:00
cketti
6497ac4cf4
Default authentication type for SMTP is automatic
2011-11-07 01:58:38 +01:00
cketti
6d9463801e
Don't call promptForServerPasswords() if we already know all passwords
2011-11-07 01:45:52 +01:00
cketti
d6c03de6f5
Fixed logic bug that prevented imported accounts from being recognized
...
We have to add new account UUIDs to "accountUuids" for them to show up
in the account list.
2011-11-07 01:45:52 +01:00
cketti
e2e9f8b6a3
Fixed startActivityForResult() failing for MessageList
...
Fixes issue 3638
2011-11-07 00:07:06 +01:00
Jesse Vincent
7ca72b9d0f
Work around broken office suites by sending an explicit mime type with files we open
2011-11-06 17:00:25 -05:00
cketti
70dc27c481
Make MimeUtility.getMimeTypeForViewing() return lower case MIME types
...
MIME type matching in Android is case-sensitive. So we convert the MIME
types we read from the email to lower case.
2011-11-06 02:05:47 +01:00
cketti
88a2dd6289
Merge branch 'issue549'
...
Conflicts:
src/com/fsck/k9/Account.java
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-05 18:47:55 +01:00
Andrew Chen
4a1046a893
Merge pull request #93 from andrewgaul/cursor-close-quietly
...
Introduce and use Utility.closeQuietly(Cursor)
2011-11-04 16:20:22 -07:00
Andrew Gaul
39aa577651
Introduce and use Utility.closeQuietly(Cursor)
...
This helper is in the same spirit as IOUtils.closeQuietly.
2011-11-04 09:58:55 -07:00
ashley willis
2b77c6e35c
moved code from onStop() to onPause() since onStop() may never be called.
2011-11-04 02:33:56 -05:00
Andrew Gaul
d301089f3c
Avoid string concatenation in String.format
2011-11-03 18:47:34 -07:00
cketti
5d9bf309c9
Avoid NullPointerException in services when process/service is restarted
...
See issue 3750
2011-11-03 22:10:24 +01:00
ashley willis
7f582f5a38
added mIgnoreOnStop for when adding an attachment.
2011-11-03 15:38:53 -05:00
Andrew Chen
f6eea9f014
Move the listener logic out of the Activity and into the View.
...
Change variable naming in ToggleScrollView to meet standard.
Cache the result of computeVerticalScrollRange() in ToggleScrollView.
2011-11-03 09:14:42 -07:00
Andrew Chen
57e0abbf8f
Merge pull request #84 from andrewgaul/api7
...
Use LinkedList instead of Deque.
2011-11-03 07:41:09 -07:00
Andrew Chen
981dc6cca6
Merge pull request #92 from andrewgaul/remove-combine-uuids
...
Prefer Utility.combine over Account.combinedUuids
2011-11-03 06:41:33 -07:00
Andrew Chen
7f046e5f0a
Merge pull request #91 from andrewgaul/findbugs-stream-close
...
Improve the way we open/close streams.
2011-11-03 06:40:07 -07:00
Andrew Chen
d80e5bfbd0
Merge pull request #90 from andrewgaul/close-quietly
...
Call IOUtils.closeQuietly instead of using empty try/catch block.
2011-11-03 06:35:42 -07:00
Andrew Chen
64b299ebec
Merge pull request #89 from andrewgaul/is-empty
...
Prefer Collection.isEmpty over size
2011-11-03 06:34:15 -07:00
Andrew Chen
9e74f9ffcf
Merge pull request #88 from andrewgaul/log-throwable
...
Log Throwables instead of concatenating
2011-11-03 06:32:20 -07:00
Andrew Chen
64e2247e8f
Merge pull request #87 from andrewgaul/map-initialization
...
Optimize static map, remove unneeded inner class, and use unmodifiable map.
2011-11-03 06:31:32 -07:00
Andrew Chen
8dccc7a996
Merge pull request #86 from andrewgaul/findbugs-concatenation
...
Prefer StringBuilder.append over String.concat
2011-11-03 06:28:51 -07:00
Andrew Gaul
c2e9e4b345
Prefer Utility.combine over Account.combinedUuids
2011-11-02 22:57:06 -07:00
Andrew Gaul
b53b0d33ba
Close streams on exceptional paths
...
Addresses FindBugs complaints.
2011-11-02 22:48:37 -07:00
Andrew Gaul
b1a807a712
Call IOUtils.closeQuietly where appropriate
2011-11-02 22:22:15 -07:00
Andrew Gaul
2599bdcc75
Log Throwable instead of concatenating
2011-11-02 22:18:30 -07:00
Andrew Gaul
70b635ec30
Initialize static map optimally
...
Remove unneeded inner class, use unmodifiable map, and mark as static.
2011-11-02 22:16:12 -07:00
Andrew Gaul
cb14cd9d78
Prefer StringBuilder.append over String.concat
...
Addresses FindBugs complaints.
2011-11-02 22:10:02 -07:00
Andrew Gaul
61c850e077
Remove dead stores
...
Addresses FindBugs complaints.
2011-11-02 22:02:41 -07:00
Andrew Gaul
98d0b61890
API 7 fixes
2011-11-02 20:47:48 -07:00
Andrew Gaul
647ae0a31c
Prefer Collection.isEmpty over size
2011-11-02 20:03:07 -07:00
Andrew Chen
674c39f3d5
Merge pull request #80 from andrewachen/unify_gesturedetector
...
Make the K9Activity.GestureDetector reusable
2011-11-02 18:04:01 -07:00
Andrew Chen
1e9a40ffd2
Merge pull request #81 from aatdark/issue3814
...
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 17:55:58 -07:00
Bernhard Redl
68cecb168e
added testcases for address#parse function,changed empty to null (conforms to existing code)
2011-11-03 01:36:57 +01:00
Andrew Chen
763ff2752d
Scroll to the last known position in the MessageView when rotating the screen.
2011-11-02 16:39:23 -07:00
Andrew Chen
b5dca5cf68
Merge pull request #76 from sunglim/string_util
...
Added StringUtils.isNullOrEmpty().
2011-11-02 10:50:52 -07:00
Andrew Chen
66881c0f2b
Merge branch 'master' of git@github.com:k9mail/k-9.git
...
* 'master' of git@github.com:k9mail/k-9.git:
Optimize java.util.* imports.
2011-11-02 08:37:12 -07:00
Andrew Chen
f884e967c9
Use MimeHeader.* constants when referring to content headers. Minor whitespace changes.
2011-11-02 08:34:06 -07:00
ashley willis
a021ab71de
Override onStop() to save email as draft when activity is changed (go to home screen, call received)
2011-11-01 22:12:51 -05:00
Bernhard Redl
6a76b073c3
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 02:08:06 +01:00
Andrew Chen
30151f1a70
Add parameter to MyGestureDetector to enable gestures for a specific detector, even if system-wide gestures are disabled.
2011-11-01 17:25:49 -07:00
Andrew Chen
edd78ea10c
Make the K9Activity GestureDetector more generic so that it can be used by both MessageList and MessageView.
...
Make the mTopView a ToggleScrollView. The only consumer is currently the MessageView, which uses a ToggleScrollView anyway. This should make it easier to reuse the anti-scrolling features in ToggleScrollView for ListView later on.
2011-11-01 16:55:13 -07:00
Andrew Chen
406aae6e61
Optimize java.util.* imports.
...
Conflicts:
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-01 13:54:55 -07:00
Andrew Chen
ea05f3b5d0
Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul
...
* 'legacy-collections' of https://github.com/andrewgaul/k-9 :
Prefer unsynchronized Collection types
2011-11-01 13:26:54 -07:00
Andrew Chen
186b65e523
Merge pull request #70 from andrewgaul/combine-one-element
...
Optimize Utility.combine for length 1 arguments
2011-11-01 12:51:44 -07:00
Andrew Chen
4395da270d
Merge pull request #77 from andrewgaul/findbugs-entryset
...
Prefer entrySet over keySet and get
2011-11-01 12:44:26 -07:00
ashley willis
57b9321a1e
issue-1424: saving duplicate or similar drafts fixed.
2011-11-01 03:02:29 -05:00
Andrew Gaul
773f2e8870
Prefer Integer.valueOf over explicit boxing
...
Addresses a FindBugs complaint.
2011-10-31 21:58:32 -07:00
Andrew Gaul
bfd11c444f
Prefer entrySet over keySet and get
...
Addresses FindBugs complaints.
2011-10-31 21:42:12 -07:00
Lim Sungguk
8ab10a7586
applied StringUtils.isNullOrEmpty()
2011-10-29 15:12:49 +09:00
cketti
807907cb9e
Merge branch 'master' into issue549
...
Conflicts:
res/values/strings.xml
src/com/fsck/k9/service/MailService.java
2011-10-29 05:22:07 +02:00
cketti
f345c33728
Removed useless try block
2011-10-29 05:10:13 +02:00
cketti
2d1f9f9c84
Reworked MailService to cut overhead when executing background tasks
...
Since MailService uses the auto shutdown mode of CoreService we can't
use CoreService.execute() with a startId parameter that is null. So this
change should also fix the problem some users reported where the pushers
weren't set up correctly.
See issue 2777
2011-10-29 05:08:37 +02:00
cketti
74f7abaec2
Cosmetic changes and documentation updates/fixes
2011-10-29 05:00:37 +02:00
cketti
987a1ea511
Merge branch 'master' of ssh://github.com/k9mail/k-9
2011-10-29 03:09:15 +02:00
cketti
7e1c19d4d8
Cosmetic changes - kill whitespace at the end of lines
2011-10-28 21:29:39 +02:00
Andrew Chen
f24d4c9155
Merge pull request #72 from andrewgaul/remove-literal
...
Remove unused literal methods
2011-10-27 23:32:28 -07:00
cketti
e3f6561008
Don't crash when trying to connect to an non-SSL service using SSL
...
Fixes issue 3798
2011-10-28 04:59:08 +02:00
Lim Sungguk
7903797080
stringutils
2011-10-28 03:50:23 +09:00
cketti
91ee21bb2d
Use "String.length() == 0" instead of String.isEmpty() [API 9+]
2011-10-27 19:11:44 +02:00
cketti
b69d6cb64c
Use Locale.US with toUpperCase() and toLowerCase() where appropriate
2011-10-27 17:17:43 +02:00
cketti
9327c86fe7
Use Locale.US when calling toUpperCase() on the generated MIME boundary
...
Fixes issue 3733
2011-10-27 16:52:27 +02:00
cketti
d3baa299f1
Use "reply after quoted text" value when editing drafts
2011-10-27 08:20:03 +02:00
Sven-Hendrik Haase
f4f726ae67
Fixed restoring drafts saved with "reply after quoted text" enabled
...
Fixes issue 2568
2011-10-27 07:23:01 +02:00
Andrew Chen
b6cdec43e9
Merge pull request #73 from andrewgaul/address-parse-npe
...
Fix NPE in Address.Parse
2011-10-26 18:15:40 -07:00
Andrew Gaul
ad5676ed28
Fix NPE in Address.Parse
...
Found by FindBugs. Also avoid an allocation in the uncommon case.
2011-10-25 21:24:38 -07:00
Andrew Gaul
e394924ce4
Prefer Random.nextInt over Math.random
...
Addresses a FindBugs complaint.
2011-10-25 21:21:23 -07:00
cketti
ae465789b7
Export default value for keys not found in preference storage
2011-10-26 05:13:22 +02:00
Andrew Gaul
a2d0f9ccb7
Remove unused literal methods
2011-10-25 13:56:07 -07:00
Andrew Gaul
844db81b8d
Optimize Utility.combine for length 1 arguments
2011-10-25 13:10:47 -07:00
Jesse Vincent
ae3f098b4a
Merge pull request #64 from andrewgaul/typesafe-set
...
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
Jesse Vincent
ea384b40a1
Merge pull request #66 from andrewgaul/redundant-combine-flags
...
Remove duplicated combine flags code
2011-10-20 05:33:37 -07:00
Andrew Gaul
4c5f2e59a0
Remove unused Utility.readInputStream
...
Consider IOUtils.toString instead.
2011-10-19 23:11:03 -07:00
Andrew Gaul
5b9f542bd7
Avoid type-unsafe Set
2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b
Remove duplicated combine flags code
2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
cketti
afd355f83c
Use Preferences.getAvailableAccounts() where appropriate
2011-10-18 05:09:20 +02:00
cketti
4d6946f47c
Start services and list folders after account has been activated
2011-10-18 05:06:32 +02:00
cketti
dd8cd33c5a
Fixed decoding of store URIs with empty passwords
2011-10-18 05:05:40 +02:00
cketti
9fa802afe2
Validate file format version and content version of settings file
2011-10-18 01:30:41 +02:00
cketti
e7ad0e296e
Validate account UUID on import
2011-10-17 23:33:32 +02:00
cketti
6b5b4e474e
Fixed store URI encoding/decoding in Pop3Store
2011-10-17 05:59:36 +02:00
cketti
d87e25dde1
Added new authentication methods to SmtpTransport.createUri()
2011-10-17 04:57:01 +02:00
cketti
75dc38a1c4
Added new settings to GlobalSettings
2011-10-17 04:52:33 +02:00
cketti
f08b1ef739
Added new settings to AccountSettings
2011-10-17 04:34:26 +02:00
cketti
3967654a3e
Show short message when moving accounts
2011-10-17 04:34:26 +02:00
cketti
52a92d93a1
Add dialog to ask for server passwords after import
2011-10-17 04:34:26 +02:00
cketti
849a4e37a0
Mark accounts as disabled on import
...
If the settings file doesn't contain passwords for the incoming and
outgoing servers we disable those accounts.
2011-10-16 19:24:31 +02:00
cketti
fc8d2e9979
Merge branch 'master' into issue549
...
Conflicts:
res/menu/accounts_context.xml
res/menu/accounts_option.xml
res/values/strings.xml
src/com/fsck/k9/Account.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/AsyncUIProcessor.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/ImportListener.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/Pop3Store.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-10-14 20:33:25 +02:00
cketti
effb45c463
Cleaned up success message after settings import
2011-10-14 06:19:30 +02:00
cketti
f5e684310e
Renamed StorageImportExportException to SettingsImportExportException
2011-10-14 06:00:10 +02:00
cketti
c835bb757a
Renamed StorageImporter to SettingsImporter
2011-10-14 05:58:55 +02:00
cketti
cf8bdef0a8
Renamed StorageExporter to SettingsExporter
2011-10-14 05:58:15 +02:00
cketti
0ae176bab3
Code/documentation cleanup. No functional changes.
2011-10-14 05:54:23 +02:00
cketti
470ba8bb03
Removed everything related to settings file encryption
...
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
2011-10-14 05:38:27 +02:00
cketti
fd16ff8fe6
Remove reference to NonConfigurationInstance when no longer needed
2011-10-14 04:15:45 +02:00
cketti
5b81dbc2ed
Use resource strings instead of hardcoding things
2011-10-14 03:42:04 +02:00
cketti
b146fcb2fd
Improved handling of object retention on configuration changes
2011-10-14 02:52:32 +02:00
cketti
b05750c245
Better input validation in *Store.createUri()
2011-10-13 02:35:08 +02:00
ashley willis
2058fc378d
Option to show next message after delete by default instead of previous.
2011-10-12 17:50:24 +02:00
cketti
a258415629
Merge pull request #60 from andrewgaul/builder-append-no-concatenation
...
Avoid concatenation in StringBuilder append
2011-10-12 08:28:32 -07:00
cketti
c34d896474
Merge pull request #59 from andrewgaul/immutable-sets
...
Make sets immutable
2011-10-12 08:26:43 -07:00
Marcus Wolschon
4c8ebb4bcd
added check for Null
2011-10-11 08:53:51 +02:00
cketti
7a9c747db9
Don't export incoming/outgoing server passwords
2011-10-11 03:12:18 +02:00
cketti
1de28150e2
Require accounts to at least have one identity when importing
2011-10-09 01:23:45 +02:00
cketti
13b74d0d9e
Added error logging
2011-10-09 01:14:59 +02:00
cketti
d791770154
Code cleanup
2011-10-09 00:31:33 +02:00
cketti
6714a7ec5a
Improved logging in StorageImporter
2011-10-09 00:04:00 +02:00
cketti
1ab7dbae54
Added input validation for folder settings
2011-10-08 21:30:45 +02:00
cketti
f21e14afc7
Added input validation for identity settings
2011-10-08 17:58:57 +02:00
cketti
060d21db3e
Make collections immutable
2011-10-07 21:20:12 +02:00
cketti
0920b0c14d
Changed the way SettingsDescription is used
...
Added ability to rewrite the string representation used internally to
something "pretty" on export.
Now only settings that have entries is GlobalSettings and
AccountSettings are exported. This prevents export of newer settings
that are left in the preference storage when downgrading.
2011-10-07 20:29:03 +02:00
Andrew Gaul
57be9e3ee3
Make sets immutable
...
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
Andrew Gaul
9b27aba2ba
Avoid concatenation in StringBuilder append
2011-10-06 09:20:11 -07:00
cketti
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti
31af4526ab
Merge pull request #58 from andrewgaul/spelling
...
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667
Make an inner class static
2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
83ee4253d5
Whitelist settings for export instead of blacklisting keys
...
Use GlobalSettings.SETTINGS an AccountSettings.SETTINGS to decide
which settings to export.
2011-10-04 05:13:17 +02:00
cketti
644571cfe5
Make sure the InputStream of the import file is always closed
2011-10-04 00:48:43 +02:00
cketti
f2a3752930
Added constants for (export) file format version and "settings version"
2011-10-04 00:09:38 +02:00
cketti
33ae5ff7d0
Added code to skip some account settings on export
2011-10-03 20:16:02 +02:00
cketti
0619eaf79c
Catch NumberFormatException when parsing disposition size parameter
...
Fixes issue 3712
2011-10-01 21:17:00 +02:00
cketti
88dc36da8a
Added a check to prevent an ArrayIndexOutOfBoundsException
...
Fixes issue 3683
2011-10-01 20:30:22 +02:00
cketti
dfa97cd878
Handle activity restarts due to configuration changes
...
Close existing dialogs before the activity is destroyed. Recreate them
and rewire AsyncTasks to the new activity instance after its creation.
2011-10-01 20:11:14 +02:00
cketti
6e1bf2965d
Fixed DateFormatValidator to handle placeholders SHORT and MEDIUM
2011-09-30 16:54:01 +02:00
cketti
cd72e197ec
Added code to skip certain settings on export
2011-09-30 16:47:59 +02:00
cketti
c76bec971b
Fixed compiler warning
...
Use new variable instead of overwriting an argument.
2011-09-30 14:58:13 +02:00
Jesse Vincent
defabdc20c
Additional service fixes from the original author of the issue 2777 fix
...
to stop the service from being shutdown when we have push enabled
2011-09-29 00:16:27 -04:00
Jesse Vincent
fd61b4f20b
Merge pull request #52 from andrewgaul/peekable-bad-offset
...
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
Andrew Gaul
7cf1bfcc98
Fix bad offset in PeekableInputStream
2011-09-20 21:21:50 -07:00
Koji Arai
f3795f3df5
Search same sender from searchable folders instead of the unified inbox
2011-09-16 01:33:51 +09:00
Andrew Chen
dd1334b874
Add some JavaDoc to SearchAccount stuff; astyle.
2011-09-12 15:08:34 -07:00
Jesse Vincent
cbaa9f5b3d
Work around cases where mail was last checked in the future.
...
Sometimes, user devices will have their clock misset. Previously, K-9
would just stop checking mail until the device caught up with the
future.
2011-09-05 22:16:04 -04:00
danapple
7d5bb99dbd
Add progress indicator during account move.
2011-09-05 12:45:53 -05:00
danapple
2867a90286
Disable account move menu items when account is at an end of the list.
...
Conflicts:
src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
danapple
06cabdbde1
Working version of moving accounts within the Accounts view.
2011-09-05 12:38:03 -05:00
danapple
c67ac4735f
Fixes Issue 3177
...
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes. This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count. If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
Jesse Vincent
50e6218c1d
Merge pull request #49 from senab/master
...
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-04 18:44:08 -07:00
Jesse Vincent
8223e4d4bf
Removed some doc annotations from chrisk's fix for the service stopping
...
issue (2777)
2011-09-04 16:13:19 -04:00
Christian Knecht
7cd6334c64
Stop service(s) if not in use - Fixes Issue 2777
2011-09-04 16:00:02 -04:00
Jesse Vincent
1b7481f854
optimize cketti's pop3 space-splitting code to not make lots of extra
...
copies of responses.
2011-09-04 15:53:12 -04:00