moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-08-13 17:03:48 -04:00
Code Issues Releases Wiki Activity

Remove the try-finally stream close. Add comment as to why this pattern doesn't work here.

Browse Source
This commit is contained in:
Andrew Chen 2012-09-07 23:47:21 -07:00
parent c44b19cda6
commit 2ef8cda13c
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/com/fsck/k9/mail/internet/MimeUtility.java
View File

@ -1059,16 +1059,15 @@ public class MimeUtility {
/*
* Now we read the part into a buffer for further processing. Because
* the stream is now wrapped we'll remove any transfer encoding at this point.
*
* We can't wrap this in a try-finally to close the InputStream. It looks like
* we depend on the underlying temp file to exist across calls, and closing it
* deletes the file, which isn't what we want. We should figure out if this
* is really the right way to be doing things, since it's triggering strict
* mode warnings.
*/
InputStream in = null;
try {
in = part.getBody().getInputStream();
return readToString(in, charset);
} finally {
if (in != null) {
in.close();
}
}
InputStream in = part.getBody().getInputStream();
return readToString(in, charset);
}
}