Commit Graph

983 Commits

Author SHA1 Message Date
Nick Burch
eb35f25f3b Support for cloning one extended format record onto another, plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@676203 13f79535-47bb-0310-9956-ffa450edef68
2008-07-12 17:21:54 +00:00
Nick Burch
0935654115 Support for cloning one font record onto another, plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@676201 13f79535-47bb-0310-9956-ffa450edef68
2008-07-12 16:56:55 +00:00
Josh Micich
b103b318bb Patch 45289 - finished support for special comparison operators in COUNTIF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675853 13f79535-47bb-0310-9956-ffa450edef68
2008-07-11 07:59:44 +00:00
Nick Burch
882d25e9e9 Improve javadocs relating to getLastRowNumber
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675792 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 22:39:53 +00:00
Nick Burch
927ed3a6ca Fix bug #45126 - Avoid generating multiple NamedRanges with the same name, which Excel dislikes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675776 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 21:49:37 +00:00
Nick Burch
1e5b805dfd Fix cell.getRichStringCellValue() for formula cells with string results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675727 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 20:54:42 +00:00
Nick Burch
fa00b16511 Back port fixes from the ooxml branch for CellReference column number<->letter stuff
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675717 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 20:30:46 +00:00
Nick Burch
81f9610e04 Fix bug #45365 - Handle more excel number formatting rules in FormatTrackingHSSFListener / XLS2CSVmra
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675671 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 18:41:25 +00:00
Nick Burch
f6730d9a3a Apply some changes inspired by bug # 45373, which improve the performance of HSSFSheet.shiftRows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675661 13f79535-47bb-0310-9956-ffa450edef68
2008-07-10 17:52:33 +00:00
Josh Micich
00c3543d99 Fix for bug 45367 - fixed boundary case when row zero is the last row removed from the sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675218 13f79535-47bb-0310-9956-ffa450edef68
2008-07-09 14:58:06 +00:00
Josh Micich
2262b7c5c8 Fix for bug 45348 - required tweaks to RVA formula logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@675079 13f79535-47bb-0310-9956-ffa450edef68
2008-07-09 01:45:33 +00:00
Josh Micich
718befdc6a Fix for bug 45354 - Proper distinguishing of cell references and named ranges within formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@674953 13f79535-47bb-0310-9956-ffa450edef68
2008-07-08 21:00:13 +00:00
Josh Micich
2f47f1e37a Fix bug #45338 - JDK 1.4/1.5 issue from r673997
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@674911 13f79535-47bb-0310-9956-ffa450edef68
2008-07-08 18:56:21 +00:00
Nick Burch
c622e72683 Fix bug #45338 - Fix HSSFWorkbook to give you the same HSSFFont every time, and then fix it to find newly added fonts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@673997 13f79535-47bb-0310-9956-ffa450edef68
2008-07-04 10:46:59 +00:00
Nick Burch
183c13a1d3 Fix bug #45336 - Fix HSSFColor.getTripletHash()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@673987 13f79535-47bb-0310-9956-ffa450edef68
2008-07-04 09:58:21 +00:00
Josh Micich
349d02400b Fix for bug 45334 - added impl for ERROR.TYPE()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@673863 13f79535-47bb-0310-9956-ffa450edef68
2008-07-03 23:09:08 +00:00
Josh Micich
6fcff0c660 Fix for bug 45334 - formula parser needs to handle dots in identifiers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@673853 13f79535-47bb-0310-9956-ffa450edef68
2008-07-03 22:20:18 +00:00
Nick Burch
70f9a0a528 Avoid spurious missing lines with the MissingRecordAware event code, and odd files that contain RowRecords in the middle of the cell Records.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@672562 13f79535-47bb-0310-9956-ffa450edef68
2008-06-28 18:21:21 +00:00
Nick Burch
74621c5983 Finish the EventWorkbookBuilder, now does sheet references in formulas properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@672550 13f79535-47bb-0310-9956-ffa450edef68
2008-06-28 17:04:09 +00:00
Nick Burch
591894c2f6 Make a start on being able to process formulas in the eventusermodel code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@671322 13f79535-47bb-0310-9956-ffa450edef68
2008-06-24 19:53:53 +00:00
Josh Micich
6527e63ed1 Fix for bug 30978 - small re-arrangement of class Ptg hierarchy for DeletedRef3DPtg and DeletedArea3DPtg. Similar to c664220
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@669809 13f79535-47bb-0310-9956-ffa450edef68
2008-06-20 07:10:03 +00:00
Josh Micich
c02655d884 Fix for bug 45234 - Removed incorrect shared formula conversion in CFRuleRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@669658 13f79535-47bb-0310-9956-ffa450edef68
2008-06-19 19:07:20 +00:00
Nick Burch
8a92f65d09 A partial fix for bug #30978, but something still remains, which seems to be related to changing the ptg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@669140 13f79535-47bb-0310-9956-ffa450edef68
2008-06-18 11:35:04 +00:00
Nick Burch
895d30e055 Make the test related to bug #30978, which shows that named ranges pointing to deleted sheets is ok, more complete
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@668155 13f79535-47bb-0310-9956-ffa450edef68
2008-06-16 13:39:44 +00:00
Nick Burch
acfbb1648c Slight tweak for named ranges pointing at deleted sheets, related to bug #30978
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@668153 13f79535-47bb-0310-9956-ffa450edef68
2008-06-16 13:20:42 +00:00
Josh Micich
473ac7ad05 added extra RVA test case (for bug 45206)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@668014 13f79535-47bb-0310-9956-ffa450edef68
2008-06-15 22:26:06 +00:00
Yegor Kozlov
e1de21bc09 bug#44692 - Fixed HSSFPicture.resize() to properly resize pictures if the underlying columns/rows have modified size
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@664515 13f79535-47bb-0310-9956-ffa450edef68
2008-06-08 15:31:05 +00:00
Yegor Kozlov
a0e68a7530 Correctly increment the reference count of a blip when a picture is inserted
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@664490 13f79535-47bb-0310-9956-ffa450edef68
2008-06-08 12:30:25 +00:00
Josh Micich
8eaa48315f Fix for bug 45091 - serialization of RefN~ tokens. Simplified Ptg class hierarchy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@664220 13f79535-47bb-0310-9956-ffa450edef68
2008-06-07 00:53:01 +00:00
Josh Micich
bade69a176 Fix for 45133 - OBJ Record (5Dh) needs to pad the sub-record data to a 4-byte boundary
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@663855 13f79535-47bb-0310-9956-ffa450edef68
2008-06-06 08:32:54 +00:00
Josh Micich
f35ba1b1cd Fix for bug 45145 - made sure RowRecordsAggregate comes before ValueRecordsAggregate. Also fixed BiffViewer to show correct record offsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@663765 13f79535-47bb-0310-9956-ffa450edef68
2008-06-05 22:24:05 +00:00
Josh Micich
c79342aeac Fix for bug 45123 - SharedFormulaRecord.convertSharedFormulas was ignoring token operand classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@663436 13f79535-47bb-0310-9956-ffa450edef68
2008-06-05 03:12:35 +00:00
Nick Burch
50d81039da Fix bug #45087 - Correctly detect date formats like [Black]YYYY as being date based
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660889 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 10:03:00 +00:00
Josh Micich
a811443b4b Fix for 45060 (and 45041) - Improved token class transformation during formula parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660828 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 06:19:31 +00:00
Josh Micich
4f1853e01c Changed class hierarchy of Ptg to improve 'operand class' transformation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660344 13f79535-47bb-0310-9956-ffa450edef68
2008-05-27 00:57:23 +00:00
Josh Micich
5ffa668496 Small fix for FormulaParser. Need case-insentive match for IF function name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660263 13f79535-47bb-0310-9956-ffa450edef68
2008-05-26 18:25:02 +00:00
Josh Micich
94c7876f74 Follow-on fix for bug 42564 (r653668). Array elements are stored internally column by column.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@660256 13f79535-47bb-0310-9956-ffa450edef68
2008-05-26 18:02:23 +00:00
Nick Burch
bdf210f9ee Help for bug #44840 - Improved handling of HSSFObjectData, especially for entries with data held not in POIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659575 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 15:55:08 +00:00
Nick Burch
f601b0899a Patch from Yury, plus tests, from bug #45043 - Support for getting excel cell comments when extracting text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659572 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 15:22:18 +00:00
Nick Burch
8ef6b8561d Extend the support for specifying a policy to HSSF on missing / blank cells when fetching, to be able to specify the policy at the HSSFWorkbook level
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659525 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 12:58:56 +00:00
Josh Micich
9b8395dd61 Fix for bug 35925 - Missing HSSFColor.TAN from HashTables returned by getIndexHash() and getTripletHash()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659478 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 08:55:48 +00:00
Josh Micich
a4aab681a7 Bug 45025 - improved FormulaParser parse error messages (r659452 had wrong bug number)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659455 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 06:54:46 +00:00
Josh Micich
dc3f6b36b8 Bug 45041 - improved FormulaParser parse error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659452 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 06:43:51 +00:00
Josh Micich
143128be30 Fix for bug 45046 - allowed DEFINEDNAME records without EXTERNALBOOK records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659429 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 05:28:54 +00:00
Josh Micich
4273046fca Fix for 45066 - sheet encoding size mismatch problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@659403 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 03:56:31 +00:00
Josh Micich
b1ad25f7e3 improved toString and refactored toFormulaString on Area(3D)Ptg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658833 13f79535-47bb-0310-9956-ffa450edef68
2008-05-21 19:57:40 +00:00
Nick Burch
e09c35f448 Put abstract write(OutputStream) method on POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658350 13f79535-47bb-0310-9956-ffa450edef68
2008-05-20 17:12:08 +00:00
Nick Burch
748647c9c0 Fix bug #44977 - Support for AM/PM in excel date formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658322 13f79535-47bb-0310-9956-ffa450edef68
2008-05-20 16:37:15 +00:00
Nick Burch
e548591e87 Support for specifying a policy to HSSF on missing / blank cells when fetching
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658308 13f79535-47bb-0310-9956-ffa450edef68
2008-05-20 16:30:19 +00:00
Nick Burch
2e633955d9 Patch from bug #44937 from Squeeself- Partial support for extracting Escher images from HWPF files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658302 13f79535-47bb-0310-9956-ffa450edef68
2008-05-20 16:01:53 +00:00
Nick Burch
74f90acf81 Fix bug 44898 - Correctly handle short last blocks in POIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658285 13f79535-47bb-0310-9956-ffa450edef68
2008-05-20 15:42:16 +00:00
Josh Micich
d6d5b97ad2 Minor patch to improve FormulaParser error messages like those from bug 45041
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@658033 13f79535-47bb-0310-9956-ffa450edef68
2008-05-19 23:07:27 +00:00
Josh Micich
047ca7a1f2 Bug 44306 - fixed reading/writing of AttrPtg and rendering of CHOOSE formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@657702 13f79535-47bb-0310-9956-ffa450edef68
2008-05-19 01:06:54 +00:00
Yegor Kozlov
ce8e1c9f62 added HSSFName.isDeleted() to check if the name points to cell that no longer exists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@657355 13f79535-47bb-0310-9956-ffa450edef68
2008-05-17 14:00:30 +00:00
Josh Micich
3ee85ee6a9 Fix for bug 40414 - update selected/active sheet after removing sheet from workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@657167 13f79535-47bb-0310-9956-ffa450edef68
2008-05-16 18:55:02 +00:00
Josh Micich
e5828d77dc Simplification of BiffViewer. Made easier to send results to file.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@657166 13f79535-47bb-0310-9956-ffa450edef68
2008-05-16 18:46:04 +00:00
Josh Micich
3524eaad44 44523 - fixed workbook sheet selection and focus
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@656893 13f79535-47bb-0310-9956-ffa450edef68
2008-05-15 23:30:08 +00:00
Yegor Kozlov
85feeabf9d Added boolean flag to turn on use of merged columns in autosize
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@655282 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 09:03:24 +00:00
Josh Micich
c1a11a8b7c 41187 - fixed HSSFSheet to properly read xls files without ROW records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@655278 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 08:15:39 +00:00
Josh Micich
0277016ab5 bug 23630 - fixed spelling mistake in constant name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@655216 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 01:30:56 +00:00
Josh Micich
9f125abf7d removed unused constructor and old comment after r654649
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@654650 13f79535-47bb-0310-9956-ffa450edef68
2008-05-08 23:06:30 +00:00
Josh Micich
2def1a9532 fixed mistake in FuncPtg.clone(), added test case, cleaned up outdated (since bug 13292) test method.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@654649 13f79535-47bb-0310-9956-ffa450edef68
2008-05-08 23:02:43 +00:00
Josh Micich
86746dde00 44950 - fixed HSSFFormulaEvaluator.evaluateInCell() and Area3DEval.getValue() also added validation for number of elements in AreaEvals
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@654356 13f79535-47bb-0310-9956-ffa450edef68
2008-05-08 00:52:05 +00:00
Nick Burch
6e46f03020 Add disabled test for bug #44898, and slightly improve a few poifs related error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653945 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 22:51:28 +00:00
Josh Micich
609058dea5 Another attempt to fix unicode problems in functionMetadata.txt. Made that file pure ascii.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653892 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 19:48:55 +00:00
Nick Burch
3475425c5f Fix up the functionMetadata.txt stuff to be end-to-end UTF8. Was assuming it before, but breaking on some systems, while now it ought to work fine everywhere
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653831 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 16:38:34 +00:00
Nick Burch
54200838bf Improve JavaDocs about iterators and gaps
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653815 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 15:37:45 +00:00
Josh Micich
6fc050034d 42570 - fixed LabelRecord to use empty string instead of null when the length is zero.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653675 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 03:57:15 +00:00
Josh Micich
8264540df1 42564 - fixed ArrayPtg to use ConstantValueParser. Fixed a few other ArrayPtg encoding issues.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653668 13f79535-47bb-0310-9956-ffa450edef68
2008-05-06 02:02:41 +00:00
Josh Micich
31ccbe6fc9 Follow-on from 28754 - StringPtg.toFormulaString() should escape double quotes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653608 13f79535-47bb-0310-9956-ffa450edef68
2008-05-05 21:38:07 +00:00
Yegor Kozlov
9e39df0103 restored mistakenly commented line
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653521 13f79535-47bb-0310-9956-ffa450edef68
2008-05-05 16:13:24 +00:00
Yegor Kozlov
72aceaf4dc take into account indentation in HSSFSheet.autosizeColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653484 13f79535-47bb-0310-9956-ffa450edef68
2008-05-05 13:59:11 +00:00
Josh Micich
3774c3228f Swapped ArrayIndexOutOfBoundsException for plain array length check in AbstractFunctionPtg.getParameterClass(). (To help debugging when trying to find a real AIOOB)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653125 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 20:13:56 +00:00
Josh Micich
bbe3ee9b4d 44929 - Improved error handling in HSSFWorkbook when attempting to read a BIFF5 file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@653117 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 19:53:38 +00:00
Josh Micich
8fb40de628 Fixed 44675 - Parameter operand classes (function metadata) required to encode SUM() etc properly. Added parse validation for number of parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652994 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 03:59:32 +00:00
Josh Micich
ef5cc62029 should have been submitted with r652934
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652936 13f79535-47bb-0310-9956-ffa450edef68
2008-05-02 22:49:38 +00:00
Josh Micich
9e6f2816c3 44921 - allow Ptg.writeBytes() to be called on relative ref Ptgs (RefN* and AreaN*)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652934 13f79535-47bb-0310-9956-ffa450edef68
2008-05-02 22:36:49 +00:00
Josh Micich
63a52cf21d 44914 - Fix/suppress warning message - WARN. Unread n bytes of record 0xNN
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652446 13f79535-47bb-0310-9956-ffa450edef68
2008-05-01 07:42:18 +00:00
Josh Micich
993bf57633 fixed bug 44892 - made HSSFWorkbook.getSheet(String) case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652426 13f79535-47bb-0310-9956-ffa450edef68
2008-05-01 03:25:37 +00:00
Yegor Kozlov
bd4e1ac388 more flexible creation of a cluster
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652290 13f79535-47bb-0310-9956-ffa450edef68
2008-04-30 06:21:04 +00:00
Yegor Kozlov
c5ce487ede correctly process PICT blips (see bug #44886)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@652288 13f79535-47bb-0310-9956-ffa450edef68
2008-04-30 06:19:38 +00:00
Nick Burch
64775cfe62 Fix from Trejkaz from bug #44857 - Avoid OOM on unknown escher records when EscherMetafileBlip is incorrect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@651992 13f79535-47bb-0310-9956-ffa450edef68
2008-04-27 18:02:13 +00:00
Yegor Kozlov
c52a8b10af Rich text in HSSFTextbox must have at least one format run. Make sure it is so and apply th default fopnt if no formats were applied.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@648623 13f79535-47bb-0310-9956-ffa450edef68
2008-04-16 08:43:08 +00:00
Josh Micich
35d89933c9 Conditional Formatting (30311) - API improvements, added HSSFSheetConditionalFormatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@648334 13f79535-47bb-0310-9956-ffa450edef68
2008-04-15 17:07:06 +00:00
Nick Burch
a51afa06f4 Nice and small change here... Update the formula parser code to use usermodel.HSSFWorkbook instead of model.Workbook. This should keep things a bit cleaner, and make it much easier for the formula code to work with XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@648303 13f79535-47bb-0310-9956-ffa450edef68
2008-04-15 16:00:50 +00:00
Yegor Kozlov
82bb0bc7ef make sure all hslf classes use POI loggers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647824 13f79535-47bb-0310-9956-ffa450edef68
2008-04-14 14:58:18 +00:00
Nick Burch
a23a1f11fc Switch to using our own logger, rather than the commons one
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647738 13f79535-47bb-0310-9956-ffa450edef68
2008-04-14 11:47:47 +00:00
Nick Burch
5a36ce6ec3 Finish off eventusermodel based Excel Extractor, and update the xls to csv converter (moved to correct place) based on discoveries for the text extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647576 13f79535-47bb-0310-9956-ffa450edef68
2008-04-13 15:09:42 +00:00
Nick Burch
497c9eb3c6 Start on a eventusermodel based excel text extractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647574 13f79535-47bb-0310-9956-ffa450edef68
2008-04-13 14:58:27 +00:00
Josh Micich
6f04c746ac fixed typo and formatting in class javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647278 13f79535-47bb-0310-9956-ffa450edef68
2008-04-11 19:36:37 +00:00
Nick Burch
3e3895049c Update HSLFSlideShow and HSSFWorkbook to take advantage of POIFS updates, and allow reading embeded documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@647186 13f79535-47bb-0310-9956-ffa450edef68
2008-04-11 14:43:05 +00:00
Nick Burch
beed69a11e Improve how POIFS works with directory entries, and update HWPFDocument to support reading an embeded word document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646870 13f79535-47bb-0310-9956-ffa450edef68
2008-04-10 16:59:10 +00:00
Nick Burch
f8c6a52a2c Initial support for getting and changing chart titles and series titles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646854 13f79535-47bb-0310-9956-ffa450edef68
2008-04-10 15:54:02 +00:00
Josh Micich
7024f8896e bugzilla 44792 - fixed encode/decode problems in ExternalNameRecord and CRNRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646666 13f79535-47bb-0310-9956-ffa450edef68
2008-04-10 07:06:55 +00:00
Nick Burch
63409a6647 Implement a proxy HSSFListener which tracks the format records, and lets you lookup the format string for a given cell. Convert the xls to csv example to use it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646405 13f79535-47bb-0310-9956-ffa450edef68
2008-04-09 15:36:39 +00:00
Nick Burch
3a7871a2dd Provide a common ole2 implementation of POITextExtractor, which gives access to the document metadata
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646312 13f79535-47bb-0310-9956-ffa450edef68
2008-04-09 12:46:42 +00:00
Josh Micich
08802e667e some more tweaks for bug 30311. Set some (unused) bits in FontFormatting to match Excel.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@646194 13f79535-47bb-0310-9956-ffa450edef68
2008-04-09 05:56:50 +00:00
Josh Micich
05eb15b87e 30311 - More work on Conditional Formatting - patch from Dmitriy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@645352 13f79535-47bb-0310-9956-ffa450edef68
2008-04-07 03:23:04 +00:00
Josh Micich
27761348b9 refactored all hssf junits to get test sample data in the in one place
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@645348 13f79535-47bb-0310-9956-ffa450edef68
2008-04-07 03:02:03 +00:00
Josh Micich
1051e2853c Follow up fix after r644473 (bug 44739) TestHSSFConditionalFormatting had a bug and wasn't yet included in the test suite hierarchy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@644509 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 21:17:26 +00:00
Josh Micich
dff9b26565 Fix for bug 44739 - Conditional formatting (regions with max row/col index)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@644473 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 20:25:53 +00:00
Yegor Kozlov
a4cb19f0e8 Fixed inconsistency between HSSFSHeet.getColumnWidth and HSSFSheet.getDefaultColumnWidth: getColumnWidth should always return width measured in 1/256th units.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@643834 13f79535-47bb-0310-9956-ffa450edef68
2008-04-02 10:25:18 +00:00
Rainer Klute
5c7ca6b786 44694 - HPSF: Support for property sets without sections
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@643670 13f79535-47bb-0310-9956-ffa450edef68
2008-04-02 00:50:45 +00:00
Josh Micich
b0825f0e98 fix for bug 44710 - Incorrect skip() of second formula in DATAVALIDATION record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@643654 13f79535-47bb-0310-9956-ffa450edef68
2008-04-01 23:53:51 +00:00
Josh Micich
5b0efa8e57 changes/status for #44675, #44695, #44691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642904 13f79535-47bb-0310-9956-ffa450edef68
2008-03-31 06:55:04 +00:00
Josh Micich
ede1814a1d silenced noisy tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642891 13f79535-47bb-0310-9956-ffa450edef68
2008-03-31 05:56:11 +00:00
Josh Micich
05fb78c5d4 More work on Conditional Formatting (bug 30311) junit and fixes from Dmitriy. Some other clean-up.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642878 13f79535-47bb-0310-9956-ffa450edef68
2008-03-31 05:10:35 +00:00
Nick Burch
4451a53ad3 Count implementation from ooxml branch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642737 13f79535-47bb-0310-9956-ffa450edef68
2008-03-30 13:39:51 +00:00
Nick Burch
ef5d5cb3d4 Move the FormulaEvaluator code out of scratchpad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642574 13f79535-47bb-0310-9956-ffa450edef68
2008-03-29 18:23:33 +00:00
Nick Burch
0fce9fd02e Move the missing record aware eventusermodel code out of scratchpad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@642566 13f79535-47bb-0310-9956-ffa450edef68
2008-03-29 17:45:28 +00:00
Josh Micich
0d7c6a7b78 annotated previous changelist(641964) with wrong buzilla number. Previous changes were for bug #44695.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@641967 13f79535-47bb-0310-9956-ffa450edef68
2008-03-27 20:15:13 +00:00
Josh Micich
60c8dc5688 fixes for ExternalNameRecord serialisation bug #44691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@641964 13f79535-47bb-0310-9956-ffa450edef68
2008-03-27 20:03:29 +00:00
Josh Micich
c6d7eb5387 patch 44675 - made POI capable of recognising var-args functions. Some related fixes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@641185 13f79535-47bb-0310-9956-ffa450edef68
2008-03-26 07:32:28 +00:00
Josh Micich
3ecb3c4c95 more javadoc + clean-up from Dmitriy (bug 30311 att 21711)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@641157 13f79535-47bb-0310-9956-ffa450edef68
2008-03-26 05:29:08 +00:00
Josh Micich
82f40767dc Added class javadoc. Patch 30311 from Dmtriy.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@640711 13f79535-47bb-0310-9956-ffa450edef68
2008-03-25 06:18:33 +00:00
Josh Micich
ba76fcf314 sort to int conversion sign extension fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@639918 13f79535-47bb-0310-9956-ffa450edef68
2008-03-21 23:47:51 +00:00
Nick Burch
ce8c6149ff Tweak how you get dataformat strings out of cell styles, to be more logical, and in keeping with how we'll want to do things for xssf too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@639836 13f79535-47bb-0310-9956-ffa450edef68
2008-03-21 21:04:47 +00:00
Nick Burch
f5b67d0e52 Fix for readCompressedUnicode not moaning about length=0, from bug #44643
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@639242 13f79535-47bb-0310-9956-ffa450edef68
2008-03-20 11:02:39 +00:00
Nick Burch
b57f30921b Simple patch from Josh from bug #44636 - fix for RefVPtg and edit-in-excel oddness
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@639232 13f79535-47bb-0310-9956-ffa450edef68
2008-03-20 10:16:15 +00:00
Nick Burch
f9c0c82b09 Fix bug #44627 - improve the thread safety of POILogFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@638815 13f79535-47bb-0310-9956-ffa450edef68
2008-03-19 12:49:35 +00:00
Nick Burch
f7e7b20f2e Patch from Dmitriy from bug #30311 - Support for conditional formatting records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@638812 13f79535-47bb-0310-9956-ffa450edef68
2008-03-19 12:28:56 +00:00
Yegor Kozlov
f9d8f43779 support align=distributed in HSSFTextbox
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@637870 13f79535-47bb-0310-9956-ffa450edef68
2008-03-17 13:02:46 +00:00
Nick Burch
bc88b7b1f4 Patch from Josh from bug #44609 - Handle leading spaces in formulas, such as '= 4'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@637601 13f79535-47bb-0310-9956-ffa450edef68
2008-03-16 15:48:02 +00:00
Nick Burch
8ca38c3e23 Patch from Josh from bug #44606 - Support calculated string values for evaluated formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@637595 13f79535-47bb-0310-9956-ffa450edef68
2008-03-16 15:29:34 +00:00
Yegor Kozlov
863b004ced Add accessors to horizontal and vertical alignment in HSSFTextbox
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@637189 13f79535-47bb-0310-9956-ffa450edef68
2008-03-14 18:05:55 +00:00
Nick Burch
86565db81c Make a start on handling different big block sizes in POIFS, but work isn't complete. See bug #35928 for part of what we're after
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@636786 13f79535-47bb-0310-9956-ffa450edef68
2008-03-13 15:38:28 +00:00
Nick Burch
709c487a42 Fix bug #44593 - improved handling of short DVRecords
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@636756 13f79535-47bb-0310-9956-ffa450edef68
2008-03-13 13:20:09 +00:00
Nick Burch
ff78b7ac71 Patch largely from Josh from bug #44539 - Support for area references in formulas of rows >= 32768
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634630 13f79535-47bb-0310-9956-ffa450edef68
2008-03-07 12:06:18 +00:00
Nick Burch
96198ae3d1 Improved support for read-only recommended workbooks, fixing bug #44536
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634619 13f79535-47bb-0310-9956-ffa450edef68
2008-03-07 11:36:14 +00:00
Nick Burch
e2dd40f66c Patch from Josh from bug #43901 - Correctly update the internal last cell number when adding and removing cells (previously sometimes off-by-one)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634617 13f79535-47bb-0310-9956-ffa450edef68
2008-03-07 11:18:02 +00:00
Nick Burch
924975f0e9 Change the behaviour on short last blocks to be a warning not an exception, as some people seem to have "real" valid files that trigger this. Fixed bug #28231
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@634318 13f79535-47bb-0310-9956-ffa450edef68
2008-03-06 15:54:06 +00:00
Nick Burch
e685873465 Big patch from Josh from bug #44504 - lots of formula parser improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633547 13f79535-47bb-0310-9956-ffa450edef68
2008-03-04 16:53:32 +00:00
Nick Burch
058d1e7d15 Fix indent, add more documentation, and make the error message more helpful
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633205 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 17:47:36 +00:00
Nick Burch
c5e82b7bae Patch from Josh from bug #44508 - Fix formula evaluation with evaluateInCell on boolean formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633169 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 16:55:00 +00:00
Nick Burch
a16fa738f0 Patch from Josh from bug #44510 - Fix how DVALRecord works with dropdowns
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633151 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 16:09:02 +00:00
Nick Burch
0102c66498 Patch from Josh from bug #44495 - Handle named cell ranges in formulas that have lower case parts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633126 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:26:38 +00:00
Nick Burch
0ecbec584e Fix from Yegor from bug #44491 - don't have the new style handy POIDocument property stuff break old style hpsf+hssf use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633118 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:10:46 +00:00
Nick Burch
0677bb2cff Patch from Paolo from bug #44481 - getVerticallyCenter shouldn't take a parameter, but leave the old version in as deprecated for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@633114 13f79535-47bb-0310-9956-ffa450edef68
2008-03-03 15:01:18 +00:00
Nick Burch
d601a0b4b7 Bug #44471 - Crystal Reports generates files with short StyleRecords, which isn't allowed in the spec. Work around this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@630164 13f79535-47bb-0310-9956-ffa450edef68
2008-02-22 11:40:00 +00:00
Nick Burch
7cdfaaa61d Patch from Josh from bug #44450 - VLookup and HLookup support, and improvements to Lookup and Offset
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@630160 13f79535-47bb-0310-9956-ffa450edef68
2008-02-22 11:23:50 +00:00
Nick Burch
1a6fcd5024 Patch from Josh from bug #44449 - Handle SharedFormulas better, for where there are formulas for the same area on two sheets, and when the shared formula flag is set incorrectly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629837 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:48:52 +00:00
Nick Burch
38421b7650 Patch from Josh from bug #44366 - InputStreams passed to POIFSFileSystem are now automatically closed. A warning is generated for people who might've relied on them not being closed before, and a wrapper to restore the old behaviour is supplied
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629829 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:35:59 +00:00
Nick Burch
173f63cd0a Patch from Josh from bug #44371 - support for OFFSET function, and various tweaks to the formula evaluator to support this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629821 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 15:08:44 +00:00
Nick Burch
acd787dcb8 Fix bug 38921, where HSSFPalette.findSimilar() wasn't working properly, and add tests for it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@629755 13f79535-47bb-0310-9956-ffa450edef68
2008-02-21 11:34:25 +00:00
Nick Burch
818880bf7f Further support for whole-column references, including formula strings and the evaluator. Also has some new tests for it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628065 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 13:50:38 +00:00
Nick Burch
720b6bdf3d Partial fix for bug #44410 - support whole column ranges such as C:C in the formula evaluator (so SUM(D:D) will now work). However, the formula string will still be displayed wrong
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628044 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:59:40 +00:00
Nick Burch
e113d12d34 Fix from Josh from bug #44417 - Improved handling of references for the need to quote the sheet name for some formulas, but not when fetching a sheet by name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@628033 13f79535-47bb-0310-9956-ffa450edef68
2008-02-15 12:04:42 +00:00
Nick Burch
4a7276e4ee Big formula update from Josh from bug #44364 - support for Match, NA and SumProduct functions, and initial error support in functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@627788 13f79535-47bb-0310-9956-ffa450edef68
2008-02-14 16:01:10 +00:00
Nick Burch
d92520eac2 If we have a document with a hpsf stream that exists, but is of the wrong type, then log a warning but continue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@620582 13f79535-47bb-0310-9956-ffa450edef68
2008-02-11 19:14:04 +00:00
Rainer Klute
c3340f823b - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619848 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 11:55:43 +00:00