Commit Graph

2966 Commits

Author SHA1 Message Date
Nick Burch
b3149fe1ad Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800214 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:30:15 +00:00
Nick Burch
a658a7f573 Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800211 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:25:41 +00:00
PJ Fanning
5c65b55bd4 Ensure SpreadsheetVersion is set for AreaReferences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
PJ Fanning
4209a1b2da Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
PJ Fanning
03d4e52bc0 expand StaxHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 13:53:47 +00:00
PJ Fanning
61b0ecbd4b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 07:30:07 +00:00
Greg Woolsey
0e23e4e9d8 Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 15:43:48 +00:00
Greg Woolsey
8c67848ad6 Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor
This is likely incomplete, but closer to where things should be.  It is backward compatible with previous uses of XSSFClientAnchor.

This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing).  This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden.

XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart.  That was not being set on parse previously, only when creating charts from scratch.  That didn't seem right.

XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors.  It DOES NOT update those initial inputs, however.  It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested.

Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs:

* EMUs (English Metric Units)
* Inches
* Centimeters
* Points
* Pixels
* Twips (1/20th of a point)

I'm sure there are more conversions that could be done there, I just started with what I needed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799643 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 05:16:38 +00:00
Tim Allison
649280df8c bug 61045 -- allow for (and log!) extra bytes in FormatRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 18:11:34 +00:00
Javen O'Neal
c0e5fcaa98 javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799332 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:52:43 +00:00
Nick Burch
4a51090ae7 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799320 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 09:04:02 +00:00
Javen O'Neal
171692edf2 bug 57919: close opened resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799316 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 08:13:58 +00:00
Javen O'Neal
46b5d839c3 bug 57919: add functions to write and close a POIDocument, guaranteeing closure of the output stream and document.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799308 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 07:28:14 +00:00
Javen O'Neal
4d692223bb whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799303 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:51:48 +00:00
Javen O'Neal
5de40d3261 bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799302 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:47:56 +00:00
Dominik Stadler
66bf6c5ad7 Need to do the casting differently to make the code compile with Java 6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799038 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:31 +00:00
Dominik Stadler
bac17be565 Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799035 13f79535-47bb-0310-9956-ffa450edef68
2017-06-18 05:59:11 +00:00
Andreas Beeker
0e57435abe #61169 - Text with Japanese characters overflows textbox
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798986 13f79535-47bb-0310-9956-ffa450edef68
2017-06-17 00:00:49 +00:00
Andreas Beeker
14b2d4501a #61162 - En-/decryption support for HWPF
- encryption support for HWPF
- refactor/unify EncryptionInfo handling in H**F classes
- remove Iterable interface from WorkbookRecordList - use getRecords() instead, to prevent modifications over the Iterator

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798722 13f79535-47bb-0310-9956-ffa450edef68
2017-06-14 17:21:50 +00:00
Greg Woolsey
e5c5cba87c Standardize some more common chart axis properties.
Implement the ChartAxis ss interface for date axes, which are pretty much a category axis with one extra property, a date granularity (not currently passed through, get it still from the CT* class).  Created the class and test from the category axis versions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798414 13f79535-47bb-0310-9956-ffa450edef68
2017-06-12 05:38:41 +00:00
Dominik Stadler
05570364db Move one testcase with incorrect source location
remove some junit dependencies in example-code
build: do not pass junit-jar to normal compile targets to avoid introducing it as dependency again 
Reformat code, fix warnings, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798202 13f79535-47bb-0310-9956-ffa450edef68
2017-06-09 12:49:01 +00:00
Andreas Beeker
20dcde37ec Handle encrypted files with known password in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797839 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 22:21:46 +00:00
Andreas Beeker
2b4f944883 #61162 - En-/decryption support for HWPF
Decryption for Binary RC4 and CryptoAPI (... XOR is missing)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797837 13f79535-47bb-0310-9956-ffa450edef68
2017-06-06 22:21:11 +00:00
Javen O'Neal
4232a72208 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796966 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 02:46:24 +00:00
Greg Woolsey
7e6007e0bd #61085 support table styles
Needed a bit more, to support table/range only border properties for "internal" vertical and horizontal borders.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796961 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 00:22:58 +00:00
Andreas Beeker
49e47cb6e1 Bug 61119 - Fix preset shape rendering and shading
- Fixed conversion of ooxml to awt angle
- replace subclasses and reflection calls with enums
- implemented tinting/shading of preset shapes


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796823 13f79535-47bb-0310-9956-ffa450edef68
2017-05-30 09:33:28 +00:00
Javen O'Neal
b3c6907741 bug 61059: fix NamePtg to read unsigned shorts instead of signed shorts, avoiding a AIOOBE when a workbook contains more than 32k Names. Thanks to Travis Burtrum for the patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796466 13f79535-47bb-0310-9956-ffa450edef68
2017-05-28 01:17:16 +00:00
Greg Woolsey
586cf38f1c Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color
teach XSSFColor and most things that create instances about indexed colors.

Null is a valid value for IndexedColorMap instances - the existing built-in default colors are used.

Whenever a workbook style is accessible in the call hierarchy its color mappings are passed down now.

Thanks for the unit test in the issue, it now passes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796359 13f79535-47bb-0310-9956-ffa450edef68
2017-05-26 23:14:48 +00:00
Dominik Stadler
d868026959 Bug 61063: Add a RefListEval to handle UnionPtg and implement it for Rank(), may be missing for other functions where ArrayEval is currently handled
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795963 13f79535-47bb-0310-9956-ffa450edef68
2017-05-23 21:13:02 +00:00
Javen O'Neal
7881d05743 github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795681 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 21:04:14 +00:00
Javen O'Neal
4ff23197e9 bug 61110: remove deprecated, misspelled CellReference#isRowWithnRange and #isColumnWithnRange methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795680 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 20:22:24 +00:00
Greg Woolsey
2d2aa5196a #61085 support table styles
Added more features - this allows a client app to fully display table styling without resorting to CT* classes, and has some helper logic for the additional processing needed for things like regional/area borders.

As far as I can tell I only added stuff, didn't change any existing behavior.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795648 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 04:05:32 +00:00
Javen O'Neal
0b767886bf replace "String.indexOf(String) >= 1" with "String.contains(String)"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795296 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 10:53:15 +00:00
Javen O'Neal
b6f78f8d57 github-32: speed up Irr() Excel formula computation by replacing Math.pow() with multiplication. Thanks to Daniel Kuan! This closes #32.
https://github.com/apache/poi/pull/32

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795266 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:18:17 +00:00
Nick Burch
fec503f1de Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795261 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 02:50:35 +00:00
Andreas Beeker
8c1346b138 Add ASL header and exclude table preset from rat-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795137 13f79535-47bb-0310-9956-ffa450edef68
2017-05-15 06:30:06 +00:00
Andreas Beeker
90dca20bd2 #52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Greg Woolsey
0cdc064b0c git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795002 13f79535-47bb-0310-9956-ffa450edef68 2017-05-12 18:01:32 +00:00
Dominik Stadler
e77156d9f4 Simplify the ValueEval.toString() implementations and include more information on unexpected types of ValueEval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794956 13f79535-47bb-0310-9956-ffa450edef68
2017-05-12 11:38:05 +00:00
Greg Woolsey
6bca07a15f forgot license (as always)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794093 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 18:33:49 +00:00
Greg Woolsey
18d107d974 61060 - teach DataFormatter about conditional formatting rules with number formats
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
2017-05-05 17:44:58 +00:00
Andreas Beeker
ad72f60ab6 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793727 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 22:16:26 +00:00
Andreas Beeker
76dbb5a1eb HPSF: Change CustomProperties to delegate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 19:18:45 +00:00
Andreas Beeker
d0630390d2 Remove Unicode chars in comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793647 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 14:08:04 +00:00
Andreas Beeker
0f78f6dc1f fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793604 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 00:14:55 +00:00
Andreas Beeker
cd6236c74b #52372 - OutOfMemoryError parsing a word file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:32:13 +00:00
Andreas Beeker
eeb697001f HPSF: Add CopyCompare to IntegrationTests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793600 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:29:19 +00:00
Andreas Beeker
3a1771ced1 HPSF: Enable new number types in VariantSupport
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:28:00 +00:00
Andreas Beeker
456b33a837 Fix hpsf javadocs and code issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:27:27 +00:00
Andreas Beeker
63b88fec6a HPSF: Use LittleEndianStream instead of offset calculation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793594 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:24:50 +00:00
Javen O'Neal
95538eb815 bug 61059: add @Override annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793418 13f79535-47bb-0310-9956-ffa450edef68
2017-05-01 21:51:34 +00:00
Dominik Stadler
5265ff6f81 Improve information contained in exception in CellRangeAddress()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:44 +00:00
Tim Allison
5f567f29a1 bug 61049 fix ordering of builtin formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 16:18:25 +00:00
Greg Woolsey
6e0a5916b5 Fix bug #61007
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.

Send what was checked previously plus only multi-segment conditional range formats.  Allows existing tests to pass plus the new test with the case for these conditional formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8 Fix bug #61007
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel.  Also added tests for the failing formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 18:10:52 +00:00
Dominik Stadler
511c2544a8 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad #60998 - HSLFTable.setRowHeight sets row height incorrect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 11:02:22 +00:00
Andreas Beeker
bd237e2483 #60996 - XSSF: Multiple embedded objects on same sheet are ignored
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 22:41:28 +00:00
Andreas Beeker
1f41c31984 Fix AIOOBE while extracting hssf pictures which are externally linked
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 21:43:22 +00:00
Dominik Stadler
0f193371ea Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 13:17:17 +00:00
Tim Allison
f426849947 bug 50955 convert Set to Singleton per Javen's code review
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790215 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 11:02:48 +00:00
Tim Allison
1bfd5f6585 bug 50955 and bug 60953 improve Big5 reader; ensure one character
per byte pair

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 01:45:55 +00:00
Tim Allison
af51ea4c10 bug 50955 -- word 6.0 charset fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790061 13f79535-47bb-0310-9956-ffa450edef68
2017-04-04 02:06:46 +00:00
Tim Allison
69c3311a98 60881 and 60891 -- on further look, no need to throw an exception for an encrypted xlsb. On the second, let's fix readFully to read fully.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787846 13f79535-47bb-0310-9956-ffa450edef68
2017-03-20 20:47:15 +00:00
Dominik Stadler
eef36a1580 Fix typo to "length", closes #51
Fix a few IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787659 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:30:04 +00:00
Dominik Stadler
e78eb68b10 60823: DGET function, correct behavior with multiple result entries but only one non-blank
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1787658 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 20:29:55 +00:00
Greg Woolsey
6349d2c614 Fixed #60858, which showed a regression of the fix for #56420 introduced by my refactoring to fix #56822.
Includes new unit test based on the bug sample file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786953 13f79535-47bb-0310-9956-ffa450edef68
2017-03-14 21:39:33 +00:00
Dominik Stadler
e13f7dc8af Fix some Sonar issues in sample "HSSFReadWrite"
Fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786695 13f79535-47bb-0310-9956-ffa450edef68
2017-03-13 14:09:27 +00:00
Dominik Stadler
c07c41659f HSSF: Try to handle cases where the length does not match the actual data while cloning, we see this in some documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786431 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:52 +00:00
Dominik Stadler
aafdbdfdd7 Remove unused import, IntelliJ warnings, duplicated code, improve some exception-texts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786429 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:13:39 +00:00
Javen O'Neal
5b879942fc bug 60787: remove calls to System.out.println. Thanks to Kamile Demirel.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1785185 13f79535-47bb-0310-9956-ffa450edef68
2017-03-02 18:47:28 +00:00
Javen O'Neal
c04e2a314a bug 59804: @Removal(version="3.15") version should be parsed to make sure the version number is recognizable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784230 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 04:59:29 +00:00
Greg Woolsey
717f279ed8 add javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783915 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:31:48 +00:00
Greg Woolsey
62d7050af9 Add null check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783914 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 18:18:10 +00:00
Andreas Beeker
0744f73add BugFix for JDK-6623219
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783698 13f79535-47bb-0310-9956-ffa450edef68
2017-02-19 21:36:45 +00:00
Javen O'Neal
ee6677ee56 bug 59893: fix a few forgotten unrelated changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783356 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:25:49 +00:00
Javen O'Neal
8677d099fc bug 59893: commit the changes from attachment 34068 that were unrelated to available()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783347 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 08:39:05 +00:00
Greg Woolsey
ca399b4f42 Bug #56822 fix COUNTIFS()
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b Bug #56822 fix COUNTIFS()
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78 Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae Expose Priority from newer-style HSSF CF rules
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 17:49:13 +00:00
Greg Woolsey
05125678ab Expose another common property, strikeout.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:45:47 +00:00
Nick Burch
1e5fa0dbea Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:35:43 +00:00
Greg Woolsey
b0d0d0fda5 Add evaluation of data validation rules and conditional formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 22:51:30 +00:00
Andreas Beeker
967a3b0e0c #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
2017-02-12 22:30:49 +00:00
Andreas Beeker
db3000b142 SonarQube fixes and removed redundant logger level checks, for simple String messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46 Add a possible future TODO
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 14:02:12 +00:00
Nick Burch
b6480adb9f If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5 Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 11:43:01 +00:00
Javen O'Neal
0f09e9eae2 bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:29:18 +00:00
Javen O'Neal
28999738a9 Convert all *.java files to use native end of line character(s)
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Andreas Beeker
5c4ab1dbdf #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:12:22 +00:00
Andreas Beeker
ac3d63926a #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:01:51 +00:00
Dominik Stadler
f431473f29 Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:40 +00:00
Dominik Stadler
560a33620a IntelliJ warnings, Javadoc, Formatting
Changes for the RecordFormatException deprecation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:46 +00:00
Andreas Beeker
c48a0cf334 #59836 - Tracker: Replace primitives with enums
preparation for removing those many HSSFColor subclasses with an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68
2017-01-22 22:01:22 +00:00