Commit Graph

8477 Commits

Author SHA1 Message Date
Greg Woolsey
ca399b4f42 Bug #56822 fix COUNTIFS()
Looks like at some point the function got added twice to the function instance map, once as null, later as the implementation.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783038 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:13:48 +00:00
Greg Woolsey
7dfa32c28b Bug #56822 fix COUNTIFS()
includes unit test from the issue.  Verified unit test results in Excel vs. incorrect previous POI results.  Test passes new code, as do existing tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Greg Woolsey
f990d41c78 Change logic to avoid a 1.6 compiler bug that doesn't properly handle generics. Eclipse compiler and JDK > 1.6 work properly, even with target runtime = 1.6, so I didn't see it locally. had to compile with the same version of the JDK as the build machine to see the problem.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783035 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:00:05 +00:00
Greg Woolsey
64f9c52a7d Fix accidental call to a method added in Java 7, which for some reason Eclipse didn't flag, even with compliance level set to 1.6.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783022 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 20:25:46 +00:00
Nick Burch
82244c3aae Expose Priority from newer-style HSSF CF rules
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782995 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 17:49:13 +00:00
Greg Woolsey
c88649ccd2 Ugh, that's what I get for copying someone else's code without fully reviewing it. Return the boolean property, don't wrap it in an extra if().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782989 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:49:24 +00:00
Greg Woolsey
05125678ab Expose another common property, strikeout.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782987 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:45:47 +00:00
Greg Woolsey
653c627b1f use Ant 1.9.9 explicitly, since Ant (latest) is now 1.10.1 which requires Java 8.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782983 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 16:18:55 +00:00
Greg Woolsey
117a898e35 Add license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782978 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 15:36:56 +00:00
Nick Burch
1e5fa0dbea Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782941 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:45:45 +00:00
Nick Burch
3f6cbffd8d Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782939 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:35:43 +00:00
Andreas Beeker
f4ca0b4b2b disable more H?? slaves
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782898 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 00:24:43 +00:00
Andreas Beeker
43921c1a19 Metro shapes: integration test regression on empty paragraphs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782897 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 00:18:13 +00:00
Greg Woolsey
b0d0d0fda5 Add evaluation of data validation rules and conditional formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782894 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 22:51:30 +00:00
Andreas Beeker
d74cfc4df5 Generics fix for metro shapes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782722 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 06:46:59 +00:00
Andreas Beeker
f316a0f115 remove H24 and ubuntu-4 slaves for all builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782714 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 01:09:40 +00:00
Andreas Beeker
41d7483ae3 #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782712 13f79535-47bb-0310-9956-ffa450edef68
2017-02-13 00:52:38 +00:00
Andreas Beeker
967a3b0e0c #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782706 13f79535-47bb-0310-9956-ffa450edef68
2017-02-12 22:30:49 +00:00
Andreas Beeker
ee56c07a74 java-6-openjdk-amd64 is not installed on H24
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782648 13f79535-47bb-0310-9956-ffa450edef68
2017-02-12 00:50:06 +00:00
Andreas Beeker
397771011f #60715 - Blank layout was not found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782635 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 21:48:05 +00:00
Andreas Beeker
faaa94d20a escape unicode chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782568 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 09:49:52 +00:00
Andreas Beeker
db3000b142 SonarQube fixes and removed redundant logger level checks, for simple String messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782548 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 00:57:39 +00:00
Nick Burch
ea2eb34f46 Add a possible future TODO
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 14:02:12 +00:00
Nick Burch
fc31afbb86 Use long for the dummy stream, to permit >2gb streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 13:51:33 +00:00
Nick Burch
b6480adb9f If a property refers to an invalid index, log + ignore rather than failing with a IndexOutOfBoundsException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782461 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 12:55:55 +00:00
Nick Burch
16a825ccf5 Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 11:43:01 +00:00
Nick Burch
eeae830d19 Start on a unit test for #60670, work required to get it passing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782380 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:51 +00:00
Nick Burch
31ec02043a Unit test comment for possible future expansion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782378 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:15 +00:00
Javen O'Neal
cc962432a4 bug 59030: revert r1746625 and restore r1731257, where XWPFTableCell#getVerticalAlignment() returns null rather than a default value (XWPFVertAlign.TOP) if vertical alignment is not set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782225 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:35:04 +00:00
Javen O'Neal
61f69324c7 bug 59030: convert to junit4; whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782224 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 18:32:53 +00:00
Javen O'Neal
453a868b41 Per JavaDoc and tallison, XWPFTableCell#getVerticalAlignment() should return null if valign is not set. Patch from prasad-babu. This closes #30 on GitHub.
https://github.com/apache/poi/pull/30#issuecomment-186224438

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782130 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 09:23:04 +00:00
Javen O'Neal
bee2efd2f5 bug 59227: set charset to UTF-8 to avoid editor problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782120 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:35:04 +00:00
Javen O'Neal
0f09e9eae2 bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:29:18 +00:00
Javen O'Neal
61d5a268fe target version 3.16-beta3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782118 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:24:35 +00:00
Javen O'Neal
28999738a9 Convert all *.java files to use native end of line character(s)
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Javen O'Neal
c2d3025161 bug 59983: correctly update shared formulas when shifting rows. Thanks to Luca Martini for the initial failing unit test with test file and Chiara Marcheschi for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782111 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:20:31 +00:00
Javen O'Neal
9a82490f0e +svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782109 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:04:55 +00:00
Andreas Beeker
5c4ab1dbdf #60625 - Rendering issue with background and shape overlayed by image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782096 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:12:22 +00:00
Andreas Beeker
ac3d63926a #60626 - ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782095 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 01:01:51 +00:00
Dominik Stadler
75ba4abede Jenkins DSL: Additionally disable node H12 for OpenJDK builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781824 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:50 +00:00
Dominik Stadler
cc99b7082a Update JDK 9 build config to use correct add-opens for java.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781823 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:46 +00:00
Dominik Stadler
f431473f29 Revert previous changes enough to restore the case in the commoncrawl-corpus which is failing now, add a unit-test for this case, enable one disabled unit-test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781822 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:40 +00:00
Dominik Stadler
142e52dfba Adjust for JDK 9 ea152 and newer: certain whitespaces in XML may now be trimmed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781821 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 22:34:09 +00:00
Tim Allison
be805a6e66 Bug 60677 -- handle multibyte encodings correctly in HwmfGraphics' drawString. Thanks to Dominik Stadler for finding this bug and a triggering doc via large scale regression testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781593 13f79535-47bb-0310-9956-ffa450edef68
2017-02-03 20:19:33 +00:00
Javen O'Neal
a1db2e3346 run release-prep0 with https URLs. This worked for kiwiwings.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781337 13f79535-47bb-0310-9956-ffa450edef68
2017-02-02 00:48:03 +00:00
Javen O'Neal
5e9e87ebee convert links to https
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781336 13f79535-47bb-0310-9956-ffa450edef68
2017-02-02 00:45:21 +00:00
Javen O'Neal
82ecb71a99 echo release version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781195 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 01:24:02 +00:00
Javen O'Neal
5e850ab3c3 ignore compile-lib/svnant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781194 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 01:21:28 +00:00
Javen O'Neal
16b8e35296 release-prep1 should abort if release tag already exists. It's likely that the version was entered incorrectly or copy-pasted from a template.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781191 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 00:59:20 +00:00
Javen O'Neal
fcaa74418d use https links
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1781001 13f79535-47bb-0310-9956-ffa450edef68
2017-01-30 22:05:29 +00:00