moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
8,453 Commits 29 Branches 84 Tags 722 MiB
b6480adb9f
Commit Graph

2825 Commits

Author SHA1 Message Date
Javen O'Neal
e0fd36dfb4 bug 60021: add note that EncryptionInfo may require poi-ooxml.jar to run EncryptionModes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763944 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 05:40:38 +00:00
Javen O'Neal
dd1ed5b840 bug 60197: Workbook#setSheetOrder should update named range sheet indices 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-09 03:02:13 +00:00
Javen O'Neal
5b8cbb0143 bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-07 12:39:15 +00:00
Dominik Stadler
89f68a6a47 Bug 53028: Broken auto fit row height in the cells with word wrap 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:56 +00:00
Dominik Stadler
86eafd3c44 Some IDE warning fixes and unit test adjustments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 19:59:44 +00:00
Nick Burch
4ffc48f7f7 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763399 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 10:39:03 +00:00
Mark Murphy
d106d31934 Add PropertyTemplate for drawing Borders (58787) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68
 2016-10-05 02:23:52 +00:00
Nick Burch
48e338e828 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762875 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 10:22:27 +00:00
Javen O'Neal
c1a11dc0b8 bug 60187: set BorderStyle directly instead of through short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762859 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 07:02:02 +00:00
Javen O'Neal
d169bdc2f9 bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-30 06:39:29 +00:00
Andreas Beeker
d8767e1c70 Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 23:36:09 +00:00
Andreas Beeker
0a7cd3b68b merge trunk to branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 21:01:40 +00:00
Dominik Stadler
db79fe043c Adjust some JavaDoc and remove some unnecessary String.valueOf() calls and fix some other compiler warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762617 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-28 08:44:14 +00:00
Javen O'Neal
43f7d5bfdc use equalsIgnoreCase for case-insensitive string comparisons 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761843 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-22 03:48:49 +00:00
Dominik Stadler
7e9cc96c46 Compiler/IDE warnings, unnecessary keywords, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 05:45:57 +00:00
Javen O'Neal
7e3f2ca8d1 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761669 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 03:57:22 +00:00
Javen O'Neal
deed3aa8d6 bug 57200,59788: be more specific why a temporary directory could not be created 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761667 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 03:19:31 +00:00
Javen O'Neal
2be1834545 bug 59933: demote accessibility of POILogger implementations of log(int, Object) and log(int, Object, Throwable) to be consistent with the POILogger abstract class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761665 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:45:39 +00:00
Javen O'Neal
ad8506b7f5 bug 59933: demote accessibility of NullLogger methods to the same level as POILogger 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761662 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:12:54 +00:00
Javen O'Neal
b44d6ec062 make POILogFactory _loggers cache final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761660 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 02:05:58 +00:00
Javen O'Neal
92d0f35c84 bug 59933: override POILogger#log(int, Object...) in NullLogger 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761657 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-21 01:41:54 +00:00
Dominik Stadler
c669e2ef67 Adjust handling of ByteBuffer some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761636 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-20 20:24:54 +00:00
Andreas Beeker
cda4f20482 merge trunk to branch 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-19 00:20:44 +00:00
Javen O'Neal
008a26d1bf bug 59705: consolidate bounds checking of column index into a helper method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-16 00:32:40 +00:00
Tim Allison
0784ab530a POI 60140 Prevent unnecessary memory usage -- no need to cache HeapByteBuffer in FileBackedDataSource, thanks to Luis Filipe Nassif for diagnosing this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760816 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-15 00:19:52 +00:00
Javen O'Neal
91f2d5680e declare methods throw runtime exceptions for IDE hints 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760784 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 21:32:34 +00:00
Nick Burch
41b0462f50 Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760719 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 15:01:57 +00:00
Nick Burch
5fc5680d15 Patches from Patrick Zimmermann from bugs #60130 and #60131 - DGET fix for empty cells and D* coding improvements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760717 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 14:59:00 +00:00
Javen O'Neal
ed7258906f move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 07:53:58 +00:00
Javen O'Neal
8842d7bffd move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 07:33:20 +00:00
Javen O'Neal
f71ae8036d bug 59791: add deprecation and removal annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 06:42:20 +00:00
Javen O'Neal
b0f814f83f bug 59791: add deprecation warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760639 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 06:22:38 +00:00
Javen O'Neal
9a11b0ffd5 bug 59791: add deprecation and removal annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:51:52 +00:00
Javen O'Neal
430ea9abfd bug 58190: add @since annotations to SlideShow.addPicture and findPicture 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:41:40 +00:00
Javen O'Neal
ca78ec2878 bug 58671: add @Removal annotation to deprecated fields 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760632 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:31:48 +00:00
Javen O'Neal
38cd94d676 bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 05:22:23 +00:00
Javen O'Neal
292d7ec27c bug 59264: revert getBorder[Top|Bottom|Left|Right|Diagonal]() to return short and add getBorder[Top|Bottom|Left|Right|Diagonal]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760627 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 04:35:45 +00:00
Javen O'Neal
2644cae418 bug 59790: add @Removal annotations to deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760624 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:51:45 +00:00
Javen O'Neal
5d1ae2cbae bug 59833: add @Removal annotation to deprecated methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:33:52 +00:00
Javen O'Neal
6839a52aa3 bug 59837,59833,59264: add @Removal annotations to CellStyle constants for which enums now exist 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760622 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:24:15 +00:00
Javen O'Neal
808996a683 bug 59873: add @Removal annotations for deprecated CreationHelper#createHyperlink(int) and Hyperlink static aliases to HyperlinkType enum values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760621 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:17:51 +00:00
Javen O'Neal
b91b5c5715 bug 59907: add @Removal annotations to AnchorType static aliases in ClientAnchor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760620 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 03:06:51 +00:00
Javen O'Neal
9ea5915313 bug 59907: add @Removal annotations to deprecated ClientAnchor#setAnchorType(int) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760619 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 02:55:52 +00:00
Javen O'Neal
0977e51818 bug 59907: restore ClientAnchor#setAnchorType(int) that was removed in POI 3.14 beta 1 and broke backwards compatibility without a 2 release deprecation notice 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760617 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-14 02:41:01 +00:00
Javen O'Neal
3c97d9700a change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-13 23:24:56 +00:00
Javen O'Neal
adfd0d7f6c bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760219 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-11 03:37:56 +00:00
Tim Allison
5747e871a1 poi-60044 small typo in last update to BuiltinFormats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760102 13f79535-47bb-0310-9956-ffa450edef68
 2016-09-09 18:41:37 +00:00
Javen O'Neal
9665b9859a bug 59791: add @Removal tags to Cell.CELL_TYPE_* constants, deprecated by CellType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757239 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-22 18:25:45 +00:00
Javen O'Neal
3f4612ffcb bug 59791: improve Cell.CELL_TYPE_* backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757235 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-22 17:57:45 +00:00
Andreas Beeker
9521546156 add encryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756964 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-19 20:23:16 +00:00
Andreas Beeker
5a486ec7c8 forgot cryptoapi encryption flags 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755541 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 21:00:10 +00:00
Andreas Beeker
680683cf77 merge down trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 01:14:36 +00:00
Andreas Beeker
0bfefdfc04 HSSF CryptoAPI decryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755461 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-08 00:10:44 +00:00
Nick Burch
f8bc502028 Whitespace, javadocs and @Overrides for the Logger classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-04 14:23:54 +00:00
Andreas Beeker
c4ac2e7758 Preparations for hssf_cryptoapi: 
- Add cloneable
- Change existing hslf cryptoapi to streaming


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755127 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 23:54:01 +00:00
Nick Burch
a1f6d9c832 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:53:43 +00:00
Nick Burch
60b2586c3f Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:42:04 +00:00
Nick Burch
560ff4004e Whitespace / indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:15:13 +00:00
Nick Burch
1570d79529 Whitespace / indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-03 11:12:50 +00:00
Javen O'Neal
3c77adf9e8 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 17:36:06 +00:00
David North
984683ab4b Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 12:51:24 +00:00
Javen O'Neal
5ddd038640 javadoc fix: incorrect deprecated replacement 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 05:32:41 +00:00
Mark Murphy
20907fc5b4 revert changes made in r1754691 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 04:21:14 +00:00
Mark Murphy
8c0adfe55f correction to junit bugs in r1754691 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 02:53:55 +00:00
Nick Burch
0fe7cd5299 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
 2016-08-01 00:17:33 +00:00
Mark Murphy
504a26b844 Add new class Cell Style Template and supporting enum for drawing borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 23:59:02 +00:00
Dominik Stadler
bbfb783a57 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-31 17:19:27 +00:00
David North
e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods. 
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-29 13:24:00 +00:00
Dominik Stadler
a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-24 11:38:50 +00:00
Nick Burch
13a7be6cd2 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 23:09:07 +00:00
Nick Burch
50519d3c73 Javadoc updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-21 10:27:27 +00:00
Nick Burch
92a146e4b5 If doing an in-place write, update the properties too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:31:57 +00:00
Nick Burch
d240667115 #57919 HPSF writing better error handling, and start prep for HSLF more write methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 23:09:33 +00:00
Nick Burch
3fa0449747 #57919 Add in-place and new-File write methods to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 22:35:51 +00:00
Nick Burch
8e50c77100 Prepare for pushing write() and write(File) to POIDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 18:41:27 +00:00
Nick Burch
4dee08213a Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21 Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:14:05 +00:00
Nick Burch
d84df31b50 #57919 Start on support for writing to a new File (faster than OutputStream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-20 11:07:29 +00:00
Javen O'Neal
50d1788d3d bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-19 08:02:41 +00:00
Javen O'Neal
ebbcd10034 bug 59881: fix spelling; patch from Patrick Zimmermann 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 18:25:28 +00:00
Dominik Stadler
abc3072df2 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30 Some warnings/improvements suggested by IntelliJ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-18 09:34:59 +00:00
Dominik Stadler
0bf845e0cc 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:27 +00:00
Dominik Stadler
da9cd94e76 Fix one more place where stream were left open when an exception is thrown 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:12 +00:00
Dominik Stadler
da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ... 
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 21:18:07 +00:00
Javen O'Neal
f7021f3788 only calculate getTextHeight if it will be used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:33:32 +00:00
Javen O'Neal
056a8dac84 reduce statement complexity in drawContent, also has fewer FLOPS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:29:34 +00:00
Javen O'Neal
ec4a47df73 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:27:57 +00:00
Javen O'Neal
9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 20:25:37 +00:00
Nick Burch
cf6d3489e0 #57919 Provide an initial in-place write method for HSSFWorkbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 19:02:58 +00:00
Javen O'Neal
d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow 
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 13:25:02 +00:00
Javen O'Neal
bc91641444 bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 11:56:13 +00:00
Javen O'Neal
b3300cf4be HexDump.writeHex is similar to Long#toHexString. Consider consolidating. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 10:22:43 +00:00
Javen O'Neal
7637cdc080 bug 59873: javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:48:36 +00:00
Javen O'Neal
31f2b5fdd1 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:32:29 +00:00
Dominik Stadler
16b0c380c9 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:27:07 +00:00
Javen O'Neal
c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 09:20:21 +00:00
Javen O'Neal
efbfef84a6 make private maps final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:29:40 +00:00
Javen O'Neal
f296b55b36 add @Override annotations to CreationHelper classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 07:14:49 +00:00
Javen O'Neal
14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 05:47:03 +00:00
Javen O'Neal
44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-17 04:41:20 +00:00
Dominik Stadler
af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-16 20:52:39 +00:00
Javen O'Neal
064abfa59a replace for-loop over index with for-each loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:41:26 +00:00
Javen O'Neal
6ea74f170d annotate purpose of each PROPER() function test case, add a few more test cases, identify some problems with ß handling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752786 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 07:25:16 +00:00
Javen O'Neal
0c3aade7b1 JDK8 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:35:21 +00:00
Dominik Stadler
aec95a4491 Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s) 
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5 bug 59858: describe why VBA macro reading failed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-15 06:12:37 +00:00
David North
a7d210932a "cannot not" presumably means "cannot" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-13 16:40:47 +00:00
Dominik Stadler
7beffbe3e3 Fix name of new OLE2ScratchpadExtractorFactory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-12 15:40:18 +00:00
Nick Burch
90e8b0f5b0 Last bit of reflection - get back to the full OOXML-enabled factory if we can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:57:42 +00:00
Nick Burch
4643b2ade0 Exceptions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:53:22 +00:00
Nick Burch
7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:47:02 +00:00
Nick Burch
a5fb04f45f Pull Scratchpad Extractor logic to own class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:27:02 +00:00
Nick Burch
ed7940dee5 Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-11 22:20:51 +00:00
Javen O'Neal
2ec6b12e13 bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 11:18:55 +00:00
Javen O'Neal
0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 08:29:02 +00:00
Javen O'Neal
847d90603a javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:54:36 +00:00
Javen O'Neal
79fac1f707 bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-10 06:52:16 +00:00
Andreas Beeker
cd349946a0 javadocs fixes (jdk8) 
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 18:52:26 +00:00
Javen O'Neal
44f0a6a66a add 2^x to POWER2 comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:54:07 +00:00
Javen O'Neal
e563dee47c bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:51:57 +00:00
Javen O'Neal
d8c65c777e bug 52949,59830: move module storage and decompressing into a standalone function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:18:29 +00:00
Javen O'Neal
76dde0aed5 bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 08:05:43 +00:00
Javen O'Neal
ca22a79e01 close streams if an exception is throw 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 06:30:12 +00:00
Javen O'Neal
909c07f37f bug 59830: add context to why no more bytes could be read from input stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-09 05:39:56 +00:00
Javen O'Neal
a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 22:28:28 +00:00
Javen O'Neal
3092c1121e bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-08 18:45:15 +00:00
Javen O'Neal
4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:20:34 +00:00
Javen O'Neal
bb7da64c25 add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 23:00:07 +00:00
Javen O'Neal
dd32e6b5b5 add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:46:06 +00:00
Javen O'Neal
85def647c9 whitespace (3sp to 4sp) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751839 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:38:09 +00:00
Javen O'Neal
2e142f4d6a whitespace (tabs to spaces) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751838 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:29:28 +00:00
Javen O'Neal
38c052cca1 add @Override annotations to spreadsheet formula Evaluation classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:27:32 +00:00
Javen O'Neal
9539c626a9 bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 22:22:10 +00:00
Javen O'Neal
b45a65e667 bug 59805: avoid memory leaks if time zone or locale are never set or user never resets the time zone or locale; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751739 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 01:10:24 +00:00
Javen O'Neal
5cbd7552eb findbugs: replace switch statement with fall-throughs with if statement, remove duplicate code 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751738 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-07 00:48:52 +00:00
Javen O'Neal
1766825f62 bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 09:23:34 +00:00
Javen O'Neal
0390a566a5 bug 59805: make LocaleUtil a static class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751601 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-06 05:40:53 +00:00
Javen O'Neal
78801432ed bug 59804: javadoc update 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751574 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:33:31 +00:00
Javen O'Neal
b37fde6d96 +svn:eol-style=native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:26:32 +00:00
Javen O'Neal
93f1f4b027 bug 59804: indicate when features were @Internal-ized 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:22:49 +00:00
Javen O'Neal
f78b266d73 bug 59804: add since attribute to @Internal annotation; add @Removal annotation to track when features will be removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751569 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 23:01:05 +00:00
Andreas Beeker
05cecde4a5 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751568 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-05 22:57:50 +00:00
Andreas Beeker
3ef17caad7 javadocs fixes (jdk8) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751387 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 23:45:19 +00:00
Javen O'Neal
18f2e5e405 typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751372 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 19:00:35 +00:00
Javen O'Neal
45f209e58c mark BitField as internal use only 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751371 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 18:50:26 +00:00
Javen O'Neal
eb6488585a bug 59790,59791: add @since javadoc annotation to FormulaType and CellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751287 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:49:44 +00:00
Javen O'Neal
be49e0c5a7 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 13:09:30 +00:00
Javen O'Neal
03671fea80 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:35:49 +00:00
Javen O'Neal
268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
 2016-07-04 12:21:42 +00:00