moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,443 Commits 29 Branches 84 Tags 722 MiB
a63d82bbee
Commit Graph

6131 Commits

Author SHA1 Message Date
Dominik Stadler
528a64dc76 Improve error messages to state which bounds are exceeded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-15 07:41:47 +00:00
Dominik Stadler
b01efb6855 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes 
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:30:10 +00:00
Dominik Stadler
c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a 
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:46 +00:00
Dominik Stadler
eeee511f71 Ignore a failure during cloning if we exceed file-format limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-13 21:29:23 +00:00
Dominik Stadler
b6de146895 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-12 09:44:47 +00:00
Nick Burch
118b728156 Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:40 +00:00
Nick Burch
a3966df033 Allow common tests to do auto-sizing even on SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-11 15:13:01 +00:00
Andreas Beeker
2aa39f5bdb Add example for adding videos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-06 22:23:47 +00:00
Andreas Beeker
ce22cc44c4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 22:03:44 +00:00
Dominik Stadler
fb07d95b55 Remove file from expected failures after changes for bug 56880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-05 07:51:35 +00:00
Tim Allison
827c3f562b Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
 2016-02-04 19:54:15 +00:00
Javen O'Neal
95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2 HSSFComment: note a final field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 12:14:55 +00:00
Javen O'Neal
6c89d062bf bug 58885: fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 04:04:56 +00:00
Javen O'Neal
e365e9cbac bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-31 03:27:35 +00:00
Dominik Stadler
a79dfd18e4 Adjust test to pass forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-30 11:02:54 +00:00
Dominik Stadler
68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called 
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-29 22:09:03 +00:00
Dominik Stadler
f94bb63332 add an ignored test for bug 58804 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726681 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-25 20:21:30 +00:00
Andreas Beeker
5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns 
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-24 00:12:10 +00:00
Dominik Stadler
2ac89a2dc9 Rename test-source file to actual class name to avoid constant recompilations on 'compile-main' 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725336 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:38 +00:00
Dominik Stadler
a369daa432 Fix possible NPE found with msg-file from CommonCrawl 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725334 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 20:16:23 +00:00
Dominik Stadler
fe359afec3 Fix possible NullPointerException with invalid/unsupported image types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-18 19:56:30 +00:00
Javen O'Neal
0173f22787 make SXSSFWorkbook member variables private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725047 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:58:25 +00:00
Javen O'Neal
14beee1cfd whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725043 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:31 +00:00
Javen O'Neal
18c5045d5b fix questionable List.remove(int) in SXSSFITestDataProvider 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725042 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:23:05 +00:00
Andreas Beeker
94fdd517aa BugFix: wrong hyperlink record added - used child instead of parent record 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725041 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:19:34 +00:00
Javen O'Neal
51e4b32498 add @Override annotations to ITestDataProviders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725040 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:03:58 +00:00
Javen O'Neal
276e95e43f bug 58879: add SpreadsheetVersion to Workbook interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 22:01:33 +00:00
Andreas Beeker
79920b06eb Fix NPE when calling HSLFTextRun.setHorizontalCentered() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725022 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 19:27:58 +00:00
Andreas Beeker
c1263423cf #56004 - Support for WMF rendering 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:46:17 +00:00
Dominik Stadler
50d09bf36c Fix a NullPointerException that occurs with some PPTs now but did not in POI 3.13 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724487 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:49 +00:00
Dominik Stadler
e91e15ab10 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 19:45:05 +00:00
David North
a08539ef02 Generalised API for adding ignored errors, e.g. number stored as text. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724469 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 17:54:24 +00:00
Dominik Stadler
8793846bc6 Bug 58829: Remove some useages of printStackTrace() and some other minor cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 15:59:38 +00:00
Dominik Stadler
8cf781c31b Rework test to not catch exception, junit does a good job of handling unexpected exceptions itself, StringBuffer replacing, code duplication 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724368 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 08:16:15 +00:00
Nick Burch
c86a4af85e Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491 #58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 07:26:26 +00:00
Andreas Beeker
0ded035dda Javadocs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724343 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-13 01:09:43 +00:00
Andreas Beeker
b0c16b8261 #57796 - Support hyperlink extraction when rendering slides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207 More Office 12 DSI property IDs, getters/setters to follow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805 Bump up the max DSI property ID, and list a few Office 12 well known IDs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-11 18:26:24 +00:00
Andreas Beeker
f56b918b16 #54916 - POI does not always read all the slides in pptx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723966 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 20:44:17 +00:00
Andreas Beeker
b3b4ed6564 add other printStackTrace methods to forbidden-apis-check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 02:20:35 +00:00
Andreas Beeker
22a9bade84 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723898 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-10 01:12:16 +00:00
Tim Allison
f065bf6e00 POI-58822 switch printStackTrace for actual log msg. Should probably open separate ticket to handle handful of other instances 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723765 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-08 17:06:39 +00:00
Javen O'Neal
1e9fd97f78 bug 58815: javadoc spelling 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-07 01:53:05 +00:00
Andreas Beeker
afb36678f5 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723198 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-05 23:40:47 +00:00
Andreas Beeker
6ec54a0177 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722771 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 22:46:57 +00:00
Dominik Stadler
0fe35af294 Undo changes to file in assertCloseDoesNotModifyFile to not have dirty files after running tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722756 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:37:52 +00:00
Dominik Stadler
f54452a0e7 Try to reproduce bug 52258 and add more checks to integration tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722755 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 21:23:09 +00:00
Dominik Stadler
c4c9ac0ccf bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:17 +00:00
Dominik Stadler
ff8592b190 Fix bug 58067: XWPF: don't return deleted text when document is in review-mode 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722715 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 13:28:01 +00:00
Javen O'Neal
bc6a4a20d4 re-throw errors we aren't looking for 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722708 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:48:05 +00:00
Javen O'Neal
4f6a75b701 bug 58779: check if SlideShowFactory.create() modifies the file being read when the slideshow is closed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722707 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 09:16:59 +00:00
Javen O'Neal
2cf06902d5 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722696 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:34:33 +00:00
Javen O'Neal
87ec46ff34 test XSLF SlideShowFactory creation methods individually for more granular unit test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722695 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-03 01:26:29 +00:00
Javen O'Neal
d747590977 rearrange unit tests into more, smaller functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722667 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:20:43 +00:00
Dominik Stadler
67d7b4a231 Move test for bug 57236 as it seems to be fixed since some time 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722666 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:41 +00:00
Dominik Stadler
b037995fdd Add test which reproduces bug 58325, seems the file uses AlternateContent which POI does not support (yet) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722665 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 21:11:28 +00:00
Javen O'Neal
347881ef1e bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39 fix javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7 bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-02 03:40:22 +00:00
Andreas Beeker
f5a24203b8 remove test debug stuff 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722556 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:45:30 +00:00
Andreas Beeker
9072855208 preparation for #54916 - commit unrelated changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722538 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 19:05:50 +00:00
Dominik Stadler
4803a0c355 bug 58618: XWPFParagraph insertNewRun and removeRun work incorrectly for 
runs after hyperlink/field runs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722503 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:28:01 +00:00
Dominik Stadler
bbd6e63c60 Include full nested exception, not just localized message 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722502 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:50 +00:00
Dominik Stadler
a6957b5c91 Some more unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722501 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:35 +00:00
Dominik Stadler
39551f8e01 Combine common functionality in POIXMLTypeLoader into helper method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722500 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 16:27:27 +00:00
Andreas Beeker
006595947d add ignored testcase for multiple signatures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722497 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 15:04:06 +00:00
Andreas Beeker
318f0b35b8 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
close resources

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722482 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 02:22:31 +00:00
Andreas Beeker
8ed770dfe3 remove unnecessary @SuppressWarnings("deprecation") warnings (because of old xml schemas) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722480 13f79535-47bb-0310-9956-ffa450edef68
 2016-01-01 00:45:05 +00:00
Andreas Beeker
e7d60982c7 #55030 - RichTextRun getFontName can not get Chinese font name 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722479 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 23:49:34 +00:00
Andreas Beeker
f317f5e288 #56570 - RecordType has repeat by code type 3009 
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 22:10:17 +00:00
Andreas Beeker
ee6966dae9 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722465 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 20:23:20 +00:00
David North
069d7c6141 Fix example. If you don't call super for the non-ignored sheets, everything breaks because you end up with an empty workbook. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722457 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 18:15:35 +00:00
Dominik Stadler
7f105042ba Fix bug 58760: non-standard namespace-key breaks parsing XLSX files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722433 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 09:56:33 +00:00
Dominik Stadler
c7baa89709 Revert changes to integration-test-framework to not make tests fail with strange errors about entity expansion limits 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722425 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-31 08:23:04 +00:00
Dominik Stadler
5344aa12cd Use parameter in unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722412 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:56 +00:00
Dominik Stadler
902830cf14 Adjust test for extracting some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:50 +00:00
Dominik Stadler
8589924b22 Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:44 +00:00
Dominik Stadler
e4b168d27f Add null-handler in integration-tests for two Visio files which are not handled (yet) and adjust memory handling somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722408 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:30 +00:00
Dominik Stadler
8ae2972f3d Bug 58616: Try to initialize with empty password if not done before 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:23 +00:00
Dominik Stadler
b4ac21a810 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722406 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:13 +00:00
Dominik Stadler
b06eaa0d3e Exclude file from integration-tests until bug 58760 is fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722405 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-30 20:31:04 +00:00
Andreas Beeker
5a8442a16a WMF - remove test output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722249 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 23:53:52 +00:00
Nick Burch
a3d4d2571f Disabled unit test for #58760 (problem remains) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722244 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 22:42:17 +00:00
Javen O'Neal
434ebbbdef remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722095 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:41 +00:00
Javen O'Neal
8be029b0c6 add comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722094 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:44:57 +00:00
Javen O'Neal
b96af85631 move comment 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722093 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:43:40 +00:00
Javen O'Neal
900d21a59c javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722092 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:41:50 +00:00
Javen O'Neal
44c5423be4 add unit test for bug 58779 when the problem gets fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 10:40:20 +00:00
Javen O'Neal
dba7fcdd4e junit3 -> junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:54:59 +00:00
Javen O'Neal
5310fc4b6d revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:28:32 +00:00
Javen O'Neal
6bc5c33c10 revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 09:21:17 +00:00
Javen O'Neal
5ab2c61a3f make spreadsheet file names static final rather than initializing them with setUp() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 08:53:46 +00:00
Javen O'Neal
7980a6b457 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722070 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 07:38:31 +00:00
Javen O'Neal
eb5bca1612 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 06:55:22 +00:00
Javen O'Neal
ef26a1d15c bug 58775: set an upper limit on number of data formats, default 250. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 05:46:20 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 02:57:58 +00:00
Javen O'Neal
22b03ba71b convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:26:55 +00:00
Javen O'Neal
1dd49eff7c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 01:18:16 +00:00
Andreas Beeker
a89d5210c3 WMF fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722046 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:45:59 +00:00
Javen O'Neal
ae1020ac35 bug 58778: override a built-in number format, such as using £ instead of $ for currency 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-29 00:12:04 +00:00
Javen O'Neal
bf5e95d37a bug 58740: javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 16:04:47 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:50:54 +00:00
Javen O'Neal
0404c61acc bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:37:23 +00:00
Javen O'Neal
8f47967d55 write for loop for performance and readability 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:20:30 +00:00
Javen O'Neal
0849d8c34a bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:19:50 +00:00
Javen O'Neal
f3c14d82a6 simplify bug 57880 test case: 
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 14:03:52 +00:00
Javen O'Neal
934effd443 add convenience methods for writing and reading back XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 13:44:08 +00:00
Javen O'Neal
3204cedf28 bug 58775: use assertNotBuiltInFormat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:13:17 +00:00
Javen O'Neal
0ef05fcdab java docs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:11:13 +00:00
Javen O'Neal
9bdfcc4be6 bug 58775: add unit test to test for non-built-in data formats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 12:10:12 +00:00
Javen O'Neal
8a7cd6308e bug 58775: add Override annotations, Javadocs, and comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 07:56:54 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 05:43:11 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures 
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-22 22:35:59 +00:00
Andreas Beeker
b333ed457d #56004 - Support for WMF rendering (parsing the WMF records) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-21 01:26:39 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-20 20:39:01 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-17 12:39:01 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 09:51:22 +00:00
Andreas Beeker
ad89fdcaf5 #58718 - Master styles not initialized when running multithreaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719758 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-13 01:50:24 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:43:26 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 21:11:38 +00:00
Javen O'Neal
dedb924183 bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:51:54 +00:00
Javen O'Neal
37622ec57e make test easier to understand using A1 addresses instead of row+col numbers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-06 20:43:27 +00:00
Dominik Stadler
96cb8c18fe Bug 58084: Fix cloning Cell Styles with Borders 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717973 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:39:07 +00:00
Dominik Stadler
387fb86d68 Eclipse warnings, code formatting, javadoc, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717972 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 14:38:14 +00:00
Javen O'Neal
4aa6108c0d add hashCode for corresponding equals function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717940 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:59:26 +00:00
Javen O'Neal
abced24fe4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717938 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:56:59 +00:00
Javen O'Neal
eca89530d3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717931 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 11:12:27 +00:00
Javen O'Neal
26abacebaf FindBugs warning: ExcelStyleDateFormatter doesn't override java.text.SimpleDAtaFormat.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717930 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:54:21 +00:00
Javen O'Neal
3b24eaacd3 make fields static 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717929 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:51:03 +00:00
Javen O'Neal
ebbf3d0ddb whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717928 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:47:31 +00:00
Javen O'Neal
6d17f8ddef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717927 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:46:58 +00:00
Javen O'Neal
17a4680cee findbugs: check return value of File.mkdir(s), and don't accidentally catch RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717923 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:33:28 +00:00
Javen O'Neal
93497e5b0e add comments for names of missing functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717920 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 10:01:58 +00:00
Javen O'Neal
b6e5801a1c fix javadocs errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717907 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:20:36 +00:00
Javen O'Neal
83a2f13494 fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717903 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:10:26 +00:00
Javen O'Neal
44c9afd31d fix javadoc errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717902 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 07:05:52 +00:00
Javen O'Neal
9c19c23291 bug 58570: add get/setActiveCell to Sheet interface, add Cell.getAddress, 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717900 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:36:27 +00:00
Javen O'Neal
293ef9fe17 remove deprecated functions (since 2008) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717899 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-04 06:30:34 +00:00
Dominik Stadler
5a8aceec32 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-02 21:47:52 +00:00
Andreas Beeker
cc77b04a94 Sonar fixes, direct array parameter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717359 13f79535-47bb-0310-9956-ffa450edef68
 2015-12-01 00:23:21 +00:00
Andreas Beeker
f0ed3cbbab - #47904 - Update text styles in HSLF MasterSlide 
- common sl unification for TextParagraph.setTextAlign

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717351 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 23:34:30 +00:00
Javen O'Neal
89fbd66262 bug 58670: cleanup from r1717192 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717194 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 07:03:09 +00:00
Javen O'Neal
8410c84ad6 bug 58670: replace SXSSFRow's storage of SXSSFCells[] with a TreeMap<Int, SXSSFCell> 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717192 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 06:07:49 +00:00
Javen O'Neal
b5ad3a9327 add @Override annotations to SXSSFRow 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:28:57 +00:00
Javen O'Neal
24e5a0a458 add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717179 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:22:14 +00:00
Javen O'Neal
5650b03ea0 testBool/testErr: check values before writeOutAndReadBack 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717178 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:21:01 +00:00
Javen O'Neal
7fc9df615f fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717171 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 05:00:24 +00:00
Javen O'Neal
dcba12a0ce whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717167 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:50:18 +00:00
Javen O'Neal
a5725f9b21 add @Override and @NotImplemented annotations to SXSSFCell, update javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717164 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:43:32 +00:00
Javen O'Neal
2924c7b9da break testBoolErr into 2 unit tests. The test shouldn't be aware of the underlying implementation for HSSFRows, and shorter tests are better 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717163 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:38:04 +00:00
Javen O'Neal
b58839e4b0 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717162 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:36:17 +00:00
Javen O'Neal
71b587ef36 bug 58671: change MissingCellPolicy from class to enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717157 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 04:24:06 +00:00
Javen O'Neal
b2a24f1a71 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717151 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 02:06:36 +00:00
Javen O'Neal
11650f84a9 add missing ASF License headers for bug 57450 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717149 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 01:05:10 +00:00
Javen O'Neal
226fefe0c9 patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-30 00:22:50 +00:00
Andreas Beeker
c4b5635db3 Add helper method for opening the test files - maybe switched to InputStream if test-data files are changed unexpectedly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717099 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 17:41:58 +00:00
Andreas Beeker
60b17589b7 XSLF: tables can now be removed from sheets/groups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 16:17:29 +00:00
Javen O'Neal
0e04793c2c bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717079 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:31:57 +00:00
Javen O'Neal
0a69246abc add @Override annotations to Sheet classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717078 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:27:34 +00:00
Andreas Beeker
ee0f9b84e1 close resources 
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:26:53 +00:00
Javen O'Neal
d7c3a9b2ca remove debugging print statements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717076 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 15:24:08 +00:00
Javen O'Neal
79e099f5fa Patch from Lyle for bug 52903: HSSFSheet.shiftRows does not shift hyperlink references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717069 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:45:24 +00:00
Javen O'Neal
5ee6c34217 findbugs: add missing equals and hashCode for classes with a compareTo method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717068 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 14:33:28 +00:00
Javen O'Neal
d8223753ae javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717062 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 13:15:03 +00:00
Javen O'Neal
74f0442563 bug 58667: make SX/X/HSSFRow implement Comparable interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717054 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 12:14:45 +00:00
Javen O'Neal
16c1afa0d0 HSSFRow: make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717049 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:58:26 +00:00
Javen O'Neal
f3b88f6755 SXSSFRow: privatize instance variables, make _sheet final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:50:11 +00:00
Javen O'Neal
ff6d93d4f3 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717043 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:48:02 +00:00
Javen O'Neal
a2ac15f1c8 make SXSSFRow._style private, add getRowStyleIndex() in its place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717042 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:47:27 +00:00
Javen O'Neal
f324646c04 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717040 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:44:03 +00:00
Javen O'Neal
db3028defb javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717038 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:39:36 +00:00
Javen O'Neal
7619f0c38f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 11:34:56 +00:00
Javen O'Neal
9d014aa00b bug 52903/58557: add @Override decorators to XSSFHyperlink and HSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717026 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:43:17 +00:00
Javen O'Neal
659662b5f8 bug 58636: make ClientAnchor enum constructor private, make byId Internal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717024 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 02:18:45 +00:00
Andreas Beeker
484297b9cf #46210 - Title placeholder not recognized by Powerpoint 2003 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717020 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 01:23:54 +00:00
Andreas Beeker
0c7e8e0c47 #58663 - Pictures cannot be removed from a slide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717018 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-29 00:51:04 +00:00
Javen O'Neal
8c1517eee4 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716948 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:55:02 +00:00
Javen O'Neal
47dc6340c2 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716947 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-28 11:53:22 +00:00
Javen O'Neal
1f05c1916a make instance variables final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716843 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:35:43 +00:00
Javen O'Neal
2a62f57db5 +FIXME 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716838 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 11:30:18 +00:00
Javen O'Neal
58bffd78a1 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716811 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-27 09:45:53 +00:00
Javen O'Neal
19f4f8af22 javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716365 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:52:25 +00:00
Javen O'Neal
e8b2d5feb4 bug 58651: replace for-looped sheet.getMergedRegion(index) with sheet.getMergedRegions() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716362 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 11:48:17 +00:00
Javen O'Neal
2e795a5f26 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716342 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 09:48:36 +00:00
Javen O'Neal
842171b94a add failing unit test for bug 58648 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716338 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 09:19:03 +00:00
Javen O'Neal
1f874be829 bug 58636: upgrade anchor types from int to AnchorType enum 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716313 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-25 07:16:43 +00:00
Javen O'Neal
026ad8fbdf close workbook at end of example 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716102 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 10:50:57 +00:00
Dominik Stadler
e20da28904 Remove useless double check on null introduced with the previous bugfix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716082 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 09:10:27 +00:00
Javen O'Neal
65cd898a61 bug 58637: replace deprecated getCellComment(row, col) usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716075 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:54:32 +00:00
Javen O'Neal
72aae0f14b bug 58348: use copy constructor design pattern rather than cloneable pattern for CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716074 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:52:45 +00:00
Javen O'Neal
e117107313 javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716073 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:50:53 +00:00
Javen O'Neal
e25f69814c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716060 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:15:42 +00:00
Javen O'Neal
d58342dd9f whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716057 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:13:10 +00:00
Javen O'Neal
735c43ec9d bug 58644: fix HSSFSheet.setZoom(int); update documentation to use non-deprecated method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716053 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 08:04:42 +00:00
Javen O'Neal
e7d29ad533 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716051 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:53:17 +00:00
Javen O'Neal
8eabc4710a bug 58642: deprecate Sheet.setZoom(numerator, denominator) and replace with Sheet.setZoom(scale) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716048 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:43:53 +00:00
Javen O'Neal
891f2d26fc bug 58642: remove deprecated functions in Spreadsheet Sheet interface and implementing classes; add @Override annotations 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716046 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:34:09 +00:00
Javen O'Neal
84fdda5736 rewrite ternary expression as simple Math.min call (yes, the ternary expression as written is equivalent to min, not max, despite the variable being called max. I'll leave that fix up to the original author). 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716044 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 07:05:11 +00:00
Javen O'Neal
dc1acc7ead whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716035 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:57:31 +00:00
Javen O'Neal
2fab3547be whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716034 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 05:51:54 +00:00
Javen O'Neal
cd254f2f1e FindBugs MALICIOUS_CODE, finalize method should have protected access 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716006 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:20:45 +00:00
Javen O'Neal
a736ac1777 FindBug warning: ICAST_IDIV_CAST_TO_DOUBLE: integral division result cast to double 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716005 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:11:57 +00:00
Javen O'Neal
cba32cd1a0 FindBug warning: EQ_SELF_USE_OBJECT: class defines equals(Region) and uses Object.equals(Object) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716004 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:10:47 +00:00
Javen O'Neal
d6ee7f8221 remove duplicate null check of srcStartRow (identified by FindBugs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716003 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 01:08:34 +00:00
Javen O'Neal
6acd60f74d fix normal priority FindBugs warning: DMI_INVOKING_HASHCODE_ON_ARRAY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715998 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-24 00:08:22 +00:00
Javen O'Neal
10eb8f8095 fix javadoc warnings from r1690486 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715996 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:57:40 +00:00
Javen O'Neal
b5494da29c fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715993 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:52:59 +00:00
Javen O'Neal
4dd060e25b fix javadoc warnings from r1715839 bug 58365 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715987 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 23:34:33 +00:00
Javen O'Neal
788047ed08 fixed bad test case in BaseTestSheet.getCellComments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715854 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:45:30 +00:00
Javen O'Neal
7af82a3de2 catch IOException and rethrow as RuntimeException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715850 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:36:57 +00:00
Javen O'Neal
3e10c4f0f6 bug 58365: patch from Hannes Erven: add method to efficiently get all cell comments on a Sheet and return a dictionary with the location of each comment as the key and the comment itself as the value. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715839 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 15:11:28 +00:00
Javen O'Neal
cf41635922 prevent slideshow test-data files shapes.pptx and tables_test.pptx from being modified when running "ant test"; close open resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715815 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 13:55:48 +00:00
Javen O'Neal
a77dd2777b bug 58365: patch from Hannes Erven. Update XSSFSheetXMLHandler.java to use CellAddress instead of CellReference/String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715794 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:47:24 +00:00
Javen O'Neal
831fa71953 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715787 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:32:26 +00:00
Javen O'Neal
090394287b bug 58365: patch from Hannes Erven. Update CommentsTable to use CellAddress instead of String 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715784 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 12:29:45 +00:00
Javen O'Neal
ae9bcd8e82 convert junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715752 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 10:26:06 +00:00
Javen O'Neal
dbba80c3fc bug 58637: contribution from Hannes Erven: add CellAddress class, distinct from CellReference 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715743 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-23 09:30:53 +00:00
Andreas Beeker
4ccadf7315 fix unnecessary cast warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-22 12:30:42 +00:00
Andreas Beeker
47b5cde9c3 #58617 - Add custom safe XmlBeans type loader / rename vendor specific schema packages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715555 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 19:37:26 +00:00
Andreas Beeker
7458fdc277 In preparation for table rendering, added table row heights and column widths to common sl. 
To have better results in rendering switch anchor from java.awt.Rectangle to Rectangle2D.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715540 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-21 15:54:01 +00:00
Andreas Beeker
2bc397b665 #58630 - Signing failed after deletion of first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715438 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-20 22:38:27 +00:00
Andreas Beeker
07dc2b9e08 findbugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715087 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-19 01:44:38 +00:00
Andreas Beeker
e2bc07e9d1 #55955 - Filling an existing ppt table stopped working with 3.9 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714715 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-16 23:56:19 +00:00
Andreas Beeker
a0e06add7a #54210 When saving PPT to PNG, some text is rendered backwards 
#53189 Shapes drawn wrongly when ppt file converted to image
fix line decoration (HSLF)


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714290 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:44:07 +00:00
Andreas Beeker
67b4477a7e Fix typo in EscherProperties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714289 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:42:05 +00:00
Andreas Beeker
c6f11991e7 Add default XmlOptions to XMLBeans parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714288 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-14 02:41:48 +00:00
Uwe Schindler
9ab28f52ab Add security check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713917 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 19:17:18 +00:00
Uwe Schindler
493a157e6a Fix remaining security manager problems. Forbiddenapis now passes. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 19:11:35 +00:00
Uwe Schindler
73a8488838 #58597: Fix tests to not do setAccessible(), add some doPrivileged, too. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 16:57:39 +00:00
Uwe Schindler
da19b14670 #58597: Add more AccessController.doPrivileged. We should fix them later! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713813 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 11:36:44 +00:00
Uwe Schindler
b62cc549fe #58597: Remove setAccessible (more coming soon) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713770 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-11 07:41:54 +00:00
Andreas Beeker
b0b4c020ed Fixed Off-by-one-Error which skipped paragraph styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713546 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 21:37:10 +00:00
Uwe Schindler
ce66e14b5a Wrap more security related reflection in AccessController 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713356 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:32:37 +00:00
Uwe Schindler
8c3cd70589 Use Lucene's unmapping code inside AccessController.doPrivileged() for unmapping mapped byte buffers. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713350 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 09:06:01 +00:00
Andreas Beeker
d1d1298d96 #53192 - Images in ppt file have wrong width when convering ppt to png 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713332 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-09 01:28:31 +00:00
Uwe Schindler
66ce32aee1 Add reason message to @SuppressForbidden 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713324 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:44:24 +00:00
Andreas Beeker
ccce28aae4 sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713319 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:14:50 +00:00
Andreas Beeker
e8d108ff22 Add support for HSLF metro blobs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713318 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:13:28 +00:00
Andreas Beeker
1a32b63fd3 #52297 - Bullets are not aligned properly while converting ppt slide to image 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713316 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 23:11:22 +00:00
Uwe Schindler
0f40ad3125 Make forbiddenapis also check excelant. Use a separate "classpath" for running forbiddenapis; don't misuse javadoc.classpath for that. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713222 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 11:57:58 +00:00
Dominik Stadler
db98ec0bd9 Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713218 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:01:48 +00:00
asf-sync-process
c39e9df3c8 Add some more tests for the checks for files that can cause large memory usage. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:38 +00:00
Dominik Stadler
4cdcc9fc24 Eclipse warnings, typos, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713216 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-08 10:00:24 +00:00
Javen O'Neal
8cff5d7e49 bug 58591: add formula evaluation unit tests inspired by Jason Tomforde's question on user@ 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713080 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-07 04:09:39 +00:00
Nick Burch
a4e891ff8f Whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712985 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 17:03:22 +00:00
Nick Burch
6cc2839b66 Convert to JUnit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712984 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 17:02:18 +00:00
Javen O'Neal
0149810619 remove TestWorkbookEvaluator from junit3 test suite since it was upgraded to junit4 in r1712908 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712921 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 08:51:49 +00:00
Javen O'Neal
c47401d239 remove deprecated ErrorConstants usage in TestWorkbookEvaluator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712910 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:58:35 +00:00
Javen O'Neal
663c64ff44 whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712909 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:45:25 +00:00
Javen O'Neal
42c1296ef6 convert TestWorkbookEvaluator from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712908 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-06 04:43:50 +00:00
Nick Burch
172593de22 Add a XWPFRun equivalent of isHighlighted, and add to the common WP interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712793 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 15:15:36 +00:00
David North
5636e64d68 Patch to bring CTTableStyleInfo into poi-ooxml-schemas by referencing it from a unit test. 
Thanks to Danil Lopatin

https://bz.apache.org/bugzilla/show_bug.cgi?id=58579

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712769 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 13:44:14 +00:00
Andreas Beeker
9b4919cd51 extended forbidden-apis-check to ooxml-tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712693 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-05 00:15:51 +00:00
Nick Burch
ecab3629d8 Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712606 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:25:35 +00:00
Nick Burch
0e7caa5eb1 Bug #55265 - DataFormatter correct support for alternate number grouping characters, eg 1234 + #'##0 = 1'234 not 1,234 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712605 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 18:23:17 +00:00
Javen O'Neal
20ba4851a8 fix for bug 51622: autosize columns with leading whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-04 06:39:57 +00:00
Javen O'Neal
265d198612 bug 58576: rename canComputeColumnWidht to canComputeColumnWidth 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:23:09 +00:00
Javen O'Neal
3b88a60498 supporting change for bug 57450 from Stefan Thurnherr 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712217 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 07:07:11 +00:00
Javen O'Neal
93373073bc set svn:eol-style native 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712214 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 06:06:43 +00:00
Javen O'Neal
3a08acac95 fix typos 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712213 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-03 06:03:52 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues 
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 23:46:57 +00:00
Javen O'Neal
06b3878176 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711961 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:25:31 +00:00
Javen O'Neal
3b94c206e5 fix javadoc link 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711957 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:13:52 +00:00
Javen O'Neal
e1e740bc3c bug 58572: change hyperlink reference to be consistent with TestXSSFHyperlink#testCopyXSSFHyperlink 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711952 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 13:02:44 +00:00
Javen O'Neal
9b8250832e bug 58572: replace Cloneable with copy constructors for spreadsheet Hyperlink class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711951 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 12:57:57 +00:00
Javen O'Neal
54113431b5 bug58348: add test for copying formula with unregistered UDF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711939 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 10:47:19 +00:00
Javen O'Neal
f7fbfcd5ea bug 58348: add hyperlink copying and merging to CellCopyPolicy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711926 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:59:32 +00:00
Javen O'Neal
0eb6ec6717 bug 58572: move getHyperlinkList() and getHyperlink(row, col) from XSSFSheet to Sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711923 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:40:49 +00:00
Javen O'Neal
3c18d6aa7b don't leave behind files when running unit tests. In the future this should be revisited to verify POI isn't writing workbooks that are unopenable/corrupt by applications that read POI's formats (MS Office, OpenOffice, LibreOffice, etc) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711920 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:23:12 +00:00
Javen O'Neal
e88fac62ef whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711911 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:03:12 +00:00
Javen O'Neal
43a5f308d0 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711910 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 09:01:23 +00:00
Javen O'Neal
0e3230f703 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711909 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:55:45 +00:00
Javen O'Neal
3753893f1a whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711906 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 08:34:21 +00:00
Javen O'Neal
87ad007ce4 add ASF License 2.0 header 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711901 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 05:33:31 +00:00
Javen O'Neal
0aeab392e5 remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711886 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:51:31 +00:00
Javen O'Neal
1360cd835d bug 58348: add support for copying rows for XSSFWorkbooks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711885 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:50:33 +00:00
Javen O'Neal
6fc1d21367 javadocs, remove unnecessary SuppressWarnings("resource") decorator 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711883 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:39:15 +00:00
Javen O'Neal
682f5b3ed4 make private shouldRemoveRow static and final, remove unused import 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711881 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:28:34 +00:00
Javen O'Neal
b729d3896c whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711880 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:45 +00:00
Javen O'Neal
40b250bbb3 replace deprecated usage of FormulaShifter.createForRowShift 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711879 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:22:03 +00:00
Javen O'Neal
fa7beda123 remove unneeded SuppressWarnings("resource") decorator from getSheetName 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711878 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:13:35 +00:00
Javen O'Neal
75dd7f9ba3 remove unnecessary @SuppressWarnings(resource) add Override decorator to SXSSFCell.getCellStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711877 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 02:06:43 +00:00
Javen O'Neal
c0aec91a93 delete unnecessary cast 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711876 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 01:51:03 +00:00
Javen O'Neal
af4a96f467 bug 58384: add FormulaShifter.createForRowCopy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711866 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:25:08 +00:00
Andreas Beeker
ae69a781f5 close resources, as SlideShow is now Closeable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711865 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-02 00:05:14 +00:00
Javen O'Neal
44edbec0d5 prepare for bug 58348, make FormulaShifter.ShiftMode enum private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711864 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:54:13 +00:00
Javen O'Neal
adcc71257a whitespace changes: replaced tabs with 4 spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711862 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 23:30:48 +00:00
asf-sync-process
8b6cef3b79 #45908 - RichTextRun.setBullet(false) doesn't work, bullets still here 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711858 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 22:52:49 +00:00
asf-sync-process
0ae2928035 #45088 - POI-HSLF changeTextInRichTextRun corrupts presentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711845 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 19:37:28 +00:00
Andreas Beeker
5338f9dce1 Fix locale error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711726 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 08:43:57 +00:00
Andreas Beeker
fa40f8417c findbugs fixes 
close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711712 13f79535-47bb-0310-9956-ffa450edef68
 2015-11-01 03:23:16 +00:00
Andreas Beeker
72834dfffa FindBugs fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711708 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:13:35 +00:00
Andreas Beeker
8ebc22a84e Add method for setting bullet styles 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711707 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:43 +00:00
Andreas Beeker
6485c11305 Make SlideShow closeable as of HSLF references a NPOIFSFileSystem and hasn't closed it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711706 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:10:17 +00:00
Andreas Beeker
02ff2b913f #45124 - inserting text or images wipes out boldness and makes everything italic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711705 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:08:52 +00:00
Andreas Beeker
8a6a5578e6 #45124 - inserting text or images wipes out boldness and makes everything italic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711704 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 23:05:09 +00:00
Javen O'Neal
401d3eec77 replace deprecated usage of AreaReference as a result of bug 56328 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711685 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 20:53:12 +00:00
Javen O'Neal
d0694f4fc9 whitespace change 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711680 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 19:56:22 +00:00
Javen O'Neal
f98fda03c1 add javadoc info for intersects 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711613 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 12:21:51 +00:00
Javen O'Neal
1aa81eb463 bug58452: set cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711605 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:57:39 +00:00
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:39:01 +00:00
Javen O'Neal
07cf6736ae improve error message if CellRangeAddress intersection assertion fails 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711597 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:20:15 +00:00
Javen O'Neal
5f23aa95f7 bug 58442: in-place reorganize an AreaPtg as upper-left and lower-right 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711592 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 11:10:28 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 10:22:19 +00:00
Javen O'Neal
b40a0b01bb replace deprecated usage of o.a.p.ss.util.Region with o.a.p.ss.util.CellRangeAddress; add documentation to tests that exist strictly to test deprecated methods, and move SuppressWarnings-deprecation down to just those functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711581 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-31 09:29:32 +00:00
Dominik Stadler
50baa731d3 Add a limit of the max number of characters that can be extracted to avoid sending applications out of memory with very large documents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711520 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-30 17:26:37 +00:00
Andreas Beeker
b9cf1bdc38 #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711381 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 23:22:54 +00:00
Andreas Beeker
438d4bd03e #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711380 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 23:20:35 +00:00
Dominik Stadler
ba7f5f3037 Ensure that no password was set by other tests, this breaks sometimes when the Sonar/Maven build runs all tests in one VM 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711199 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:30:11 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 09:28:38 +00:00
Javen O'Neal
1396738460 bug 58557: fix from Alessandro Guarascio, shift hyperlinks when shifting rows on an XSSFSheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711185 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 06:53:55 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText() 
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-29 01:05:27 +00:00
Nick Burch
632228a34e #58558 SXSSFCell.setCellValue((RichTextString)null) fixed to work like XSSF and HSSF, with common unit tests to verify this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711082 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-28 17:42:56 +00:00
Javen O'Neal
c65de59909 bug 26862: add test case for HSSFWorkbook.cloneSheet copies charts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710730 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-27 07:43:23 +00:00
Javen O'Neal
bcb09a3798 convert scratchpad TestHSSFChart from junit3 to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710729 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-27 07:41:09 +00:00
Dominik Stadler
856bbf97f4 Fix Sonar-Maven build, correctly determine path to test-file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710694 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:38 +00:00
Dominik Stadler
f1f08de7fb Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 20:48:32 +00:00
David North
b0551e322e Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58549 
Thanks to Damian Cugley for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710552 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 10:32:30 +00:00
Dominik Stadler
c7ebebcbb1 Bug 56957: Avoid error if Workbook with empty SharedStringTable is written 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710521 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-26 07:54:06 +00:00
Nick Burch
8cd7f1f736 58536 DataFormatter and CellFormat non-localised support for localised currency formats like [$£-809] 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710484 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 21:20:44 +00:00
Nick Burch
90db0bf451 Fix javadoc warning - @see with a URL needs wrapping in an a-href tag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710460 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:19:35 +00:00
Nick Burch
dc947416d4 Mention about Locale definitions in Excel cell data format strings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-25 16:13:16 +00:00
Nick Burch
1b019d3c76 #58532 Enable more of the padding cell format tests, but a few remain to be fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710407 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:57:49 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which 
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 23:34:47 +00:00
Nick Burch
e86a116d0a Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710395 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 22:12:06 +00:00
asf-sync-process
41419d44eb Test to check that #58532 formats are seen as valid 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710394 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-24 22:09:11 +00:00
Dominik Stadler
dd48f58f95 Bug 58085: removing sheet breaks other existing sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710193 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 12:11:40 +00:00
Javen O'Neal
c22fdbbc2b bug 58441: define equals method for CellRangeAddressBase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710172 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 11:17:06 +00:00
Javen O'Neal
ab729cfd0e bug 58402: make AreaReference's private SpreadsheetVersion _version variable final 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710163 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 09:54:32 +00:00
Javen O'Neal
522b6d4a15 bug 58439: rename private FormulaShifter.adjustPtgDueToShiftMove to adjustPtgDueToSheetMove 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710147 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:56:49 +00:00
Javen O'Neal
538b2d1377 bug 33174: Use common unit test for testNoMergedRegionsIsEmptyList 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710140 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-23 08:38:14 +00:00
Dominik Stadler
27d4814b80 Set newer curvesapi-version in .classpath as well and update some third-party libs for the password-protection-code to the latest versions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710032 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-22 15:21:25 +00:00
Dustin Spicuzza
fe771aa808 XDGF: fix the fix 
- Use Collections.emptySet() for an iterator instead
- Bump curvesapi to 1.03, which is compiled for JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709463 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 18:36:45 +00:00
Dustin Spicuzza
9c23e12b8e XDGF: fix jdk < 1.8 compat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709427 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 14:55:30 +00:00
Dustin Spicuzza
f540622a05 XDGF: fix jenkins build errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709363 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:55:06 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:26:57 +00:00
Dustin Spicuzza
879ca64994 Add some limited XDGF documentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709357 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 06:08:58 +00:00
Dustin Spicuzza
e3365dfaeb poi-import: fix build dependencies 
- Compilation + tests work now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709356 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:42 +00:00
Dustin Spicuzza
d70b8e8b88 poi-visio import: reformat code to fit project standards, remove JRE 7isms 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709355 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:59:37 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-19 05:52:35 +00:00
Dominik Stadler
3a8f40db7c Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway 
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 14:40:36 +00:00
Dominik Stadler
43ab1cd35a Use the default XmlOptions for all the invocations of the XmlBeans XML parsing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709128 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-17 08:45:25 +00:00
David North
bb18031ac7 Remove unnecessary warning suppressions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708921 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-16 09:00:43 +00:00
Dominik Stadler
e9d0e9cc12 Update test to not depend on an existing build-directory 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708682 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 19:27:20 +00:00
Dominik Stadler
392591e222 Reenable test on Windows which was disabled previously but should now work after a workaround was put in place via bug 58480. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708613 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 15:00:19 +00:00
Dominik Stadler
a00240f212 Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:53:41 +00:00
Dominik Stadler
d15ef65b8f Bug 58341: fix some edge cases in the DStar function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708606 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-14 14:31:04 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor 
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-12 20:43:42 +00:00
Dominik Stadler
7fbf591db5 Retry which measures duration a few times to see if that reduces the number of failures caused by this test sometimes when CI machines are loaded. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707488 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-08 11:08:41 +00:00
Nick Burch
4ae623c699 Update the XSSF EventModel example, to show how to do it better using the SheetContentsHandler helper that does most of the work for you 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707326 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-07 15:19:04 +00:00
Dustin Spicuzza
bf68d5f290 Bug 58048: Add visio schemas to the OOXML jar 
- Bumped OOXML jar version also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707177 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-07 02:41:30 +00:00
Andreas Beeker
cab7f9c2e0 fix forbidden apis issue and make non-static as decimalformat is not thread-safe 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707166 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 22:52:05 +00:00
David North
efee7bf83f Format numbers more like Excel does 
Thanks to Chris Boyle for the patch

https://bz.apache.org/bugzilla/show_bug.cgi?id=58471

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706971 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 09:56:26 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-06 00:04:12 +00:00
David North
2dc93d4411 Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58466 
ColumnHelper now preserves information on multiple changes to the same group, hopefully while preserving the faster implementation intended by the original patch.

NB changes to TestXSSFSheet: the behaviour of column group collapsing/expanding is now closer to what Excel does than before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706789 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 10:31:33 +00:00
Dominik Stadler
cc1caaf658 As discussed at ApacheCon: Try to automatically find test-data in unit tests, this makes it easier to get going in Eclipse or other IDEs. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706752 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 06:45:20 +00:00
Dominik Stadler
4b487fcc10 Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706750 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 06:41:48 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:28:54 +00:00
Andreas Beeker
0d29f8b2ec obsoleted Codec classes by HexDump 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706741 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:27:47 +00:00
Andreas Beeker
8aec6ba738 removed obsolete classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706740 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:45 +00:00
Andreas Beeker
d9c0fb9ce5 Fixed a problem with save-and-load of conditional formattings (CFHeader12 wasn't added to conditional formattings, rgb value wasn't saved in extended color) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706739 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-05 00:26:19 +00:00
Andreas Beeker
98e93217fe sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-04 00:35:30 +00:00
Dominik Stadler
030c29cfed Bug 55032: Fix handling missing option values in financial functions PV, FV, NPER and PMT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706254 13f79535-47bb-0310-9956-ffa450edef68
 2015-10-01 14:05:28 +00:00
Andreas Beeker
2de9d527b4 sonar fixes 
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-30 23:06:39 +00:00
Dominik Stadler
9deb59f263 Verify that bug 51998 is actually fixed since some time already. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705855 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 13:09:47 +00:00
Dominik Stadler
99d33a0330 Bug 50319: Make row groups which include row 0 work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705844 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 12:26:08 +00:00
Dominik Stadler
b261c978a8 Tried to reproduce bug 48403 but couldn't, still adding the related unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705830 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 10:14:40 +00:00
Andreas Beeker
ffd1f4333e sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 08:31:15 +00:00
Dominik Stadler
c56977e6d2 Add test which shows that bug 46515 is fixed since some time already. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705807 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 07:51:48 +00:00
Dominik Stadler
72ae82f7dc Verify that bug 45541 can be resolved, add some more checks in XSLFFileHandler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705804 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-29 06:08:08 +00:00
Andreas Beeker
1b2b506edb Sonar fixes - add cloneable interface to classes with clone() 
Sonar fixes - remove pubic/static/final modifier from interfaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705789 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 23:16:58 +00:00
Andreas Beeker
6f7f16853e Removed HDF API 
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-27 22:14:25 +00:00
Andreas Beeker
bde96d1a9a fixed some wrong nightly assumptions ... (Note to myself, don't rely on ant automatic file change detection, but run ant clean before ...) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704999 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-24 05:51:38 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes 
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 23:22:46 +00:00
David North
c93ded0f36 Make XSSF and HSSF consistent in getMergedRegions - return empty list if there are none, rather than an exception. Tests for this. 
https://bz.apache.org/bugzilla/show_bug.cgi?id=58350

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704839 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-23 12:53:13 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-22 19:50:37 +00:00
Nick Burch
c556e08a52 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704393 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 19:18:40 +00:00
Andreas Beeker
6488170c6d removed common sl path 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704207 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:16:36 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio 
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-21 00:09:45 +00:00
Dominik Stadler
d61ea07e26 Bug 58333: Apply patch to verify behavior on row-index before and after the limits set by the specification 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704186 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:16:17 +00:00
Dominik Stadler
f2cd7ed8f5 Bug 58332: Adjust implementation of dev-util 'MemoryUsage' to print out information if limits are reached instead of OOM 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704182 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 20:05:36 +00:00
Andreas Beeker
f3004e6185 close resources in junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704124 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 12:02:40 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF) 
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
 2015-09-20 02:25:35 +00:00