Commit Graph

7666 Commits

Author SHA1 Message Date
Javen O'Neal
57e9abb8d1 parameterize raw generics
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:40:32 +00:00
Javen O'Neal
0ec8b3a88e bug 56454: keep XSSFRowShifter#shiftMerged in sync with HSSFSheet: when shifting rows, shift merged regions (even when the merged region does not include column 0)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749248 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 02:02:08 +00:00
Javen O'Neal
55cb9381de bug 56454: deprecate shiftMerged with unused parameter, move loop-invariant out of for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749247 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:49:46 +00:00
Javen O'Neal
2804197bdb bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:44:44 +00:00
Javen O'Neal
015cf4c86f object-oriented methods are preferred over utility classes for discoverability
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749245 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:25:23 +00:00
Javen O'Neal
8dc7ee659d bug 59729: update CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749243 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:55:51 +00:00
Javen O'Neal
970626a88e whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749241 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:28:19 +00:00
Javen O'Neal
8c6c7783d6 mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39 bug 56454: add CellRangeAddress#containsRow and containsColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:16:41 +00:00
Andreas Beeker
3a4754de98 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749238 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:08:11 +00:00
Javen O'Neal
e08786d49e convert TestCellRangeAddress from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749237 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:00:41 +00:00
Javen O'Neal
778fa8aa3d bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749226 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 23:02:43 +00:00
Javen O'Neal
ebd55552bf bug 59728: add disabled unit test: should not be able to add an array formula to merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:51:01 +00:00
Andreas Beeker
3a72eea5c5 Regression fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749224 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:43:24 +00:00
Javen O'Neal
b9e9b0d41d bug 56958: slightly improve performance when checking array formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:24:17 +00:00
Nick Burch
7da9b2cd67 #59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:13:41 +00:00
Nick Burch
b7b990f56f #59724 Provide Closeable on all OLE2-based POIDocument types
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749213 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:12:55 +00:00
Javen O'Neal
492aac4e73 bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9 bug 59645: add Page Setup Print row and column headings support for Common SS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00
Javen O'Neal
8240a8ab5d update javadoc for clarification about non-literal lists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:23:57 +00:00
Javen O'Neal
3eb3df8d35 use fully qualified name for Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749132 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:16:23 +00:00
Javen O'Neal
3d15bb8f65 add unit test for bug 59719
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749131 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:10:50 +00:00
Javen O'Neal
e930c44e2d bug 59719: parse static list text properly; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749129 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 04:43:53 +00:00
Andreas Beeker
bec4c45c59 findbugs fixes - ME_MUTABLE_ENUM_FIELD
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 01:06:55 +00:00
Andreas Beeker
e1241ed975 #59702 - Setting background color in slide master
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749108 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 23:48:00 +00:00
Javen O'Neal
d8d821b1f2 add unit test for HSSFWorkbook.getSelectedTabs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 02:37:24 +00:00
Javen O'Neal
acac716a64 bug 59718: deprecate get/setBoldweight. Use get/setBold
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:21:08 +00:00
Javen O'Neal
59d1dc095b bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:06:53 +00:00
Javen O'Neal
21e8ce5979 bug 59432: move loop invariants outside the loop to marginally improve code execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748832 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 11:06:58 +00:00
Javen O'Neal
be7fd6ffb6 FunctionEval is a utility class. It should not have a public default constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748830 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:47:13 +00:00
Javen O'Neal
26d3072b1e bug 56958: validate array formulas wasn't correctly checking for overlap with a merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748829 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:22:09 +00:00
Javen O'Neal
645fbd08fc bug 59279: add unit test for CellComment.equals and CellComment.hashCode
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748827 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:17:47 +00:00
Javen O'Neal
19a0cc12fa bug 59279: add Comment.equals and hashCode methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:56:10 +00:00
Javen O'Neal
720e866a4c add unit test for Cell.getCellComment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748813 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:54:08 +00:00
Javen O'Neal
6ea5e99ce4 move loop invariant outside of loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748809 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 07:59:01 +00:00
Javen O'Neal
4e60db8b4e findbugs: remove uncalled private methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748804 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 07:32:38 +00:00
Javen O'Neal
8eb863686c bug 58575: add 'svn:auto-props = *.java = svn:eol-style=native'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748802 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 07:21:48 +00:00
Javen O'Neal
7a66ac346f bug 59170: add version when deprecated
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748793 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:35:44 +00:00
Javen O'Neal
7b14a48436 bug 59170: deprecate o.a.p.hssf.model.PictureShape
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748792 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:31:27 +00:00
Javen O'Neal
07767097bb bug 59170: remove deprecated constructors in o.a.p.hwpf.usermodel.Paragraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748791 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:16:40 +00:00
Javen O'Neal
890afdc0f4 bug 59170: remove deprecated o.a.p.hwpf.usermodel.Pictures methods; add version when deprecated to javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748790 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:12:05 +00:00
Javen O'Neal
c7c11821fe bug 59170: remove or privatize deprecated methods in o.a.p.hwpf.usermodel.Range from POI 3.8 beta 4/5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748789 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:48:46 +00:00
Javen O'Neal
bb43d1eb3c remove deprecated o.a.p.hwpf.usermodel.Shapes (replaced by OfficeDrawing in POI 3.8 beta 4)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748788 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:34:00 +00:00
Javen O'Neal
e28a8789f3 bug 59170: remove deprecated o.a.p.hwpf.usermodel.ListEntry constructor and method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748787 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:24:38 +00:00
Javen O'Neal
06b4103cb0 bug 59170: remove deprecated WordExtractor constructor; add version when deprecated to HWPF HeaderStories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748786 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:19:36 +00:00
Javen O'Neal
3369507cac bug 59170: remove deprecated o.a.p.hwpf.usermodel.CharacterRun#cloneProperties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748785 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:09:05 +00:00
Javen O'Neal
5fe6c32f85 bug 59170: add version when deprecated
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748784 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 01:00:38 +00:00
Javen O'Neal
ae12cfcd57 bug 59170: remove deprecated HSLF and HWPF methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748783 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 00:55:22 +00:00
Javen O'Neal
45ec02487c bug 59170: remove deprecated o.a.p.hdgf.HDGFDiagram constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748782 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 00:36:19 +00:00