moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
5,954 Commits 29 Branches 84 Tags 722 MiB
7ee9ce8388
Commit Graph

4833 Commits

Author SHA1 Message Date
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-25 21:32:03 +00:00
Dominik Stadler
2e283f2ebf Apply patch for bug 55864 - XSSFImportFromXML.importFromXML() does not support optional elements 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633404 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-21 15:56:45 +00:00
Dominik Stadler
3c37d8f3cd Apply patch to fix bug 56835: Unreadable content when adding multiple comments to cell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633397 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-21 15:16:14 +00:00
Nick Burch
f9754de0cd Add disabled unit tests for bug #46670 - failing on both HSSF and XSSF, but for different reasons 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633257 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 23:22:02 +00:00
Nick Burch
89ad69234c Unit tests which reference XSSF must be on the ooxml part of the tree 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633256 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 23:21:01 +00:00
Nick Burch
2bb53e200b Escape non-ASCII characters in the unit test, so it builds properly everywhere 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633255 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 23:19:30 +00:00
Andreas Beeker
11cfec8513 xml dsign - javadoc fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633241 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 22:18:42 +00:00
Dominik Stadler
5706aab18c Bug 57010: Add implementation of function PROPER 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633215 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 19:57:11 +00:00
Dominik Stadler
7664c7efa7 * Make more tests work in OOXMLLite compilation by adding xml security classpath and ensuring proper cleanup in some Extractor tests 
* Remove downloading xerces library here, we now do this in the special Jenkins job and thus can get rid of it here

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633166 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 14:26:53 +00:00
Dominik Stadler
02a4dc5462 * Also adjust build.xml for newer required Ant 1.8.0 
* Pass "additionaljar" to junit calls to enable us to exclude tests which we know are failing (newer XML Security stuff)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633156 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 13:54:41 +00:00
Dominik Stadler
f0d47ab7cb When using v4 Junit style, we need to set @Test to make the test-methods actually execute 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633154 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 13:49:51 +00:00
Andreas Beeker
14f3200486 Removed some custom classloading code, which doesn't make sense anymore 
Tested a few other timestamp providers
limited the use of the additional libraries to xml dsign classes while running the junit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632858 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 23:19:49 +00:00
Nick Burch
802bc7cd8a Finish unit tests for stackoverflow #26437323 - POI works fine already! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632842 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 20:53:50 +00:00
Nick Burch
db0e58b4b6 Start on unit tests for the problem reported in stackoverflow post 26437323 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632841 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 20:37:56 +00:00
Nick Burch
14fb9a55ee Move non-HSSF specific bug tests into BaseTestBugzillaIssues from HSSF TestBugs, so they can be tested automatically on XSSF too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632837 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 20:10:31 +00:00
Nick Burch
508f36d702 SheetUtil helper for finding the main cell of a merged region, if in one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632833 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 19:58:05 +00:00
Dominik Stadler
a604506683 Seems we have slow connection on the Apache Jenkins instance. Thus allow one specific test to fail with a specific ConnectException as we see this happening sometimes in Jenkins but should not fail the unit test suite of POI because of such infrastructure problems 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632566 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-17 13:04:53 +00:00
Andreas Beeker
5692f061a9 Bug 56836 - XML signature support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632447 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-16 23:30:42 +00:00
Nick Burch
8137193852 Add a note on how this is not the right way to make a string of your cell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632438 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-16 21:41:11 +00:00
Andreas Beeker
daa7d17531 Bug 57080 - IndexOutOfBoundsException in poi decryptor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631600 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-13 23:42:33 +00:00
Dominik Stadler
5c40484b1f Enhance test and coverge for class TempFile 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631250 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-12 20:07:24 +00:00
Andreas Beeker
a16db327fd xml signature: mainly javadocs - a few reorgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631003 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-10 22:48:21 +00:00
Nick Burch
0bd50defba Add a disabled unit test for bug #56880 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1630543 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-09 17:58:47 +00:00
Dominik Stadler
2d04f98cd1 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629656 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:43:37 +00:00
Dominik Stadler
8dde4b0ae4 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:39:35 +00:00
Dominik Stadler
d254ec8ec1 Print out current version of java before building to allow to see in build output if we use a supported Java VM version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:20:12 +00:00
Andreas Beeker
30d72983d1 another round of refactoring, limited exception declarations, more javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629332 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-03 22:24:09 +00:00
Andreas Beeker
ab84e448ca removed obsolete classes and added a few javadocs elements and example calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629095 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-02 22:47:35 +00:00
Andreas Beeker
3438e7f4f6 xml signature - small javadoc fixes, removed obsolete parameter from SignatureFacet interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1628575 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-30 23:42:21 +00:00
Andreas Beeker
1ed069daf7 Fixed complete-build errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628338 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-29 23:39:45 +00:00
Andreas Beeker
da4201c2cd more tests, some refactoring 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 22:30:02 +00:00
Andreas Beeker
4fb7957b52 forgot to rename get/setter 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628031 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 00:35:00 +00:00
Andreas Beeker
ab5a1dd5d3 Moved prefix logic in one place 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628029 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 00:30:05 +00:00
Andreas Beeker
013bd1469c configure namespaces via signatureconfig 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627985 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-27 17:49:09 +00:00
Andreas Beeker
0eb917b223 clean ups 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627682 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-25 23:59:36 +00:00
Andreas Beeker
123784df81 more flexible signer verification through Iterable-Interface 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1627434 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-24 22:54:21 +00:00
Andreas Beeker
ff38e12652 centralized configs 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1626646 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-21 22:48:20 +00:00
Andreas Beeker
6639a1938e reorganization, xmlsignatureservice is now in signatureinfo 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1626107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-18 23:47:41 +00:00
Andreas Beeker
c9757d974f Switched to config object 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625850 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 23:12:16 +00:00
Andreas Beeker
b410e72196 merge with trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 21:12:36 +00:00
Andreas Beeker
11e384f0ec timestamping fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620990 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-27 22:58:03 +00:00
Andreas Beeker
687194fd91 removed HorribleProxy 
added current version of BouncyCastle and xmlsec (using xmlsec instead of jdk internal classes, because of interoperabiltiy with e.g. IBM JDK)
heaps of changes because of above

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620230 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-24 23:06:05 +00:00
Andreas Beeker
d0cc2e4267 removed HorribleProxy 
added current version of BouncyCastle and xmlsec (using xmlsec instead of jdk internal classes, because of interoperabiltiy with e.g. IBM JDK)
heaps of changes because of above

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1620229 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-24 23:05:26 +00:00
Andreas Beeker
8962fa8310 starting tsp tests / removed mockito stuff again 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618515 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-17 19:53:34 +00:00
Andreas Beeker
58b11677cb - Updated to BC 1.51 
- Download BC/test-libs in build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618403 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-16 19:21:31 +00:00
Andreas Beeker
ec7fde8fcb replace xmlbeans.factory.parse with selectPath calls 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618292 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 23:10:07 +00:00
Andreas Beeker
1b2f321ae9 migrated enveloped document test (1 of 2) 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618288 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 22:20:30 +00:00
Andreas Beeker
777fd47d71 some changes because of test errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618254 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 18:19:28 +00:00
Andreas Beeker
c378d75e51 sync merge to trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617624 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 23:33:07 +00:00
Uwe Schindler
cd80405811 Add some extra safety test to check that external entities are not loaded by xmlbeans 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617453 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 11:33:02 +00:00
Uwe Schindler
2f5bcfd162 Fix bug #56814 - Switch from dom4j to JAXP 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1617428 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-12 07:19:51 +00:00
Andreas Beeker
6bbe12277f Tests/fixes for hash > sha1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617180 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 23:34:13 +00:00
Andreas Beeker
7d445b6693 download xades files and remove from them resources 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617153 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 20:37:44 +00:00
Andreas Beeker
63f8c1dcf0 Xml signature support - version 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617141 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 18:25:10 +00:00
Nick Burch
89fd75ff0a Fix bug #56812 - In XSLF provide a way to get the URI of externally linked pictures 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615812 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 22:00:47 +00:00
Nick Burch
e0f22fd7cf Add a disabled unit test for bug #56812, based on code and file from Geoff Wright 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615803 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 21:34:51 +00:00
Nick Burch
b350d5c5ed Before parsing an OOXML document, reset the xmlbeans sax parser to avoid the risk of getting one in an error state (due to XMLBEANS-512). Should be a minimal extra overhead pending a proper fix. Allows us to finish enabling the unit tests for #54764 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615781 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 20:42:41 +00:00
Nick Burch
07771c3d8c Add another test file for #54764, and a test that uses it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615731 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 19:18:20 +00:00
Nick Burch
236c3c52a9 Apply suggestions from Uwe Schindler for more secure xml defaults for #54764 and #56164, for xml parsers which support them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615720 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-04 18:17:26 +00:00
Andreas Beeker
3cd1cd6e70 Another test for NPOIFS in-place writing support - probably the deletion of an entry causes the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615273 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-02 00:51:56 +00:00
Nick Burch
0e44d8da73 Fix bug #56800 - Provide a helpful exception, XLSBUnsupportedException, if XSSFWorkbook is passed a .xlsb file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615118 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-01 14:33:17 +00:00
Nick Burch
afa2322295 Fix bug #55196 - Correct XWPF createTOC handling of short style names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614930 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 16:11:35 +00:00
Nick Burch
2ee05730bd Fix bug #55050 - If the start+end row and cell are the same on an AreaPtg, avoid inverting the relative flag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614928 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 16:06:43 +00:00
Nick Burch
da61e7dd32 Fix bug 54725 - HWPF where no parent style CHP exists, use an empty 
set when processing the style to avoid a NPE

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614926 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 15:41:58 +00:00
Nick Burch
4bfe3c6784 Fix bug #56502 - When shifting XSSF rows with formula cells, if the formula can't be parsed, log + leave it unchanged rather than failing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614916 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 15:07:27 +00:00
Nick Burch
5f5d8f496e Fix bug #56527 - Avoid NPE from XSSFHyperLink when setting the cell 
it references on a new link

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614914 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 14:55:04 +00:00
Nick Burch
de0d2a0935 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614886 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:37:33 +00:00
Nick Burch
65e23c7ea9 Fix bug #53984 - Support the ColInfoRecord coming after the cells, rather than before as is normal, and also handle things so that if an unsupported BofRecord is found for a sheet, warn and skip rather than breaking 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614884 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:31:01 +00:00
Nick Burch
f16296111b Correct logic for the start-of-sheet missing rows, for event user model, and add tests for this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614789 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 23:06:46 +00:00
Nick Burch
bf860eccf1 Generics fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614788 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 23:05:58 +00:00
Nick Burch
bdb9bbccc1 Start on details tests for bug #53433 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614786 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 22:43:31 +00:00
Nick Burch
78c4a8168a Unit test to show that bug #53494 has already been fixed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614741 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 19:02:09 +00:00
Nick Burch
64187356aa #56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 18:08:28 +00:00
Nick Burch
d03c10f257 XSSF external workbook lookup support for in-line file:/// based book "numbers" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614724 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 17:53:54 +00:00
Nick Burch
c62aa2d74b Convert the test to using interfaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614715 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 16:56:31 +00:00
Nick Burch
7844d4dafb Updated patch from Marc from #55927 - handle date formulas too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614696 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 16:10:56 +00:00
Nick Burch
27dd2eafe1 Add row label getter for Pivot Tables, and use this in unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614691 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:44:05 +00:00
Nick Burch
797f3368d6 Patch from Sofia Larsson and Martin Andersson from bug #56020 - XSSF support for creating Pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614684 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:27:09 +00:00
Nick Burch
f0dc1291ad Change XSSFSheetXMLHandler.SheetContentsHandler to require fewer backwards incompatible changes for #56023 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614576 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 07:41:01 +00:00
Dominik Stadler
a9f946ef70 Add simple unit test to verify that Bug 42016 was fixed already by some other fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614135 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-28 19:10:54 +00:00
Dominik Stadler
379214975e Add unit test for bug 37625 which verifies that this file can now be loaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613837 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-27 19:57:57 +00:00
Dominik Stadler
51649dbdfa Add/Fix some Javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613826 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-27 18:32:24 +00:00
Nick Burch
a4e73e3dc8 Unit test to show that bug #52111 (intersect formulas) was already solved 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613737 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-26 22:39:16 +00:00
Nick Burch
5d9f8945c9 HSSF and XSSF Multi-Sheet formula reference tests from Radoslav from bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613654 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-26 15:20:06 +00:00
Nick Burch
59861b7836 Complete evaluation support for multi-sheet references for bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:42:31 +00:00
Nick Burch
2438213bd8 Begin required interface + base-class support for multi-sheet area references for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613460 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:15:47 +00:00
Nick Burch
97c4bbc9b8 Allow XSSF to evaluate multi-sheet references too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:55:49 +00:00
Nick Burch
82b36d3268 Split the reference and area tests for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613454 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:49:35 +00:00
Nick Burch
3872e620a7 Update the RefEval method signature to cope with multi-sheet references, and have appropriate functions take advantage of this. For bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613453 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:46:05 +00:00
Nick Burch
d97867e5be Start preparing LazyAreaEval and LazyRefEval to handle sheet ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613443 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:50:44 +00:00
Nick Burch
3e2e01c149 Update the XSSF getExternalSheet method signature, to start to prepare for sheet ranges 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613439 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:23:21 +00:00
Nick Burch
4c8f3ab160 More tests for #55906, and provide a new eval that lets you get at evals for many sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:15:56 +00:00
Nick Burch
96386e2e0a Areas can have multi-sheet references too, so add FormulaParser support to these as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 13:59:07 +00:00
Nick Burch
8f4fac46ee Update Ref3DPxg to support multi-sheet ranges too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613376 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:22:21 +00:00
Nick Burch
0dde805ec7 Refactor to reduce clutter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613374 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:10:52 +00:00
Nick Burch
29e5928c42 More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:05:57 +00:00
Nick Burch
1161077a6b More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 22:44:51 +00:00
Nick Burch
e27a6e5466 More internal method signature updates, for HSSF external sheets being possible ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613307 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:35:47 +00:00
Nick Burch
7f6ba5513c Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:25:45 +00:00
Nick Burch
1fc5397a59 #55906 Extern Sheet References can have a last as well as a first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613302 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:10:13 +00:00
Nick Burch
899ff0569b Disabled unit tests for multi-sheet references, see bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613282 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 20:48:29 +00:00
Nick Burch
14d5fa912f Patch from Shaun Kalley from bug #56023 - Allow XSSF event model to find + return comments, and use this for the event based .xlsx text extractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613266 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 20:13:54 +00:00
Nick Burch
a41a4fd118 Patch from thaichat04 from bug #56194 - HPSF thumbnail format tags are int not unit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613256 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 19:34:19 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 18:58:27 +00:00
Nick Burch
9fcdec5719 To avoid problems on strange platforms, tell xmlbeans to use UTF-8 for strings by default, for bug #56683 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613193 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 17:14:00 +00:00
Nick Burch
50af15f97f XSSF table example, from Sofia Larsson from bug #55562 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613191 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 17:09:23 +00:00
Nick Burch
bb91152a12 For places where an ordered collection is created and used within the context of a single thread, and there are no thread safety concerns, use ArrayList not Vector. See bug #54838 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613186 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:41:43 +00:00
Nick Burch
70b21ffe56 Fix javadoc warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613176 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:26:34 +00:00
Nick Burch
0c8112b84a Correct HSSFOptimiser logic for the case where the to-keep style wasn't previously in use. Fixes #54443 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613175 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:25:58 +00:00
Nick Burch
f91eee5846 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613174 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:22:28 +00:00
Nick Burch
fec4eb7a12 When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:56:23 +00:00
Nick Burch
f06915e95d Don't fetch the name, convert to a ptg, then convert back again, instead simply return the name directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613153 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:37:09 +00:00
Nick Burch
bf6f54d836 Get further with the XSSF formula reference evaluation testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612926 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 19:09:45 +00:00
Nick Burch
4418c0cef9 Further XSSF external name evaluation lookup support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612925 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 19:09:25 +00:00
Dominik Stadler
a5d32d87d4 Fix test to make it work on different date as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612786 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-23 07:55:48 +00:00
Dominik Stadler
b6dd3bca34 Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 12:31:56 +00:00
Dominik Stadler
3f9c701688 Fix formatting of trailing comma in HexDumps, cover class fully with tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612496 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 07:47:14 +00:00
Nick Burch
56b7f9f365 Use the link table when looking up external xssf names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612347 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 16:52:19 +00:00
Nick Burch
12e87a1900 Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 12:23:54 +00:00
Nick Burch
79f3f4bb06 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612219 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:45:44 +00:00
Nick Burch
3db4f0b82c Allow creating a CollaboratingWorkbooksEnvironment from a Map too, not only a pair of arrays 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612218 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:44:21 +00:00
Nick Burch
d43121661c Correct non-sheet-based NameXPxg formula rendering, and add tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 07:35:09 +00:00
Nick Burch
1179ca9c26 More unit tests for #56737 and #56752 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612157 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 19:24:42 +00:00
Nick Burch
146c39e070 Comments updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612156 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 19:13:45 +00:00
Nick Burch
05dc1ec70c Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:56:35 +00:00
Nick Burch
a550397ac2 XSSF Pxgs must escape sheet names where required when generating the formula string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:53:27 +00:00
Nick Burch
44a6aef699 Common interface across the XSSF Ptg / Pxg classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612149 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:48:48 +00:00
Nick Burch
4345b06cab Rename missing from previous commit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612140 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:14:47 +00:00
Nick Burch
42cd819573 Update the formula evaluator to support XSSF style external named ranges too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 17:51:51 +00:00
Nick Burch
0b1dee9913 Better reporting on why a test is failing, and partial NameXPxg eval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:27:28 +00:00
Nick Burch
81869b869d Complete the XSSF Formula Parser tests for #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611963 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:00:21 +00:00
Nick Burch
ed7140b3d8 Move towards supporting same workbook named ranges in external style for xssf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:51:23 +00:00
Nick Burch
58096a6862 Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:30:31 +00:00
Nick Burch
86ca81d22f Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:42:07 +00:00
Nick Burch
84b50e845e Fix inconsistent indents/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611949 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:23:13 +00:00
Nick Burch
2cd4290460 Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:19:06 +00:00
Nick Burch
0986f32d46 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:11:54 +00:00
Nick Burch
c392b4fa72 The Event User Model fake-workbook for formula evaluations needs to know about the sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:10:47 +00:00
Nick Burch
fbcf64087d Fix Generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611944 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:00:09 +00:00
Nick Burch
7c382f9f37 The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 12:49:41 +00:00
Nick Burch
1ed2a18323 There can be more than one linked ExternalLinks table for a workbook #56744 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611890 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 11:27:46 +00:00
Nick Burch
7d2a9093da Turns out that .xlsx files can have multiple link tables, add a test file which shows this (support to follow) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611878 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 10:09:00 +00:00
Nick Burch
c386b48755 Convert test to junit 4, and stub out the additional 3d ref tests we need to pass for #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611877 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 10:08:20 +00:00
Nick Burch
58d3cd3717 Stub the unit test which is the next thing to need to work for progress on #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611833 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 23:02:51 +00:00
Nick Burch
551573dd95 Bit more towards XSSF name support for #56737, will need some deeper changes though to fully implement 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611830 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 22:50:54 +00:00
Nick Burch
611bcffb0c Initial support for XSSF External Links tables, which hold references to other workbooks referenced by formulas and names. #56744 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611828 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 22:48:59 +00:00
Nick Burch
d0db408a2f Leave part disabled for now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611755 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:54 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:16 +00:00
Nick Burch
3fd7c0d258 Update bug reference numbers, and bring over part of a test from unfixed that is now working (rest remains broken) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611728 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 17:27:37 +00:00
Nick Burch
6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 16:58:38 +00:00