moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
5,959 Commits 29 Branches 84 Tags 722 MiB
5ce675f345
Commit Graph

4838 Commits

Author SHA1 Message Date
Nick Burch
611bcffb0c Initial support for XSSF External Links tables, which hold references to other workbooks referenced by formulas and names. #56744 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611828 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 22:48:59 +00:00
Nick Burch
d0db408a2f Leave part disabled for now 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611755 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:54 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:16 +00:00
Nick Burch
3fd7c0d258 Update bug reference numbers, and bring over part of a test from unfixed that is now working (rest remains broken) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611728 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 17:27:37 +00:00
Nick Burch
6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 16:58:38 +00:00
Nick Burch
d4a1239efa #56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 15:59:55 +00:00
Nick Burch
c9d90732e5 Add disabled unit tests for bug #56737, which currently fails (differently) for HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611400 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-17 16:18:39 +00:00
Nick Burch
696b9d6406 Fix for #56702 - If a cell is of type numeric but has an empty <v/> tag, return as 0 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1610482 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-14 18:53:39 +00:00
Nick Burch
b9ff74b050 This bug has been fixed, so re-enable the unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607662 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 14:46:32 +00:00
Nick Burch
92f1cd20da Add a disabled unit test for bug #56420 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607661 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 14:30:47 +00:00
Nick Burch
570b87c885 Update the CheckFunctionsSupported example to take advantage of the new NotImplementedFunctionException to identify the function that is missing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607589 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 11:21:03 +00:00
Nick Burch
dd6819aa13 When throwing an exception during formula evaluation, if this is due to an unimplemented function, have a more specific exception type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607588 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 11:20:32 +00:00
Nick Burch
7bc0767bf5 Formula evaluation and error handling example - reports what cells can't be evaluated, and (TODO) what functions are used but not implemented 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607583 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 10:56:25 +00:00
Nick Burch
f33843810a Now that XSSFWorkbook can be closed, the older path based constructor no longer needs to be deprecated #56537 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607536 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 05:45:21 +00:00
Dominik Stadler
e34e77b12d Bug 56537: Update javadoc to reflect the addition of Closeable to Workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607390 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-02 15:05:05 +00:00
Tim Allison
94e9d67258 BUG 54771: add class to svn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602960 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-16 18:53:28 +00:00
Tim Allison
af7b947bb9 BUG 54771 extract text from SDTs at the cell level within a table row 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602955 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-16 18:46:00 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly, 
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 20:36:30 +00:00
Nick Burch
8afc419270 Fix inconsistent indent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601930 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 15:38:26 +00:00
Nick Burch
a1d0c8a260 #56537 close method for SXSSF too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601917 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 14:38:32 +00:00
Nick Burch
47a8f6cf48 Partial fix for #56537 - Have Workbook offer a close() method, which in turn closes the NPOIFS or OPC resource from which it was loaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601901 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 13:48:54 +00:00
Nick Burch
1bcf519c7c Add a note about file resources, see bug #56537 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1600326 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-04 16:34:16 +00:00
Nick Burch
e1000f257e When finding the CTCol object for a XSSF Sheet column, as we often have to traverse most of the list, and we are mostly reading not changing, switch to fetching all the objects as an array in one go, rather than fetching one at a time, which is hopefully faster. Aims to help bug #56556 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1600319 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-04 15:58:14 +00:00
Dominik Stadler
1d52c63292 Add workaround for IBM JDK where Ant populates classname instead of className for some reason 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598264 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-29 12:04:51 +00:00
Nick Burch
11a095bb3d HSSFCell should follow XSSF, and allow setting a null-style to return to the default style, fixes bug #56572 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598258 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-29 11:39:50 +00:00
Dominik Stadler
1d12d8b2aa Remove null-checks that can never be reached 
add test for ExcelAnt setString

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598225 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-29 09:15:33 +00:00
Dominik Stadler
f928ce1d34 Increase the font-inaccuracy for one unit test as some machines have fonts that lead to lower values, e.g. we get only 770 instead of 980 for Jenkins build on IBM JDK and on some local Windows machines 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597873 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-27 20:45:25 +00:00
Dominik Stadler
8c6e7e06aa Fix for 56563 - Multithreading bug when reading 2 similar files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597637 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-26 20:03:08 +00:00
Nick Burch
834973efe0 If a NoteRecord has no author tag, it seems it can sometimes be double padded. Fixes #47251 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597098 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 14:07:20 +00:00
Nick Burch
6cc94cdae8 Handle date format strings in an iso8601 style format, with a T in them. Fixes bug #54034 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597038 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 09:18:16 +00:00
Nick Burch
2bde35b8ff Patch from Yaniv Kunda from bug #56274 - Fix SXSSF writing of tables when creating from a template 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596624 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-21 17:08:25 +00:00
Dominik Stadler
1e93f257fc Move some tests from "unfixed" to "normal" test classes as the underlying bug is now fixed. 
Also make on of the unfixed bugs cause an actual failure so it is justified to stay in "unfixed"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596261 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-20 14:12:19 +00:00
Dominik Stadler
47ea1aa486 Bug 53691: Fix a copy/paste error in CFRuleRecord.clone() 
also make CFRuleRecord.toString() print out more information which caused the bug to be much harder to find
Add unit tests to verify/reproduce this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596251 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-20 14:01:22 +00:00
Dominik Stadler
38b5621723 Bug 56170: Fix a problem with cells in workbooks becoming disconnected from XMLBeans whenever columns need to be reordered during writing the file. This happens because setCArray() disconnects any previously stored array-item but we try to re-use them. So we need to recreate the CTCell and set it in the XSSFCell to make this work in all currently tested cases. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595659 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-18 19:18:27 +00:00
Dominik Stadler
927e62f662 Apache POI - Use assertArrayEquals() instead of assertTrue(Arrays.equals()), this way we get better information on failure 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595190 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-16 13:25:45 +00:00
Dominik Stadler
8f04bf295e Fix Bug 56514, add missing null-check if simple shape does not have any text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595127 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-16 07:09:55 +00:00
Dominik Stadler
8e6c459d83 Bug 56325: fix Exception when removing sheets with named ranges in the workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595048 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 21:14:52 +00:00
Dominik Stadler
9efc349872 Avoid unnecessary string creation/concatination for numeric conversion, use Double.toString() instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595047 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 21:14:32 +00:00
Nick Burch
4d2a90d3ec Add a HSSF print paper size constant for "printer default" for bug #56509 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594848 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 10:15:04 +00:00
Andreas Beeker
d0320ad77d Bug 56468 - Writing a workbook more than once corrupts the file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594721 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-14 21:14:16 +00:00
Dominik Stadler
599489e6fa fix some Eclipse warnings, unnecessary null-check and missing close() in tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594201 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-13 11:31:18 +00:00
Nick Burch
0bcdc868f3 Based on reading of the new file format docs, start to tweak how fixed length vs variable length / multi-valued properties are handled 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593861 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-11 21:16:40 +00:00
Nick Burch
1a149050ee Outlook sometimes stores a codepage of ANSI when it means 1252, detect and alias, fixes bug #53983 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593306 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-08 15:17:22 +00:00
Nick Burch
50ad48e746 Implement a few more MAPI property types 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593298 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-08 14:49:21 +00:00
Nick Burch
27e48c3b79 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1593297 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-08 14:46:43 +00:00
Andreas Beeker
00e2e55338 Bug 56486 - Add XOR obfuscation/decryption support to HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592636 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-05 21:41:31 +00:00
Andreas Beeker
337f775807 Bug 56269 - DateFormat - Rounding of fractionals 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592419 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 21:17:18 +00:00
Andreas Beeker
234ad7f85e The NPOIFS-classes result currently in left-over memory mapped buffers. 
These are actually hard to workaround, so for Windows the test is ignored, if this error happens.
http://stackoverflow.com/questions/3602783/file-access-synchronized-on-java-object 

Apart of that, the RandomFileAccess instance is saved in the FileBackedDataSource as it needs to
be closed instead of the Channel.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4796385

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592418 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 20:58:42 +00:00
Dominik Stadler
4112a8441e File leak detector: Close streams in some tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592315 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 08:05:32 +00:00
Nick Burch
ee0cddaf9a Excel 2007 and later allows for more than 3 Conditional Formatting rules per sheet, so change our hard limit to logging a compatibility warning. Test file from Pau Coma Ramirez from bug #56482 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591959 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 15:49:23 +00:00
Nick Burch
305ce3123b Generics warnings fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591838 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 09:15:23 +00:00
Nick Burch
ba4225395f Provide a convenience method for creating a PropertySet from a Directory + Entry 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590650 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:19:13 +00:00
Nick Burch
52c6fd587c Fix generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590642 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:03:18 +00:00
Nick Burch
3a5825c43f Update the HPSF change properties example to use NPOIFS + in-place writes, and have NPOIFS give a helpful error if you try to in-place write on a read only open 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590577 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 09:22:58 +00:00
Nick Burch
a57e1f1fa6 Get NPOIFS in-place-write working! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590556 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 06:35:39 +00:00
Andreas Beeker
5cd8324b89 junit4 fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590327 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 23:37:40 +00:00
Nick Burch
3e6cb71fb9 More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:50:00 +00:00
Nick Burch
f649abdbe9 Fix javadoc layout 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590317 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:43:23 +00:00
Nick Burch
0496d8f330 Convert the HPSF test to JUnit 4, and add a bit more testing for NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590309 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 21:51:28 +00:00
Nick Burch
7f5f7d0440 Stream tests for NDocumentOutputStream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590303 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 21:33:19 +00:00
Nick Burch
73bc57db74 NDocumentOutputStream write logic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590191 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:34:09 +00:00
Nick Burch
b77ce4fede Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590190 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:33:16 +00:00
Nick Burch
c3769b5da0 Begin to support and test in-place changes to documents within a NPOIFS stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:07:00 +00:00
Nick Burch
868a108fe3 Support for replacing the contents of a Document in a NPOIFSFileSytem, in place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590177 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:40:51 +00:00
Nick Burch
0250a0372f Complete NPOIFS write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590162 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:05:46 +00:00
Nick Burch
0bdc025279 When deleting a document in NPOIFS, free the underlying blocks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:00:30 +00:00
Nick Burch
fb89f2c2aa More progress with the write/read npoifs tests, but one bug still to go.... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590153 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 21:23:10 +00:00
Nick Burch
2c23f889df Refactor some of the NPOIFS write tests, and begin on the last missing write test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590149 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 21:11:26 +00:00
Nick Burch
b1dd6b403f Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 21:10:52 +00:00
Nick Burch
f6e7e1c8c7 Finish off the next NPOIFS write text 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590133 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 20:38:55 +00:00
Nick Burch
6a89a9afbf More NPOIFS mini stream improvements, and more tests for it all 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:39:31 +00:00
Nick Burch
e4e0e93ff5 Correct mini stream initialisation, and enable more npoifs write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:14:28 +00:00
Nick Burch
4b6ae05a04 More NPOIFS tests, and a partial mini-stream fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 17:06:10 +00:00
Nick Burch
4540a3c0ab More npoifs write tests, some disabled as failing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589987 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 10:57:15 +00:00
Nick Burch
a4c8f4f1c9 Add common code for writing out and reading NPOIFS again, and add a disabled roundtrip test (currently failing...) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589895 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 22:22:06 +00:00
Nick Burch
1fc66d1f71 Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 21:08:34 +00:00
Nick Burch
950c10faf4 Add TODOs for the next set of NPOIFS write tests we need 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589868 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 20:23:43 +00:00
Nick Burch
a94f150450 More NPOIFS write testing, and fix a problem with writing xbat details out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:44:10 +00:00
Nick Burch
166b8f6f8a Update a test to use the existing EntryUtils to copy with, rather than duplciating the logic, and tweak naming/javadocs to clarify what the test does 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589802 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:32:47 +00:00
Nick Burch
b2a35bb494 More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:25:10 +00:00
Nick Burch
fbd86d5084 More int/long sizing fixes for >2gb NPOIFS files, see bug #56447 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 16:15:21 +00:00
Nick Burch
e7dff43065 Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 15:42:53 +00:00
Nick Burch
d36d917467 Fix some Eclipse identified warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589765 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 15:07:20 +00:00
Nick Burch
6050a68d5a Two more test files from Stefan Kopf for bug #56164, and unit tests which use them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589759 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 14:52:09 +00:00
Nick Burch
67d97d8894 Correct an eclipse warning around close(), and a related bug that this identified 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589756 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 14:50:52 +00:00
Andreas Beeker
14a7ae6316 Bug 56437 - [PATCH] Streaming write support in NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 14:37:33 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes: 
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 12:16:54 +00:00
Nick Burch
d3ad1a9bb8 Tweak 'assertAlmostEquals' bast on Jenkins results 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588595 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 23:44:08 +00:00
Nick Burch
1dc3c57c0c Unit test for column autosizing of % values 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588562 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 20:46:57 +00:00
Dominik Stadler
0974acc778 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 18:20:15 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-15 21:59:52 +00:00
Dominik Stadler
91b6961a44 Fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584544 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-04 07:26:53 +00:00
Dominik Stadler
a08e8e4824 exclude new broken test-file for this test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584543 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-04 07:26:24 +00:00
Nick Burch
32b69ac9b9 Add another test file for bug #47251, from Joe Yuan, and a disabled test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583825 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-01 23:27:05 +00:00
Dominik Stadler
a202d2fa64 Fix two javadoc warnings reported in Jenkins build and add some @Overrides 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583598 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-01 10:40:13 +00:00
Dominik Stadler
aef13a344a Undo a toString() removal for a case where it is actually necessary. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583571 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-01 08:28:52 +00:00
Cédric Walter
1c987c38e6 performance issue: removed instantiation of new String object by copying an existing string. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 16:16:52 +00:00
Cédric Walter
730deb782b performance issue: call toString() on a String object. This is entirely redundant. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 16:01:39 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 15:54:52 +00:00
Nick Burch
f52fe377ae Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-28 21:54:30 +00:00
Nick Burch
8bee2665b3 Patch for #55594 from Paul Vonnahme - Fix SXSSF encodings on EBC 
IDIC platforms, by setting the required encoding explicitly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1580314 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-22 20:48:58 +00:00
Nick Burch
3868a2cdc7 Avoid an IndexOutOfBoundsException if there are no property nodes when searching for the start index, return -1 instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578929 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-18 14:40:27 +00:00
Nick Burch
af381473d0 Support adding tabs to a XWPFRun, and add unit tests on toString() for addTab and addCarriageReturn 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578921 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-18 14:26:28 +00:00
Nick Burch
e9ea048c00 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578915 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-18 14:17:36 +00:00
Nick Burch
6d2ecdeac2 Fix bug #56278 - Support loading .xlsx files with no Styles Table 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578518 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-17 19:02:21 +00:00
Dominik Stadler
ee58bd0d32 Bug 56195: replace System.err with propert logging 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1578147 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-16 19:46:56 +00:00
Dominik Stadler
24fdb260bc Remove two files added inadvertedely 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577909 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 17:31:43 +00:00
Dominik Stadler
7c3f1a926b Bug 56169: Fix NPE during export to XML with xs:all 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577907 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 17:29:17 +00:00
Dominik Stadler
f597633624 Bug 56114: Add testcase to verify that the flag is correctly stored in the XLS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577901 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 17:00:22 +00:00
Nick Burch
1e03ded992 When looking for text run related records after a TextHeaderAtom, provide a cleaner way to skip ones we don't care about, and a cleaner way to find the StyleTextPropAtom. Should fix #56260 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577803 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 08:16:43 +00:00
Nick Burch
488647cb43 Implement MasterTextPropAtom, which provides the indents for a run of text, needed for #56260 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577802 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-15 08:14:36 +00:00
Nick Burch
adb98e1073 #56260 Partial fix for a slide with a TextHeaderAtom but no other atoms related to it, which is followed by another TextHeaderAtom straight away 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577537 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-14 13:59:24 +00:00
Andreas Beeker
c5527db88a Bug 56075 - Add Change Tracking support to XWPF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1577010 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-13 00:16:56 +00:00
Nick Burch
f63b47b8f6 Fix inconsistent whitespace, and add a close call in the main method to avoid a resource-leak warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575684 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-09 09:53:25 +00:00
Nick Burch
2a7cebf8c0 Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-09 09:49:06 +00:00
Nick Burch
434f05058e Fix the inconsistent indents in the test file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575600 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 20:03:40 +00:00
Nick Burch
09adb72510 Add more unit tests for XWPF Headers and Footers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575599 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 20:01:38 +00:00
Nick Burch
d5c8510750 When adding a new XPWFRun to a paragraph, update both the Runs and IRuns lists with it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575597 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 19:52:09 +00:00
Nick Burch
70e1b5edeb Add some javadocs for the XWPF Header/Footer creation methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575594 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 19:33:07 +00:00
Dominik Stadler
7e21a14172 Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 16:46:59 +00:00
Dominik Stadler
8c5115aeb1 Fix Sonar issues about finalize() usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:41:25 +00:00
Dominik Stadler
a128bcd5e2 Enhance test to print out more information, it seems to fail on Apache Jenkins JDK8 build 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575500 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:41:08 +00:00
Dominik Stadler
382be9f312 Adjust TestExtractorFactory to provide more output to see why it fails on Maven builds on nemo.sonarsource.org 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575497 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:22:03 +00:00
Andreas Beeker
3fe86eca24 Added MD4-option and some cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-06 00:53:09 +00:00
Nick Burch
f6a5959788 POI is now on JDK 1.6, so remove 1.5 workaround 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-04 11:57:44 +00:00
Nick Burch
6d8a78a373 Report how long the CSV conversion took, helpful for a quick read performance test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1572555 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-27 13:32:27 +00:00
Andreas Beeker
833ae007f8 Bug 56076 - Add document protection with password support to XWPF 
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-21 23:19:57 +00:00
Nick Burch
31493632ea Zero length code page fix has been committed, so this file can once again be included in the overall test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570390 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-20 23:37:20 +00:00
Nick Burch
7984a1ec3f More helpful visio v5 exception, see bug #56171 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570388 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-20 23:20:19 +00:00
Nick Burch
32290bd2bf Another content types test, for #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570002 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-20 00:06:34 +00:00
Andreas Beeker
49c69f0eed The junit test failed with the original test-file (CDT_Data_Retention-PPT.ppt), so another check was necessary 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569999 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-20 00:03:42 +00:00
Nick Burch
d72bd78c19 Fix bug #56164 - Tidy up the OPC SAX setup code with a new common Helper 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569991 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:54:46 +00:00
Andreas Beeker
8afdb7a9ce Bug 55732 - PPT can't open, fails with "Couldn't instantiate .... StyleTextProp9Atom : java.lang.ArrayIndexOutOfBoundsException: 56" 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569984 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:45:07 +00:00
Nick Burch
56d6f0342a Complete support for OOXML content types with parameters, including parts of the patch from Sebastien Schneider from bug #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569976 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:34:53 +00:00
Andreas Beeker
edf1ffd89b upgraded to junit4 (before other changes) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569972 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:30:12 +00:00
Nick Burch
6e933cb242 Begin to implement some of the tests and logic for content types with parameters, based on the test file for bug #55026 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1569965 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-19 23:12:56 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix 
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 23:36:32 +00:00
Nick Burch
c144310a15 Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 19:35:55 +00:00
Andreas Beeker
53c90692ee FindBugs fix 
- fixed "equals() method does not check for null argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 19:35:16 +00:00
Andreas Beeker
8689458854 Sweeping is also needed for empty column-list ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568791 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 17:00:53 +00:00
Andreas Beeker
2a14920cdd FindBugs fix 
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 16:30:24 +00:00
Dominik Stadler
dcad3624dc Fix unit tests broken by newly added test-file, ignore TestFontRendering as it is inherently unstable currently 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568744 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 09:11:28 +00:00
Dominik Stadler
7e63803aa9 Fix unit test which failed after new corrupted file was added. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568741 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 08:39:47 +00:00
Dominik Stadler
2414998aac Adjust test to write the failing PNG in case expected and actual do not match 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568740 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 08:39:17 +00:00
Dominik Stadler
023fa18794 Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 10:43:58 +00:00
Dominik Stadler
b51a52cf20 Provide more output on test that failed for me locally 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568558 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:21:19 +00:00
Dominik Stadler
8bc8ac9bef Adjust some tests to not hardcode the 'test-data' directory. This breaks the Sonar-maven build that I am working on locally 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568557 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:20:24 +00:00
Dominik Stadler
9b4121cb45 Update Javadoc somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:19:32 +00:00
Dominik Stadler
2b85b00690 Add assertions, remove Sonar warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568554 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:18:34 +00:00
Andreas Beeker
f8bf66308e update *ssf-workbook tests to junit4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568541 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 23:21:30 +00:00
Andreas Beeker
a0831ba0f9 Bug 53130 - SXSSF Shared Strings option support, to make generated xlsx files compatible with Google Docs or iPad 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568539 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 22:45:05 +00:00
Andreas Beeker
92a488a28b FindBugs fix 
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix 
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-13 23:34:11 +00:00
Andreas Beeker
276b477322 disable not applicable findbugs check 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567815 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-13 00:07:36 +00:00
Andreas Beeker
8c3785890a Bug 55902 - Mixed fonts issue with Chinese characters (unable to form images from ppt) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567455 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-11 23:16:54 +00:00
Andreas Beeker
413e76aed0 FindBugs fix 
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-09 21:19:20 +00:00
Dominik Stadler
d9009484a6 Bug 55923: Fix compare/sorting of nodes in exported XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564050 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 20:56:43 +00:00
Dominik Stadler
19ed26f156 Bug 55924: Avoid errors during exporting XML if there are numeric cells without value, also verify in tests that XML can always be parsed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564045 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 20:17:59 +00:00
Dominik Stadler
d7028dcf09 Bug 55926: Handle numeric formula values when exporting to XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564028 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 19:46:41 +00:00
Dominik Stadler
503ce1e6c4 Bug 55927: Handle date types when exporting to XML 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1564011 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-03 19:19:14 +00:00
Nick Burch
d07ce077f5 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563660 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:44:30 +00:00
Nick Burch
e023d34c9a Add setIncludeHeadersFooters(boolean) to the ExcelExtractor common interface, as all implementations now have the method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563658 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:41:27 +00:00
Nick Burch
eb2e8ffe0a Patch from Shaun Kalley from bug #56022 - XSSF Event Text Extractor header/footer support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563657 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:39:53 +00:00
Nick Burch
85bee89fe3 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563653 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:28:04 +00:00
Nick Burch
720b4a3aad Have the Excel text extractors all implement the same interface, as best as they can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:23:26 +00:00
Dominik Stadler
cdb915a279 Bug 56017: Fix comment-ref when shiftig rows with comments, this probably does not fix the bug itself, though 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563587 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 10:34:42 +00:00
Andreas Beeker
c1a7ab3860 Bug 53282 - Hyperlink with a non-breaking space throws java.lang.IllegalStateException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563540 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 01:56:02 +00:00
Andreas Beeker
028ec314ae javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563509 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 23:23:07 +00:00
Andreas Beeker
f101bc0aff Bug 55802 - Special Letters not exported correct 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563496 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 22:26:18 +00:00
Nick Burch
fdcd28194e Fix up whitespace / indents to be consistent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563491 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 22:05:23 +00:00
Nick Burch
c5823a746f Fix javadoc formatting 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563489 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:58:24 +00:00
Andreas Beeker
5e7679eafd Javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563488 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:56:07 +00:00
Nick Burch
2b0c8deb2f Expose the StyleIndex of CharacterRuns, and expand the range style tests to cover this + related 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563486 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:52:19 +00:00
Andreas Beeker
5d0f69097c Bug 51891 - Fix StringIndexOutOfBoundsException : Ole10Native.<init> (parsing word file) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563483 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:45:48 +00:00
Dominik Stadler
7db6081827 Bug 56011: Use default style if the cell style attribute is not present 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563470 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 20:54:09 +00:00
Andreas Beeker
bd3cd2243e TreeSet without JDK 6 method usages 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561511 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 16:26:59 +00:00
Andreas Beeker
e790281425 This patch is not working as of license incompatibility - see http://www.apache.org/licenses/GPL-compatibility.html 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561507 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 15:38:11 +00:00
Andreas Beeker
6f6c6cda34 As Jdk 1.5 doesn't provide NavigableMap/Set classes of JDK 1.6, we temporarily use the open jdk classes instead, until POI has switched to JDK 1.6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561500 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 15:01:12 +00:00
Andreas Beeker
30d9106d9a - Bug 51585 - WorkbookFactory.create() hangs when creating a workbook 
- adapted relevant test-classes to Junit4 to support timeout handling
- tab / space cleanup

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561435 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-26 02:18:53 +00:00
Andreas Beeker
474c4eec6a jdk 5 compiler doesn't support overwrite for interfaces ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561406 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-25 21:56:08 +00:00
Nick Burch
d2687261e3 Patch from Detlef Brendle from bug #55873 - Support for COUNTIFS function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1560736 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-23 16:43:59 +00:00
Andreas Beeker
439ad29071 Added license headers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-18 00:38:04 +00:00
Andreas Beeker
c148f9c3e5 javadoc fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557290 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-11 00:14:17 +00:00
Andreas Beeker
1eba8faedb Bug 35897 - Password protected files 
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 23:14:03 +00:00
Nick Burch
0e5300538f Ensure our package html files have consistent line endings, and the right svn properties set on them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557156 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 15:39:39 +00:00
Dominik Stadler
d714d0da65 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-01 22:15:44 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more 
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:12:30 +00:00
Dominik Stadler
dcc34ec845 Don't unnecessarily convert from ArrayList to array, use the ArrayList directly instead, this speeds up BiffViewer and related unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554534 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:59 +00:00
Dominik Stadler
d83461c3fb Print out which actual value was out of range 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554533 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:44 +00:00
Andreas Beeker
f32e87957c obsoleted by TestEscherBlipRecord and EscherMetafileBlip 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554104 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-30 00:00:54 +00:00
Andreas Beeker
ae2b93eaa0 Bug 45776 - Fix corrupt file problem using TextRun.setText 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554077 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-29 22:14:05 +00:00
Andreas Beeker
c95d740ee4 Bug 41246 - AIOOBE with missing notes entries 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553760 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-27 23:42:34 +00:00
Nick Burch
e961fe6e94 Fix whitespace - reformat to consistent spaces, instead of a mix of tabs and spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553625 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-27 04:26:18 +00:00
Andreas Beeker
3ef65e166d Bug 48593 - [PATCH] Multiple Saves Causes Slide Corruption 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553610 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-27 00:22:19 +00:00
Dominik Stadler
1e4c1770d7 Bug 51158: clear out Memory-based part before writing to it, 
except for PictureData items, which keep the original image
data in the Part-object directly.
Add reproducer-unit tests and enhance some related unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553525 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 17:55:36 +00:00
Dominik Stadler
f8969e8d83 Remove unnecessary separate length, an array already has one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553522 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 17:54:49 +00:00
Dominik Stadler
60ca1a5de4 Add some @Overrides suggested by Eclipse, generics and some warnings, 
convert some tabs to spaces.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553466 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 09:38:48 +00:00
Dominik Stadler
3f39b60f53 Fix some Eclipse warnings in ReaderWriter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553465 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 09:32:08 +00:00
Dominik Stadler
aaa4029cd5 Remove unused members and make others private 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553464 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 09:31:25 +00:00
Andreas Beeker
e34a1f9620 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 00:46:16 +00:00
Andreas Beeker
2788aca235 javadoc and compiler warning house-keeping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553428 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 23:24:04 +00:00
Andreas Beeker
3ccd728544 javadoc house-keeping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553422 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 22:18:53 +00:00
Dominik Stadler
bc7b658ea9 Fix some JavaDoc items that are reported in the build-output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 18:05:41 +00:00
kiwiwings
3a36da330a JCE policy fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553342 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 01:04:29 +00:00
kiwiwings
82958a11cb Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553340 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:55:17 +00:00
kiwiwings
c72965c8b2 Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553339 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:49:10 +00:00
kiwiwings
abac580a6e Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553338 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:39:09 +00:00
kiwiwings
ad9cecae59 Patch for Bug/Enhancement 55818 - add encryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553336 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:13:21 +00:00
Yegor Kozlov
ff79d73725 patch 55731: StringBuilder logic in DataFormatter.cleanFormatForNumber 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553248 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 06:02:27 +00:00
Yegor Kozlov
ed5942640f patch 55730: Fix org.apache.poi.ss.usermodel.BuiltinFormats.java for 0x29-0x2c 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553247 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 05:58:23 +00:00
Yegor Kozlov
fdda5f2071 removed pictureFileZero.ppt from svn as requested by the owner, see discussion on @poi-dev from Dec 12, 2013 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551845 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-18 05:26:49 +00:00
Nick Burch
87375a5b46 Fix bug #55901 - Avoid using RMI based 
exception from PropertySetFactory, as it's not needed nor helpful

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551832 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-18 04:08:03 +00:00
Nick Burch
01378c8acc Don't use the degree symbol in comments, as it upsets the compiler, and causes the javadoc tool to error. Use the word degrees instead, much safer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1550351 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-12 05:29:11 +00:00
Nick Burch
43383ec1f4 More javadocs for Cell.setCellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1550349 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-12 05:22:26 +00:00
Dominik Stadler
76c0cfc2c9 Refactor XSSFExportToXml a bit, split code into more methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1549008 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-08 08:39:10 +00:00
Dominik Stadler
2a08a1dd10 Bug 55850: fix NullPointerException during extraction from XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1549007 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-08 08:35:20 +00:00
Dominik Stadler
18f9a3e88e Bug 55640, added reproducer, a fix for the Exception cases and some verify-tests to ensure future 
changes are checked via unit tests. There might be more work pending to
make grouping fully work the same way as Excel does.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1547153 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-02 19:14:03 +00:00
Dominik Stadler
5511c6dbcc Bug 55745: fix handling of tables in XSSF if there are comments as well, add testcase which was committed to the wrong tag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1546458 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-28 21:19:34 +00:00
Dominik Stadler
6618473e64 Bug 55745: fix handling of tables in XSSF if there are comments as well, there is not much sense in leaving the loop on the first instance of comment table and skipping all the other tables. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1546385 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-28 15:15:59 +00:00
Cédric Walter
73ee268e56 Bug 55768: added Line charts support and setting axis tick marks, title 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544628 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 18:26:11 +00:00
Cédric Walter
e9b8faa748 Bug 54676: added new chart axis type: Category axis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544612 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 17:45:00 +00:00
Nick Burch
44c9f41cc9 Patch from Andreas Beeker from bug #53475 - Switch XWPF test to JUnit 4, so that we can skip one part of the tests if the JVM doesn't support larger keys 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544121 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-21 11:18:23 +00:00
Nick Burch
d1118ce0d5 Patch from Andreas Beeker from bug #53475 - further OOXML Encryption support, covering more ciphers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541009 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 11:37:45 +00:00
Nick Burch
e2e04b0ebc Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541005 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 11:32:10 +00:00
Nick Burch
16eb9990bc More JavaDoc tweaks, and suppress deprecated warnings where these are expected 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540989 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:55:46 +00:00
Nick Burch
c6dde74f4f Consistent indenting, based on current POI style guide 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540987 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:53:57 +00:00
Nick Burch
381cc611d7 Fix some JavaDocs, and add a generic constructor based on ZipEntrySource 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540986 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 09:51:13 +00:00
Nick Burch
6780a911e2 Reduce duplication by replacing lots of deprecated methods with calls to their replacement (which is basically the same code anyway) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540878 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-11 23:08:36 +00:00
Nick Burch
0457300fdf Try to make a few OPCPackage error messages more helpful, and slightly reform the configure code block to make it hopefully easier to read 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540877 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-11 23:03:00 +00:00
Yegor Kozlov
362fec4a01 Bugzilla 55560 : Patch for hiding slides in HSLF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540295 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-09 11:57:21 +00:00
Yegor Kozlov
9b3a2ccb82 Patch 53176 - Fixed auto shapes render problem in pptx files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1540290 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-09 11:32:55 +00:00
Nick Burch
4ae76ffddc Unit tests for Shrink To Fit cell style support (#55661) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539850 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 22:39:11 +00:00
Nick Burch
c6177274af Start on HSSF/XSSF Shrink To Fit support, see bug #55661 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539848 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 22:28:06 +00:00
Nick Burch
d45b6acef3 Patch from Andreas Beeker from bug #49237 - HSSF Row Style XfIndex is 12 not 16 bits of data 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539837 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 21:56:49 +00:00
Nick Burch
f7b44f5e9f Patch from Andreas Beeker from bug #53475 - CSPName may not always be present on OOXML encrypted documents, plus test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539828 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 21:29:14 +00:00
Cédric Walter
224b66e8d4 Bug 55742: fixed mirr FormulaEvalTestData.xls tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539451 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-06 20:09:43 +00:00
Cédric Walter
28b14db09a Bug 55742: fixed hex2dec tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539447 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-06 20:04:22 +00:00
Cédric Walter
fb811535be Bug 55724: implementation of excel percentile function, added unit test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539401 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-06 17:12:13 +00:00
Cédric Walter
3976993fda Bug 54696: Add overlay setting to ChartLegend 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539169 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 22:35:54 +00:00
Cédric Walter
fc086aba47 Bug 55724: implementation of Excel PERCENTILE function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539154 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 22:11:18 +00:00
Cédric Walter
fac5f0ea50 fixed red build, cause by invalid java 5 method isEmpty and unmappable character for encoding ASCII 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539127 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 20:46:20 +00:00
Cédric Walter
d8c54be1aa Bug 55024: MIRR Formula implementation review, added error handling and FormulaEvalTest.xls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538795 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 22:52:06 +00:00
Cédric Walter
eab0adda8b Bug 54535: Bug in INTERCEPT and SLOPE, review and integration test added to FormulaEvalTestData.xls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538772 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 21:27:12 +00:00
Cédric Walter
6cb3b01753 Bug 55742: Apply patch for Oct2Dec and refactor Hex2Dec to also use BaseNumberUtils.convertToDecimal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538765 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 21:09:40 +00:00
Dominik Stadler
7014abae83 Bug 52400: fix handling some types of TNEF files, make HMEFMessage.HEADER_SIGNATURE int as it is handled as int everywhere, move .dat files to HMEF sample dir, cover some border cases in HMEFMessage, add another .dat sample file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538353 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-03 12:43:42 +00:00
Dominik Stadler
19630f1a29 Add more output to assertion in test-case that is sometimes failing, see e.g. Jenkins build #170... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538330 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-03 10:11:09 +00:00
Dominik Stadler
0cf470a5d4 Add slightly more coverage for ExcelAntWorkbookUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538281 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-02 20:58:22 +00:00
Dominik Stadler
8d345b13d0 Fix Bug 54400 by updating the index in the LinkTable whenever sheets are 
removed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538163 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-02 10:01:01 +00:00
Nick Burch
a6b301e485 Fix bug #55733 - XWPFWordExtractor need 
s to handle .docx files with neither headers nor footers

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538044 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-01 19:43:46 +00:00
Nick Burch
01b276b2f3 Allow formatting of formula error cells, giving back the error string that Excel shows #55729 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1537552 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-31 16:53:03 +00:00
Dominik Stadler
d08ab9dc0d Slightly more test-coverage in HSSFSheet/XSSFSheet/SXSSFSheet and fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1537331 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-30 22:26:13 +00:00
Dominik Stadler
f82527ecb1 Re-use functionality from HSSFWorkbook in dev-tools to find the 
dir-entry-name to make special names like WORKBOOK or BOOK work, handle
a special case in ExternalNameRecord when the flag states that there is
data, but no data remains in the stream, slightly improve error-output
in DirectoryNode, adjust all dev-tools-tests to not report stack-traces
any more for expected failures and try with HSSFWorkbook to decide if it
is an expected failure or now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1536062 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-27 08:16:29 +00:00
Dominik Stadler
0342f9602d Add reproducer tests for Bug 53515, disabled as we do not fix any of the 
reported issues. Also fix some Ecliipse warnings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535959 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-26 10:05:24 +00:00
Dominik Stadler
5644fcbaa0 Bug 49940: Apply patch to avoid XmlValueDisconnectedException when 
saving a file twice and enable reproducing unit test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535938 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-26 07:31:47 +00:00
Dominik Stadler
780aec8ad2 Add a number of tests for the dev-tools. The tests iterate over all .xls 
files that are found under test-data, any newly added file or
code-change which breaks one of the dev-tools will cause the tests to
fail in the future. Known broken files can be excluded.

Also fixes two points where some files could cause BiffViewer to fail.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535885 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-25 21:57:48 +00:00
Yegor Kozlov
616238f8e2 Patch 55612 - Performance improvement in HSSFCellStyle.getDataFormatString() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535810 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-25 18:41:24 +00:00
Dominik Stadler
5ad89d96b6 Fix some Eclipse warnings, remove trailing whitespaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535517 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-24 19:58:19 +00:00
Nick Burch
b646166b6c Have HSSFWorkbook check for an encrypted .xlsx file when opening, and give a helpful error if found, plus tests. Fixes #55692 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534967 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-23 09:43:28 +00:00
Nick Burch
5ac455fd72 Patch from bug #55650 from Andrej - Avoid AIOOBE if a non-existant Xfs is requested for a styleAvoid AIOOBE if a non-existant Xfs is requested for a style 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534818 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-22 22:04:16 +00:00
Dominik Stadler
1bf79ee0cf Bug 55369: Add support for collapsing rows in SXSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533932 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-20 18:04:08 +00:00
Yegor Kozlov
689f027749 Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533768 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-19 14:12:15 +00:00
Yegor Kozlov
4243b72fc2 Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533764 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-19 13:53:19 +00:00
Dominik Stadler
3b4538cfb4 Bug 55658: don't fail in SXSSF if a numeric cell is overwritten with a string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532873 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-16 19:47:21 +00:00
Dominik Stadler
9d98d6e309 Change from having actual zero bytes in java code to java-string notation for unicode-zero to avoid trouble with this file in Sonar when using PostgreSQL (which seems to fall over binary data in text files). The resulting test should be the same with the \u0000 notation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1532037 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-14 19:44:30 +00:00
Yegor Kozlov
cf7a4c117a Bugzilla 55578 - Support embedding OLE1.0 packages in HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531623 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-13 07:39:40 +00:00
Yegor Kozlov
489b0b5bdb Bugzilla 49658 - Support embedding EMF/WMF pictures in HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531622 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-13 07:20:36 +00:00
Cédric Walter
451d9eb4af Bug 55036: fixed red build (Dec2Hex) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531506 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-12 06:28:51 +00:00
Cédric Walter
b43a685b6c Bug 55036: patch for missing function Dec2HEx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531395 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 19:16:43 +00:00
Cédric Walter
1d8a31724a Bug 55057: patch for missing function Hex2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531393 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 19:06:33 +00:00
Cédric Walter
c70043f1d5 Bug 55116: patch for missing function Dec2Bin 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531390 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 18:49:19 +00:00
Cédric Walter
be144a48fd Bug 55055: patch for missing function Bin2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531386 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 18:39:22 +00:00
Cédric Walter
61f1130e38 Bug 55649: WORKDAY Function returns incorrect date when spanning a weekend, or the start date is a weekend 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531124 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 21:54:52 +00:00
Nick Burch
f15a35ec45 Fix #55647 - When creating a temp file, ensure the name isn't already taken 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531040 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 16:20:07 +00:00
Cédric Walter
ed1fc84a38 Bug 55058: patch for missing function FactDouble 
Returns the double factorial of a number: FACTDOUBLE(number)

Number     is the value for which to return the double factorial. If number is not an integer, it is truncated.

Remarks
If number is nonnumeric, FACTDOUBLE returns the #VALUE! error value.
If number is negative, FACTDOUBLE returns the #NUM! error value.

Has  a cache for more speed of previously calculated factorial
Add additional sanity check/integration test FormulaEvalTestData.xls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530907 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 10:10:54 +00:00
Cédric Walter
8c2e38892e Bug 55081: patch for missing function WEEKNUM 
Add simple spreadsheet with Excel 2003, and another with 2013 (both fresh files)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530256 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-08 12:54:35 +00:00
Cédric Walter
f49f20daec Bug 55037: patch for missing function DELTA 
Add missing TestDeltaFunctionsFromSpreadsheet and register Delta in AnalysisToolPak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1529809 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-07 09:42:38 +00:00
Dominik Stadler
43b74b0253 Apply patch from bug 55341 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527397 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-29 20:23:20 +00:00
Tim Allison
3e1208af44 Potential NPE in PPExtractor; found while working on TIKA-1171 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527041 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-27 19:35:14 +00:00
Tim Allison
58dd7d7c0c POI-54722 table text in ppt files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1526960 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-27 15:45:55 +00:00
Nick Burch
ad8b09095e Support more hashing formats for OOXML protected documents, for bug #55544 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1522074 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-11 22:22:30 +00:00
Dominik Stadler
4a3c974e3b Remove Eclipse warnings, remove duplicate test, rename tests to also run tests in base class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521015 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-09 09:41:31 +00:00
Dominik Stadler
e6ed66a126 Bug 53798: Add fix for XmlValueDisconnectException during shifting rows 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521012 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-09 09:24:05 +00:00
Dominik Stadler
17e8880dcd Bug 54524: Fix border case in FormulaShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517676 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-26 20:09:19 +00:00
Dominik Stadler
84ef8c5970 Fix regression introduced by r1516969 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517180 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-24 18:33:00 +00:00
Dominik Stadler
18d369ed86 Exclude TestUnfixedBugs from OOXMLLite to avoid confusing output in ant-build of ooxml-lite 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517179 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-24 18:32:45 +00:00
Nick Burch
673864cdc5 More unit tests for column conversion, and avoid the use of Math.pow based on the suggestion from github-6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516983 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 19:00:01 +00:00
Dominik Stadler
b79d4fda52 Tried to reproduce Bug 47090, but seems to be fixed now. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516982 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:56:32 +00:00
Dominik Stadler
13e08c3e92 Add testcase which tries to reproduce Bug 48495, but seems to be fixed 
now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516981 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:56:11 +00:00
Dominik Stadler
f8f998b80b Some Eclipse warnings removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516980 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:54:05 +00:00
Nick Burch
689aa10390 Add some explicit tests for column letter to/from number conversion 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516978 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:52:18 +00:00
Nick Burch
8b0334c701 Remove some @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516975 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:42:57 +00:00
Nick Burch
f04c20ce5d Start to remove @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516973 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:36:41 +00:00
Nick Burch
95fb311279 Inspired by github pull-6, use a StringBuilder for quicker string appending 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516969 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:30:01 +00:00
Dominik Stadler
bff0813e48 fix some Eclipse warnings, adjust some unit tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516818 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 10:44:39 +00:00
Dominik Stadler
37b7f408a3 Fix unit test for Bug 50298 some more 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516320 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:57:26 +00:00
Dominik Stadler
f0a8bc9281 Adjust test for Bug 50298 to not leave a temporary file behind and 
enhance the test with some more cases of moving/changing/removing sheet
order/names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516314 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:19:58 +00:00
Dominik Stadler
1249614bc8 Bug 50298: Fix corruption of Workbook when setting sheet order. The 
boundssheets themselves were adjusted, but not the corresponding
records.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516313 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:08:20 +00:00
Dominik Stadler
134195c86c Also fix some Eclipse warnings while hunting Bugs: Generics, unused 
variables, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516312 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:06:07 +00:00
Nick Burch
75a56dcf22 Push the fix for bug #55248 up to the Sheet interface (was XSSF only before) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 09:41:15 +00:00
Dominik Stadler
9e62269eef Bug 52233: try to fix this without breaking the format of xlsx-files. 
The set to null is necessary to not have an empty <cols/> element in the
xlsx, however later on stuff breaks if no colsArray is availalbe,
therefore we now re-create the empty cols array if we did remove it
before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1515916 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-20 18:44:44 +00:00