Javen O'Neal
|
6fcacf21f3
|
bug 61474, github #81: pull up methods from RowShifter to BaseRowColShifter, since both row and column shifting should be able to shift formulas, comments, merged regions, conditional formatting, etc; add @since decorators for new *ColumnShifter and *RowColShifter classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814261 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 09:07:32 +00:00 |
|
Javen O'Neal
|
ec8b13c3a8
|
bug 61474, github #81: remove @Internal RowShifter#updateRowFormulas, move to XSSFRowColShifter; implement ColumnShifter#updateFormulas; remove duplicated JavaDocs (better to inherit)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814260 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 08:54:20 +00:00 |
|
Javen O'Neal
|
4d526bfd01
|
bug 61474, github #81: implement updateConditionalFormatting for ColumnShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814259 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 07:58:41 +00:00 |
|
Javen O'Neal
|
7c88f32408
|
bug 61474, github #81: implement updateNamedRanges for ColumnShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814258 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 07:42:33 +00:00 |
|
Javen O'Neal
|
607ca594b1
|
bug 61474, github #81: fix ColumnShifter#removalNeeded to use columns instead of rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814257 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 07:29:53 +00:00 |
|
Javen O'Neal
|
4b92e7c67a
|
bug 61474, github #81: add ColumnShifter interface; deduplicate some code in RowShifter, CFRecordsAggregate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814256 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 07:17:44 +00:00 |
|
Javen O'Neal
|
b671199b40
|
bug 61474, #81 on github: add @Override annotation; rename FormulaShifter shifter to FormulaShifter formulaShifter to reduce confusion with the shifter variable referring to the RowShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814255 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 05:48:18 +00:00 |
|
Javen O'Neal
|
0e540db89b
|
bug 61474,github-81: add FormulaShifter.createForColumnShift and ShiftMode.ColumnMove
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814254 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 05:29:52 +00:00 |
|
Javen O'Neal
|
40ae87fd36
|
github-81: extract routines in HSSFRow#shiftRows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814253 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 04:29:45 +00:00 |
|
Javen O'Neal
|
59594b6030
|
rename ambiguous variable name shifter -> formulaShifter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814247 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 02:57:01 +00:00 |
|
Javen O'Neal
|
4b2f709551
|
whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814245 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-04 02:49:52 +00:00 |
|
Andreas Beeker
|
388c491135
|
#61671 - XSLFSlide does not contain isHidden and setHidden like HSLFSlide does
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814122 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-02 23:15:19 +00:00 |
|
Nick Burch
|
bae303a412
|
Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813966 13f79535-47bb-0310-9956-ffa450edef68
|
2017-11-01 11:21:25 +00:00 |
|
Javen O'Neal
|
925a296cc3
|
eventually we want to forbid StringBuffer usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 11:10:08 +00:00 |
|
PJ Fanning
|
34006a542e
|
use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813869 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 10:24:47 +00:00 |
|
Javen O'Neal
|
bf5a0c4c9e
|
github-68: add @Override to o.a.p.ss.usermodel.charts.DataSources. Thanks to Alain-Bearez.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813868 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 10:17:38 +00:00 |
|
PJ Fanning
|
5402bcdd49
|
add test case for bug 61701
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813864 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 09:51:51 +00:00 |
|
PJ Fanning
|
e623808539
|
add test case for bug 61701 and use StringBuilder in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813863 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 09:48:23 +00:00 |
|
Javen O'Neal
|
722ab2d4f1
|
github-77: Remove the 'public' modifier to make fields package protected (findbugs-MS_PKGPROTECT). Thanks to BruceKuiLiu for the PR. This closes #77 on github.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813859 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 09:38:03 +00:00 |
|
Javen O'Neal
|
729c86e82c
|
consolidate duplicated code: XSSFWorkbook#setBookViewsIfMissing()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813841 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 01:45:03 +00:00 |
|
Javen O'Neal
|
d4a0dbc792
|
bump the Eclipse compile source to Java 1.8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813840 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-31 01:08:43 +00:00 |
|
Javen O'Neal
|
1cea1c52fd
|
bug 61630: Patch from Daniel to fix XSSFExportToXML IllegalArgumentException: Comparison method violates its general contract! (bug 61630, comment 17, attachment 35468). Found during manual testing.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813443 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-26 18:10:09 +00:00 |
|
Javen O'Neal
|
b88b245fb8
|
remove test-hssf ant target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813351 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-25 20:19:23 +00:00 |
|
Javen O'Neal
|
52dfce033c
|
remove test-ss and test-ooxml-ss ant targets, as these were causing problems with the build/ooxml-testokfile.txt being written, requiring test-ooxml to be rerun on subsequent ant calls even if had previously completed successfully and not modifications to the ooxml source had been made.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813342 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-25 18:59:54 +00:00 |
|
Javen O'Neal
|
2cf5a977aa
|
bug 61630: further XSSFExportToXML performance improvements from Daniel (bug 61630 comment 15, attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813332 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-25 18:19:12 +00:00 |
|
Javen O'Neal
|
02093f59dc
|
bug 61630: revert r1813240, which failed the integration test with org.apache.poi.stress.XSSFFileHandler on test-data/spreadsheet/59025.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813243 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-24 23:44:21 +00:00 |
|
Javen O'Neal
|
87d9019713
|
bug 61630: further XSSFExportToXML performance improvements from Daniel (comment 9, bug 61630 attachment 35450)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813240 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-24 23:00:12 +00:00 |
|
PJ Fanning
|
95828710f1
|
Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813102 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-23 21:17:49 +00:00 |
|
PJ Fanning
|
af2813634b
|
Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813092 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-23 20:39:27 +00:00 |
|
PJ Fanning
|
6c0ac68e05
|
Remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813085 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-23 20:27:47 +00:00 |
|
PJ Fanning
|
245d9b3b7f
|
Introduce new BorderFormatting methods to expose border styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812917 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-22 13:53:42 +00:00 |
|
PJ Fanning
|
26cc1e4d32
|
Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812911 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-22 13:03:33 +00:00 |
|
PJ Fanning
|
1ea1a692e0
|
Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812907 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-22 12:45:35 +00:00 |
|
PJ Fanning
|
dfd5f07079
|
Remove use of deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812901 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-22 12:07:14 +00:00 |
|
Dominik Stadler
|
5d5ba1c767
|
Add getter/setter for ReadingOrder to XSSF, closes issue #73
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812558 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 18:26:41 +00:00 |
|
Nick Burch
|
68104817ec
|
Bump up the Eclipse JVM version to 8 to match Ant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812557 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 18:21:29 +00:00 |
|
Nick Burch
|
eb9f7bcbea
|
Bump up the Eclipse JVM version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812556 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 18:16:48 +00:00 |
|
Javen O'Neal
|
79975dcfce
|
bug 61630: performance improvements in XSSFExportToXml. Thanks to Daniel for the patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812546 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 16:04:06 +00:00 |
|
Javen O'Neal
|
22e4bc2399
|
cleanup for r1812470: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812532 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:40:56 +00:00 |
|
Javen O'Neal
|
49add35f3b
|
fix compile error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812531 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:40:05 +00:00 |
|
Javen O'Neal
|
42c4e4909c
|
cleanup for r1812475: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812520 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:29:56 +00:00 |
|
Javen O'Neal
|
fc2bcfae9a
|
cleanup for r1812476: avoid NPEs from string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812516 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 14:08:43 +00:00 |
|
Javen O'Neal
|
5fb4887907
|
replace "".equals(string) with string.isEmpty() to avoid null strings silently evaluating to false; most code should probably check string for null if it is not already
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812476 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:41:42 +00:00 |
|
Javen O'Neal
|
aba704b928
|
prefer literal.equals(variable) over variable.equals(literal)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812475 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:41:25 +00:00 |
|
Javen O'Neal
|
3a2ee5f4d1
|
convert "".equals(string) to string.isEmpty()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812470 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:22:51 +00:00 |
|
Javen O'Neal
|
21b65721e7
|
simplfy PackagingURIHelper#combine boolean logic using xor and replacing +FORWARD_SLASH_CHAR with FORWARD_SLASH_STRING
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812468 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 08:10:36 +00:00 |
|
Javen O'Neal
|
afa5be82d3
|
fix typo
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812464 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:47:25 +00:00 |
|
Javen O'Neal
|
cfac692a6a
|
string.equals("") -> string.isEmpty() or "".equals(string)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812463 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:45:53 +00:00 |
|
Javen O'Neal
|
36dcbd7403
|
for -> foreach
string.equals() -> string.isEmpty() or .equals(string)
ArrayList -> List
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812461 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-18 07:33:07 +00:00 |
|
Javen O'Neal
|
bcbadce32e
|
IntelliJ: simplify boolean logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812363 13f79535-47bb-0310-9956-ffa450edef68
|
2017-10-17 07:43:41 +00:00 |
|