Commit Graph

9359 Commits

Author SHA1 Message Date
Dominik Stadler
d4e89724c7 Update some tests and IntelliJ warnings
Ignore disabled test instead of not listing it in the test-report at all

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819768 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 14:38:58 +00:00
PJ Fanning
d10ec59751 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819766 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 13:05:31 +00:00
PJ Fanning
272e33e4a8 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819763 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 12:23:06 +00:00
PJ Fanning
822608f1a6 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819762 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 12:13:53 +00:00
PJ Fanning
ef89809723 Bug-61947 add back deprecated methods (removed by accident)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819761 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:54:01 +00:00
PJ Fanning
0f390dab17 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819759 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:47:53 +00:00
PJ Fanning
186736ce11 Bug-61947 remove deprecated method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819758 13f79535-47bb-0310-9956-ffa450edef68
2018-01-01 11:42:43 +00:00
Andreas Beeker
95bbbe5678 #61797 - Embed Excel / Ole objects into powerpoint
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819710 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 01:14:08 +00:00
Andreas Beeker
45c73e1741 #61943 - SL Common: narrow generics definition because of tighter java9 checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819709 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 01:05:59 +00:00
Andreas Beeker
2a18d2d4db #61942 - Refactor PackagePartName handling and add getUnusedPartIndex method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819708 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:56:07 +00:00
Andreas Beeker
2dc2933f9a #61941 - Move Ole marker generation to Ole10Native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819706 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:22:43 +00:00
Andreas Beeker
7d3876cf12 #61940 - Replace ClassID statics with enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819705 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:13:38 +00:00
Andreas Beeker
4073f568cd #61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819704 13f79535-47bb-0310-9956-ffa450edef68
2017-12-31 00:01:04 +00:00
Andreas Beeker
e262b250d7 #61939 - Provide schema for AlternateContent - provide new ooxml-schemas-1.4.jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819690 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 22:17:55 +00:00
Yegor Kozlov
ca7549131b Bug 58106: when a cell with a 'master' shared formula is removed, the next cell in the range becomes the master
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 16:34:57 +00:00
Yegor Kozlov
ff6f06cc27 Bugzilla 61116: Formula evaluation fails when using matrix addition within index function call
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819596 13f79535-47bb-0310-9956-ffa450edef68
2017-12-30 13:11:56 +00:00
Dominik Stadler
24c2b4fabe Disable test which currently breaks with every little change to the resulting XML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819424 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 13:46:00 +00:00
Dominik Stadler
7a50340cbf Bug 61665: Enhance SSPerformanceTest some more to add a warmup run and allow to run with unsynchronized XmlBeans
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819417 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 10:53:40 +00:00
Dominik Stadler
9eb8fedf5d Fix bug 61787, which was introduced by bug 58067: Change how deleted content is detected to not incorrectly see too much text as deleted.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819405 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:51 +00:00
Dominik Stadler
451c26874a Bug 61798: Fix usage of getLastCellNum(), unfortunately this is a bit misleading compared to getFirstCellNum()...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819404 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:43 +00:00
Dominik Stadler
eb8fac4f77 Bug 61911: Avoid IndexOutOfBounds access when reading pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819403 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:36 +00:00
Dominik Stadler
822188c49a Fix IntelliJ warnings and code formatting, generalize ExcelToHtmlUtils, use try-with-resources, update/enhance JavaDoc somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819402 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:45:26 +00:00
Greg Woolsey
31ae97e748 Added a couple missing null checks.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819398 13f79535-47bb-0310-9956-ffa450edef68
2017-12-28 08:17:33 +00:00
Greg Woolsey
a7a3293fb9 Implement DMAX and DSUM functions, following the pattern from DMIN.
Refactored the D* function enum to have instances return the function implementation instances rather than using a case construct, now that Java 8 is required.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819376 13f79535-47bb-0310-9956-ffa450edef68
2017-12-27 22:33:03 +00:00
PJ Fanning
50c0ba01c6 Remove misleading SXSSF logging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1819282 13f79535-47bb-0310-9956-ffa450edef68
2017-12-26 11:02:45 +00:00
Yegor Kozlov
64d98e7872 Bug 61869: updating a cell with shared formula produces an unreadable file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818818 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 16:30:13 +00:00
PJ Fanning
12f82dd617 use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818786 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 12:15:35 +00:00
PJ Fanning
7cdaeba856 use try with resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818781 13f79535-47bb-0310-9956-ffa450edef68
2017-12-20 11:47:52 +00:00
PJ Fanning
57dcaedde7 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818629 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:33:16 +00:00
PJ Fanning
bfff3c7bd8 use StandardCharsets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818628 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 00:23:52 +00:00
PJ Fanning
af11cb1023 use non deprecated method for adding string to shared strings table
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818623 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 20:54:39 +00:00
Yegor Kozlov
1ccc7bfd46 Bug 61859: support for evaluating comparison operators in array mode, detect array mode from formula ptgs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818587 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 15:54:50 +00:00
PJ Fanning
9ab4245730 Bug-61906 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818248 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:13:16 +00:00
PJ Fanning
e34387b2cf Bug-61906 add API for working with RichStringText and deprecate API methods that use CTRst
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 09:09:50 +00:00
PJ Fanning
b3e2c19784 Bug-61792 simplify sxssf code that writes chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1818223 13f79535-47bb-0310-9956-ffa450edef68
2017-12-15 00:54:52 +00:00
Javen O'Neal
525952b625 delete commented out code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817976 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:39:01 +00:00
Javen O'Neal
5530f8a831 bug 57423: add unit test demonstrating corrupted workbook where CTRow xmlbeans are not in ascending order in the CTWorksheet; unit test adapted from Luca
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817975 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 06:21:19 +00:00
Nick Burch
8498e4d88c #61765 Another HSSF Workbook name found from (unknown) third party software produced files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817812 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 19:52:53 +00:00
Greg Woolsey
08e25fe46e Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817797 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:33:00 +00:00
Greg Woolsey
11e60eb77e Bug 61882 - Some paths can create an XSSFColor instance with a null CTColor reference
Protect against this in the future by introducing a factory method to create XSSFColor instances from a CTColor instance and the associated workbook style indexed color map.

If the CTColor instance is null, the factory returns null.  All callers already are prepared for a null instance, but many had their own null check on the CTColor object.  This centralizes that.

This also further forces the requirement for the indexed color map.  Any time a color is created, the workbook or styleTable is available in the same context, so passing this is extra parameter is trivial and allows XSSFColor to properly reference custom/themed indexed colors.

Did not remove any methods yet, only deprecated them.  Changed the signature to one internal test-only constructor.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817796 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 17:30:04 +00:00
Andreas Beeker
185a66aed5 remove package name to ease the output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817600 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 12:06:59 +00:00
Andreas Beeker
2c2028ede6 #61881 - handle invalid font names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817599 13f79535-47bb-0310-9956-ffa450edef68
2017-12-09 11:44:19 +00:00
Greg Woolsey
41981a4ac9 #61841
Add @Override annotations, clean up imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817331 13f79535-47bb-0310-9956-ffa450edef68
2017-12-07 01:54:21 +00:00
Greg Woolsey
cbd17b9320 #61841 fix typo in method name
Fixing the typo pointed out by PJ Fanning, thanks for the proof read!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817325 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 23:53:25 +00:00
Greg Woolsey
94c2b64692 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
always with the missing license...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817254 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:46:42 +00:00
Greg Woolsey
6390202491 Bug #61841 - Unnecessary long computation when evaluating VLOOKUP on all column reference
Found some optimizations in the general evaluation framework related to blank cells in rows beyond the last defined row of a sheet.

I don't see any issue with passing a bit of context down deeper into this framework, as it's all POI-internal and only had one calling path.

See the above bug for the performance analysis.  Not specifically related to VLOOKUP, but improves that case by more than 2/3 as well.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817252 13f79535-47bb-0310-9956-ffa450edef68
2017-12-06 00:15:51 +00:00
PJ Fanning
5f4f1b5846 use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817247 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 22:31:59 +00:00
PJ Fanning
89a788ea5b use try-with-resources in more places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1817238 13f79535-47bb-0310-9956-ffa450edef68
2017-12-05 21:23:44 +00:00
Javen O'Neal
58114c6d8c bug 61840: close workbook to prevent resource leak in unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816893 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:51:19 +00:00
Javen O'Neal
79250e916f bug 61840: add unit test showing that shiftRows does not produce #REF! formula errors if cells are not shifted above the first row
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816892 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 17:47:29 +00:00