Commit Graph

1666 Commits

Author SHA1 Message Date
Andreas Beeker 457100c358 Bug 60320 - issue opening password protected xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767399 13f79535-47bb-0310-9956-ffa450edef68
2016-11-01 01:30:48 +00:00
Tim Allison 2633894b39 60293 -- Handle illegal "Odd" header/footer in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767353 13f79535-47bb-0310-9956-ffa450edef68
2016-10-31 19:02:06 +00:00
Mark Murphy 14babbb970 57366: XWPFTable to Header / Footer
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=57366

This update contains a breaking change

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767175 13f79535-47bb-0310-9956-ffa450edef68
2016-10-30 18:49:16 +00:00
Dominik Stadler ca4a7d2f27 Bug 53611: populate dimension of XSSF Worksheet when writing the document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767096 13f79535-47bb-0310-9956-ffa450edef68
2016-10-29 07:38:46 +00:00
Dominik Stadler d47fff6e1c Bug 59026: Add two null-checks to make exporting XLSX to XML work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767057 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 18:24:04 +00:00
Tim Allison 1cdf883548 60315 -- allow 'yyyy-MM-dd' as a valid date format in metadata in OPCParser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767026 13f79535-47bb-0310-9956-ffa450edef68
2016-10-28 14:11:52 +00:00
Andreas Beeker 51b4f2a365 fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766747 13f79535-47bb-0310-9956-ffa450edef68
2016-10-26 22:37:34 +00:00
Andreas Beeker 2c086c590e Bug 60059 - Deprecate xslf.usermodel.Drawing* - was: Can't change text of DrawingParagraph
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766746 13f79535-47bb-0310-9956-ffa450edef68
2016-10-26 22:32:46 +00:00
Dominik Stadler 3f91e44380 Bug 60289: Fix handling of unicode escapes with lowercase hex-chars
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766065 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 16:31:51 +00:00
Javen O'Neal 359820ba80 bug 60288: remove defensive copy for internal relationships. Patch from Tim Helmstedt. This closes #38.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765935 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 07:29:40 +00:00
Tim Allison e9b4a17d77 BUG-60286 avoid NPE XWPFRun. Didn't add unit test or document...didn't seem to be worth it.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765863 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:58:47 +00:00
Tim Allison 9c455cb5c9 BUG-60285 avoid NPE if missing relationship id
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765861 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:45:03 +00:00
Andreas Beeker 3ac60f4bcc Bug 55714 - Background image ignored on slide copy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765733 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:25:51 +00:00
Javen O'Neal 425e04b4a4 add @Override decorators to SheetIterator, move code outside of for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765556 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:38:19 +00:00
Javen O'Neal 3ac3f37cbe bug 60255: use actual number of package parts rather than hard-coding an upper-bound
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765546 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:47:07 +00:00
Javen O'Neal eada340cbd make code more similar between default case and indexed case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765536 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 06:44:09 +00:00
Nick Burch bff698c938 #60255 When creating a XSSF drawing, find the next available document part, even if another type has pinched the next number
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764863 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:44:03 +00:00
Javen O'Neal 1e5dc11721 bug 56781,60246: fix named range validation to match valid name rules per Excel docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:11:23 +00:00
Javen O'Neal 999c6499ec bug 60253: add helper functions to make the constructor formula1-overloading code simpler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764831 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 08:09:39 +00:00
Javen O'Neal ee6b1e741d bug 60253: remove repeated check for ValidationType.ANY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764823 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:07:15 +00:00
Javen O'Neal 489f632288 bug 60253: revert XSSFDataValidationConstraint#prettyPrint QUOTE change in r1749129
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764822 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 07:04:27 +00:00
Javen O'Neal cdd3a4f0df make cached fields transient
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764809 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 05:13:47 +00:00
Mark Murphy 37f9122633 53009: Problem creating header and footer
Task-Url: https://bz.apache.org/bugzilla/show_bug.cgi?id=53009

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764563 13f79535-47bb-0310-9956-ffa450edef68
2016-10-13 01:13:45 +00:00
Javen O'Neal 02b3019f6c bug 60153: patch from PJ Fanning to demonstrate that SXSSFWorkbook SheetDataWriter can write encrypted temporary files to disk and the workbook can be AES encrypted when written to disk for a fully secure disk environment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763969 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:58:46 +00:00
Javen O'Neal db53120ab3 fix findbugs warning BC_VACUOUS_INSTANCEOF from bug 55075
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763965 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 12:15:39 +00:00
Javen O'Neal 370aa27bf2 bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:59:34 +00:00
Javen O'Neal 63da9f8d19 bug 60153: findbugs OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE close opened streams if an exception is raised while decorating the stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763959 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:51:13 +00:00
Javen O'Neal 6426f4d19e bug 55075: remove wildcard import; previous commit contributed by Frank Ploessel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763951 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:13:06 +00:00
Javen O'Neal 61f00a509f bug 55075,51233: create drawings with correct height when rows are custom height
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763950 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:02:36 +00:00
Javen O'Neal 3e4da0cd75 bug 60153: encrypt SXSSF temporary files; patch from PJ Fanning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763943 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 04:43:14 +00:00
Javen O'Neal dd1ed5b840 bug 60197: Workbook#setSheetOrder should update named range sheet indices
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 03:02:13 +00:00
Andreas Beeker cb03495d36 Bug 60226 - ClassLoader workaround for OSGI when processing OOXML files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763922 13f79535-47bb-0310-9956-ffa450edef68
2016-10-08 17:07:15 +00:00
Javen O'Neal 5b8cbb0143 bug 60216: javadocx fix for Comment#isVisible and Comment#setVisible; patch from Daniel Kueppers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763757 13f79535-47bb-0310-9956-ffa450edef68
2016-10-07 12:39:15 +00:00
Dominik Stadler 94859c032c Bug 59958: Add simple test-case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763487 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 20:13:38 +00:00
Dominik Stadler cdef5dc16c Use IOUtils.closeQuietly() in more places
Avoid two possible file-handle leaks when opening files fails with an exception
Make tests close resources properly to not spam the output when running with file-leak-detector

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763485 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 20:00:07 +00:00
Dominik Stadler 2bfa5a50de Print out size of extracted text in CommandLineExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763483 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:50 +00:00
Andreas Beeker d8767e1c70 Bug 59857 - Password protected files with "Microsoft Enhanced Cryptographic Provider v1.0"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762726 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 23:36:09 +00:00
Andreas Beeker 0a7cd3b68b merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 21:01:40 +00:00
Javen O'Neal 596bba0962 bug 59687: correctly delete comments from rows when removing a row and the workbook contains empty rows above the deleted row; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761861 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 07:50:33 +00:00
Javen O'Neal e9a16f2c5e fix NPE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761844 13f79535-47bb-0310-9956-ffa450edef68
2016-09-22 04:02:56 +00:00
Dominik Stadler 7e9cc96c46 Compiler/IDE warnings, unnecessary keywords,
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:45:57 +00:00
Javen O'Neal cbeddd0d11 bug 59983: add failing unit test demonstrating formula shifting is apply twice to shared formulas; patch from Luca Martini
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761673 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:20:36 +00:00
Javen O'Neal 4e864476c6 bug 60153: move flushSheets out to its own method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761668 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 03:31:15 +00:00
Javen O'Neal 29128d019d javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761664 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 02:43:55 +00:00
Javen O'Neal a4c3ce29ea bug 59853: exclude BaseTestXSSFPivotTable from ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761545 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 09:59:01 +00:00
Javen O'Neal 676ca76fd9 bug 59853: support PivotTables with named structured references; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761537 13f79535-47bb-0310-9956-ffa450edef68
2016-09-20 07:55:13 +00:00
Andreas Beeker cda4f20482 merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
2016-09-19 00:20:44 +00:00
Javen O'Neal 008a26d1bf bug 59705: consolidate bounds checking of column index into a helper method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760986 13f79535-47bb-0310-9956-ffa450edef68
2016-09-16 00:32:40 +00:00
Javen O'Neal 5b79b4da90 sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760814 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 22:43:08 +00:00
Javen O'Neal 1de973e2a7 declare methods throw runtime exceptions for IDE hints
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760798 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 21:44:06 +00:00
Javen O'Neal 03b5dc68eb bug 60128: remove forbidden-api Exception.printStackTrace()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760744 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 19:24:49 +00:00
Javen O'Neal 97b94f5dcd javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760733 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:25:03 +00:00
Javen O'Neal 753ca9b811 bug 60128: make code Java 6 compatible. Throwable#addSuppressed not available until Java 7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760732 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 17:21:31 +00:00
Javen O'Neal 6ed8aaada6 make logger final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760711 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:56:03 +00:00
Javen O'Neal 2104b1d585 bug 60128: close opened resources to avoid leaks; add exception as cause where available for more context for raised exceptions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760710 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:55:39 +00:00
Javen O'Neal d34b6a995b give more helpful exceptions rather than returning null when zip file cannot be opened
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760708 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 13:28:27 +00:00
Javen O'Neal ed5cd06fb7 bug 60128: close open file descriptors when exceptions are thrown from OPCPackage.open
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:57:39 +00:00
Nick Burch 6219cc6664 Unit test for bug #60128, showing that calling close on a broken package cleans up file or stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760693 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 12:35:34 +00:00
Javen O'Neal ed7258906f move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:53:58 +00:00
Javen O'Neal 8842d7bffd move BaseXSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) and HSSFFormulaEvaluator#evaluateFormulaCellEnum(Cell) up to BaseFormulaEvaluator class to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760647 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 07:33:20 +00:00
Javen O'Neal f71ae8036d bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760641 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 06:42:20 +00:00
Javen O'Neal 9a11b0ffd5 bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:51:52 +00:00
Javen O'Neal 430ea9abfd bug 58190: add @since annotations to SlideShow.addPicture and findPicture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760633 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:41:40 +00:00
Javen O'Neal 38cd94d676 bug 59264: revert CellStyle#getBorder[Top|Bottom|Left|Right]() to return short and add getBorder[Top|Bottom|Left|Right]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760630 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:22:23 +00:00
Javen O'Neal 292d7ec27c bug 59264: revert getBorder[Top|Bottom|Left|Right|Diagonal]() to return short and add getBorder[Top|Bottom|Left|Right|Diagonal]Enum() returns BorderStyle enum for backwards compatibility with POI 3.14 and earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760627 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 04:35:45 +00:00
Javen O'Neal 5d1ae2cbae bug 59833: add @Removal annotation to deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760623 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:33:52 +00:00
Javen O'Neal 808996a683 bug 59873: add @Removal annotations for deprecated CreationHelper#createHyperlink(int) and Hyperlink static aliases to HyperlinkType enum values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760621 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 03:17:51 +00:00
Javen O'Neal 9ea5915313 bug 59907: add @Removal annotations to deprecated ClientAnchor#setAnchorType(int)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760619 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:55:52 +00:00
Javen O'Neal 0977e51818 bug 59907: restore ClientAnchor#setAnchorType(int) that was removed in POI 3.14 beta 1 and broke backwards compatibility without a 2 release deprecation notice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760617 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 02:41:01 +00:00
Javen O'Neal 3c97d9700a change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
2016-09-13 23:24:56 +00:00
Javen O'Neal abe46f40ed bug 52425: Error adding Comments into cloned Sheets; patch from Daniel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760221 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 04:05:42 +00:00
Javen O'Neal 5409095923 bug 58191: Support merge cells within a table row; patch from Mark Olesen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760217 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 03:21:33 +00:00
Javen O'Neal 6146860a5e bug 59958: Add cells on the fly to the evaluation sheet cache on cache miss; patch from Tomasz Stanczak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760213 13f79535-47bb-0310-9956-ffa450edef68
2016-09-11 02:02:56 +00:00
Javen O'Neal d9cfcbdd18 bug 60102: throw IOException when writing a closed document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760206 13f79535-47bb-0310-9956-ffa450edef68
2016-09-10 19:33:32 +00:00
Andreas Beeker 71db60b890 merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756967 13f79535-47bb-0310-9956-ffa450edef68
2016-08-19 20:57:56 +00:00
Javen O'Neal 139319ac73 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756398 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 16:08:11 +00:00
Javen O'Neal 779c0e527a bug 60005: fix NPE in XSLFTextParagraph.getDefaultFontSize()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1756397 13f79535-47bb-0310-9956-ffa450edef68
2016-08-15 16:05:32 +00:00
Andreas Beeker 680683cf77 merge down trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 01:14:36 +00:00
Andreas Beeker c4ac2e7758 Preparations for hssf_cryptoapi:
- Add cloneable
- Change existing hslf cryptoapi to streaming


git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755127 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 23:54:01 +00:00
Nick Burch a1f6d9c832 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:53:43 +00:00
Javen O'Neal fcb22a8a5e bug 59922: rename XSSFPaswordHelper to XSSFPasswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754786 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:20:43 +00:00
Javen O'Neal ca31684a27 bug 59922: make XSSFPasswordHelper internal because it works on XmlObject objects, which are generally an internal implementation detail of POI-OOXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754785 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:03:36 +00:00
Javen O'Neal 66d7d4ddaa whitespace; +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754784 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 18:01:24 +00:00
David North 984683ab4b Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 12:51:24 +00:00
Dominik Stadler 5e0612eabd IDE warnings and fix a few places where we do not close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754673 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:17 +00:00
Nick Burch dfcf57bfbf Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754530 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 14:03:28 +00:00
David North e5877bd8e0 Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
Dominik Stadler fa24949520 Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
2016-07-27 18:15:54 +00:00
Dominik Stadler a86686846b Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Dominik Stadler da595c2343 Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Javen O'Neal 9ee14c5508 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:25:37 +00:00
Javen O'Neal d9f3df34de bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:25:02 +00:00
Javen O'Neal 7637cdc080 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:48:36 +00:00
Javen O'Neal 4d33ceffb1 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753042 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:44:26 +00:00
Javen O'Neal 2944b7a7a8 bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:42:13 +00:00
Javen O'Neal c44094c04e bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:20:21 +00:00
Javen O'Neal 0025b16e3e add cause to exceptions, log exceptions that are caught and suppressed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753030 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:41:52 +00:00
Javen O'Neal 1cf76af9e8 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753028 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 08:26:51 +00:00
Javen O'Neal f296b55b36 add @Override annotations to CreationHelper classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:14:49 +00:00
Javen O'Neal 4a8e7c393d throw exception if hyperlink is invalid type when validating hyperlink
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753016 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 06:04:56 +00:00
Javen O'Neal 14472c1def bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:47:03 +00:00
Javen O'Neal 285bedac9e bug 59775: correctly create XSSFHyperlinks when target is a URL containing a hash mark; patch contributed by Guillermo Alvarez
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753013 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:43:03 +00:00
Javen O'Neal 44199a8ecd bug 59872: add Sheet.getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Andreas Beeker 11fe2eda86 #59841 - OOXML: enable custom zip streams via OPCPackage.open(ZipEntrySource)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753003 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 00:14:06 +00:00
Dominik Stadler af2a99b910 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Dominik Stadler 52bf709104 Add a test to check for a NullPointerException in XSLFTableCell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752862 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:11 +00:00
Javen O'Neal 9d8b7b33db JDK8 javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752812 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 10:13:58 +00:00
Javen O'Neal 0c3aade7b1 JDK8 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752781 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:35:21 +00:00
Nick Burch 439fc2e92d Remove un-used imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 23:00:40 +00:00
Nick Burch 7179c813e6 Start moving logic over into the main and scratchpad jars for OLE2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:47:02 +00:00
Nick Burch f94e7e761b Notes on use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 22:17:34 +00:00
Javen O'Neal 0f8039f3ab bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 08:29:02 +00:00
Javen O'Neal ba1e2c8b14 Add comments describing Outlook .msg DirectoryNode names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:41:15 +00:00
Javen O'Neal fbf2d524f9 move string literals out to array that can be for-looped over
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 01:29:30 +00:00
Javen O'Neal a6f5ef09ef bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 22:28:28 +00:00
Javen O'Neal 9c00c18f38 bug 56154: rename setLastModifiedBy to setLastModifiedByUser
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:05:02 +00:00
Javen O'Neal ed4ae3fff0 bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:59:01 +00:00
Javen O'Neal 182c1415f5 bug 56154: get and set last modified by user property; patch from Danil Lopatin
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 17:56:54 +00:00
Javen O'Neal 92c2fa753d add crude unit test for ZipPackagePropertiesMarshaller
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 09:10:03 +00:00
Javen O'Neal 4c72ddaba1 add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:20:34 +00:00
Javen O'Neal 38c052cca1 add @Override annotations to spreadsheet formula Evaluation classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 22:27:32 +00:00
Javen O'Neal 9539c626a9 bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 22:22:10 +00:00
Javen O'Neal 6f566fca27 whitespace; +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751744 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:27:13 +00:00
Javen O'Neal 81f13bb621 Findbugs-JDK8: log ignored exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751743 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:25:42 +00:00
Javen O'Neal 56d11479de bug 50795: move hack to avoid xmlbeans corrupt pointer to its own function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751742 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:19:02 +00:00
Javen O'Neal b37fde6d96 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 23:26:32 +00:00
Javen O'Neal 93f1f4b027 bug 59804: indicate when features were @Internal-ized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 23:22:49 +00:00
Nick Burch 90e4babfc1 #59780 OPC support for a wider range of timezone'd created and modified date formats in package properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751379 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 20:55:07 +00:00
Javen O'Neal 24faa602e0 bug 59796: XSSFTable#getRowCount off-by-one error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751373 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 19:09:10 +00:00
Javen O'Neal f0f37b58ed pre for-each iteration over for index iteration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751369 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:43:45 +00:00
Javen O'Neal 31efeb44b7 bug 59795: add method to synchronize start and stop cell references with CTTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751368 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 18:25:00 +00:00
Javen O'Neal be49e0c5a7 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 13:09:30 +00:00
Javen O'Neal 03671fea80 bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:35:49 +00:00
Javen O'Neal 268c5deeb2 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal 034d3cfcca bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal fba65665fb reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal 64ef8e26a3 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal d1d6ea97fb bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal 8df4c77647 bug 59790: convert FormulaType class to enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 05:37:06 +00:00
Andreas Beeker 6899a1ad95 javadocs fixes (jdk8)
(eclipse) source clean ups

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751165 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 18:25:05 +00:00
Javen O'Neal 33cf815199 bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 07:20:47 +00:00
Andreas Beeker 76c479ce28 javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751106 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 23:08:07 +00:00
Javen O'Neal 73fcbfdb68 bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751086 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 18:28:43 +00:00
Javen O'Neal 4ab0e89901 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Javen O'Neal b11ee3f7da don't shadow drawing field from XSSFShape in XSSFGraphicFrame
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:40:50 +00:00
Javen O'Neal ac84cdb773 findbugs: remove implements Cloneable declaration from classes that don't implement a clone method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 08:30:34 +00:00
Javen O'Neal 4dd2ff6c7c findbugs REC_CATCH_EXCEPTION: catch specific exception types and include more helpful reason rather than catching all Exceptions with one misleading reason
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751023 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:11:01 +00:00
Javen O'Neal e7ef961359 +svn:eol-style=native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751022 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 05:01:43 +00:00
Andreas Beeker c985706686 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751007 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 21:10:40 +00:00
Javen O'Neal b2f4150b06 bug 59776: don't swallow cause of exception in ZipPackagePropertiesMashaller exception handling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750893 13f79535-47bb-0310-9956-ffa450edef68
2016-07-01 09:14:41 +00:00