Commit Graph

6930 Commits

Author SHA1 Message Date
Javen O'Neal
44c5423be4 add unit test for bug 58779 when the problem gets fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722091 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 10:40:20 +00:00
Javen O'Neal
dba7fcdd4e junit3 -> junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722081 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 09:54:59 +00:00
Javen O'Neal
5310fc4b6d revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722079 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 09:28:32 +00:00
Javen O'Neal
6bc5c33c10 revert, not close, XSSFWorkbooks created by WorkbookFactory in order to avoid modifying SampleSS.xlsx (this bug will be addressed in a future commit). Since r1721468
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722078 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 09:21:17 +00:00
Javen O'Neal
5ab2c61a3f make spreadsheet file names static final rather than initializing them with setUp()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722073 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 08:53:46 +00:00
Javen O'Neal
7980a6b457 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722070 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 07:38:31 +00:00
Javen O'Neal
eb5bca1612 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722057 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 06:55:22 +00:00
Javen O'Neal
ef26a1d15c bug 58775: set an upper limit on number of data formats, default 250.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722054 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 05:46:20 +00:00
Javen O'Neal
70f08e1fc5 fix javadocs warnings for r1721930 (bug 58775)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 02:57:58 +00:00
Javen O'Neal
22b03ba71b convert junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722048 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 01:26:55 +00:00
Javen O'Neal
1dd49eff7c whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722047 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 01:18:16 +00:00
Andreas Beeker
a89d5210c3 WMF fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722046 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 00:45:59 +00:00
Javen O'Neal
ae1020ac35 bug 58778: override a built-in number format, such as using £ instead of $ for currency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722043 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 00:12:04 +00:00
Javen O'Neal
bf5e95d37a bug 58740: javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721942 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 16:04:47 +00:00
Javen O'Neal
a50f45e4c2 bug 58775: use short for data format index, int for cell style index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:50:54 +00:00
Javen O'Neal
0404c61acc bug 58775: consolidate HashMap and array numberFormats data structures to one SortedMap data structure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721928 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:37:23 +00:00
Javen O'Neal
8f47967d55 write for loop for performance and readability
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721924 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:20:30 +00:00
Javen O'Neal
0849d8c34a bug 58775: fix a>b which should be a>=b; use shorts instead of ints to hold number format index
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721923 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:19:50 +00:00
Javen O'Neal
f3c14d82a6 simplify bug 57880 test case:
remove unrelated DataFormat code (not worried about wrap-around here since Excel supports up to 250 data formats and we're using the short data type)
replace complex write-out, close, read-back, delete code with new better test apparatus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721922 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:03:52 +00:00
Javen O'Neal
934effd443 add convenience methods for writing and reading back XSSFWorkbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721920 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 13:44:08 +00:00
Javen O'Neal
3204cedf28 bug 58775: use assertNotBuiltInFormat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721902 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 12:13:17 +00:00
Javen O'Neal
0ef05fcdab java docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721901 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 12:11:13 +00:00
Javen O'Neal
9bdfcc4be6 bug 58775: add unit test to test for non-built-in data formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721900 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 12:10:12 +00:00
Javen O'Neal
8a7cd6308e bug 58775: add Override annotations, Javadocs, and comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721880 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 07:56:54 +00:00
Javen O'Neal
a94df00797 make HSSFCellStyle attributes final, add Override decorators on all methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721876 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 05:43:11 +00:00
Javen O'Neal
ec4732a034 bug 58740: add @Internal annotations and decrease access level to methods that only exist for unit testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721864 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 00:52:47 +00:00
Javen O'Neal
19e5db9602 bug 58740: return unmodifiable list/map when exposing internal data structures
patch from Archie Cobbs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721857 13f79535-47bb-0310-9956-ffa450edef68
2015-12-27 23:17:33 +00:00
Dominik Stadler
d89168fa51 Fix compiling unit-test after previous changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721471 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:48:31 +00:00
Dominik Stadler
a021bc780b Fix some cases where file resources were not closed correctly, mostly when Exceptions occur during opening files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721470 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:36:43 +00:00
Dominik Stadler
c9dee45744 fix commandline option in PPTX2PNG from quite to quiet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721469 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:36:33 +00:00
Dominik Stadler
0a3370347e Fix freeing resources in some tests and dev-tools so we can run unit-tests with enabled file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721468 13f79535-47bb-0310-9956-ffa450edef68
2015-12-22 22:35:59 +00:00
Andreas Beeker
b333ed457d #56004 - Support for WMF rendering (parsing the WMF records)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721078 13f79535-47bb-0310-9956-ffa450edef68
2015-12-21 01:26:39 +00:00
Dominik Stadler
b69c64fe21 Handle some cases better where file handles were left open by the ExtractorFactory, mostly when opening files failed, but also when using the NPOIFSFileSystem for initialization.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721064 13f79535-47bb-0310-9956-ffa450edef68
2015-12-20 20:39:01 +00:00
Andreas Beeker
99f6175e97 rat-check - remove clutter to compact build output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721043 13f79535-47bb-0310-9956-ffa450edef68
2015-12-20 17:01:46 +00:00
Nick Burch
355810fb9f Unit test for non-reproducable #58747
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720588 13f79535-47bb-0310-9956-ffa450edef68
2015-12-17 15:05:06 +00:00
Dominik Stadler
ffe36ac2fe Fix unit test for bug 58731 to actually run
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720534 13f79535-47bb-0310-9956-ffa450edef68
2015-12-17 12:39:01 +00:00
David North
9e0601a058 Trunk now heading for beta2 again, unpin docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720438 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 20:21:30 +00:00
David North
5e1efe1708 Pin docs external for 3.14 beta1 rc2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720435 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 20:19:46 +00:00
David North
807bf16cee About to roll 3.14 beta1 rc2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720434 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 20:17:22 +00:00
Nick Burch
1fbfc70cca Unit test for #58731 - not reproduced, and some javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720411 13f79535-47bb-0310-9956-ffa450edef68
2015-12-16 18:15:31 +00:00
Andreas Beeker
7b4c17b70c #58733 - New AIOOBE in getCell while iterating through a table in PPT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1720035 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 22:49:04 +00:00
Andreas Beeker
3e8b58e356 fix forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 09:51:22 +00:00
Andreas Beeker
ad89fdcaf5 #58718 - Master styles not initialized when running multithreaded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719758 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 01:50:24 +00:00
David North
8c491bfb7a Multisign update to allow gpg2 usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718483 13f79535-47bb-0310-9956-ffa450edef68
2015-12-07 22:21:05 +00:00
David North
a18fc56822 Trunk is now on course for 3.14beta2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718468 13f79535-47bb-0310-9956-ffa450edef68
2015-12-07 21:13:59 +00:00
David North
a890226558 Pin documentation to r1718465 for 3.14beta1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718466 13f79535-47bb-0310-9956-ffa450edef68
2015-12-07 21:10:00 +00:00
Javen O'Neal
4f8057e56f bug 57450: javadoc fixes from Stefan Thurnherr
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718226 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 21:43:26 +00:00
Javen O'Neal
5da709336c supporting change for bug 56454: SheetUtil.containsCell and CellRangeAddress.isInRange are equivalent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718221 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 21:11:38 +00:00
Javen O'Neal
dedb924183 bug 56454: shiftRows incorrectly handle merged regions that do not contain column 0. Add failing unit test from Jörg Selbach.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718217 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 20:51:54 +00:00
Javen O'Neal
37622ec57e make test easier to understand using A1 addresses instead of row+col numbers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1718216 13f79535-47bb-0310-9956-ffa450edef68
2015-12-06 20:43:27 +00:00