Commit Graph

7058 Commits

Author SHA1 Message Date
Andreas Beeker 41d693fe15 Regression fixes for H/XSLF and HWMF
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler 161ef55132 Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Dominik Stadler 2411273a57 Add xlsx which verifies via the integration-tests that the namespace fix works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732234 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:38:53 +00:00
Nick Burch d35942ca52 #59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:24:09 +00:00
Nick Burch 194fdfe162 Pull out two more XSSF namespace definitions as re-usable constants
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:16:54 +00:00
Nick Burch 094e3f68e6 Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68
2016-02-23 22:10:20 +00:00
Nick Burch c58e4fe96c Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 21:17:23 +00:00
Dominik Stadler 0f10be0ca4 One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:42:05 +00:00
Dominik Stadler 10f46da1ae Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Tim Allison bc716a2796 POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68
2016-02-19 15:46:26 +00:00
Javen O'Neal 2cab09db04 bug 58896: comment out time-dependent test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 17:53:13 +00:00
Nick Burch 20777db2e7 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 11:16:11 +00:00
Javen O'Neal 7bb1a1bb22 move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 04:05:45 +00:00
Javen O'Neal 57ebf6b133 bug 58896: add unit test to time Sheet.autoSizeColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 03:33:25 +00:00
Javen O'Neal 5e52b6f4e9 avoid redundant null check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 02:03:11 +00:00
Tim Allison 9e46ee937c 59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:49:59 +00:00
Javen O'Neal c80fa0c870 bug 56345: reject single-cell merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Dominik Stadler 5093542774 Add test which verifies that bug 52684 is not a problem (any more)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
2016-02-17 21:35:22 +00:00
Javen O'Neal 3cb72bfa7b bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Dominik Stadler 4aeff3f0ac Tried to reproduce bug 55476, but could not, added unit test anyway
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 19:16:45 +00:00
Nick Burch 86153c0ea6 Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00
Nick Burch 0982d9dee5 Start generalising the IgnoredErrorType code for later HSSF use too #56892
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:40:24 +00:00
Dominik Stadler 63a7f89342 No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 10:08:26 +00:00
Dominik Stadler 677b19afbd GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 09:26:51 +00:00
Dominik Stadler 98da5af350 Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 08:33:12 +00:00
Dominik Stadler 528a64dc76 Improve error messages to state which bounds are exceeded
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 07:41:47 +00:00
Dominik Stadler b01efb6855 Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:30:10 +00:00
Dominik Stadler c68a9e4c02 Regression analysis: the additional testing of cloning sheets showed a
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:46 +00:00
Dominik Stadler eeee511f71 Ignore a failure during cloning if we exceed file-format limits
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:23 +00:00
Dominik Stadler b6de146895 bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68
2016-02-12 09:44:47 +00:00
Nick Burch 118b728156 Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 15:13:40 +00:00
Nick Burch a3966df033 Allow common tests to do auto-sizing even on SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 15:13:01 +00:00
Andreas Beeker 2aa39f5bdb Add example for adding videos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68
2016-02-06 22:23:47 +00:00
Andreas Beeker ce22cc44c4 XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 22:03:44 +00:00
Dominik Stadler fb07d95b55 Remove file from expected failures after changes for bug 56880
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 07:51:35 +00:00
Tim Allison 827c3f562b Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68
2016-02-04 19:54:15 +00:00
Javen O'Neal 95e95dfabb remove deprecated (2009) HSSFComment#setColumn(short). int version is available.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:52:32 +00:00
Javen O'Neal 80c9b356c2 HSSFComment: note a final field
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:33:00 +00:00
Javen O'Neal dc860a6f93 fix O(n^2) runtime unnecessarily recreating an array inside a for-loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:14:55 +00:00
Javen O'Neal 6c89d062bf bug 58885: fix javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 04:04:56 +00:00
Javen O'Neal e365e9cbac bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 03:27:35 +00:00
Dominik Stadler a79dfd18e4 Adjust test to pass forbidden-apis-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68
2016-01-30 11:02:54 +00:00
Dominik Stadler 68997de5f0 Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 22:09:03 +00:00
Dominik Stadler d70d496f84 Add curvesapi-jar when running Findbugs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727652 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 22:08:55 +00:00
Nick Burch d5ad47658c Bump xmlsec version in the Eclipse project file too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726844 13f79535-47bb-0310-9956-ffa450edef68
2016-01-26 16:25:52 +00:00
Dominik Stadler f94bb63332 add an ignored test for bug 58804
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726681 13f79535-47bb-0310-9956-ffa450edef68
2016-01-25 20:21:30 +00:00
Andreas Beeker 183b2d774f Raised xmlsec version to 2.0.6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726528 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 18:36:56 +00:00
Andreas Beeker 5fad9af36f #41047 - Support hyperlinks in HSLF shapes and textruns
#47291 - Cannot open link correctly which insert in ppt

HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 00:12:10 +00:00
Dominik Stadler 6d56feee90 Update copyright-year to 2016
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725457 13f79535-47bb-0310-9956-ffa450edef68
2016-01-19 10:09:12 +00:00
Dominik Stadler 2ac89a2dc9 Rename test-source file to actual class name to avoid constant recompilations on 'compile-main'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725336 13f79535-47bb-0310-9956-ffa450edef68
2016-01-18 20:16:38 +00:00