Commit Graph

6217 Commits

Author SHA1 Message Date
David North
369c593380 Add explicit test for NPE only caught by other tests. Test '97 fallback behaviour generally.
https://bz.apache.org/bugzilla/show_bug.cgi?id=56328

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685104 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:29:20 +00:00
David North
16a9eca7c8 My own patch to fix #56328
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
2015-06-12 15:20:10 +00:00
David North
3b01cd9b10 Add my PGP key to the list.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1683317 13f79535-47bb-0310-9956-ffa450edef68
2015-06-03 13:09:20 +00:00
David North
c580758b2c Use a different arbitrary value for the ID of the comment shape type. This appears to prevent Excel >= 2010 from turning POI-written comments into the wrong shape (giant curved arrow).
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=55410

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1683315 13f79535-47bb-0310-9956-ffa450edef68
2015-06-03 12:50:10 +00:00
Dominik Stadler
d3f93952e9 Bug 53109: Correctly handle unicode strings in NameCommentRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682999 13f79535-47bb-0310-9956-ffa450edef68
2015-06-01 20:49:53 +00:00
Nick Burch
7915b3ce38 Patch from René Scheibe from bug #57512 - Fix potential NPE in DateUtil for invalid dates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682796 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 21:18:11 +00:00
Dominik Stadler
44821b1f39 Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682794 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 21:02:39 +00:00
Dominik Stadler
493511bbdc Bug 57904: Add full source build from dist-packages to CI builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682786 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 20:11:28 +00:00
Dominik Stadler
c49278ebac List more targets in help, make jar-src work standalone
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682785 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 20:11:20 +00:00
Dominik Stadler
82d1907584 Set version to 3.13-beta1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682784 13f79535-47bb-0310-9956-ffa450edef68
2015-05-31 20:10:08 +00:00
Tim Allison
ca17056096 POI-57975: clean up white spaces and other style issues in XWPF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682473 13f79535-47bb-0310-9956-ffa450edef68
2015-05-29 14:01:31 +00:00
Tim Allison
b8f9c0cad1 POI-57889 -- actually trigger inclusion of CTNumLvl with document contributed by Moritz Dorka on TIKA-1315
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682310 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 19:08:24 +00:00
Nick Burch
0da60bd78e Note on why ooxml needs scratchpad, for one part only
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682212 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:17:41 +00:00
Nick Burch
a727593a41 Correct package
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682210 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:15:07 +00:00
Nick Burch
c5c70d3ce4 Pull out the parts of TextPainter needed by XSLF from HSLF to common-SL in core #57963
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682209 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:13:23 +00:00
Nick Burch
1b20215fc7 #57963 Move the WP and SL interface definitions to core from scratchpad, so the OOXML classes can work without scratchpad
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682204 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:06:18 +00:00
Nick Burch
f769cb3461 Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682201 13f79535-47bb-0310-9956-ffa450edef68
2015-05-28 11:00:32 +00:00
Nick Burch
77916b9364 #57951 Use BigDecimal in some cases in DataFormatter.formatRawCellContents, to avoid rounding problems on JDK8. Patch from Robert Kish
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682083 13f79535-47bb-0310-9956-ffa450edef68
2015-05-27 17:15:17 +00:00
Nick Burch
4e3011f70a Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682081 13f79535-47bb-0310-9956-ffa450edef68
2015-05-27 17:10:45 +00:00
Dominik Stadler
03805d9e20 Add WorkbookFactory.create() with a flag to allow to open files read-only, keep the current way of opening read/write as default to not break existing code.
Also adjust Javadoc somewhat.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681823 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 19:30:21 +00:00
Dominik Stadler
9017803980 Make POIXMLDocument implement Closeable as it holds an OCPPackage with open resources and thus should be closed after usage. Until now only XSSFWorkbook did this, but it makes sense for all derived classes.
Also make close() in POIXMLDocument public to not have to re-implement it in all sub-classes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681822 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 19:30:04 +00:00
Nick Burch
2f87b078e9 Add ignore - file has no content streams
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681809 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 18:38:34 +00:00
Nick Burch
b2d1c1b6ac #56791 Make NPOIFS the default when POIFSFileSystem is requested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681804 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 18:04:00 +00:00
Nick Burch
b8d9c978ad Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681803 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 18:03:29 +00:00
Nick Burch
8878be359a Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681802 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 17:59:13 +00:00
Nick Burch
e4b6cb6811 Remove a long-deprecated OPOIFS related method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681801 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 17:55:23 +00:00
Nick Burch
fe07d32178 Fix warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681763 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 14:06:17 +00:00
Nick Burch
e9f442ffa7 Fix testing for NPOIFS zero-length stream writing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681762 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 13:56:40 +00:00
Nick Burch
e812e61ad3 Fix NPOIFS to handle dodgy excel-95 file from bug #46904
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681756 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 13:46:20 +00:00
Nick Burch
e579b78672 More 0 byte stream tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681754 13f79535-47bb-0310-9956-ffa450edef68
2015-05-26 13:41:29 +00:00
Dominik Stadler
8cf9eaa685 Add verification unit test for bug 47169
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680657 13f79535-47bb-0310-9956-ffa450edef68
2015-05-20 19:13:36 +00:00
Dominik Stadler
001cdeb936 Apply fix reported in bug 47661 and add unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680642 13f79535-47bb-0310-9956-ffa450edef68
2015-05-20 18:00:19 +00:00
Dominik Stadler
589b189151 Prevent problems reported in Bug 56574 by ensuring that Cells are properly removed when a row is overwritten by calling createRow() with it's rownum.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680280 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 13:13:09 +00:00
Dominik Stadler
4c826a7ee3 Update to JaCoCo 0.7.4 and fix location of coverage data in build-output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680228 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 10:16:57 +00:00
Dominik Stadler
b817b93477 Let Eclipse add some more settings to the project files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680216 13f79535-47bb-0310-9956-ffa450edef68
2015-05-19 09:37:52 +00:00
Dominik Stadler
dafabdc7b9 Move location where document is held and adjust constructors and class-hierarchy accordingly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1679903 13f79535-47bb-0310-9956-ffa450edef68
2015-05-17 21:26:31 +00:00
Dominik Stadler
cbd315d441 Adjust error message to have the same error across different types of Workbook and revert test to check on common error message again
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678874 13f79535-47bb-0310-9956-ffa450edef68
2015-05-12 06:27:11 +00:00
Dominik Stadler
c4a26a18f4 Fix unit test which asserts on actual error message
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678861 13f79535-47bb-0310-9956-ffa450edef68
2015-05-12 04:54:47 +00:00
Andreas Beeker
6b6890152c Update documentation for POI 3.12
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678838 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 23:49:42 +00:00
Dominik Stadler
b3a56bd752 Adjust intendation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678814 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 20:03:36 +00:00
Dominik Stadler
eb58b83090 Provide better exception if we would access out of bounds in arraycopy for Escher properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678812 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 20:00:42 +00:00
Dominik Stadler
142e4a9f92 Avoid possible NPE found via CommonCrawl files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678811 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 20:00:18 +00:00
Dominik Stadler
5ca35be087 Add checks for invalid row number in RowRecord to find corrupted files earlier
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678810 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 19:59:52 +00:00
Nick Burch
c9c4aee324 #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678802 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 19:00:12 +00:00
Nick Burch
dd8fc66a0c #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:59:10 +00:00
Nick Burch
46f4c0fbd2 Leave POIFSFileSystem as a lightweight shim around OPOIFSFileSystem pending the final changeover for #56791
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678790 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:21:20 +00:00
Nick Burch
aec457dbcb #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678787 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:15:03 +00:00
Nick Burch
a89a9d673a #56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678783 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:04:30 +00:00
Nick Burch
bd6012d9b9 Add a deep re-write NPOIFS test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678781 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 18:00:45 +00:00
Nick Burch
1945dfc00c Correct zero byte entry support in NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678778 13f79535-47bb-0310-9956-ffa450edef68
2015-05-11 17:53:59 +00:00