Commit Graph

1369 Commits

Author SHA1 Message Date
Yegor Kozlov b9fab26825 added tests for XSSF usermodel for array formulas, this change is a step towards adoption of the patch submitted in Bugzilla 48292
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893625 13f79535-47bb-0310-9956-ffa450edef68
2009-12-23 20:58:01 +00:00
Josh Micich 51c3adb24f Added arg check to NumericFunction.singleOperandEvaluate().
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893403 13f79535-47bb-0310-9956-ffa450edef68
2009-12-23 04:40:14 +00:00
Josh Micich cc648a0fc0 Simplified InterfaceHdrRecord and InterfaceEndRecord (some rework after bug 47251 / r892862).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893402 13f79535-47bb-0310-9956-ffa450edef68
2009-12-23 04:35:37 +00:00
Josh Micich 56c40e3a0f replaced commented code with 'if (false)' block
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893395 13f79535-47bb-0310-9956-ffa450edef68
2009-12-23 03:43:33 +00:00
Yegor Kozlov 3bbde4880c improved performance of DateUtil.isCellDateFormatted(), see Bugzilla 48425
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893105 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 07:52:55 +00:00
Josh Micich c89aeaee12 Added getRow() and getColumn() functions to TwoDEval to simplify logic in INDEX implementation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893063 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 03:00:21 +00:00
Josh Micich 65a41cce66 Fixed SharedValueManager to create separate empty instances in anticipation of instances becoming mutable.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893057 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 01:41:16 +00:00
Josh Micich f11c66506d Renamed model.Sheet to InternalSheet to alleviate name clash.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893051 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 01:08:33 +00:00
Josh Micich ea80e22b2b Renamed model.Workbook to InternalWorkbook to alleviate name clash.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893050 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 00:51:29 +00:00
Josh Micich ce3db22c12 put field initialisation in Workbook constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893045 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 00:13:56 +00:00
Josh Micich cac5b3d60f Removed unused Model, ModelFactory. ModelFactoryListener etc.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893041 13f79535-47bb-0310-9956-ffa450edef68
2009-12-22 00:03:04 +00:00
Josh Micich 7033e79c35 renamed function implementations to avoid potential name clashes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@893030 13f79535-47bb-0310-9956-ffa450edef68
2009-12-21 23:30:32 +00:00
Yegor Kozlov 7bd00361c3 fixed InterfaceEndRecord to tolerate unexpected record contents, see bug 47251
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892862 13f79535-47bb-0310-9956-ffa450edef68
2009-12-21 16:24:08 +00:00
Yegor Kozlov fcdc6ff6e2 undo code mistakenly submitted in r892839
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892842 13f79535-47bb-0310-9956-ffa450edef68
2009-12-21 14:57:23 +00:00
Yegor Kozlov 3969ed7e8f improved javadoc on Picture.resize()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892839 13f79535-47bb-0310-9956-ffa450edef68
2009-12-21 14:51:39 +00:00
Yegor Kozlov 13e963bc8c fixed PageSettingsBlock to allow multiple HeaderFooterRecord records, see Bugzilla 48026
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892467 13f79535-47bb-0310-9956-ffa450edef68
2009-12-19 11:37:45 +00:00
Yegor Kozlov f57d1d8a39 added --noheader option to BiffViewer to suppress output of record headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892465 13f79535-47bb-0310-9956-ffa450edef68
2009-12-19 11:36:06 +00:00
Yegor Kozlov e945a10ade fixed CellRangeUtil.mergeCellRanges to work for adjacent cell regions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892462 13f79535-47bb-0310-9956-ffa450edef68
2009-12-19 11:27:01 +00:00
Yegor Kozlov d704d13573 fixed possible NPE in LbsDataSubRecord.toString()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892461 13f79535-47bb-0310-9956-ffa450edef68
2009-12-19 11:26:10 +00:00
Yegor Kozlov 9da4551038 changed retention policy in @Internal to RUNTIME, also added a string parameter for custom messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@892460 13f79535-47bb-0310-9956-ffa450edef68
2009-12-19 11:25:39 +00:00
Josh Micich b589ee7482 Fixed INDEX function to return reference results properly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@891516 13f79535-47bb-0310-9956-ffa450edef68
2009-12-17 01:35:57 +00:00
Josh Micich 5d9b7a3ee4 fixed special cases of dereferenceResult method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@891468 13f79535-47bb-0310-9956-ffa450edef68
2009-12-16 23:16:30 +00:00
Josh Micich 556622b05f changed short param to int in AreaEval.containsColumn() method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@891425 13f79535-47bb-0310-9956-ffa450edef68
2009-12-16 21:08:36 +00:00
Yegor Kozlov 7ae214c7c7 fixed ExternalNameRecord to properly distinguish DDE data from OLE data in the record body, see Bugzilla 48339
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@890871 13f79535-47bb-0310-9956-ffa450edef68
2009-12-15 16:25:14 +00:00
Yegor Kozlov 2468b7a1e4 preserve POIFS StorageClsid when re-writing existing workbooks, this property is important for embedded objects, see Bugzilla 47920
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@890714 13f79535-47bb-0310-9956-ffa450edef68
2009-12-15 09:30:30 +00:00
David Fisher db0bd14a2c Added missing license headers to 5 files. Removed dist target from howtobuild.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@890089 13f79535-47bb-0310-9956-ffa450edef68
2009-12-13 18:32:47 +00:00
Josh Micich adac5e854d modified MultiOperandNumericFunction to use TwoDEval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888714 13f79535-47bb-0310-9956-ffa450edef68
2009-12-09 07:01:49 +00:00
Josh Micich 18041addf0 Created new TwoDEval interface for AreaEvals (in preparation for patch 48292)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888665 13f79535-47bb-0310-9956-ffa450edef68
2009-12-09 00:50:11 +00:00
Josh Micich 2ddd88ed0d Removed unused imports under src/java and src/testcases. Other minor fixes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888653 13f79535-47bb-0310-9956-ffa450edef68
2009-12-09 00:12:32 +00:00
Josh Micich 0c3c85a152 Renamed AreaEval method from getValueAt() to getAbsoluteValue()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888582 13f79535-47bb-0310-9956-ffa450edef68
2009-12-08 21:48:54 +00:00
Josh Micich 37790e51e4 Some more clean up of array formula support in preparation for patch 48292
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888577 13f79535-47bb-0310-9956-ffa450edef68
2009-12-08 21:30:35 +00:00
Josh Micich f26db72b4b Refactored some code in OFFSET implementation. Added test cases showing comparisons with BoolEval.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888555 13f79535-47bb-0310-9956-ffa450edef68
2009-12-08 20:08:59 +00:00
Josh Micich 72eaea0704 Bugzilla 48343 - added implementation of SUBTOTAL function (patch from Paul Tomlin)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@888490 13f79535-47bb-0310-9956-ffa450edef68
2009-12-08 17:19:09 +00:00
Josh Micich 1992068d14 Controlled instantiation of BoolPtg (made consistent with ErrPtg)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@887477 13f79535-47bb-0310-9956-ffa450edef68
2009-12-05 01:04:44 +00:00
Josh Micich 9fb5841de3 Removed generic type parameter from OperandPtg because it was not worth the extra syntax.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@887432 13f79535-47bb-0310-9956-ffa450edef68
2009-12-04 23:05:06 +00:00
Josh Micich e55e9044aa Made POI follow the rules for encoding unary +/- operators more closely.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@887028 13f79535-47bb-0310-9956-ffa450edef68
2009-12-04 01:25:34 +00:00
Josh Micich 7eea9324d8 More fixes for Cell.setCellType() when converting from CELL_TYPE_FORMULA to CELL_TYPE_STRING. Similar to issues fixed with bugzilla 46479.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@886951 13f79535-47bb-0310-9956-ffa450edef68
2009-12-03 22:18:12 +00:00
Josh Micich 513534c852 Converted line endings from CRLF to LF in Internal.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@886942 13f79535-47bb-0310-9956-ffa450edef68
2009-12-03 22:04:26 +00:00
Yegor Kozlov 4a45b78277 added an annotation '@Internal' to mark program elements intended for POI internal use only, marked all public accessors to OOXML xmlbeans as @Internal
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@886846 13f79535-47bb-0310-9956-ffa450edef68
2009-12-03 16:50:34 +00:00
Josh Micich 5c57aa3cba Bugzilla 48332 - fixed ColumnInfoRecord to tolerate missing reserved field
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@886311 13f79535-47bb-0310-9956-ffa450edef68
2009-12-02 21:29:44 +00:00
Yegor Kozlov 9c515122aa fixed RecordFormatException when reading LbsDataSubRecord, see bugzilla 47701
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@886113 13f79535-47bb-0310-9956-ffa450edef68
2009-12-02 10:56:01 +00:00
Josh Micich 712ac9f8ee Made ScalarConstantPtg public and MissingArgEval.instance final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885661 13f79535-47bb-0310-9956-ffa450edef68
2009-12-01 03:09:55 +00:00
Josh Micich baa4640ec9 Made BlankEval instance consistent with other Eval singletons.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885061 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 02:50:47 +00:00
Josh Micich f81973441b Added constants for IF() and CHOOSE() function indexes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885043 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 22:53:42 +00:00
Josh Micich 5c7dbb2730 Patch 48284 - raise visibility of FormulaParseException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885007 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 21:01:59 +00:00
Josh Micich c73dd9d324 minor changes - initial work on bugzilla 48292 (support for array formulas)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885006 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 20:54:03 +00:00
Josh Micich 97a5bf3d61 small tweak to fix compiler error after r884918 (differences in @Override rules from java 5 to 6)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@885000 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 20:47:39 +00:00
Yegor Kozlov 11b696550c improved work with cell comments in XSSF, also added support for cell comments to SS interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@884918 13f79535-47bb-0310-9956-ffa450edef68
2009-11-27 17:39:17 +00:00
Josh Micich 823c6c6424 Moved handling of MissingArgEval into IF() or CHOOSE() for non-optimised (eager argument evaluation) case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@884389 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 02:57:24 +00:00
Nick Burch 6602faf140 Add support for creating SummaryInformation and DocumentSummaryInformation properties on POIDocuments that don't have them, via POIDocument.createInformationProperties()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@884072 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 12:37:48 +00:00
Nick Burch 4bcde19ada Fix bug #48180 - short chart records skipping some unused fields
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@884065 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 12:11:04 +00:00
Nick Burch 83504367e3 Patch from Jeremy Michelson (with slight tweaks) - bug #48274 - fix erronious wrapping of byte colours in HSSFPalette.findSimilarColor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@884061 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 11:45:37 +00:00
Josh Micich b6a98299a3 Removed Ptg[] parameter from method IEvaluationListener.onStartEvaluate()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883208 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 01:22:56 +00:00
Josh Micich 1f22e9c945 updated remaining evaluator functions to implement fixed args interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883197 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 00:19:11 +00:00
Josh Micich 6be8ae88fc added fixed arg function interfaces, converted some functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883045 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 07:29:40 +00:00
Josh Micich f56c779723 refactored functions taking optionally 2 or 3 parameters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883041 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 06:27:55 +00:00
Josh Micich 18f9851823 minor fix to T() function, junit added
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883039 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 05:49:51 +00:00
Josh Micich e09f868473 Fixed small bug in SUMIF() added junits. Also added test cases for DAYS360, some initially disabled.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@883037 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 05:30:53 +00:00
Yegor Kozlov 52274f2a3f fixed javadoc for HSSFSheet.setColumnWidth and XSSFSheet setColumnWidth
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@882931 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 15:49:16 +00:00
Josh Micich cf7f47fbe1 moved lazy ref creation methods to OperationEvaluationContext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@882375 13f79535-47bb-0310-9956-ffa450edef68
2009-11-20 01:13:17 +00:00
Josh Micich 89c17f1ef7 changed short to int in Function.evaluate() method signature
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@881704 13f79535-47bb-0310-9956-ffa450edef68
2009-11-18 09:21:12 +00:00
Josh Micich 96c5649208 added method format2DRefAsString() to interface ExternSheetReferenceToken to help with refactoring 3D ref code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@881698 13f79535-47bb-0310-9956-ffa450edef68
2009-11-18 08:39:17 +00:00
Josh Micich 518ae59f07 Removed OperationEval and rearranged function/operator evaluation.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@880593 13f79535-47bb-0310-9956-ffa450edef68
2009-11-16 05:41:57 +00:00
Josh Micich 5630df07a4 Updated diagnostic code in HSSFEvaluationWorkbook - regarding changed status of IntersectionPtg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@836344 13f79535-47bb-0310-9956-ffa450edef68
2009-11-15 09:12:30 +00:00
Josh Micich 623a4c1e5b Clean-up of copy/clone methods in Ptg hierarchy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@836343 13f79535-47bb-0310-9956-ffa450edef68
2009-11-15 09:01:35 +00:00
Josh Micich f633a0e646 made ArrayPtg immutable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@836332 13f79535-47bb-0310-9956-ffa450edef68
2009-11-15 06:04:03 +00:00
Josh Micich d8f3c6de71 fixed bug in LittleEndianByteArrayInputStream.readFully()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@836298 13f79535-47bb-0310-9956-ffa450edef68
2009-11-15 00:27:59 +00:00
Josh Micich 00e64461a9 Made AbstractFunctionPtg immutable, other minor improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@836101 13f79535-47bb-0310-9956-ffa450edef68
2009-11-14 02:41:24 +00:00
Josh Micich 861e2bae01 Bugzilla 48195 - short-circuit evaluation of IF() and CHOOSE()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@835994 13f79535-47bb-0310-9956-ffa450edef68
2009-11-13 21:21:23 +00:00
Josh Micich a76bd88d9b Cleaned up AttrPtg - made immutable, fixed property accessors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@835982 13f79535-47bb-0310-9956-ffa450edef68
2009-11-13 20:46:02 +00:00
Yegor Kozlov a8da0c422e renamed HSSFSheet.setArabic to HSSFSheet.setRightToLeft
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@835846 13f79535-47bb-0310-9956-ffa450edef68
2009-11-13 13:33:52 +00:00
Nick Burch 4a57314dcc Make a start on feature related records. Not finished yet, so not enabled in the recordfactory until complete+tested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@835183 13f79535-47bb-0310-9956-ffa450edef68
2009-11-12 01:10:19 +00:00
Yegor Kozlov b592beedaa added a method to set arabic mode in HSSFSheet, see Bugzilla 47970
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@833537 13f79535-47bb-0310-9956-ffa450edef68
2009-11-06 19:40:07 +00:00
Yegor Kozlov 477347c3ec release system resources when calling javax.imageio.ImageIO in Picture.resize()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@833527 13f79535-47bb-0310-9956-ffa450edef68
2009-11-06 19:08:41 +00:00
Josh Micich 5b49f93f8a Removed erroneous coding for Ptg 0x1a (see bugzilla 40008)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@832975 13f79535-47bb-0310-9956-ffa450edef68
2009-11-05 02:33:32 +00:00
Nick Burch 87b83797e0 Hopefully fix #45672 properly - improve handling by MissingRecordAwareHSSFListener of records that cover multiple cells (MulBlankRecord and MulRKRecord)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@832584 13f79535-47bb-0310-9956-ffa450edef68
2009-11-03 22:45:39 +00:00
Josh Micich 047c900ced Bugzilla 48096 - relaxed validation check in RecalcIdRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@832536 13f79535-47bb-0310-9956-ffa450edef68
2009-11-03 20:23:21 +00:00
Josh Micich f286580c44 Bugzilla 48085 - improved error checking in BlockAllocationTableReader to trap unreasonable field values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@832505 13f79535-47bb-0310-9956-ffa450edef68
2009-11-03 18:48:20 +00:00
Yegor Kozlov ef37deea55 fixed logic for matching cells and comments in HSSFCell.getCellComment()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@831025 13f79535-47bb-0310-9956-ffa450edef68
2009-10-29 16:43:24 +00:00
Josh Micich 74624c0cdd Bugzilla 48044 - added implementation for CountBlank function (patch from Mads Mohr Christensen)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@829293 13f79535-47bb-0310-9956-ffa450edef68
2009-10-24 00:41:30 +00:00
Josh Micich c856343fc0 Bugzilla 48036 - added IntersectionEval to allow evaluation of the intersection formula operator.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@828244 13f79535-47bb-0310-9956-ffa450edef68
2009-10-21 23:00:09 +00:00
Josh Micich 5e240d7032 deleted 'svn:executable' property
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@826045 13f79535-47bb-0310-9956-ffa450edef68
2009-10-16 19:17:12 +00:00
Josh Micich 3a2f15aafe fixed compiler warnings and TODOs in org.apache.poi.hssf.record.formula.eval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@826041 13f79535-47bb-0310-9956-ffa450edef68
2009-10-16 19:07:11 +00:00
Josh Micich a27dff24ea simplify/optimise OperationEvaluatorFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@826017 13f79535-47bb-0310-9956-ffa450edef68
2009-10-16 18:00:25 +00:00
Josh Micich 1833764495 Bugzilla 47969 - improvements to equals() methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@824972 13f79535-47bb-0310-9956-ffa450edef68
2009-10-13 23:24:14 +00:00
Josh Micich ed1b4794a0 Bugzilla 47962 - Fixed some potential NPEs. Avoided unnecessary creation of box instances. Applied patch with mods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@823348 13f79535-47bb-0310-9956-ffa450edef68
2009-10-08 22:29:41 +00:00
Josh Micich a6ced5bc25 Minor improvements to error handling in ForkedEvaluator. Added junits.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@820479 13f79535-47bb-0310-9956-ffa450edef68
2009-09-30 22:25:53 +00:00
Josh Micich c098ef803e Bugzilla 47747 - fixed logic for locating shared formula records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@816417 13f79535-47bb-0310-9956-ffa450edef68
2009-09-18 00:33:18 +00:00
Josh Micich cae73922a6 Improvements to patch 47809 (support for UDFs)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@816016 13f79535-47bb-0310-9956-ffa450edef68
2009-09-17 00:00:57 +00:00
Josh Micich 6977f358dd Reverted initial application of patches 47848(r815935) and 47849(r815942). Some details need clarification.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@816006 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 23:20:51 +00:00
Yegor Kozlov d093e7c3a4 Added possibility to get EvaluationCell from RefEval, see bugzilla 47849
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@815942 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 19:59:39 +00:00
Yegor Kozlov 0092e8152d Added method createEvaluationWorkbook() to CreationHelper, see Bugzilla 47848
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@815935 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 19:29:42 +00:00
Yegor Kozlov 141dc22e84 improved work with user-defined functions, see Bugzilla 47809
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@815928 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 19:16:39 +00:00
Yegor Kozlov bd966f208b removed unnecessary svn:executable flag from files in SVN trunk, see bugzilla 47734
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@814335 13f79535-47bb-0310-9956-ffa450edef68
2009-09-13 16:05:28 +00:00
Yegor Kozlov 81a095fa5e added javadoc how to avoid Excel crash when creating too many HSSFRichTextString cells, see Bugzilla 47543
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@814324 13f79535-47bb-0310-9956-ffa450edef68
2009-09-13 14:53:51 +00:00
Yegor Kozlov e4378f5677 built-in positive formats don't need starting '(', see bugzilla 47770
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@813449 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 14:02:16 +00:00
Yegor Kozlov 0b4d43db7b Necessary fix of FunctionEval (follow-on to patch 47768)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@813440 13f79535-47bb-0310-9956-ffa450edef68
2009-09-10 13:51:26 +00:00
Yegor Kozlov dc05b63cb9 Added method setFunction(boolean) for defined names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@811998 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 05:17:23 +00:00
Yegor Kozlov 4f42192d39 Implementation of Excel Days360 and Npv functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@811996 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 05:04:17 +00:00
Yegor Kozlov f11f0c4138 Do not allow text longer than 32,767 characters in HSSF cells, see Bugzilla 47751
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@811994 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 04:55:32 +00:00
Yegor Kozlov 006806553c fixed incorrect assignment in TextObjectRecord.clone()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@809658 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 16:56:22 +00:00
Josh Micich dd9c89cc43 Bugzilla 47721 - Added implementation for INDIRECT()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806759 13f79535-47bb-0310-9956-ffa450edef68
2009-08-21 23:37:17 +00:00
Josh Micich 4076768ed3 minor improvements to sheet name validation and identification of cell references vs defined names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806395 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 23:25:10 +00:00
Yegor Kozlov 7e2a5dacee Avoid exception when reading ClipboardData packet in OLE property sets, see bugzilla 45583
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806172 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 13:49:33 +00:00
Josh Micich f226104c29 changed interface from OperationEval to Function for basic operators
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805971 13f79535-47bb-0310-9956-ffa450edef68
2009-08-19 20:55:44 +00:00
Josh Micich ee3718b5a7 Fixing compiler warnings - unboxing parameter to overloaded method, unnecessary typecast
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805900 13f79535-47bb-0310-9956-ffa450edef68
2009-08-19 17:39:21 +00:00
Josh Micich 9926c89006 Fixed compiler warnings - unnecessary throws declaration
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805552 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 19:49:28 +00:00
Josh Micich c304173145 Fixed compiler warnings - unnecessary else
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805492 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 16:50:24 +00:00
Josh Micich c83d6bfa24 Fixing compiler warnings - unnecessary typecasts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805284 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 05:29:53 +00:00
Josh Micich 995d8fe73f Fixed unused imports compiler warnings (and some others)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805262 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 02:41:45 +00:00
Josh Micich 37bbf5d179 Removed obsolete Eval interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805192 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 22:34:22 +00:00
Josh Micich e72a30c440 Replaced obsolete Eval with ValueEval in signature of Function.evaluate()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805119 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 20:04:45 +00:00
Josh Micich b25137db49 initial work on removing obsolete Eval interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805091 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 18:55:05 +00:00
Josh Micich ab0268434e Combined FuncVarEval into FunctionEval. Simplified selection of free ref functions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805088 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 18:29:40 +00:00
Josh Micich 457a13f8a4 Follow-on for bugzilla 47652 - used more specific exception when password is incorrect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@804381 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 21:35:44 +00:00
Josh Micich c7ef83811b Bugzilla 47652 - Added support for reading encrypted workbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@801890 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 06:03:31 +00:00
Josh Micich 755b86af67 code improvements to RecordFactoryInputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@801850 13f79535-47bb-0310-9956-ffa450edef68
2009-08-07 00:21:00 +00:00
Josh Micich c37ef4c7ca Bugzilla 47598 - Improved formula evaluator number comparison
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@798771 13f79535-47bb-0310-9956-ffa450edef68
2009-07-29 03:36:25 +00:00
Yegor Kozlov 47909f9f88 Fixed RecordFactoryInputStream to properly read continued DrawingRecords
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@797737 13f79535-47bb-0310-9956-ffa450edef68
2009-07-25 10:22:04 +00:00
Yegor Kozlov c9929932a2 added a cmd option to turn on deserialization of escher records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@797735 13f79535-47bb-0310-9956-ffa450edef68
2009-07-25 10:21:28 +00:00
Josh Micich 32d0c7213e Improvements to formula evaluation treatment of -0.0. (Refinements to fix for bug 47198
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@797258 13f79535-47bb-0310-9956-ffa450edef68
2009-07-23 23:12:17 +00:00
Josh Micich e6d41ed590 Converted ConcatEval to singleton
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@797238 13f79535-47bb-0310-9956-ffa450edef68
2009-07-23 21:45:56 +00:00
Yegor Kozlov bf76476b0e updated docs on extraction of embedded objects, misc changes in HSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@795394 13f79535-47bb-0310-9956-ffa450edef68
2009-07-18 16:49:56 +00:00
Yegor Kozlov db7502182e Fixed HyperlinkRecord to properly handle URL monikers, see Bugzilla 47498
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@793281 13f79535-47bb-0310-9956-ffa450edef68
2009-07-12 07:21:04 +00:00
Josh Micich 9ba354156d Bugzilla 47479 - Fix BoolErrRecord to tolerate incorrect format written by OOO
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@791595 13f79535-47bb-0310-9956-ffa450edef68
2009-07-06 19:59:32 +00:00
Yegor Kozlov 15ffa9ebda refactored HSSFEventFactory to use RecordFactory instead of HSSFRecordStream, see Bugzilla 47448
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@791251 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 14:10:49 +00:00
Josh Micich af131d4cee Bugzilla 47415 - Fixed PageSettingsBlock to allow multiple PLS records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@788157 13f79535-47bb-0310-9956-ffa450edef68
2009-06-24 19:45:44 +00:00
Josh Micich c71e498a11 Bugzilla 47412 - Fixed concurrency issue with EscherProperties.initProps()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@787771 13f79535-47bb-0310-9956-ffa450edef68
2009-06-23 18:06:18 +00:00
Yegor Kozlov 2089d73506 Fixed OOM in HSSFWorkbook#getAllPictures when reading .xls files containing metafiles, see Bugzilla 47143
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@786793 13f79535-47bb-0310-9956-ffa450edef68
2009-06-20 11:17:30 +00:00
Josh Micich 07bff0902a Added implementation for ISNA()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@786696 13f79535-47bb-0310-9956-ffa450edef68
2009-06-19 22:42:39 +00:00
Yegor Kozlov e1ff96d77d fixed a regression issue where HSSFHyperlink failed to set inter-sheet and file links, see Bugzilla #47375
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@786442 13f79535-47bb-0310-9956-ffa450edef68
2009-06-19 10:37:24 +00:00
Josh Micich 8e010177ef Bugzilla 47384 - Fixed ExternalNameRecord to handle unicode names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@786267 13f79535-47bb-0310-9956-ffa450edef68
2009-06-18 21:01:13 +00:00
Josh Micich 383e9e4a40 Removed trailing whitespace in RecordFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@784247 13f79535-47bb-0310-9956-ffa450edef68
2009-06-12 19:42:28 +00:00
Josh Micich 635c570598 Bugzilla 47363 - Fixed HSSFSheet to allow addition of data validations after sheet protection
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@784240 13f79535-47bb-0310-9956-ffa450edef68
2009-06-12 19:17:59 +00:00
Yegor Kozlov ac526f039b fixed CommonObjectDataSubRecord.field_2_objectId to be unsigned, also fixed HSSFCell.findCellComment to handle sheets with more than 65536 comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@782398 13f79535-47bb-0310-9956-ffa450edef68
2009-06-07 14:54:49 +00:00
Josh Micich 190684164a Bugzilla 46776 - Added clone() method to MulBlankRecord to fix crash in Sheet.cloneSheet()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@782177 13f79535-47bb-0310-9956-ffa450edef68
2009-06-06 00:46:41 +00:00
Josh Micich 3f7db41945 Removed RCS tags from src/java javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781869 13f79535-47bb-0310-9956-ffa450edef68
2009-06-04 23:07:15 +00:00
Josh Micich 3280064978 Bugzilla 47244 - Fixed HSSFSheet to handle missing header / footer records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781645 13f79535-47bb-0310-9956-ffa450edef68
2009-06-04 03:38:52 +00:00
Josh Micich 93b121eb01 Fix for javadoc error in Cell.setCellValue(Date) found by Mike Curwen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781624 13f79535-47bb-0310-9956-ffa450edef68
2009-06-04 00:08:33 +00:00
Josh Micich b7d7f53ea6 rolling back r781622
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781623 13f79535-47bb-0310-9956-ffa450edef68
2009-06-04 00:06:31 +00:00
Josh Micich f7148c9431 Fix for javadoc error in Cell.setCellValue(Date) found by Mike Curwen
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781622 13f79535-47bb-0310-9956-ffa450edef68
2009-06-03 23:57:31 +00:00
Josh Micich fd7ce95af9 Bugzilla 47312 - Fixed formula parser to properly reject cell references with a '0' row component
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781616 13f79535-47bb-0310-9956-ffa450edef68
2009-06-03 23:23:13 +00:00
Josh Micich 522d5c6892 Changed CRLF to LF in remaining trunk/src files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780878 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 23:21:13 +00:00
Josh Micich dd7e611bda Fixed non-use of 10 sample files (named 'BigSSTRecord*'). Resurrected SSTRecord test (commented out in r353769).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780874 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 23:13:29 +00:00
Josh Micich e6149cca3a removed '@version $Id:$' tags (all were in javadoc comments)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780832 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 21:07:20 +00:00
Josh Micich e939bb7d88 removed obsolete classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780822 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 20:47:11 +00:00
Josh Micich 5fc9eb4718 Code cleanup in hssf.model.Sheet. Minor re-formatting and compiler warning fixes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780792 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 19:18:43 +00:00
Josh Micich bffe0432f6 Bugzilla 47199 - Fixed PageSettingsBlock/Sheet to tolerate margin records after other non-PSB records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780774 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 18:41:10 +00:00
Yegor Kozlov e7d06ec34c Fixed HSSFSheet#getFirstRowNum and HSSFSheet#getLastRowNum to return correct values after removal of all rows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780245 13f79535-47bb-0310-9956-ffa450edef68
2009-05-30 11:31:14 +00:00
Josh Micich 5a9db459c4 Bugzilla 47250 - Fixed FontRecord to expect unicode flags even when name length is zero
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@777717 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 21:30:50 +00:00
Josh Micich 0cc03d5e13 Made constructor parameter type less restrictive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@777660 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 19:04:49 +00:00
Josh Micich bd15957a5b Bugzilla 47198 - Fixed formula evaluator comparison of -0.0 and 0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@777392 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 06:25:58 +00:00
Josh Micich 394445888b Bugzilla 47229 - Fixed ExternalNameRecord to handle DDE links
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@777275 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 21:41:47 +00:00
Josh Micich b707cd8b48 Added debug methods to decode BIFF record types from record IDs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@777270 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 21:32:54 +00:00
Josh Micich 54a729eb7d removed unused class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@776513 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 01:09:21 +00:00
Josh Micich 52d7b774bf Changed CRLF to LF in function implementations. Removed subclasses of NotImplementedFunction. Minor fixes for compiler warnings, and formatting.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@776505 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 00:14:19 +00:00
Josh Micich 718d1bcf43 Changed CRLF to LF in poi/ddf, Minor fixes for compiler warnings, and formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@776424 13f79535-47bb-0310-9956-ffa450edef68
2009-05-19 19:21:12 +00:00
Josh Micich bae270a565 Changed CRLF to LF in .java base src files. Minor reformatting fixes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@776377 13f79535-47bb-0310-9956-ffa450edef68
2009-05-19 16:29:51 +00:00
Nick Burch 8cfca324f1 Tweaked patch from bug #46287 - Control of header and footer extraction in ExcelExtractor / XSSFExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775738 13f79535-47bb-0310-9956-ffa450edef68
2009-05-17 18:49:29 +00:00
Yegor Kozlov c444cd27e9 Allow columns greater than 255 and rows greater than 0x100000 in XSSF formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775701 13f79535-47bb-0310-9956-ffa450edef68
2009-05-17 16:35:25 +00:00
Josh Micich 2b1d0dd9ab encapsulated hasUnlimitedVarags() logic into FunctionMetadata
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775575 13f79535-47bb-0310-9956-ffa450edef68
2009-05-17 02:02:48 +00:00
Josh Micich 508e2c83cb Code clean-up in HSSFDataFormat etc. Removed bad characters from TestHSSFDataFormatter. Added comment about international formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775570 13f79535-47bb-0310-9956-ffa450edef68
2009-05-17 00:10:36 +00:00
Nick Burch ad56447d05 Base class for "old version" exceptions, and new HSLF detection + use of old versions exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775526 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 20:51:29 +00:00
Nick Burch cf0d23d3de Fix bug #47154 - Handle the cell format @ as the same as General
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775500 13f79535-47bb-0310-9956-ffa450edef68
2009-05-16 17:39:31 +00:00
Josh Micich eaa9c19074 Bugzilla 47048 - Fixed evaluation of defined names with the 'complex' flag set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775376 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 22:47:33 +00:00
Josh Micich b92b2d556b Fix for bug noticed while investigating bugzilla 47048. Made INDEX() support missing args.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@775360 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 21:36:25 +00:00
Josh Micich df9cd1738e Fix bug (broken junit) introduced in r773412. Also hooked up test.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@773441 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 00:50:45 +00:00
Josh Micich 93c369411f Introduced CustomViewSettingsRecordAggregate. Also reverted some debug changes to EscherAggregate from r773412
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@773438 13f79535-47bb-0310-9956-ffa450edef68
2009-05-11 00:28:45 +00:00
Josh Micich 98524ddaf8 Created ChartSubstreamRecordAggregate to manage chart sub-streams. Not fully incorporated yet.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@773434 13f79535-47bb-0310-9956-ffa450edef68
2009-05-10 23:54:29 +00:00
Josh Micich e2793ef74b Bug 46953 - fixed PageSettingsBlock parsing logic in Sheet. Bug caused sheet EOFs to get misplaced.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@773412 13f79535-47bb-0310-9956-ffa450edef68
2009-05-10 21:34:28 +00:00
Nick Burch f9b0e77d90 Fix javadocs for AbortableHSSFListener, and add unit test to show it all works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@771865 13f79535-47bb-0310-9956-ffa450edef68
2009-05-05 16:02:06 +00:00
Yegor Kozlov 3842f1ff22 Fixed POIFSFileSystem to set CLSID of root when constructing instances from InputStream, see bugzilla 39056
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@766757 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 17:09:09 +00:00
Yegor Kozlov fe50c3f15c moved 'throw' into else clause avoiding exception on every call of cloneStyleFrom, see bugzilla 47054
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@766755 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 16:58:29 +00:00
Yegor Kozlov db553fd510 read GutsRecord in in the Sheet(RecordStream rs)
constructor (see bugzilla 46186); always call sheet.setAlternativeExpression in conjuction with sheet.setRowSumsBelow, see bugzilla 46714 and 30714

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@766273 13f79535-47bb-0310-9956-ffa450edef68
2009-04-18 09:06:16 +00:00
Yegor Kozlov 62b0595b83 Allow 255 arguments for excel functions in XSSF, see bugzilla 46279
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@766251 13f79535-47bb-0310-9956-ffa450edef68
2009-04-18 07:12:38 +00:00
Josh Micich f41239ad03 Fix for bug 46987 - allow RecordFactory to handle non-zero padding at the end of the workbook stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@765866 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 06:53:49 +00:00
Josh Micich 10ee56f313 added Workbook.getName(String) method. Fixed javadoc on related methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@765751 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 20:34:13 +00:00
Nick Burch be1fb69d9b Fix bug #47034 - Reading the name of a NameRecord when the name is > 127
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@765163 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 12:42:53 +00:00
Yegor Kozlov 050f386bba removed unused imports of deprecated classes, fixed javadoc errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@764203 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 14:15:27 +00:00
Josh Micich 806706b135 Bugzilla 47001 - Fixed WriteAccessRecord and LinkTable to handle unusual format written by Google Docs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@763391 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 21:01:43 +00:00
Yegor Kozlov bb1ce91342 moved common interfaces from src/ooxml/interfaces-jdk15 to src/java, they do belong there
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@763332 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 17:51:33 +00:00
Josh Micich 60fd0a0fae Bugzilla 46973 - fixed defined names to behave better when refersToFormula is unset
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@762479 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 19:57:21 +00:00
Yegor Kozlov 6ceeb39a45 consolidate limits specific to Excel version(Excel97, Excel2007) in SpreadsheetVersion enum, allow merged regions with columns greater than 255 or rows bigger than 65536 in XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@762372 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 15:06:23 +00:00
Josh Micich 527b4c7fc5 Bug 46951 - fixed formula parser to better handle range operators and whole row/column refs.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@762250 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 08:22:25 +00:00
Josh Micich dc2630494d Added toString debug method to MemAreaPtg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@761862 13f79535-47bb-0310-9956-ffa450edef68
2009-04-04 02:53:08 +00:00
Josh Micich 0d76928c37 fixed compiler error from r761723
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@761836 13f79535-47bb-0310-9956-ffa450edef68
2009-04-03 23:16:44 +00:00
Yegor Kozlov 3bcd8fd479 added SpreadsheetVersion enum to hold version-specific properties such as maximum number of rows and columns, etc.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@761723 13f79535-47bb-0310-9956-ffa450edef68
2009-04-03 16:42:39 +00:00
Josh Micich b558d99132 Changed cell and area ref Ptgs to allow creation using CellReference and AreaReference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@761553 13f79535-47bb-0310-9956-ffa450edef68
2009-04-03 07:41:29 +00:00
Josh Micich 0e7da90f77 Fix for bug 46948 - Range operator can now take area-refs for operands
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@761023 13f79535-47bb-0310-9956-ffa450edef68
2009-04-01 19:41:12 +00:00
Josh Micich fba33cf5a4 Fix for 46918 - Allow shorter format for ExtendedPivotTableViewFieldsRecord(SXVDEX) record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@760646 13f79535-47bb-0310-9956-ffa450edef68
2009-03-31 21:12:47 +00:00
Josh Micich 6fb401a724 Bugzilla 46818 (patch from Wayne Clingingsmith) - added implementation for HYPERLINK function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@760343 13f79535-47bb-0310-9956-ffa450edef68
2009-03-31 06:09:06 +00:00
Josh Micich 91a91b2301 Fix for bug 46898 - Formula evaluator should not cache intermediate circular-reference error results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@760162 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 20:46:51 +00:00
Yegor Kozlov 51d71180ab more refactoring of common ss tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@759714 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 16:10:40 +00:00
Yegor Kozlov 52ab464cab improved test cases: moved common hssf-xssf test to org.apache.poi.ss namespace, removed duplicate tests, refactored code to throw same exceptions, etc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@759112 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 11:50:52 +00:00
Josh Micich ecf6617071 Fix for bug 46917 - PageItemRecord(SXPI) can contain multiple field infos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@758770 13f79535-47bb-0310-9956-ffa450edef68
2009-03-26 17:42:18 +00:00
Nick Burch 46590f58a1 Fix the block allocation test, but still leave the recent blocks hssf bug fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@758353 13f79535-47bb-0310-9956-ffa450edef68
2009-03-25 17:22:06 +00:00
Nick Burch 579a4b95a4 Explicit cast
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@757904 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 17:00:00 +00:00
Nick Burch d8af6dfdd4 Fix bug #46904, for old biff5/biff7 files where the block chain is terminated incorrectly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@757873 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 16:07:49 +00:00
Josh Micich ef93bdc6ae Fix for bug 46840 - PageSettingsBlock should include HEADERFOOTER record
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@757520 13f79535-47bb-0310-9956-ffa450edef68
2009-03-23 19:42:39 +00:00
Josh Micich 4f4ad37765 Abstracted record construction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@754828 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 07:03:13 +00:00
Josh Micich 032d57431f updated url in comment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@750316 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 04:54:27 +00:00
Yegor Kozlov e4d94add7f support built-in data formats in XSSFDataFormat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@749054 13f79535-47bb-0310-9956-ffa450edef68
2009-03-01 16:24:40 +00:00
Yegor Kozlov 1dfecf377c improved shifting of sheet-level names, also fixed an incorrect Bugzilla number in status.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@748064 13f79535-47bb-0310-9956-ffa450edef68
2009-02-26 09:10:35 +00:00
Yegor Kozlov bebc51def9 more improvements in shiftRows: 1. shift named ranges and merged regions, JUnit added. 2. fixed shiftRows in XSSF to preserve row heights, see bugzilla 46719.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@747894 13f79535-47bb-0310-9956-ffa450edef68
2009-02-25 19:12:06 +00:00
Yegor Kozlov 55dfa11284 fixed non-standard ASF license headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@747348 13f79535-47bb-0310-9956-ffa450edef68
2009-02-24 11:30:08 +00:00
Yegor Kozlov 4862f72197 added setDisplayZeros / isDisplayZeros and getMergedRegion(int) to common interface org.apache.poi.ss.usermodel.Sheet; more progress on testing common xssf-hssf interfaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@747307 13f79535-47bb-0310-9956-ffa450edef68
2009-02-24 08:38:16 +00:00
Josh Micich d707f50d5d Should have been part of c746085 (More fixes to allow EscherContainerRecord to exclusively maintain 'child records' field due to r745976 / r746018)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@746086 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 01:57:45 +00:00
Josh Micich 8dcd0c8c58 More fixes to allow EscherContainerRecord to exclusively maintain 'child records' field. (due to r745976 / r746018)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@746085 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 01:55:47 +00:00
Josh Micich 8a77c05b99 Fix for bug introduced in r745976. EscherContainerRecord shouldn't hand out it's private 'child records' field.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@746018 13f79535-47bb-0310-9956-ffa450edef68
2009-02-19 22:02:14 +00:00
Josh Micich 3e6f2bbf80 Added Apache License text to files where it was missing. Also fixed some compiler warnings in those files.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@745976 13f79535-47bb-0310-9956-ffa450edef68
2009-02-19 19:50:20 +00:00
Josh Micich d527d61af4 fixed typo in toString()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@745972 13f79535-47bb-0310-9956-ffa450edef68
2009-02-19 19:05:06 +00:00
Yegor Kozlov 6fa67727ea fixed autoSizeColumn() to use cached formula values when processing formula cells, see bug #46736
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@745937 13f79535-47bb-0310-9956-ffa450edef68
2009-02-19 17:29:55 +00:00
Yegor Kozlov 5d5f76be67 Fixed formula parser to handle names with backslashes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@744749 13f79535-47bb-0310-9956-ffa450edef68
2009-02-15 20:45:24 +00:00
Josh Micich 7c870ecd41 fixed compiler warnings. added some TODO comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@744257 13f79535-47bb-0310-9956-ffa450edef68
2009-02-13 22:11:16 +00:00
Josh Micich 521656d9c2 Bugzilla 46660 - added 'hidden' property to Workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@744253 13f79535-47bb-0310-9956-ffa450edef68
2009-02-13 21:46:44 +00:00
Josh Micich 8edb507a89 Fix for bug 46693 - serialization errors in CHARTFORMAT, SHTPROPS, SXVD and SXVDEX records
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@743601 13f79535-47bb-0310-9956-ffa450edef68
2009-02-12 02:28:43 +00:00
Josh Micich ffe6fd7a23 Minor code clean-up
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@743484 13f79535-47bb-0310-9956-ffa450edef68
2009-02-11 20:23:08 +00:00
Josh Micich 12321616a3 fixed record name in toString() close element
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@742839 13f79535-47bb-0310-9956-ffa450edef68
2009-02-10 03:41:08 +00:00
Josh Micich 4b5616a6ca Refactored common CellValueRecordInterface code into a new superclass CellRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@742785 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 23:16:49 +00:00
Josh Micich 771369c409 Fixed serialization of multiple blank records (should get aggregated into MulBlankRecord)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@741850 13f79535-47bb-0310-9956-ffa450edef68
2009-02-07 07:39:23 +00:00
Yegor Kozlov 23cf469315 changed. Sheet.setColumnWidth to throw IllegalArgumentException if the column width argument is greater than 255 characters (the maximum column width in Excel)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@741678 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 18:59:24 +00:00
Josh Micich aac8563019 Fix for bug 46654 - HSSFRow/RowRecord needs to properly update cell boundary indexes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@741036 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 07:39:57 +00:00
Josh Micich d7c95a10c8 Fixed deprecated references to HSSFSheet.getRow(short) etc. Removed all deprecated warnings from hssf.usermodel.examples.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@740179 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 01:19:13 +00:00
Josh Micich 011fafc7ae Modified formula parser to encode SUM taking a single argument as tAttrSum (from comment 7 of bugzilla 46643)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@740159 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 23:53:22 +00:00
Josh Micich e3775b8b1d Fix for bug 46643 - formula parser should encode range operator with tMemFunc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@740146 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 23:10:30 +00:00
Josh Micich 7cbc3b9067 Added toString methods to help debugging
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@740123 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 22:11:48 +00:00
Josh Micich 4057cb7cf0 Fix for bug 46647 - COUNTIF NE operator and other special cases involving type conversion
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@740088 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 19:42:57 +00:00
Yegor Kozlov 7a842bc264 fixed bugs 40520 and 46553: HSSFFont.applyFont() formats wrong parts of HSSFRichTextString
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@738908 13f79535-47bb-0310-9956-ffa450edef68
2009-01-29 16:03:52 +00:00
Josh Micich 980ff2cf30 Fix for bug 46545 - ObjRecord should ignore excessive padding written by previous POI versions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@738709 13f79535-47bb-0310-9956-ffa450edef68
2009-01-29 01:57:22 +00:00
Josh Micich 0b692dd75c Fix for bug 46613 - evaluator should perform case insensitive string comparisons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@738188 13f79535-47bb-0310-9956-ffa450edef68
2009-01-27 19:02:13 +00:00
Josh Micich c3258085c7 Follow-up fix for r737173 and r737238 (patch 46544) - filename arg was not properly parsed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@737248 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 23:34:22 +00:00
Josh Micich 184ec62cf4 Follow-up fix for r737173 (patch 46544) - filename arg was not properly parsed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@737238 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 23:06:56 +00:00
Josh Micich d800ec6a84 Bugzilla 45644 - adding a command line interface to hssf ExcelExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@737173 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 20:12:13 +00:00
Josh Micich 59e334e8a5 Replaced ErrorEval.FUNCTION_NOT_IMPLEMENTED with new exception NotImplementedException. Removed test case involving ISREF which was working for the wrong reasons.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@736505 13f79535-47bb-0310-9956-ffa450edef68
2009-01-22 00:26:28 +00:00
Josh Micich c013d9b7c9 Fixing compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@736479 13f79535-47bb-0310-9956-ffa450edef68
2009-01-21 23:17:45 +00:00
Josh Micich 6756ffefe0 Fixed HSSFCell/FormulaRecordAggregate to properly remove StringRecord when cached result type changes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@736476 13f79535-47bb-0310-9956-ffa450edef68
2009-01-21 23:11:45 +00:00
Josh Micich 07fd83a278 Fix for bug 46547 - Allow for addition of conditional formatting when data validations are present. Avoid creation of and empty conditional formatting table while shifting formulas.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@736175 13f79535-47bb-0310-9956-ffa450edef68
2009-01-21 00:19:49 +00:00
Josh Micich 73a498fb35 Removed unused, erroneous import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@735208 13f79535-47bb-0310-9956-ffa450edef68
2009-01-17 02:27:13 +00:00
Josh Micich 306c28cc28 Bug 46548 - fixes for Page Settings Block (patch from Dmitriy Kumshayev + some mods)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@735179 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 23:13:11 +00:00
Josh Micich 98a6bded10 Updated class comment
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@735174 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 22:54:42 +00:00
Josh Micich 7dad2164cd Fixing bug 46551 - spelling mistakes in xSSFCell.checkBounds(). Also fixed 0/1-based index error for cell range checks in XSSF.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@735061 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 17:31:29 +00:00
Josh Micich b280b299a0 resolved error constants in BoolErrRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@734281 13f79535-47bb-0310-9956-ffa450edef68
2009-01-14 00:22:00 +00:00
Josh Micich d4ec8ceb11 Bugzilla 46523 - added implementation for SUMIF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@734252 13f79535-47bb-0310-9956-ffa450edef68
2009-01-13 22:02:52 +00:00
Josh Micich 9c05b68576 Improvements to countif implementation in preparation for sumif
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@734243 13f79535-47bb-0310-9956-ffa450edef68
2009-01-13 21:22:37 +00:00
Nick Burch ea421dab2b Support for reading HSSF column styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@732112 13f79535-47bb-0310-9956-ffa450edef68
2009-01-06 20:49:02 +00:00
Nick Burch 68e203d5e6 Fix bug #46472 - Avoid NPE in HPSFPropertiesExtractor when no properties exist
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@732058 13f79535-47bb-0310-9956-ffa450edef68
2009-01-06 18:59:42 +00:00
Josh Micich 6e2f255f14 Fix for bug 46479 - conversion of cached formula values and HSSFFormulaEvaluator.evaluateInCell()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@731715 13f79535-47bb-0310-9956-ffa450edef68
2009-01-05 20:58:02 +00:00
Josh Micich 3bdb856e58 Fix for 45031 - added implementation for CHOOSE function.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@730469 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 20:32:47 +00:00
Josh Micich df7d120dc6 Simplifying ValueEval hierarchy, added comments to Function and OperationEval.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@730450 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 19:32:44 +00:00
Josh Micich d9df585ca5 Patch 46410 from Steven Butler - added impl for TIME() function.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@730309 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 05:31:42 +00:00