Commit Graph

5795 Commits

Author SHA1 Message Date
Andreas Beeker
07dc2b9e08 findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715087 13f79535-47bb-0310-9956-ffa450edef68
2015-11-19 01:44:38 +00:00
Andreas Beeker
e2bc07e9d1 #55955 - Filling an existing ppt table stopped working with 3.9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714715 13f79535-47bb-0310-9956-ffa450edef68
2015-11-16 23:56:19 +00:00
Andreas Beeker
a0e06add7a #54210 When saving PPT to PNG, some text is rendered backwards
#53189 Shapes drawn wrongly when ppt file converted to image
fix line decoration (HSLF)


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714290 13f79535-47bb-0310-9956-ffa450edef68
2015-11-14 02:44:07 +00:00
Andreas Beeker
67b4477a7e Fix typo in EscherProperties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714289 13f79535-47bb-0310-9956-ffa450edef68
2015-11-14 02:42:05 +00:00
Andreas Beeker
c6f11991e7 Add default XmlOptions to XMLBeans parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1714288 13f79535-47bb-0310-9956-ffa450edef68
2015-11-14 02:41:48 +00:00
Uwe Schindler
9ab28f52ab Add security check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713917 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 19:17:18 +00:00
Uwe Schindler
493a157e6a Fix remaining security manager problems. Forbiddenapis now passes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 19:11:35 +00:00
Uwe Schindler
73a8488838 #58597: Fix tests to not do setAccessible(), add some doPrivileged, too.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 16:57:39 +00:00
Uwe Schindler
da19b14670 #58597: Add more AccessController.doPrivileged. We should fix them later!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713813 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 11:36:44 +00:00
Uwe Schindler
b62cc549fe #58597: Remove setAccessible (more coming soon)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713770 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 07:41:54 +00:00
Andreas Beeker
b0b4c020ed Fixed Off-by-one-Error which skipped paragraph styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713546 13f79535-47bb-0310-9956-ffa450edef68
2015-11-09 21:37:10 +00:00
Uwe Schindler
ce66e14b5a Wrap more security related reflection in AccessController
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713356 13f79535-47bb-0310-9956-ffa450edef68
2015-11-09 09:32:37 +00:00
Uwe Schindler
8c3cd70589 Use Lucene's unmapping code inside AccessController.doPrivileged() for unmapping mapped byte buffers.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713350 13f79535-47bb-0310-9956-ffa450edef68
2015-11-09 09:06:01 +00:00
Andreas Beeker
d1d1298d96 #53192 - Images in ppt file have wrong width when convering ppt to png
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713332 13f79535-47bb-0310-9956-ffa450edef68
2015-11-09 01:28:31 +00:00
Uwe Schindler
66ce32aee1 Add reason message to @SuppressForbidden
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713324 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 23:44:24 +00:00
Andreas Beeker
ccce28aae4 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713319 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 23:14:50 +00:00
Andreas Beeker
e8d108ff22 Add support for HSLF metro blobs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713318 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 23:13:28 +00:00
Andreas Beeker
1a32b63fd3 #52297 - Bullets are not aligned properly while converting ppt slide to image
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713316 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 23:11:22 +00:00
Uwe Schindler
0f40ad3125 Make forbiddenapis also check excelant. Use a separate "classpath" for running forbiddenapis; don't misuse javadoc.classpath for that.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713222 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 11:57:58 +00:00
Dominik Stadler
db98ec0bd9 Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713218 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 10:01:48 +00:00
asf-sync-process
c39e9df3c8 Add some more tests for the checks for files that can cause large memory usage.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713217 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 10:00:38 +00:00
Dominik Stadler
4cdcc9fc24 Eclipse warnings, typos, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713216 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 10:00:24 +00:00
Javen O'Neal
8cff5d7e49 bug 58591: add formula evaluation unit tests inspired by Jason Tomforde's question on user@
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713080 13f79535-47bb-0310-9956-ffa450edef68
2015-11-07 04:09:39 +00:00
Nick Burch
a4e891ff8f Whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712985 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 17:03:22 +00:00
Nick Burch
6cc2839b66 Convert to JUnit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712984 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 17:02:18 +00:00
Javen O'Neal
0149810619 remove TestWorkbookEvaluator from junit3 test suite since it was upgraded to junit4 in r1712908
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712921 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 08:51:49 +00:00
Javen O'Neal
c47401d239 remove deprecated ErrorConstants usage in TestWorkbookEvaluator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712910 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 04:58:35 +00:00
Javen O'Neal
663c64ff44 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712909 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 04:45:25 +00:00
Javen O'Neal
42c1296ef6 convert TestWorkbookEvaluator from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712908 13f79535-47bb-0310-9956-ffa450edef68
2015-11-06 04:43:50 +00:00
Nick Burch
172593de22 Add a XWPFRun equivalent of isHighlighted, and add to the common WP interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712793 13f79535-47bb-0310-9956-ffa450edef68
2015-11-05 15:15:36 +00:00
David North
5636e64d68 Patch to bring CTTableStyleInfo into poi-ooxml-schemas by referencing it from a unit test.
Thanks to Danil Lopatin

https://bz.apache.org/bugzilla/show_bug.cgi?id=58579

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712769 13f79535-47bb-0310-9956-ffa450edef68
2015-11-05 13:44:14 +00:00
Andreas Beeker
9b4919cd51 extended forbidden-apis-check to ooxml-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712693 13f79535-47bb-0310-9956-ffa450edef68
2015-11-05 00:15:51 +00:00
Nick Burch
ecab3629d8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712606 13f79535-47bb-0310-9956-ffa450edef68
2015-11-04 18:25:35 +00:00
Nick Burch
0e7caa5eb1 Bug #55265 - DataFormatter correct support for alternate number grouping characters, eg 1234 + #'##0 = 1'234 not 1,234
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712605 13f79535-47bb-0310-9956-ffa450edef68
2015-11-04 18:23:17 +00:00
Javen O'Neal
20ba4851a8 fix for bug 51622: autosize columns with leading whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
2015-11-04 06:39:57 +00:00
Javen O'Neal
265d198612 bug 58576: rename canComputeColumnWidht to canComputeColumnWidth
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 07:23:09 +00:00
Javen O'Neal
3b88a60498 supporting change for bug 57450 from Stefan Thurnherr
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712217 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 07:07:11 +00:00
Javen O'Neal
93373073bc set svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712214 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 06:06:43 +00:00
Javen O'Neal
3a08acac95 fix typos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712213 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 06:03:52 +00:00
Andreas Beeker
acb219fbe1 fixes sonar/findbugs issues
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 23:46:57 +00:00
Javen O'Neal
06b3878176 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711961 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 13:25:31 +00:00
Javen O'Neal
3b94c206e5 fix javadoc link
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711957 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 13:13:52 +00:00
Javen O'Neal
e1e740bc3c bug 58572: change hyperlink reference to be consistent with TestXSSFHyperlink#testCopyXSSFHyperlink
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711952 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 13:02:44 +00:00
Javen O'Neal
9b8250832e bug 58572: replace Cloneable with copy constructors for spreadsheet Hyperlink class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711951 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 12:57:57 +00:00
Javen O'Neal
54113431b5 bug58348: add test for copying formula with unregistered UDF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711939 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 10:47:19 +00:00
Javen O'Neal
f7fbfcd5ea bug 58348: add hyperlink copying and merging to CellCopyPolicy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711926 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:59:32 +00:00
Javen O'Neal
0eb6ec6717 bug 58572: move getHyperlinkList() and getHyperlink(row, col) from XSSFSheet to Sheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711923 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:40:49 +00:00
Javen O'Neal
3c18d6aa7b don't leave behind files when running unit tests. In the future this should be revisited to verify POI isn't writing workbooks that are unopenable/corrupt by applications that read POI's formats (MS Office, OpenOffice, LibreOffice, etc)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711920 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:23:12 +00:00
Javen O'Neal
e88fac62ef whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711911 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:03:12 +00:00
Javen O'Neal
43a5f308d0 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711910 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 09:01:23 +00:00
Javen O'Neal
0e3230f703 upgrade spreadsheet Hyperlink unit tests from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711909 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 08:55:45 +00:00
Javen O'Neal
3753893f1a whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711906 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 08:34:21 +00:00
Javen O'Neal
87ad007ce4 add ASF License 2.0 header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711901 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 05:33:31 +00:00
Javen O'Neal
0aeab392e5 remove unused import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711886 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:51:31 +00:00
Javen O'Neal
1360cd835d bug 58348: add support for copying rows for XSSFWorkbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711885 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:50:33 +00:00
Javen O'Neal
6fc1d21367 javadocs, remove unnecessary SuppressWarnings("resource") decorator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711883 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:39:15 +00:00
Javen O'Neal
682f5b3ed4 make private shouldRemoveRow static and final, remove unused import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711881 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:28:34 +00:00
Javen O'Neal
b729d3896c whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711880 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:22:45 +00:00
Javen O'Neal
40b250bbb3 replace deprecated usage of FormulaShifter.createForRowShift
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711879 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:22:03 +00:00
Javen O'Neal
fa7beda123 remove unneeded SuppressWarnings("resource") decorator from getSheetName
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711878 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:13:35 +00:00
Javen O'Neal
75dd7f9ba3 remove unnecessary @SuppressWarnings(resource) add Override decorator to SXSSFCell.getCellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711877 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 02:06:43 +00:00
Javen O'Neal
c0aec91a93 delete unnecessary cast
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711876 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 01:51:03 +00:00
Javen O'Neal
af4a96f467 bug 58384: add FormulaShifter.createForRowCopy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711866 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 00:25:08 +00:00
Andreas Beeker
ae69a781f5 close resources, as SlideShow is now Closeable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711865 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 00:05:14 +00:00
Javen O'Neal
44edbec0d5 prepare for bug 58348, make FormulaShifter.ShiftMode enum private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711864 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 23:54:13 +00:00
Javen O'Neal
adcc71257a whitespace changes: replaced tabs with 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711862 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 23:30:48 +00:00
asf-sync-process
8b6cef3b79 #45908 - RichTextRun.setBullet(false) doesn't work, bullets still here
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711858 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 22:52:49 +00:00
asf-sync-process
0ae2928035 #45088 - POI-HSLF changeTextInRichTextRun corrupts presentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711845 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 19:37:28 +00:00
Andreas Beeker
5338f9dce1 Fix locale error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711726 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 08:43:57 +00:00
Andreas Beeker
fa40f8417c findbugs fixes
close resources in tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711712 13f79535-47bb-0310-9956-ffa450edef68
2015-11-01 03:23:16 +00:00
Andreas Beeker
72834dfffa FindBugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711708 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 23:13:35 +00:00
Andreas Beeker
8ebc22a84e Add method for setting bullet styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711707 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 23:10:43 +00:00
Andreas Beeker
6485c11305 Make SlideShow closeable as of HSLF references a NPOIFSFileSystem and hasn't closed it
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711706 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 23:10:17 +00:00
Andreas Beeker
02ff2b913f #45124 - inserting text or images wipes out boldness and makes everything italic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711705 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 23:08:52 +00:00
Andreas Beeker
8a6a5578e6 #45124 - inserting text or images wipes out boldness and makes everything italic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711704 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 23:05:09 +00:00
Javen O'Neal
401d3eec77 replace deprecated usage of AreaReference as a result of bug 56328
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711685 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 20:53:12 +00:00
Javen O'Neal
d0694f4fc9 whitespace change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711680 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 19:56:22 +00:00
Javen O'Neal
f98fda03c1 add javadoc info for intersects
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711613 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 12:21:51 +00:00
Javen O'Neal
1aa81eb463 bug58452: set cell formulas containing unregistered function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711605 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:57:39 +00:00
Javen O'Neal
2354bbb0b0 supporting changes for bug 58452: copy cell formulas containing unregistered function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711600 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:39:01 +00:00
Javen O'Neal
07cf6736ae improve error message if CellRangeAddress intersection assertion fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711597 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:20:15 +00:00
Javen O'Neal
5f23aa95f7 bug 58442: in-place reorganize an AreaPtg as upper-left and lower-right
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711592 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 11:10:28 +00:00
Javen O'Neal
043a86e243 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 10:22:19 +00:00
Javen O'Neal
b40a0b01bb replace deprecated usage of o.a.p.ss.util.Region with o.a.p.ss.util.CellRangeAddress; add documentation to tests that exist strictly to test deprecated methods, and move SuppressWarnings-deprecation down to just those functions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711581 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 09:29:32 +00:00
Dominik Stadler
50baa731d3 Add a limit of the max number of characters that can be extracted to avoid sending applications out of memory with very large documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711520 13f79535-47bb-0310-9956-ffa450edef68
2015-10-30 17:26:37 +00:00
Andreas Beeker
b9cf1bdc38 #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711381 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 23:22:54 +00:00
Andreas Beeker
438d4bd03e #58516 - Rare new aioobe in 3.13 on initialization of a handful of ppts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711380 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 23:20:35 +00:00
Dominik Stadler
ba7f5f3037 Ensure that no password was set by other tests, this breaks sometimes when the Sonar/Maven build runs all tests in one VM
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711199 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 09:30:11 +00:00
Nick Burch
fa5fc2e65e Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711197 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 09:28:38 +00:00
Javen O'Neal
1396738460 bug 58557: fix from Alessandro Guarascio, shift hyperlinks when shifting rows on an XSSFSheet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711185 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 06:53:55 +00:00
Andreas Beeker
1d1bdc1521 Common sl unification - copy first paragraph / textrun properties on XSLFTextShape.setText()
Common sl unification - converted ApacheconEU08 example to common sl - added missing functionality
Common sl unification - return null instead of default values for missing borders X/HSLFTable
Common sl unification - use points in HSLFTable.setColumnWidth()
Fix appending text to empty HSLFTextParagraph


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711171 13f79535-47bb-0310-9956-ffa450edef68
2015-10-29 01:05:27 +00:00
Nick Burch
632228a34e #58558 SXSSFCell.setCellValue((RichTextString)null) fixed to work like XSSF and HSSF, with common unit tests to verify this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711082 13f79535-47bb-0310-9956-ffa450edef68
2015-10-28 17:42:56 +00:00
Javen O'Neal
c65de59909 bug 26862: add test case for HSSFWorkbook.cloneSheet copies charts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710730 13f79535-47bb-0310-9956-ffa450edef68
2015-10-27 07:43:23 +00:00
Javen O'Neal
bcb09a3798 convert scratchpad TestHSSFChart from junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710729 13f79535-47bb-0310-9956-ffa450edef68
2015-10-27 07:41:09 +00:00
Dominik Stadler
856bbf97f4 Fix Sonar-Maven build, correctly determine path to test-file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710694 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 20:48:38 +00:00
Dominik Stadler
f1f08de7fb Apply some micro-optimization which helps when retrieving the string-value of large spreadsheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710692 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 20:48:32 +00:00
David North
b0551e322e Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58549
Thanks to Damian Cugley for the patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710552 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 10:32:30 +00:00
Dominik Stadler
c7ebebcbb1 Bug 56957: Avoid error if Workbook with empty SharedStringTable is written
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710521 13f79535-47bb-0310-9956-ffa450edef68
2015-10-26 07:54:06 +00:00
Nick Burch
8cd7f1f736 58536 DataFormatter and CellFormat non-localised support for localised currency formats like [$£-809]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710484 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 21:20:44 +00:00
Nick Burch
90db0bf451 Fix javadoc warning - @see with a URL needs wrapping in an a-href tag
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710460 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 16:19:35 +00:00
Nick Burch
dc947416d4 Mention about Locale definitions in Excel cell data format strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 16:13:16 +00:00
Nick Burch
1b019d3c76 #58532 Enable more of the padding cell format tests, but a few remain to be fixed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710407 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 23:57:49 +00:00
Nick Burch
e966499ad2 #58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which
DataFormatter didn't properly support, call out to the alternate CellFormat
 instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
 only have one set of cell formatting logic...


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 23:34:47 +00:00
Nick Burch
e86a116d0a Fix inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710395 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 22:12:06 +00:00
asf-sync-process
41419d44eb Test to check that #58532 formats are seen as valid
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710394 13f79535-47bb-0310-9956-ffa450edef68
2015-10-24 22:09:11 +00:00
Dominik Stadler
dd48f58f95 Bug 58085: removing sheet breaks other existing sheet references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710193 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 12:11:40 +00:00
Javen O'Neal
c22fdbbc2b bug 58441: define equals method for CellRangeAddressBase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710172 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 11:17:06 +00:00
Javen O'Neal
ab729cfd0e bug 58402: make AreaReference's private SpreadsheetVersion _version variable final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710163 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 09:54:32 +00:00
Javen O'Neal
522b6d4a15 bug 58439: rename private FormulaShifter.adjustPtgDueToShiftMove to adjustPtgDueToSheetMove
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710147 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 08:56:49 +00:00
Javen O'Neal
538b2d1377 bug 33174: Use common unit test for testNoMergedRegionsIsEmptyList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710140 13f79535-47bb-0310-9956-ffa450edef68
2015-10-23 08:38:14 +00:00
Dominik Stadler
27d4814b80 Set newer curvesapi-version in .classpath as well and update some third-party libs for the password-protection-code to the latest versions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710032 13f79535-47bb-0310-9956-ffa450edef68
2015-10-22 15:21:25 +00:00
Dustin Spicuzza
fe771aa808 XDGF: fix the fix
- Use Collections.emptySet() for an iterator instead
- Bump curvesapi to 1.03, which is compiled for JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709463 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 18:36:45 +00:00
Dustin Spicuzza
9c23e12b8e XDGF: fix jdk < 1.8 compat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709427 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 14:55:30 +00:00
Dustin Spicuzza
f540622a05 XDGF: fix jenkins build errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709363 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:55:06 +00:00
Dustin Spicuzza
e0a5e102b8 Add Visio OOXML text extractor + tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709361 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:26:57 +00:00
Dustin Spicuzza
879ca64994 Add some limited XDGF documentation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709357 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 06:08:58 +00:00
Dustin Spicuzza
e3365dfaeb poi-import: fix build dependencies
- Compilation + tests work now

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709356 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:59:42 +00:00
Dustin Spicuzza
d70b8e8b88 poi-visio import: reformat code to fit project standards, remove JRE 7isms
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709355 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:59:37 +00:00
Dustin Spicuzza
3bd2011924 Import poi-visio codebase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:52:35 +00:00
Dominik Stadler
3a8f40db7c Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
2015-10-17 14:40:36 +00:00
Dominik Stadler
43ab1cd35a Use the default XmlOptions for all the invocations of the XmlBeans XML parsing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709128 13f79535-47bb-0310-9956-ffa450edef68
2015-10-17 08:45:25 +00:00
David North
bb18031ac7 Remove unnecessary warning suppressions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708921 13f79535-47bb-0310-9956-ffa450edef68
2015-10-16 09:00:43 +00:00
Dominik Stadler
e9d0e9cc12 Update test to not depend on an existing build-directory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708682 13f79535-47bb-0310-9956-ffa450edef68
2015-10-14 19:27:20 +00:00
Dominik Stadler
392591e222 Reenable test on Windows which was disabled previously but should now work after a workaround was put in place via bug 58480.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708613 13f79535-47bb-0310-9956-ffa450edef68
2015-10-14 15:00:19 +00:00
Dominik Stadler
a00240f212 Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
2015-10-14 14:53:41 +00:00
Dominik Stadler
d15ef65b8f Bug 58341: fix some edge cases in the DStar function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708606 13f79535-47bb-0310-9956-ffa450edef68
2015-10-14 14:31:04 +00:00
Andreas Beeker
a0a197bc96 javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708265 13f79535-47bb-0310-9956-ffa450edef68
2015-10-12 23:10:02 +00:00
Andreas Beeker
5fd71db914 - removed deprecated and confusing methods in XSSFColor
- sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708236 13f79535-47bb-0310-9956-ffa450edef68
2015-10-12 20:43:42 +00:00
Dominik Stadler
7fbf591db5 Retry which measures duration a few times to see if that reduces the number of failures caused by this test sometimes when CI machines are loaded.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707488 13f79535-47bb-0310-9956-ffa450edef68
2015-10-08 11:08:41 +00:00
Nick Burch
4ae623c699 Update the XSSF EventModel example, to show how to do it better using the SheetContentsHandler helper that does most of the work for you
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707326 13f79535-47bb-0310-9956-ffa450edef68
2015-10-07 15:19:04 +00:00
Dustin Spicuzza
bf68d5f290 Bug 58048: Add visio schemas to the OOXML jar
- Bumped OOXML jar version also

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707177 13f79535-47bb-0310-9956-ffa450edef68
2015-10-07 02:41:30 +00:00
Andreas Beeker
cab7f9c2e0 fix forbidden apis issue and make non-static as decimalformat is not thread-safe
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1707166 13f79535-47bb-0310-9956-ffa450edef68
2015-10-06 22:52:05 +00:00
David North
efee7bf83f Format numbers more like Excel does
Thanks to Chris Boyle for the patch

https://bz.apache.org/bugzilla/show_bug.cgi?id=58471

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706971 13f79535-47bb-0310-9956-ffa450edef68
2015-10-06 09:56:26 +00:00
Andreas Beeker
62561d5f53 sonar fixes and closing resources after use
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706937 13f79535-47bb-0310-9956-ffa450edef68
2015-10-06 00:04:12 +00:00
David North
2dc93d4411 Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=58466
ColumnHelper now preserves information on multiple changes to the same group, hopefully while preserving the faster implementation intended by the original patch.

NB changes to TestXSSFSheet: the behaviour of column group collapsing/expanding is now closer to what Excel does than before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706789 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 10:31:33 +00:00
Dominik Stadler
cc1caaf658 As discussed at ApacheCon: Try to automatically find test-data in unit tests, this makes it easier to get going in Eclipse or other IDEs.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706752 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 06:45:20 +00:00
Dominik Stadler
4b487fcc10 Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706750 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 06:41:48 +00:00
Andreas Beeker
eee32c0480 fixed sonar issues and eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:28:54 +00:00
Andreas Beeker
0d29f8b2ec obsoleted Codec classes by HexDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706741 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:27:47 +00:00
Andreas Beeker
8aec6ba738 removed obsolete classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706740 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:26:45 +00:00
Andreas Beeker
d9c0fb9ce5 Fixed a problem with save-and-load of conditional formattings (CFHeader12 wasn't added to conditional formattings, rgb value wasn't saved in extended color)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706739 13f79535-47bb-0310-9956-ffa450edef68
2015-10-05 00:26:19 +00:00
Andreas Beeker
98e93217fe sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
2015-10-04 00:35:30 +00:00
Dominik Stadler
030c29cfed Bug 55032: Fix handling missing option values in financial functions PV, FV, NPER and PMT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706254 13f79535-47bb-0310-9956-ffa450edef68
2015-10-01 14:05:28 +00:00
Andreas Beeker
2de9d527b4 sonar fixes
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
2015-09-30 23:06:39 +00:00
Dominik Stadler
9deb59f263 Verify that bug 51998 is actually fixed since some time already.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705855 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 13:09:47 +00:00
Dominik Stadler
99d33a0330 Bug 50319: Make row groups which include row 0 work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705844 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 12:26:08 +00:00
Dominik Stadler
b261c978a8 Tried to reproduce bug 48403 but couldn't, still adding the related unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705830 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 10:14:40 +00:00
Andreas Beeker
ffd1f4333e sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 08:31:15 +00:00
Dominik Stadler
c56977e6d2 Add test which shows that bug 46515 is fixed since some time already.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705807 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 07:51:48 +00:00
Dominik Stadler
72ae82f7dc Verify that bug 45541 can be resolved, add some more checks in XSLFFileHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705804 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 06:08:08 +00:00
Andreas Beeker
1b2b506edb Sonar fixes - add cloneable interface to classes with clone()
Sonar fixes - remove pubic/static/final modifier from interfaces

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705789 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 23:16:58 +00:00
Andreas Beeker
6f7f16853e Removed HDF API
Sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705779 13f79535-47bb-0310-9956-ffa450edef68
2015-09-28 21:26:06 +00:00
Andreas Beeker
5cd3436295 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705587 13f79535-47bb-0310-9956-ffa450edef68
2015-09-27 22:14:25 +00:00
Andreas Beeker
bde96d1a9a fixed some wrong nightly assumptions ... (Note to myself, don't rely on ant automatic file change detection, but run ant clean before ...)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704999 13f79535-47bb-0310-9956-ffa450edef68
2015-09-24 05:51:38 +00:00
Andreas Beeker
abfe427e72 - a few findbugs/sonar fixes
- removed obsolete openxml4j signature classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704964 13f79535-47bb-0310-9956-ffa450edef68
2015-09-23 23:22:46 +00:00
David North
c93ded0f36 Make XSSF and HSSF consistent in getMergedRegions - return empty list if there are none, rather than an exception. Tests for this.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58350

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704839 13f79535-47bb-0310-9956-ffa450edef68
2015-09-23 12:53:13 +00:00
Dominik Stadler
5e6b975b1c Ensure that the ThreadLocal-Biff-Password is reset correctly after each usage, we had some unit tests failing sporadically due to this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704710 13f79535-47bb-0310-9956-ffa450edef68
2015-09-22 19:50:37 +00:00
Nick Burch
c556e08a52 Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704393 13f79535-47bb-0310-9956-ffa450edef68
2015-09-21 19:18:40 +00:00
Andreas Beeker
6488170c6d removed common sl path
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704207 13f79535-47bb-0310-9956-ffa450edef68
2015-09-21 00:16:36 +00:00
Andreas Beeker
dec09d2713 - #58216 - provide picture-shape resize that maintains the aspect ratio
- moved SlideShowFactory to Common SL
- changed get/setAnchor to Rectangle instead of Rectangle2D
- Fixed some Common SL generic definitions
- picture dimensions are now in points and an additional method exists for pixels

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704206 13f79535-47bb-0310-9956-ffa450edef68
2015-09-21 00:09:45 +00:00
Dominik Stadler
d61ea07e26 Bug 58333: Apply patch to verify behavior on row-index before and after the limits set by the specification
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704186 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 20:16:17 +00:00
Dominik Stadler
f2cd7ed8f5 Bug 58332: Adjust implementation of dev-util 'MemoryUsage' to print out information if limits are reached instead of OOM
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704182 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 20:05:36 +00:00
Andreas Beeker
f3004e6185 close resources in junit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704124 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 12:02:40 +00:00
Andreas Beeker
18395d5c3b - #58207 - Provide user access to the original image dimensions (XSLF)
- same for hslf / common sl
- unify method names in H/XSLF Slideshow for common sl
- add/fix header information for PICT/EMF/WMF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1704097 13f79535-47bb-0310-9956-ffa450edef68
2015-09-20 02:25:35 +00:00
Dominik Stadler
a207e463e9 Bug 57925: Add unit test and a simple fix to at least avoid the NPE when Workbooks have invalid external references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703999 13f79535-47bb-0310-9956-ffa450edef68
2015-09-19 12:22:42 +00:00
Dominik Stadler
3a325dc5dc Bug 57915: Fix Dev2Hex for numbers larger than Integer.MAX_VALUE and less than Integer.MIN_VALUE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703672 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 19:23:25 +00:00
Dominik Stadler
6dda58db90 Apply patch from bug 57890 to add support for different datatypes in XSSFImportFromXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703665 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 18:30:13 +00:00
Nick Burch
20b44d546e Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703575 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 11:18:15 +00:00
Nick Burch
9647b62d1a Patch from Javen ONeal from bug #58245 - Make Workbook support iterating over Sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703573 13f79535-47bb-0310-9956-ffa450edef68
2015-09-17 11:10:11 +00:00
Dominik Stadler
8f604e8563 Eclipse warnings, code formatting, simplify ExcelAntWorkbookUtilFactory, always close resources, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1703028 13f79535-47bb-0310-9956-ffa450edef68
2015-09-14 18:40:23 +00:00
Dominik Stadler
a5918f26fe Update javadoc for bug 56129
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702805 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:32:50 +00:00
Dominik Stadler
c6f875fbb9 Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:05:55 +00:00
Dominik Stadler
a4901ca30d Enhance integration testing to apply OPCPackage tests to more file-types and also run XSSFReader in XSSFFileHandler
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702801 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:05:40 +00:00
Dominik Stadler
42053fcf71 Verify that bug 55406 can be closed WORKSFORME
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702800 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 19:05:28 +00:00
Dominik Stadler
fb88108e30 Add test case for bug 54399
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702786 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 14:48:58 +00:00
Andreas Beeker
50777f1e48 fix eclipse warning - mostly generics cosmetics
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702773 13f79535-47bb-0310-9956-ffa450edef68
2015-09-13 12:36:56 +00:00
Andreas Beeker
5f94d8b533 fix eclipse warning - mostly generics cosmetics
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
2015-09-12 18:45:07 +00:00
Dominik Stadler
768060a8ff Bug 58353: Return correct value in Match-Function with match-type == -1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702535 13f79535-47bb-0310-9956-ffa450edef68
2015-09-11 18:52:29 +00:00
Nick Burch
aff1dba75b Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702417 13f79535-47bb-0310-9956-ffa450edef68
2015-09-11 10:27:22 +00:00
Andreas Beeker
fec6b40606 More forbidden apis fixes (added main-tests to the check)
and a few junit4 upgrades
... hopefully this doesn't crash the build again ... :|

to simulate the tests on jenkins on the local developer box, uncomment the UTC lines in the build.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702356 13f79535-47bb-0310-9956-ffa450edef68
2015-09-11 00:56:16 +00:00
Andreas Beeker
c21b7bc4d1 forbidden apis fixes - timezone fix ... will it work?
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702321 13f79535-47bb-0310-9956-ffa450edef68
2015-09-10 21:31:00 +00:00
David North
728e202b6b Patch from https://bz.apache.org/bugzilla/show_bug.cgi?id=58347 - s/arg/filename for a more descriptive filename
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702060 13f79535-47bb-0310-9956-ffa450edef68
2015-09-09 17:27:49 +00:00
Andreas Beeker
aea434a135 forbidden apis fixes - a few DateFormat clean ups ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
2015-09-09 00:41:03 +00:00
Andreas Beeker
50107cae16 Bug 58326 - Forbidden APIs patches - second set of changes for charset settings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701713 13f79535-47bb-0310-9956-ffa450edef68
2015-09-08 00:04:12 +00:00
Andreas Beeker
91e6a64627 forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 22:34:21 +00:00
Andreas Beeker
aaafb0270d Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Andreas Beeker
3166646249 Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
commit single files because of svn failures ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701684 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:14:33 +00:00
Dominik Stadler
782739541a Bug 58315: Avoid NPE for RichTextString without font-details
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701382 13f79535-47bb-0310-9956-ffa450edef68
2015-09-05 12:57:04 +00:00
Dominik Stadler
b2bd6a0a4c Eclipse warnings, close resources in CommandLineTextExtractor, add try/finally, formatting, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701139 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:59:14 +00:00
Dominik Stadler
de46578051 Bug 56959: Add verification unit test to show that the bug cannot be reproduced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701135 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:32 +00:00
Dominik Stadler
dab5f4c078 Fix bug 53275: reset indexed color flag when setting a non-indexed color
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701134 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:23 +00:00
Dominik Stadler
f7e0bdea37 Add unit test which verifies that bug 53105 is actually fixed now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701133 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:14 +00:00
Dominik Stadler
4b8c20a7ca Add unit tests to verify that bug 51626 and bug 51451 are fixed
Conflicts:
	src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701132 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:46:04 +00:00
Dominik Stadler
fcfe2e2a71 Add unit tests which verify that the issues from bug 48962 and 50755 do not occur any more on the latest version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701131 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 20:45:55 +00:00
David North
7d1947ad3a Make D* functions thread safe, thanks to Patrick Zimmermann for the patch.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701055 13f79535-47bb-0310-9956-ffa450edef68
2015-09-03 15:58:00 +00:00
Andreas Beeker
d6f598b8f9 remove trailing comma ... works ok in Oracle jdk6, but maybe not in openjdk ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700880 13f79535-47bb-0310-9956-ffa450edef68
2015-09-02 19:44:14 +00:00
Andreas Beeker
1ca522ffa9 Fix DAYS360 for US/EU handling
fix forbidden api calls
add TimeZone (user) override to DateUtil
fix a few left open resources in the junit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700686 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 23:10:43 +00:00
Nick Burch
d2ebc899fb Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700677 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:46:30 +00:00
Nick Burch
d00fb8a65b Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700675 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:31:02 +00:00
Nick Burch
83399ac543 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700673 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:26:39 +00:00
Nick Burch
b0ec4fbcf6 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700672 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:18:33 +00:00
Nick Burch
aa455c91fd Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700670 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:09:20 +00:00
Nick Burch
4fba7dbd62 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700669 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 20:57:57 +00:00
Nick Burch
28ae209cb8 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700652 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:36:22 +00:00
Nick Burch
64416b4d84 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700651 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:24:55 +00:00
Nick Burch
8265e2e95e Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700648 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:19:55 +00:00
Nick Burch
46eccc04cc Fix inconsistent indent/whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700647 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:17:40 +00:00
Nick Burch
3e9159c523 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700646 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:16:21 +00:00
Nick Burch
71a62c0f9d Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700645 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:11:20 +00:00
Nick Burch
47fb9df1a1 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700644 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:06:53 +00:00
Nick Burch
533e1c8dcb Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:01:36 +00:00
Nick Burch
2015baaad3 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700641 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 18:56:44 +00:00
Nick Burch
4fed0c35e9 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700640 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 18:49:50 +00:00
Nick Burch
f098eca5a0 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700635 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 18:37:07 +00:00
Andreas Beeker
6703c9d3fb forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700076 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 21:45:08 +00:00
Andreas Beeker
828c58f956 forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700063 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 18:01:26 +00:00
Andreas Beeker
3c609d309b fixed a few forbidden api calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700055 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 15:52:10 +00:00
Andreas Beeker
f2487c035a junit4 fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700043 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:47:16 +00:00
Andreas Beeker
33ffe01bff - reworked HexDump class - unified array dumps and usage of standard java calls for hex format
- fixed a few findbugs DM_DEFAULT_ENCODING issues
- removed a few System.out/.err calls - instead the poilogger is used
- closed a few left open resource instances

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700040 13f79535-47bb-0310-9956-ffa450edef68
2015-08-29 14:41:12 +00:00
Nick Burch
c451224d84 Fix a handful of forbidden apis identified problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698198 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 17:21:35 +00:00
Dominik Stadler
b98bfd48aa Adjust excludes for TestRecordLister
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698081 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 06:32:33 +00:00
Andreas Beeker
880d5fa413 javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698030 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 22:26:39 +00:00
Andreas Beeker
cf84bb1a85 Fix for JDK6 bug: http://bugs.java.com/view_bug.do?bug_id=6569074
This was fixed in jdk 7u72 ... so we'll keep this bit uncleaner version for a while ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698006 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 21:25:58 +00:00
Dominik Stadler
6bdc2fb024 Add possibility to set zoomPercent for XWPFDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697992 13f79535-47bb-0310-9956-ffa450edef68
2015-08-26 19:34:28 +00:00
Dominik Stadler
5a867f39e9 Adjust excludes after adjusting multiple HeaderFooterRecord instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697602 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:32:41 +00:00
Dominik Stadler
50687e782b Refactor BaseXLSIteratingTest into a Parameterized test to better show which files failed
Simplify exclusion handling
Exclude testEXCEL_3.xls and testEXCEL_4.xls in two tests, not sure why this worked before?!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697601 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:30:49 +00:00
Dominik Stadler
97fa448a2c Allow multiple instances of HeaderFooterRecord in CustomViewSettingsRecordAggregate similar to ChartSubstreamRecordAggreagte in order to read sample 49931.xls correctly after re-saving it with HSSFWorkbook
Improve error output


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697600 13f79535-47bb-0310-9956-ffa450edef68
2015-08-25 08:28:54 +00:00
Andreas Beeker
cd536720dd common sl: reworked and unified generics definitions
made various methods available through common sl
added createTextBox,AutoShape,... methods to ShapeContainers
hslf tables created by poi, will be identified as such when the file is read again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697515 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 23:15:14 +00:00
Nick Burch
0d7476e130 Tweak error message to make clear that we really need a file showing the problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697502 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 21:20:01 +00:00
Nick Burch
d662021baf Javadoc tweak
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697462 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 17:55:57 +00:00
Dominik Stadler
639b847d6e Reduce required memory in tests by not actually creating all the rows/cells when verifying the max number of cellstyles. Hopefully this will avoid the OOMs that we see in various CI environments currently while still verifying the limits correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1697326 13f79535-47bb-0310-9956-ffa450edef68
2015-08-24 08:12:01 +00:00
Dominik Stadler
39163eccff Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 14:28:39 +00:00
Dominik Stadler
f828ff1554 Somehow the Date formatting via SimpleDateFormatter fails on some CI machines, don't rely on this to avoid test-failures due to timezones/locales but rather compare the date directly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696710 13f79535-47bb-0310-9956-ffa450edef68
2015-08-20 06:29:48 +00:00
Nick Burch
cd988b9c2e Patch from Javen ONeal from bug #58254 - CellFormatResult.text should check for nulls as per the javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696638 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 18:00:31 +00:00
Dominik Stadler
c275dea88c POI Bug 58260: Fix checks for limit on number of styles in XSSF/SXSSF and fix having more than 32k styles in SXSSF workbooks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696586 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:36:08 +00:00
Dominik Stadler
a6caec985c Add additional checks to narrow down why this test fails when run via Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696584 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:28:23 +00:00
Dominik Stadler
580171fe27 Adjust excludes to make the output a bit cleaner in OOXMLLite and also look in the superclass for @Test annotations to include one additional unit-test that we missed currently.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696577 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 13:03:05 +00:00
David North
2af2fa28c2 Improve ReadOnlySharedStringsTable to cope gracefully with an empty SST part.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58262

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696559 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 11:10:13 +00:00
Dominik Stadler
1e45197f59 * Adjust reported text when a Zip-Bomb is detected to allow to quickly see why it happened
* Fail only with inflation ratio lower than the min, not equals, to behave as documented
* Add getters to be able to temporarily adjust the limits for unit tests
* Allow lower inflation ratio in OOXMLPrettyPrint as this is a dev-only tool

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696556 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:57:19 +00:00
David North
5706c2ac9b Make intersection formulae work in XSSF. Patch from Matt Hillsdon plus additional tests.
https://bz.apache.org/bugzilla/show_bug.cgi?id=52111

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696549 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 10:10:08 +00:00
Dominik Stadler
badd478547 Add one unit-test for a different way of calculating workdays to see if this also triggers test failures in Sonar Maven runs which currently fail for test-case TestWorkdayFunction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696498 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 20:24:07 +00:00
Nick Burch
152b0d1e6d Comments, imports and warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696436 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:59:52 +00:00
Nick Burch
91ed79222b Fix indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696432 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:49:38 +00:00
Nick Burch
96a2062e6e Patch from Javen ONeal from bug #58253 - CellReference upper-case check for #REF!, and code readability + javadoc improvements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696430 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:46:01 +00:00
Nick Burch
a92c078d18 Fix indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696429 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:34:52 +00:00
Nick Burch
3bde975db7 Patch from Javen ONeal from bug #58252 - More CellReference unit testing coverage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696427 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:32:53 +00:00
Dominik Stadler
0377dbbb3e Bug 54938: Throw InvalidFormatException as documented instead of IllegalArgumentException in WorkbookFactory.create()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696338 13f79535-47bb-0310-9956-ffa450edef68
2015-08-17 20:54:32 +00:00
Dominik Stadler
0345110611 Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
2015-08-16 20:51:40 +00:00
Andreas Beeker
d90309db4e Move and rename hslf line because of ambiguity with common sl line
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696095 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 20:43:51 +00:00
Andreas Beeker
5827cee62d FindBugs - DLS_DEAD_LOCAL_STORE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696050 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 13:05:00 +00:00
Andreas Beeker
ef3dab6bd7 FindBugs - BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696049 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 13:00:05 +00:00
Andreas Beeker
dd5e6e61c4 FindBugs - DMI_INVOKING_TOSTRING_ON_ARRAY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696043 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 12:20:52 +00:00
Andreas Beeker
860a1ecae0 FindBugs - BX_UNBOXING_IMMEDIATELY_REBOXED
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696042 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 12:13:09 +00:00
Andreas Beeker
af3f0427b5 FindBugs - BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696040 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 12:09:26 +00:00
Andreas Beeker
05c92b7a19 FindBugs - DLS_DEAD_LOCAL_STORE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696038 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 11:57:57 +00:00
Nick Burch
2df37edbae Bigger warnings that new users should use SXSSF, and not mess around with the XML themselves
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696019 13f79535-47bb-0310-9956-ffa450edef68
2015-08-15 07:29:27 +00:00
Nick Burch
6be4fc05d2 Remove catches which were previously incorrectly declared when not needed
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695775 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:31:25 +00:00
Nick Burch
1a84b476e8 #58237 When adding a picture to a XWPF header or footer, attach it to the right part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695772 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:23:58 +00:00
Nick Burch
cfbc261e65 #58237 Add some more XWPF header and footer tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695769 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 20:01:04 +00:00
Nick Burch
d9697de075 Fix inconsistent line endings and some eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695757 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 19:20:58 +00:00
Andreas Beeker
0e1aa75750 findbugs - DM_NUMBER_CTOR
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695635 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 00:38:04 +00:00
Andreas Beeker
3ac2d2905a findbugs - DM_BOXED_PRIMITIVE_...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695629 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 00:17:08 +00:00
Andreas Beeker
14df4b2824 Common stress test for X/HSLF and a few bug fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695628 13f79535-47bb-0310-9956-ffa450edef68
2015-08-13 00:10:11 +00:00
Nick Burch
36ee486049 More consistent test-file output for Excel testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695605 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 19:52:22 +00:00
Nick Burch
a87cdf35cd Fix inconsistent whitespace/indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695604 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 19:49:25 +00:00
Nick Burch
83bf96035c Continue with 55747 / 55324 testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695603 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 19:46:54 +00:00
Nick Burch
459cb5ec62 More tests for 55747 / 55324
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695601 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 19:31:47 +00:00
Nick Burch
f3a33fcead Note on arguments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695595 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 18:38:30 +00:00
Nick Burch
940b5fc449 Javadoc updates, and fix warning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695593 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 18:03:52 +00:00
Nick Burch
6d46fc382f #58220 - Improve the javadocs for XSSFFont and Font getFontHeight methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695528 13f79535-47bb-0310-9956-ffa450edef68
2015-08-12 14:14:12 +00:00
Nick Burch
ac8ed40f80 Fix some eclipse warnings, add TODOs for fields/hyperlinks XWPF add support, and give a more helpful exception if someone tries to remove a XWPFRun that is not a direct paragraph child
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695365 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 20:10:53 +00:00
Nick Burch
87a2acf935 Support XWPF field runs, the same way that we handle hyperlink runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695361 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 20:01:26 +00:00
Dominik Stadler
3b1e99d58f Fix integration test for OPCPackage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695346 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 18:39:50 +00:00
Nick Burch
beec0097bc Bring over some fixes from XSSFSheetXMLHandler, and note that in the javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695309 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 14:31:14 +00:00
Dominik Stadler
ccc4ebcf70 Bug 56479: don't hardcode dcterms as namespace alias in the attribute, but expect the actual alias that is used in the corresponding element.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695212 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 05:37:15 +00:00
Andreas Beeker
4795b3d2cb clamp (h)sl values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1695183 13f79535-47bb-0310-9956-ffa450edef68
2015-08-11 00:07:15 +00:00
Dominik Stadler
e7f4d132f1 Provide more output when failing range-checks on HSL2RGB-construction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694960 13f79535-47bb-0310-9956-ffa450edef68
2015-08-10 06:17:44 +00:00
Andreas Beeker
750558d8d9 #56519 - XSLFSlide.draw is not working with text embeded in PPTX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694925 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 22:44:13 +00:00
Nick Burch
bdb00633a3 Complete theme colour tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694892 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 14:15:00 +00:00
Nick Burch
5b97e55997 Get theme and non-theme rows consistent in the test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694889 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 13:30:35 +00:00
Nick Burch
d2a95d0901 Begin Themes+Normal colour tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694887 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 13:06:40 +00:00
Nick Burch
3abeb347a6 Fix the themes test for the complex workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694883 13f79535-47bb-0310-9956-ffa450edef68
2015-08-09 12:36:57 +00:00
Andreas Beeker
d325916595 Added Siddharths ExcelComparator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694753 13f79535-47bb-0310-9956-ffa450edef68
2015-08-08 00:56:44 +00:00
Andreas Beeker
7c8f544b9f add ASL header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694613 13f79535-47bb-0310-9956-ffa450edef68
2015-08-07 06:59:11 +00:00
Andreas Beeker
d0e0f0cb97 #58205 - getSlideMasters() returns the master slides in the incorrect order
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694592 13f79535-47bb-0310-9956-ffa450edef68
2015-08-07 00:17:55 +00:00
David North
1d6a728931 Make it a complete sentence.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694537 13f79535-47bb-0310-9956-ffa450edef68
2015-08-06 16:38:23 +00:00
David North
66fbc9d44e Example to go with refactor for https://bz.apache.org/bugzilla/show_bug.cgi?id=58219
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694536 13f79535-47bb-0310-9956-ffa450edef68
2015-08-06 16:37:09 +00:00
David North
9730ff9cd6 Proposed refactor for:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58219

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694531 13f79535-47bb-0310-9956-ffa450edef68
2015-08-06 15:57:48 +00:00
Andreas Beeker
f28588fbb3 #57786 - XSLFFreeformShape ignores quadratic bezier curves
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694373 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 23:24:13 +00:00
Andreas Beeker
e5069da22a #58206 - provide a mechanism to find slide layouts by name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694340 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 22:46:42 +00:00
Andreas Beeker
91353085b5 #58204 - STYLE: ShapeContainer interface makes internal getShapesList() redundant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694335 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 21:44:01 +00:00
Nick Burch
0e2e61d1e1 NPE fix for text extraction from MSG files with only a short name
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694255 13f79535-47bb-0310-9956-ffa450edef68
2015-08-05 15:58:43 +00:00
Nick Burch
1f6594c244 Stub next test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694127 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:26:20 +00:00
Nick Burch
b2ab81ad81 Use an enum to simplify the themes code and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694125 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:14:23 +00:00
Andreas Beeker
c4e543d4fa Findbugs fixes for DMI_INVOKING_TOSTRING_ON_ARRAY
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694124 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 23:11:50 +00:00
Nick Burch
f78eac8c41 Pull out indexes from the switch statement to constants, and fix warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694121 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 22:46:27 +00:00
Andreas Beeker
1241a24ebb move setting of xmlinputfactory from junit to gump-meta/poi.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694120 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 22:24:31 +00:00
Nick Burch
885368e2ce Further XSSF Themes unit testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694093 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 17:50:44 +00:00
Nick Burch
78223ca2b8 Consistent indent between font and pattern CF formatting toString indent
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1694087 13f79535-47bb-0310-9956-ffa450edef68
2015-08-04 17:08:50 +00:00
Andreas Beeker
adfcf4d251 FindBugs fixes - MS_SHOULD_BE_FINAL
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1693984 13f79535-47bb-0310-9956-ffa450edef68
2015-08-03 23:36:28 +00:00