Commit Graph

9245 Commits

Author SHA1 Message Date
Dominik Stadler
5265ff6f81 Improve information contained in exception in CellRangeAddress()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793252 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:44 +00:00
Dominik Stadler
fa39402871 60325: Add commented out test that reproduces the performance issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793251 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:36 +00:00
Nick Burch
28cbb8e84e Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793249 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 08:49:51 +00:00
Javen O'Neal
f5389965a2 bug 61034: break out of for-loop when both <sheet name="", id=""/> are found
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793230 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 18:56:09 +00:00
Javen O'Neal
e39ae9cd30 bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 17:27:17 +00:00
Tim Allison
a98eaeb917 bug 61051 -- add new worksheet-like relations for xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792940 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 18:50:22 +00:00
Tim Allison
5f567f29a1 bug 61049 fix ordering of builtin formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 16:18:25 +00:00
Nick Burch
9896e13bf4 Patch from Tim Jones from #61044 - Note on setCompressTempFiles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-26 09:43:56 +00:00
Tim Allison
c2dc3ad585 bug 61021 - extract abspath from xlsb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792198 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 13:02:29 +00:00
Greg Woolsey
f5b90cbbee Add conditional formatting evaluation example code and output results
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792102 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 18:05:50 +00:00
Javen O'Neal
3c2a6b38bb Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 01:28:40 +00:00
Javen O'Neal
3cbf4740b1 Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 23:51:03 +00:00
Greg Woolsey
6e0a5916b5 Fix bug #61007
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.

Send what was checked previously plus only multi-segment conditional range formats.  Allows existing tests to pass plus the new test with the case for these conditional formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8 Fix bug #61007
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel.  Also added tests for the failing formats.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 18:10:52 +00:00
Nick Burch
d4d08d5ce8 Use assertContains instead of assertTrue(text.contains) for better error messages on failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791857 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 06:13:33 +00:00
Dominik Stadler
511c2544a8 Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
c89d312bad #60998 - HSLFTable.setRowHeight sets row height incorrect
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791696 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 17:13:23 +00:00
Andreas Beeker
7df2a8804c findbugs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791679 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 11:02:22 +00:00
Andreas Beeker
544657556a add 3.16 to doap file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791674 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 09:50:52 +00:00
Andreas Beeker
594b46f1cd fix forbidden-apis-check error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791646 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 23:43:56 +00:00
Andreas Beeker
bd237e2483 #60996 - XSSF: Multiple embedded objects on same sheet are ignored
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791644 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 22:41:28 +00:00
Andreas Beeker
3d53258942 Website update / release guide fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791631 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 20:40:47 +00:00
Dominik Stadler
f0b2404b86 Add initial file of excludes when running with file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791594 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 10:19:49 +00:00
Dominik Stadler
14086f953f Exclude more temporary files from Git
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791593 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 10:19:44 +00:00
Dominik Stadler
30d6ba68c7 Set eclipse folder outside of build-folder to not have hickups in Eclipse whener we run 'ant clean'
Conflicts:
	.classpath

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791592 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 10:19:41 +00:00
Dominik Stadler
3e06696ae3 Revert "Add hamcrest-all to Gradle build as well"
This reverts commit e452090d41190820ec7f2591097fb9e63ad6c59c.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791587 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 09:46:54 +00:00
Dominik Stadler
89976adea2 Add hamcrest-all to Gradle build as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791586 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 09:45:23 +00:00
Javen O'Neal
21f5fc8eaf roll back to hamcrest-core
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791572 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 06:19:30 +00:00
Javen O'Neal
dc29c94460 roll back to hamcrest-core
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791570 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 06:10:23 +00:00
Javen O'Neal
abc2f1f9ea change from hamcrest-core-1.3 to hamcrest-all-1.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791567 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 05:02:07 +00:00
Andreas Beeker
160fb550c1 #60993 - HSLF: Grid and rowspan calculation in table cells is wrong
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791500 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 12:14:26 +00:00
Javen O'Neal
0acf44d3dc improve unit test error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791445 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:21:34 +00:00
Javen O'Neal
ef8c9329cf change from hamcrest-core-1.3 to hamcrest-all-1.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791444 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:19:27 +00:00
Javen O'Neal
e7ca1594da use hamcrest matchers to reduce custom code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:50:46 +00:00
Javen O'Neal
7977026f96 use assertStartsWith and assertEndsWith for better unit test error messages
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:19:24 +00:00
Nick Burch
70ae27f96d #60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791108 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 11:11:56 +00:00
Nick Burch
3bd1f662f3 Failing, disabled unit test for bug #60973
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791098 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 09:40:54 +00:00
Andreas Beeker
1078cef19c prepare for 3.17-beta1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791047 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 22:14:38 +00:00
Andreas Beeker
2bfad141fc release prepare for 3.16 - updating build.xml and status.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791045 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 22:13:33 +00:00
Greg Woolsey
b37a4e5640 The new HeapDump class uses com.sun.* classes, which the previous settings flagged as an error in Eclipse. This changes them to warnings so compilation can succeed.
Also adds a couple of prefs from newer Eclipse, apparently.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791026 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:35:06 +00:00
Greg Woolsey
6163e4ca45 Issue #60971, handle formula chart titles
implemented per issue, breaking out static text vs. formula based title getters and setters, with unit test updates and additions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791025 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:27:23 +00:00
Tim Allison
0ddc4da7e2 bug 50955 - add logging per Javen's recommendation. Thank you!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791021 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 20:00:12 +00:00
Tim Allison
9412d467f3 bug 50955 - incorporate info from the DocumentSummaryInformation for
guessing the encoding.  Back off to the old method if DocSummInfo is
not available. Thanks to Andreas Beeker for recommending this direction.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791002 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 17:07:04 +00:00
Tim Allison
44d536e4ce bug 50955 - try originally guessed codepoint, backoff to 1252 if that fails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790904 13f79535-47bb-0310-9956-ffa450edef68
2017-04-11 01:30:02 +00:00
Andreas Beeker
1f41c31984 Fix AIOOBE while extracting hssf pictures which are externally linked
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790897 13f79535-47bb-0310-9956-ffa450edef68
2017-04-10 21:43:22 +00:00
Dominik Stadler
1ce1f599bf Exclude some additional nodes from OpenJDK builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790511 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 06:56:35 +00:00
Dominik Stadler
48526517cd Adjust checking for Zip-Bomb errors so it also works on JDK >= 8
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790508 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 06:38:23 +00:00
Dominik Stadler
77614b8c49 Test for another type of xml-bomb
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790473 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:50:03 +00:00
Dominik Stadler
0f193371ea Fix issue found via large corpus tests: HSSFPicture in a HSSFShapeGroup might not have a patriarch set, so let's walk up the parents to try to find one.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790472 13f79535-47bb-0310-9956-ffa450edef68
2017-04-06 21:49:53 +00:00
Nick Burch
eb427080e8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790239 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 13:17:17 +00:00