Javen O'Neal
e355d20cfa
bug 59170: remove deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:26:58 +00:00
Javen O'Neal
ea30ed25b4
bug 57840: make it easier to replace _rows implementation (HashMap?) by making it final
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748482 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:56:56 +00:00
Javen O'Neal
ccdc23ab43
bug 59170: remove deprecated methods in o.a.p.hpsf.wellknown.SectionIDMap
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748481 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:48:23 +00:00
Javen O'Neal
e9be07056b
bug 59170: remove deprecated hpsf.Constants class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748480 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:47:04 +00:00
Javen O'Neal
07c65c3fc4
bug 57840: add comments for explicit boxing performance optimization
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748479 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 01:42:11 +00:00
Javen O'Neal
72ef600ce0
remove RegionUtil reference
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748473 13f79535-47bb-0310-9956-ffa450edef68
2016-06-14 21:57:38 +00:00
Andreas Beeker
f83ff6f8ce
javadoc fixes (jdk8)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 23:08:13 +00:00
Andreas Beeker
d8437d0476
reverted changes of r1747942 and deprecated instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 21:18:50 +00:00
Javen O'Neal
227a62ce1e
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:14:26 +00:00
Javen O'Neal
beef6df971
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:12:29 +00:00
Javen O'Neal
4a85959d45
Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748175 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:55:49 +00:00
Javen O'Neal
e61e346436
add HSSFCell.setCachedErrorResult(FormulaError)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748174 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:53:03 +00:00
Javen O'Neal
ef3564968a
type check error code when setting cell error value on HSSFCell
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:29:38 +00:00
Javen O'Neal
8bf974b185
add useless unit test for o.a.p.ss.util.RegionUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:14:44 +00:00
Javen O'Neal
84924a4918
add periods for complete sentences
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748166 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:51:01 +00:00
Nick Burch
ae11fa3dae
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748158 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:39:36 +00:00
Nick Burch
b8c13b6cc8
Javadoc fixes - @see and @link can't be combined together, at least not in Java 6
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748157 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:38:12 +00:00
Javen O'Neal
48eb5c521b
improve unit test coverage on CellReference.
...
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:58:55 +00:00
Javen O'Neal
48410a4224
fix accidental infinite recursion
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748143 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:55:41 +00:00
Javen O'Neal
4c89f44cc5
bug 58787: add an advertisement to BorderPropertyTemplate.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:44:29 +00:00
Javen O'Neal
ede81720ee
bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:40:20 +00:00
Javen O'Neal
d658ec8f95
whitespace (tabs to spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:27:18 +00:00
Javen O'Neal
889188f445
add description to gump and jenkins build targets
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748100 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:15:47 +00:00
Javen O'Neal
e4e4cbb71e
findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:02:33 +00:00
Javen O'Neal
64ae6dc0ff
findbugs: fix SF_SWITCH_NO_DEFAULT warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:38:53 +00:00
Javen O'Neal
84113f3c63
findbugs: fix SF_SWITCH_FALLTHROUGH warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:12:35 +00:00
Javen O'Neal
609d0c1826
findbugs depends on the poi, poi-scratchpad, and poi-ooxml jars being copied to build/maven
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748087 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:41:32 +00:00
Javen O'Neal
6c5cd8e400
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:34:02 +00:00
Javen O'Neal
b148307f0f
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:06:47 +00:00
Javen O'Neal
1853126f9b
findbugs: fix URF_UNREAD_FIELD warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:42:59 +00:00
Javen O'Neal
81d15d29df
whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748083 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:34:37 +00:00
Javen O'Neal
ddfb99fa47
consolidate findbugs filters using Or logic
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:09:41 +00:00
Javen O'Neal
55b675a384
fix findbugs issues
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 03:48:30 +00:00
Javen O'Neal
9d58a47e0c
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf
test copy constructor: make changes to same range: this is a better test for deepcopy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f
add copy constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:43:34 +00:00
Javen O'Neal
d68b4ea41d
move colors in TestBorderPropertyTemplate to testclass constants
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:40:46 +00:00
Javen O'Neal
0ae778e5cd
rewrite switch statements to not re-check the switch'd variable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 23:43:16 +00:00
Javen O'Neal
a63d82bbee
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 23:03:23 +00:00
Javen O'Neal
67b7e97a9f
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:59:47 +00:00
Javen O'Neal
ad98f81e5f
move check if border line style is blank before setting the border color to a helper function for readability
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:57:37 +00:00
Javen O'Neal
344b9d9884
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:33:24 +00:00
Javen O'Neal
513dfc5ff1
javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:02:38 +00:00
Javen O'Neal
e6937956f2
use CellAddress in unit tests where possible to improve readability
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:01:30 +00:00
Javen O'Neal
3530aa3bf2
javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 22:00:45 +00:00
Javen O'Neal
f9c7ae0102
javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 21:35:56 +00:00
Andreas Beeker
a696823927
fixing javadocs errors (in JDK8)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 21:28:13 +00:00
Andreas Beeker
a1ff5002a5
fixing javadocs errors (in JDK8)
...
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html )
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 20:19:59 +00:00
Andreas Beeker
1ace43ba9f
javadocs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 19:54:35 +00:00