Javen O'Neal
|
d658ec8f95
|
whitespace (tabs to spaces)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 07:27:18 +00:00 |
|
Javen O'Neal
|
889188f445
|
add description to gump and jenkins build targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748100 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 07:15:47 +00:00 |
|
Javen O'Neal
|
e4e4cbb71e
|
findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 07:02:33 +00:00 |
|
Javen O'Neal
|
64ae6dc0ff
|
findbugs: fix SF_SWITCH_NO_DEFAULT warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 06:38:53 +00:00 |
|
Javen O'Neal
|
84113f3c63
|
findbugs: fix SF_SWITCH_FALLTHROUGH warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 06:12:35 +00:00 |
|
Javen O'Neal
|
609d0c1826
|
findbugs depends on the poi, poi-scratchpad, and poi-ooxml jars being copied to build/maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748087 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 05:41:32 +00:00 |
|
Javen O'Neal
|
6c5cd8e400
|
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 05:34:02 +00:00 |
|
Javen O'Neal
|
b148307f0f
|
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 05:06:47 +00:00 |
|
Javen O'Neal
|
1853126f9b
|
findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 04:42:59 +00:00 |
|
Javen O'Neal
|
81d15d29df
|
whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748083 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 04:34:37 +00:00 |
|
Javen O'Neal
|
ddfb99fa47
|
consolidate findbugs filters using Or logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 04:09:41 +00:00 |
|
Javen O'Neal
|
55b675a384
|
fix findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 03:48:30 +00:00 |
|
Javen O'Neal
|
9d58a47e0c
|
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 01:25:50 +00:00 |
|
Javen O'Neal
|
a3e44453ca
|
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 01:00:51 +00:00 |
|
Javen O'Neal
|
75e4c452bf
|
test copy constructor: make changes to same range: this is a better test for deepcopy
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 00:50:52 +00:00 |
|
Javen O'Neal
|
ca9431d71f
|
add copy constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 00:43:34 +00:00 |
|
Javen O'Neal
|
d68b4ea41d
|
move colors in TestBorderPropertyTemplate to testclass constants
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-13 00:40:46 +00:00 |
|
Javen O'Neal
|
0ae778e5cd
|
rewrite switch statements to not re-check the switch'd variable
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 23:43:16 +00:00 |
|
Javen O'Neal
|
a63d82bbee
|
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 23:03:23 +00:00 |
|
Javen O'Neal
|
67b7e97a9f
|
rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style from NONE to THIN fails the unit test. What is the correct behavior?
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:59:47 +00:00 |
|
Javen O'Neal
|
ad98f81e5f
|
move check if border line style is blank before setting the border color to a helper function for readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:57:37 +00:00 |
|
Javen O'Neal
|
344b9d9884
|
remove public convenience methods that let the user avoid creating a CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key.
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:33:24 +00:00 |
|
Javen O'Neal
|
513dfc5ff1
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:02:38 +00:00 |
|
Javen O'Neal
|
e6937956f2
|
use CellAddress in unit tests where possible to improve readability
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:01:30 +00:00 |
|
Javen O'Neal
|
3530aa3bf2
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 22:00:45 +00:00 |
|
Javen O'Neal
|
f9c7ae0102
|
javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 21:35:56 +00:00 |
|
Andreas Beeker
|
a696823927
|
fixing javadocs errors (in JDK8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748054 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 21:28:13 +00:00 |
|
Andreas Beeker
|
a1ff5002a5
|
fixing javadocs errors (in JDK8)
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 20:19:59 +00:00 |
|
Andreas Beeker
|
1ace43ba9f
|
javadocs fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748042 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 19:54:35 +00:00 |
|
Andreas Beeker
|
0ef5f1d292
|
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748028 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 16:57:15 +00:00 |
|
Andreas Beeker
|
feead38601
|
ignore invalid performance issues - e.g. see #57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 01:18:12 +00:00 |
|
Andreas Beeker
|
6a6aa540eb
|
revert back to changes of bug 57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747945 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:54:01 +00:00 |
|
Andreas Beeker
|
f919e8bd8a
|
Common-SS: changed UDFFinder from interface to abstract class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747943 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:20:52 +00:00 |
|
Andreas Beeker
|
81d891921b
|
findbugs fixes
changed UDFFinder to abstract class and moved DEFAULT constant to factory method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747942 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-12 00:12:22 +00:00 |
|
Andreas Beeker
|
603bda4915
|
use newer findbugs version, if we run with java 7+
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747936 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 21:23:01 +00:00 |
|
Dominik Stadler
|
b9ceae5ef3
|
Add some pre-checks to fail the test with better assertion if the locale is not set correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747916 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:59 +00:00 |
|
Dominik Stadler
|
b758810081
|
Downgrade version of download-plugin as the newer one is not found by Maven
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747915 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:53 +00:00 |
|
Dominik Stadler
|
81defe041c
|
Set the correct locale for tests in the Sonar-Maven files to not fail on CI machines that have a different locale set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747914 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 17:03:46 +00:00 |
|
Javen O'Neal
|
61f0e58abb
|
make CellRangeAddresses easier to cross-reference the example with the written out workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 12:18:04 +00:00 |
|
Javen O'Neal
|
16fb41d5f1
|
make these classes more discoverable/searchable using more specific names
rename PropertyTemplate to BorderPropertyTemplate
rename Extent to BorderExtent
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 12:09:23 +00:00 |
|
Javen O'Neal
|
9e54ef68cb
|
bug 57840: lazily compute hashCode; patch from Greg Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747881 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:40:30 +00:00 |
|
Javen O'Neal
|
55546a5495
|
whitespace (tabs to spaces, 3-space to 4-space)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:35:18 +00:00 |
|
Javen O'Neal
|
be9b615048
|
bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:28:55 +00:00 |
|
Javen O'Neal
|
cea8cc65a3
|
javadoc update and boolean addLeft|Right|Top|Bottom line wrap update
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:12:04 +00:00 |
|
Javen O'Neal
|
66498c10af
|
fix spelling in javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 11:01:48 +00:00 |
|
Javen O'Neal
|
7c90716fdc
|
fix javadocs: remove unnecessary @links, remove references to CellStyle
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 10:09:05 +00:00 |
|
Javen O'Neal
|
ad11547c8a
|
move loop-invariants outside the loop for readability and execution speed
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:58:12 +00:00 |
|
Javen O'Neal
|
bd22a7be43
|
replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*
update PropertyTemplate functions to require enum instead of short borderType
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 09:15:57 +00:00 |
|
Dominik Stadler
|
9880040b1b
|
Improve output on invalid HTTP Status Code and ignore another failure to contact the TSP server
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747863 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:45:41 +00:00 |
|
Dominik Stadler
|
0c74fe60a3
|
Remove invalid removal of findbugs-zip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747862 13f79535-47bb-0310-9956-ffa450edef68
|
2016-06-11 08:45:33 +00:00 |
|