moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity
7,096 Commits 29 Branches 84 Tags 722 MiB
06083f85f4
Commit Graph

2338 Commits

Author SHA1 Message Date
David North
16a9eca7c8 My own patch to fix #56328 
Add tests for initial patch applied by Nick in r1582892

Fix and test AreaReference#isWholeColumnReference to take account of the prevailing spreadsheet version. Fixing all users of this is a big undertaking, so for now I've left a fallback on the original behaviour for some cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1685101 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-12 15:20:10 +00:00
Andreas Beeker
4acc6a84a1 Fixed TextRun handling and various junit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1684773 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-10 22:23:47 +00:00
Dominik Stadler
d3f93952e9 Bug 53109: Correctly handle unicode strings in NameCommentRecord 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682999 13f79535-47bb-0310-9956-ffa450edef68
 2015-06-01 20:49:53 +00:00
Nick Burch
7915b3ce38 Patch from René Scheibe from bug #57512 - Fix potential NPE in DateUtil for invalid dates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682796 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-31 21:18:11 +00:00
Andreas Beeker
d1f9035400 Fixed several test drivers or the implementation 
renamed font functions in HSLFTextRun

git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1682356 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 23:32:26 +00:00
Nick Burch
c5c70d3ce4 Pull out the parts of TextPainter needed by XSLF from HSLF to common-SL in core #57963 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682209 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:13:23 +00:00
Nick Burch
1b20215fc7 #57963 Move the WP and SL interface definitions to core from scratchpad, so the OOXML classes can work without scratchpad 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682204 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-28 11:06:18 +00:00
Nick Burch
77916b9364 #57951 Use BigDecimal in some cases in DataFormatter.formatRawCellContents, to avoid rounding problems on JDK8. Patch from Robert Kish 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682083 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-27 17:15:17 +00:00
Nick Burch
4e3011f70a Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682081 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-27 17:10:45 +00:00
Nick Burch
b2d1c1b6ac #56791 Make NPOIFS the default when POIFSFileSystem is requested 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681804 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 18:04:00 +00:00
Nick Burch
e4b6cb6811 Remove a long-deprecated OPOIFS related method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681801 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 17:55:23 +00:00
Nick Burch
e9f442ffa7 Fix testing for NPOIFS zero-length stream writing 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681762 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 13:56:40 +00:00
Nick Burch
e812e61ad3 Fix NPOIFS to handle dodgy excel-95 file from bug #46904 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681756 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 13:46:20 +00:00
Nick Burch
e579b78672 More 0 byte stream tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681754 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-26 13:41:29 +00:00
Dominik Stadler
001cdeb936 Apply fix reported in bug 47661 and add unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1680642 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-20 18:00:19 +00:00
Dominik Stadler
dafabdc7b9 Move location where document is held and adjust constructors and class-hierarchy accordingly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1679903 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-17 21:26:31 +00:00
Dominik Stadler
cbd315d441 Adjust error message to have the same error across different types of Workbook and revert test to check on common error message again 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678874 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-12 06:27:11 +00:00
Dominik Stadler
b3a56bd752 Adjust intendation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678814 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 20:03:36 +00:00
Dominik Stadler
eb58b83090 Provide better exception if we would access out of bounds in arraycopy for Escher properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678812 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 20:00:42 +00:00
Dominik Stadler
142e4a9f92 Avoid possible NPE found via CommonCrawl files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678811 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 20:00:18 +00:00
Dominik Stadler
5ca35be087 Add checks for invalid row number in RowRecord to find corrupted files earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678810 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 19:59:52 +00:00
Nick Burch
dd8fc66a0c #56791 More updates from OPOIFS to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678801 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:59:10 +00:00
Nick Burch
46f4c0fbd2 Leave POIFSFileSystem as a lightweight shim around OPOIFSFileSystem pending the final changeover for #56791 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678790 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:21:20 +00:00
Nick Burch
aec457dbcb #56791 More updates from OPOIFS to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678787 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:15:03 +00:00
Nick Burch
a89a9d673a #56791 More updates from OPOIFS to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678783 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 18:04:30 +00:00
Nick Burch
1945dfc00c Correct zero byte entry support in NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678778 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 17:53:59 +00:00
Nick Burch
2df3bef375 #56791 Remove long-deprecated OPOIFS related methods 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678760 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 14:26:39 +00:00
Nick Burch
252d7cc81a #56791 Default to NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678759 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 14:26:01 +00:00
Nick Burch
08bd34b20f Begin making NPOIFS the default #56791 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678677 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-11 06:29:17 +00:00
Nick Burch
c5f9a72dd1 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677565 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-04 09:17:14 +00:00
Nick Burch
e9340cc1ba If an empty stream or file is given to WorkbookFactory.create, give a more informative exception - EmptyFileException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677562 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-04 09:15:48 +00:00
Nick Burch
f911f58441 New EmptyFileException, and fix serial warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1677561 13f79535-47bb-0310-9956-ffa450edef68
 2015-05-04 09:14:48 +00:00
Nick Burch
fb4bf25259 Use a constant for the name of the OOXML encrypted package node 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1676838 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-29 19:47:35 +00:00
Andreas Beeker
e6413c3fe7 committing intermediate results - hslf is mostly migrated to common interface - junit tests partly fail - still a few compile errors - xslf drawing works - hslf drawing is not yet tested 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1676365 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-27 20:13:43 +00:00
Nick Burch
1cbac547a0 Add a common interface for 3D Pxg's 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675744 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 02:07:01 +00:00
Nick Burch
5516228367 Patch from Conor from bug #57747 - Add ISERR() function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675741 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 01:47:20 +00:00
Nick Burch
2be2a7cbfc Whitespace and comment updates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675740 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-24 01:42:21 +00:00
Nick Burch
20fa446f40 #57851 - Skip null properties in PropertyTableBase, which is how PropertyFactory reports unsupported POIFS properties 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675702 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-23 18:35:15 +00:00
Dominik Stadler
12c220121e Bug 57163: Fix possible NullPointerException when a spreadsheet has no LinkTable and we try to adjust it during sheet removal. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1673168 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-13 12:19:11 +00:00
Dominik Stadler
570819e4f6 Bug 56579: Throw exception if max string length of 32767 chars is exceeded in XSSF and SXSSF. 
Add verification testcase for bug 57008.
Move some unit tests to the Bsae-Test-Class to verify things for all SS-implementations.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1671096 13f79535-47bb-0310-9956-ffa450edef68
 2015-04-03 15:55:21 +00:00
Dominik Stadler
7bf9b90fb2 Remove some findbugs warnings about missing close of streams, use existing IOUtils.copy() to copy from one stream to another 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666683 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-14 13:18:43 +00:00
Dominik Stadler
e369d1c121 Bug 56380: Remove limitation of 1024 comments per Workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1666505 13f79535-47bb-0310-9956-ffa450edef68
 2015-03-13 16:26:41 +00:00
Nick Burch
d9b5b0239e Link to the replacement constructions for the deprecated ones, and a few extra bits of JavaDoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662979 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-28 17:49:18 +00:00
Dominik Stadler
f043c44017 * Verify some more Text-Extraction features as part of integration tests, fix some NullPointerExceptions that showed up now because the event-based extraction does not have a Document available 
* Also handle a XLSX which does not have row-numbers in the sheet-xml. Excel can read it so it makes sense to also allow to read it in the XSSFSheetXMLHandler 
* Remove some Eclipse warnings in test-code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1662691 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-27 14:58:41 +00:00
Andreas Beeker
996c9dd93c initial commit - still lots of errors, but I need to switch to a clean trunk for releasing and testing 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/common_sl@1661322 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-21 10:56:03 +00:00
Dominik Stadler
e7615fdd34 Bug 57456: Fix reading XLS with empty SSTRecord where Excel puts some random number in unique-strings-count-field 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1659650 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-13 19:14:14 +00:00
Dominik Stadler
8d8c3eeae1 Bug 57479: Typo in HSSFWorkbook javaDocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658596 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-09 22:43:56 +00:00
Dominik Stadler
6f4b4816a8 Bug 57480: Fix some unnecessary casts, generics, Eclipse warnings, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658594 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-09 22:33:24 +00:00
Nick Burch
702f8b9ee7 Finish converting ErrorEval to only use the FormulaError constants, and then finish unit test for 57535 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658190 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-08 15:37:14 +00:00
Nick Burch
d566e3948d Prepare FormulaError for both long and short codes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658187 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-08 15:22:01 +00:00
Nick Burch
557eade297 Reduce duplication between FormulaError and ErrorConstants 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1658185 13f79535-47bb-0310-9956-ffa450edef68
 2015-02-08 15:17:20 +00:00
Andreas Beeker
70dbed4513 The default for standard encryption cipher algorithm was wrongly set to rc4 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1654716 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-26 00:02:20 +00:00
Nick Burch
9ccc610f6a Fix TIKA-1515 - Handle Excel 3 files with a 0x8001 codepage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1651517 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-13 22:13:24 +00:00
Dominik Stadler
113edb1a76 Adjust Bin2Dec similar to what we did for Hex2Dec in Bug 57196 and fix some smaller problems in the implementation found while adding full unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650654 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-09 20:37:11 +00:00
Dominik Stadler
c8bf92f963 Bug 57196: Resolve RefEval to it's inner ValueEval in Hex2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650597 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-09 16:51:02 +00:00
Dominik Stadler
8997d8900d * Add missing close() on streams in ImageUtils.getImageDimension() 
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-07 14:36:39 +00:00
Andreas Beeker
0ea9f5fff9 Test and fix for bug #46441 
Use generics on Shape.getEscherChild() and SimpleShape.getClientDataRecord() to minimize casting
Unify access to Shape.getEscherOptRecord()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649152 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 22:57:05 +00:00
Dominik Stadler
b930f0c46c Include seen invalid index in thrown Exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649125 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 21:07:25 +00:00
Dominik Stadler
302db39cb7 Fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649123 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 21:06:51 +00:00
Dominik Stadler
12edcc5ed2 Bug 46192: Add methods to query outline level for HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1649107 13f79535-47bb-0310-9956-ffa450edef68
 2015-01-02 20:03:28 +00:00
Andreas Beeker
26ae1edcd8 Bug 49541 - Mapping of symbol characters to unicode equivalent 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648415 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-29 19:43:35 +00:00
Dominik Stadler
bfffe6cb4f Add missing license header for new file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648254 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 21:25:42 +00:00
Dominik Stadler
a0248ff4f0 Bug 57007: Add initial implementations of DMIN and DGET functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648166 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 10:47:41 +00:00
Dominik Stadler
7c9d23d887 Remove unused local variable 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648159 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 09:09:11 +00:00
Dominik Stadler
5173eca9ea Fix Eclipse warnings, unnecessary casts, use generics, static access... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-28 09:06:12 +00:00
Andreas Beeker
4bed984c0f Charset.forName() for known encodings makes catching UnknownEncodingException obsolete 
Unify UTF-16LE conversion to StringUtil
BugFix for RecordInputStream.readFully in combination with continuing records
BugFix for integration tests - fix pathname for handler/exclude lookup on windows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648032 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-27 01:33:28 +00:00
Nick Burch
5ce675f345 Fix inconsistent whitespace/indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647884 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-25 09:13:40 +00:00
Dominik Stadler
c7044b77aa Add javadoc to CellRange.getReferenceText() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647883 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-25 08:59:16 +00:00
Andreas Beeker
202aa8177f - Support for Office Binary Document RC4 CryptoAPI Encryption for HSLF 
- Support for Office Binary Document RC4 Encryption
- use LittleEndian class in LittleEndianInputStream
- add normalize method for HSLF, to remove edit history, which is also necessary for encryption support
- update PersistDirectoryEntry handling in PersistPtrHolder to recognize groups while serializing
- deprecated PersistPtrHolder.getSlideOffsetDataLocationsLookup() - throws now UnsupportedOperationException,
  as this wasn't used outside the scope of the class and was quite internal logic of PersistPtrHolder


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647867 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-25 01:56:29 +00:00
Dominik Stadler
7ee9ce8388 Fix two Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647325 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 14:56:47 +00:00
Dominik Stadler
a7ba500280 Bug 56595: Also switch the cache in DateUtil.isADateFormat() to ThreadLocals to not have another syncpoint here. Again only very little data is kept, so no memory bloat should happen because of this. 
Also do more simple checks before actually looking at the cache

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647296 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 12:08:59 +00:00
Dominik Stadler
a98c9daa01 Some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647269 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 09:16:16 +00:00
Dominik Stadler
0fdfac62c9 Bug 57171 and 57163: Adjust the active sheet in setSheetOrder() and removeSheet() for both HSSF and XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647264 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 09:00:18 +00:00
Dominik Stadler
76af8804d5 Bug 57231: Add missing ArrayRecord.clone() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647255 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 08:17:56 +00:00
Nick Burch
c975b754d1 Expose the version information from OldExcelExtractor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1647244 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-22 05:59:51 +00:00
Andreas Beeker
181d135fb9 Added link to test cases for the workarounds 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1645344 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-13 19:00:00 +00:00
Andreas Beeker
1460fd33b2 Added workarounds to tests for JDK 6 LineBreakMeasurer bug and handle it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1644806 13f79535-47bb-0310-9956-ffa450edef68
 2014-12-12 01:43:45 +00:00
Nick Burch
680feb50ee Correct older biff detection, and add unit tests for HSSFWorkbook giving helpful exceptions on the older formats 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642568 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 17:09:03 +00:00
Nick Burch
fd9a2b0527 Update TODOs for what remains 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642567 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 17:07:45 +00:00
Nick Burch
6873214113 More detection for older Excel formats when opening the POIFS Stream, and a more specific exception for non-OLE2 files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642565 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 16:59:06 +00:00
Nick Burch
0c32d34bef On Biff5 files, include the sheet name. (Older formats are single sheet) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642563 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 16:40:53 +00:00
Nick Burch
be469c985f Track the codepage in old excel files, to be able to correctly decode the 8 bit strings in them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642561 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 16:21:39 +00:00
Nick Burch
77bf6ef42b Track what Biff version we are working on, and use that to work around Biff 2 and 5 having the same formula record sid for different layouts 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642556 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 15:54:34 +00:00
Nick Burch
a1fffd7d04 Switch to POITestCase / assertContains 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642549 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 14:36:01 +00:00
Nick Burch
101f66c789 Begin adding Excel 5 support to OldExcelExtractor for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642548 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 14:22:06 +00:00
Nick Burch
41ba513d11 Formula values for Excel 4 extractor, for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642497 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 01:30:43 +00:00
Nick Burch
17b050c66f Largely there with the Excel 4 extractor, for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642493 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 01:20:16 +00:00
Nick Burch
738c518474 Further Excel 4 text extractor support, for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642492 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 01:03:24 +00:00
Nick Burch
553964a455 Further Excel 4 text extractor support, for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642491 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 00:48:17 +00:00
Nick Burch
48ab7bf987 Start on a Text Extractor for the pre-OLE2 Excel formats like Excel 4, for TIKA-1490 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642490 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-30 00:16:23 +00:00
Dominik Stadler
8bf3ebfcee Remove some Eclipse warnings, remove confusing FunctionID/ID renaming... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642035 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-27 07:07:29 +00:00
Dominik Stadler
4c451f44ed Add more output in case of unknown cipher-ids to aid in debugging bugs like 57195 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641883 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-26 18:39:44 +00:00
Andreas Beeker
3f77a96e47 revert of r1639217 and offline-linking for maven javadocs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1639807 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-15 00:00:30 +00:00
Andreas Beeker
39ba1ba707 Javadoc warnings fixed: 
Now that the javadocs are split, the reference from one module to another need to be url links

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1639217 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-13 00:30:48 +00:00
Nick Burch
2608583130 Add boolean getters/setters for bold to font, matching italic and underline, plus matching xssf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638954 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-12 19:11:20 +00:00
Andreas Beeker
45fb6c5b18 Picture method to resize with different scales in width and height 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1638623 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-12 00:19:00 +00:00
Dominik Stadler
0f0c16f56d Add some missing close() calls and fix some generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637703 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-09 17:53:10 +00:00
Nick Burch
82ee923858 Patch from hishidama to add Cell.removeHyperlink(). This closes #13 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637562 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-08 13:46:30 +00:00
Dominik Stadler
80bc816ecc Fix some eclipse warnings, newlines, javadoc, generics, ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637367 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 13:02:00 +00:00
Dominik Stadler
eb44db4d9c Bug 57003: Add implementation of function FIXED 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637361 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-07 12:29:05 +00:00
Nick Burch
85d0a161b0 Patch from hishidama to add Sheet.getDataValidations() for HSSF and XSSF. This closes #11 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636857 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-05 12:14:54 +00:00
Nick Burch
20438f4db5 Patch from hishidama to add Comment.getClientAnchor(). This closes #12 from github 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636782 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 23:55:23 +00:00
Nick Burch
3300ac2a56 FilePassRecord type of 4 is now documented as the same as 2 & 3, see bug #35897 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636776 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 23:22:50 +00:00
Nick Burch
4923afc9f8 Fix bug #57185 - Should be Series not Serie, latter is incorrect English / a Typo 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636755 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 22:11:07 +00:00
Nick Burch
0fdd7a1dbc Partial HSSF support for adding new external workbook formula references for #57184 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636742 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 21:35:01 +00:00
Nick Burch
4b479d98c4 Improve BiffViewer output for SupBookRecord 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636725 13f79535-47bb-0310-9956-ffa450edef68
 2014-11-04 20:11:35 +00:00
Nick Burch
8616a88a86 Add missing HSSFWorkbook constructor javadocs #57166 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635533 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 16:19:54 +00:00
Dominik Stadler
8a82d32ae8 Apply patch for bug 57151: Document CellRangeAddress and add some validation to prevent invalid row/column combinations. 
Cover class CellRangeAddress fully in unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635389 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-30 05:53:06 +00:00
Cédric Walter
d59c8f47be Bug 57150: Added EOMONTH function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634515 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-27 12:29:32 +00:00
Andreas Beeker
8dcdbe9c1a Bug 57143 - Javadocs and throws clause for WorkbookUtil 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634412 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-27 00:36:13 +00:00
Andreas Beeker
f818d1fdb7 house keeping - fixes for sonarqube blockers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1634255 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-25 21:32:03 +00:00
Dominik Stadler
5706aab18c Bug 57010: Add implementation of function PROPER 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1633215 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-20 19:57:11 +00:00
Nick Burch
508f36d702 SheetUtil helper for finding the main cell of a merged region, if in one 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632833 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-18 19:58:05 +00:00
Nick Burch
8137193852 Add a note on how this is not the right way to make a string of your cell 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1632438 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-16 21:41:11 +00:00
Andreas Beeker
daa7d17531 Bug 57080 - IndexOutOfBoundsException in poi decryptor 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1631600 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-13 23:42:33 +00:00
Dominik Stadler
2d04f98cd1 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629656 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:43:37 +00:00
Dominik Stadler
8dde4b0ae4 Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:39:35 +00:00
Dominik Stadler
d254ec8ec1 Print out current version of java before building to allow to see in build output if we use a supported Java VM version 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
 2014-10-06 13:20:12 +00:00
Andreas Beeker
da4201c2cd more tests, some refactoring 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1628107 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-28 22:30:02 +00:00
Andreas Beeker
b410e72196 merge with trunk 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
 2014-09-17 21:12:36 +00:00
Andreas Beeker
777fd47d71 some changes because of test errors 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1618254 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-15 18:19:28 +00:00
Andreas Beeker
63f8c1dcf0 Xml signature support - version 1 
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1617141 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-10 18:25:10 +00:00
Andreas Beeker
3cd1cd6e70 Another test for NPOIFS in-place writing support - probably the deletion of an entry causes the problem 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615273 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-02 00:51:56 +00:00
Nick Burch
0e44d8da73 Fix bug #56800 - Provide a helpful exception, XLSBUnsupportedException, if XSSFWorkbook is passed a .xlsb file 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1615118 13f79535-47bb-0310-9956-ffa450edef68
 2014-08-01 14:33:17 +00:00
Nick Burch
2ee05730bd Fix bug #55050 - If the start+end row and cell are the same on an AreaPtg, avoid inverting the relative flag 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614928 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 16:06:43 +00:00
Nick Burch
de0d2a0935 Fix javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614886 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:37:33 +00:00
Nick Burch
65e23c7ea9 Fix bug #53984 - Support the ColInfoRecord coming after the cells, rather than before as is normal, and also handle things so that if an unsupported BofRecord is found for a sheet, warn and skip rather than breaking 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614884 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-31 13:31:01 +00:00
Nick Burch
f16296111b Correct logic for the start-of-sheet missing rows, for event user model, and add tests for this 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614789 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 23:06:46 +00:00
Nick Burch
bdb9bbccc1 Start on details tests for bug #53433 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614786 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 22:43:31 +00:00
Nick Burch
64187356aa #56132 Allow XSSF formula evaluation to also skip missing external workbook references, if requested 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614729 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 18:08:28 +00:00
Nick Burch
797f3368d6 Patch from Sofia Larsson and Martin Andersson from bug #56020 - XSSF support for creating Pivot tables 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1614684 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-30 15:27:09 +00:00
Dominik Stadler
51649dbdfa Add/Fix some Javadoc 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613826 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-27 18:32:24 +00:00
Nick Burch
59861b7836 Complete evaluation support for multi-sheet references for bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:42:31 +00:00
Nick Burch
2438213bd8 Begin required interface + base-class support for multi-sheet area references for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613460 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 16:15:47 +00:00
Nick Burch
97c4bbc9b8 Allow XSSF to evaluate multi-sheet references too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:55:49 +00:00
Nick Burch
3872e620a7 Update the RefEval method signature to cope with multi-sheet references, and have appropriate functions take advantage of this. For bug #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613453 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 15:46:05 +00:00
Nick Burch
d97867e5be Start preparing LazyAreaEval and LazyRefEval to handle sheet ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613443 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:50:44 +00:00
Nick Burch
3e2e01c149 Update the XSSF getExternalSheet method signature, to start to prepare for sheet ranges 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613439 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:23:21 +00:00
Nick Burch
4c8f3ab160 More tests for #55906, and provide a new eval that lets you get at evals for many sheets 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 14:15:56 +00:00
Nick Burch
96386e2e0a Areas can have multi-sheet references too, so add FormulaParser support to these as well 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 13:59:07 +00:00
Nick Burch
8f4fac46ee Update Ref3DPxg to support multi-sheet ranges too, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613376 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:22:21 +00:00
Nick Burch
0dde805ec7 Refactor to reduce clutter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613374 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:10:52 +00:00
Nick Burch
29e5928c42 More progress towards #55906 - Have the ExternSheet references set up for multi-sheet references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613373 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-25 10:05:57 +00:00
Nick Burch
1161077a6b More progress towards #55906 - FormulaParser is able to identify and parse multi-sheet references, but not yet fully round-trip them. (No evaluation support yet either) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613317 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 22:44:51 +00:00
Nick Burch
e27a6e5466 More internal method signature updates, for HSSF external sheets being possible ranges, for #55906 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613307 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:35:47 +00:00
Nick Burch
7f6ba5513c Rename some of the internal HSSF sheet lookup methods which deal with external sheet indicies, to make it clear when they return the first sheet name/index, and add support for getting the last one too (will be the same as the first if not a range) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613305 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:25:45 +00:00
Nick Burch
1fc5397a59 #55906 Extern Sheet References can have a last as well as a first sheet 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613302 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 21:10:13 +00:00
Nick Burch
a41a4fd118 Patch from thaichat04 from bug #56194 - HPSF thumbnail format tags are int not unit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613256 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 19:34:19 +00:00
Nick Burch
4c98f1db45 Patch from Raúl Wegmann from bug #56735 / GitHub Pull #10 - Rationalise POI temp file creation to the TempFile util class, and allow a system wide setting of where Temp files (eg for SXSSF) go, via TempFile / TempFileCreationStrategy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613246 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 18:58:27 +00:00
Nick Burch
70b21ffe56 Fix javadoc warning 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613176 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:26:34 +00:00
Nick Burch
0c8112b84a Correct HSSFOptimiser logic for the case where the to-keep style wasn't previously in use. Fixes #54443 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613175 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:25:58 +00:00
Nick Burch
f91eee5846 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613174 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 16:22:28 +00:00
Nick Burch
fec4eb7a12 When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:56:23 +00:00
Nick Burch
f06915e95d Don't fetch the name, convert to a ptg, then convert back again, instead simply return the name directly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613153 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-24 14:37:09 +00:00
Dominik Stadler
b6dd3bca34 Bug 56688: Fix border cases in EDATE function: handle RefEval and BlankEval and also return #VALUE, not #REF if case of error 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612557 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 12:31:56 +00:00
Dominik Stadler
3f9c701688 Fix formatting of trailing comma in HexDumps, cover class fully with tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612496 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-22 07:47:14 +00:00
Nick Burch
12e87a1900 Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 12:23:54 +00:00
Nick Burch
79f3f4bb06 Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612219 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:45:44 +00:00
Nick Burch
3db4f0b82c Allow creating a CollaboratingWorkbooksEnvironment from a Map too, not only a pair of arrays 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612218 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 09:44:21 +00:00
Nick Burch
d43121661c Correct non-sheet-based NameXPxg formula rendering, and add tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612203 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-21 07:35:09 +00:00
Nick Burch
05dc1ec70c Change how we update sheet names in XSSF formulas and names, when renaming sheets, to take advantage of the simpler structure that Pxg now offers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612151 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:56:35 +00:00
Nick Burch
a550397ac2 XSSF Pxgs must escape sheet names where required when generating the formula string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612150 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:53:27 +00:00
Nick Burch
44a6aef699 Common interface across the XSSF Ptg / Pxg classes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612149 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:48:48 +00:00
Nick Burch
4345b06cab Rename missing from previous commit 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612140 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 18:14:47 +00:00
Nick Burch
42cd819573 Update the formula evaluator to support XSSF style external named ranges too 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612133 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-20 17:51:51 +00:00
Nick Burch
0b1dee9913 Better reporting on why a test is failing, and partial NameXPxg eval 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611969 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 21:27:28 +00:00
Nick Burch
ed7140b3d8 Move towards supporting same workbook named ranges in external style for xssf 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611961 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:51:23 +00:00
Nick Burch
58096a6862 Start to add XSSF specific handling for NameX (named ranges or functions from another file) #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611958 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 20:30:31 +00:00
Nick Burch
86ca81d22f Provide XSSF-style external sheet support for areas, similar to the recent cell reference support. #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611950 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:42:07 +00:00
Nick Burch
84b50e845e Fix inconsistent indents/whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611949 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:23:13 +00:00
Nick Burch
2cd4290460 Start to update how the formula parser looks up sheets from formula ptgs, to account for the differences in how HSSF and XSSF store references to external sheets. For #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611948 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:19:06 +00:00
Nick Burch
0986f32d46 Fix inconsistent indents 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611947 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:11:54 +00:00
Nick Burch
c392b4fa72 The Event User Model fake-workbook for formula evaluations needs to know about the sheet names 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611946 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:10:47 +00:00
Nick Burch
fbcf64087d Fix Generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611944 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 19:00:09 +00:00
Nick Burch
7c382f9f37 The way that HSSF and XSSF stores references to external sheets are rather different, so begin to reflect that in how we parse their formulas into Ptgs 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611906 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-19 12:49:41 +00:00
Nick Burch
4c362590d8 Start to support formula parsing of sheet-specified named ranges, required for a full fix to bug #56737 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611753 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 18:30:16 +00:00
Nick Burch
6e37f73018 Have WorkbookEvaluator process NameXPtgs, rather than returning a NameXEval which later places didn't handle. Largely allows us to process the .xls version of the test file for #56737 (but filenames aren't quite the same as in Excel) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611711 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 16:58:38 +00:00
Nick Burch
d4a1239efa #56737 Sometimes Excel writes an internal reference to a local name in an odd way, without an ExternalNameRecord, try to detect and work around those 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1611681 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-18 15:59:55 +00:00
Nick Burch
dd6819aa13 When throwing an exception during formula evaluation, if this is due to an unimplemented function, have a more specific exception type 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607588 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-03 11:20:32 +00:00
Dominik Stadler
e34e77b12d Bug 56537: Update javadoc to reflect the addition of Closeable to Workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1607390 13f79535-47bb-0310-9956-ffa450edef68
 2014-07-02 15:05:05 +00:00
Dominik Stadler
9d1d93b88f Add missing @Overrides, reformat some files, increase coverage slightly, 
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 20:36:30 +00:00
Nick Burch
47a8f6cf48 Partial fix for #56537 - Have Workbook offer a close() method, which in turn closes the NPOIFS or OPC resource from which it was loaded 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1601901 13f79535-47bb-0310-9956-ffa450edef68
 2014-06-11 13:48:54 +00:00
Nick Burch
11a095bb3d HSSFCell should follow XSSF, and allow setting a null-style to return to the default style, fixes bug #56572 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1598258 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-29 11:39:50 +00:00
Dominik Stadler
8c6e7e06aa Fix for 56563 - Multithreading bug when reading 2 similar files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597637 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-26 20:03:08 +00:00
Nick Burch
834973efe0 If a NoteRecord has no author tag, it seems it can sometimes be double padded. Fixes #47251 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597098 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 14:07:20 +00:00
Nick Burch
6cc94cdae8 Handle date format strings in an iso8601 style format, with a T in them. Fixes bug #54034 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597038 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-23 09:18:16 +00:00
Dominik Stadler
47ea1aa486 Bug 53691: Fix a copy/paste error in CFRuleRecord.clone() 
also make CFRuleRecord.toString() print out more information which caused the bug to be much harder to find
Add unit tests to verify/reproduce this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1596251 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-20 14:01:22 +00:00
Dominik Stadler
8e6c459d83 Bug 56325: fix Exception when removing sheets with named ranges in the workbook 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1595048 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 21:14:52 +00:00
Nick Burch
4d2a90d3ec Add a HSSF print paper size constant for "printer default" for bug #56509 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594848 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-15 10:15:04 +00:00
Andreas Beeker
00e2e55338 Bug 56486 - Add XOR obfuscation/decryption support to HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592636 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-05 21:41:31 +00:00
Andreas Beeker
337f775807 Bug 56269 - DateFormat - Rounding of fractionals 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592419 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 21:17:18 +00:00
Andreas Beeker
234ad7f85e The NPOIFS-classes result currently in left-over memory mapped buffers. 
These are actually hard to workaround, so for Windows the test is ignored, if this error happens.
http://stackoverflow.com/questions/3602783/file-access-synchronized-on-java-object 

Apart of that, the RandomFileAccess instance is saved in the FileBackedDataSource as it needs to
be closed instead of the Channel.
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4796385

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592418 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 20:58:42 +00:00
Dominik Stadler
4112a8441e File leak detector: Close streams in some tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1592315 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-04 08:05:32 +00:00
Nick Burch
ee0cddaf9a Excel 2007 and later allows for more than 3 Conditional Formatting rules per sheet, so change our hard limit to logging a compatibility warning. Test file from Pau Coma Ramirez from bug #56482 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591959 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 15:49:23 +00:00
Nick Burch
305ce3123b Generics warnings fixes 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1591838 13f79535-47bb-0310-9956-ffa450edef68
 2014-05-02 09:15:23 +00:00
Nick Burch
ba4225395f Provide a convenience method for creating a PropertySet from a Directory + Entry 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590650 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:19:13 +00:00
Nick Burch
52c6fd587c Fix generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590642 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 14:03:18 +00:00
Nick Burch
3a5825c43f Update the HPSF change properties example to use NPOIFS + in-place writes, and have NPOIFS give a helpful error if you try to in-place write on a read only open 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590577 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 09:22:58 +00:00
Nick Burch
a57e1f1fa6 Get NPOIFS in-place-write working! 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590556 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-28 06:35:39 +00:00
Nick Burch
3e6cb71fb9 More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:50:00 +00:00
Nick Burch
f649abdbe9 Fix javadoc layout 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590317 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 22:43:23 +00:00
Nick Burch
0496d8f330 Convert the HPSF test to JUnit 4, and add a bit more testing for NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590309 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-26 21:51:28 +00:00
Nick Burch
73bc57db74 NDocumentOutputStream write logic 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590191 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:34:09 +00:00
Nick Burch
b77ce4fede Fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590190 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:33:16 +00:00
Nick Burch
c3769b5da0 Begin to support and test in-place changes to documents within a NPOIFS stream 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 23:07:00 +00:00
Nick Burch
868a108fe3 Support for replacing the contents of a Document in a NPOIFSFileSytem, in place 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590177 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:40:51 +00:00
Nick Burch
0bdc025279 When deleting a document in NPOIFS, free the underlying blocks 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590160 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 22:00:30 +00:00
Nick Burch
b1dd6b403f Add a getEntryNames() method to POIFS/NPOIFS directory entries, to make listing easier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590148 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 21:10:52 +00:00
Nick Burch
6a89a9afbf More NPOIFS mini stream improvements, and more tests for it all 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:39:31 +00:00
Nick Burch
e4e0e93ff5 Correct mini stream initialisation, and enable more npoifs write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 18:14:28 +00:00
Nick Burch
4b6ae05a04 More NPOIFS tests, and a partial mini-stream fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-25 17:06:10 +00:00
Nick Burch
1fc66d1f71 Correct NPOIFS mini stream first write bug, and add more NPOIFS stream write tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589881 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 21:08:34 +00:00
Nick Burch
a94f150450 More NPOIFS write testing, and fix a problem with writing xbat details out 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589806 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:44:10 +00:00
Nick Burch
b2a35bb494 More unit tests for NPOIFS writing, and correct a bug in how bats get allocated in xbats. (Some issues still remain) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589800 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 17:25:10 +00:00
Nick Burch
fbd86d5084 More int/long sizing fixes for >2gb NPOIFS files, see bug #56447 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589783 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 16:15:21 +00:00
Nick Burch
e7dff43065 Fix bug #56450 - Avoid a NPE if a comment has no associated NoteRecord (but we still don't know where it belongs) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1589770 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-24 15:42:53 +00:00
Andreas Beeker
14a7ae6316 Bug 56437 - [PATCH] Streaming write support in NPOIFS 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588887 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 14:37:33 +00:00
Andreas Beeker
821d3ca5bd Some encryption fixes: 
- don't rely on SecretKey object having the right algorithm set
- leave encryption-description parsing of string/stream to xmlbeans and refactor it to one location
- use namespaces of schema instead of hard-coded strings
- use CryptoFunctions.getMessageDigest() instead of code duplication

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588874 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-21 12:16:54 +00:00
Dominik Stadler
0974acc778 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-18 18:20:15 +00:00
Nick Burch
d2d289b90f Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
 2014-04-15 21:59:52 +00:00
Cédric Walter
730deb782b performance issue: call toString() on a String object. This is entirely redundant. 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 16:01:39 +00:00
Cédric Walter
a0d1ab5add performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-31 15:54:52 +00:00
Nick Burch
f52fe377ae Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-28 21:54:30 +00:00
Nick Burch
2a7cebf8c0 Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-09 09:49:06 +00:00
Dominik Stadler
7e21a14172 Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 16:46:59 +00:00
Dominik Stadler
8c5115aeb1 Fix Sonar issues about finalize() usage 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-08 08:41:25 +00:00
Andreas Beeker
3fe86eca24 Added MD4-option and some cleanups 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-06 00:53:09 +00:00
Nick Burch
f6a5959788 POI is now on JDK 1.6, so remove 1.5 workaround 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68
 2014-03-04 11:57:44 +00:00
Andreas Beeker
833ae007f8 Bug 56076 - Add document protection with password support to XWPF 
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-21 23:19:57 +00:00
Andreas Beeker
2cfc8dbf17 FindBugs fix 
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 23:36:32 +00:00
Nick Burch
c144310a15 Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 19:35:55 +00:00
Andreas Beeker
2a14920cdd FindBugs fix 
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-16 16:30:24 +00:00
Dominik Stadler
023fa18794 Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 10:43:58 +00:00
Dominik Stadler
9b4121cb45 Update Javadoc somewhat 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-15 00:19:32 +00:00
Andreas Beeker
92a488a28b FindBugs fix 
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-14 01:00:45 +00:00
Andreas Beeker
3ceb93b23d FindBugs fix 
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-13 23:34:11 +00:00
Andreas Beeker
413e76aed0 FindBugs fix 
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-09 21:19:20 +00:00
Nick Burch
d07ce077f5 Fix whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563660 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:44:30 +00:00
Nick Burch
e023d34c9a Add setIncludeHeadersFooters(boolean) to the ExcelExtractor common interface, as all implementations now have the method 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563658 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:41:27 +00:00
Nick Burch
720b4a3aad Have the Excel text extractors all implement the same interface, as best as they can 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-02 16:23:26 +00:00
Andreas Beeker
5d0f69097c Bug 51891 - Fix StringIndexOutOfBoundsException : Ole10Native.<init> (parsing word file) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563483 13f79535-47bb-0310-9956-ffa450edef68
 2014-02-01 21:45:48 +00:00
Andreas Beeker
474c4eec6a jdk 5 compiler doesn't support overwrite for interfaces ... 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561406 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-25 21:56:08 +00:00
Nick Burch
d2687261e3 Patch from Detlef Brendle from bug #55873 - Support for COUNTIFS function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1560736 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-23 16:43:59 +00:00
Andreas Beeker
439ad29071 Added license headers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-18 00:38:04 +00:00
Andreas Beeker
1eba8faedb Bug 35897 - Password protected files 
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 23:14:03 +00:00
Nick Burch
0e5300538f Ensure our package html files have consistent line endings, and the right svn properties set on them 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557156 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-10 15:39:39 +00:00
Dominik Stadler
d714d0da65 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
 2014-01-01 22:15:44 +00:00
Dominik Stadler
5e77641784 remove some unused imports and some useless TODOs, slightly more 
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:12:30 +00:00
Dominik Stadler
dcc34ec845 Don't unnecessarily convert from ArrayList to array, use the ArrayList directly instead, this speeds up BiffViewer and related unit tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554534 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:59 +00:00
Dominik Stadler
d83461c3fb Print out which actual value was out of range 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554533 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-31 15:11:44 +00:00
Andreas Beeker
f32e87957c obsoleted by TestEscherBlipRecord and EscherMetafileBlip 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554104 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-30 00:00:54 +00:00
Nick Burch
e961fe6e94 Fix whitespace - reformat to consistent spaces, instead of a mix of tabs and spaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553625 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-27 04:26:18 +00:00
Dominik Stadler
60ca1a5de4 Add some @Overrides suggested by Eclipse, generics and some warnings, 
convert some tabs to spaces.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553466 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 09:38:48 +00:00
Andreas Beeker
e34a1f9620 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-26 00:46:16 +00:00
Andreas Beeker
3ccd728544 javadoc house-keeping 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553422 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 22:18:53 +00:00
Dominik Stadler
bc7b658ea9 Fix some JavaDoc items that are reported in the build-output 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 18:05:41 +00:00
kiwiwings
3a36da330a JCE policy fix 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553342 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-25 01:04:29 +00:00
kiwiwings
c72965c8b2 Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553339 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:49:10 +00:00
kiwiwings
abac580a6e Fix jdk-differences for encryption patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553338 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:39:09 +00:00
kiwiwings
ad9cecae59 Patch for Bug/Enhancement 55818 - add encryption support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553336 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 23:13:21 +00:00
Yegor Kozlov
ff79d73725 patch 55731: StringBuilder logic in DataFormatter.cleanFormatForNumber 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553248 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 06:02:27 +00:00
Yegor Kozlov
ed5942640f patch 55730: Fix org.apache.poi.ss.usermodel.BuiltinFormats.java for 0x29-0x2c 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553247 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-24 05:58:23 +00:00
Nick Burch
87375a5b46 Fix bug #55901 - Avoid using RMI based 
exception from PropertySetFactory, as it's not needed nor helpful

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551832 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-18 04:08:03 +00:00
Nick Burch
43383ec1f4 More javadocs for Cell.setCellType 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1550349 13f79535-47bb-0310-9956-ffa450edef68
 2013-12-12 05:22:26 +00:00
Cédric Walter
73ee268e56 Bug 55768: added Line charts support and setting axis tick marks, title 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544628 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 18:26:11 +00:00
Cédric Walter
e9b8faa748 Bug 54676: added new chart axis type: Category axis 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544612 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-22 17:45:00 +00:00
Nick Burch
44c9f41cc9 Patch from Andreas Beeker from bug #53475 - Switch XWPF test to JUnit 4, so that we can skip one part of the tests if the JVM doesn't support larger keys 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544121 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-21 11:18:23 +00:00
Nick Burch
d1118ce0d5 Patch from Andreas Beeker from bug #53475 - further OOXML Encryption support, covering more ciphers 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541009 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-12 11:37:45 +00:00
Nick Burch
c6177274af Start on HSSF/XSSF Shrink To Fit support, see bug #55661 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539848 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 22:28:06 +00:00
Nick Burch
d45b6acef3 Patch from Andreas Beeker from bug #49237 - HSSF Row Style XfIndex is 12 not 16 bits of data 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539837 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 21:56:49 +00:00
Nick Burch
f7b44f5e9f Patch from Andreas Beeker from bug #53475 - CSPName may not always be present on OOXML encrypted documents, plus test 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539828 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-07 21:29:14 +00:00
Cédric Walter
224b66e8d4 Bug 55742: fixed mirr FormulaEvalTestData.xls tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539451 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-06 20:09:43 +00:00
Cédric Walter
28b14db09a Bug 55742: fixed hex2dec tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539447 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-06 20:04:22 +00:00
Cédric Walter
3976993fda Bug 54696: Add overlay setting to ChartLegend 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539169 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 22:35:54 +00:00
Cédric Walter
fc086aba47 Bug 55724: implementation of Excel PERCENTILE function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539154 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 22:11:18 +00:00
Cédric Walter
fac5f0ea50 fixed red build, cause by invalid java 5 method isEmpty and unmappable character for encoding ASCII 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1539127 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-05 20:46:20 +00:00
Cédric Walter
d8c54be1aa Bug 55024: MIRR Formula implementation review, added error handling and FormulaEvalTest.xls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538795 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 22:52:06 +00:00
Cédric Walter
eab0adda8b Bug 54535: Bug in INTERCEPT and SLOPE, review and integration test added to FormulaEvalTestData.xls 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538772 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 21:27:12 +00:00
Cédric Walter
6cb3b01753 Bug 55742: Apply patch for Oct2Dec and refactor Hex2Dec to also use BaseNumberUtils.convertToDecimal 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538765 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-04 21:09:40 +00:00
Dominik Stadler
8d345b13d0 Fix Bug 54400 by updating the index in the LinkTable whenever sheets are 
removed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538163 13f79535-47bb-0310-9956-ffa450edef68
 2013-11-02 10:01:01 +00:00
Nick Burch
01b276b2f3 Allow formatting of formula error cells, giving back the error string that Excel shows #55729 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1537552 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-31 16:53:03 +00:00
Dominik Stadler
d08ab9dc0d Slightly more test-coverage in HSSFSheet/XSSFSheet/SXSSFSheet and fix some Eclipse warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1537331 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-30 22:26:13 +00:00
Dominik Stadler
f82527ecb1 Re-use functionality from HSSFWorkbook in dev-tools to find the 
dir-entry-name to make special names like WORKBOOK or BOOK work, handle
a special case in ExternalNameRecord when the flag states that there is
data, but no data remains in the stream, slightly improve error-output
in DirectoryNode, adjust all dev-tools-tests to not report stack-traces
any more for expected failures and try with HSSFWorkbook to decide if it
is an expected failure or now.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1536062 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-27 08:16:29 +00:00
Dominik Stadler
780aec8ad2 Add a number of tests for the dev-tools. The tests iterate over all .xls 
files that are found under test-data, any newly added file or
code-change which breaks one of the dev-tools will cause the tests to
fail in the future. Known broken files can be excluded.

Also fixes two points where some files could cause BiffViewer to fail.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535885 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-25 21:57:48 +00:00
Yegor Kozlov
616238f8e2 Patch 55612 - Performance improvement in HSSFCellStyle.getDataFormatString() 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535810 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-25 18:41:24 +00:00
Dominik Stadler
5ad89d96b6 Fix some Eclipse warnings, remove trailing whitespaces 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1535517 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-24 19:58:19 +00:00
Nick Burch
b646166b6c Have HSSFWorkbook check for an encrypted .xlsx file when opening, and give a helpful error if found, plus tests. Fixes #55692 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1534967 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-23 09:43:28 +00:00
Yegor Kozlov
689f027749 Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533768 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-19 14:12:15 +00:00
Yegor Kozlov
4243b72fc2 Patch 55611 - Performance improvement in DateUtil.isADateFormat(int, String) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1533764 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-19 13:53:19 +00:00
Yegor Kozlov
cf7a4c117a Bugzilla 55578 - Support embedding OLE1.0 packages in HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531623 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-13 07:39:40 +00:00
Yegor Kozlov
489b0b5bdb Bugzilla 49658 - Support embedding EMF/WMF pictures in HSSF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531622 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-13 07:20:36 +00:00
Cédric Walter
b43a685b6c Bug 55036: patch for missing function Dec2HEx 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531395 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 19:16:43 +00:00
Cédric Walter
1d8a31724a Bug 55057: patch for missing function Hex2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531393 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 19:06:33 +00:00
Cédric Walter
c70043f1d5 Bug 55116: patch for missing function Dec2Bin 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531390 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 18:49:19 +00:00
Cédric Walter
be144a48fd Bug 55055: patch for missing function Bin2Dec 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531386 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-11 18:39:22 +00:00
Cédric Walter
61f1130e38 Bug 55649: WORKDAY Function returns incorrect date when spanning a weekend, or the start date is a weekend 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531124 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 21:54:52 +00:00
Nick Burch
f15a35ec45 Fix #55647 - When creating a temp file, ensure the name isn't already taken 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1531040 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 16:20:07 +00:00
Cédric Walter
ed1fc84a38 Bug 55058: patch for missing function FactDouble 
Returns the double factorial of a number: FACTDOUBLE(number)

Number     is the value for which to return the double factorial. If number is not an integer, it is truncated.

Remarks
If number is nonnumeric, FACTDOUBLE returns the #VALUE! error value.
If number is negative, FACTDOUBLE returns the #NUM! error value.

Has  a cache for more speed of previously calculated factorial
Add additional sanity check/integration test FormulaEvalTestData.xls

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530907 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-10 10:10:54 +00:00
Cédric Walter
8c2e38892e Bug 55081: patch for missing function WEEKNUM 
Add simple spreadsheet with Excel 2003, and another with 2013 (both fresh files)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1530256 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-08 12:54:35 +00:00
Cédric Walter
f49f20daec Bug 55037: patch for missing function DELTA 
Add missing TestDeltaFunctionsFromSpreadsheet and register Delta in AnalysisToolPak

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1529809 13f79535-47bb-0310-9956-ffa450edef68
 2013-10-07 09:42:38 +00:00
Dominik Stadler
43b74b0253 Apply patch from bug 55341 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1527397 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-29 20:23:20 +00:00
Nick Burch
ad8b09095e Support more hashing formats for OOXML protected documents, for bug #55544 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1522074 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-11 22:22:30 +00:00
Dominik Stadler
4a3c974e3b Remove Eclipse warnings, remove duplicate test, rename tests to also run tests in base class 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1521015 13f79535-47bb-0310-9956-ffa450edef68
 2013-09-09 09:41:31 +00:00
Dominik Stadler
17e8880dcd Bug 54524: Fix border case in FormulaShifter 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517676 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-26 20:09:19 +00:00
Dominik Stadler
84ef8c5970 Fix regression introduced by r1516969 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1517180 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-24 18:33:00 +00:00
Nick Burch
673864cdc5 More unit tests for column conversion, and avoid the use of Math.pow based on the suggestion from github-6 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516983 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 19:00:01 +00:00
Dominik Stadler
f8f998b80b Some Eclipse warnings removed 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516980 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:54:05 +00:00
Nick Burch
8b0334c701 Remove some @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516975 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:42:57 +00:00
Nick Burch
f04c20ce5d Start to remove @author tags, as per http://poi.apache.org/guidelines.html#CodeStyle 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516973 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:36:41 +00:00
Nick Burch
95fb311279 Inspired by github pull-6, use a StringBuilder for quicker string appending 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516969 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 18:30:01 +00:00
Dominik Stadler
bff0813e48 fix some Eclipse warnings, adjust some unit tests slightly 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516818 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-23 10:44:39 +00:00
Dominik Stadler
1249614bc8 Bug 50298: Fix corruption of Workbook when setting sheet order. The 
boundssheets themselves were adjusted, but not the corresponding
records.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516313 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:08:20 +00:00
Dominik Stadler
134195c86c Also fix some Eclipse warnings while hunting Bugs: Generics, unused 
variables, ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516312 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 22:06:07 +00:00
Nick Burch
75a56dcf22 Push the fix for bug #55248 up to the Sheet interface (was XSSF only before) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-21 09:41:15 +00:00
Cédric Walter
72d3a7d2a3 Bug 55043: patch for missing function QUOTIENT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514847 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 18:54:35 +00:00
Cédric Walter
67f198e752 Bug 55082: patch for missing function ROMAN 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514834 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 18:28:18 +00:00
Cédric Walter
7962fc2a9e Bug 55080: patch for missing function IMREAL 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514830 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 18:13:40 +00:00
Cédric Walter
aba46897dc Bug 55079: patch for missing function IMAGINARY 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514824 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 17:59:01 +00:00
Cédric Walter
a727830c61 Bug 54720: Support for Row/Col Area Range like 8:8 or H:H 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514812 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 17:35:16 +00:00
Cédric Walter
baee918c5a Bug 54723: Support for percentage in VALUE() function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514799 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 17:15:47 +00:00
Dominik Stadler
ed2e2a28bc Bug 54786: Fix missing quoting in date formatting, add a number of unit 
tests which verify the new formatting options.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514632 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-16 09:38:47 +00:00
Tim Allison
a62fcb2fbf 55419 and refactor SimpleFraction 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514123 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-15 01:46:25 +00:00
Dominik Stadler
2834048155 Various small Eclipse warning fixes, 
also ensure close() of stream in Ant-Task, although WorkbookFactory usually takes care of this, however in exception-cases it could be missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513764 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-14 08:25:51 +00:00
Dominik Stadler
5ce961a826 Bug 55195: use interface instead of implementation for 
NumericValueEval and others.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513247 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-12 20:27:08 +00:00
Dominik Stadler
4a3138f575 Bug 55380: Fix endless loop in CellRangeUtil.mergeCellRanges() by not trying to merge overlapping regions any more, the implementation is buggy and even tagged TODO - unit test missing. The code is hard to understand and bug-free-ness is better than catching all possible merges imho. 
Also add many cases to the unit tests and reformat code slightly as well
as fixing some Generics-Warnings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1513225 13f79535-47bb-0310-9956-ffa450edef68
 2013-08-12 19:13:10 +00:00
Tim Allison
b21ad9dbd2 added ratted out Apache license to HPSFPropertiesOnlyDocument 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1508190 13f79535-47bb-0310-9956-ffa450edef68
 2013-07-29 19:36:24 +00:00
Nick Burch
8e9c0a1cc0 Ensure the interface and implementation javadocs share the same warnings, and paragraph-ise to look nicer 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1503491 13f79535-47bb-0310-9956-ffa450edef68
 2013-07-15 21:45:21 +00:00
Dominik Stadler
d5528af80c Add more unit tests to cover more of HSSFWorkbook and HSSFSheet, check one more case of IndexOutOfBoundsException 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1502661 13f79535-47bb-0310-9956-ffa450edef68
 2013-07-12 19:21:12 +00:00
Nick Burch
7cc22dd3c1 Refactor to avoid logic duplication on the property value -> string conversion 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499329 13f79535-47bb-0310-9956-ffa450edef68
 2013-07-03 11:36:11 +00:00
Nick Burch
fb8d0c1076 Fix bug #55191 - Avoid a ClassCastException if a HPSF string property isn't directly stored as a string 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1499326 13f79535-47bb-0310-9956-ffa450edef68
 2013-07-03 11:24:01 +00:00
Nick Burch
e82421ef02 HSMF generally wants Java Lang style encoding names, which HPSF has always worked with Java NIO ones, so add a flag to CodePageUtil to let you select which style to return 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497037 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 18:44:51 +00:00
Nick Burch
8aca6fde15 Deprecate the old HPSF codepage Constants list, and change the code to use the new CodePageUtil class instead for their codepage work 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497035 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 18:20:37 +00:00
Nick Burch
f073151b1a Bring the numeric CodePage support from HPSF (constants and converters) out to a new Util class, so that HSMF can later use it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1497032 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 18:18:21 +00:00
Nick Burch
1ae9e8eba6 Fix JavaDoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496701 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 00:56:28 +00:00
Nick Burch
43355883c8 JavaDoc fix - missing > 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496685 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 00:21:40 +00:00
Nick Burch
82df889469 Add a write method to HPSFPropertiesOnlyDocument, and use this to finish the unit tests for bug #54233 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496683 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 00:18:41 +00:00
Nick Burch
90b74675d5 Pull the Properties-Only document type out to a superclass, so other places (eg unit tests) can use it 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496680 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-26 00:10:43 +00:00
Nick Burch
40d49a54d2 Fix bug #54233 - Some HPSF documents require UnicodeStrings to be 4-byte aligned, spot these from the otherwise invalid length 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496675 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 23:49:24 +00:00
Nick Burch
bd92cbc8b5 Fix to have consistent whitespace, and add javadoc deprecated entries 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496673 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 23:34:22 +00:00
Nick Burch
9d87fb9caa Fix to have consistent whitespace 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496671 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 23:30:37 +00:00
Nick Burch
f7a7eeec22 Add missing license headers, and a few javadoc tweaks while working on those files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496652 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 22:04:49 +00:00
Nick Burch
a7bfec9271 Fix from Florian Hopf from bug #54564 - Fix error message text 
for a workbook with no sheets when a sheet operation is performed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496516 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 15:19:56 +00:00
Nick Burch
dbd1a59416 Patch from Andrew Novikov from bug #53972 - Presence of PLV record shouldn't affect HSSF Data Validation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1496499 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-25 14:48:16 +00:00
Nick Burch
cb4dfced34 Patch and unit test from Tim Allen from bug #54686 - Improve how DataFormatter handles fractions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494986 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-20 13:37:26 +00:00
Nick Burch
d80ec206c6 Avoid a NPE if no password was given - use the default office one instead 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1494571 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-19 11:56:21 +00:00
Dominik Stadler
eee1b1af23 Bug 54982: Add a close() interface to POITextExtractor which can be used to free resources later. 
Implement close() where necessary so resources are closed. Add close()
to tests and run existing unit tests also against the Extractor that is
built via the Factory. Also add a small test-suite to quickly execute
all extractor-related tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493669 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-17 07:53:59 +00:00
Nick Burch
bd1214db1e Patch from Trejkaz from GitHub Pull 2 - HSSFWorkbook.getAllEmbeddedObjects() needs to recurse into container Shapes (with new unit test) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1493001 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-14 08:53:29 +00:00
Nick Burch
b80a40bc13 JavaDoc fixes from #54731 from Dominik Stadler 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1492267 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-12 16:32:24 +00:00
Yegor Kozlov
09c79ffed4 fixed compatibility issues with JDK 1.5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1489685 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-05 02:03:07 +00:00
Yegor Kozlov
e3bbd87918 removed @Override to keep javac on JDK 1.5 happy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488823 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-03 01:05:28 +00:00
Yegor Kozlov
2135b0741c Bug 55047: REPT formula support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488811 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 23:39:41 +00:00
Yegor Kozlov
abd5fcd939 missing tests for Bug 55041 - CODE formula support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488810 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 23:32:24 +00:00
Yegor Kozlov
ecb8b8240c added missing tests for Bug 55042: patch for missing function COMPLEX 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488808 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 23:25:07 +00:00
Yegor Kozlov
4d81d34d5d Bugzilla 55043 and 55042: initial support for Complex and Quotient functions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488734 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 16:08:17 +00:00
Yegor Kozlov
0dfb528355 Bugzilla 55041: CODE function support, also removed @Override from interfaces to stay compatible with JDK 1.5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488733 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 15:58:41 +00:00
Yegor Kozlov
c119f35388 Bugzilla 55037: DELTA function support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488730 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 15:30:58 +00:00
Yegor Kozlov
e5cfade841 Bugzilla 55036 - Dec2HEx formula support 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1488729 13f79535-47bb-0310-9956-ffa450edef68
 2013-06-02 15:13:47 +00:00
Nick Burch
808c01e365 Fix #54891 - correct javadoc on HSSF + SS (XSSF was correct) for Row.createCell(int,int) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1479639 13f79535-47bb-0310-9956-ffa450edef68
 2013-05-06 16:53:04 +00:00
Yegor Kozlov
76fac97865 Bug 54673 - [PATCH] Simple wildcard support in HLOOKUP, VOOLKUP, MATCH, COUNTIF 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1457243 13f79535-47bb-0310-9956-ffa450edef68
 2013-03-16 12:33:08 +00:00
Yegor Kozlov
651e622176 Bugzilla 54625 - Register user-defined functions in instance scope instead of static 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1452060 13f79535-47bb-0310-9956-ffa450edef68
 2013-03-03 16:16:12 +00:00
Yegor Kozlov
decfde00ff Bugzilla 54469 - Support for financial functions IPMT and PPMT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1451886 13f79535-47bb-0310-9956-ffa450edef68
 2013-03-02 13:17:53 +00:00
Nick Burch
522168dda4 Fix bug #54579 - Handle milliseconds in date formats eg ss.000 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1447798 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-19 16:28:40 +00:00
Nick Burch
9f23a59eaa Fix bug #54557 - Don't mis-detect format patterns like .000 as dates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1445725 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-13 16:45:03 +00:00
Nick Burch
8d7d3f54c0 Fix bug #54506 - Add "BOOK" to the list of unusual-but-largely-ok Workbook directory entry names list, alongside WORKBOOK, plus tests 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1443745 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-07 21:53:07 +00:00
Nick Burch
887af17af3 Fix 1.6ism from original patch 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442521 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-05 10:00:43 +00:00
Nick Burch
37c76d9b28 EDate function implementation from Detlef Brendle from bug #54508 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442392 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-04 22:01:55 +00:00
Nick Burch
dd21676086 An XBAT may not be fully used, and remaining entries may be 0 not POIFSConstants.UNUSED_BLOCK, so avoid trying to process any that we know aren't used. Fixes bug #53810 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1442095 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-04 12:52:12 +00:00
Evgeniy Berlog
5801aa36b2 set isHidden flag 'true' for invisible comment and 'false' for visible comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1441829 13f79535-47bb-0310-9956-ffa450edef68
 2013-02-02 23:10:34 +00:00
Yegor Kozlov
0d3e7886ea keep javac on JDK 1.5 happy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436888 13f79535-47bb-0310-9956-ffa450edef68
 2013-01-22 13:02:39 +00:00
Yegor Kozlov
c5e81c11e7 keep javac on JDK 1.5 happy 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1436819 13f79535-47bb-0310-9956-ffa450edef68
 2013-01-22 09:35:39 +00:00
Yegor Kozlov
3680179e47 Bugzilla 54356 - Support of statistical function SLOPE 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1435633 13f79535-47bb-0310-9956-ffa450edef68
 2013-01-19 18:33:34 +00:00
Nick Burch
b7c061f07a Patch from Johan from bug #54402 - fix IfError with indirect references 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1431403 13f79535-47bb-0310-9956-ffa450edef68
 2013-01-10 15:08:22 +00:00
Yegor Kozlov
0023138765 Bugzilla 54356: Support of statistical function INTERCEPT 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1426485 13f79535-47bb-0310-9956-ffa450edef68
 2012-12-28 12:50:15 +00:00
Nick Burch
876fea8596 Patch from Johan Karlsteen for bug #53966 - Implement IfError AP function 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1426382 13f79535-47bb-0310-9956-ffa450edef68
 2012-12-28 03:34:18 +00:00
Nick Burch
21abfa9536 Make the exception a bit more explicit about what is wrong 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1424281 13f79535-47bb-0310-9956-ffa450edef68
 2012-12-20 03:54:42 +00:00
Yegor Kozlov
7d6b730202 Bug 54206: ValueRecordsAggregate.updateFormulasAfterRowShift doesn't update shared formulas 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1416917 13f79535-47bb-0310-9956-ffa450edef68
 2012-12-04 12:44:33 +00:00
Yegor Kozlov
baa610fa5e removed svn:executable from test files 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1413341 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-25 12:19:05 +00:00
Yegor Kozlov
c7c321b0f1 avoid warning: check if property node exists instead of throw/catch exception 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410324 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-16 12:58:45 +00:00
Yegor Kozlov
133c0d7c0b Bug 52628 - Replace System.err info messages with a POILogger 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410318 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-16 12:21:49 +00:00
Yegor Kozlov
87073d28da fixed javadoc warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410315 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-16 12:00:02 +00:00
Yegor Kozlov
2365cae199 bugzilla 54137 - improved performance of DataFormatter with Fractions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1410269 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-16 09:46:28 +00:00
Yegor Kozlov
27355c84b1 clear unused import warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1408236 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-12 09:54:37 +00:00
Yegor Kozlov
395b0af2e4 Bugzilla 54070: Patch for typos in comments, javadoc and documentation 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1404642 13f79535-47bb-0310-9956-ffa450edef68
 2012-11-01 15:26:27 +00:00
Yegor Kozlov
7ba0f8af84 Bug #54016 - Avoid exception when parsing workbooks with DConRefRecord in row aggregate 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1402482 13f79535-47bb-0310-9956-ffa450edef68
 2012-10-26 12:21:33 +00:00
Yegor Kozlov
7b196a13fa Bug #53404 - Fixed compatibility issue with modifying xls files created by POI-3.6 and earlier 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1402186 13f79535-47bb-0310-9956-ffa450edef68
 2012-10-25 15:13:53 +00:00
Yegor Kozlov
6000b0e528 Bugzilla 53763: avoid style mess when using HSSFOptimiser 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1397548 13f79535-47bb-0310-9956-ffa450edef68
 2012-10-12 12:55:45 +00:00
Yegor Kozlov
299ca1472b Bugzilla >53974 - Avoid exception when constructing HSSFWorbook on Google App Engine 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1396543 13f79535-47bb-0310-9956-ffa450edef68
 2012-10-10 11:09:48 +00:00
Nick Burch
e57875865e Have HSSFOptimiser also remove un-used cell styles, in addition to duplicates 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1391891 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-29 21:36:27 +00:00
Nick Burch
aa358ace11 Fix generics warnings 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1391885 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-29 21:25:44 +00:00
Sergey Vladimirov
9f666b8aee refactor list format override structures (was marked with @Internal annotation) 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1389037 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-23 12:56:09 +00:00
Evgeniy Berlog
c7c1fd596a fixed bug 46250 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1382494 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-09 13:21:38 +00:00
Evgeniy Berlog
881e7df713 fixed bug 53588 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1382339 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-08 18:35:04 +00:00
Evgeniy Berlog
ddbbd7ba32 bugzilla ticket 53642: added detailed logging for formula evaluation in both HSSF and XSSF modules 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1381249 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-05 17:03:55 +00:00
Evgeniy Berlog
e0db6f31a0 resolved bugzilla ticket 53642 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1380882 13f79535-47bb-0310-9956-ffa450edef68
 2012-09-04 21:00:41 +00:00
Evgeniy Berlog
107c23505b fixed bug 53434 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1378016 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-28 08:24:07 +00:00
Evgeniy Berlog
c3f9a6e682 fixed bug 53432 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1373110 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-14 21:11:53 +00:00
Evgeniy Berlog
98f64db1c7 fixed bug 53028, added check before serialization if any cell contains 2 or more comments 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1373005 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-14 18:22:31 +00:00
Evgeniy Berlog
a2b21484ae complete refactoring in EscherAggregate 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1372065 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-12 10:18:43 +00:00
Yegor Kozlov
b200e0b4c2 Bugzilla 53699 - Patch to correct BorderStyle enum positions 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1372063 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-12 09:59:54 +00:00
Yegor Kozlov
8d467f5751 fixed compilation errors on JDk 1.5 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1372061 13f79535-47bb-0310-9956-ffa450edef68
 2012-08-12 09:38:17 +00:00