Dominik Stadler
06083f85f4
Refactor some common code from the various Document-Factories into a helper class
...
Fix a potential file-handle-leak for password protected workbooks or slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:32 +00:00
Dominik Stadler
128a991f9c
Findbugs fixes
...
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Dominik Stadler
b1bc13c26f
Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:56 +00:00
Andreas Beeker
7d6be0ff54
#59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 00:17:16 +00:00
Andreas Beeker
0776e32108
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
2016-03-11 23:14:09 +00:00
Andreas Beeker
1b9523898d
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
2016-03-10 00:20:34 +00:00
Andreas Beeker
e2fc2822a6
Remove a superfluous/bloated log function, which String.format can do better and is only used once ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 20:57:26 +00:00
Nick Burch
9090741226
More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 10:57:52 +00:00
Andreas Beeker
261ef4934c
#59056 - Render individual slideshow shapes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:59:49 +00:00
Andreas Beeker
e5baa15b25
Fix NPE of regression tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:36:58 +00:00
Nick Burch
62b5b0d874
#59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
856261f4d0
Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:43:59 +00:00
Nick Burch
0b8283b37c
Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Andreas Beeker
41d693fe15
Regression fixes for H/XSLF and HWMF
...
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler
161ef55132
Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Dominik Stadler
10f46da1ae
Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Javen O'Neal
c80fa0c870
bug 56345: reject single-cell merged regions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Javen O'Neal
3cb72bfa7b
bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Nick Burch
86153c0ea6
Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00
Nick Burch
0982d9dee5
Start generalising the IgnoredErrorType code for later HSSF use too #56892
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:40:24 +00:00
Dominik Stadler
98da5af350
Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 08:33:12 +00:00
Dominik Stadler
c68a9e4c02
Regression analysis: the additional testing of cloning sheets showed a
...
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68
2016-02-13 21:29:46 +00:00
Javen O'Neal
95e95dfabb
remove deprecated (2009) HSSFComment#setColumn(short). int version is available.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:52:32 +00:00
Javen O'Neal
80c9b356c2
HSSFComment: note a final field
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:33:00 +00:00
Javen O'Neal
dc860a6f93
fix O(n^2) runtime unnecessarily recreating an array inside a for-loop
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68
2016-01-31 12:14:55 +00:00
Dominik Stadler
68997de5f0
Make OldExcelExtractor Closeable to be able to free up resources if getText() was not called
...
Allow Excel files which have an entry "Workbook" instead of "Book" like other classes do
Add some more unit tests to cover more of the code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727653 13f79535-47bb-0310-9956-ffa450edef68
2016-01-29 22:09:03 +00:00
Andreas Beeker
5fad9af36f
#41047 - Support hyperlinks in HSLF shapes and textruns
...
#47291 - Cannot open link correctly which insert in ppt
HSLF hyperlink code was all over the place - moved most of it into HSLFHyperlink
extended common sl for hyperlinks
extended XSLF shape linking and added XSLFTextShape.appendText to go along with HSLF
adapted/fixed documentation
added convenience methods to the hyperlink classes to address the different targets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1726458 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 00:12:10 +00:00
Dominik Stadler
fe359afec3
Fix possible NullPointerException with invalid/unsupported image types
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725332 13f79535-47bb-0310-9956-ffa450edef68
2016-01-18 19:56:30 +00:00
Javen O'Neal
276e95e43f
bug 58879: add SpreadsheetVersion to Workbook interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 22:01:33 +00:00
Andreas Beeker
c1263423cf
#56004 - Support for WMF rendering
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724897 13f79535-47bb-0310-9956-ffa450edef68
2016-01-16 00:11:01 +00:00
Dominik Stadler
bdef6e1c52
Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:46:17 +00:00
Dominik Stadler
e91e15ab10
Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:45:05 +00:00
Nick Burch
c86a4af85e
Javadoc fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724364 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 07:33:03 +00:00
Nick Burch
ed9a070491
#58847 Getters/setters/removers for the additional well-known document summary information properties from Office 12
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724363 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 07:26:26 +00:00
Andreas Beeker
b0c16b8261
#57796 - Support hyperlink extraction when rendering slides
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724338 13f79535-47bb-0310-9956-ffa450edef68
2016-01-12 23:20:48 +00:00
Nick Burch
ef61211207
More Office 12 DSI property IDs, getters/setters to follow
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724110 13f79535-47bb-0310-9956-ffa450edef68
2016-01-11 18:43:33 +00:00
Nick Burch
5e32d8c805
Bump up the max DSI property ID, and list a few Office 12 well known IDs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724104 13f79535-47bb-0310-9956-ffa450edef68
2016-01-11 18:26:24 +00:00
Andreas Beeker
b3b4ed6564
add other printStackTrace methods to forbidden-apis-check
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 19:52:16 +00:00
Andreas Beeker
8d033e235c
replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Javen O'Neal
1e9fd97f78
bug 58815: javadoc spelling
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723445 13f79535-47bb-0310-9956-ffa450edef68
2016-01-07 01:53:05 +00:00
Dominik Stadler
c4c9ac0ccf
bug 58043: provide some compatibility between HSSF and XSSF in regards to values for CellStyle.setRotation(). Also adjust JavaDoc to mention the remaining things to note
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722716 13f79535-47bb-0310-9956-ffa450edef68
2016-01-03 13:28:17 +00:00
Javen O'Neal
347881ef1e
bug 58633 comment 5 and comment 6: add unit test coverage for CellUtil.java; throw exception of Cell does not belong to workbook for some methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722618 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 11:11:33 +00:00
Javen O'Neal
4a47ec3d39
fix javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722609 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 06:23:05 +00:00
asf-sync-process
de7807c8a7
bug 58633: Set multiple CellStyle properties at once. Patch from Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722607 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 04:29:34 +00:00
Javen O'Neal
85bb833ea1
javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722605 13f79535-47bb-0310-9956-ffa450edef68
2016-01-02 03:40:22 +00:00
Andreas Beeker
f317f5e288
#56570 - RecordType has repeat by code type 3009
...
#58159 - getHeaderText() and getFooterText() duplicate text in sheet.getTextRuns()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722476 13f79535-47bb-0310-9956-ffa450edef68
2015-12-31 22:10:17 +00:00
Dominik Stadler
8589924b22
Bug 58746: Fix missing adjustment of formulas when sheet-ordering is changed.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722410 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:44 +00:00
Dominik Stadler
8ae2972f3d
Bug 58616: Try to initialize with empty password if not done before
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722407 13f79535-47bb-0310-9956-ffa450edef68
2015-12-30 20:31:23 +00:00
Javen O'Neal
70f08e1fc5
fix javadocs warnings for r1721930 (bug 58775)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1722049 13f79535-47bb-0310-9956-ffa450edef68
2015-12-29 02:57:58 +00:00
Javen O'Neal
a50f45e4c2
bug 58775: use short for data format index, int for cell style index
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1721930 13f79535-47bb-0310-9956-ffa450edef68
2015-12-28 14:50:54 +00:00