PJ Fanning
5c65b55bd4
Ensure SpreadsheetVersion is set for AreaReferences
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
PJ Fanning
4209a1b2da
Remove some deprecated *SSF APIs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
PJ Fanning
03d4e52bc0
expand StaxHelper
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 13:53:47 +00:00
PJ Fanning
eee5205d0c
[Bug 60422] Fix forbidden-api build issue
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799723 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:37:03 +00:00
PJ Fanning
c1cc93a2ef
[Bug 60422] Tidy up test case
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799722 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 00:15:20 +00:00
PJ Fanning
66b39c70ad
Bug 60422 add testtestcase with current LocaleUtil workaround
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799721 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 23:42:25 +00:00
Tim Allison
649280df8c
bug 61045 -- allow for (and log!) extra bytes in FormatRecord.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799360 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 18:11:34 +00:00
Javen O'Neal
4d692223bb
whitespace
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799303 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:51:48 +00:00
Javen O'Neal
5de40d3261
bug 52063: support 2-argument LOOKUP(lookup_value, array) function in Excel
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799302 13f79535-47bb-0310-9956-ffa450edef68
2017-06-20 05:47:56 +00:00
Dominik Stadler
2095c92402
Improve error message if we encounter invalid/unexpected files in integration tests
...
Adjust some tests slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799178 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 11:05:20 +00:00
Dominik Stadler
05570364db
Move one testcase with incorrect source location
...
remove some junit dependencies in example-code
build: do not pass junit-jar to normal compile targets to avoid introducing it as dependency again
Reformat code, fix warnings, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1798202 13f79535-47bb-0310-9956-ffa450edef68
2017-06-09 12:49:01 +00:00
Andreas Beeker
efccafd898
fix eclipse resource leak warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1797043 13f79535-47bb-0310-9956-ffa450edef68
2017-05-31 14:10:18 +00:00
Greg Woolsey
479b45ced9
Bug 60898 - XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color
...
Missed this test. As part of the work I noticed the Enum was missing some values defined in the OOXML spec, so I added them.
I've updated the test to reflect that those values are no longer invalid.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1796360 13f79535-47bb-0310-9956-ffa450edef68
2017-05-26 23:37:04 +00:00
Dominik Stadler
d868026959
Bug 61063: Add a RefListEval to handle UnionPtg and implement it for Rank(), may be missing for other functions where ArrayEval is currently handled
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795963 13f79535-47bb-0310-9956-ffa450edef68
2017-05-23 21:13:02 +00:00
Javen O'Neal
7881d05743
github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795681 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 21:04:14 +00:00
Javen O'Neal
0b767886bf
replace "String.indexOf(String) >= 1" with "String.contains(String)"
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795296 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 10:53:15 +00:00
Javen O'Neal
be5106a1d7
github-43: add disabled unit test showing a problem with ROUNDUP(3987*0.2, 2). Thanks to @FishMeat.
...
https://github.com/apache/poi/pull/43
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795265 13f79535-47bb-0310-9956-ffa450edef68
2017-05-16 03:04:12 +00:00
Andreas Beeker
90dca20bd2
#52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
...
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Andreas Beeker
76dbb5a1eb
HPSF: Change CustomProperties to delegate
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793699 13f79535-47bb-0310-9956-ffa450edef68
2017-05-03 19:18:45 +00:00
Andreas Beeker
3a1771ced1
HPSF: Enable new number types in VariantSupport
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793598 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:28:00 +00:00
Andreas Beeker
456b33a837
Fix hpsf javadocs and code issues
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793596 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:27:27 +00:00
Dominik Stadler
fa39402871
60325: Add commented out test that reproduces the performance issue
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793251 13f79535-47bb-0310-9956-ffa450edef68
2017-04-30 09:12:36 +00:00
Javen O'Neal
e39ae9cd30
bug 61034: Call to XSSFReader.getSheetsData() returns duplicate sheets.
...
Thanks to Mauricio Eastmond for the Excel test file and unit test.
Thanks to Sebastian Wikalinski for isolating the problem and providing a patch.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793223 13f79535-47bb-0310-9956-ffa450edef68
2017-04-29 17:27:17 +00:00
Tim Allison
5f567f29a1
bug 61049 fix ordering of builtin formulas
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792918 13f79535-47bb-0310-9956-ffa450edef68
2017-04-27 16:18:25 +00:00
Javen O'Neal
3c2a6b38bb
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792009 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 01:28:40 +00:00
Javen O'Neal
3cbf4740b1
Use assertContains instead of assertTrue(text.contains) for better error messages on failure
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1792007 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 23:51:03 +00:00
Greg Woolsey
6e0a5916b5
Fix bug #61007
...
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.
Send what was checked previously plus only multi-segment conditional range formats. Allows existing tests to pass plus the new test with the case for these conditional formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 20:04:46 +00:00
Greg Woolsey
d1b92fe2d8
Fix bug #61007
...
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel. Also added tests for the failing formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
2017-04-19 18:10:52 +00:00
Dominik Stadler
511c2544a8
Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Javen O'Neal
dc29c94460
roll back to hamcrest-core
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791570 13f79535-47bb-0310-9956-ffa450edef68
2017-04-16 06:10:23 +00:00
Javen O'Neal
ef8c9329cf
change from hamcrest-core-1.3 to hamcrest-all-1.3
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791444 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 03:19:27 +00:00
Javen O'Neal
e7ca1594da
use hamcrest matchers to reduce custom code
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791443 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:50:46 +00:00
Javen O'Neal
7977026f96
use assertStartsWith and assertEndsWith for better unit test error messages
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791440 13f79535-47bb-0310-9956-ffa450edef68
2017-04-15 02:19:24 +00:00
Tim Allison
1bfd5f6585
bug 50955 and bug 60953 improve Big5 reader; ensure one character
...
per byte pair
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1790172 13f79535-47bb-0310-9956-ffa450edef68
2017-04-05 01:45:55 +00:00
Dominik Stadler
abc3d37adc
Add tests from bug 45353 to show that this now works fine
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1786432 13f79535-47bb-0310-9956-ffa450edef68
2017-03-10 20:14:00 +00:00
Javen O'Neal
bb6e94851f
add helper functions to make it easier to see which scenarios are being tested
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1784231 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 05:07:10 +00:00
Javen O'Neal
7fcaaa9479
bug 59893: close open resources to prevent leaks
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783362 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:53:49 +00:00
Javen O'Neal
85a30f16cf
convert from junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783360 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:37:00 +00:00
Javen O'Neal
1584310ac5
bug 59893: more unrelated changes from Andi
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783353 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 09:08:21 +00:00
Greg Woolsey
7dfa32c28b
Bug #56822 fix COUNTIFS()
...
includes unit test from the issue. Verified unit test results in Excel vs. incorrect previous POI results. Test passes new code, as do existing tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783037 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 22:05:49 +00:00
Andreas Beeker
faaa94d20a
escape unicode chars
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782568 13f79535-47bb-0310-9956-ffa450edef68
2017-02-11 09:49:52 +00:00
Nick Burch
fc31afbb86
Use long for the dummy stream, to permit >2gb streams
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782470 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 13:51:33 +00:00
Nick Burch
16a825ccf5
Update the big file test to use POIFSFileSystem.create(File), and tweak javadocs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782454 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 11:43:01 +00:00
Nick Burch
eeae830d19
Start on a unit test for #60670 , work required to get it passing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782380 13f79535-47bb-0310-9956-ffa450edef68
2017-02-09 19:29:51 +00:00
Javen O'Neal
0f09e9eae2
bug 59227: parse dates formatted in Japanese or Chinese. Change javac source encoding from ASCII to UTF-8 (same as build.gradle). Patch from jzhao. This closes #48 on Github.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782119 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 08:29:18 +00:00
Javen O'Neal
28999738a9
Convert all *.java files to use native end of line character(s)
...
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Dominik Stadler
db600cf0b4
Adjust expected font-size in tests, XSSF seems to use slightly larger fonts on some machines
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780479 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 20:59:49 +00:00
Dominik Stadler
37b53744c0
Move test to base-test-class to run it for (S)XSSF as well
...
Also had to increase the numbers a bit as it fails locally for me otherwise
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780454 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:52 +00:00
Dominik Stadler
560a33620a
IntelliJ warnings, Javadoc, Formatting
...
Changes for the RecordFormatException deprecation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780453 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:46 +00:00
Dominik Stadler
797ea00d09
Bug 60031: Enhance test some more
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1780450 13f79535-47bb-0310-9956-ffa450edef68
2017-01-26 19:58:18 +00:00
Andreas Beeker
4a5f7765bb
fix eclipse warnings - close resources
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779869 13f79535-47bb-0310-9956-ffa450edef68
2017-01-23 00:31:27 +00:00
Andreas Beeker
c48a0cf334
#59836 - Tracker: Replace primitives with enums
...
preparation for removing those many HSSFColor subclasses with an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779866 13f79535-47bb-0310-9956-ffa450edef68
2017-01-22 22:01:22 +00:00
Javen O'Neal
93eb933aa6
fix assert message typo
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779567 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:40:49 +00:00
Javen O'Neal
6aa7fe54e9
fix copy-paste typo in unit test found by Andrzej Witecki
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779565 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:37:12 +00:00
Javen O'Neal
9def800cd4
bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:35:57 +00:00
Javen O'Neal
c46e7d03f3
remove unused imports
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779563 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:04:57 +00:00
Javen O'Neal
2f648842cd
bug 60605: replace Workbook.SHEET_STATE_VERY_HIDDEN with SheetVisibility.VERY_HIDDEN
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779562 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 05:00:29 +00:00
Javen O'Neal
dfd906aa9b
bug 60605: remove code for enforcing rule that active sheet cannot be hidden
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779561 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:55:06 +00:00
Javen O'Neal
15be6fb336
bug 60605: convert Workbook.SHEET_STATE_* to SheetVisibility enum
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779558 13f79535-47bb-0310-9956-ffa450edef68
2017-01-20 04:23:42 +00:00
Javen O'Neal
70cc2bce03
bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779426 13f79535-47bb-0310-9956-ffa450edef68
2017-01-19 07:44:25 +00:00
Andreas Beeker
75c630f976
fix eclipse warnings / close resources in tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778958 13f79535-47bb-0310-9956-ffa450edef68
2017-01-16 01:18:46 +00:00
Andreas Beeker
a7706b3fdf
fix eclipse warnings - close resources / type generics
...
cleanup sources - add parenthesis to statements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 23:08:47 +00:00
Javen O'Neal
726fe10074
bug 60260: parse unicode sheet names
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778418 13f79535-47bb-0310-9956-ffa450edef68
2017-01-12 10:39:26 +00:00
Javen O'Neal
42c5a08dfb
add unit tests for MAPIMessage.get*Body()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777463 13f79535-47bb-0310-9956-ffa450edef68
2017-01-05 12:46:28 +00:00
Dominik Stadler
102c0d2173
Bug 60219: FormulaParser can't parse external references when sheet name is quoted
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776796 13f79535-47bb-0310-9956-ffa450edef68
2016-12-31 16:53:16 +00:00
Dominik Stadler
36406ad3a1
Ensure streams are closed always, reformat code somewhat
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776647 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:12:06 +00:00
Dominik Stadler
6f616d0a51
Bug 60369: Adjust pattern to better handle non-ASCII characters in Month-names which can appear since Java 8
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776646 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:55 +00:00
Dominik Stadler
8def7307d9
Bug 60452: WorkdayCalculator calculateWorkdays does return wrong value for same day input
...
deprecate unused method isNonWorkday
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776588 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 15:05:14 +00:00
Andreas Beeker
6a8332a173
eclipse warnings - raw list access
...
close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773906 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:31:23 +00:00
Andreas Beeker
128001186b
eclipse warnings - raw list access
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773905 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:30:24 +00:00
Andreas Beeker
fae46faf29
remove unused class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773904 13f79535-47bb-0310-9956-ffa450edef68
2016-12-13 00:29:03 +00:00
Dominik Stadler
230453d76e
Adjust toString() of ExternalNameRecord
...
Fix some IntelliJ warnings
Reformat TextPieceTable
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773776 13f79535-47bb-0310-9956-ffa450edef68
2016-12-12 11:41:07 +00:00
Dominik Stadler
17311852ce
Revert "Local test to run one of the multi-file tests on only one file"
...
This reverts commit 6582ca62b000143b96823509ad7bb8d444cabee3.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773689 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:15:37 +00:00
Dominik Stadler
5cf4143fcc
Revert "Adjust local test class run with Gradle-Build as well"
...
This reverts commit 76be95541fa6ac22bf0746d864404a84868ab1c6.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773663 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:13:51 +00:00
Dominik Stadler
8003ad78f4
Adjust local test class run with Gradle-Build as well
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773661 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 21:00:00 +00:00
Dominik Stadler
54778bfac6
Local test to run one of the multi-file tests on only one file
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773635 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:58:12 +00:00
Dominik Stadler
2e364ee85d
Exclude new BIFF5 file in some unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1773605 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 20:56:03 +00:00
Nick Burch
30d64fda8c
Recursive delete unit test based on users@ query - working fine already
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772894 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 13:52:46 +00:00
Andreas Beeker
75dc015766
SonarCube fix - make members private
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772585 13f79535-47bb-0310-9956-ffa450edef68
2016-12-04 23:49:49 +00:00
Andreas Beeker
656f28ba81
SonarCube fix - make members private
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1772291 13f79535-47bb-0310-9956-ffa450edef68
2016-12-01 23:46:27 +00:00
Andreas Beeker
6ea58e94bc
#60331 - Remove deprecated classes - deprecate Mutable* property classes
...
sonarcube fix - make protected attributes private
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 20:19:18 +00:00
Dominik Stadler
aba5d21295
Fix newly introduced Sonar issues and allow text to be null
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771563 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 11:06:57 +00:00
Dominik Stadler
be1aa45b25
Bug 60370: Encode some special characters when setting title/text for validation text-boxes, for now all characters below 32, more can be added if necessary.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771396 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:59 +00:00
Dominik Stadler
e2b22e51f7
Bug 59200: Check for actual Excel limits on data validation title/text
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 08:55:52 +00:00
Dominik Stadler
57fa4c1869
Pull up one more test into BaseTestConditionalFormatting
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768590 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 21:32:18 +00:00
Dominik Stadler
76a0c6378e
Add setFormattingRanges() to interface ConditionalFormatting, closes #42
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1768588 13f79535-47bb-0310-9956-ffa450edef68
2016-11-07 21:32:04 +00:00
Javen O'Neal
a3f001b7ae
bug 60331: remove deprecated FormulaShifter.createForRowShift(). Require SpreadsheetVersion.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1767728 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 16:37:12 +00:00
Dominik Stadler
0610a20d87
Fix some IDE warnings, JavaDoc, ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1766063 13f79535-47bb-0310-9956-ffa450edef68
2016-10-21 16:31:37 +00:00
Dominik Stadler
d0d5334386
Exclude new BIFF5 file in some unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765876 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 20:31:57 +00:00
Dominik Stadler
f2c9dbec3f
Add some missing close() calls
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765875 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 20:31:50 +00:00
Tim Allison
9fd46e3174
BUG-60284 -- need to update dev tests <face_palm/>
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765859 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 18:39:47 +00:00
Tim Allison
d233f7c348
BUG-60284 -- throw EncryptedDocumentException for password protected OldExcel files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765829 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 15:13:16 +00:00
Javen O'Neal
a1ec4334cf
Eclipse automated refactor/cleanup: add final modifier to private fields to unit tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765739 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 02:21:14 +00:00
Javen O'Neal
96d35e0b8e
Eclipse automated refactor/cleanup: convert for loops to for-each loops
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765736 13f79535-47bb-0310-9956-ffa450edef68
2016-10-20 01:54:56 +00:00
Andreas Beeker
54122c2233
remove *_dump directory
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765734 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:43:42 +00:00
Javen O'Neal
5d3d50b9d1
add StringUtil.count, inspired by Apache Commons Lang StringUtils#countMatches and Python's str.count(substr)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765730 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 23:04:16 +00:00
Javen O'Neal
4b01accdb3
Eclipse automated refactor/cleanup: convert for loops to for-each loops
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765728 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 22:28:07 +00:00
Javen O'Neal
c5dddf7fac
Eclipse automated refactor/cleanup: add missing @Override and @Deprecated annotations
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765726 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 21:52:31 +00:00
Tim Allison
5958cb4840
BUG-59302 --add minimal support for VBAMacro extraction to HSLF; credit to Andreas Beeker for this patch. Problems are mine.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765696 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 18:44:46 +00:00
Javen O'Neal
9cad5aff09
reenable unit test for bug 58648 that passes now
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765548 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:03:57 +00:00
Javen O'Neal
e1734cd542
disabled unit tests are now passing for bug 48703
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765544 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 07:37:47 +00:00
Tim Allison
17d4d76f4f
BUG 60273 -- Use codepageutil to get correct charset in VBAMacroReader
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765490 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 18:24:39 +00:00
Tim Allison
ef7bbb8fe4
BUG 59858 -- avoid npe when there's a collision of record names...doh. Fix unit test.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765482 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:54:12 +00:00
Tim Allison
92eb3bbade
BUG 59858 -- avoid npe when there's a collision of record names
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765479 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 16:43:20 +00:00
Tim Allison
c878e39b55
BUG 59830 -- incorrect reading of unicode stream name
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765468 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 15:47:38 +00:00
Tim Allison
db79501e9f
BUG 60158 -- AIOOBE in VBAMacroReader
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765433 13f79535-47bb-0310-9956-ffa450edef68
2016-10-18 12:55:34 +00:00
Dominik Stadler
37116e84e5
Bug 60029: apply suggested fix and fix some IntelliJ warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765018 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 06:54:20 +00:00
Tim Allison
7f9f8e9afa
add length sanity check for length of embedded OLE10Native (BUG 60256)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764927 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 14:57:29 +00:00
Tim Allison
442815fcc5
add ignored test and triggering document for BUG 60256
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764890 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 13:22:23 +00:00
Javen O'Neal
1e5dc11721
bug 56781,60246: fix named range validation to match valid name rules per Excel docs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1764854 13f79535-47bb-0310-9956-ffa450edef68
2016-10-14 10:11:23 +00:00
Javen O'Neal
45d18d5c45
bug 55075: add missing import
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763955 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:26:49 +00:00
Javen O'Neal
61f00a509f
bug 55075,51233: create drawings with correct height when rows are custom height
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763950 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 10:02:36 +00:00
Javen O'Neal
dd1ed5b840
bug 60197: Workbook#setSheetOrder should update named range sheet indices
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 03:02:13 +00:00
Dominik Stadler
cdef5dc16c
Use IOUtils.closeQuietly() in more places
...
Avoid two possible file-handle leaks when opening files fails with an exception
Make tests close resources properly to not spam the output when running with file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763485 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 20:00:07 +00:00
Dominik Stadler
89f68a6a47
Bug 53028: Broken auto fit row height in the cells with word wrap
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763484 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:56 +00:00
Dominik Stadler
86eafd3c44
Some IDE warning fixes and unit test adjustments
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763482 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 19:59:44 +00:00
Mark Murphy
d106d31934
Add PropertyTemplate for drawing Borders (58787)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763338 13f79535-47bb-0310-9956-ffa450edef68
2016-10-05 02:23:52 +00:00
Javen O'Neal
d169bdc2f9
bug 60187: replace methods operating on BorderStyle codes with BorderStyle enums
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1762856 13f79535-47bb-0310-9956-ffa450edef68
2016-09-30 06:39:29 +00:00
Andreas Beeker
0a7cd3b68b
merge trunk to branch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
2016-09-28 21:01:40 +00:00
Andreas Beeker
cda4f20482
merge trunk to branch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
2016-09-19 00:20:44 +00:00
Andreas Beeker
71db60b890
merge trunk to branch
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756967 13f79535-47bb-0310-9956-ffa450edef68
2016-08-19 20:57:56 +00:00
Andreas Beeker
9521546156
add encryption support
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1756964 13f79535-47bb-0310-9956-ffa450edef68
2016-08-19 20:23:16 +00:00
Andreas Beeker
680683cf77
merge down trunk
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 01:14:36 +00:00
Andreas Beeker
0bfefdfc04
HSSF CryptoAPI decryption support
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755461 13f79535-47bb-0310-9956-ffa450edef68
2016-08-08 00:10:44 +00:00
Javen O'Neal
327a4aa091
test Cell.setCellValue(false)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753634 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 02:17:37 +00:00
Nick Burch
4dee08213a
Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 12:01:36 +00:00
Nick Burch
dfd3bbee21
Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:14:05 +00:00
Javen O'Neal
93a53a1da3
add test case for bug 53564
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753359 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 10:08:50 +00:00
Dominik Stadler
abc3072df2
52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 10:32:55 +00:00
Dominik Stadler
35173d9e30
Some warnings/improvements suggested by IntelliJ
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 09:34:59 +00:00
Dominik Stadler
da595c2343
Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
...
test-updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Nick Burch
cf6d3489e0
#57919 Provide an initial in-place write method for HSSFWorkbook
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 19:02:58 +00:00
Javen O'Neal
d9f3df34de
bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
...
add tests for SlideShow.findPicture and SlideShow.addPicture
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:25:02 +00:00
Javen O'Neal
bc91641444
bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:56:13 +00:00
Javen O'Neal
a478687281
bug 59264,59833,59837: upgrade deprecated methods in examples and testcases
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753060 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:43:50 +00:00
Javen O'Neal
2944b7a7a8
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753041 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:42:13 +00:00
Javen O'Neal
31f2b5fdd1
bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:32:29 +00:00
Dominik Stadler
16b0c380c9
Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:27:07 +00:00
Javen O'Neal
4ba3ed06fc
bug 59775: fix cell address index error
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753011 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:59:12 +00:00
Javen O'Neal
44199a8ecd
bug 59872: add Sheet.getHyperlink(CellAddress)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Dominik Stadler
af2a99b910
Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Dominik Stadler
ae7ef11c88
Bug 59861: Adjust testcase, it works now for me. Also combine the two TestProper classes into one
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752861 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 18:24:02 +00:00
Dominik Stadler
aec95a4491
Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
...
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:32:45 +00:00
Javen O'Neal
75f5d3afc5
bug 59858: describe why VBA macro reading failed
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752778 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 06:12:37 +00:00
Javen O'Neal
bb8f614a90
bug 59858: add disabled unit test for bug 59858; file from Brooke
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752776 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 05:28:29 +00:00
Javen O'Neal
c541e0a16f
add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:37:22 +00:00
Javen O'Neal
2ec6b12e13
bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68
2016-07-10 11:18:55 +00:00
Javen O'Neal
909c07f37f
bug 59830: add context to why no more bytes could be read from input stream
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 05:39:56 +00:00
Javen O'Neal
3092c1121e
bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68
2016-07-08 18:45:15 +00:00
Javen O'Neal
bb7da64c25
add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 23:00:07 +00:00
Javen O'Neal
140b11bc7a
bug 59805: tearDown should reset, not set, the LocaleUtil ThreadLocals (also avoid memory leaks)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751741 13f79535-47bb-0310-9956-ffa450edef68
2016-07-07 02:09:25 +00:00
Javen O'Neal
1766825f62
bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 09:23:34 +00:00
Javen O'Neal
83e27bd10c
bug 59805: add unit test for LocaleUtil#getLocaleCalendar
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751629 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 08:52:40 +00:00
Javen O'Neal
076b9b600d
bug 59805: add unit test for LocaleUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751620 13f79535-47bb-0310-9956-ffa450edef68
2016-07-06 08:12:08 +00:00
Dominik Stadler
6784574ea2
Add a unit-test to verify that DataFormatter.formatCellValue() does format formula-results correctly
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751400 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 07:24:14 +00:00
Javen O'Neal
268c5deeb2
bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal
034d3cfcca
bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal
fba65665fb
reorganize imports (remove unused imports, sort alphabetically)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:38:25 +00:00
Javen O'Neal
64ef8e26a3
bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal
d1d6ea97fb
bug 59791: convert Cell Type to an enum
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal
d358c2a0ab
bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 03:06:11 +00:00
Javen O'Neal
f972e1c6e4
bug 59166: suggest alternative implementations for TempFileCreationStrategy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 01:07:52 +00:00
Javen O'Neal
569db169dd
bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 00:00:20 +00:00
Javen O'Neal
c54deaf3ff
uncomment ignored unit tests so they at least compile
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:59:41 +00:00
Javen O'Neal
0e118a7b6d
bug 59788: create temporary directories
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:58:06 +00:00
Andreas Beeker
1781e9d83f
deprecated DrawingManager
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 22:21:55 +00:00
Andreas Beeker
8e84226202
#59170 - Remove deprecated classes (POI 3.15) - o.a.p.hssf.model.*Shape classes removed
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751174 13f79535-47bb-0310-9956-ffa450edef68
2016-07-03 21:54:17 +00:00
Javen O'Neal
4ab0e89901
bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Andreas Beeker
6eab79528b
a few performance fixes to speed-up the tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750867 13f79535-47bb-0310-9956-ffa450edef68
2016-06-30 22:59:46 +00:00
Andreas Beeker
099f63d054
deprecated constants pointing to MissingCellPolicy - use enum instead
...
javadocs fixes (jdk8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 23:31:12 +00:00
Javen O'Neal
fd1a23361b
bug 59748: replace Hashtable with HashMap; contributed by Axel Howind
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1750168 13f79535-47bb-0310-9956-ffa450edef68
2016-06-24 21:39:44 +00:00
Javen O'Neal
0f3a7b24b4
bug 56781: make Name#validateName compatible on Java 6 (no Regex \p{IsAlphabetic} metaclasses
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749305 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 11:27:40 +00:00
Javen O'Neal
d23e77fcf5
remove commented out @Ignore
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:32:21 +00:00
Javen O'Neal
b617f3ccec
bug 56781: disallow names with symbols, except underscore, period, and backslash
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 10:27:52 +00:00
Javen O'Neal
3881a0db31
bug 57929: add disabled unit test, adapted from nova
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 07:15:09 +00:00
Javen O'Neal
7929adbf80
whitespace (tabs to 4 spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749264 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 04:21:26 +00:00
Javen O'Neal
57e9abb8d1
parameterize raw generics
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749260 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:50:30 +00:00
Javen O'Neal
ce8b8ea7ab
bug 59730: promote XSSFSheet#removeMergedRegions to Sheet interface
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749258 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 03:40:32 +00:00
Javen O'Neal
2804197bdb
bug 56454: add disabled unit test based on Jörg Selbach's test case showing shiftRows incorrectly handles merged regions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749246 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 01:44:44 +00:00
Javen O'Neal
8c6c7783d6
mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Javen O'Neal
e205422d39
bug 56454: add CellRangeAddress#containsRow and containsColumn
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:16:41 +00:00
Javen O'Neal
e08786d49e
convert TestCellRangeAddress from junit3 to junit4
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749237 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:00:41 +00:00
Javen O'Neal
ebd55552bf
bug 59728: add disabled unit test: should not be able to add an array formula to merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749225 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:51:01 +00:00
Nick Burch
7da9b2cd67
#59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:13:41 +00:00
Javen O'Neal
492aac4e73
bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:00:44 +00:00
Javen O'Neal
895bcab9f9
bug 59645: add Page Setup Print row and column headings support for Common SS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00
Javen O'Neal
d8d821b1f2
add unit test for HSSFWorkbook.getSelectedTabs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 02:37:24 +00:00
Javen O'Neal
59d1dc095b
bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:06:53 +00:00
Javen O'Neal
645fbd08fc
bug 59279: add unit test for CellComment.equals and CellComment.hashCode
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748827 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:17:47 +00:00
Javen O'Neal
720e866a4c
add unit test for Cell.getCellComment
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748813 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:54:08 +00:00
Javen O'Neal
e355d20cfa
bug 59170: remove deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:26:58 +00:00
Andreas Beeker
d8437d0476
reverted changes of r1747942 and deprecated instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 21:18:50 +00:00
Javen O'Neal
227a62ce1e
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748294 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:14:26 +00:00
Javen O'Neal
beef6df971
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:12:29 +00:00
Javen O'Neal
8bf974b185
add useless unit test for o.a.p.ss.util.RegionUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748170 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:14:44 +00:00
Javen O'Neal
48eb5c521b
improve unit test coverage on CellReference.
...
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:58:55 +00:00
Javen O'Neal
9d58a47e0c
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:25:50 +00:00
Javen O'Neal
a3e44453ca
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:00:51 +00:00
Javen O'Neal
75e4c452bf
test copy constructor: make changes to same range: this is a better test for deepcopy
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:50:52 +00:00
Javen O'Neal
ca9431d71f
add copy constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:43:34 +00:00