moparisthebest/poi
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Add a possible future TODO

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Nick Burch 2017-02-10 14:02:12 +00:00
parent fc31afbb86
commit ea2eb34f46
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java
View File

@ -88,6 +88,11 @@ public class FileBackedDataSource extends DataSource {
throw new IndexOutOfBoundsException("Position " + position + " past the end of the file"); throw new IndexOutOfBoundsException("Position " + position + " past the end of the file");
} }
// TODO Could we do the read-only case with MapMode.PRIVATE instead?
// See https://docs.oracle.com/javase/7/docs/api/java/nio/channels/FileChannel.MapMode.html#PRIVATE
// Or should we have 3 modes instead of the current boolean -
// read-write, read-only, read-to-write-elsewhere?
// Do we read or map (for read/write)? // Do we read or map (for read/write)?
ByteBuffer dst; ByteBuffer dst;
if (writable) { if (writable) {