From ea2eb34f4656d1085e54b025f6d0bd874f9bbd2a Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Fri, 10 Feb 2017 14:02:12 +0000 Subject: [PATCH] Add a possible future TODO git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782472 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java b/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java index 32a8701fb..69f361791 100644 --- a/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java +++ b/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java @@ -88,6 +88,11 @@ public class FileBackedDataSource extends DataSource { throw new IndexOutOfBoundsException("Position " + position + " past the end of the file"); } + // TODO Could we do the read-only case with MapMode.PRIVATE instead? + // See https://docs.oracle.com/javase/7/docs/api/java/nio/channels/FileChannel.MapMode.html#PRIVATE + // Or should we have 3 modes instead of the current boolean - + // read-write, read-only, read-to-write-elsewhere? + // Do we read or map (for read/write)? ByteBuffer dst; if (writable) {