1
0
mirror of https://github.com/moparisthebest/pacman synced 2024-08-13 17:03:46 -04:00
pacman/lib/libalpm
Xavier Chantry a2d7f6f206 libalpm/remove: fix funny progress bar problem with empty packages
$ pacman -Rd kde-meta

Remove (15): kde-meta-kdewebdev-4.5-1 [0.00 MB]  kde-meta-kdeutils-4.5-1 [0.00 MB]
             kde-meta-kdetoys-4.5-1 [0.00 MB]  kde-meta-kdesdk-4.5-1 [0.00 MB]
             kde-meta-kdeplasma-addons-4.5-1 [0.00 MB]  kde-meta-kdepim-4.5-1 [0.00 MB]
             kde-meta-kdenetwork-4.5-1 [0.00 MB]  kde-meta-kdemultimedia-4.5-1 [0.00 MB]
             kde-meta-kdegraphics-4.5-1 [0.00 MB]  kde-meta-kdegames-4.5-1 [0.00 MB]
             kde-meta-kdeedu-4.5-1 [0.00 MB]  kde-meta-kdebase-4.5-1 [0.00 MB]
             kde-meta-kdeartwork-4.5-1 [0.00 MB]  kde-meta-kdeadmin-4.5-1 [0.00 MB]
             kde-meta-kdeaccessibility-4.5-1 [0.00 MB]

Total Removed Size:   0.06 MB

Do you want to remove these packages? [Y/n]
( 1/15) removing kde-meta-kdewebdev      [------------------------] 100%
$ it stopped here..

On one side, libalpm did not initialize the progress bar at 0 percent.
So with meta-packages that have 0 files, there was only one progress bar
call with percent == 100.

On the other side, pacman callback kept track of the last percent that
it received. When there are only meta-packages, we always received only
100, so pacman believed the progress bar needed not update. Thus only
the first package was actually displayed.

A proper fix for the callback would be to keep track of last package
name to make sure the recorded prev percent applies.

But since we now specify that both Add and Remove should at least send
percent=0 at beginning and percent=100 at the end, there is no need
for that.

Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
2010-10-18 16:46:41 -05:00
..
po Update Kazakh translation 2010-09-15 07:19:51 -05:00
.gitignore Remove unnecessary entries from .gitignore files 2007-07-16 16:49:28 -04:00
add.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
add.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
alpm_list.c alpm_list_diff_sorted - make some arguments const 2010-03-25 21:31:37 -05:00
alpm_list.h alpm_list_diff_sorted - make some arguments const 2010-03-25 21:31:37 -05:00
alpm.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
alpm.h Introduce -D, --database 2010-05-05 10:37:01 -05:00
backup.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
backup.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
be_files.c More consistent printing of off_t and time_t 2010-03-25 21:58:35 -05:00
be_package.c Read 'force' entry from packages 2010-10-11 17:48:11 -05:00
cache.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
cache.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
conflict.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
conflict.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
db.c Introduce -D, --database 2010-05-05 10:37:01 -05:00
db.h Compute package download size outside _alpm_sync_prepare 2010-05-05 18:15:52 -05:00
delta.c More consistent printing of off_t and time_t 2010-03-25 21:58:35 -05:00
delta.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
deps.c Partial fix for the phonon/qt issue 2010-05-18 11:33:00 -05:00
deps.h Partial fix for the phonon/qt issue 2010-05-18 11:33:00 -05:00
dload.c More consistent printing of off_t and time_t 2010-03-25 21:58:35 -05:00
dload.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
error.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
graph.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
group.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
group.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
handle.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
handle.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
log.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
log.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
Makefile.am Move vercmp code into a separate file 2010-05-04 23:32:13 -05:00
md5.c Add note about XySSL/PolarSSL name change 2010-06-07 10:35:08 -05:00
md5.h libalpm/md5: Fix license header 2008-06-03 21:31:31 -05:00
package.c Move vercmp code into a separate file 2010-05-04 23:32:13 -05:00
package.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
remove.c libalpm/remove: fix funny progress bar problem with empty packages 2010-10-18 16:46:41 -05:00
remove.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
sync.c Mark sync_pkg and sync_target as static functions 2010-07-27 10:10:55 -05:00
sync.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
trans.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
trans.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
util.c Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
util.h Bump copyright dates to 2010 2010-03-14 19:46:59 -05:00
version.c Remove call to function logger 2010-05-04 23:38:52 -05:00