Commit Graph

435 Commits

Author SHA1 Message Date
Aaron Griffin 3d07ad9539 Copy/pasta error in alpm_get_upgrades that caused a segfault 2007-02-07 06:19:40 +00:00
Aaron Griffin cbd516a06e Only honor 'force' if versions are NOT identical 2007-02-07 06:12:53 +00:00
Aaron Griffin 6c5066471c Cleanup and more debug info for alpm_pkg_compare_versions 2007-02-07 05:57:28 +00:00
Dan McGee da637c79e5 Oops. Actuall add two new translation templates as requested on the ML-
'it' and 'pt_BR'.
2007-02-07 02:24:13 +00:00
Dan McGee f05b6c152b * Update of all the *.po files and *.pot template files.
* Makefile targets to rebuild po files now work - use 'make update-po' in
  the po directories.
* Added two new translation templates as requested on the ML- 'it' and
  'pt_BR'.

This commit might be a bit big for the mailing list to like on the commit
message. :)
2007-02-07 02:22:53 +00:00
Dan McGee 4de804d157 * Makepkg updates, and small bugfix on man page compression.
* Change libtool default to makepkg2 behavior.
* Other small changes.
2007-02-06 22:36:13 +00:00
Dan McGee 96a0115630 Cleaning up mistakes. :P 2007-02-06 21:28:29 +00:00
Aaron Griffin 79c277a218 Attempt #2 at -S/-Su unification: verify that the 'force' option has been read before comparing versions 2007-02-06 20:57:17 +00:00
Aaron Griffin 7d63ecfac6 Copy-pasta errors. 8) 2007-02-06 17:41:36 +00:00
Aaron Griffin 67ea493ec2 Attempt to unify the -S and -Su version comparissons for when a package is newer
See FS#5388
2007-02-06 17:39:32 +00:00
Aaron Griffin 63000584b6 Implemented a crappy version of -Qu (query upgrades). This simply outputs the
packages to be upgraded in a -Su operation.  Much of the code is duplicated from
sync.c.
TODO: move the implementation to upgrades.c, and reimplement the sync_sysupgrade
function in terms of this:
    trans->packages = alpm_get_upgrades();
2007-02-04 08:26:52 +00:00
Aaron Griffin b2da4b4234 * Added archive verification when loading package metadata for -u and -A
operations (now aborts on a corrupt archive)
* Fixed the pm_fprintf newline error that was plaguing us.  It seems a line
  resetting 'neednl' was removed a while back (by me).  This causes all the
  output errors we've been seeing
2007-02-04 03:24:32 +00:00
Aaron Griffin 616620ad5c * Minor output fix (move colon so it's not part of the URL)
* Added ldconfig on --sync operations too
2007-02-01 03:31:46 +00:00
Aaron Griffin 21e19a7bcf Loading package data from a file was ALWAYS generating the filelist, instead of
using the in-package one. This is now fixed, and an autogenerated one is used as
a last resort.

This fixes the bug where /.CHANGELOG showed up in -Ql.
2007-02-01 03:00:34 +00:00
Aaron Griffin a2bd6d105c Cleaned up some of the metadata control 2007-02-01 02:29:07 +00:00
Aaron Griffin 4cd65c0a31 * !strcmp reads funny (as "not string compare" - switch those to == 0, which has
a positive connotation.
* Added a nice TODO
2007-02-01 01:51:12 +00:00
Aaron Griffin 21729f0ce4 * Forgot the int->enum header checkin
* Removed the dep-sorting TODO item - switch the sorting to a topological sort
  later (I'll let Dan do the CS stuff, heh)
2007-01-31 08:10:01 +00:00
Aaron Griffin 290b962c48 Switched an int to an enum 2007-01-31 07:14:50 +00:00
Aaron Griffin 0adceabe13 Fix corrupt DB entry handling when loading package entries.
* scan loops no longer abort on corrupt entries
* reloading a cache package (and discovering it corrupt) no longer prints 2 messages
  and uses the pre-build "remove from package cache" function

NOTE: The TODOs in there are important for later w.r.t. cleaning up corrupt DB
entries but there are some logical complexities with doing so, so I'm holding
off for now.
2007-01-31 06:48:06 +00:00
Aaron Griffin 670319c2fb Debug logging changes:
* The --debug params were goofy.  New setup allows --debug without params,
  --debug=<level> where level 1=debug output, 2=debug and download output,
  3=debug, download, and function tracing output.  This seems more sane to me.
* Removed PM_LOG_FLOW1 and PM_LOG_FLOW2.  They were just confusing.  When adding
  new functions, it is near impossible to determin if your output should be
  "flow1" or "flow2" without tracking all the way up the call chain.  Rarely
  would one ever say "ok, lets just show "flow2" output.  These have both been
  replaced with PM_LOG_DEBUG
* Removed the need for the root parameter on alpm_initialize. it is now
  defaulted to PM_ROOT just like dbpath and cachedir.  This allows alpm to be
  initialized BEFORE option parsing in the front end, saving us some duplicate
  variables in the frontend.
* Cleaned up front end variables due to early alpm_initialize call.
2007-01-31 06:10:21 +00:00
Dan McGee 44dc48f10f slight line spacing/indent updates 2007-01-31 02:58:12 +00:00
Aaron Griffin da648bc24c K. Piche <kevin.piche@cgi.com>
* ALPM_LOG_FUNCTION macro and all the great work to add this macro everywhere
2007-01-30 08:14:10 +00:00
Aaron Griffin 195e30e8aa K. Piche <kpiche@rogers.com>
* gcc visiblity changes

Also modified _alpm_versioncmp -> alpm_versioncmp (public function) as per K.
Piche's suggestions
2007-01-30 07:47:19 +00:00
Dan McGee 0bc06918e4 * Remove -fno-strict-aliasing as it is now unnecessary to compile.
* Fix up add.c a bit better than it was in regards to FS #3492.
* Optimized the sqrt call in dependency cycle checking to a single call.
* Removal of an outdated comment.
2007-01-30 05:41:13 +00:00
Dan McGee 1799afc9c1 Discussed on IRC for a bit, this makes the following changes for clarity:
* alpm_list_is_in    --> alpm_list_find
* alpm_list_is_strin --> alpm_list_find_str
* Flip parameters of both functions to be inline with rest of alpm_list.

First commit, woohoo.
2007-01-30 03:46:33 +00:00
Jürgen Hötzel 13f9fc4d19 * Fix building outside $(srcdir).
* Removed ./gen-mirrorlist.sh invocation from configure script:
  Mirror-files are generated by make, not configure.
2007-01-29 22:18:31 +00:00
Aaron Griffin e22336673a Dan McGee <dpmcgee@gmail.com>
* Lots of code cleanup, and type fixes
* Make 'makeworld' a bit more in-line with the other stuff
* Make -Si and -Qi operations appear the same
2007-01-26 02:13:16 +00:00
Aaron Griffin a5ad2b3f93 * Fix FS #3107- Use ISO date style
* Fix FS #5409- document that pacman.conf repo ordering is important

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
2007-01-26 01:33:03 +00:00
Aaron Griffin 170d63190a * Shuffled some of the alpm_list free funtions - still not perfect, but better
* Added alpm_list_remove_node for single list node removal
* Proper error checking/output for failed db_read/db_write (missing files)
* Invalid packages (missing files) are now removed from the package cache
* -Qs and -Ss output now look the same
* config.rpath causes errors on one machine I had, so I added it to CVS
* Fixed a "clobbered memory" issue when installing groups - only the outer list
  should be free'd, not the contained data
2007-01-24 08:51:50 +00:00
Aaron Griffin 1b61cc8c69 This mainly deals with code clarity- removing currently unneeded
optimizations in order to make the code much more readable and
type-checkable. Every enum in the library now has it's own type that
should be used instead of the generic 'unsigned char'. In addition,
several #define statements dealing with constants were converted to
enums.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
2007-01-24 03:02:53 +00:00
Aaron Griffin 8b11dd50eb James Rosten <seinfeld90@gmail.com>
* attempt to unlink file AFTER moving to .pacsave always fails
2007-01-23 16:05:21 +00:00
Aaron Griffin 4db24ca28a * Added some calloc calls to replace the malloc-then-set-to-zero functionality
* Fixed -Ss output so as not to call alpm_list_getdata with a NULl list
* Added a NULL check in alpm_list_getdata
* Fixed alpm_list_add_sorted to properly handle a new / beginning insertions
2007-01-23 01:34:58 +00:00
Aaron Griffin 000256cbc5 * Added a check for .FILELIST for package validity in addition to .PKGINFO 2007-01-22 16:16:51 +00:00
Aaron Griffin c19839695b Introduced an infinite loop during the pmlist -> alpm_list transition, whoops 2007-01-22 09:27:00 +00:00
Aaron Griffin 35a9f3e7d0 Moved some decls to make the "pkg_invalid" patch compile again. 2007-01-19 23:44:50 +00:00
Aaron Griffin 77f6bcfa3d Whoops. There's a 0 where there should be a 1. 2007-01-19 18:06:37 +00:00
Aaron Griffin d27e5efec9 Johannes Weiner <hannes@saeurebad.de>
* package cleanup (pkg_invalid) refactoring
2007-01-19 18:05:19 +00:00
Aaron Griffin e310209296 Johannes Weiner <hannes@saeurebad.de>
* use calloc to zero-out new packages (far more ideal)
* use memcpy to copy primatives when copying package structures
2007-01-19 18:01:02 +00:00
Aaron Griffin 6167017264 Preliminary checkin for alpm_list conversion
* renamed pmlist_t -> alpm_list_t
* made alpm_list_t a public type (alpm_list.h header)
* removed additional storage for registered DBs in pacman source
* some code cleanup
* removed duplicate (pm)list_display functions from pacman source
* misc code cleanup
2007-01-19 09:28:44 +00:00
Aaron Griffin 37b83a7401 Some confusion with variable names in unlink_file caused unlink to try and find the _relative_ file instead of absolute. The absolute path name has also been used in some of the output there too. 2007-01-18 17:04:25 +00:00
Aaron Griffin 86b136bb59 Dan McGee <dpmcgee@gmail.com>
* Removed some unnecessary headers and library links
* Made things static if possible
* Cleaned up makefiles a bit
* Fixed some old comments in the code
* Fixed some errors the static code checker splint pointed out
* Backwards arguments in a memset call in _alpm_db_read (could have been worse)
* Other various small fixes

Other:
* Default to 80 columns when getcols cannot determine display width
* Removal of ._install as a valid install file in packages
2007-01-18 16:52:57 +00:00
Aaron Griffin 46e26ac5c8 Dan McGee <dpmcgee@gmail.com>
* fix "warning: dereferencing type-punned pointer will break strict-aliasing rules"
2007-01-18 16:09:34 +00:00
Aaron Griffin f6a76dac12 Added strerror() output on unlink failure 2007-01-18 16:04:05 +00:00
Aaron Griffin 1bea7706ae * Misc logging changes
Addition of a forced fflush in an attempt to diagnose mutli-logging
  Removal of varargs from the internal logaction function, they are handled in
   alpm_logaction just fine
2007-01-17 07:21:07 +00:00
Aaron Griffin 803f92b6a6 James Rosten <seinfeld90@gmail.com>
* _alpm_remove_commit refactoring
* clean up/fixes by Dan McGee <dpmcgee@gmail.com>
2007-01-17 04:47:19 +00:00
Aaron Griffin 726e90dc2c Jürgen Hötzel <juergen@hoetzel.info>
* avoid repeated regex compilations (regex for search string do not
 change while scanning the package database)

* remove needless string duplication (regex function do not change target
 string nor free them)

* code cleanup

This patch improves search performance:

bash-3.2$ time ./src/pacman/pacman.static.old -Ss "(database|web).*server" >/dev/null

real    0m1.026s
user    0m0.544s
sys     0m0.208s
bash-3.2$ time ./src/pacman/pacman.static -Ss "(database|web).*server" >/dev/null

real    0m0.777s
user    0m0.456s
sys     0m0.128s
bash-3.2$
2007-01-17 03:57:53 +00:00
Aaron Griffin 42f8b8b2d3 cvsignore cleanup and additions 2007-01-17 03:40:08 +00:00
Aaron Griffin 2a457c5319 * Jrgen Htzel <juergen@hoetzel.info>
_alpm_db_load_pkgcache: use mergesort to improve performance
2007-01-11 17:44:39 +00:00
Aaron Griffin 244fb2a264 * Dan McGee <dpmcgee@gmail.com>
Documentation cleanup
2007-01-11 17:32:49 +00:00
Aaron Griffin 043a49701f * bug fix FS#6100 - fix --print-uris output 2007-01-03 08:05:13 +00:00