moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-08-13 17:03:48 -04:00
Code Issues Releases Wiki Activity
3,276 Commits 36 Branches 329 Tags 887 MiB
dd5ab2c2c6
Commit Graph

1972 Commits

Author SHA1 Message Date
cketti
5a8ddaa039 Make sure draft id points to a valid message before deleting it 
Avoids IllegalArgumentException in LocalStore.getMessage()
 2012-01-26 00:37:25 +01:00
cketti
aae734c175 Don't Log.w() full stacktrace if file wasn't found 
This happens regularly when AttachmentView tries to get a thumbnail for
attachments that haven't been downloaded yet.
 2012-01-24 22:14:21 +01:00
cketti
4e5d116713 Delete attachment metadata and thumbnails when deleting attachments 2012-01-24 16:15:45 +01:00
cketti
c6696f632a Code cleanup, fixed some warnings, rearranged some stuff 2012-01-24 16:15:44 +01:00
cketti
7a3cadbf1c Refactored AttachmentProvider.openFile() 2012-01-24 16:15:44 +01:00
cketti
4bbc5de1ba Code cleanup / fixed lots of warnings 2012-01-22 06:25:06 +01:00
cketti
45faad041e Don't finish() MessageCompose in onPause() 2012-01-22 05:32:52 +01:00
cketti
bddacf6b64 Use database ID to keep track of the current draft 
By using the database ID we avoid having to deal with the problem of
changing UIDs. First the message has a local UID, then, when the upload
to the server is completed, it gets a remote UID.
 2012-01-22 05:20:41 +01:00
cketti
96f827d291 Modified LocalStore to use UPDATE when replacing existing messages 
This way we can later use the database ID to keep track of drafts.
 2012-01-22 05:20:41 +01:00
cketti
be2aac52a8 Reload accounts after writing imported account settings to storage 
This makes sure that when the next account is imported it will see the
account just imported. That's necessary e.g. when going though all
accounts to find the next free account number, or when avoiding account
name conflicts.
 2012-01-21 03:10:40 +01:00
cketti
0625e13380 Canceling notifications once should be enough 2012-01-20 23:32:55 +01:00
cketti
a8f91b0f70 Minor code cleanup 2012-01-20 23:32:12 +01:00
cketti
7eccc1701d Merge branch 'issue3508' 2012-01-20 23:19:22 +01:00
cketti
2c5f640b9e Minor cleanup 2012-01-20 23:15:11 +01:00
wcb
457e65010e Issue 3139: notifications of new messages removed when unified inbox is selected 2012-01-20 11:55:04 -08:00
Nick Nikolaou
773d1e30f1 Simplied code and added curly brackets to if/else 2012-01-20 19:10:11 +00:00
cketti
32a29f131b Make sure an IOException is always passed through as MessagingException 
This is important for the code handling pending actions in
MessagingController. If a non-permantent MessagingException is
encountered, the pending action is retried later.

Fixes issue 3696
 2012-01-20 19:50:07 +01:00
Nick Nikolaou
1a01c10fc5 Don't save to drafts if drafts folder is -NONE- 2012-01-20 17:02:35 +00:00
cketti
258b0039d5 IMAP: also get the Message-ID when fetching the message "envelope" 
This should fix issue 3994
 2012-01-14 06:30:22 +01:00
cketti
66b7805a57 Fixed a bug in the IMAP response parser 
Also got rid of ImapResponse.more() which isn't necessary anymore.
 2012-01-12 07:56:52 +01:00
cketti
ad8b025b6f Fixed indentation 2012-01-12 02:20:22 +01:00
cketti
8e627834c1 Changed font size unit from DIP to SP 
"Scale-independent Pixels - this is like the dp unit, but it is also
scaled by the user's font size preference. It is recommend you use this
unit when specifying font sizes, so they will be adjusted for both the
screen density and the user's preference." - Android Developer Docs
 2012-01-12 02:18:41 +01:00
cketti
edf0361aab Added font size setting for text input fields in MessageCompose 2012-01-12 01:05:01 +01:00
cketti
e7f29d429c Fixed quoted text for plain text messages 2012-01-10 07:44:50 +01:00
cketti
0d8497b04b Restructured and documented MessageCompose.buildText() 
Also fixed a bug where the signature wasn't appended in the HTML part of
newly composed messages.
 2012-01-10 01:47:23 +01:00
cketti
a191415860 Avoid using TreeMap methods introduced with API 9 2012-01-08 04:04:25 +01:00
Jesse Vincent
ec78c1e009 Save settings changes "on pause" rather than "on back" so we actually 
save settings when a user hits home or menu or whatever.
 2012-01-06 20:27:10 -05:00
Jesse Vincent
3d9f9c4ab4 Don't save account settings until after we save the updated push 
settings.
 2012-01-06 20:12:40 -05:00
Andrew Chen
beda7beac7 Use a constant for 18 hours. 2012-01-05 19:01:00 -08:00
cketti
7e8aede93d Updated settings description with new default values (import/export) 2012-01-06 01:36:32 +01:00
Andrew Chen
06175888b9 Enable system zoom and disable gestures by default. 2012-01-05 16:10:23 -05:00
cketti
926406edd3 Be more careful when deleting an account 
Fixes issue 3954
 2012-01-05 20:24:18 +01:00
cketti
d848b434f5 Fall back to HELO command if the server doesn't know EHLO (SMTP) 
Fixes issue 2704
 2012-01-05 03:53:23 +01:00
Mark Baker
0e86fb2a80 Fixed whitespace 2012-01-04 19:58:19 +00:00
Andrew Chen
3c5a63adeb Issue 3875: Revert to the old way of determining minimum swipe distance. 
Fix my logic bug when determining left to right vs. right to left.
 2012-01-03 21:58:36 -08:00
Andrew Chen
11ebc1b262 Issue 3875: Add a bit more debug data for swiping. 2012-01-03 21:19:59 -08:00
Andrew Chen
fc5ea05e48 Issue 3875: Add more debugging lines to figure out what might be wrong with the new swipe algorithm. 
Fix some variable names.
 2012-01-03 21:06:20 -08:00
Andrew Chen
81f0cb510a Remove unused date formatter. 2012-01-03 21:04:27 -08:00
cketti
fec6434f08 Removed unused code 2012-01-04 03:57:54 +01:00
cketti
71174417ce Clone Message object to avoid ConcurrentModificationExceptions 
Fixes issue 3953
 2012-01-04 03:57:53 +01:00
edpeur
daeedc2222 Close resources properly 2011-12-31 17:38:41 +00:00
cketti
0aa513429a Show/hide ListView footer depending on message list type 
Fixes issue 3946
 2011-12-31 02:24:54 +01:00
Mark Baker
09c6cfb6e4 Remove TODO 2011-12-29 09:56:54 +00:00
wongk
fb3cd234fa Merge branch 'master' of github.com:k9mail/k-9 2011-12-28 14:04:37 -05:00
wongk
b2d5ea3ce2 Fixed the parsing of response data for WebDAV requests. 2011-12-28 14:03:44 -05:00
Mark Baker
7ad5429e98 Merge remote-tracking branch 'upstream/master' 2011-12-26 19:17:05 +00:00
cketti
852dca4124 Removed unused import 2011-12-26 02:30:59 +01:00
András Veres-Szentkirályi
39ef1ae9a4 Removed overrides merely calling super() 2011-12-26 02:28:32 +01:00
András Veres-Szentkirályi
cea6f4468d Removed unused private field 2011-12-26 02:28:31 +01:00
András Veres-Szentkirályi
1949067979 Removed unnecessary return statement 2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
de30c712f9 Removed duplicate import 2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
b9ea7db5da Removed unneeded semicolons 2011-12-26 02:28:29 +01:00
Mark Baker
af1b9f83f2 Added batch buttons for Archive and Move. Made batch buttons configurable. 2011-12-24 18:17:12 +00:00
cketti
6de081c5b0 Minor cleanup 2011-12-19 02:21:27 +01:00
mwolschon
696666ca5e Issue 1303: can't send mail get "no route to host" error 2011-12-19 02:10:17 +01:00
mwolschon
2bfe1f4533 Issue 17: Hierarchical folder list / folder tree 2011-12-15 10:34:29 +01:00
cketti
61ca1a2ae2 Use internal representation for settings during the upgrade process 
This avoids constant conversion between the string representation used
in preference storage and the internal representation.
 2011-12-11 06:02:31 +01:00
cketti
345f4c2939 Code cleanup; no functional changes 2011-12-11 05:16:22 +01:00
cketti
18a58e2872 Added code to upgrade settings on import 
This allows us to import files with an outdated content version, then
upgrade the settings to the current content version.
 2011-12-11 05:16:22 +01:00
cketti
d57e684296 Extended *Settings classes to handle multiple versions 2011-12-11 05:16:22 +01:00
cketti
50058a92db Fixed "managed" back button behavior in MessageView 2011-12-05 18:16:43 +01:00
Koji Arai
d1778e0303 mIgnoreOnStop should be set to true when call startActivityForResult() 2011-12-04 05:25:57 +09:00
cketti
63605b65b6 Add support for new auto-detect namespace setting to ImapStore 2011-12-01 06:30:47 +01:00
cketti
017033cd53 Changed UI to allow selecting the empty IMAP namespace 2011-12-01 06:05:05 +01:00
cketti
75cdbd860e Only save IMAP path prefix in store URI if auto-detection isn't used 2011-12-01 05:58:44 +01:00
cketti
f729dd72dc Code cleanup 2011-12-01 05:17:32 +01:00
cketti
9f41afc6e7 Use Store.createStoreUri() in AccountSetupIncoming 2011-12-01 05:10:13 +01:00
cketti
f2253a95d7 Modified ServerSettings to be able to create instances with "extras" 2011-12-01 02:57:53 +01:00
cketti
cb7b88680b Use Store.decodeStoreUri() in AccountSetupIncoming 2011-12-01 02:28:57 +01:00
cketti
9e0ea7dd79 Extended ImapStore URI to support empty IMAP path prefix 2011-12-01 01:57:50 +01:00
cketti
d6fbeb2913 Fixed creation of store URIs when a "path" was used. 2011-11-29 21:45:52 +01:00
cketti
9350a3b1b6 Merge pull request #105 from andrewgaul/writer-string-concatenation 
Avoid string concatenation in Writer.write
 2011-11-27 16:32:25 -08:00
cketti
23c72cd181 FixedLengthInputStream - code cleanup 
Inspired by andrewgaul
 2011-11-28 01:21:50 +01:00
cketti
798d6753dd FixedLengthInputStream - implement skip which honors mLength 
Patch by andrewgaul
 2011-11-28 01:14:49 +01:00
cketti
e145a621c7 FixedLengthInputStream - increment mCount only when read() succeeds 
Patch by andrewgaul
 2011-11-28 01:10:41 +01:00
Andrew Gaul
368bac851b Prefer Boolean constants over Boolean.valueOf 2011-11-27 15:10:58 -08:00
Andrew Gaul
e93510b4b3 Avoid string concatenation in Writer.write 2011-11-27 13:57:11 -08:00
Andrew Gaul
057b316bcb Avoid NPE in getOldestMessageDate 
Caused by autounboxing a possibly null Long into a long.
 2011-11-27 10:35:06 -08:00
Andrew Chen
4b548169d6 Merge pull request #82 from ashleywillis/issue-1424 
Issue 1424: saving duplicate or similar drafts fixed.
 2011-11-21 11:13:09 -08:00
Andrew Chen
6fc22283db Merge pull request #102 from ashleywillis/pgp-fixes 
Pgp-related fixes (issues 2152, 2900, 3673, partially 1424)
 2011-11-21 07:28:16 -08:00
cketti
20eab9c812 Rewrite application/x-zip-compressed to application/zip 2011-11-21 11:49:03 +01:00
ashley willis
e9c8ec5598 Merge branch 'master' into pgp-fixes 2011-11-21 02:24:10 -06:00
ashley willis
94ba9bf71f added comments, reworked a bit, and created warning dialog if some recipients don't have keys saved. 2011-11-21 01:59:51 -06:00
cketti
73edf5c31a Fixed problem with back button because of custom dispatchKeyEvent() 2011-11-20 21:29:18 +01:00
ashley willis
18ad12eda7 incremented Settings.VERSION 2011-11-19 18:15:20 -06:00
ashley willis
079996ebe5 refuse to save draft marked encrypted 2011-11-19 18:05:24 -06:00
ashley willis
c49d1ecc8e removed code from previous commit disabling of syncing drafts to be encrypted. 2011-11-19 13:34:26 -06:00
ashley willis
51c662f0d0 pgp issues 2152, 2900, and 3673. also option to disable not-yet-encrypted drafts related to issue 1424. 2011-11-19 00:49:04 -06:00
Koji Arai
d82d0a220c Fixed Issue 3850. Revert part of the onBackPressed() magic to back from MessageView. 
At least, this code still needed on android.os.Build.VERSION.SDK_INT == GINGERBREAD_MR1.
 2011-11-17 22:52:35 +09:00
Apoorv Khatreja
4b0d3ccf21 Removed an unnecessary portion of code that attempted to handle command continuation requests after a UID COPY command. Also removed some extraneous test code that mysteriously creeped into the repo. 2011-11-17 02:46:01 +05:30
cketti
fe727f8b20 Merge pull request #98 from cketti/remove_legacy_code 
Remove legacy code
 2011-11-15 20:07:23 -08:00
cketti
4f060642ee Merge branch 'imap_parser' 2011-11-16 04:52:05 +01:00
cketti
99163dc9b9 Removed isSizeOrExpungeResponse() 
I don't understand what the purpose of this code was. It stopped parsing
before the end of the line was reached, thus causing problems with
parsing subsequent lines of the response.
 2011-11-16 04:48:50 +01:00
cketti
8cdd283bb8 Added Javadoc comment 2011-11-16 03:59:27 +01:00
cketti
e9b0f82c11 Minor code cleanup 2011-11-16 03:23:59 +01:00
cketti
f8779095d9 Parse resp-text on command continuation requests 2011-11-16 03:17:36 +01:00
cketti
43f5cbb361 Renamed parseStatusResponse() to parseResponseText() 2011-11-16 03:11:35 +01:00
cketti
727c8564ec Cleaned up readTokens() 2011-11-16 03:10:26 +01:00
cketti
688db057ac Removed unused imports 2011-11-16 02:51:46 +01:00
Andrew Chen
97bfb5e229 Merge branch 'star-confirm' of https://github.com/ashleywillis/k-9 into pull-101 
* 'star-confirm' of https://github.com/ashleywillis/k-9:
  Option to have confirmation on deleting starred messages.
  incremented preferences/Settings.VERSION for new settings
 2011-11-15 11:21:27 -08:00
ashley willis
6a02552b23 incremented preferences/Settings.VERSION for new settings 2011-11-15 13:01:30 -06:00
Andrew Chen
ec17cd3c38 Merge pull request #100 from ashleywillis/autoformat 
Message Format: Automatic (plain text unless replying to an HTML message)
 2011-11-15 10:13:45 -08:00
ashley willis
6694f637e3 capitalization and change of variable names. 2011-11-15 00:42:37 -06:00
ashley willis
3ffb5021e1 Option to have confirmation on deleting starred messages. 2011-11-15 00:28:41 -06:00
Jesse Vincent
a8ef6594ec Preserve header order (with the exception of duplicate headers like 
"received" they all show up where the first one did
 2011-11-15 00:00:42 -05:00
Andrew Chen
c642b10b39 Merge pull request #99 from andrewachen/autoconfig_gmail_yahoo 
Do a better job of auto-configuring Yahoo! and Gmail accounts
 2011-11-14 18:57:38 -08:00
Andrew Chen
7ca438669e Add theoretical support for RFC6154 SPECIAL-USE for auto-configuration. 2011-11-14 18:55:11 -08:00
Andrew Chen
95215f00b7 Kerio also supports auto-configuration; remove the gmail.com requirement to use XLIST for auto-configuration. 2011-11-14 18:27:08 -08:00
Andrew Chen
2f3565d180 Implement Gmail's XLIST IMAP command to determine Gmail-specific folders. 2011-11-14 18:15:32 -08:00
ashley willis
994f474aae configured so setting message format to auto does not break k-9 if it is downgraded. 2011-11-14 20:12:08 -06:00
Andrew Chen
58d20a501a Set the IMAP namespace for Gmail during auto-configuration. 2011-11-14 15:42:50 -08:00
Andrew Chen
44cc1930d5 If we auto-config a Yahoo! account, set the spam folder to be "Bulk Mail." 2011-11-14 15:42:40 -08:00
ashley willis
9201d16659 add MessageFormat.AUTO so that text/html messages are created only when necessary. 2011-11-14 17:28:45 -06:00
Andrew Chen
22e61b987e Add javadoc for getSignatureHtml() and use StringUtil.isNullOrEmpty(). 2011-11-14 14:23:29 -08:00
ashley willis
37f480c969 Merge ashleywillis' changes in https://github.com/k9mail/k-9/pull/97. 
Option to strip signature from quoted text in replies.
Strips signature from quoted text in replies (line of /^-- $/ or html
equivalent, and everything below). Per account.
 2011-11-14 14:00:15 -08:00
ashley willis
1012ad56dd Merge ashleywillis' changes in https://github.com/k9mail/k-9/pull/96 2011-11-14 13:20:07 -08:00
cketti
be70120ee5 Use Service.onStartCommand() instead of deprecated Service.onStart() 2011-11-10 06:36:14 +01:00
cketti
8c8b3eea9e Use Intent.ACTION_SEND_MULTIPLE instead of string constant 2011-11-10 05:44:30 +01:00
cketti
07fa0c7264 Use Build.VERSION.SDK_INT instead of parsing Build.VERSION.SDK 2011-11-10 05:39:04 +01:00
cketti
14ff4d006e Removed onBackPressed() magic 2011-11-10 05:38:52 +01:00
cketti
85f556e6c9 Removed helper function to create AbsoluteSizeSpan objects 2011-11-10 05:38:51 +01:00
cketti
5eb2533bcb Removed code for old contacts API (ContactsSdk3_4) 2011-11-10 05:05:06 +01:00
cketti
c5cc62b570 Removed AutoSyncHelper and use API 5 methods directly 2011-11-10 05:05:05 +01:00
Andrew Chen
a2fcb54507 Merge pull request #95 from ashleywillis/reply-after-quote 
added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);"
 2011-11-07 15:51:05 -08:00
Andrew Chen
ef631e21d1 Merge pull request #83 from andrewachen/messageview_save_location 
Restore position in MessageView after rotation screen.
 2011-11-07 09:57:18 -08:00
ashley willis
efe591c34d added "mQuotedHtmlContent.setFooterInsertionPoint(bodyOffset);" because bodyOffset could refer to header or footer 2011-11-07 01:59:03 -06:00
cketti
6497ac4cf4 Default authentication type for SMTP is automatic 2011-11-07 01:58:38 +01:00
cketti
6d9463801e Don't call promptForServerPasswords() if we already know all passwords 2011-11-07 01:45:52 +01:00
cketti
d6c03de6f5 Fixed logic bug that prevented imported accounts from being recognized 
We have to add new account UUIDs to "accountUuids" for them to show up
in the account list.
 2011-11-07 01:45:52 +01:00
cketti
e2e9f8b6a3 Fixed startActivityForResult() failing for MessageList 
Fixes issue 3638
 2011-11-07 00:07:06 +01:00
Jesse Vincent
7ca72b9d0f Work around broken office suites by sending an explicit mime type with files we open 2011-11-06 17:00:25 -05:00
cketti
70dc27c481 Make MimeUtility.getMimeTypeForViewing() return lower case MIME types 
MIME type matching in Android is case-sensitive. So we convert the MIME
types we read from the email to lower case.
 2011-11-06 02:05:47 +01:00
cketti
88a2dd6289 Merge branch 'issue549' 
Conflicts:
	src/com/fsck/k9/Account.java
	src/com/fsck/k9/mail/store/WebDavStore.java
 2011-11-05 18:47:55 +01:00
Andrew Chen
4a1046a893 Merge pull request #93 from andrewgaul/cursor-close-quietly 
Introduce and use Utility.closeQuietly(Cursor)
 2011-11-04 16:20:22 -07:00
Andrew Gaul
39aa577651 Introduce and use Utility.closeQuietly(Cursor) 
This helper is in the same spirit as IOUtils.closeQuietly.
 2011-11-04 09:58:55 -07:00
ashley willis
2b77c6e35c moved code from onStop() to onPause() since onStop() may never be called. 2011-11-04 02:33:56 -05:00
Andrew Gaul
d301089f3c Avoid string concatenation in String.format 2011-11-03 18:47:34 -07:00
cketti
5d9bf309c9 Avoid NullPointerException in services when process/service is restarted 
See issue 3750
 2011-11-03 22:10:24 +01:00
ashley willis
7f582f5a38 added mIgnoreOnStop for when adding an attachment. 2011-11-03 15:38:53 -05:00
Andrew Chen
f6eea9f014 Move the listener logic out of the Activity and into the View. 
Change variable naming in ToggleScrollView to meet standard.
Cache the result of computeVerticalScrollRange() in ToggleScrollView.
 2011-11-03 09:14:42 -07:00
Andrew Chen
57e0abbf8f Merge pull request #84 from andrewgaul/api7 
Use LinkedList instead of Deque.
 2011-11-03 07:41:09 -07:00
Andrew Chen
981dc6cca6 Merge pull request #92 from andrewgaul/remove-combine-uuids 
Prefer Utility.combine over Account.combinedUuids
 2011-11-03 06:41:33 -07:00
Andrew Chen
7f046e5f0a Merge pull request #91 from andrewgaul/findbugs-stream-close 
Improve the way we open/close streams.
 2011-11-03 06:40:07 -07:00
Andrew Chen
d80e5bfbd0 Merge pull request #90 from andrewgaul/close-quietly 
Call IOUtils.closeQuietly instead of using empty try/catch block.
 2011-11-03 06:35:42 -07:00
Andrew Chen
64b299ebec Merge pull request #89 from andrewgaul/is-empty 
Prefer Collection.isEmpty over size
 2011-11-03 06:34:15 -07:00
Andrew Chen
9e74f9ffcf Merge pull request #88 from andrewgaul/log-throwable 
Log Throwables instead of concatenating
 2011-11-03 06:32:20 -07:00
Andrew Chen
64e2247e8f Merge pull request #87 from andrewgaul/map-initialization 
Optimize static map, remove unneeded inner class, and use unmodifiable map.
 2011-11-03 06:31:32 -07:00
Andrew Chen
8dccc7a996 Merge pull request #86 from andrewgaul/findbugs-concatenation 
Prefer StringBuilder.append over String.concat
 2011-11-03 06:28:51 -07:00
Andrew Gaul
c2e9e4b345 Prefer Utility.combine over Account.combinedUuids 2011-11-02 22:57:06 -07:00
Andrew Gaul
b53b0d33ba Close streams on exceptional paths 
Addresses FindBugs complaints.
 2011-11-02 22:48:37 -07:00
Andrew Gaul
b1a807a712 Call IOUtils.closeQuietly where appropriate 2011-11-02 22:22:15 -07:00
Andrew Gaul
2599bdcc75 Log Throwable instead of concatenating 2011-11-02 22:18:30 -07:00
Andrew Gaul
70b635ec30 Initialize static map optimally 
Remove unneeded inner class, use unmodifiable map, and mark as static.
 2011-11-02 22:16:12 -07:00
Andrew Gaul
cb14cd9d78 Prefer StringBuilder.append over String.concat 
Addresses FindBugs complaints.
 2011-11-02 22:10:02 -07:00
Andrew Gaul
61c850e077 Remove dead stores 
Addresses FindBugs complaints.
 2011-11-02 22:02:41 -07:00
Andrew Gaul
98d0b61890 API 7 fixes 2011-11-02 20:47:48 -07:00
Andrew Gaul
647ae0a31c Prefer Collection.isEmpty over size 2011-11-02 20:03:07 -07:00
Andrew Chen
674c39f3d5 Merge pull request #80 from andrewachen/unify_gesturedetector 
Make the K9Activity.GestureDetector reusable
 2011-11-02 18:04:01 -07:00
Andrew Chen
1e9a40ffd2 Merge pull request #81 from aatdark/issue3814 
Improve handling of From: Headers without parseable email addresses (fixes 3814)
 2011-11-02 17:55:58 -07:00
Bernhard Redl
68cecb168e added testcases for address#parse function,changed empty to null (conforms to existing code) 2011-11-03 01:36:57 +01:00
Andrew Chen
763ff2752d Scroll to the last known position in the MessageView when rotating the screen. 2011-11-02 16:39:23 -07:00
Andrew Chen
b5dca5cf68 Merge pull request #76 from sunglim/string_util 
Added StringUtils.isNullOrEmpty().
 2011-11-02 10:50:52 -07:00
Andrew Chen
66881c0f2b Merge branch 'master' of git@github.com:k9mail/k-9.git 
* 'master' of git@github.com:k9mail/k-9.git:
  Optimize java.util.* imports.
 2011-11-02 08:37:12 -07:00
Andrew Chen
f884e967c9 Use MimeHeader.* constants when referring to content headers. Minor whitespace changes. 2011-11-02 08:34:06 -07:00
ashley willis
a021ab71de Override onStop() to save email as draft when activity is changed (go to home screen, call received) 2011-11-01 22:12:51 -05:00
Bernhard Redl
6a76b073c3 Improve handling of From: Headers without parseable email addresses (fixes 3814) 2011-11-02 02:08:06 +01:00
Andrew Chen
30151f1a70 Add parameter to MyGestureDetector to enable gestures for a specific detector, even if system-wide gestures are disabled. 2011-11-01 17:25:49 -07:00
Andrew Chen
edd78ea10c Make the K9Activity GestureDetector more generic so that it can be used by both MessageList and MessageView. 
Make the mTopView a ToggleScrollView.  The only consumer is currently the MessageView, which uses a ToggleScrollView anyway.  This should make it easier to reuse the anti-scrolling features in ToggleScrollView for ListView later on.
 2011-11-01 16:55:13 -07:00
Andrew Chen
406aae6e61 Optimize java.util.* imports. 
Conflicts:

	src/com/fsck/k9/mail/store/WebDavStore.java
 2011-11-01 13:54:55 -07:00
Andrew Chen
ea05f3b5d0 Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul 
* 'legacy-collections' of https://github.com/andrewgaul/k-9:
  Prefer unsynchronized Collection types
 2011-11-01 13:26:54 -07:00
Andrew Chen
186b65e523 Merge pull request #70 from andrewgaul/combine-one-element 
Optimize Utility.combine for length 1 arguments
 2011-11-01 12:51:44 -07:00
Andrew Chen
4395da270d Merge pull request #77 from andrewgaul/findbugs-entryset 
Prefer entrySet over keySet and get
 2011-11-01 12:44:26 -07:00
ashley willis
57b9321a1e issue-1424: saving duplicate or similar drafts fixed. 2011-11-01 03:02:29 -05:00
Andrew Gaul
773f2e8870 Prefer Integer.valueOf over explicit boxing 
Addresses a FindBugs complaint.
 2011-10-31 21:58:32 -07:00
Andrew Gaul
bfd11c444f Prefer entrySet over keySet and get 
Addresses FindBugs complaints.
 2011-10-31 21:42:12 -07:00
Lim Sungguk
8ab10a7586 applied StringUtils.isNullOrEmpty() 2011-10-29 15:12:49 +09:00
cketti
807907cb9e Merge branch 'master' into issue549 
Conflicts:
	res/values/strings.xml
	src/com/fsck/k9/service/MailService.java
 2011-10-29 05:22:07 +02:00
cketti
f345c33728 Removed useless try block 2011-10-29 05:10:13 +02:00
cketti
2d1f9f9c84 Reworked MailService to cut overhead when executing background tasks 
Since MailService uses the auto shutdown mode of CoreService we can't
use CoreService.execute() with a startId parameter that is null. So this
change should also fix the problem some users reported where the pushers
weren't set up correctly.

See issue 2777
 2011-10-29 05:08:37 +02:00
cketti
74f7abaec2 Cosmetic changes and documentation updates/fixes 2011-10-29 05:00:37 +02:00
cketti
987a1ea511 Merge branch 'master' of ssh://github.com/k9mail/k-9 2011-10-29 03:09:15 +02:00
cketti
7e1c19d4d8 Cosmetic changes - kill whitespace at the end of lines 2011-10-28 21:29:39 +02:00
Andrew Chen
f24d4c9155 Merge pull request #72 from andrewgaul/remove-literal 
Remove unused literal methods
 2011-10-27 23:32:28 -07:00
cketti
e3f6561008 Don't crash when trying to connect to an non-SSL service using SSL 
Fixes issue 3798
 2011-10-28 04:59:08 +02:00
Lim Sungguk
7903797080 stringutils 2011-10-28 03:50:23 +09:00
cketti
91ee21bb2d Use "String.length() == 0" instead of String.isEmpty() [API 9+] 2011-10-27 19:11:44 +02:00
cketti
b69d6cb64c Use Locale.US with toUpperCase() and toLowerCase() where appropriate 2011-10-27 17:17:43 +02:00
cketti
9327c86fe7 Use Locale.US when calling toUpperCase() on the generated MIME boundary 
Fixes issue 3733
 2011-10-27 16:52:27 +02:00
cketti
d3baa299f1 Use "reply after quoted text" value when editing drafts 2011-10-27 08:20:03 +02:00
Sven-Hendrik Haase
f4f726ae67 Fixed restoring drafts saved with "reply after quoted text" enabled 
Fixes issue 2568
 2011-10-27 07:23:01 +02:00
Andrew Chen
b6cdec43e9 Merge pull request #73 from andrewgaul/address-parse-npe 
Fix NPE in Address.Parse
 2011-10-26 18:15:40 -07:00
Andrew Gaul
ad5676ed28 Fix NPE in Address.Parse 
Found by FindBugs.  Also avoid an allocation in the uncommon case.
 2011-10-25 21:24:38 -07:00
Andrew Gaul
e394924ce4 Prefer Random.nextInt over Math.random 
Addresses a FindBugs complaint.
 2011-10-25 21:21:23 -07:00
cketti
ae465789b7 Export default value for keys not found in preference storage 2011-10-26 05:13:22 +02:00
Andrew Gaul
a2d0f9ccb7 Remove unused literal methods 2011-10-25 13:56:07 -07:00
Andrew Gaul
844db81b8d Optimize Utility.combine for length 1 arguments 2011-10-25 13:10:47 -07:00
Jesse Vincent
ae3f098b4a Merge pull request #64 from andrewgaul/typesafe-set 
Avoid type-unsafe Set
 2011-10-20 05:34:48 -07:00
Jesse Vincent
ea384b40a1 Merge pull request #66 from andrewgaul/redundant-combine-flags 
Remove duplicated combine flags code
 2011-10-20 05:33:37 -07:00
Andrew Gaul
4c5f2e59a0 Remove unused Utility.readInputStream 
Consider IOUtils.toString instead.
 2011-10-19 23:11:03 -07:00
Andrew Gaul
5b9f542bd7 Avoid type-unsafe Set 2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b Remove duplicated combine flags code 2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130 Prefer unsynchronized Collection types 2011-10-19 21:56:20 -07:00
cketti
afd355f83c Use Preferences.getAvailableAccounts() where appropriate 2011-10-18 05:09:20 +02:00
cketti
4d6946f47c Start services and list folders after account has been activated 2011-10-18 05:06:32 +02:00
cketti
dd8cd33c5a Fixed decoding of store URIs with empty passwords 2011-10-18 05:05:40 +02:00
cketti
9fa802afe2 Validate file format version and content version of settings file 2011-10-18 01:30:41 +02:00
cketti
e7ad0e296e Validate account UUID on import 2011-10-17 23:33:32 +02:00
cketti
6b5b4e474e Fixed store URI encoding/decoding in Pop3Store 2011-10-17 05:59:36 +02:00
cketti
d87e25dde1 Added new authentication methods to SmtpTransport.createUri() 2011-10-17 04:57:01 +02:00
cketti
75dc38a1c4 Added new settings to GlobalSettings 2011-10-17 04:52:33 +02:00
cketti
f08b1ef739 Added new settings to AccountSettings 2011-10-17 04:34:26 +02:00
cketti
3967654a3e Show short message when moving accounts 2011-10-17 04:34:26 +02:00
cketti
52a92d93a1 Add dialog to ask for server passwords after import 2011-10-17 04:34:26 +02:00
cketti
849a4e37a0 Mark accounts as disabled on import 
If the settings file doesn't contain passwords for the incoming and
outgoing servers we disable those accounts.
 2011-10-16 19:24:31 +02:00
cketti
fc8d2e9979 Merge branch 'master' into issue549 
Conflicts:
	res/menu/accounts_context.xml
	res/menu/accounts_option.xml
	res/values/strings.xml
	src/com/fsck/k9/Account.java
	src/com/fsck/k9/activity/Accounts.java
	src/com/fsck/k9/activity/AsyncUIProcessor.java
	src/com/fsck/k9/activity/FolderList.java
	src/com/fsck/k9/activity/ImportListener.java
	src/com/fsck/k9/activity/K9Activity.java
	src/com/fsck/k9/activity/K9ListActivity.java
	src/com/fsck/k9/activity/MessageView.java
	src/com/fsck/k9/mail/store/ImapStore.java
	src/com/fsck/k9/mail/store/Pop3Store.java
	src/com/fsck/k9/mail/store/WebDavStore.java
	src/com/fsck/k9/mail/transport/SmtpTransport.java
 2011-10-14 20:33:25 +02:00
cketti
effb45c463 Cleaned up success message after settings import 2011-10-14 06:19:30 +02:00
cketti
f5e684310e Renamed StorageImportExportException to SettingsImportExportException 2011-10-14 06:00:10 +02:00
cketti
c835bb757a Renamed StorageImporter to SettingsImporter 2011-10-14 05:58:55 +02:00
cketti
cf8bdef0a8 Renamed StorageExporter to SettingsExporter 2011-10-14 05:58:15 +02:00
cketti
0ae176bab3 Code/documentation cleanup. No functional changes. 2011-10-14 05:54:23 +02:00
cketti
470ba8bb03 Removed everything related to settings file encryption 
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
 2011-10-14 05:38:27 +02:00
cketti
fd16ff8fe6 Remove reference to NonConfigurationInstance when no longer needed 2011-10-14 04:15:45 +02:00
cketti
5b81dbc2ed Use resource strings instead of hardcoding things 2011-10-14 03:42:04 +02:00
cketti
b146fcb2fd Improved handling of object retention on configuration changes 2011-10-14 02:52:32 +02:00
cketti
b05750c245 Better input validation in *Store.createUri() 2011-10-13 02:35:08 +02:00
ashley willis
2058fc378d Option to show next message after delete by default instead of previous. 2011-10-12 17:50:24 +02:00
cketti
a258415629 Merge pull request #60 from andrewgaul/builder-append-no-concatenation 
Avoid concatenation in StringBuilder append
 2011-10-12 08:28:32 -07:00
cketti
c34d896474 Merge pull request #59 from andrewgaul/immutable-sets 
Make sets immutable
 2011-10-12 08:26:43 -07:00
Marcus Wolschon
4c8ebb4bcd added check for Null 2011-10-11 08:53:51 +02:00
cketti
7a9c747db9 Don't export incoming/outgoing server passwords 2011-10-11 03:12:18 +02:00
cketti
1de28150e2 Require accounts to at least have one identity when importing 2011-10-09 01:23:45 +02:00
cketti
13b74d0d9e Added error logging 2011-10-09 01:14:59 +02:00
cketti
d791770154 Code cleanup 2011-10-09 00:31:33 +02:00
cketti
6714a7ec5a Improved logging in StorageImporter 2011-10-09 00:04:00 +02:00
cketti
1ab7dbae54 Added input validation for folder settings 2011-10-08 21:30:45 +02:00
cketti
f21e14afc7 Added input validation for identity settings 2011-10-08 17:58:57 +02:00
cketti
060d21db3e Make collections immutable 2011-10-07 21:20:12 +02:00
cketti
0920b0c14d Changed the way SettingsDescription is used 
Added ability to rewrite the string representation used internally to
something "pretty" on export.
Now only settings that have entries is GlobalSettings and
AccountSettings are exported. This prevents export of newer settings
that are left in the preference storage when downgrading.
 2011-10-07 20:29:03 +02:00
Andrew Gaul
57be9e3ee3 Make sets immutable 
Use final and unmodifiable and avoid anonymous inner classes.
 2011-10-06 20:22:18 -07:00
Andrew Gaul
9b27aba2ba Avoid concatenation in StringBuilder append 2011-10-06 09:20:11 -07:00
cketti
2e2428b093 Merge pull request #55 from andrewgaul/stringbuilder 
Prefer StringBuilder over StringBuffer
 2011-10-06 09:04:43 -07:00
cketti
31af4526ab Merge pull request #58 from andrewgaul/spelling 
Spelling corrections
 2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d Spelling corrections 2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667 Make an inner class static 2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1 Prefer StringBuilder over StringBuffer 
The former is unsynchronized and slightly faster.
 2011-10-05 21:50:31 -07:00
cketti
83ee4253d5 Whitelist settings for export instead of blacklisting keys 
Use GlobalSettings.SETTINGS an AccountSettings.SETTINGS to decide
which settings to export.
 2011-10-04 05:13:17 +02:00
cketti
644571cfe5 Make sure the InputStream of the import file is always closed 2011-10-04 00:48:43 +02:00
cketti
f2a3752930 Added constants for (export) file format version and "settings version" 2011-10-04 00:09:38 +02:00
cketti
33ae5ff7d0 Added code to skip some account settings on export 2011-10-03 20:16:02 +02:00
cketti
0619eaf79c Catch NumberFormatException when parsing disposition size parameter 
Fixes issue 3712
 2011-10-01 21:17:00 +02:00