Commit Graph

1819 Commits

Author SHA1 Message Date
baolongnt 06ecc11ee7 Merge commit '4586ba560e3498ead43fc4eacb7a92a3ce62de75'
Merged branch issue-3060 to master: Option to hide special accounts
2011-03-06 16:53:21 -08:00
cketti 171711fa9c Remove trailing space from IMAP command
This could be the cause of the error reported in issue 3089.
2011-03-04 03:36:52 +01:00
Andrew Chen 5a22137d54 Use <pre> instead of <div> so that plain text clients get the line wrapping correct. 2011-03-02 08:17:36 -08:00
Koji Arai da34a5ec8c Avoid IllegalArgumentException for Charset.forName(null). 2011-03-02 00:59:20 +09:00
cketti 203dab5c64 Revert changes for issue 549 (import/export settings).
The feature will be polished in branch "issue549".
2011-02-28 22:55:34 +01:00
danapple 7b82061535 Add provenance explanation. 2011-02-27 22:22:09 -06:00
danapple a756f70eb6 Turn off some logging 2011-02-27 13:36:36 -06:00
danapple a7e134164f Handle pluralization of import toasts. 2011-02-27 13:35:59 -06:00
danapple 932d178679 Merge branch 'issue549'
Conflicts:
	src/com/fsck/k9/Account.java
	src/com/fsck/k9/K9.java
	src/com/fsck/k9/Preferences.java
	src/com/fsck/k9/activity/Accounts.java
	src/com/fsck/k9/activity/ActivityListener.java
	src/com/fsck/k9/activity/ChooseFolder.java
	src/com/fsck/k9/activity/FolderInfoHolder.java
	src/com/fsck/k9/activity/FolderList.java
	src/com/fsck/k9/activity/K9Activity.java
	src/com/fsck/k9/activity/K9ListActivity.java
	src/com/fsck/k9/activity/MessageList.java
	src/com/fsck/k9/activity/MessageReference.java
	src/com/fsck/k9/activity/MessageView.java
	src/com/fsck/k9/activity/setup/AccountSettings.java
	src/com/fsck/k9/controller/MessagingController.java
	src/com/fsck/k9/crypto/Apg.java
	src/com/fsck/k9/helper/DateFormatter.java
	src/com/fsck/k9/helper/DomainNameChecker.java
	src/com/fsck/k9/mail/Address.java
	src/com/fsck/k9/mail/internet/MimeHeader.java
	src/com/fsck/k9/mail/internet/MimeMessage.java
	src/com/fsck/k9/mail/internet/MimeUtility.java
	src/com/fsck/k9/mail/store/ImapStore.java
	src/com/fsck/k9/mail/store/LocalStore.java
	src/com/fsck/k9/mail/store/WebDavStore.java
	src/com/fsck/k9/mail/transport/SmtpTransport.java
	src/com/fsck/k9/view/AttachmentView.java
2011-02-27 13:09:38 -06:00
danapple 807f85d38e Astyling recent change 2011-02-27 11:10:32 -06:00
danapple f0a8d2edee Update date formatter on when importing preferences. 2011-02-26 19:28:47 -06:00
danapple ad3dd07a7a astyle-d 2011-02-26 18:39:06 -06:00
cketti 4724848a5a Merge branch 'focus_to_box' 2011-02-27 01:26:04 +01:00
cketti 766674c27c Code/comment cleanup 2011-02-26 23:04:49 +01:00
cketti 6686b3e993 Merge branch 'remove_bouncycastle_dependency' into HEAD 2011-02-26 22:59:48 +01:00
Jesse Vincent c7a3b28289 Change our technique for sending \r\n at the end of smtp commands to
deal with a weird failure on honeycomb
2011-02-26 16:53:53 -05:00
danapple 6dc94fb78e First mostly working copy of export/import. Committing while I sort
out how to use git.
2011-02-26 11:31:56 -06:00
cketti 6f90d791b5 Removed dependency on (external) commons-codec and commons-logging 2011-02-26 17:36:18 +01:00
cketti 77f4625cd9 Use SslCertificate that is part of the official Android API instead of
BouncyCastle's X509Name (which is not shipped anymore in Android 3.0)
to verify domain names on SSL/TLS connections.
2011-02-26 16:57:58 +01:00
baolongnt 457479cd43 Removed dup check (keeping the more explicit one) per cketti recommendation 2011-02-25 14:49:39 -08:00
baolongnt fce2fc12d0 Implemented option to hide special accounts (issue 3060) 2011-02-25 12:36:47 -08:00
cketti daf92a7b95 Use FLAG_ACTIVITY_NEW_TASK when starting activity
for SHOW_OR_CREATE_CONTACT.
2011-02-25 19:15:13 +01:00
cketti 397d01d513 Fix bug with partitioning of IMAP FETCH commands 2011-02-21 21:07:56 +01:00
Matt Johnston d43f17ab94 Use java.util.zip for inflating
Can't use it for deflating since it doesn't have Z_PARTIAL_FLUSH
2011-02-21 04:57:46 +08:00
Matt Johnston eb9fca69c6 Don't need to reparse addresses from database 2011-02-21 02:45:40 +08:00
cketti 0c02fb1027 Merge branch 'open-attachment' 2011-02-20 19:31:42 +01:00
cketti d354905f21 Cosmetic changes 2011-02-20 19:18:17 +01:00
cketti 5f0e51caa9 Added a comment 2011-02-20 19:02:42 +01:00
Jan Berkel 41378188f9 Updates to the view need to happen on the UI thread
Fixes downloading attachments (would just fail silently)

  Also added a ProgressDialog since progress() just asks for
  progress to displayed in the title bar. Since there is no title bar,
  no progress is shown at all.
2011-02-20 18:49:55 +01:00
Jan Berkel cc0b935b38 Performance fix: Use ListView#addFooterView to add the footer
The previous approach (generating the view in the adapter) kills performance
  because list views cannot be recycled anymore, as soon as the user scrolls to
  the bottom of the list. The Android ListView widget already provides support
  for list header/footers, so use them.
2011-02-20 17:47:06 +01:00
cketti ea590cbe39 Removed unused import + constant 2011-02-20 06:25:19 +01:00
cketti a79b7ea93c Inlined methods that were extracted to use
@SuppressWarnings("unchecked"). That's now unnecessary after the
Serializable -> Parcelable switch
2011-02-20 06:23:06 +01:00
cketti bb40049212 Remove unused imports 2011-02-20 05:31:35 +01:00
cketti ad159b3093 Merge branch 'hardcoded_outbox' into HEAD 2011-02-20 05:14:22 +01:00
cketti 737cff0612 Hardcode folder name for (local) outbox and don't show outbox when
only being allowed to select remote folders.
2011-02-20 04:47:28 +01:00
HIRANO Takahito 580d19ec17 Allow emoji input in subjects.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-02-20 10:15:50 +09:00
Jan Berkel a7a690e6ff Simplify getTextForDisplay() and fix a potential ClassCastException 2011-02-19 15:25:09 -05:00
Jan Berkel 685df0ff67 Perf improvement: use parcels instead of serializable
Standard Java serialization is slow on Android. Replacing it w/
  parcelable makes it around 10x faster (on a N1, with ~ 500 messages
  in the list).

  To avoid further confusion and potential bugs MessageReference was
  made no longer implement Serializable.
2011-02-19 15:24:53 -05:00
Koji Arai 68381d4725 Should not use double-quoted empty string.
Some host may reject such the From address.
2011-02-17 00:41:55 +09:00
wongk 5c6e86006d Support non-English Exchange installations. 2011-02-15 19:05:08 -05:00
Jesse Vincent 8a778a0222 reformatting 2011-02-14 20:45:08 -05:00
Jesse Vincent fb663508e0 remove an unused method 2011-02-14 20:44:53 -05:00
Jesse Vincent 143ca4df26 replace redundant calls with a helper 2011-02-14 20:26:00 -05:00
Jesse Vincent ea6e5e0e62 Lifting more of the "Show this message" over to the SingleMessageView 2011-02-14 13:40:49 -05:00
Jesse Vincent dc1444d1ac Rename a method that was confusingly similar to another method 2011-02-14 13:32:30 -05:00
Jesse Vincent 10da146e93 clean up unused imports 2011-02-14 13:32:25 -05:00
Jesse Vincent 5aad882976 Move the "isScreenReader" active code down into the MessageView 2011-02-14 13:32:14 -05:00
Jesse Vincent 04bc32db9e move a call to setLoadPictures down 2011-02-14 13:31:43 -05:00
Jesse Vincent 043535f7a5 Migrate a method into SingleMessageView 2011-02-14 13:31:34 -05:00
cketti e70d091433 Explicitly set focus to "To:" input field when composing or forwarding
a message.
2011-02-14 08:28:03 +01:00
Jesse Vincent 260b933a3b Move the "update the title" code from almost every single
ActivityListener callback to the superclass, removing the need for many
sublcass methods
2011-02-13 21:20:22 -05:00
Jesse Vincent 7cbbd72fac Astyle 2011-02-13 21:20:21 -05:00
Jesse Vincent 4e48366243 Remove more redundant checks 2011-02-13 21:20:21 -05:00
Jesse Vincent be106c21a1 remove completely redundant code from batch archive/spam codepaths. (It
duplicated code in the batch move codepath)
2011-02-13 21:20:21 -05:00
cketti 35f0b953c2 Merge branch 'share_extras' 2011-02-13 05:24:49 +01:00
cketti 44d2194a00 Add extra for the sender address(es) to the "Share intent" 2011-02-13 05:23:18 +01:00
unknown 42edb24c4b Merge branch 'master' of https://github.com/k9mail/k-9 2011-02-12 16:24:56 -05:00
unknown 9d0201edae Correctly verify when the user is authenticated or not. Handle "quasi-absolute" form targets during authentication. 2011-02-12 16:10:12 -05:00
Matt Johnston ae2c933181 Destroy all messages in one sqlite transaction 2011-02-11 15:30:50 -05:00
Jesse Vincent 0d0415e705 use a single layout inflater for loading attachments 2011-02-11 12:13:18 -05:00
Jesse Vincent e099337c52 remove dead code 2011-02-11 12:12:52 -05:00
Jesse Vincent 20623dc18a slight clean up to cryptoprovider view interface 2011-02-11 12:12:09 -05:00
Jesse Vincent abc921093c refactor display of the download button 2011-02-11 12:11:21 -05:00
Jesse Vincent 9deea33426 re-enable setOnFlagListener 2011-02-11 12:10:45 -05:00
Jesse Vincent 06baf3f602 simplify the "load a url for the message body" signature 2011-02-11 12:09:47 -05:00
Jesse Vincent 111b9a6305 remove a pointless indirection and an extra method call to set the
options menu when we didn't need to
2011-02-11 11:16:50 -05:00
Jesse Vincent 49b35f9236 More reshuffling toward having a reusable "Show a message" widget - what
should eventually be a Fragment.

Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
2011-02-11 10:59:31 -05:00
Jesse Vincent d634bcb381 Switch the Message view to our new SingleMessageView 2011-02-10 19:31:15 -05:00
Jesse Vincent 015baa06b4 Renamed "next" and "previous" buttons to match code style 2011-02-10 16:39:49 -05:00
Jesse Vincent fe21d6951f remove unused method 2011-02-10 16:39:49 -05:00
Jesse Vincent 98f3909ecc Split out a "clear the current message view" method 2011-02-10 14:56:56 -05:00
Jesse Vincent a3793ac651 Merge branch 'crypto-view'
* crypto-view:
  Move as much of the Apg code as possible to its own "view" class (should eventually be a fragment?)
  Bumped manifest to 3.702
2011-02-10 14:20:09 -05:00
Jesse Vincent 850aee9008 Move as much of the Apg code as possible to its own "view" class
(should eventually be a fragment?)
2011-02-10 14:02:21 -05:00
mwolschon 673b1fdf94 bugfix for
2e981afaed
( forgot a call to finish() )
2011-02-10 07:59:29 +01:00
Andrew Chen a51daf9798 Use interface Map.Entry. 2011-02-09 11:06:01 -08:00
cketti 14abb68772 Get rid of the "Fwd: " prefix when sharing a message. Add recipients
to the intent ("To:" -> EXTRA_EMAIL, "CC:" -> EXTRA_CC)
2011-02-09 07:08:10 +01:00
cketti 7e824fc748 Log error message when switching local storage provider fails. 2011-02-09 06:58:06 +01:00
Marcus Wolschon 2e981afaed if account is not ready (sd-card removed), fall through to the
"else"-case, so onItemClick -handler still gets registred.
Else inserting the SD-card without leaving the activity,
THEN clicking the account will not do anything.
2011-02-08 08:56:08 +01:00
Jesse Vincent 2aee63e242 make it possible to define Providers that don't require
username+password auth
2011-02-07 22:07:31 -05:00
Jesse Vincent 7cd99bdfd2 When some message has an Application/octet-stream .jpg attachment, be a
bit more lenient and treat it as application/octet-stream, so we can
look up the content type by file extension
2011-02-07 20:34:08 -05:00
Jesse Vincent bb1e66c70d If android's content-type lookup says "why yes, I have no idea what that
is", at least look at our local list
2011-02-07 20:33:46 -05:00
Jesse Vincent 12d1097a24 Big, scary massive "ant astyle" to get us back to something
approximating AOSP coding standards.
2011-02-06 17:09:48 -05:00
Andrew Chen cc9d6ac5ea Add button to allow editing of quoted message in HTML mode by dropping user back to text mode. Fixes issue 2959. 2011-02-05 15:14:02 -08:00
cketti d2561f19af Removed unused imports
git-svn-id: https://k9mail.googlecode.com/svn/k9mail/trunk@3270 9a7fa126-a48b-11dd-a887-7ffe1a420f8d
2011-02-04 23:19:07 -05:00
Dan Applebaum 4842051de6 Immediately update the title bar when the syncing status changes due to external events. 2011-02-04 23:19:06 -05:00
Andrew Chen 19d863ee41 Move linkification into a separate method. Linkify text in textToHtmlFragment. Fixed Issue 2951. 2011-02-04 23:19:06 -05:00
Andrew Chen 1b37fc69f6 Another potential NPE fix. 2011-02-04 23:19:06 -05:00
Dan Applebaum e31d218dc5 At Jesse's suggestion, avoid the use of the Android term-of-art "density". Instead use "Compact layouts" to refer, both internally and externally, to the feature of elminating minimum sizes on UI elements and other minor layout changes for maximizing information quantity to be displayed on a page.
Others are free to adjust the user-facing text further.
2011-02-04 23:19:06 -05:00
Andrew Chen 66f6999c53 Fix for NPE introduced in r3258. 2011-02-04 23:19:06 -05:00
Dan Applebaum 40bdf99925 Fixes Issue 2934 Fixes Issue 2935
Provides for storing Folder Settings in the central Preferences
Storage as a back-up to the settings stored on each folder.  In this
way, even if the LocalStore DB is recreated or otherwise lost, Folder
Settings can be recovered.

1) Does not change the methodology used to read settings while
running, nor the changes in r3107 & r3116 which tremendously improve
Accounts list loading time.

2) Loads Folder Settings from Preferences and stores on the folder
only when creating a new LocalFolder

3) Saves Folder Settings to Preferences and the DB row every time the
Folder Settings are changed.

4) When upgrading from DB version 41 to 42 or later, copies all
settings for existing folders from the DB storage to the Preferences
Storage.

5) Transactional bulk folder creation and single pass local folder
existence check during "Refresh folders" operation drastically reduces
time spent when refreshing folders from the remote store.

6) Uses prepared statement during Editor commit to reduce Preference
storing time.

Probably needs a reversion of r3239, but I'm unfamiliar with
translations, so am leaving that to others' discretion.
2011-02-04 23:19:06 -05:00
Dan Applebaum ea3619b733 Display a message in the titlebar when K-9 Mail is not performing any message synchronization. This state will happen when no network is available, when background ops/background data/auto-sync settings turn off synchronization, or when no account is set for polling or pushing.
This revision respects the intention of r3011 that when K-9 Mail is
set for pushing only no message is displayed, as that condition is a
normal state.  However, it provides valuable feedback in other cases
that synchronization is off-line, as was done in r1433.

Although the case when the user has intentionally set no account for
polling or pushing can be considered "normal" and therefore unworthy
of a message, it turns out to be a significant burden to detect that
situation when the network is offline, since we normally do not even
try to figure out the account configurations in that case.  Therefore,
without making substantial, otherwise unwarranted, changes to
MailService.java, "Syncing off" would be displayed sometimes to such a
user, and sometimes not.  Since it is presumably a rare case, and
there is minimal harm to display the "Syncing off" message, the
message will be consistently displayed when no account is set for
polling or pushing.

Note to translators:
"Syncing off" is different than "Polling off".  The new phrase "Syncing
off" means that K-9 Mail is not performing any synchronization with
any mail server.  The prior non-English phrases for "Polling off" are
currently in-place as translations for "Syncing off", as it seems that
the meanings are close enough that it would be better to show the
obsolete translations that to fallback to the English "Syncing off".
However, better translations of "Syncing off" would be welcome.
2011-02-04 23:19:06 -05:00
Andrew Chen 33e5520a9d Mark messages as ANSWERED only on send. Save a reference to the message in the identity so that loading a draft of a reply also marks the referenced message correctly. 2011-02-03 06:32:29 +00:00
Daniel Applebaum 6c03c968ef Provide for users with good eyesight to completely take advantage of the
"smaller" (and smaller) fonts by allowing the Accounts and Folder List
items to have a height smaller than the normal Android minimum.  This
option is off by default to maintain existing behavior for
uninterested parties.  The preferences text is not especially
compelling so could certainly be changed if better phrasing is found.
2011-02-03 03:42:45 +00:00
Andrew Chen 5fa757bba1 Only include name with an address if it's non-empty. 2011-02-03 03:35:50 +00:00
Jesse Vincent ff0f517cbb Configure MIME4J to not die when there are long header lines or a large message header 2011-02-01 20:48:20 +00:00
Kris Wong 9e5435a5f3 Fix the ability to accept invalid SSL certificates for exchange support. 2011-02-01 13:15:54 +00:00
Jesse Vincent 3d090e9626 astyle 2011-01-31 23:45:23 +00:00
Jesse Vincent 6550151684 Add serialVersionUID to Serializable classes to make eclipse happy 2011-01-31 23:45:14 +00:00
Jesse Vincent fbb62ff158 Replaced our local copy of jzlib with a clean jar built from jzlib 1.0.7
downloaded from jcraft: http://www.jcraft.com/jzlib/jzlib-1.0.7.tar.gz

Built using the following build.xml (since jzlib doesn't include one)

<project>
    <target name="clean">
        <delete dir="build"/>
    </target>
    <target name="compile">
        <mkdir dir="build/classes"/>
        <javac srcdir="com" destdir="build/classes"/>
    </target>
    <target name="jar">
        <mkdir dir="build/jar"/>
        <jar destfile="build/jar/jzlib.jar" basedir="build/classes"></jar>
    </target>
</project>
2011-01-31 18:26:01 +00:00
Jesse Vincent 4cc114c568 Replaced local version of jutf7 with a homebuilt jar from:
URL: https://jutf7.svn.sourceforge.net/svnroot/jutf7/trunk
Repository Root: https://jutf7.svn.sourceforge.net/svnroot/jutf7
Repository UUID: 1064e9db-3825-0410-a553-84549dc1c2c0
Revision: 20
Last Changed Author: jtbeetstra
Last Changed Rev: 20
Last Changed Date: 2010-04-22 11:31:16 -0400 (Thu, 22 Apr 2010)
2011-01-31 18:25:52 +00:00
Jesse Vincent 2ce5b9ed03 Replace Apache Commons IO with v2.01 downloaded from apache.org as a
prebuilt JAR
2011-01-31 18:25:26 +00:00
Jesse Vincent 7b2cd531ca Start building using a JAR of MIME4J 2011-01-31 17:19:58 +00:00
Jesse Vincent 4d5381f33d Turns out to be some code which tries to be clever about removing the
multipart envelope in LocalStore.java. It is thrown away if there is
just one item in the multipart. This breaks the display of attachment
only message, since the attachment is no longer detected by the code
which creates the view. I made a fix (see patch below) which checks if
the single item in the multipart is not a attachment.

        -- patch from wernermann29 at googlemail.com
2011-01-31 01:54:27 +00:00
Andrew Chen fe8ba6078e Propagate the ACTION_DOWN event to the ScrollView so we can stop scrolling after a fling. Fixes issue 2892. 2011-01-30 22:05:47 +00:00
Jesse Vincent 65dc3c7d1b Fix display of icon in About box on Android 2.1 and earlier 2011-01-30 15:11:16 +00:00
cketti bec094326a Make decodeQ() actually use the "fixed up" string. Will fix Q-encoded subjects where space is encoded as "_".
Fixes issue 2926
2011-01-30 03:00:46 +00:00
HIRANO Takahito 07814db9f4 Fix range check for ISO-2022-JP stream.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-29 17:56:58 +00:00
cketti 555e6431b2 Add credits for third-party libraries and emoji icons to about box 2011-01-29 02:49:39 +00:00
Kris Wong 88d0af16a5 Updated Exchange setup view. 2011-01-28 22:45:10 +00:00
Andrew Chen 13898f7edf Fix the way newlines are added in HTML mode. 2011-01-28 21:41:06 +00:00
Jesse Vincent 5e7982a31b first pass at a better about box 2011-01-28 18:30:35 +00:00
cketti a213ca2fb7 Correctly parse email addresses (from contacts). Could be of the form "User name <user@example.com>".
Fixes issue 2920
2011-01-28 06:01:10 +00:00
Jesse Vincent 4a558c5ac5 Revert the active part of "Update issue 848"
This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d.

It turns out that disabling the "View attachment" button (rather than
giving a useful error message telling the user what mime type the app
needs to support) was confusing to users.
2011-01-28 03:33:49 +00:00
Andrew Chen 840fa7bf40 Replace concatenation in StringBuilder with append. 2011-01-25 04:25:27 +00:00
Andrew Chen ba1709770e Issue 854 - Fix reply after quote in HTML mode. 2011-01-25 03:56:19 +00:00
cketti e5b172b7bb Fix warnings 2011-01-25 02:36:08 +00:00
cketti 737edf369b Use new contacts API on Android 2.0, 2.0.1, and 2.1 devices with additional code to match by phonetic names.
Fixes issue 2906
2011-01-25 02:34:02 +00:00
cketti de9f04ea0d Avoid IllegalArgumentException - Only fetch display name in getOwnerName() 2011-01-25 02:29:31 +00:00
cketti 57be868668 Added some comments 2011-01-25 01:32:31 +00:00
Marcus Wolschon ba24fdc742 update issue 2744
try all addresses of a host.
(Fix is required for proper operation in IPv4-only/IPv6-only networks
 for IPv4/IPv6 dual-stack mail-hosts)
2011-01-24 15:09:36 +00:00
Jesse Vincent 04e4dcb187 code reindenting 2011-01-24 03:27:26 +00:00
Jesse Vincent 59b3c1ba89 Extract out the list of folder columns 2011-01-24 03:27:19 +00:00
Jesse Vincent 22f422ea29 Use a heuristic to try to avoid notifying POP3 users about older mail
messages
2011-01-24 03:27:14 +00:00
Jesse Vincent 7858f72c53 Remove commented out code. that's what a version control system is for 2011-01-24 03:27:08 +00:00
Jesse Vincent 3444bb4134 Remove some duplicate code in the pop3 implementation 2011-01-24 03:26:57 +00:00
cketti 6a2233cdd0 Removed unnecessary imports 2011-01-23 13:59:15 +00:00
Jesse Vincent 24d03ce662 Deal with potential NPEs if folders aren't set up, as happens on new
accounts
2011-01-23 02:26:14 +00:00
Jesse Vincent 098851684f astyle 2011-01-23 00:56:01 +00:00
Jesse Vincent c06643bd47 Add a preference to allow users to always show email addresses instead
of the "friendly" parts of email addresses.
2011-01-23 00:55:46 +00:00
Jesse Vincent a234c39722 astyle 2011-01-19 21:33:23 +00:00
Jesse Vincent 8329a0287b Upgrade to mime4j. "0.7" branch as of
http://svn.apache.org/repos/asf/james/mime4j/trunk@1058339
2011-01-19 21:32:09 +00:00
cketti f5bb836087 Fix code that was broken when fixing warnings. 2011-01-19 21:00:28 +00:00
Andrew Chen b1d8e49d72 Be a little more graceful when scrolling horizontally in a (vertical) scroll view.
Not quite to the point of diagonal scrolling, but hopefully closer.
2011-01-19 17:05:56 +00:00
cketti bcb1131cb5 Don't rely on FolderClass implementation details outside of FolderClass 2011-01-19 01:50:28 +00:00
cketti 22834d6998 Removed unnecessary null pointer checks 2011-01-19 01:30:13 +00:00
cketti 4e11c17ff5 Removed unnecessary type cast 2011-01-19 01:28:27 +00:00
cketti 7119c7165f Removed unnecessary type casts 2011-01-19 01:21:27 +00:00
cketti 14a20843e3 Get rid of two potential null pointer access warnings 2011-01-19 00:57:12 +00:00
cketti 365b106753 Fixed warnings about unchecked casts by extracting the code to methods and using the @SuppressWarnings annotation on them. 2011-01-19 00:36:15 +00:00
cketti d48ec4892a Added missing annotation 2011-01-19 00:33:19 +00:00
cketti a9cee7a6ad Rewrote code to get rid of return statement in finally block (which generated a warning). 2011-01-19 00:23:56 +00:00
cketti 72d2d24cec Fixed potential null pointer access 2011-01-19 00:13:58 +00:00
cketti 8f2623e33c Rewrote code to be easier to read and not raise a potential null pointer warning by Eclipse. 2011-01-19 00:10:36 +00:00
cketti 6a9a5f6b1f Added a null pointer check to make the static analysis component of Eclipse happy 2011-01-19 00:00:58 +00:00
cketti 8279092070 Fixed lots of warnings (unused imports/variables, missing annotations, etc.) 2011-01-18 23:54:49 +00:00
cketti a40ec8fa98 Removed unused variables and imports. 2011-01-18 23:37:37 +00:00
Marcus Wolschon 60ea4c6ce7 Update issue 2479
possible fix for "The content of the adapter has changed but ListView did not receive a notification."
2011-01-18 15:34:41 +00:00
Jesse Vincent 951dbcbd33 Set up some reasonableish defaults when creating folders 2011-01-18 00:04:24 +00:00
Jesse Vincent 65e89afc40 remove a duplicate codepath for folder insert 2011-01-18 00:04:17 +00:00
Jesse Vincent d59600653c astyle 2011-01-18 00:04:11 +00:00
Jesse Vincent bd66315375 Visual cleanup of messageview. Clean up of icon display codepaths 2011-01-17 17:25:00 +00:00
Marcus Wolschon fc4b64c559 Update issue 848
"view" only enabled for attachments if there is an actual
application on the phone to view this kind of file.
2011-01-17 10:41:48 +00:00
Marcus Wolschon 30767c3bd9 Fixed NullPointerExceptions 2011-01-17 10:28:58 +00:00
Jesse Vincent 6504d592ea Try harder not to use "special folders" as count sources 2011-01-17 04:06:34 +00:00
Jesse Vincent 890564b926 Missed a case for stats computation 2011-01-17 03:22:30 +00:00
Jesse Vincent 30fed01784 Replace the expensive part of Account.getStats() that loaded all folders
and iterated through them with a SQL query.
2011-01-16 21:33:58 +00:00
Jesse Vincent 5a5541b400 Don't notify for new mail in a designated spam folder 2011-01-16 21:33:54 +00:00
Jesse Vincent 734cbf856d Simplify the logic for "should I search this folder" using our new
helper
2011-01-16 21:33:50 +00:00
Jesse Vincent a974f7188c Simplify folder-skip logic when cleaning out folders deleted on the
server. (Note that we no longer delete the archive folder locally, even
if it's killed upstream)
2011-01-16 21:33:46 +00:00
Jesse Vincent c5846b4202 simplify our "should we count messages in this folder" logic for the
purposes of account stats generation
2011-01-16 21:33:43 +00:00
Jesse Vincent 76e1165fea we no longer need the special version of getDisplayClass 2011-01-16 21:33:39 +00:00
Jesse Vincent 574c544d64 new helper routine for checking to see if a folder is special. 2011-01-16 21:33:34 +00:00
Jesse Vincent 5fb8b7c7e5 only do one preferences update per account when upgrading. Big perf
boost
2011-01-16 04:23:12 +00:00
Jesse Vincent 38ba071172 astyle 2011-01-16 04:23:08 +00:00
Jesse Vincent 4d0f489ab4 Initial implementation of folder attributes on the folder, rather than in preferences 2011-01-16 04:23:03 +00:00
Jesse Vincent cafa08fc6a generalize some repeated code 2011-01-16 04:22:59 +00:00
Jesse Vincent ab5c7ea6ff Refactoring of emoji transcoding code into the htmlconverter class 2011-01-15 15:25:48 +00:00
Jesse Vincent 4dcf32d2a9 Call the routine to convert emoji to images only when a message actually contains emoji.
This is to solve the performance issue repoted by jesse in Issue 2657.

Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-15 15:25:42 +00:00
Jesse Vincent 711b4763e9 Tweak our message list subject default a bit bigger to set it off from the other text. 2011-01-14 03:54:00 +00:00
Jesse Vincent aacb414004 astyle 2011-01-14 01:37:52 +00:00
Jesse Vincent 8bb7613471 Update URL regexes by importing from AOSP and then from IANA 2011-01-14 01:37:46 +00:00
Jesse Vincent d1a1b12aae Support emoji in subjects.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-14 00:53:19 +00:00
Jesse Vincent e36ead77c4 ant doesn't like the unicode symbol 2011-01-13 16:28:57 +00:00
Jesse Vincent da22ffdcea standardize the formats of our wakelock messages to be able to better audit them 2011-01-13 01:18:40 +00:00
Andrew Chen e56b044bbc Add support for HTML composition with text alternative.
Revamp K9 Identity string.
Quote names in Address only when needed.
Remove quoted text bar and move button to quoted text area.
2011-01-12 23:48:28 +00:00
Andrew Chen ed4aec26f1 Removed bogus javadoc param. 2011-01-12 06:24:00 +00:00
Andrew Chen c07c7052dc Add Notification setting to disable unread count in notification bar. 2011-01-12 01:23:17 +00:00
Andrew Chen a17c21f0cd Add null check in header view to prevent NPE. 2011-01-11 22:25:06 +00:00
cketti ba6a92b432 Removed unnecessary import. 2011-01-11 03:49:11 +00:00
cketti a03f75dd5e Updated javadoc comment 2011-01-11 03:48:30 +00:00
cketti 3aba9e11ae Code/comment cleanup 2011-01-11 03:40:43 +00:00
cketti d403e36f06 Don't count on skip() to actually skip as many bytes as requested. 2011-01-11 03:27:58 +00:00
cketti c7a7d832e7 Better handle the case where a list in an IMAP response is prematurely ended by CRLF.
Fixes issue 2852
2011-01-11 03:10:24 +00:00
Andrew Chen b4635e53b5 When editing a draft, only show the BCC field if it has entries other than the auto-bcc for that account.
This makes draft editing behavior the same as new composition.
2011-01-11 02:49:00 +00:00
Andrew Chen e19f742678 Consolidate exception catching in processSourceMessage into a single try/catch block.
Add error logging if we do have an exception.
2011-01-10 20:12:08 +00:00
Jesse Vincent 9d5704c0f5 Split the Header view out from the MessageView activity 2011-01-10 17:47:28 +00:00
Jesse Vincent 052695af83 Simplify Contacts API 2011-01-10 17:47:23 +00:00
Jesse Vincent 0ca6adfbf8 move DateFormatter from Activity to Helper 2011-01-10 17:47:16 +00:00
Andrew Chen 5fe33f2c62 remove dead isInUse code. 2011-01-07 21:41:27 +00:00
Jesse Vincent b2c44579d2 lift "displayMessage" out of a callback 2011-01-06 16:56:55 +00:00
Jesse Vincent 39ef6584a8 continue to extract attachment code out to AttachmentView 2011-01-06 16:56:37 +00:00
Jesse Vincent 19c5324316 Extract AttachmentView and MediaScannerNotifier into their own classes 2011-01-06 16:56:20 +00:00
Jesse Vincent ed60cdfa5a replace constant lookups of the MessagingController instance with a locally cached one 2011-01-06 16:56:02 +00:00
Jesse Vincent 299c057cd4 minor code cleanup 2011-01-06 16:55:48 +00:00
Jesse Vincent 9c847d3e9d minor code cleanup 2011-01-06 16:55:34 +00:00
Jesse Vincent de806f7715 astyle 2011-01-06 16:55:08 +00:00
Andrew Chen aa0eeac736 Show the correct quote style options at preference load time. 2011-01-06 07:05:57 +00:00
Andrew Chen f9ddc7eb06 Remove extraneous colon. 2011-01-06 01:34:08 +00:00
Andrew Chen 74e6384236 Fix potential NPE. 2011-01-06 01:31:28 +00:00
cketti f9f6160719 Correctly encode/escape strings when used in IMAP commands.
Fixes issue 2832
2011-01-06 00:39:09 +00:00
Andrew Chen 5fef7f3b07 Add support for Outlook-style quote headers as a preference under Account Settings -> Sending Mail.
Refactor forwarding header (header-style quote header) into individual string pieces that are assembled in code to accommodate future HTML version of headers.
Introduced four new strings for translation.
2011-01-05 23:58:14 +00:00
Jesse Vincent 9f4790088e Escape backslashes in IMAP mailbox names 2011-01-05 13:12:30 +00:00
Andrew Chen ead632aac6 Refactor html/text conversions into its own class.
Add more tags to be ignored during HTML to plain text conversion.
Remove UTF-8 non-breaking spaces from generated text.
2011-01-05 04:26:33 +00:00
Jesse Vincent f8f916edde Make contacts searchable from phonetic names on Eclair and earlier.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-04 14:33:02 +00:00
Jesse Vincent 2daf8eaec8 Allow emoji input.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-04 13:25:59 +00:00
Jesse Vincent d25f12fa16 Switch K-9 from generating X-User-Agent to User-Agent headers.
Fixes issue 1917
2011-01-04 08:33:12 +00:00
Andrew Chen f3e75d564a Add custom HTML tag handler to be used when converting HTML to Text.
Hides code in STYLE and SCRIPT tags and adds text-equivalent of HR.
2011-01-04 06:58:13 +00:00
Jesse Vincent 40344aea41 support iPad mail too 2011-01-03 18:12:35 +00:00
Jesse Vincent 0a8514888e Map emoji code points defined by mobile carriers to ones defined by
Google in order to support various carriers. Patch by HIRANO Takahito
<hiranotaka@zng.info>
2011-01-03 18:07:44 +00:00
Andrew Chen 68ded8aa3e Add some more documentation about temporary notification avoidance code using UIDs. 2011-01-03 03:26:31 +00:00
Andrew Chen e794af0bbf Prevent new mail notifications if they're older than our most recent message.
First attempt at fixing Issue 1276.  Only works with services that use numeric message IDs, like IMAP.
2011-01-02 09:01:23 +00:00
cketti fe724c8c79 Changed SMTP code to handle reply codes without additional text.
Fixes issue 2801
2011-01-01 18:45:33 +00:00
Andrew Chen 731ea27a24 Minor formatting cleanup. 2010-12-31 08:56:05 +00:00
Jesse Vincent 29fdb81f9b Fix for the "K9 skips every 101st message when fetching on IMAP" bug by
e-t172 <e-t172@akegroup.org>. Fixes Issue 2819
2010-12-30 23:57:41 +00:00
Fiouz 47762a9baa Remove coupling between ImapStore and ImapConnection by adding an settings indirection interface. Purpose: use the IMAP connection code to validate credentials without having an actual ImapStore instance. 2010-12-30 21:57:59 +00:00
cketti a1e059e871 Introduced setting to change the font size of the message preview in the message list.
Fixes issue 2788
2010-12-30 00:52:00 +00:00
Andrew Chen 605a0bdc93 Add more comments about LocalTextBody.
Display decrypted PGP data as text/plain (content type was being set, but not being passed to WebViews).
2010-12-29 07:34:57 +00:00
Andrew Chen b85f0b64c0 Fix javadoc; make constant all caps. 2010-12-29 07:17:43 +00:00
cketti cb97c312fc Move ColorChip to the correct directory 2010-12-28 23:37:47 +00:00
Jesse Vincent 777f75b5c4 Stop showing "Not polling" in the status header. Most of the time, this
is because we're pushing.
2010-12-28 09:12:02 +00:00
Jesse Vincent 8bc984f440 APG-related messageview bugfixes 2010-12-28 09:11:35 +00:00
Jesse Vincent 0c426c9c4b Round our color chips, clean up color hcip rendering a bit 2010-12-28 09:11:10 +00:00
Jesse Vincent 4c9c478d8d minor code and doc cleanups as recommended by IntelliJ 2010-12-28 09:10:50 +00:00
Jesse Vincent bbf65f1335 remove temporary variables 2010-12-28 09:10:30 +00:00
Jesse Vincent b166cf03e8 split apart attachment view creation a bit 2010-12-28 09:09:52 +00:00
Jesse Vincent 3c9eb2c004 Further refactoring of message display 2010-12-28 09:09:33 +00:00
Jesse Vincent 9fe56831bf finish removing setHeaders as a layer of indirection 2010-12-28 09:09:15 +00:00
Jesse Vincent 8116a0f39f lift some gpg code into the crypto initializer 2010-12-28 09:08:58 +00:00
Jesse Vincent 3ffa28fa02 we import so we don't need to qualify 2010-12-28 09:08:40 +00:00
Jesse Vincent 85a7a08e9a Rename our attachment view holder from Attachment to AttachmentViewHolder 2010-12-28 09:08:18 +00:00
Jesse Vincent 6a04afb758 extract "does it have html images" out of MessageView. really, it should
end up in LocalMessage somewhere
2010-12-28 09:07:59 +00:00
Jesse Vincent 7623a02852 lift the "get display text" code out of the messageview and into
localmessage
2010-12-28 09:07:39 +00:00
Jesse Vincent 84f6e546d2 setLoadPictures sets mShowPictures. We don't need to set it again 2010-12-28 09:07:19 +00:00
Jesse Vincent f292251b78 lift createUniqueFile to a Utility class 2010-12-28 09:06:57 +00:00
Jesse Vincent 570dbf7126 split apart onCreate into bite-sized pieces 2010-12-26 03:51:33 +00:00
Jesse Vincent 43e3e860f8 doc fix 2010-12-26 03:49:52 +00:00
Jesse Vincent d352b8a4a5 whitespace 2010-12-26 03:49:23 +00:00
Jesse Vincent f2b2fddd5a onRefile removes code duplication 2010-12-26 03:49:20 +00:00
Jesse Vincent db02383d4a whitespace cleanups 2010-12-26 03:49:16 +00:00
Jesse Vincent 8488b55e09 remove some duplicated code 2010-12-26 03:49:13 +00:00
Jesse Vincent 8c6df94739 remove some temp variables 2010-12-26 03:49:09 +00:00
Jesse Vincent 877427f110 cut down a couple overly verbose conditionals 2010-12-26 03:49:06 +00:00
Jesse Vincent daf5a9d704 lift emulateShiftHeld to our custom WebView subclass 2010-12-25 22:30:34 +00:00
Jesse Vincent 8e2e4e515f simplify MessageView's setHeaders 2010-12-25 22:30:31 +00:00
Jesse Vincent 8b52aac135 remove unused imports 2010-12-25 22:30:27 +00:00
Jesse Vincent 76fd8e9939 extract animation code from MessageView 2010-12-25 22:30:22 +00:00
Jesse Vincent 5f9eae1580 Extract MessageWebView specific code into a new class 2010-12-25 22:30:16 +00:00
Jesse Vincent ea4e0aa61f remove a bunch of extraneous code and variables 2010-12-25 19:29:02 +00:00
Jesse Vincent 9f24ea2b03 minor code cleanup 2010-12-25 19:28:58 +00:00
Jesse Vincent 91ab617807 rename "hide buttons" to "scroll buttons" because that's what it does 2010-12-25 19:28:54 +00:00